On Tue, Aug 31, 2021 at 9:35 PM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> This function should be made stable now.
>
> Also, fix the docbook comment format.
>
> Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value")
> Cc: konstantin.anan...@intel.com
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> lib/mbuf/rte_mbuf.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 7722b36ee44b..627790fe26e7 100644
> --- a/lib/mbuf/rte_mbuf.h
> +++ b/lib/mbuf/rte_mbuf.h
> @@ -1773,7 +1773,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf
> *head, struct rte_mbuf *tail
> return 0;
> }
>
> -/*
> +/**
> * @warning
> * @b EXPERIMENTAL: This API may change without prior notice.
> *
> @@ -1797,6 +1797,7 @@ static inline int rte_pktmbuf_chain(struct rte_mbuf
> *head, struct rte_mbuf *tail
> * @return
> * raw tx_offload value.
> */
> +__rte_experimental
>From title and description, I would expect we remove
__rte_experimental tag, not add one.
Can you clarify the intention?
> static __rte_always_inline uint64_t
> rte_mbuf_tx_offload(uint64_t il2, uint64_t il3, uint64_t il4, uint64_t tso,
> uint64_t ol3, uint64_t ol2, uint64_t unused)
> --
> 2.30.2
>
--
David Marchand
