Re: [dpdk-dev] [PATCH] lpm6: Fix missing ^ in documentation.

2021-09-14 Thread David Marchand
On Mon, Sep 13, 2021 at 8:47 PM Ben Pfaff wrote: > This is probably due to conversion from ms word to rst format. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: sta...@dpdk.org > Signed-off-by: Ben Pfaff Reviewed-by: David Marchand -- David Marchand

Re: [dpdk-dev] [PATCH] efd: change data type of parameter

2021-09-14 Thread David Marchand
On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara wrote: > > rte_efd_create() function was using uint8_t for a socket bitmask, > for one of its parameters. > This limits the maximum of NUMA sockets to be 8. > Changing to to uint64_t increases it to 64, which should be > more future-proof. Cc: ppc mai

[dpdk-dev] [PATCH v1] eventdev: update rx timestamp in mbuf using mbuf dynamic field

2021-09-14 Thread Ganapati Kundapura
Add support to register timestamp dynamic field in mbuf. Update the timestamp in mbuf for each packet before enqueuing to event device if the timestamp is not already set. Adding the timestamp in Rx adapter avoids additional latency due to the event device. Signed-off-by: Ganapati Kundapura ---

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update

2021-09-14 Thread Nélio Laranjeiro
+Shahaf, Hi Maxime, On Mon, Sep 13, 2021 at 11:41:04AM +0200, Maxime Coquelin wrote: > Hi Nélio, > > On 9/10/21 4:16 PM, Nélio Laranjeiro wrote: > > On Fri, Sep 10, 2021 at 01:06:53PM +0300, Andrew Rybchenko wrote: > >> On 9/10/21 12:57 PM, Maxime Coquelin wrote: > >>> > >>> > >>> On 9/10/21 11:

Re: [dpdk-dev] [PATCH] net/virtio: remove handling of zero desc number on RxQ setup

2021-09-14 Thread Maxime Coquelin
On 9/14/21 8:40 AM, Andrew Rybchenko wrote: > On 9/13/21 10:25 PM, Maxime Coquelin wrote: >> >> >> On 8/20/21 2:47 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Rx queue setup callback allows to use the whole ring when >>> descriptor number argument equals zero. There's no point t

Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align desc limits in dev info get

2021-09-14 Thread Maxime Coquelin
On 9/14/21 8:43 AM, Andrew Rybchenko wrote: > On 9/13/21 10:52 PM, Maxime Coquelin wrote: >> >> >> On 8/20/21 2:48 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Report max/min/align descriptors limits in device info get callback. >>> Before calling the callback, rte_eth_dev_info_g

Re: [dpdk-dev] [PATCH] net/virtio: remove handling of zero desc number on RxQ setup

2021-09-14 Thread Andrew Rybchenko
On 9/14/21 10:26 AM, Maxime Coquelin wrote: > > > On 9/14/21 8:40 AM, Andrew Rybchenko wrote: >> On 9/13/21 10:25 PM, Maxime Coquelin wrote: >>> >>> >>> On 8/20/21 2:47 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Rx queue setup callback allows to use the whole ring when d

Re: [dpdk-dev] [PATCH v8] doc: add release milestones definition

2021-09-14 Thread Thomas Monjalon
03/09/2021 17:35, Ferruh Yigit: > On 9/3/2021 12:50 PM, Thomas Monjalon wrote: > > 02/09/2021 18:33, Ferruh Yigit: > >> On 8/26/2021 11:11 AM, Thomas Monjalon wrote: > >>> +* Any issue found in -rc1 should be fixed. > >>> + > >>> +rc3 > >>> +~~~ > >>> + > >>> +* Priority: applications. No applicati

[dpdk-dev] [PATCH v9] doc: add release milestones definition

2021-09-14 Thread Thomas Monjalon
From: Asaf Penso Adding more information about the release milestones. This includes the scope of change, expectations, etc. Signed-off-by: Asaf Penso Signed-off-by: Thomas Monjalon Acked-by: John McNamara Acked-by: Ajit Khaparde Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- v2

Re: [dpdk-dev] [PATCH] app/testpmd: Document what the application does.

2021-09-14 Thread Ferruh Yigit
On 9/10/2021 6:57 PM, Ben Pfaff wrote: > I could not find anything in the documentation that says what > testpmd does. This should save other people time trying to > figure that out in the future. > > Signed-off-by: Ben Pfaff > --- > doc/guides/testpmd_app_ug/run_app.rst | 6 ++ > 1 file ch

Re: [dpdk-dev] [PATCH v2] app/testpmd: Document what the application does.

2021-09-14 Thread Ferruh Yigit
On 9/13/2021 7:33 PM, Ben Pfaff wrote: > I could not find anything in the documentation that says what > testpmd does. This should save other people time trying to > figure that out in the future. > > Signed-off-by: Ben Pfaff > --- > v1->v2: Revise introduction instead of option documentation. >

Re: [dpdk-dev] [PATCH 8/8] bus/pci: remove ABIs in PCI bus

2021-09-14 Thread Xu, Rosen
> -Original Message- > From: Xia, Chenbo > Sent: Friday, September 10, 2021 10:24 > To: dev@dpdk.org > Cc: Chautru, Nicolas ; Yigit, Ferruh > ; Burakov, Anatoly ; > Ray Kinsella ; Nithin Dabilpuram > ; Kiran Kumar K ; > Sunil Kumar Kori ; Satha Rao > ; Matan Azrad ; Shahaf > Shuler ; Vi

Re: [dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

2021-09-14 Thread Maxime Coquelin
Hi Stehpen, On 9/13/21 6:10 PM, Stephen Hemminger wrote: > Yet another spelling error found by codespell. > > Signed-off-by: Stephen Hemminger > --- > lib/vhost/rte_vhost.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.

Re: [dpdk-dev] [PATCH v2 1/2] net/virtio: reconfigure LSC handler when required

2021-09-14 Thread Maxime Coquelin
On 8/31/21 5:54 PM, David Marchand wrote: > There is no reason to re-register a interrupt handler for LSC if this > feature was not requested in the first place. > A simple usecase is when asking for Rx interrupts without LSC interrupt. > > Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue inter

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: fix virtio-user Rx interrupts with multi queue

2021-09-14 Thread Maxime Coquelin
On 8/31/21 5:54 PM, David Marchand wrote: > The callfds[] array stores eventfds sequentially for Rx and Tx vq. > > Fixes: 3d4fb6fd2505 ("net/virtio-user: support Rx interrupt") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c |

[dpdk-dev] [PATCH v1 0/2] fix RSS configuration failure

2021-09-14 Thread Wenjun Wu
Due to share code limitation, independent configuration of default RSS for IP fragment packets need to be removed. Wenjun Wu (2): net/ice: fix RSS configuration failure net/iavf: fix RSS configuration failure drivers/net/iavf/iavf_hash.c | 10 -- drivers/net/ice/ice_ethdev.c | 22 +--

[dpdk-dev] [PATCH v1 1/2] net/ice: fix RSS configuration failure

2021-09-14 Thread Wenjun Wu
Due to share code limitation, when RSS for IP packets and IP fragment packets coexists, they cannot share the same hash field. As a result, independent configuration of default RSS for IP fragment packets need to be removed. This patch revert the original patch to fix this failure. Fixes: 91f5935

[dpdk-dev] [PATCH v1 2/2] net/iavf: fix RSS configuration failure

2021-09-14 Thread Wenjun Wu
Due to share code limitation, when RSS for IP packets and IP fragment packets coexists, they cannot share the same hash field. As a result, independent configuration of default RSS for IP fragment packets need to be removed. This patch revert the original patch to fix this failure. Fixes: c405255

Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings

2021-09-14 Thread Ferruh Yigit
On 9/3/2021 12:53 AM, David Christensen wrote: > Suppress the gcc warning "note: the layout of aggregates containing > vectors with 4-byte alignment has changed in GCC 5" on POWER systems > by setting "-Wno-psabi". Warning was originally added to gcc in > commit https://gcc.gnu.org/git/gitweb.cgi?

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-14 Thread David Hunt
On 10/9/2021 9:24 AM, Thomas Monjalon wrote: 10/09/2021 10:06, David Marchand: On Fri, Sep 10, 2021 at 9:54 AM Bruce Richardson wrote: On Fri, Sep 10, 2021 at 08:51:04AM +0200, David Marchand wrote: On Thu, Sep 9, 2021 at 4:38 PM Bruce Richardson wrote: On Thu, Sep 09, 2021 at 02:45:06PM

[dpdk-dev] [RFC PATCH 00/10] Support MLX5 crypto driver on Windows

2021-09-14 Thread Tal Shnaiderman
Support the MLX5 crypto driver on Windows OS by moving the driver's control path communication with the Kernel to be OS agnostic. --- Depends-on: patch 98796 ("cryptodev: build on Windows") --- Tal Shnaiderman (10): common/mlx5: add DV enums to Windows defs file common/mlx5: add an agnostic OS

[dpdk-dev] [RFC PATCH 02/10] common/mlx5: add an agnostic OS function to open device context

2021-09-14 Thread Tal Shnaiderman
Add a function to open device context from a rte_device. Function mlx5_os_open_device_context can be used both on Windows and Linux OS. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/linux/mlx5_common_os.c | 28 +++ drivers/common/mlx5/mlx5_common.h| 4 + drivers/co

[dpdk-dev] [RFC PATCH 01/10] common/mlx5: add DV enums to Windows defs file

2021-09-14 Thread Tal Shnaiderman
Add needed DV enums used by the crypto PMD and missing for Windows OS. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/windows/mlx5_win_defs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers/common/mlx5/windows/mlx5_

[dpdk-dev] [RFC PATCH 08/10] crypto/mlx5: use OS agnostic functions for Verbs operations

2021-09-14 Thread Tal Shnaiderman
use the functions mlx5_os_open_device_context, mlx5_os_get_ctx_device_name mlx5_os_reg_mr mlx5_os_dereg_mr instead of the ib verbs functions and variables to support device operations on all OSs. Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 41 +-

[dpdk-dev] [RFC PATCH 04/10] common/mlx5: add memory region OS agnostic functions for Linux

2021-09-14 Thread Tal Shnaiderman
The OS agnostic functions for memory region registration/deregistration (mlx5_os_reg_mr mlx5_os_dereg_mr) exist only for Windows OS. Adding them for Linux as well as they are needed for memory region activities in shared code. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/linux/mlx5_co

[dpdk-dev] [RFC PATCH 05/10] crypto/mlx5: replace UNIX functions with EAL functions

2021-09-14 Thread Tal Shnaiderman
Use the OS agnostic EAL function rte_mem_page_size to get page size value instead of the Linux specific implementation. Also remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman --- drivers/crypto

[dpdk-dev] [RFC PATCH 10/10] crypto/mlx5: support on Windows

2021-09-14 Thread Tal Shnaiderman
Add support for mlx5 crypto pmd on Windows OS. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/version.map | 2 +- drivers/crypto/aesni_gcm/meson.build | 6 ++ drivers/crypto/aesni_mb/meson.build | 6 ++ drivers/crypto/armv8/meson.build | 6 ++ drivers/crypto/bcmfs/m

[dpdk-dev] [RFC PATCH 03/10] common/mlx5: move pdn getter to common driver

2021-09-14 Thread Tal Shnaiderman
Move to common and export the function mlx5_os_get_pdn. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/linux/mlx5_common_os.c | 35 drivers/common/mlx5/mlx5_common.h| 4 drivers/common/mlx5/version.map | 1 + drivers/common/m

[dpdk-dev] [RFC PATCH 07/10] crypto/mlx5: use OS agnostic functions for PD operations

2021-09-14 Thread Tal Shnaiderman
use the functions mlx5_os_alloc_pd, mlx5_os_dealloc_pd mlx5_os_get_pdn instead of the glue functions to support PD operations on all OSs. Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 15 ++- drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2 files changed, 7 inser

[dpdk-dev] [RFC PATCH 06/10] crypto/mlx5: use OS agnostic functions for UMEM operations

2021-09-14 Thread Tal Shnaiderman
use the functions mlx5_os_umem_reg, mlx5_os_umem_dereg mlx5_os_get_umem_id instead of the glue functions to support UMEM operations on all OSs. Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 14 +++--- drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2 files changed, 8

[dpdk-dev] [RFC PATCH 09/10] crypto/mlx5: fix size of UMR WQE

2021-09-14 Thread Tal Shnaiderman
The size of the UMR WQE allocated object is decided by a sizof operation on the struct, however since the struct contains a union of flexible array members this sizeof results can differ between compilers. GCC for example treats the union as 0 sized, MSVC adds a padding of 16Bits. To resolve the

Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align desc limits in dev info get

2021-09-14 Thread Maxime Coquelin
On 8/20/21 2:48 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Report max/min/align descriptors limits in device info get callback. > Before calling the callback, rte_eth_dev_info_get() provides > default values of nb_min as zero and nb_max as UINT16_MAX that are > not correct for the d

[dpdk-dev] [RFC v2] vhost: add support async dequeue for packed ring

2021-09-14 Thread Cheng Jiang
This patch implements asynchronous dequeue data path for packed ring. Signed-off-by: Cheng Jiang --- It's based on these 2 patches: 1. vhost: remove copy threshold for async vhost http://patches.dpdk.org/project/dpdk/patch/1629463466-450012-1-git-send-email-jiayu...@intel.com/ 2. vhost: support a

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-14 Thread David Marchand
On Tue, Sep 14, 2021 at 11:34 AM David Hunt wrote: > > > On 10/9/2021 9:24 AM, Thomas Monjalon wrote: > > 10/09/2021 10:06, David Marchand: > >> On Fri, Sep 10, 2021 at 9:54 AM Bruce Richardson > >> wrote: > >>> On Fri, Sep 10, 2021 at 08:51:04AM +0200, David Marchand wrote: > On Thu, Sep 9,

Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings

2021-09-14 Thread David Marchand
On Tue, Sep 14, 2021 at 11:18 AM Ferruh Yigit wrote: > > On 9/3/2021 12:53 AM, David Christensen wrote: > > Suppress the gcc warning "note: the layout of aggregates containing > > vectors with 4-byte alignment has changed in GCC 5" on POWER systems > > by setting "-Wno-psabi". Warning was origina

Re: [dpdk-dev] [PATCH v2] config/ppc: ignore gcc 11 psabi warnings

2021-09-14 Thread Bruce Richardson
On Tue, Sep 14, 2021 at 12:16:36PM +0200, David Marchand wrote: > On Tue, Sep 14, 2021 at 11:18 AM Ferruh Yigit wrote: > > > > On 9/3/2021 12:53 AM, David Christensen wrote: > > > Suppress the gcc warning "note: the layout of aggregates containing > > > vectors with 4-byte alignment has changed in

Re: [dpdk-dev] [RFC] Control packet event adapter and FIFO library

2021-09-14 Thread Kaladi, Ashok K
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Thursday, September 2, 2021 12:20 PM > To: Kaladi, Ashok K > Cc: Harman Kalra ; Nithin Dabilpuram > ; Yigit, Ferruh ; > Burakov, Anatoly ; Richardson, Bruce > ; Ananyev, Konstantin > ; Thomas Monjalon > ; David Marchand ; > jer.

Re: [dpdk-dev] [PATCH] efd: change data type of parameter

2021-09-14 Thread Kinsella, Ray
On 14/09/2021 08:10, David Marchand wrote: > On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara > wrote: >> >> rte_efd_create() function was using uint8_t for a socket bitmask, >> for one of its parameters. >> This limits the maximum of NUMA sockets to be 8. >> Changing to to uint64_t increases it t

Re: [dpdk-dev] [PATCH] net/virtio: fix device configure without jumbo Rx offload

2021-09-14 Thread Maxime Coquelin
On 9/2/21 4:39 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Use max-pkt-len only if jumbo frames offload is requested > since otherwise this field isn't valid. > > Fixes: 8b90e4358112 ("net/virtio: set offload flag for jumbo frames") > Fixes: 4e8169eb0d2d ("net/virtio: fix Rx scatter

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-14 Thread David Hunt
On 14/9/2021 11:00 AM, David Marchand wrote: On Tue, Sep 14, 2021 at 11:34 AM David Hunt wrote: On 10/9/2021 9:24 AM, Thomas Monjalon wrote: 10/09/2021 10:06, David Marchand: On Fri, Sep 10, 2021 at 9:54 AM Bruce Richardson wrote: On Fri, Sep 10, 2021 at 08:51:04AM +0200, David Marchand

Re: [dpdk-dev] [PATCH] net/virtio: fix device configure without jumbo Rx offload

2021-09-14 Thread Andrew Rybchenko
On 9/14/21 2:07 PM, Maxime Coquelin wrote: > > > On 9/2/21 4:39 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Use max-pkt-len only if jumbo frames offload is requested >> since otherwise this field isn't valid. >> >> Fixes: 8b90e4358112 ("net/virtio: set offload flag for jumbo frames"

Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost

2021-09-14 Thread Maxime Coquelin
On 8/20/21 2:44 PM, Jiayu Hu wrote: > Copy threshold is introduced in async vhost data path to select > the appropriate copy engine to do copies for higher efficiency. > However, it may cause packets out-of-order, and it also causes > data path performance unpredictable. > > Therefore, this pat

Re: [dpdk-dev] [PATCH] net/virtio: remove handling of zero desc number on RxQ setup

2021-09-14 Thread Maxime Coquelin
On 8/20/21 2:47 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Rx queue setup callback allows to use the whole ring when > descriptor number argument equals zero. There's no point to > handle zero in any way since RTE Rx queue setup function > rte_eth_rx_queue_setup() doesn't pass zero

Re: [dpdk-dev] [PATCH] net/virtio: fix reporting of mbufs allocated on RxQ setup

2021-09-14 Thread Maxime Coquelin
On 8/20/21 2:47 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Rx queue setup finish function may report wrong number of > allocated mbufs in case of in-order feature. Fix the > function to not ignore allocation error and count only > successfully allocated number of buffers. > > Fixes

Re: [dpdk-dev] [PATCH] net/virtio: turn SW RxQ size to that of split vec. virtqueue

2021-09-14 Thread Maxime Coquelin
On 8/20/21 2:47 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Descriptors number may be set less than queue size for split queue > vectorized Rx path. Pointers to mbufs for received packets are > obtained from SW ring, that is initially filled with them in the end > of queue setup in v

Re: [dpdk-dev] [PATCH] net/virtio: report max/min/align desc limits in dev info get

2021-09-14 Thread Maxime Coquelin
On 8/20/21 2:48 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Report max/min/align descriptors limits in device info get callback. > Before calling the callback, rte_eth_dev_info_get() provides > default values of nb_min as zero and nb_max as UINT16_MAX that are > not correct for the d

Re: [dpdk-dev] [PATCH v4] net/virtio: fix repeated memory free of vq

2021-09-14 Thread Maxime Coquelin
On 8/31/21 4:39 PM, Gaoxiang Liu wrote: > When virtio_init_queue returns error, the memory of vq is freed. > But the value of hw->vqs[queue_idx] does not restore. > If virtio_init_queue returns error, the memory of vq is freed again > in virtio_free_queues. > > Fixes: 69c80d4ef89b ("net/virtio:

Re: [dpdk-dev] [PATCH v2 0/2] virtio-user interrupt fixes

2021-09-14 Thread Maxime Coquelin
On 8/31/21 5:54 PM, David Marchand wrote: > Trying to use virtio-user as a replacement for taps in OVS, I ended up > with some fixes on the interrupt side. > The patches for OVS are not ready yet, but sending the DPDK fixes in > any case. > > @CI guys: > Patch 2 probably means there is a hole i

Re: [dpdk-dev] [PATCH] net/virtio: fix device configure without jumbo Rx offload

2021-09-14 Thread Maxime Coquelin
On 9/2/21 4:39 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Use max-pkt-len only if jumbo frames offload is requested > since otherwise this field isn't valid. > > Fixes: 8b90e4358112 ("net/virtio: set offload flag for jumbo frames") > Fixes: 4e8169eb0d2d ("net/virtio: fix Rx scatter

Re: [dpdk-dev] [PATCH] net/virtio: fix device configure without jumbo Rx offload

2021-09-14 Thread Maxime Coquelin
On 9/14/21 1:17 PM, Andrew Rybchenko wrote: > On 9/14/21 2:07 PM, Maxime Coquelin wrote: >> >> >> On 9/2/21 4:39 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Use max-pkt-len only if jumbo frames offload is requested >>> since otherwise this field isn't valid. >>> >>> Fixes: 8b90e

Re: [dpdk-dev] [PATCH v7] vhost: fix crash on port deletion

2021-09-14 Thread Maxime Coquelin
On 9/2/21 5:45 PM, Gaoxiang Liu wrote: > The rte_vhost_driver_unregister() and vhost_user_read_cb() > can be called at the same time by 2 threads. > when memory of vsocket is freed in rte_vhost_driver_unregister(), > the invalid memory of vsocket is accessed in vhost_user_read_cb(). > It's a bug

Re: [dpdk-dev] [PATCH] vhost: promote some APIs to stable

2021-09-14 Thread Maxime Coquelin
On 9/7/21 4:58 AM, Chenbo Xia wrote: > As reported by symbol bot, APIs listed in this patch have been > experimental for more than two years. This patch promotes these > 18 APIs to stable. > > Signed-off-by: Chenbo Xia > --- > lib/vhost/rte_vhost.h| 13 - > lib/vhost/rte_v

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-14 Thread David Marchand
On Tue, Sep 14, 2021 at 1:07 PM David Hunt wrote: > >> “ERROR: logical core 212 is above the maximum lcore number permitted. > >> Please use the --lcores option to map lcores onto physical cores, e.g. > >> --lcores="(0-3)@(212-215).” > > If you could directly provide the right --lcores syntax base

Re: [dpdk-dev] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-14 Thread Maxime Coquelin
On 9/7/21 2:51 AM, Gaoxiang Liu wrote: > Add log print of socket path in vhost_user_add_connection. > It's useful when adding a mass of socket connections, > because the information of every connection is clearer. > > Fixes: 8f972312b8f4 ("vhost: support vhost-user") > Cc: sta...@dpdk.org > >

[dpdk-dev] DPDK 21.11 NVIDIA Mellanox Roadmap

2021-09-14 Thread Shy Shyman
Below is NVIDIA Mellanox's roadmap for DPDK21.11, on which we are currently working: ethdev new APIs: === [1] Introduce an optimization in memory/performance for the case of scaled-up interfaces. Motivation: An application (e.g. OVS) polls all representors que

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

2021-09-14 Thread John Levon
On Tue, Sep 14, 2021 at 01:34:54PM +0300, Dmitry Kozlyuk wrote: > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > using handcraft parsing of /proc/mounts and mixing traversal logic with > selecting the needed entry. Separate code to enumerate hugetlbfs mounts > to eal_hu

Re: [dpdk-dev] Questions about rte_eth_link_speed_to_str API

2021-09-14 Thread Min Hu (Connor)
Thanks Stephen, While I think this option is more clear and simple: +const char * +rte_eth_link_speed_to_str(uint32_t link_speed) +{ +#define SPEED_STRING_LEN 16 + static char name[SPEED_STRING_LEN]; + + if (link_speed == ETH_SPEED_NUM_NONE) + return "None"; + if (l

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: add support for event vector

2021-09-14 Thread Srujana Challa
Adds event vector support to inline protocol offload mode. By default vector support is disabled, it can be enabled by using the option --event-vector. Additional options to configure vector size and vector timeout are also implemented and can be used by specifying --vector-size and --vector-tmo.

Re: [dpdk-dev] [RFC 0/7] hide eth dev related structures

2021-09-14 Thread Ananyev, Konstantin
Hi Jerin, > > NOTE: This is just an RFC to start further discussion and collect the > > feedback. > > Due to significant amount of work, changes required are applied only to two > > PMDs so far: net/i40e and net/ice. > > So to build it you'll need to add: > > -Denable_drivers='common/*,mempool/*

Re: [dpdk-dev] [PATCH v3] net/pcap: support buffer size parameter

2021-09-14 Thread Ferruh Yigit
On 8/28/2021 10:47 AM, Qiming Chen wrote: > When the pcap port is probed, the size of the pcap message buffer is not > set, the default is 2M, and then this value has a great impact on the > message forwarding performance. Therefore, parameters are provided for > users to set. > Hi Qiming, I ass

Re: [dpdk-dev] [PATCH] build: propagate Windows system dependencies to pkg-config

2021-09-14 Thread Thomas Monjalon
20/08/2021 18:08, William Tu: > On Thu, Aug 19, 2021 at 4:15 PM Dmitry Kozlyuk > wrote: > > > > Windows EAL depends on some system libraries. They were linked using > > add_project_link_arguments('-l'), which prevented meson from adding > > them to Libs.private of pkg-config file. As a result, ap

Re: [dpdk-dev] [PATCH v7] ethdev: add IPv4 and L4 checksum RSS offload types

2021-09-14 Thread Ferruh Yigit
On 8/31/2021 10:52 AM, Alvin Zhang wrote: > This patch defines new RSS offload types for IPv4 and > L4(TCP/UDP/SCTP) checksum, which are required when users want > to distribute packets based on the IPv4 or L4 checksum field. > > For example "flow create 0 ingress pattern eth / ipv4 / end > action

Re: [dpdk-dev] [RFC 2/7] eth: make drivers to use new API for Rx

2021-09-14 Thread Ananyev, Konstantin
Hi Ferruh, > > Overall this enables us hiding the ethdev internals, which is good. But it > duplicates most of the datapath function (rx burst for this patch) per each > PMD ops. Yes, same as right now rte_eth_rx/tx_burst() code can be duplicated in dozen places inside user-level code. And

[dpdk-dev] [PATCH v3 0/3] eal: add memory pre-allocation from existing files

2021-09-14 Thread Dmitry Kozlyuk
Hugepage allocation from the system takes time, resulting in slow startup or sporadic delays later. Most of the time spent in kernel is zero-filling memory for security reasons, which may be irrelevant in a controlled environment. The bottleneck is memory access speed, so for speeduup the amount of

[dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

2021-09-14 Thread Dmitry Kozlyuk
get_hugepage_dir() searched for a hugetlbfs mount with a given page size using handcraft parsing of /proc/mounts and mixing traversal logic with selecting the needed entry. Separate code to enumerate hugetlbfs mounts to eal_hugepage_mount_walk() taking a callback that can inspect already parsed ent

[dpdk-dev] [PATCH v3 2/3] eal: add memory pre-allocation from existing files

2021-09-14 Thread Dmitry Kozlyuk
From: Viacheslav Ovsiienko The primary DPDK process launch might take a long time if initially allocated memory is large. From practice allocation of 1 TB of memory over 1 GB hugepages on Linux takes tens of seconds. Fast restart is highly desired for some applications and launch delay presents a

[dpdk-dev] [PATCH v3 3/3] app/test: add allocator performance autotest

2021-09-14 Thread Dmitry Kozlyuk
Memory allocator performance is crucial to applications that deal with large amount of memory or allocate frequently. DPDK allocator performance is affected by EAL options, API used and, at least, allocation size. New autotest is intended to be run with different EAL options. It measures performanc

[dpdk-dev] [Bug 809] KNI request overwritten with new asynchronous kni_net_release mechanism

2021-09-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=809 Bug ID: 809 Summary: KNI request overwritten with new asynchronous kni_net_release mechanism Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status:

[dpdk-dev] [PATCH v5 0/3] security: Improve inline fast path routines

2021-09-14 Thread Nithin Dabilpuram
Improvements to Inline inbound and outbound processing fast path routines rte_security_set_pkt_metadata() and rte_security_get_userdata() to make them inline functions and also provide mechanism for drivers to support fast userdata and metadata access instead of driver specific per-pkt function cal

[dpdk-dev] [PATCH v5 1/3] security: enforce semantics for Tx inline processing

2021-09-14 Thread Nithin Dabilpuram
Not all net PMD's/HW can parse packet and identify L2 header and L3 header locations on Tx. This is inline with other Tx offloads requirements such as L3 checksum, L4 checksum offload, etc, where mbuf.l2_len, mbuf.l3_len etc, needs to be set for HW to be able to generate checksum. Since Inline IPSe

[dpdk-dev] [PATCH v5 2/3] security: add option for faster udata or mdata access

2021-09-14 Thread Nithin Dabilpuram
Currently rte_security_set_pkt_metadata() and rte_security_get_userdata() methods to set pkt metadata on Inline outbound and get userdata after Inline inbound processing is always driver specific callbacks. For drivers that do not have much to do in the callbacks but just to update metadata in rte

[dpdk-dev] [PATCH v5 3/3] examples/ipsec-secgw: update event mode inline path

2021-09-14 Thread Nithin Dabilpuram
Update mbuf.l2_len with L2 header size for outbound inline processing. This patch also fixes a bug in arg parsing. Signed-off-by: Nithin Dabilpuram Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/ipsec_worker.c | 41 --

Re: [dpdk-dev] [PATCH v2] telemetry: add support for dicts of dicts

2021-09-14 Thread Power, Ciara
Hi Radu, Thanks for adding the test, one more comment inline that I have just noticed. >-Original Message- >From: Nicolau, Radu >Sent: Friday 10 September 2021 12:28 >To: Power, Ciara >Cc: dev@dpdk.org; Richardson, Bruce ; Nicolau, >Radu ; Doherty, Declan > >Subject: [PATCH v2] telemet

Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info

2021-09-14 Thread Ferruh Yigit
On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: > From: Viacheslav Galaktionov > > Make it simpler to debug configurations and code related to the representor > info API. > > Signed-off-by: Viacheslav Galaktionov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- > v2: > -

[dpdk-dev] [PATCH v3] telemetry: add support for dicts of dicts

2021-09-14 Thread Radu Nicolau
Add support for dicts of dicts to telemetry library. Increase the max string size to 128. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- app/test/test_telemetry_data.c | 29 lib/telemetry/rte_telemetry.h | 2 +- lib/telemetry/telemetry.c | 48 +

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

2021-09-14 Thread Ferruh Yigit
On 9/1/2021 12:17 PM, Kinsella, Ray wrote: > > > On 01/09/2021 09:53, Ferruh Yigit wrote: >> On 9/1/2021 8:08 AM, Andrew Rybchenko wrote: >>> On 9/1/21 4:50 AM, Xiaoyun Li wrote: Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API that was introduced in 18.11 and have b

Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info

2021-09-14 Thread Andrew Rybchenko
On 9/14/21 6:52 PM, Ferruh Yigit wrote: > On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: >> From: Viacheslav Galaktionov >> >> Make it simpler to debug configurations and code related to the representor >> info API. >> >> Signed-off-by: Viacheslav Galaktionov >> Signed-off-by: Andrew Rybchenko >>

Re: [dpdk-dev] [PATCH v9] doc: add release milestones definition

2021-09-14 Thread Ferruh Yigit
On 9/14/2021 8:56 AM, Thomas Monjalon wrote: > From: Asaf Penso > > Adding more information about the release milestones. > This includes the scope of change, expectations, etc. > > Signed-off-by: Asaf Penso > Signed-off-by: Thomas Monjalon > Acked-by: John McNamara > Acked-by: Ajit Khaparde

Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info

2021-09-14 Thread Ferruh Yigit
On 9/14/2021 5:17 PM, Andrew Rybchenko wrote: > On 9/14/21 6:52 PM, Ferruh Yigit wrote: >> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: >>> From: Viacheslav Galaktionov >>> >>> Make it simpler to debug configurations and code related to the representor >>> info API. >>> >>> Signed-off-by: Viaches

Re: [dpdk-dev] [PATCH v8] doc: add release milestones definition

2021-09-14 Thread Thomas Monjalon
14/09/2021 18:11, Ajit Khaparde: > On Tue, Sep 14, 2021 at 12:53 AM Thomas Monjalon wrote: > > 03/09/2021 17:35, Ferruh Yigit: > > > On 9/3/2021 12:50 PM, Thomas Monjalon wrote: > > > > 02/09/2021 18:33, Ferruh Yigit: > > > >> On 8/26/2021 11:11 AM, Thomas Monjalon wrote: > > > >>> +* Any issue fo

Re: [dpdk-dev] [PATCH v9] doc: add release milestones definition

2021-09-14 Thread Thomas Monjalon
14/09/2021 18:34, Ferruh Yigit: > On 9/14/2021 8:56 AM, Thomas Monjalon wrote: > > From: Asaf Penso > > > > Adding more information about the release milestones. > > This includes the scope of change, expectations, etc. > > > > Signed-off-by: Asaf Penso > > Signed-off-by: Thomas Monjalon > > A

[dpdk-dev] [PATCH] net/bnxt: fix Rx queue startup state

2021-09-14 Thread Lance Richardson
Since the addition of support for runtime queue setup, receive queues that are started by default no longer have the correct state. Fix this by setting the state when a port is started. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Signed-off-by: Lance Richardson Reviewed-by: Ajit

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

2021-09-14 Thread Dmitry Kozlyuk
> -Original Message- > From: John Levon > Sent: 14 сентября 2021 г. 15:48 > To: Dmitry Kozlyuk > Cc: dev@dpdk.org; Anatoly Burakov ; Slava > Ovsiienko > Subject: Re: [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable > > External email: Use caution opening links or attachments >

Re: [dpdk-dev] [PATCH v9] doc: add release milestones definition

2021-09-14 Thread Thomas Monjalon
14/09/2021 18:51, Ajit Khaparde: > On Tue, Sep 14, 2021 at 9:50 AM Thomas Monjalon wrote: > > > > 14/09/2021 18:34, Ferruh Yigit: > > > On 9/14/2021 8:56 AM, Thomas Monjalon wrote: > > > > From: Asaf Penso > > > > > > > > Adding more information about the release milestones. > > > > This includes

Re: [dpdk-dev] [PATCH] lpm6: Fix missing ^ in documentation.

2021-09-14 Thread Medvedkin, Vladimir
On 14/09/2021 09:05, David Marchand wrote: On Mon, Sep 13, 2021 at 8:47 PM Ben Pfaff wrote: This is probably due to conversion from ms word to rst format. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: sta...@dpdk.org Signed-off-by: Ben Pfaff Reviewed-by: David Marchand Acke

Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-09-14 Thread Honnappa Nagarahalli
> > Rx descriptor is 16B/32B in size and consists of multiple words. > The word that includes DD field should be read first. Read result with DD bit > set indicates the rest part in a descriptor is valid. Suggest rewording as follows: Rx descriptor is 16B/32B in size. If the DD bit is set, it in

[dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available

2021-09-14 Thread Usama Nadeem
From: usamanadeem321 Checks if IPV4, UDP and TCP Checksum offloads are available. If not available, prints a warning message. Bugzilla ID: 545 Signed-off-by: usamanadeem321 --- examples/l3fwd/main.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/exam

Re: [dpdk-dev] [PATCH] efd: change data type of parameter

2021-09-14 Thread David Christensen
On 9/14/21 12:10 AM, David Marchand wrote: On Fri, Sep 10, 2021 at 6:54 PM Pablo de Lara wrote: rte_efd_create() function was using uint8_t for a socket bitmask, for one of its parameters. This limits the maximum of NUMA sockets to be 8. Changing to to uint64_t increases it to 64, which sho

Re: [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available

2021-09-14 Thread Stephen Hemminger
On Tue, 14 Sep 2021 23:08:27 +0500 Usama Nadeem wrote: > + > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_UDP_CKSUM) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_UDP_CKSUM; > + > + else > + printf(

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix risk in Rx descriptor read in NEON vector path

2021-09-14 Thread Honnappa Nagarahalli
Similar comments that I have to patch 2/2 > > Rx descriptor is 16B/32B in size and consists of multiple words. > The word that includes DD field should be read first. Read result with DD bit > set indicates the rest part in a descriptor is valid. Suggest rewording as follows: Rx descriptor is 16

[dpdk-dev] [PATCH] pipeline: improve handling of learner table action arguments

2021-09-14 Thread Cristian Dumitrescu
The arguments of actions that are learned are now specified as part of the learn instruction as opposed to being statically specified as part of the learner table configuration. Signed-off-by: Cristian Dumitrescu --- Depends-on: series-18878 ("[V3,01/24] pipeline: move data structures to internal

Re: [dpdk-dev] [PATCH v8] doc: add release milestones definition

2021-09-14 Thread Ajit Khaparde
On Tue, Sep 14, 2021 at 12:53 AM Thomas Monjalon wrote: > > 03/09/2021 17:35, Ferruh Yigit: > > On 9/3/2021 12:50 PM, Thomas Monjalon wrote: > > > 02/09/2021 18:33, Ferruh Yigit: > > >> On 8/26/2021 11:11 AM, Thomas Monjalon wrote: > > >>> +* Any issue found in -rc1 should be fixed. > > >>> + > >

Re: [dpdk-dev] [PATCH v9] doc: add release milestones definition

2021-09-14 Thread Ajit Khaparde
On Tue, Sep 14, 2021 at 9:50 AM Thomas Monjalon wrote: > > 14/09/2021 18:34, Ferruh Yigit: > > On 9/14/2021 8:56 AM, Thomas Monjalon wrote: > > > From: Asaf Penso > > > > > > Adding more information about the release milestones. > > > This includes the scope of change, expectations, etc. > > > >

Re: [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available

2021-09-14 Thread Ananyev, Konstantin
> > From: usamanadeem321 > > Checks if IPV4, UDP and TCP Checksum offloads are available. > If not available, prints a warning message. > > Bugzilla ID: 545 > Signed-off-by: usamanadeem321 > --- > examples/l3fwd/main.c | 22 +- > 1 file changed, 21 insertions(+), 1 dele

Re: [dpdk-dev] [PATCH v2] net/iavf: enable interrupt polling

2021-09-14 Thread Kadam, Pallavi
On 8/25/2021 1:34 AM, Robin Zhang wrote: For VF hosted by Intel 700 series NICs, internal rx interrupt and adminq interrupt share the same source, that cause a lot cpu cycles be wasted on interrupt handler on rx path. The patch disable pci interrupt and remove the interrupt handler, replace it

Re: [dpdk-dev] [PATCH v2] Warns if IPv4, UDP or TCP checksum offload not available

2021-09-14 Thread Stephen Hemminger
On Tue, 14 Sep 2021 22:22:04 + "Ananyev, Konstantin" wrote: > > > > From: usamanadeem321 > > > > Checks if IPV4, UDP and TCP Checksum offloads are available. > > If not available, prints a warning message. > > > > Bugzilla ID: 545 > > Signed-off-by: usamanadeem321 > > --- > > examples/l

[dpdk-dev] [PATCH] windows/netuio: add Intel Virtual Function device IDs

2021-09-14 Thread Pallavi Kadam
Add Intel Ethernet Virtual Function device IDs to netuio inf file to support Intel 40GbE and 100GbE deives on Windows VM. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- windows/netuio/netuio.inf | 12 1 file changed, 12 insertions(+) diff --git a/windows/netuio/netuio.

Re: [dpdk-dev] [PATCH] net/iavf: fix mbuf leak

2021-09-14 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Qiming Chen > Sent: Saturday, September 11, 2021 9:47 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; > Qiming Chen ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix mbuf leak > > A local test found that repeated po

Re: [dpdk-dev] [PATCH] net/i40e: fix vf resource leakage problem

2021-09-14 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of > chenqiming_hua...@163.com > Sent: Saturday, August 21, 2021 4:14 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Qiming Chen > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix vf resource leakage problem > > From: Qiming Chen >

Re: [dpdk-dev] [PATCH v7] ethdev: add IPv4 and L4 checksum RSS offload types

2021-09-14 Thread Zhang, AlvinX
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 14, 2021 10:01 PM > To: Zhang, AlvinX ; Zhang, Qi Z > ; Guo, Junfeng > Cc: dev@dpdk.org; Ajit Khaparde ; Singh, > Aman Deep > Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add IPv4 and L4 checksum RSS > offload types > >

  1   2   >