Re: [dpdk-dev] [WARNING: UNSCANNABLE EXTRACTION FAILED][WARNING: UNSCANNABLE EXTRACTION FAILED] [PATCH v5] doc: mtr: add API walk through

2021-08-07 Thread Jerin Jacob
On Fri, Aug 6, 2021 at 11:16 PM Dumitrescu, Cristian wrote: > > Hi Jerin, Hi Cristian, I will next version with your suggestions. > > > +API Walk-through > > + > > + > > +.. _figure_rte_mtr_chaining: > > + > > +.. figure:: img/rte_mtr_meter_chaining.* > > + > > + Meter compone

[dpdk-dev] [PATCH v6] doc: mtr: add API walk through

2021-08-07 Thread jerinj
From: Jerin Jacob Added a diagram to document meter library components and added text for steps performed by the application to configure the traffic meter and policing library. Signed-off-by: Jerin Jacob --- v2: Fix long lines in svg file to avoid patch apply issue v3: Fix all Thomas's commen

[dpdk-dev] [PATCH] vhost: fix coredump on port deletion

2021-08-07 Thread Gaoxiang Liu
The rte_vhost_driver_unregister() and vhost_user_read_cb() can be called at the same time by 2 threads. Eg thread1 calls rte_vhost_driver_unregister() and frees memory of conn, then thread2 calls vhost_user_read_cb() and access invalid memory of conn. The fix is to move the "fdset_try_del" in fron

[dpdk-dev] [Bug 781] why use rte_eth_dev_start/stop instead of rte_eth_set_link_up/down in kni_config_network_interface function in examples/kni/main.c

2021-08-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=781 Bug ID: 781 Summary: why use rte_eth_dev_start/stop instead of rte_eth_set_link_up/down in kni_config_network_interface function in examples/kni/main.c Product: D

Re: [dpdk-dev] 回复: [PATCH] doc: announce the deprecation of lcore state FINISHED

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 11:43 AM Feifei Wang wrote: > > > -邮件原件- > > 发件人: dev 代表 Honnappa Nagarahalli > > 发送时间: Saturday, July 31, 2021 3:59 AM > > 收件人: dev@dpdk.org; Honnappa Nagarahalli > > ; tho...@monjalon.net; > > konstantin.anan...@intel.com; Feifei Wang (Arm Technology China) > > >

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 3:44 PM Hemant Agrawal wrote: > > Acked-by: Hemant Agrawal Acked-by: Jerin Jacob

Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

2021-08-07 Thread Jerin Jacob
On Wed, Aug 4, 2021 at 5:59 PM Andrew Rybchenko wrote: > > On 8/4/21 11:08 AM, Slava Ovsiienko wrote: > >> -Original Message- > >> From: dev On Behalf Of Xueming Li > >> Sent: Monday, August 2, 2021 16:11 > >> Cc: dev@dpdk.org; Xueming(Steven) Li ; Ray Kinsella > >> > >> Subject: [dpdk-d

Re: [dpdk-dev] [PATCH] doc: announce IPsec xform struct changes

2021-08-07 Thread Jerin Jacob
On Wed, Aug 4, 2021 at 11:05 PM Ananyev, Konstantin wrote: > > > > > > IPsec xform struct would be updated to include IPsec SA lifetime > > > configuration. The existing member 'esn_soft_limit' would only track > > > ESN. And as sequence number control is getting introduced, > > > 'esn_soft_limit'

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data

2021-08-07 Thread Jerin Jacob
On Wed, Aug 4, 2021 at 5:40 PM Andrew Rybchenko wrote: > > On 8/3/21 9:10 PM, Ajit Khaparde wrote: > > On Tue, Aug 3, 2021 at 1:58 AM Ori Kam wrote: > >> > >> In the current implementation, > >> the action rte_flow_action_modify_field is not well defined > >> for fields larger than 64 bits (for e

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function

2021-08-07 Thread Jerin Jacob
On Tue, Aug 3, 2021 at 11:35 PM Ajit Khaparde wrote: > > On Tue, Aug 3, 2021 at 1:58 AM Ori Kam wrote: > > > > Currently there is a dedicated modify function for each > > field that the application wants to change. > > For example: > > rte_flow_action_type_set_tp_port to modify destination port o

Re: [dpdk-dev] [PATCH] doc: announce restructuring of crypto session structs

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 9:51 AM Anoob Joseph wrote: > > > Subject: [PATCH] doc: announce restructuring of crypto session structs > > > > The structures rte_cryptodev_sym_session and rte_cryptodev_asym_session are > > not used by the application directly. The application just need an opaque > > poi

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce changes in security session struct

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 9:45 AM Anoob Joseph wrote: > > > Subject: [EXT] Re: [PATCH] doc: announce changes in security session struct > > > > > > On Tue, Aug 3, 2021 at 5:36 AM Ananyev, Konstantin > > wrote: > > > > > > > > > > The structure rte_security_session is not directly used > > > > by the

Re: [dpdk-dev] [PATCH 1/2] doc: announce ipsec rte_ipsec_sa_prm structure changes

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 4:10 PM Ananyev, Konstantin wrote: > > > > > > > Signed-off-by: Radu Nicolau > > --- > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst

Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 7:23 PM Walsh, Conor wrote: > > > This patch announces the experimental tag removal of all fib APIs, > > which have been experimental for 2 years. > > API will be promoted to stable in DPDK 21.11 > > > > Signed-off-by: Vladimir Medvedkin > > --- > > doc/guides/rel_notes/de

Re: [dpdk-dev] [PATCH 1/2] rib: announce experimental tag removal of the rib API

2021-08-07 Thread Jerin Jacob
On Thu, Aug 5, 2021 at 4:56 PM Vladimir Medvedkin wrote: > > This patch announces the experimental tag removal of all rib APIs, > which have been experimental for 2 years. > API will be promoted to stable in DPDK 21.11 > > Signed-off-by: Vladimir Medvedkin Acked-by: Jerin Jacob > --- > doc/gu

Re: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create

2021-08-07 Thread Thomas Monjalon
30/07/2021 23:44, Honnappa Nagarahalli: > The current expected behaviour of the function rte_ctrl_thread_create > is rigid which makes the implementation of the function complex. > Make the expected behaviour abstract to allow for simplified > implementation. > > With this change, the calls to pth

Re: [dpdk-dev] 回复: [PATCH] doc: announce the deprecation of lcore state FINISHED

2021-08-07 Thread Thomas Monjalon
> > > Lcore state FINISHED is used by the worker thread to indicate that it has > > > completed the assigned task. The state is changed to WAIT by another > > > thread after it observes the updated state. This additional step is > > > redundant. > > > After this deprecation, the worker thread will

Re: [dpdk-dev] [PATCH] doc: announce change in crypto adapter metadata

2021-08-07 Thread Thomas Monjalon
> > >> In crypto adapter metadata, first 8 bytes of request info is a space > > >> holder for response info. For better clarity, reserved field should be > > >> removed from request info. New space for response info can be made by > > >> changing type of event crypto metadata to structure from unio

Re: [dpdk-dev] [EXT] [PATCH v2] doc: announce change in crypto raw data vector

2021-08-07 Thread Thomas Monjalon
05/08/2021 16:04, Akhil Goyal: > > The current crypto raw data vectors need to be extended to support > > out of place processing. It is proposed to add additional desl_sgl > > to provide details for destination sgl. > > The same is also extended to support rte_security usecases, where > > we need

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce changes in security session struct

2021-08-07 Thread Thomas Monjalon
> > > > > The structure rte_security_session is not directly used > > > > > by the application. The application just need an opaque > > > > > pointer to attached to the mbuf or rte_crypto_op while > > > > > enqueue. Hence, it can be hidden inside the library > > > > > and would prevent unnecessary

Re: [dpdk-dev] [PATCH] doc: announce IPsec xform struct changes

2021-08-07 Thread Thomas Monjalon
> > > > IPsec xform struct would be updated to include IPsec SA lifetime > > > > configuration. The existing member 'esn_soft_limit' would only track > > > > ESN. And as sequence number control is getting introduced, > > > > 'esn_soft_limit' may not indicate the number of packets processed. > > > >

Re: [dpdk-dev] [PATCH] doc: announce SA config option struct changes

2021-08-07 Thread Thomas Monjalon
> > Propose new fields to support offloads like > > - IPsec inner checksum(L3/L4) > > - IPsec tunnel header verification > > - TSO > > - etc > > in the structure ``rte_security_ipsec_sa_options``. > > > > Signed-off-by: Archana Muniganti > > Signed-off-by: Tejasree Kondoj > > Acked-by: Akhil Goya

Re: [dpdk-dev] [PATCH v2] vhost: announce experimental tag removal of vhost APIs

2021-08-07 Thread Thomas Monjalon
30/07/2021 10:24, Chenbo Xia: > This patch announces the experimental tag removal of 10 vhost APIs, > which have been experimental for more than 2 years. All APIs could > be made stable in DPDK 21.11. > > Signed-off-by: Chenbo Xia > Acked-by: Maxime Coquelin > --- > +* vhost: The experimental ta

Re: [dpdk-dev] [PATCH v2 1/2] vhost: announce vDPA driver API marking as internal

2021-08-07 Thread Thomas Monjalon
30/07/2021 10:12, Maxime Coquelin: > This patch announces the marking of all the vDPA driver APIs > as internal. > > Acked-by: Chenbo Xia > Signed-off-by: Maxime Coquelin > --- > +* vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``, > + ``rte_vhost_host_notifier_ctrl`` and ``r

Re: [dpdk-dev] [PATCH v2 2/2] vhost: notice Vhost ops struct renaming

2021-08-07 Thread Thomas Monjalon
30/07/2021 10:12, Maxime Coquelin: > This patch announces the renaming of struct > vhost_device_ops to rte_vhost_device_ops in DPDK v21.11. > > Acked-by: Chenbo Xia > Signed-off-by: Maxime Coquelin > --- > +* vhost: rename ``struct vhost_device_ops`` to ``struct > rte_vhost_device_ops`` > + in

Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

2021-08-07 Thread Thomas Monjalon
> > >> To support shared Rx queue, this patch announces new offload flag > > >> RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct > > >> rte_eth_rxconf in DPDK v21.11. > > >> > > >> [1] mail list discussion: > > >> https://mails.dpdk.org/archives/dev/2021-July/215575.html > > >> >

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data

2021-08-07 Thread Thomas Monjalon
> > >> In the current implementation, > > >> the action rte_flow_action_modify_field is not well defined > > >> for fields larger than 64 bits (for example IPv6 source) > > >> In addition, the byte order is also not well defined. > > >> > > >> Both of those issue should be fixed. > > >> > > >> Sign

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function

2021-08-07 Thread Thomas Monjalon
> > > Currently there is a dedicated modify function for each > > > field that the application wants to change. > > > For example: > > > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. > > > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4. > > > > > > A new f

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes

2021-08-07 Thread Thomas Monjalon
> > By its very name, action PORT_ID means that packets hit an ethdev with the > > given DPDK port ID. At least the current comments don't state the opposite. > > > > However some drivers implement it in a different way and direct traffic to > > the opposite end of the "wire" plugged to the given e

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port

2021-08-07 Thread Thomas Monjalon
> > Transfer flow rules may be applied to traffic entering switch from > > many sources. There are flow API pattern items which allow to specify > > ingress port match criteria explicitly, but it is not documented > > if ethdev port used to create flow rule adds any implicit match > > criteria and

[dpdk-dev] [PATCH v2] vhost: fix coredump on port deletion

2021-08-07 Thread Gaoxiang Liu
The rte_vhost_driver_unregister() and vhost_user_read_cb() can be called at the same time by 2 threads. Eg thread1 calls rte_vhost_driver_unregister() and frees memory of conn, then thread2 calls vhost_user_read_cb() and access invalid memory of conn. The fix is to move the "fdset_try_del" in fron