Re: [dpdk-dev] [PATCH v2 3/4] vhost: avoid deadlock on async register

2021-04-15 Thread Maxime Coquelin
On 4/15/21 3:08 AM, Hu, Jiayu wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, April 14, 2021 6:09 PM >> To: Hu, Jiayu ; dev@dpdk.org >> Cc: Xia, Chenbo ; Wang, Yinan >> ; Pai G, Sunil ; Jiang, Cheng1 >> >> Subject: Re: [PATCH v2 3/4] vhost: avoid deadloc

[dpdk-dev] [PATCH] net/bonding: fix add bonded device itself as its slave

2021-04-15 Thread Min Hu (Connor)
From: Chengchang Tang Adding the bond device as its own slave should be forbidden. This will cause a recursive endless loop in many subsequent operations, and eventually lead to coredump. This problem was found in testpmd, the related logs are as follows: testpmd> create bonded device 1 0 Create

[dpdk-dev] [PATCH] examples/timer: fix incorrect time interval

2021-04-15 Thread Min Hu (Connor)
From: Chengchang Tang Timer sample example assumes that the frequency of the timer is about 2Ghz to control the period of calling rte_timer_manage(). But this assumption is easy to fail. For example. the frequency of tsc on ARM64 is much less than 2Ghz. This patch uses the frequency of the curre

Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields

2021-04-15 Thread David Marchand
On Thu, Apr 15, 2021 at 7:33 AM Akhil Goyal wrote: > > Hi David, > > > Certain structures are added with reserved fields > > > to address any future enhancements to retain ABI > > > compatibility. > > > However, ABI script will still report error as it > > > is not aware of reserved fields. Hence,

Re: [dpdk-dev] [PATCH 10/12] net/hns3: rename Rx burst API

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 2:58 AM, Min Hu (Connor) wrote: 在 2021/4/15 1:41, Ferruh Yigit 写道: On 4/13/2021 12:50 PM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, user could use runtime config "rx_func_hint=simple" to select the hns3_recv_pkts API, but the API's name get from rte_eth_rx_burst_mod

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of Xueming Li > Sent: Tuesday, April 13, 2021 11:23 > To: Thomas Monjalon > Cc: dev@dpdk.org; xuemi...@nvidia.com; Asaf Penso ; Parav > Pandit ; > Ray Kinsella ; Neil Horman > Subject: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bu

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 3:55 AM, Suanming Mou wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, April 14, 2021 9:07 PM To: Suanming Mou ; Ori Kam ; Andrew Rybchenko ; NBU-Contact-Thomas Monjalon Cc: dev@dpdk.org; Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: make

[dpdk-dev] [PATCH v4] net/ice: support GTPU TEID pattern for switch filter

2021-04-15 Thread Yuying Zhang
Enable GTPU pattern for CVL switch filter. Support teid and qfi field of GTPU pattern. Patterns without inner l3/l4 field support outer dst/src ip. Patterns with inner l3/l4 field only support inner dst/src ip and inner dst/src port. +---+---

Re: [dpdk-dev] [PATCH v4] net/iavf: deprecate i40evf pmd

2021-04-15 Thread Wang, Haiyue
> -Original Message- > From: Zhang, RobinX > Sent: Thursday, April 15, 2021 10:05 > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue > ; m...@ashroe.eu; nhor...@tuxdriver.com; Wu, Jingjing > ; > Yang, Qiming ; Yang, SteveX ; > Zhang, RobinX > > Subject: [PATCH v4] net/ia

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Xueming(Steven) Li
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, April 15, 2021 3:36 PM > To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella ; Neil Horman > > Subject: RE: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce aux

Re: [dpdk-dev] [PATCH v3 25/26] event/dlb: remove version from device name

2021-04-15 Thread Thomas Monjalon
15/04/2021 07:47, Jerin Jacob: > On Thu, Apr 15, 2021 at 2:03 AM Thomas Monjalon wrote: > > 14/04/2021 21:44, Jerin Jacob: > > > On Wed, Apr 14, 2021 at 1:49 AM Timothy McDaniel > > > wrote: > > > > > > > > Updated eventdev device name to be dlb_event instead of > > > > dlb2_event. The new name

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Wang, Haiyue
> -Original Message- > From: Xueming(Steven) Li > Sent: Thursday, April 15, 2021 15:46 > To: Wang, Haiyue ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella > ; Neil Horman > Subject: RE: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxilia

Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process

2021-04-15 Thread Ferruh Yigit
On 4/12/2021 5:37 PM, Ferruh Yigit wrote: On 3/30/2021 2:48 AM, Min Hu (Connor) wrote: From: Lijun Ou This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Xueming(Steven) Li
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, April 15, 2021 3:52 PM > To: Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella ; Neil Horman > > Subject: RE: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce aux

Re: [dpdk-dev] [PATCH v3 25/26] event/dlb: remove version from device name

2021-04-15 Thread Jerin Jacob
On Thu, Apr 15, 2021 at 1:18 PM Thomas Monjalon wrote: > > 15/04/2021 07:47, Jerin Jacob: > > On Thu, Apr 15, 2021 at 2:03 AM Thomas Monjalon wrote: > > > 14/04/2021 21:44, Jerin Jacob: > > > > On Wed, Apr 14, 2021 at 1:49 AM Timothy McDaniel > > > > wrote: > > > > > > > > > > Updated eventdev d

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Thomas Monjalon
15/04/2021 09:55, Xueming(Steven) Li: > From: Wang, Haiyue > > From: Xueming(Steven) Li > > > From: Wang, Haiyue > > > > From: dev On Behalf Of Xueming Li > > > > > +/** > > > > > + * A structure describing an auxiliary driver. > > > > > + */ > > > > > +struct rte_auxiliary_driver { > > > > > +

Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus

2021-04-15 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, April 15, 2021 15:59 > To: Wang, Haiyue ; Xueming(Steven) Li > > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit > ; Ray Kinsella > ; david.march...@redhat.com; Yigit, Ferruh > ; > andrew.rybche...@oktetlabs.ru; olivier.m...@6w

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Andrew Rybchenko
On 4/15/21 3:52 AM, Min Hu (Connor) wrote: > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 0366137722a0 ("ethdev: check f

Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields

2021-04-15 Thread Bruce Richardson
On Thu, Apr 15, 2021 at 09:26:38AM +0200, David Marchand wrote: > On Thu, Apr 15, 2021 at 7:33 AM Akhil Goyal wrote: > > > > Hi David, > > > > Certain structures are added with reserved fields > > > > to address any future enhancements to retain ABI > > > > compatibility. > > > > However, ABI scri

Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields

2021-04-15 Thread Thomas Monjalon
15/04/2021 10:25, Bruce Richardson: > On Thu, Apr 15, 2021 at 09:26:38AM +0200, David Marchand wrote: > > On Thu, Apr 15, 2021 at 7:33 AM Akhil Goyal wrote: > > > > > +; Ignore changes in reserved fields > > > > > +[suppress_variable] > > > > > + name_regexp = reserved > > > > > > > > Mm, t

Re: [dpdk-dev] [PATCH v4 0/3] Predictable RSS feature

2021-04-15 Thread David Marchand
On Wed, Apr 14, 2021 at 8:05 PM Wang, Yipeng1 wrote: > > > -Original Message- > > From: Medvedkin, Vladimir > > Sent: Tuesday, April 13, 2021 6:20 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin ; Chilikin, Andrey > > ; Kinsella, Ray ; Wang, > > Yipeng1 ; Gobriel, Sameh > > ; Richards

Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields

2021-04-15 Thread Akhil Goyal
> > > > ; Ignore fields inserted in cacheline boundary of rte_cryptodev > > > > [suppress_type] > > > > name = rte_cryptodev > > > > -has_data_member_inserted_between = {offset_after(attached), > end} > > > > \ No newline at end of file > > > > +has_data_member_inserted_b

[dpdk-dev] [PATCH v3] net/hns3: rename Rx burst API

2021-04-15 Thread Min Hu (Connor)
From: Chengwen Feng Currently, user could use runtime config "rx_func_hint=simple" to select the hns3_recv_pkts API, but the API's name get from rte_eth_rx_burst_mode_get is "Scalar" which has not reflected "simple". So this patch renames hns3_recv_pkts to hns3_recv_pkts_simple, and also change

Re: [dpdk-dev] [EXT] [PATCH v5] cryptodev: support multiple cipher data-units

2021-04-15 Thread Akhil Goyal
> From: Matan Azrad > > In cryptography, a block cipher is a deterministic algorithm operating > on fixed-length groups of bits, called blocks. > > A block cipher consists of two paired algorithms, one for encryption > and the other for decryption. Both algorithms accept two inputs: > an input b

Re: [dpdk-dev] [PATCH v7 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-15 Thread Walsh, Conor
> > > > The IPv6 subnets used were not within the 2001:200::/48 subnet > > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > etc... > > Err... all those subnets were exactly == 2001:200::/48. > Is the issue that the examp

[dpdk-dev] [PATCH] doc: announce modification in eventdev structure

2021-04-15 Thread gakhil
From: Akhil Goyal A new field ``ca_enqueue`` is added in ``rte_eventdev`` in the end to maintain ABI. It needs to be moved above in the structure to align with other enqueue callbacks. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH v11 0/3] Enhancements to crypto adapter forward mode

2021-04-15 Thread gakhil
From: Akhil Goyal v11: - removed first patch. - removed deprecation notice. It is sent separately. http://patches.dpdk.org/project/dpdk/patch/20210415090859.1319171-1-gak...@marvell.com/ v10: - moved last patch to first patch of the series. v9: - moved ca_enqueue in the end of rte_eventdev befo

[dpdk-dev] [PATCH v11 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-15 Thread gakhil
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v11 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-15 Thread gakhil
From: Shijith Thotton Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton Acked-by: Abhinandan Gujjar --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 49 +++ drivers/event/octeontx2/otx2_evdev.c

[dpdk-dev] [PATCH v11 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-15 Thread gakhil
From: Shijith Thotton Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton Acked-by: Abhinandan Gujjar --- app/test/test_event_crypto_adapter.c | 33 ++-- 1 file changed, 2

[dpdk-dev] limit on console prints

2021-04-15 Thread Gagandeep Singh
Hi, Do we have anything similar to "printk_ratelimit()" in DPDK to limit the prints? Thanks, Gagan

[dpdk-dev] [PATCH v8 0/2] Support meter policy API

2021-04-15 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

[dpdk-dev] [PATCH v8 2/2] app/testpmd: support policy actions per color

2021-04-15 Thread Li Zhang
From: Haifei Luo Add the create/del policy CLIs to support actions per color. The CLIs are: Create: add port meter policy (port_id) (policy_id) g_actions (actions) y_actions (actions) r_actions (actions) Delete: del port meter policy (port_id) (policy_id) Examples: testpmd> add port meter poli

[dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined meter policy API

2021-04-15 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

Re: [dpdk-dev] [PATCH v4 2/3] examples/ipsec-secgw: add UDP encapsulation support

2021-04-15 Thread Ananyev, Konstantin
> Adding lookaside IPsec UDP encapsulation support > for NAT traversal. > Application has to add udp-encap option to sa config file > to enable UDP encapsulation on the SA. > > Signed-off-by: Tejasree Kondoj > Acked-by: Akhil Goyal > --- Acked-by: Konstantin Ananyev > 2.27.0

[dpdk-dev] [PATCH v5 0/2] add alternative AVX512 offload path

2021-04-15 Thread Leyi Rong
Add alternative Rx/Tx offload path for AVX512, which can support Rx/Tx offload features, like checksum/vlan/RSS/QinQ offload. --- v5: - fix bug [DPDK-26560] invalid checksum for tunnel packet. v4: - code rebased. v3: - complete ice_dev_supported_ptypes_get() for new adding offload functions. -

[dpdk-dev] [PATCH v5 1/2] net/ice: add Tx AVX512 offload path

2021-04-15 Thread Leyi Rong
Add alternative Tx data path for AVX512 which can support partial Tx offload features, including Tx checksum offload, vlan/QinQ insertion offload. Signed-off-by: Leyi Rong Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c| 28 +-- drivers/net/ice/ice_rxtx.h|

[dpdk-dev] [PATCH v5 2/2] net/ice: add Rx AVX512 offload path

2021-04-15 Thread Leyi Rong
Split AVX512 Rx data path into two, one is for basic, the other one can support additional Rx offload features, including Rx checksum offload, Rx vlan offload, RSS offload. Signed-off-by: Leyi Rong Signed-off-by: Wenzhuo Lu --- drivers/net/ice/ice_rxtx.c| 50 +++- drivers/net/ice/i

[dpdk-dev] [PATCH v5 1/2] net/ice: support GTPU TEID pattern for switch filter

2021-04-15 Thread Yuying Zhang
Enable GTPU pattern for CVL switch filter. Support teid and qfi field of GTPU pattern. Patterns without inner l3/l4 field support outer dst/src ip. Patterns with inner l3/l4 field only support inner dst/src ip and inner dst/src port. +---+---

[dpdk-dev] [PATCH v5 2/2] net/ice/base: support GTPU for DCF switch filter

2021-04-15 Thread Yuying Zhang
Enable GTPU filtering for DCF switch filter. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_protocol_type.h | 20 ++ drivers/net/ice/base/ice_switch.c| 263 --- drivers/net/ice/base/ice_switch.h| 5 + 3 files changed, 260 insertions(+), 28 deletio

Re: [dpdk-dev] [PATCH v4] net/iavf: deprecate i40evf pmd

2021-04-15 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Robin Zhang > Sent: Thursday, April 15, 2021 10:05 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; m...@ashroe.eu; nhor...@tuxdriver.com; > Wu, Jingjing ; Yang, Qiming > ; Yang, SteveX ; Zhang, > RobinX > Subject: [dpd

Re: [dpdk-dev] [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API

2021-04-15 Thread Zhang, Roy Fan
Hi Akhil, It is possible the user don't know how many ops to dequeue. For example in VPP crypto up to 64 buffers (vnet_crypto_async_frame_elt_t) are wrapped into the following data structure typedef struct { CLIB_CACHE_LINE_ALIGN_MARK (cacheline0); vnet_crypto_async_frame_state_t state; v

[dpdk-dev] [PATCH v5] net/iavf: deprecate i40evf pmd

2021-04-15 Thread Robin Zhang
The i40evf PMD will be deprecated, iavf will be the only VF driver for Intel 700 serial (i40e) NIC family. To reach this, there will be 2 steps: Step 1: iavf will be the default VF driver, while i40evf still can be selected by devarg: "driver=i40evf". This is covered by this patch, which include:

[dpdk-dev] [PATCH v6 1/2] net/ice/base: support GTPU for DCF switch filter

2021-04-15 Thread Yuying Zhang
Enable GTPU filtering for DCF switch filter. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_protocol_type.h | 20 ++ drivers/net/ice/base/ice_switch.c| 263 --- drivers/net/ice/base/ice_switch.h| 5 + 3 files changed, 260 insertions(+), 28 deletio

[dpdk-dev] [PATCH v6 2/2] net/ice: support GTPU TEID pattern for switch filter

2021-04-15 Thread Yuying Zhang
Enable GTPU pattern for CVL switch filter. Support teid and qfi field of GTPU pattern. Patterns without inner l3/l4 field support outer dst/src ip. Patterns with inner l3/l4 field only support inner dst/src ip and inner dst/src port. +---+---

[dpdk-dev] [PATCH v3] net/ice: support flow priority for DCF switch filter

2021-04-15 Thread Yuying Zhang
Support rte flow priority attribute for DCF switch filter. The rules with same patterns couldn't be created at the same time since they were related to the same recipe. This patch supports flow priority to create different recipes for this situation. Only priority 0 and 1 are supported and higher v

[dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-15 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Min Hu (Connor)
在 2021/4/15 16:15, Andrew Rybchenko 写道: On 4/15/21 3:52 AM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixe

[dpdk-dev] [PATCH v3 0/2] support single flow dump on MLX5 PMD

2021-04-15 Thread Haifei Luo
Dump information for all flows are supported and it is useful to dump one flow. Add single flow dump support on MLX5 PMD. Modify API mlx5_flow_dev_dump to support.Modify mlx5_socket since one extra arg flow_ptr is added. The data structure sent to DPDK application from the utility triggering th

[dpdk-dev] [PATCH v3 2/2] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-15 Thread Haifei Luo
Modify API mlx5_flow_dev_dump to support the feature. Modify mlx5_socket since one extra arg flow_ptr is added. The data structure sent to DPDK application from the utility triggering the flow dumps should be packed and endianness must be specified. The native host endianness can be used, all exch

[dpdk-dev] [PATCH v3 1/2] common/mlx5: add mlx5 APIs for single flow dump feature

2021-04-15 Thread Haifei Luo
add mlx5 APIs for single flow dump feature Signed-off-by: Haifei Luo Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/meson.build | 6 -- drivers/common/mlx5/linux/mlx5_glue.c | 13 + drivers/common/mlx5/linux/mlx5_glue.h | 1 + drivers/common/mlx5/mlx5_devx_cmds.c

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: add mlx5 APIs for single flow dump feature

2021-04-15 Thread Slava Ovsiienko
> -Original Message- > From: Haifei Luo > Sent: Thursday, April 15, 2021 14:19 > To: dev@dpdk.org > Cc: Ori Kam ; Slava Ovsiienko ; > Raslan Darawsheh ; Xueming(Steven) Li > ; Haifei Luo ; Matan Azrad > ; Shahaf Shuler > Subject: [PATCH v3 2/2] net/mlx5: add mlx5 APIs for single flow dump

[dpdk-dev] DPDK Release Status Meeting 15/04/2021

2021-04-15 Thread Ferruh Yigit
Release status meeting minutes {Date} = :Date: 15 April 2021 :toc: .Agenda: * Release Dates * Subtrees * LTS * Opens .Participants: * Arm * Broadcom * Canonical * Debian/Microsoft * Intel * Marvell * Nvidia * OKTET Labs * Red Hat Release Dates -

[dpdk-dev] [PATCH v3 0/2] fix missing check for thread creation

2021-04-15 Thread Min Hu (Connor)
There exist some thread creation function without result check. This set of patches add result check and message print out after failure. Chengwen Feng (2): telemetry: fix missing check for thread creation test: fix missing check for thread creation --- v3: * modify return value check and err

[dpdk-dev] [PATCH v3 2/2] test: fix missing check for thread creation

2021-04-15 Thread Min Hu (Connor)
From: Chengwen Feng There was a call for thread create function without result check. Add result check and message print out after failure. Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) ---

[dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-15 Thread Min Hu (Connor)
From: Chengwen Feng Add result check and message print out for thread creation after failure. Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_telemetry/telemetry.c| 30 +

Re: [dpdk-dev] [PATCH v2 1/2] telemetry: fix missing check for thread creation

2021-04-15 Thread Min Hu (Connor)
Hi, David, ALl has been fixed in v3, please check it out, thanks. 在 2021/4/12 15:48, David Marchand 写道: On Mon, Apr 12, 2021 at 2:32 AM Min Hu (Connor) wrote: From: Chengwen Feng Add result check and message print out for thread creation after failure. Ah, I was looking at this co

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Thomas Monjalon
15/04/2021 10:15, Andrew Rybchenko: > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP); > > In theory, the first argument is sufficient to make the ops > check, but I think it is the right solution to keep it as is > since current tendency is to check operation support when >

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Andrew Rybchenko
On 4/15/21 2:57 PM, Thomas Monjalon wrote: > 15/04/2021 10:15, Andrew Rybchenko: >>> RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP); >> In theory, the first argument is sufficient to make the ops >> check, but I think it is the right solution to keep it as is >> since current t

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Kevin Traynor
On 15/04/2021 01:52, Min Hu (Connor) wrote: > This patch adds more sanity checks in control path APIs. > Hi Connor, A few general comments, -- Some of the functions have unit tests, you could consider adding unit tests for the new checks. Considering the checks are not subtle and unlikely to be

Re: [dpdk-dev] [PATCH v5] net/iavf: deprecate i40evf pmd

2021-04-15 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Robin Zhang > Sent: Thursday, April 15, 2021 6:35 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; m...@ashroe.eu; nhor...@tuxdriver.com; > Wu, Jingjing ; Yang, Qiming > ; Yang, SteveX ; Zhang, > RobinX > Subject: [dpdk

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Thomas Monjalon
15/04/2021 14:04, Kevin Traynor: > On 15/04/2021 01:52, Min Hu (Connor) wrote: > > + if (iter == NULL) { > > + RTE_ETHDEV_LOG(ERR, "Failed to iterator init for NULL\n"); > > "Failed to init iterator for NULL iterator\n" The word "Failed" looks weird in these checks. What about "Cannot

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Thomas Monjalon
15/04/2021 14:03, Andrew Rybchenko: > On 4/15/21 2:57 PM, Thomas Monjalon wrote: > > 15/04/2021 10:15, Andrew Rybchenko: > >>> RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP); > >> In theory, the first argument is sufficient to make the ops > >> check, but I think it is the right

Re: [dpdk-dev] [PATCH v6 1/2] net/ice/base: support GTPU for DCF switch filter

2021-04-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Thursday, April 15, 2021 6:48 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Zhang, Yuying > Subject: [PATCH v6 1/2] net/ice/base: support GTPU for DCF switch filter > > Enable GTPU filtering for DCF switch filter. > > Signed-off-by: Yuyi

Re: [dpdk-dev] [PATCH v6 2/2] net/ice: support GTPU TEID pattern for switch filter

2021-04-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Thursday, April 15, 2021 6:48 PM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Zhang, Yuying > Subject: [PATCH v6 2/2] net/ice: support GTPU TEID pattern for switch filter > > Enable GTPU pattern for CVL switch filter. Support teid and qfi f

Re: [dpdk-dev] [PATCH] net/i40e: Add support for 25G AOC/ACC cables

2021-04-15 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Yury Kylulin > Sent: Tuesday, April 13, 2021 11:30 PM > To: Xing, Beilei > Cc: dev@dpdk.org; ap...@juniper.net; Kylulin, Yury > Subject: [dpdk-dev] [PATCH] net/i40e: Add support for 25G AOC/ACC cables > > Enable additional PHY types (25G-

Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 3:40 AM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queu

Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information

2021-04-15 Thread Thomas Monjalon
15/04/2021 14:33, Ferruh Yigit: > On 4/15/2021 3:40 AM, Lijun Ou wrote: > > Currently, upper-layer application could get queue state only > > through pointers such as dev->data->tx_queue_state[queue_id], > > this is not the recommended way to access it. So this patch > > add get queue state when ca

Re: [dpdk-dev] [PATCH v2 1/4] vhost: move allocation of mbuf outside of packet enqueue

2021-04-15 Thread Maxime Coquelin
Hi Balazs, Hint for future revisions, please add a cover letter when multiple patches, it makes the series handling for the maintainer easier. Also, please use the MAINTAINERS file to add the other maintainers. On 4/7/21 12:17 PM, Balazs Nemeth wrote: > In preparation for subsequent patches, move

Re: [dpdk-dev] [PATCH v4] ethdev: add sanity checks in control APIs

2021-04-15 Thread Andrew Rybchenko
On 4/15/21 3:20 PM, Thomas Monjalon wrote: > 15/04/2021 14:03, Andrew Rybchenko: >> On 4/15/21 2:57 PM, Thomas Monjalon wrote: >>> 15/04/2021 10:15, Andrew Rybchenko: > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, -ENOTSUP); In theory, the first argument is sufficient to make th

Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 1:36 PM, Thomas Monjalon wrote: 15/04/2021 14:33, Ferruh Yigit: On 4/15/2021 3:40 AM, Lijun Ou wrote: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this pa

Re: [dpdk-dev] [PATCH] net/virtio: fix vhost_kernel_set_owner for multi-queue devices

2021-04-15 Thread Ferruh Yigit
On 4/13/2021 9:45 AM, Maxime Coquelin wrote: Hi Thierry, On 4/8/21 2:37 PM, Thierry Herbelot wrote: Restore the original code, where VHOST_SET_OWNER is applied to all vhostfds of the device. Fixes: 06856cabb89b0 ("net/virtio: add virtio-user ops to set owner") Cc: Maxime Coquelin Cc: Chenbo X

Re: [dpdk-dev] [dpdk-stable] [v2] test/mempool: fix heap buffer overflow

2021-04-15 Thread Aaron Conole
Olivier Matz writes: > On Tue, Apr 13, 2021 at 01:52:26PM +0200, Thomas Monjalon wrote: >> 13/04/2021 22:05, Wenwu Ma: >> > Amount of allocated memory was not enough for mempool >> > which cause buffer overflow when access fields of mempool >> > private structure in the rte_pktmbuf_priv_size func

Re: [dpdk-dev] [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ

2021-04-15 Thread Raslan Darawsheh
Hi Li, > -Original Message- > From: Li Zhang > Sent: Wednesday, April 14, 2021 5:58 AM > To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; Roni > Bar Yanai > Subject: [PATCH v4 10/14]

Re: [dpdk-dev] [PATCH v3] net/hns3: rename Rx burst API

2021-04-15 Thread Ferruh Yigit
On 4/15/2021 9:35 AM, Min Hu (Connor) wrote: From: Chengwen Feng Currently, user could use runtime config "rx_func_hint=simple" to select the hns3_recv_pkts API, but the API's name get from rte_eth_rx_burst_mode_get is "Scalar" which has not reflected "simple". So this patch renames hns3_recv_

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-04-15 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, March 31, 2021 2:39 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; david.march...@redhat.com; > honnappa.nagaraha...@arm.com; dev@dpdk.org > Subject: Re: [PATCH v4] build: add platform meson option > > On Wed, Mar 31, 2

Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information

2021-04-15 Thread Thomas Monjalon
15/04/2021 14:45, Ferruh Yigit: > On 4/15/2021 1:36 PM, Thomas Monjalon wrote: > > 15/04/2021 14:33, Ferruh Yigit: > >> On 4/15/2021 3:40 AM, Lijun Ou wrote: > >>> Currently, upper-layer application could get queue state only > >>> through pointers such as dev->data->tx_queue_state[queue_id], > >>>

Re: [dpdk-dev] [PATCH v4] build: add platform meson option

2021-04-15 Thread Bruce Richardson
On Thu, Apr 15, 2021 at 01:32:08PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Wednesday, March 31, 2021 2:39 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; david.march...@redhat.com; > > honnappa.nagaraha...@arm.com; dev@dpdk.org > >

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs

2021-04-15 Thread Andrew Rybchenko
On 4/10/21 5:03 PM, Bing Zhao wrote: > Right now, rte_flow_shared_action_* APIs are used for some shared > actions, like RSS, count. The shared action should be created before > using it inside a flow. These shared actions sometimes are not > really shared but just some indirect actions decoupled f

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs

2021-04-15 Thread Thomas Monjalon
15/04/2021 15:55, Andrew Rybchenko: > On 4/10/21 5:03 PM, Bing Zhao wrote: > > Right now, rte_flow_shared_action_* APIs are used for some shared > > actions, like RSS, count. The shared action should be created before > > using it inside a flow. These shared actions sometimes are not > > really sha

Re: [dpdk-dev] [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ

2021-04-15 Thread Li Zhang
Hi Raslan, Thanks. I will fix in the next patch. Regards, Li Zhang > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, April 15, 2021 9:05 PM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler > Cc: dev@dpdk.org; NBU-Contact-Thom

Re: [dpdk-dev] [PATCH v2] eal: declare extern "C" linkage when building with __cplusplus

2021-04-15 Thread David Marchand
On Wed, Mar 17, 2021 at 5:14 PM Tyler Retzlaff wrote: > > Add missing extern "C" linkage for rte_reciprocal.h consistent with > other eal headers. > > Fixes: ffe3ec811ef5 ("sched: introduce reciprocal divide") > Cc: sta...@dpdk.org > > Signed-off-by: Tyler Retzlaff Acked-by: David Marchand Appl

Re: [dpdk-dev] [PATCH] eal/linux: add operation LOCK_NB to flock()

2021-04-15 Thread Burakov, Anatoly
On 25-Mar-21 8:21 AM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang The hugepage of different size, 2MB, 1GB may be mounted on the same directory (e.g /dev/hugepages). Then dpdk primary process will be blocked. To address this issue, add the LOCK_NB flags to flock(). $ cat /proc/mounts .

Re: [dpdk-dev] [PATCH v7 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-15 Thread David Marchand
On Thu, Apr 15, 2021 at 10:44 AM Walsh, Conor wrote: > > > > > > > > > The IPv6 subnets used were not within the 2001:200::/48 subnet > > > > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > > etc... > > > > Err... all t

Re: [dpdk-dev] [PATCH v7 2/5] examples/l3fwd: move l3fwd routes to common header

2021-04-15 Thread David Marchand
On Tue, Apr 6, 2021 at 1:11 PM Conor Walsh wrote: > > To prevent code duplication from the addition of lookup methods > the routes specified in lpm should be moved to a common header. > > Signed-off-by: Conor Walsh > Acked-by: Konstantin Ananyev > Acked-by: Vladimir Medvedkin > --- > examples/

Re: [dpdk-dev] [PATCH v7 4/5] examples/l3fwd: implement FIB lookup method

2021-04-15 Thread David Marchand
On Tue, Apr 6, 2021 at 1:11 PM Conor Walsh wrote: > > This patch implements the Forwarding Information Base (FIB) library > in l3fwd using the function calls and infrastructure introduced in > the previous patch. This probably helped for reviews, but I will squash this into the previous patches +

Re: [dpdk-dev] [PATCH v2] raw/octeontx2_dma: fix unavailable PCI device in dpivf

2021-04-15 Thread Thomas Monjalon
09/04/2021 10:06, Radha Mohan Chintakuntla: > The PCI device address is being used for sending mailbox which was > introduced in previous commit which replaced the macros so that > multiple DPI blocks in the hardware can be supported. The sentence is too long and complex. My advice: make multiple

Re: [dpdk-dev] [PATCH v7 5/5] doc/guides/l3_forward: update documentation for FIB

2021-04-15 Thread David Marchand
On Tue, Apr 6, 2021 at 1:11 PM Conor Walsh wrote: > > The purpose of this patch is to update the l3fwd user guide to include > the changes proposed in this patchset. > > Signed-off-by: Conor Walsh > Acked-by: John McNamara > --- > doc/guides/sample_app_ug/l3_forward.rst | 113 ++

Re: [dpdk-dev] [EXT] [dpdk-dev v2] cryptodev: change raw data path dequeue API

2021-04-15 Thread Akhil Goyal
> > Hi Akhil, > > It is possible the user don't know how many ops to dequeue. > For example in VPP crypto up to 64 buffers (vnet_crypto_async_frame_elt_t) > are wrapped into the following data structure > > typedef struct > { > CLIB_CACHE_LINE_ALIGN_MARK (cacheline0); > vnet_crypto_async_fra

Re: [dpdk-dev] [PATCH v4 0/4] add travis ci support for ppc64le

2021-04-15 Thread Christian Ehrhardt
On Thu, Apr 2, 2020 at 7:13 PM David Wilder wrote: > > This patch series adds Travis gcc compilation jobs and unit testing > for ppc64le. Limitations for ppc64le are similar to arm64 (see commit > 31bb45bcfd). > > 1. Only gcc builds are supported on ppc64le. > 2. Hugepages are not available in th

Re: [dpdk-dev] [PATCH v3 1/2] telemetry: fix missing check for thread creation

2021-04-15 Thread David Marchand
On Thu, Apr 15, 2021 at 1:50 PM Min Hu (Connor) wrote: > diff --git a/lib/librte_telemetry/telemetry.c > b/lib/librte_telemetry/telemetry.c > index 7e08afd..e6a99f3 100644 > --- a/lib/librte_telemetry/telemetry.c > +++ b/lib/librte_telemetry/telemetry.c > @@ -350,6 +350,7 @@ socket_listener(void

Re: [dpdk-dev] [PATCH v7 5/5] doc/guides/l3_forward: update documentation for FIB

2021-04-15 Thread David Marchand
On Tue, Apr 6, 2021 at 1:11 PM Conor Walsh wrote: > +/* populate the FIB table */ > + > +for (i = 0; i < IPV4_L3FWD_NUM_ROUTES; i++) { > +struct in_addr in; > + > +/* skip unused ports */ > +if ((1 << ipv4_l3fwd_fib_route_array[i].if_out & > ena

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add packet integrity checks

2021-04-15 Thread Ori Kam
Hi Ajit, > -Original Message- > From: Ajit Khaparde > Subject: Re: [PATCH v5 1/2] ethdev: add packet integrity checks > > On Wed, Apr 14, 2021 at 9:10 AM Gregory Etelson > wrote: > > > > From: Ori Kam > > > > Currently, DPDK application can offload the checksum check, > > and report it

[dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD

2021-04-15 Thread Li Zhang
To support more meters and better performance, MLX HW provide ASO flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the ASO flow meter for mlx5 driver. MLX5 PMD driver will be responsible for ASO

[dpdk-dev] [PATCH v5 01/14] net/mlx5: support three level table walk

2021-04-15 Thread Li Zhang
From: Suanming Mou This commit adds table entry walk for the three level table. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_utils.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/

[dpdk-dev] [PATCH v5 02/14] common/mlx5: add color register idle bits definition

2021-04-15 Thread Li Zhang
From: Shun Hao 8 bits are used for meter color in meter register. When the meter register can be shared, the rest 24 bits can be used by others. This adds the definination for the 24 bits that can be shared. Signed-off-by: Shun Hao Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 6

[dpdk-dev] [PATCH v5 05/14] net/mlx5: use mask for meter register setting

2021-04-15 Thread Li Zhang
From: Shun Hao ASO meter feature may require to locate the flow context tag action after the ASO action. When color register is shared by meter_id/flow_id, it's like: Bits[0-7] A meter color value set by the HW. Bits[8-31] A flow id and meter id set by SW. Currently the tag action for meter writ

[dpdk-dev] [PATCH v5 06/14] common/mlx5: add definitions for ASO flow meter

2021-04-15 Thread Li Zhang
This patch adds different PRM definitions, related to ASO flow meter feature, in MLX5 PMD code. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 75 -- 1 file changed, 71 insertions(+), 4 deletions(-) diff --git a/drivers/common

[dpdk-dev] [PATCH v5 03/14] net/mlx5: fix meter statistics

2021-04-15 Thread Li Zhang
From: Shun Hao Currently, packets after meter will be steered to a global policer table, which includes green/red color rules for every meter, so as to have counter statistics of each color in every meter. There's a bug that all the rules in global policer table are matching only color criteria,

[dpdk-dev] [PATCH v5 08/14] common/mlx5: add DevX API to create ASO flow meter object

2021-04-15 Thread Li Zhang
Add DevX API to create ASO flow meter object. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 18 +- drivers/common/mlx5/version.map | 1 + 3 files changed, 72 insertio

  1   2   >