On 3/4/21 5:30 PM, Xueming Li wrote:
> The NIC can have multiple PCIe links and can be attached to multiple
> hosts, for example the same single NIC can be shared for multiple server
> units in the rack. On each PCIe link NIC can provide multiple PFs and
> VFs/SFs based on these ones. The full repr
> Subject: [dpdk-dev] [PATCH] eal/windows: fix default thread priority
>
> The hard-coded thread priority for Windows threads in eal is
> REALTIME_PRIORITY_CLASS/THREAD_PRIORITY_TIME_CRITICAL.
>
> This results in issues with DPDK threads causing OS thread starvation and
> eventually a bugcheck.
>
Add support for aarch32 cross build in meson and add aarch64 -> aarch32
cross build to Travis.
Aarch32 is an execution state that allows execution of 32-bit code on
armv8 machines. This execution state contains a superset of previous
armv7 32-bit instructions and features. Thus the aarch32 build i
From: Ruifeng Wang
The sfc PMD was enabled for aarch32 which is 32-bit mode but has
cpu_family set to aarch64.
As sfc support only 64-bit system, it should be disabled for aarch32.
Updated meson file to disable sfc for aarch32 build.
Fixes: 141d2870675a ("net/sfc: support aarch64 architecture")
From: Ruifeng Wang
NEON vector path of the PMD needs aarch64 support. But it was
enabled for aarch32 build as well because aarch32 build had
cpu_family set to aarch64. So build for aarch32 will fail due
to unsupported intrinsics.
Fix aarch32 build by updating meson file to exclude NEON vector
im
NEON vector path of the PMD needs aarch64 support. But it was
enabled for aarch32 build as well because aarch32 build had
cpu_family set to aarch64. So build for aarch32 will fail due
to unsupported intrinsics.
Fix aarch32 build by updating meson file to exclude NEON vector
implementation for aarc
Add aarch32 extra build flags and aarch32 machine flags to generic
machine args.
Also modify how arm flags are updated in meson build - for 32-bit build,
update only if cross-compiling.
Signed-off-by: Juraj Linkeš
Acked-by: Ruifeng Wang
---
config/arm/meson.build | 24 +---
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf-
toolset which comes with standard packages on most used systems, such as
Ubuntu and CentOS.
Signed-off-by: Juraj Linkeš
Acked-by: Ruifeng Wang
---
config/arm/arm32_armv8a_linux_gcc | 17 +
1 file changed, 1
Add two jobs (static and shared libs), both building on aarch64 and
producing 32-bit arm binaries executable on armv8-a, but not armv7.
Do not run tests in these jobs.
Signed-off-by: Juraj Linkeš
Reviewed-by: Ruifeng Wang
Acked-by: Aaron Conole
---
.ci/linux-build.sh | 7 ++-
.travis.yml
From: Phil Yang
Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host.
Signed-off-by: Phil Yang
Acked-by: Ruifeng Wang
---
.../linux_gsg/cross_build_dpdk_for_arm64.rst | 37 +++
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/doc/guides/linux_gsg
On 3/8/2021 11:39 AM, Ferruh Yigit wrote:
Signed-off-by: Ferruh Yigit
Acked-by: Bruce Richardson
Applied to dpdk-next-net/main, thanks.
Hi Thomas, David,
Is there anything missing in this patch? We have some acks and reviewed-by.
Maybe add more documentation? If so, where?
Thanks,
Juuraj
> -Original Message-
> From: Juraj Linkeš
> Sent: Thursday, February 18, 2021 3:13 PM
> To: bruce.richard...@intel.com; tho...@monjal
Hi Folks,
Does anyone have any comments? Is the patch ready? If so, please send acks or
reviewed-by, thanks.
Andrew, did you get a chance to test the patch?
Juraj
> -Original Message-
> From: Juraj Linkeš
> Sent: Thursday, February 11, 2021 2:00 PM
> To: bruce.richard...@intel.com; th
在 2021/3/9 1:33, Ferruh Yigit 写道:
On 3/5/2021 9:57 AM, Lijun Ou wrote:
From: Chengwen Feng
This patch support tx_done_cleanup command:
tx_done_cleanup port (port_id) (queue_id) (free_cnt)
Users must make sure there are no concurrent access to the same Tx
queue (like rte_eth_tx_burst, rte_e
Honnappa, Thomas, Bruce, Jerin, you've comments in the past. Do you have any
further input?
I think we just need to agree on the allowlist/blocklist mechanism. The current
commit allows specifying either an allowlist or a blocklist, but not both.
However, it would possible to implement specifyi
On 2/28/21 10:48 PM, Ori Kam wrote:
> Currently, DPDK application can offload the checksum check,
> and report it in the mbuf.
>
> However, this approach doesn't work if the traffic
> is offloaded and should not arrive to the application.
>
> This commit introduces rte flow item that enables
> matc
The return value of rte_pci_read_config should be checked.
Coverity issue: 302860
Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Wang
---
drivers/vdpa/ifc/base/ifcvf.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dri
Hi, Jerin
Sorry to disturb you. Would you please help review this patch when you are free?
Thanks very much.
Best Regards
Feifei
> -邮件原件-
> 发件人: Feifei Wang
> 发送时间: 2021年2月25日 17:32
> 收件人: jer...@marvell.com; Sunil Kumar Kori ; David
> Marchand
> 抄送: dev@dpdk.org; nd ; Feifei Wang
> ;
09/03/2021 10:01, Andrew Rybchenko:
> On 2/28/21 10:48 PM, Ori Kam wrote:
> > Currently, DPDK application can offload the checksum check,
> > and report it in the mbuf.
> >
> > However, this approach doesn't work if the traffic
> > is offloaded and should not arrive to the application.
> >
> > This
Few adjustments of debug log usage in mlx4/mlx5.
v2:
- fix a typo in an old log
- separate commit for line feed fixes (and fix more)
Thomas Monjalon (4):
net/mlx4: enable debug logs dynamically
common/mlx5: enable debug logs dynamically
common/mlx5: remove extra line feed in log mes
The macro DEBUG was doing nothing if not compiled with
RTE_LIBRTE_MLX4_DEBUG.
As it is not used in the data path, it can be always enabled at
compilation time. Then it can be enabled at runtime with:
--log-level pmd.net.mlx4:debug
Signed-off-by: Thomas Monjalon
---
drivers/net/mlx4/mlx4
Most debug logs are using DRV_LOG(DEBUG,)
but some were using DEBUG().
The macro DEBUG is doing nothing if not compiled with
RTE_LIBRTE_MLX5_DEBUG.
As it is not used in the data path, the macro DEBUG
can be replaced with DRV_LOG.
Then all debug logs can be enabled at runtime with:
--log-le
The macro DRV_LOG already includes a terminating line feed character
defined in PMD_DRV_LOG_.
The extra line feeds added in some messages are removed.
Signed-off-by: Thomas Monjalon
---
drivers/common/mlx5/mlx5_common_pci.c | 4 ++--
drivers/common/mlx5/mlx5_devx_cmds.c | 2 +-
drivers/compress
Having to force an alignment does not impact the user,
so it should not be a warning.
The log level is reduced from warning to debug.
Signed-off-by: Thomas Monjalon
---
drivers/net/mlx5/mlx5_utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_uti
On 3/9/2021 8:49 AM, oulijun wrote:
在 2021/3/9 1:33, Ferruh Yigit 写道:
On 3/5/2021 9:57 AM, Lijun Ou wrote:
From: Chengwen Feng
This patch support tx_done_cleanup command:
tx_done_cleanup port (port_id) (queue_id) (free_cnt)
Users must make sure there are no concurrent access to the same Tx
09/03/2021 10:53, Ferruh Yigit:
> On 3/9/2021 8:49 AM, oulijun wrote:
> > 2021/3/9 1:33, Ferruh Yigit:
> >> Similar to above comment 'rte_eth_devices' is the internal variable,
> >> applications should not access it directly.
> >>
> > No API is available, and multiple references exist in the testp
On 3/9/21 12:57 PM, Thomas Monjalon wrote:
> 09/03/2021 10:53, Ferruh Yigit:
>> On 3/9/2021 8:49 AM, oulijun wrote:
>>> 2021/3/9 1:33, Ferruh Yigit:
Similar to above comment 'rte_eth_devices' is the internal variable,
applications should not access it directly.
>>> No API is availab
https://bugs.dpdk.org/show_bug.cgi?id=650
Bug ID: 650
Summary: af_xdp：the packets in complete_queue can't match the
tx_queue
Product: DPDK
Version: 20.05
Hardware: x86
OS: Linux
Status: UNCONFIRM
>The measure_perf function should be executed after worker threads
>exit
>to collect correct perf data. Otherwise, while workers are running, the
>main thread may get incomplete data from workers.
>
>In the meanwhile, remove unnecessary barrier in the test.
>For signal variables "ldata.done" and "l
> -Original Message-
> From: luca.bocca...@gmail.com
> Sent: Monday, February 22, 2021 3:09 PM
> To: sta...@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe ;
> Akhil Goyal ; Ali Alnubani ;
> Walker, Benjamin ; David Christensen
> ; Govindharajan, Hariprasad
> ; Hemant Agrawal
> ; Stokes,
Single-core performance of AF_XDP at high loads can be poor because
a heavily loaded NAPI context will never enter or allow for busy-polling.
1C testpmd rxonly (both IRQs and PMD on core 0):
./dpdk-testpmd -l 0-1 --vdev=net_af_xdp0,iface=eth0 --main-lcore=1 -- \
--forward-mode=rxonly
0.088Mpps
In
Prior to this commit, the maximum batch sizes for zero-copy and copy-mode
rx and copy-mode tx were set to 32. Apart from zero-copy tx, the user
could never rx/tx any more than 32 packets at a time and without inspecting
the code the user wouldn't be aware of this.
This commit removes these upper l
poll() is more expensive and requires more tuning
when used with the upcoming busy polling functionality.
Signed-off-by: Ciara Loftus
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/n
This commit introduces support for preferred busy polling
to the AF_XDP PMD. This feature aims to improve single-core
performance for AF_XDP sockets under heavy load.
A new vdev arg is introduced called 'busy_budget' whose default
value is 64. busy_budget is the value supplied to the kernel
with t
On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš wrote:
> Honnappa, Thomas, Bruce, Jerin, you've comments in the past. Do you have any
> further input?
>
> I think we just need to agree on the allowlist/blocklist mechanism. The
> current commit allows specifying either an allowlist or a bl
On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote:
> If the telemetry library initialization has some issue,
> the error message is returned in a string
> (to avoid circular dependency with EAL log system).
>
> In order to make clear where the message comes from,
> a prefix is added.
On 3/8/2021 10:29 PM, Ed Czeck wrote:
- New PCIe IDs using net/ark driver
- Update Version IDs and structures specified by hardware
- New internal descriptor status for TX
- Adjust data placement in RX operations, headroom in retained
for segmented mbufs
Signed-off-by: Ed Czeck
---
doc/guides
On 3/8/2021 10:29 PM, Ed Czeck wrote:
- Rename extension functions with rte_pmd_ark prefix
- Move extension prototype to rte_pmd_ark.h
- Update documentation for extension
Hi Ed,
I think better to have the documentation with the previous patch, where it has
the hooks.
It has a benefit to have
> -Original Message-
> From: Bruce Richardson
> Sent: Tuesday, March 9, 2021 11:57 AM
> To: Juraj Linkeš
> Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com;
> phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com;
> jerinjac...@gmail.com; hemant.agra...@nxp.com;
> ajit.k
On 3/8/2021 10:34 PM, Ajit Khaparde wrote:
Fix formatting in testpmd user guide for hairpin operation.
Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
Cc:sta...@dpdk.org
Signed-off-by: Ajit Khaparde
Cc: Bing Zhao
Cc: Ori Kam
---
doc/guides/testpmd_app_ug/run_app.rst | 12 +
On Tue, Mar 9, 2021 at 2:36 PM Feifei Wang wrote:
>
> Hi, Jerin
>
> Sorry to disturb you. Would you please help review this patch when you are
> free?
Sure. See below.
> Thanks very much.
>
> Best Regards
> Feifei
>
> > -邮件原件-
> > 发件人: Feifei Wang
> > 发送时间: 2021年2月25日 17:32
> > 收件人: je
On Tue, Mar 9, 2021 at 5:19 PM Juraj Linkeš wrote:
>
>
>
> > -Original Message-
> > From: Bruce Richardson
> > Sent: Tuesday, March 9, 2021 11:57 AM
> > To: Juraj Linkeš
> > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com;
> > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak..
Updates the documentation for supported sample actions in the NIC Rx
and E-Switch steering flow.
Signed-off-by: Jiawei Wang
Acked-by: Viacheslav Ovsiienko
---
doc/guides/nics/mlx5.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index
Update documentation for sample action usage in testpmd and
show the command line example.
Signed-off-by: Jiawei Wang
Acked-by: Viacheslav Ovsiienko
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 60 +
1 file changed, 60 insertions(+)
diff --git a/doc/guides/test
On 3/3/2021 10:19 PM, Alexander Kozyrev wrote:
Field IDs for the MODIFY_FIELD action lack doxygen comments
and not visible in online DPDK documentation because of that.
Provide a meaningful description for every Field ID for the
rte_flow_field_id enumeration.
Fixes: 73b68f4c54 ("ethdev: introduc
09/03/2021 14:09, Jiawei Wang:
> + - Supports ``MARK``, ``COUNT``, ``QUEUE``, ``RSS`` as sample actions for
> NIC Rx sampling/mirroring flow.
"sample actions for NIC Rx sampling" is redundant.
I suggest "Supports [...] actions for NIC Rx flow sampling/mirroring."
> + - Supports ``RAW ENCAP``,
Juraj Linkeš writes:
> From: Phil Yang
>
> Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host.
>
> Signed-off-by: Phil Yang
> Acked-by: Ruifeng Wang
> ---
Acked-by: Aaron Conole
Ferruh Yigit writes:
> On 3/9/2021 8:49 AM, oulijun wrote:
>>
>>
>> 在 2021/3/9 1:33, Ferruh Yigit 写道:
>>> On 3/5/2021 9:57 AM, Lijun Ou wrote:
From: Chengwen Feng
This patch support tx_done_cleanup command:
tx_done_cleanup port (port_id) (queue_id) (free_cnt)
Users
On Tue, Mar 09, 2021 at 10:59:52AM +, Bruce Richardson wrote:
> On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote:
> > If the telemetry library initialization has some issue,
> > the error message is returned in a string
> > (to avoid circular dependency with EAL log system).
> >
On 3/9/2021 2:00 PM, Aaron Conole wrote:
Ferruh Yigit writes:
On 3/9/2021 8:49 AM, oulijun wrote:
在 2021/3/9 1:33, Ferruh Yigit 写道:
On 3/5/2021 9:57 AM, Lijun Ou wrote:
From: Chengwen Feng
This patch support tx_done_cleanup command:
tx_done_cleanup port (port_id) (queue_id) (free_cnt)
On 3/5/2021 11:23 AM, Jiawen Wu wrote:
For more different devices, update device ID and subsystem id.
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_devids.h | 44 ++---
drivers/net/txgbe/base/txgbe_hw.c | 55 ---
drivers/net/txgbe/base
On 3/5/2021 11:23 AM, Jiawen Wu wrote:
Use some configuration to control the link setup flow, to adapt to
different NIC's construction. Use firmware version to control the impact
of firmware update. And fix some left bugs.
Signed-off-by: Jiawen Wu
---
config/rte_config.h |
Hi
> -Original Message-
> From: dev On Behalf Of Thomas Monjalon
> Sent: Tuesday, March 9, 2021 11:11 AM
> Subject: Re: [dpdk-dev] [RFC] ethdev: add sanity packet checks
>
> 09/03/2021 10:01, Andrew Rybchenko:
> > On 2/28/21 10:48 PM, Ori Kam wrote:
> > > Currently, DPDK application can
> > >
> > > On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš wrote:
> > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the past. Do
> > > > you have
> > > any further input?
> > > >
> > > > I think we just need to agree on the allowlist/blocklist
> > > > mechanism. The current
> > >
> > >
> > > On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš wrote:
> > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the past. Do
> > > > you have
> > > any further input?
> > > >
> > > > I think we just need to agree on the allowlist/blocklist
> > > > mechanism. The current
> > >
On 3/9/21 6:08 PM, Ori Kam wrote:
> Hi
>
>> -Original Message-
>> From: dev On Behalf Of Thomas Monjalon
>> Sent: Tuesday, March 9, 2021 11:11 AM
>> Subject: Re: [dpdk-dev] [RFC] ethdev: add sanity packet checks
>>
>> 09/03/2021 10:01, Andrew Rybchenko:
>>> On 2/28/21 10:48 PM, Ori Kam wr
From: Qiming Chen
The d2146nt chip integrates the x722 controller. The i40e.ko version is
2.9.21, and the firmware version is Intel’s customized version 4.3. It has been
communicated with Intel Steven. The version is compatible. Each PF virtual
place has 16 VFs, and there are 2 Each proces
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Tuesday, March 9, 2021 4:09 PM
> To: Jerin Jacob ; Juraj Linkeš
>
> Cc: Bruce Richardson ; Ruifeng Wang
> ; vcchu...@amazon.com; Dharmik Thakkar
> ; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa...@broadcom.com) ;
> ferruh.
The DPDK testing infrastructure includes a comprehensive set of
libraries, utilities, and CI integrations for developers to test
their code changes. This isn't well documented, however.
Document the basics for adding a test suite to the infrastructure
and enabling that test suite for continuous i
tc ov watermark is intialized with computed value of
max tc ov watermark.
Signed-off-by: Savinay Dharmappa
---
lib/librte_sched/rte_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 7c56880681..cd87e688e4
> > > > >
> > > > > On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš wrote:
> > > > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the past.
> > > > > > Do you have
> > > > > any further input?
> > > > > >
> > > > > > I think we just need to agree on the allowlist/blocklist
> > > >
Fixes: b33ccdb17f55 ("net/ark: provide API for hardware modules MPU RQP and
pktdir")
Cc: sta...@dpdk.org
Signed-off-by: Ed Czeck
---
drivers/net/ark/ark_ethdev.c | 1 +
drivers/net/ark/ark_pktdir.c | 2 +-
drivers/net/ark/ark_pktdir.h | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
di
Allocate mbufs for Rx path in bulk of at least 64 buffers
to improve performance. Allow recovery even without
a Rx operation to support lack of buffers in pool.
Fixes: be410a861598 ("net/ark: add recovery for lack of mbufs")
Cc: sta...@dpdk.org
Signed-off-by: Ed Czeck
---
drivers/net/ark/ark_et
- New PCIe IDs using net/ark driver
- Update Version IDs and structures specified by hardware
- New internal descriptor status for TX
- Adjust data placement in RX operations, headroom in retained
for segmented mbufs
Signed-off-by: Ed Czeck
---
doc/guides/nics/ark.rst | 5 ++
drivers/n
- Rename extension functions with rte_pmd_ark prefix
- Move extension prototype to rte_pmd_ark.h
- Update local function documentation
Signed-off-by: Ed Czeck
---
v3:
- split function rename from previous commit
v4:
- reorder patches renaming before adding
---
drivers/net/ark/ark_ethdev.c | 32
In this commit we generalize the movement of user-specified
meta data between mbufs and FPGA AXIS tuser fields using
user-defined hook functions.
- Previous use of PMD dynfields are removed
- Hook function added to ark_user_ext
- Add hook function calls in Rx and Tx paths
- Update guide with examp
remove unnecessary includes
no functional changes
Signed-off-by: Ed Czeck
---
drivers/net/ark/ark_ethdev.c | 17 ++---
drivers/net/ark/ark_pktchkr.c | 4
drivers/net/ark/ark_pktgen.c | 20 ++--
drivers/net/ark/ark_pktgen.h | 1 +
4 files changed, 17 insertio
tc ov watermark is initialized with computed value of
max tc ov watermark.
Signed-off-by: Savinay Dharmappa
---
v2: fix spelling error.
---
lib/librte_sched/rte_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.
Aaron Conole writes:
> Bruce Richardson writes:
>
>> On Tue, Mar 02, 2021 at 10:07:26AM +0100, David Marchand wrote:
>>> On Wed, Feb 10, 2021 at 3:56 PM Aaron Conole wrote:
>>> > diff --git a/doc/guides/contributing/testing.rst
>>> > b/doc/guides/contributing/testing.rst
>>> > new file mode 10
No, I am sorry, I have not tested it. I was able to remove rte_kni from our
requirements so this is no longer a blocker for us.
-Andrew
> On Mar 9, 2021, at 3:47 AM, Juraj Linkeš wrote:
>
> Hi Folks,
>
> Does anyone have any comments? Is the patch ready? If so, please send acks or
> reviewed
On 3/9/2021 10:19 AM, Ciara Loftus wrote:
This commit introduces support for preferred busy polling
to the AF_XDP PMD. This feature aims to improve single-core
performance for AF_XDP sockets under heavy load.
A new vdev arg is introduced called 'busy_budget' whose default
value is 64. busy_budge
On 3/9/2021 10:19 AM, Ciara Loftus wrote:
Prior to this commit, the maximum batch sizes for zero-copy and copy-mode
rx and copy-mode tx were set to 32. Apart from zero-copy tx, the user
could never rx/tx any more than 32 packets at a time and without inspecting
the code the user wouldn't be aware
On 3/9/2021 4:08 PM, Ed Czeck wrote:
In this commit we generalize the movement of user-specified
meta data between mbufs and FPGA AXIS tuser fields using
user-defined hook functions.
- Previous use of PMD dynfields are removed
- Hook function added to ark_user_ext
- Add hook function calls in Rx
On 3/9/2021 4:08 PM, Ed Czeck wrote:
- Rename extension functions with rte_pmd_ark prefix
- Move extension prototype to rte_pmd_ark.h
- Update local function documentation
Signed-off-by: Ed Czeck
---
v3:
- split function rename from previous commit
v4:
- reorder patches renaming before adding
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Tuesday, March 9, 2021 5:05 PM
> To: Juraj Linkeš ; Jerin Jacob
>
> Cc: Bruce Richardson ; Ruifeng Wang
> ; vcchu...@amazon.com; Dharmik Thakkar
> ; hemant.agra...@nxp.com; Ajit Khaparde
> (ajit.khapa...@broadcom.com) ;
> ferruh.
Dear Team,
we are using 18.11.1-6WIND DPDK. we are trying to get EAL Debug messages
and we are not able to see any one from them in /var/log/messages. Kindly
let me know --log-level=8 is enough or --log-level=*8 is correct OR
--log-level=eal,debug is correct ?
Appreciate your quick response.
reg
Hi
> -Original Message-
> From: Ajit Khaparde
> Subject: Re: [dpdk-dev] [RFC] ethdev: add sanity packet checks
>
> On Sun, Mar 7, 2021 at 10:46 AM Ori Kam wrote:
> >
> > Hi
> >
> > > -Original Message-
> > > From: Thomas Monjalon
> > > Sent: Thursday, March 4, 2021 12:46 PM
> >
Hi Andrew,
Thanks for the reply PDB,
> -Original Message-
> From: Andrew Rybchenko
> Sent: Tuesday, March 9, 2021 5:28 PM
> Subject: Re: [dpdk-dev] [RFC] ethdev: add sanity packet checks
>
> On 3/9/21 6:08 PM, Ori Kam wrote:
> > Hi
> >
> >> -Original Message-
> >> From: dev On B
> >
> > > > > > >
> > > > > > > On Tue, Mar 09, 2021 at 08:58:39AM +, Juraj Linkeš wrote:
> > > > > > > > Honnappa, Thomas, Bruce, Jerin, you've comments in the past.
> > > > > > > > Do you have
> > > > > > > any further input?
> > > > > > > >
> > > > > > > > I think we just need to agree on t
Hi Shijith,
Please see a question in-line:
> -Original Message-
> From: Shijith Thotton
> Sent: Monday, March 8, 2021 2:46 PM
> To: Carrillo, Erik G
> Cc: Shijith Thotton ; Pavan Nikhilesh
> ; Jerin Jacob ;
> dev@dpdk.org
> Subject: [PATCH 1/3] eventdev: introduce adapter flags for peri
On Wed, 10 Mar 2021 00:30:24 +0530
Shanmugasundaram M wrote:
> Dear Team,
>
> we are using 18.11.1-6WIND DPDK. we are trying to get EAL Debug messages
> and we are not able to see any one from them in /var/log/messages. Kindly
> let me know --log-level=8 is enough or --log-level=*8 is correct O
2021-02-18 13:40 (UTC+0200), Tal Shnaiderman:
> The hard-coded thread priority for Windows threads in eal
> is REALTIME_PRIORITY_CLASS/THREAD_PRIORITY_TIME_CRITICAL.
>
> This results in issues with DPDK threads causing OS thread starvation
> and eventually a bugcheck.
>
> The fix reduce the threa
The main intent of this series is to provide a nice help
for the --log-level option.
More patches are added to improve options help in general.
Thomas Monjalon (11):
eal: explain argv behaviour during init
eal: improve options usage text
eal: use macros for help option
eal: move private lo
After argument parsing done by rte_eal_init(),
the remaining arguments are to be parsed by the application
by progressing in the argv array.
In this context, the first string represented by argv[0] is still
the same program name as the original argv[0],
while the next strings are the application ar
The description of the EAL options was printed before the application
description provided via the hook.
It is better to let the application print the global syntax
and describes the detail of the EAL options below.
Also, some useless lines are removed,
and the alignment of few options is fixed.
The macros OPT_HELP and OPT_HELP_NUM were not used where appropriate.
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/common/eal_common_options.c | 2 +-
lib/librte_eal/freebsd/eal.c | 2 +-
lib/librte_eal/linux/eal.c | 2 +-
lib/librte_eal/windows/eal.c
Some private log functions had a wrong "rte_" prefix.
All private log functions are moved from eal_private.h
to the new file eal_log.h:
rte_eal_log_init -> eal_log_init
rte_log_save_regexp -> eal_log_save_regexp
rte_log_save_pattern -> eal_log_save_pattern
eal_log_s
RTE_DIM(...) and RTE_LOG_DEBUG were used to get the highest log level.
For better clarity a new constant RTE_LOG_MAX is introduced
and mapped to RTE_LOG_DEBUG.
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/common/eal_common_log.c | 8
lib/librte_eal/common/eal_common_options.c |
The parsing check for invalid log level was not trying to catch
irrelevant numeric values.
A log level 0 or too high is now a failure in options parsing
so it can be caught early.
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/common/eal_common_options.c | 2 +-
1 file changed, 1 insertion(+)
The option --log-level was not completely described in the usage text,
and it was difficult to guess the names of the log types and levels.
A new value "help" is accepted after --log-level to give more details
about the syntax and listing the log types and levels.
The array "levels" used for leve
Some applications were printing useless messages with rte_exit()
after showing the help. Using exit() is enough in this case.
Some applications were using a redundant printf or fprintf() before
calling rte_exit(). The messages are unified in a single rte_exit().
Some rte_exit() calls were missing
Use rte_set_application_usage_hook() in the test applications,
so the full help including EAL options can be printed in one go
with the EAL option -h or --help.
Signed-off-by: Thomas Monjalon
---
app/pdump/main.c | 2 ++
app/proc-info/main.c
The usage syntax help includes the program name which was fake.
It is replaced with the real name from argv.
Signed-off-by: Thomas Monjalon
---
app/test-regex/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-regex/main.c b/app/test-regex/main.c
index ba09b2
The options help text was including an incomplete and redundant
summary of the options before explaining each. The summary is dropped.
The details of the option --hairpin-mode had an extra space,
breaking the alignment with the next line.
Signed-off-by: Thomas Monjalon
---
app/test-pmd/paramete
use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign
to integer literal where the desired type is unsigned.
Signed-off-by: Tyler Retzlaff
---
lib/librte_eal/common/eal_common_fbarray.c | 12 ++--
lib/librte_power/rte_power_pmd_mgmt.c | 2 +-
2 files changed, 7 i
Dump all the flows is supported.Some customers require to dump info
for one flow. To implement this requirement,
add the CLI to dump one rule: flow dump PORT rule ID
the CLI to dump all: flow dump PORT all
Examples:
testpmd> flow dump 0 all
testpmd> flow dump 0 rule 0
Also new AP
Previous implementations support dump all the flows.Add new ones
to dump one flow.
New API added: rte_flow_dump.
Signed-off-by: Haifei Luo
---
doc/guides/nics/mlx5.rst| 10 +++--
doc/guides/prog_guide/rte_flow.rst | 44 +
lib/librte_ethdev/rte
Add support for single flow dump.
The CLIs to dump one rule: flow dump PORT rule ID
to dump all: flow dump PORT all
Examples:
testpmd> flow dump 0 all
testpmd> flow dump 0 rule 0
Signed-off-by: Haifei Luo
---
app/test-pmd/cmdline_flow.c | 55 +
app/tes
add mlx5 APIs for single flow dump feature
Signed-off-by: Haifei Luo
---
drivers/common/mlx5/linux/meson.build | 4
drivers/common/mlx5/linux/mlx5_glue.c | 13 +
drivers/common/mlx5/linux/mlx5_glue.h | 1 +
drivers/common/mlx5/mlx5_devx_cmds.c | 10 ++
drivers/common/
Add API mlx5_flow_dump_rule to support the feature.
Modify mlx5_socket since one extra arg flow_ptr is added.
Signed-off-by: Haifei Luo
---
drivers/net/mlx5/linux/mlx5_socket.c | 27 ++---
drivers/net/mlx5/mlx5.h | 3 +++
drivers/net/mlx5/mlx5_flow.c | 3
1 - 100 of 153 matches
Mail list logo
