Re: [dpdk-dev] [PATCH] config/arm: fix typo in meson config

2021-02-02 Thread Ferruh Yigit
On 2/2/2021 2:19 AM, Ruifeng Wang wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, February 2, 2021 6:42 AM To: Jan Viktorin ; Ruifeng Wang ; jer...@marvell.com; Bruce Richardson ; Juraj Linkeš ; Honnappa Nagarahalli ; Vimal Chungath Cc: Ferruh Yigit ; dev@dpdk.org; tho...@mo

Re: [dpdk-dev] [PATCH] ci: ignore APT update failure in GitHub Actions

2021-02-02 Thread David Marchand
On Mon, Feb 1, 2021 at 3:31 PM David Marchand wrote: > > Ubuntu 18.04 GHA virtual machine images point at an invalid APT > repository. > We have no control over this, simply ignore the failure. > > This was caught by Ilya for OVS and the robot just hit the same issue > for DPDK: > > """ > Get:46 h

[dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-02-02 Thread Wan Junjie
If vhost device's IOMMU feature is disabled, iotlb mempool allocation is unnecessary. Reported-by: Peng He Signed-off-by: Wan Junjie Reviewed-by: Zhihong Wang --- lib/librte_vhost/vhost.c | 4 ++-- lib/librte_vhost/vhost_user.c | 6 +- 2 files changed, 7 insertions(+), 3 deletions(-)

[dpdk-dev] [PATCH v2] config/arm: fix variable name

2021-02-02 Thread Ferruh Yigit
A config variable rename seems missed to update all config files and new config file get with old variable names. Reflect config variable rename to all config files, changed 'implementor_id' to 'implementer_id', 'implementor_pn' to 'part_number'. Fixes: 3d01d65ba0d3 ("config: add aarch64 clang fo

Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error

2021-02-02 Thread David Marchand
On Thu, Jan 28, 2021 at 10:27 PM Thomas Monjalon wrote: > > 28/01/2021 13:28, David Marchand: > > On Wed, Jan 27, 2021 at 3:47 PM Leyi Rong wrote: > > > > > > This patchset fix mingw build error when avx512 is introduced. > > > > > > --- > > > v2: > > > - Set i40e_avx512_cc_support to false to av

[dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-02-02 Thread Wan Junjie
If vhost device's IOMMU feature is disabled, iotlb mempool allocation is unnecessary. Reported-by: Peng He Signed-off-by: Wan Junjie Reviewed-by: Zhihong Wang --- lib/librte_vhost/vhost.c | 4 ++-- lib/librte_vhost/vhost_user.c | 6 +- 2 files changed, 7 insertions(+), 3 deletions(-)

Re: [dpdk-dev] [PATCH v10 0/3] pmdinfogen: rewrite in Python

2021-02-02 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v10 0/3] pmdinfogen: rewrite in Python > > External email: Use caution opening links or attachments > > > Hi Thomas, > > We have updated all UNH-IOL environments to include pyelftools. FreeBSD compilation test is still failing on the missing dependency: buildt

Re: [dpdk-dev] [PATCH] devtools: remove ethdev ABI exception

2021-02-02 Thread Kinsella, Ray
On 01/02/2021 18:08, David Marchand wrote: > Now that the ethernet driver dev_ops structure definition is not > exported anymore, there is no need for an exception. > abidiff will only consider structures defined in the installed headers > (passed with --headers-dirX options). > > Fixes: df96fd

[dpdk-dev] [RFC PATCH v2] config/arm: replace native machine args

2021-02-02 Thread Juraj Linkeš
There are compiler issues when building with -mcpu=native with popular compilers, such as GCC-8.4: In file included from ../lib/librte_eal/arm/include/rte_vect.h:11, from ../lib/librte_net/net_crc_neon.c:10: ../lib/librte_net/net_crc_neon.c: In function ‘crcr32_folding_round’: /usr

Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error

2021-02-02 Thread Rong, Leyi
> -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 4:37 PM > To: Rong, Leyi ; Dmitry Kozlyuk > > Cc: Thomas Monjalon ; Richardson, Bruce > ; Tal Shnaiderman ; Zhang, > Qi Z ; Kadam, Pallavi ; Yigit, > Ferruh ; Menon, Ranjit ; Xing, > Beilei ; dev ; Aaron Conole

[dpdk-dev] [PATCH] examples/vhost_blk: check protocol feature before get inflight info

2021-02-02 Thread Keiichi Watanabe
Avoid calling rte_vhost_get_vhost_ring_inflight() and rte_vhost_get_vring_base_from_inflight() when VHOST_USER_PROTOCOL_F_INFLIGHT_SHMFD is not set. Signed-off-by: Keiichi Watanabe --- examples/vhost_blk/vhost_blk.c | 22 +- lib/librte_vhost/rte_vhost.h | 13 +

Re: [dpdk-dev] [PATCH] app/testpmd: add PF and VF targets to flow action type sample

2021-02-02 Thread Ferruh Yigit
On 1/31/2021 8:53 AM, Ori Kam wrote: Hi, -Original Message- From: psathe...@marvell.com Sent: Monday, December 21, 2020 7:47 AM From: Satheesh Paul Add support to specify PF or VF as targets in "set sample_actions" command. Signed-off-by: Satheesh Paul Acked-by: Ori Kam Appl

Re: [dpdk-dev] [PATCH v2] config/arm: fix variable name

2021-02-02 Thread Thomas Monjalon
02/02/2021 09:35, Ferruh Yigit: > A config variable rename seems missed to update all config files and new > config file get with old variable names. > > Reflect config variable rename to all config files, changed > 'implementor_id' to 'implementer_id', > 'implementor_pn' to 'part_number'. > > Fi

Re: [dpdk-dev] [RFC PATCH v2] config/arm: replace native machine args

2021-02-02 Thread Thomas Monjalon
02/02/2021 10:05, Juraj Linkeš: > There are compiler issues when building with -mcpu=native with popular > compilers, such as GCC-8.4: > In file included from ../lib/librte_eal/arm/include/rte_vect.h:11, > from ../lib/librte_net/net_crc_neon.c:10: > ../lib/librte_net/net_crc_neon.c

Re: [dpdk-dev] [PATCH] net/virtio: fix missing listen FD initialization

2021-02-02 Thread Zhou, JunX W
Tested-by: Zhou, Jun -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, February 1, 2021 5:33 PM To: dev@dpdk.org; Wang, Yinan ; Xia, Chenbo ; amore...@redhat.com; david.march...@redhat.com; Ling, WeiX ; Jiang, YuX Cc: Maxime Coquelin ; Zhou, J

[dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW

2021-02-02 Thread Leyi Rong
Disable i40e AVX512 code path for Windows build regardless of CPU capability to avoid the MinGW build error: Error: invalid register for .seh_savexmm Signed-off-by: Leyi Rong --- drivers/net/i40e/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/meson.build

Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW

2021-02-02 Thread Thomas Monjalon
02/02/2021 10:06, Leyi Rong: > Disable i40e AVX512 code path for Windows build regardless of CPU > capability to avoid the MinGW build error: > Error: invalid register for .seh_savexmm > > Signed-off-by: Leyi Rong Please provide a "Fixes:" line.

[dpdk-dev] 回复: ixgbe and UDP with zero checksum

2021-02-02 Thread Feifei Wang
Hi, Haiyue We will release the patch to support zero checksum in arm neon path later. Best Regards Feifei > -邮件原件- > 发件人: Wang, Haiyue > 发送时间: 2021年2月2日 15:42 > 收件人: Feifei Wang ; Ruifeng Wang > > 抄送: Guo, Jia ; Aaron Conole ; > dev@dpdk.org; Yang, Qiming ; Paolo Valerio > > 主题: RE:

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread David Marchand
Hello Haiyue, Thanks for working on it quickly. Cc: ARM maintainers. On Tue, Feb 2, 2021 at 8:23 AM Haiyue Wang wrote: > > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was Maybe add a reference to the 82599 hw

Re: [dpdk-dev] [PATCH] net/mlx5: fix miniCQE configuration for Verbs

2021-02-02 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Monday, February 1, 2021 19:17 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix miniCQE configuration for Verbs > > Verbs cannot be used to configure newly

Re: [dpdk-dev] [PATCH] net/mlx5: check FW miniCQE format capabilities

2021-02-02 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, February 2, 2021 4:08 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: check FW miniCQE format capabilities > > miniCQE formats for Flow Tag and L3/L4

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: fix testpmd sample qinq flow rules

2021-02-02 Thread Ferruh Yigit
On 1/20/2021 1:42 AM, Li, Xiaoyun wrote: -Original Message- From: Iremonger, Bernard Sent: Tuesday, January 19, 2021 21:01 To: dev@dpdk.org; Li, Xiaoyun Cc: Iremonger, Bernard ; sta...@dpdk.org Subject: [PATCH v2] doc: fix testpmd sample qinq flow rules In the Testpmd Flow rules manag

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

2021-02-02 Thread David Marchand
On Mon, Feb 1, 2021 at 9:33 PM Maxime Coquelin wrote: > > VIRTIO_OPS() macro relies on the port ID stored in the > virtio_hw struct. Issue is that it is used before being > assigned at init time. It results in all devices setting > ops on port ID 0, causing crash later when calling ops > for port

Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW

2021-02-02 Thread Bruce Richardson
On Tue, Feb 02, 2021 at 05:06:39PM +0800, Leyi Rong wrote: > Disable i40e AVX512 code path for Windows build regardless of CPU > capability to avoid the MinGW build error: > Error: invalid register for .seh_savexmm > > Signed-off-by: Leyi Rong > --- > drivers/net/i40e/meson.build | 1 + >

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

2021-02-02 Thread Ling, WeiX
Tested-by: Wei Ling > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, February 2, 2021 04:32 AM > To: dev@dpdk.org; Wang, Yinan ; Xia, Chenbo > ; amore...@redhat.com; > david.march...@redhat.com; Ling, WeiX ; Jiang, YuX > > Cc: Maxime Coquelin > Subject: [PATCH v2] net/virt

[dpdk-dev] FOSDEM 2021 Software Defined Networking Devroom

2021-02-02 Thread Kinsella, Ray
FOSDEM is Europe largest gathering of Open Source contributors, usually attracting 8000+ attendees. The conference is in 4 days time and is free to attend, so now is a good time to check whether you can attend! FOSDEM 2021 Online will happen through fosdem.org/2021/schedule

[dpdk-dev] [PATCH] devtools: fix examples external compilation for x86-default

2021-02-02 Thread David Marchand
Since we don't check ABI on the x86-default target anymore, installation of the target must always happen for examples external compilation check to work. Fixes: 6a426d733ec0 ("devtools: reduce ABI checks and static binaries") Signed-off-by: David Marchand --- devtools/test-meson-builds.sh | 5

Re: [dpdk-dev] [PATCH] doc: clarify disclosure time slot when no response

2021-02-02 Thread Ferruh Yigit
On 1/25/2021 1:57 AM, Marvin Liu wrote: Sometimes security team won't send confirmation mail back to reporter in three business days. This mean reported vulnerability is either low severity or not a real vulnerability. Reporter should assume that the issue need shortest embargo. After that report

Re: [dpdk-dev] [PATCH 1/7] bus/fslmc: fix to use ci value for qbman 5.0

2021-02-02 Thread Ferruh Yigit
On 1/20/2021 2:27 PM, Hemant Agrawal wrote: From: Youri Querry since for qbman 5.0 generally, pi == ci, no need for extra checks. They are causing issue. It would be nice to document the issues, in case users encounter them, they will know this patch is fixing it. Can you please send details

Re: [dpdk-dev] [PATCH v7 08/10] buildtools/chkincs: add app to verify header includes

2021-02-02 Thread David Marchand
On Fri, Jan 29, 2021 at 5:49 PM Bruce Richardson wrote: > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > new file mode 100644 > index 00..f345e87551 > --- /dev/null > +++ b/buildtools/chkincs/meson.build > @@ -0,0 +1,36 @@ > +# SPDX-License-Identifier: BSD-3

Re: [dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len

2021-02-02 Thread Ferruh Yigit
On 1/20/2021 2:27 PM, Hemant Agrawal wrote: This patch introduce a new pmd api, which can help the applications to configure the max framelen for a given dpdmux interface Signed-off-by: Hemant Agrawal <...> +/** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without p

Re: [dpdk-dev] [PATCH 6/7] net/dpaa2: add traffic management driver

2021-02-02 Thread Ferruh Yigit
On 1/20/2021 2:27 PM, Hemant Agrawal wrote: From: Gagandeep Singh Add basic support for scheduling and shaping on dpaa2 platform. HW supports 2 level of scheduling and shaping. However the current patch only support single level. Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal ---

[dpdk-dev] [PATCH 2/2] doc: fix crypto perf script guide

2021-02-02 Thread Ciara Power
The guide for using the crypto perf graphing script had some incorrect indentation, unnecessary blank lines, and a missing argument in one of the usage examples. These are corrected in this patch. Fixes: f400e0b82bf1 ("app/crypto-perf: add script to graph perf results") Signed-off-by: Ciara Power

[dpdk-dev] [PATCH 1/2] doc: update release notes for crypto perf script

2021-02-02 Thread Ciara Power
Add release note for the new crypto perf graphing script. Signed-off-by: Ciara Power --- doc/guides/rel_notes/release_21_02.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index cc181dfd17..dc8a55f2b3

[dpdk-dev] [PATCH 0/2] Update doc for crypto perf script

2021-02-02 Thread Ciara Power
A release note is added for the new crypto perf script. Some small fixes for the script documentation are also included. Ciara Power (2): doc: update release notes for crypto perf script doc: fix crypto perf script guide doc/guides/rel_notes/release_21_02.rst | 6 ++ doc/guides/tools/cry

Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report

2021-02-02 Thread Ferruh Yigit
On 1/29/2021 1:49 AM, oulijun wrote: 在 2021/1/29 7:41, Ferruh Yigit 写道: On 1/22/2021 10:18 AM, Lijun Ou wrote: From: Chengwen Feng This patch support LSC(Link Status Change) event report. There is a user config for lsc, 'dev->data->dev_conf.intr_conf.lsc', which seems not taken into acco

Re: [dpdk-dev] [PATCH 14/14] net/hns3: support LSC event report

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 10:18 AM, Lijun Ou wrote: From: Chengwen Feng This patch support LSC(Link Status Change) event report. Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou <...> @@ -2373,8 +2408,11 @@ hns3vf_stop_service(struct hns3_adapter *hns) struct rte_eth_dev *eth_dev; e

Re: [dpdk-dev] [PATCH v2] doc: update i40e PMD to support on windows

2021-02-02 Thread Ferruh Yigit
On 1/26/2021 11:03 PM, Pallavi Kadam wrote: Add documentation to support i40e PMD on Windows. Update the release notes and features list for the same. v2 changes: - updated doc/guides/nics/features/i40e.ini file - Replaced the name UIO with NetUIO Signed-off-by: Pallavi Kadam R

Re: [dpdk-dev] [PATCH v2] net/ice: fix rss type checking

2021-02-02 Thread Zhang, Qi Z
> -Original Message- > From: Ding, Xuan > Sent: Monday, February 1, 2021 1:17 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan > Subject: [PATCH v2] net/ice: fix rss type checking > > For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mas

Re: [dpdk-dev] [PATCH v7 08/10] buildtools/chkincs: add app to verify header includes

2021-02-02 Thread Bruce Richardson
On Tue, Feb 02, 2021 at 12:36:34PM +0100, David Marchand wrote: > On Fri, Jan 29, 2021 at 5:49 PM Bruce Richardson > wrote: > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > > new file mode 100644 > > index 00..f345e87551 > > --- /dev/null > > +++ b/buildto

[dpdk-dev] [PATCH 2/2] doc: group mlx5 shared actions

2021-02-02 Thread Jack Min
Put all supported shared actions in one new table Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index e99fea4342..dbd7ae1bb9 100644 ---

[dpdk-dev] [PATCH 0/2] doc update for rte flow shared action

2021-02-02 Thread Jack Min
This series update documents as following: 1. Add more information about shared action in rte_flow.rst. 2. Group all supported shared actions in mlx5.rst Xiaoyu Min (2): doc: more info of rte flow shared action doc: group mlx5 shared actions doc/guides/nics/mlx5.rst | 30 +

[dpdk-dev] [PATCH 1/2] doc: more info of rte flow shared action

2021-02-02 Thread Jack Min
Added more information of shared action on how to update, query, and the benefits. Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 0b8c243fe1

Re: [dpdk-dev] [PATCH v2] doc: add mirror rule limitation of X722

2021-02-02 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Tuesday, February 2, 2021 12:50 PM > To: Liu, Lingyu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: add mirror rule limitation of X722 > > > > > -Original Message- > > From: Liu, Lingyu > > Sent: Tu

Re: [dpdk-dev] [PATCH] net: redefine array size macros

2021-02-02 Thread Ferruh Yigit
On 2/1/2021 10:32 PM, Andrew Boyer wrote: On Feb 1, 2021, at 5:28 PM, Thomas Monjalon > wrote: 29/01/2021 23:44, Andrew Boyer: Replace copies of size(arr)/size(arr[0]) with RTE_DIM(). Eventually all of these macro definitions should be removed. Signed-off-by: And

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
Hi David, > -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 17:45 > To: Wang, Haiyue > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin

Re: [dpdk-dev] [PATCH v2 4/13] net/ionic: use the existing array-size macro

2021-02-02 Thread Ferruh Yigit
On 1/29/2021 10:44 PM, Andrew Boyer wrote: Using the RTE_DIM() macro makes the code clearer. Signed-off-by: Andrew Boyer Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support

2021-02-02 Thread Ferruh Yigit
On 1/29/2021 10:44 PM, Andrew Boyer wrote: The ionic PMD only supports Tx queue version 1 or greater. Version 1 introduced a new SGL format with support for more fragments per descriptor. Add release notes and an explanation to the docs. Signed-off-by: Andrew Boyer Applied to dpdk-next-net/m

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread David Marchand
On Tue, Feb 2, 2021 at 1:42 PM Wang, Haiyue wrote: > > If the driver/hw can't report a valid checksum hint, it should > > announce it does not know if the checksum is valid (neither bad, nor > > good). > > > > So the workaround for udp packets (on this hw model) would be to > > report PKT_RX_L4_CK

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 17:45 > To: Wang, Haiyue > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin Jacob Koll

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, February 2, 2021 20:54 > To: Wang, Haiyue > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin Jacob Koll

Re: [dpdk-dev] [PATCH] net/enic: fix the filter type used for flow API

2021-02-02 Thread Ferruh Yigit
On 2/2/2021 12:24 AM, Hyong Youb Kim wrote: The filter type (struct filter_v2.type) should always be set to FILTER_DPDK_1, when advanced filtering is enabled in firmware. Otherwise, for some old firmware versions, the driver sets it to FILTER_USNIC_IP, and attempts to install filters fail. This b

Re: [dpdk-dev] [PATCH v2] common/mlx5: fix storing the synched MAC to internal table

2021-02-02 Thread Slava Ovsiienko
Hi, It seems there is wrong quota character in the "Fixes: " tags: ( net/mlx5: reduce Netlink commands dependencies ) With best regards, Slava > -Original Message- > From: Dey, Souvik > Sent: Tuesday, February 2, 2021 5:54 > To: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Sha

Re: [dpdk-dev] [PATCH v3] bus/pci: nvme on Windows requires class id and bus

2021-02-02 Thread Nick Connolly
Hi Tal, + /* Convert 4-digit class IDs to 6-digit format */ + if (strspn(cp + 4, "0123456789abcdefABCDEF") == 4) Maybe we can move this format string to a define in the header, something like RTE_PCI_DRV_CLASSID_FMT? I'll send out a v4 with a defi

[dpdk-dev] [PATCH v4] bus/pci: nvme on Windows requires class id and bus

2021-02-02 Thread Nick Connolly
Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID and device.bus fields. Decode the class ID from the PCI device info strings if it is present and set device.bus. Signed-off-by: Nick Connolly --- drivers/bus/pci/windows/pci.c | 18 +- 1 file changed, 17 in

[dpdk-dev] [PATCH v5] bus/pci: nvme on Windows requires class id and bus

2021-02-02 Thread Nick Connolly
Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID and device.bus fields. Decode the class ID from the PCI device info strings if it is present and set device.bus. Signed-off-by: Nick Connolly --- v5: * Add missing version history v4: * Use #define to determine length of C

Re: [dpdk-dev] [PATCH v5] bus/pci: nvme on Windows requires class id and bus

2021-02-02 Thread Tal Shnaiderman
> Subject: [PATCH v5] bus/pci: nvme on Windows requires class id and bus > > External email: Use caution opening links or attachments > > > Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID > and device.bus fields. Decode the class ID from the PCI device info strings > i

Re: [dpdk-dev] Crypto API for AES-XTS cipher algorithm

2021-02-02 Thread Matan Azrad
Yes. I'll do soon. From: Akhil Goyal Sent: Thursday, January 21, 2021 8:33 PM To: Matan Azrad ; Declan Doherty Cc: dev@dpdk.org Subject: RE: Crypto API for AES-XTS cipher algorithm External email: Use caution opening links or attachments Hi Matan, Can you send an RFC patch for the changes you

Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW

2021-02-02 Thread Tal Shnaiderman
> Subject: Re: [PATCH] net/i40e: disable AVX512 with MinGW > > External email: Use caution opening links or attachments > > > On Tue, Feb 02, 2021 at 05:06:39PM +0800, Leyi Rong wrote: > > Disable i40e AVX512 code path for Windows build regardless of CPU > > capability to avoid the MinGW build e

[dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide

2021-02-02 Thread Viacheslav Ovsiienko
The fixes: - Buffer Split offload is supported/verified on ConnectX-5 - Tx scheduling requires ConnectX-6DX and depends on firmware version Fixes: cb7b0c24c835 ("doc: update hardware offloads support in mlx5 guide") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/ml

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Wang, Haiyue
> -Original Message- > From: Wang, Haiyue > Sent: Tuesday, February 2, 2021 20:57 > To: David Marchand > Cc: dev ; pvale...@redhat.com; Aaron Conole > ; Zhang, Qi Z > ; Rong, Leyi ; Tu, Lijuan > ; dpdk > stable ; Guo, Jia ; Richardson, Bruce > ; > Ananyev, Konstantin ; Jerin Jacob Kolla

Re: [dpdk-dev] [PATCH] net/i40e: disable AVX512 with MinGW

2021-02-02 Thread Rong, Leyi
> -Original Message- > From: Tal Shnaiderman > Sent: Tuesday, February 2, 2021 10:14 PM > To: Richardson, Bruce ; Rong, Leyi > > Cc: david.march...@redhat.com; Zhang, Qi Z ; Yigit, > Ferruh ; NBU-Contact-Thomas Monjalon > ; Kadam, Pallavi ; Menon, > Ranjit ; Xing, Beilei ; > acon...@red

[dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW

2021-02-02 Thread Leyi Rong
Adds extra cflags '-fno-asynchronous-unwind-tables' to avoid the MinGW build error: Error: invalid register for .seh_savexmm Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW") Signed-off-by: Leyi Rong --- drivers/net/i40e/meson.build | 8 1 file changed, 4 insertions(+

[dpdk-dev] [PATCH] net/sfc: add 8000-series EF10 hardware TSO bug workaround

2021-02-02 Thread Ivan Malov
Innermost IP length and outer UDP datagram length must be greater than or equal to the corresponding values derived from the MSS; otherwise, the checksum offloads will break. Fixes: c1ce2ba218f8 ("net/sfc: support tunnel TSO on EF10 native Tx datapath") Fixes: 6bc985e41155 ("net/sfc: support TSO i

Re: [dpdk-dev] [PATCH] doc: fix supported feature table in mlx5 guide

2021-02-02 Thread Asaf Penso
Hi >-Original Message- >From: Viacheslav Ovsiienko >Sent: Tuesday, February 2, 2021 4:28 PM >To: dev@dpdk.org >Cc: Raslan Darawsheh ; NBU-Contact-Thomas Monjalon >; Asaf Penso ; >carsten.andr...@tu-ilmenau.de; sta...@dpdk.org >Subject: [PATCH] doc: fix supported feature table in mlx5 guid

[dpdk-dev] [PATCH] net/mlx5: fix validation for counter and age

2021-02-02 Thread Jiawei Wang
Currently old age action was implemented by flow counter and only one counter index was maintained in each flow. While there was old age action and share count action in one flow, and the same share count action in the another flow, the counter was updated if second flow was hit, so it may cause th

[dpdk-dev] [PATCH v2 1/3] doc: update release notes for crypto perf script

2021-02-02 Thread Ciara Power
Add release note for the new crypto perf graphing script. Signed-off-by: Ciara Power --- doc/guides/rel_notes/release_21_02.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index cc181dfd17..dbfb635861

[dpdk-dev] [PATCH v2 2/3] doc: fix crypto perf script guide

2021-02-02 Thread Ciara Power
The guide for using the crypto perf graphing script had some incorrect indentation, unnecessary blank lines, and a missing argument in one of the usage examples. These are corrected in this patch. Fixes: f400e0b82bf1 ("app/crypto-perf: add script to graph perf results") Signed-off-by: Ciara Power

[dpdk-dev] [PATCH v2 0/3] Update crypto perf script and doc

2021-02-02 Thread Ciara Power
This patchset contains some fixes for the crypto perf graphing script. A release note is added, and some small fixes for the script documentation are also included. The script config handling is modified to handle EAL and app parameters using the same method, which fixes a bug that some formats of

[dpdk-dev] [PATCH v2 3/3] test/cryptodev: fix handling for config parameters

2021-02-02 Thread Ciara Power
The crypto perf graphing script did not handle parsing parameters from the JSON config files correctly. A common parsing function is used for both EAL and app parameters, to ensure they are handled the same way and to reduce code duplication. Short parameters are now passed with the value being a s

Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum

2021-02-02 Thread Paolo Valerio
"Wang, Haiyue" writes: >> -Original Message- >> From: Wang, Haiyue >> Sent: Tuesday, February 2, 2021 20:57 >> To: David Marchand >> Cc: dev ; pvale...@redhat.com; Aaron Conole >> ; Zhang, Qi Z >> ; Rong, Leyi ; Tu, Lijuan >> ; dpdk >> stable ; Guo, Jia ; Richardson, Bruce >> ; >> Ana

Re: [dpdk-dev] [PATCH v1 01/20] net/txgbe: add ethdev probe and remove for VF device

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Introduce virtual function driver in txgbe PMD, add simple init and uninit function to probe and remove the device. Signed-off-by: Jiawen Wu <...> @@ -0,0 +1,12 @@ +; +; Supported features of the 'txgbe_vf' network poll mode driver. +; +; Refer to defa

[dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

2021-02-02 Thread Dey, Souvik
From: Souvik Dey As the internal MAC table is divided into Unicast and Multicast address sections, we should check the type of synched MAC address before storing it to the internal table. Currently the check is not done, and the synched MAC of 33:33:00:00:00:01 gets stored in the unicast section

Re: [dpdk-dev] [PATCH v1 05/20] net/txgbe: add interrupt operation for VF device

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Add VF device interrupt handler, support to enable and disable RX queue interrupt, and configure misx interrupt. Signed-off-by: Jiawen Wu <...> @@ -4,6 +4,8 @@ ; Refer to default.ini for the full list of available PMD features. ; [Features] +Rx i

Re: [dpdk-dev] [PATCH v1 07/20] net/txgbe: add Rx and Tx unit init for VF device

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Configure VF device with RX port. Initialize receive and transmit unit, set the receive and transmit functions. And support to check the status of RX and TX descriptors. Signed-off-by: Jiawen Wu <...> @@ -13,6 +17,9 @@ L3 checksum offload = P L4 che

Re: [dpdk-dev] [PATCH v1 16/20] net/txgbe: add some supports as PF driver implemented

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Some RXTX operations like queue setup and release, packet type get, and Tx done cleanup have been supported on PF device. There are ops functions directly added. Signed-off-by: Jiawen Wu <...> @@ -1375,6 +1380,7 @@ static const struct eth_dev_ops txgbe

Re: [dpdk-dev] [PATCH v1 18/20] net/txgbe: hardware support for VF representor

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Support to get link status and set mac address for VF representor. Signed-off-by: Jiawen Wu <...> @@ -21,6 +21,7 @@ sources = files( 'txgbe_rxtx.c', 'txgbe_tm.c', 'txgbe_vf_representor.c', + 'rte_pmd_txgbe.c' This is add

Re: [dpdk-dev] [PATCH v1 20/20] doc: update release note for txgbe

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:48 AM, Jiawen Wu wrote: Update release note to add txgbevf PMD support. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_21_02.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst inde

Re: [dpdk-dev] [PATCH v1 02/20] net/txgbe: add base code for VF driver

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Implement VF device init and uninit function with hardware operations, and negotiate with PF in mailbox. Signed-off-by: Jiawen Wu <...> +int txgbevf_get_queues(struct txgbe_hw *hw, unsigned int *num_tcs, + unsigned int *default_tc)

Re: [dpdk-dev] [PATCH v2] doc: update i40e PMD to support on windows

2021-02-02 Thread Kadam, Pallavi
On 2/2/2021 4:21 AM, Ferruh Yigit wrote: On 1/26/2021 11:03 PM, Pallavi Kadam wrote: Add documentation to support i40e PMD on Windows. Update the release notes and features list for the same. v2 changes: - updated doc/guides/nics/features/i40e.ini file - Replaced the name UIO with Net

Re: [dpdk-dev] [PATCH v1 09/20] net/txgbe: add VLAN handle support to VF driver

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: Add VLAN filter, offload and strip set support to VF driver. Signed-off-by: Jiawen Wu <...> +static int +txgbevf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) +{ + struct txgbe_hw *hw = TXGBE_DEV_HW(dev); + struct txgbe

Re: [dpdk-dev] [PATCH v1 00/20] net/txgbe: add VF driver support

2021-02-02 Thread Ferruh Yigit
On 1/22/2021 9:47 AM, Jiawen Wu wrote: This patch adds txgbevf PMD as a part of txgbe PMD. Jiawen Wu (20): net/txgbe: add ethdev probe and remove for VF device net/txgbe: add base code for VF driver net/txgbe: support add and remove VF device MAC address net/txgbe: get VF device info

Re: [dpdk-dev] [PATCH v2] crypto/octeontx2: fix null pointer dereferences

2021-02-02 Thread Akhil Goyal
> Coverity reports that pointers ip and ip6 may be dereferenced > with null value. This patch fixes this. > > Coverity issue: 365549 > Coverity issue: 365551 > > Fixes: 8f685ec2d545 ("crypto/octeontx2: support AES-CBC SHA1-HMAC") > > Signed-off-by: Ankur Dwivedi > --- > v2: > * Fixed wrong fixe

[dpdk-dev] [PATCH v3] doc: update i40e PMD to support on windows

2021-02-02 Thread Pallavi Kadam
Add documentation to support i40e PMD on Windows. Update the release notes and features list for the same. v3 changes: - Replaced the commit link with netuio README.rst documentation link v2 changes: - updated doc/guides/nics/features/i40e.ini file - Replaced the

Re: [dpdk-dev] [PATCH] devtools: add acronyms in dictionary for commit checks

2021-02-02 Thread Thomas Monjalon
01/02/2021 23:47, Ferruh Yigit: > eCPRI -> enhanced Common Public Radio Interface > FEC -> Forward Error Correction > SMP -> Symmetric Multiprocessing > > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] devtools: fix examples external compilation for x86-default

2021-02-02 Thread Thomas Monjalon
02/02/2021 11:54, David Marchand: > Since we don't check ABI on the x86-default target anymore, installation > of the target must always happen for examples external compilation check > to work. Otherwise the error is: find: ‘build-x86-default/install’: No such file or directory > > Fixes: 6a426d

Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW

2021-02-02 Thread Dmitry Kozlyuk
On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote: > Adds extra cflags '-fno-asynchronous-unwind-tables' > to avoid the MinGW build error: > Error: invalid register for .seh_savexmm > > Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW") > > Signed-off-by: Leyi Rong Tested-by: D

Re: [dpdk-dev] [PATCH] net/virtio: fix missing listen FD initialization

2021-02-02 Thread Ferruh Yigit
On 2/2/2021 9:26 AM, Zhou, JunX W wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Monday, February 1, 2021 5:33 PM To: dev@dpdk.org; Wang, Yinan ; Xia, Chenbo ; amore...@redhat.com; david.march...@redhat.com; Ling, WeiX ; Jiang, YuX Cc: Maxime

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

2021-02-02 Thread Ferruh Yigit
On 2/2/2021 10:03 AM, David Marchand wrote: On Mon, Feb 1, 2021 at 9:33 PM Maxime Coquelin wrote: VIRTIO_OPS() macro relies on the port ID stored in the virtio_hw struct. Issue is that it is used before being assigned at init time. It results in all devices setting ops on port ID 0, causing cr

Re: [dpdk-dev] [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled

2021-02-02 Thread Xia, Chenbo
> -Original Message- > From: Wan Junjie > Sent: Tuesday, February 2, 2021 4:39 PM > To: Xia, Chenbo ; Maxime Coquelin > > Cc: dev@dpdk.org; Wan Junjie ; Peng He > ; Zhihong Wang > Subject: [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled > > If vhost device's IOMMU

[dpdk-dev] [PATCH v2] net/ixgbe: fix UDP zero checksum error

2021-02-02 Thread Haiyue Wang
There is an 82599 errata that UDP frames with a zero checksum are incorrectly marked as checksum invalid by the hardware. This was leading to misleading PKT_RX_L4_CKSUM_BAD flag. This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, so the software application will then have to reco

Re: [dpdk-dev] [PATCH v2] vhost: fix vid allocation race

2021-02-02 Thread Xia, Chenbo
Hi Peng, > -Original Message- > From: Peng He > Sent: Monday, February 1, 2021 4:49 PM > To: dev@dpdk.org; Xia, Chenbo > Cc: sta...@dpdk.org > Subject: [PATCH v2] vhost: fix vid allocation race > > vhost_new_device might be called in different threads at the same time. > thread 1(config

[dpdk-dev] [PATCH 00/17] bugfixes and small functionality for hns3

2021-02-02 Thread Lijun Ou
This patch series add some bugfixes and some small functions. In order to fix some bugfixes, we had to do some code rework, for example patch[13/17]. Chengchang Tang (6): net/hns3: support module EEPROM dump net/hns3: add more registers to dump net/hns3: fix stats flip overflow net/hns3: r

[dpdk-dev] [PATCH 03/17] net/hns3: implement cleanup for Tx done

2021-02-02 Thread Lijun Ou
From: Chengwen Feng This patch add support tx_done_cleanup ops, which could support for the API rte_eth_tx_done_cleanup to free consumed mbufs on Tx ring. Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- Depends-on: series-1 ("update doc for hns3") --- doc/guides/nics/features/hns

[dpdk-dev] [PATCH 02/17] net/hns3: add more registers to dump

2021-02-02 Thread Lijun Ou
From: Chengchang Tang This patch makes more registers dumped in the dump_reg API to help loacte the fault. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- drivers/net/hns3/hns3_cmd.h | 13 drivers/net/hns3/hns3_regs.c | 171 ++- 2 file

[dpdk-dev] [PATCH 04/17] net/hns3: add enhance stats function

2021-02-02 Thread Lijun Ou
From: "Min Hu (Connor)" In current HNS3 PMD, Rx/Tx bytes and imissed from packet stats are not implemented. This patch implemented Rx/Tx bytes using soft counters. Rx/Tx bytes stats will be enabled if the macro RTE_LIBRTE_HNS3_PMD_SOFT_COUNTERS is defined. Also, Rx imissed stats was in implement

[dpdk-dev] [PATCH 01/17] net/hns3: support module EEPROM dump

2021-02-02 Thread Lijun Ou
From: Chengchang Tang This patch add support for dumping module EEPROM. Signed-off-by: Chengchang Tang Signed-off-by: Lijun Ou --- Depends-on: series-1 ("update doc for hns3") --- doc/guides/nics/features/hns3.ini | 1 + doc/guides/rel_notes/release_21_02.rst | 1 + drivers/net/h

[dpdk-dev] [PATCH 10/17] net/hns3: constraint TM peak rate

2021-02-02 Thread Lijun Ou
From: Chengwen Feng User could config Port or TC's peak rate by TM ops, but hardware does not support peak rate which lower than 1Mbps. So we constraint tm peak rate must be at least 1Mbps. Fixes: c09c7847d892 ("net/hns3: support traffic management") Signed-off-by: Chengwen Feng Signed-off-by:

[dpdk-dev] [PATCH 12/17] net/hns3: fix stats flip overflow

2021-02-02 Thread Lijun Ou
From: Chengchang Tang Currently, statistics may overflow in some scenarios. For example, if HW statistics are reset by stats reset operation, but there are still a lot of residual packets exist in the HW queues and these packets are error packets, flip may occurred because the ipacket is obtaine

[dpdk-dev] [PATCH 16/17] net/hns3: fix VF reset after MBX failed

2021-02-02 Thread Lijun Ou
From: Chengchang Tang Currently, during the VF reset, the VF will send a MBX to inform PF to reset it and the disable command bit will be set whether the MBX is successful. Generally, multiple reset attempts are made after a failure. However, because the command is diabled, all subsequent reset w

  1   2   >