On Tue, Feb 02, 2021 at 12:36:34PM +0100, David Marchand wrote:
> On Fri, Jan 29, 2021 at 5:49 PM Bruce Richardson
> <bruce.richard...@intel.com> wrote:
> > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
> > new file mode 100644
> > index 0000000000..f345e87551
> > --- /dev/null
> > +++ b/buildtools/chkincs/meson.build
> > @@ -0,0 +1,36 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2021 Intel Corporation
> > +
> > +if not get_option('check_includes')
> > + build = false
> > + subdir_done()
> > +endif
> > +
> > +if is_windows
> > + # for windows, the shebang line in the script won't work.
> > + error('option "check_includes" is not supported on windows')
> > +endif
> > +
> > +gen_c_file_for_header = find_program('gen_c_file_for_header.py')
> > +gen_c_files = generator(gen_c_file_for_header,
> > + output: '@BASENAME@.c',
> > + arguments: ['@INPUT@', '@OUTPUT@'])
> > +
> > +cflags = machine_args
> > +cflags += '-Wno-unused-function' # needed if we include generic headers
>
> With http://patchwork.dpdk.org/patch/87567/, we have no direct
> inclusion of the generic headers remaining.
> This flag could be removed.
> WDYT?
>
If it can be removed, it should be, IMHO.
/Bruce
