[dpdk-dev] [PATCH v8] net/ice: fix outer checksum unknown

2020-12-15 Thread Murphy Yang
When received tunneled packets, the testpmd output log shows 'ol_flags' value always is 'PKT_RX_OUTER_L4_CKSUM_UNKNOWN', but expected value is 'PKT_RX_OUTER_L4_CKSUM_GOOD' or 'PKT_RX_OUTER_L4_CKSUM_BAD'. Add the 'PKT_RX_OUTER_L4_CKSUM_GOOD' and 'PKT_RX_OUTER_L4_CKSUM_BAD' to 'flags' for normal pat

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate

2020-12-15 Thread Li, Xiaoyun
Hi I don't think this is right. One question: What if users want to disable rss? What you're doing right now will just make testpmd ignore "--disable-rss". BRs Xiaoyun > -Original Message- > From: dev On Behalf Of Steve Yang > Sent: Tuesday, December 15, 2020 14:13 > To: dev@dpdk.org >

[dpdk-dev] [PATCH 1/2] net/mlx5: fix Rx queue creation error flow

2020-12-15 Thread Michael Baum
In Rx queue creation, there are some validations for the Rx configuration. When one of them fails, the MR btree memory was not freed what caused a memory leak. Free it. Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Mat

[dpdk-dev] [PATCH 2/2] net/mlx5: fix Tx queue creation error flow

2020-12-15 Thread Michael Baum
In Tx queue creation, there are two validations for the Tx configuration. When one of them fails, the MR btree memory was not freed what caused a memory leak. Free it. Fixes: f6d9ab4e769f ("net/mlx5: check Tx queue size overflow") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan

Re: [dpdk-dev] [PATCH] rib: fix undefined behavior

2020-12-15 Thread David Marchand
On Tue, Dec 8, 2020 at 6:00 PM Vladimir Medvedkin wrote: > > According to GCC documentation for __builtin_clz: > Returns the number of leading 0-bits in x, > starting at the most significant bit position. > If x is 0, the result is undefined. > __builtin_clz will be called with 0 if the existing >

[dpdk-dev] [PATCH] net/i40e: fix Rx-bytes statistics

2020-12-15 Thread Zhang,Alvin
From: Alvin Zhang Update the Rx-bytes statistics by subtract CRC bytes count from original bytes count. Fixes: bd7883c07d4a ("net/i40e: refactor some stats related functions") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file changed, 1 inserti

Re: [dpdk-dev] [EXT] Re: [PATCH v1 1/2] meson: update meson build for armada drivers

2020-12-15 Thread Liron Himi
-Original Message- From: Ferruh Yigit Sent: Monday, 14 December 2020 11:57 To: Liron Himi ; bruce.richard...@intel.com Cc: dev@dpdk.org; Akhil Goyal Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers On 12/13/2020 8:06 PM, Liron Himi wrote: >

[dpdk-dev] [PATCH v2] net/ixgbe: fix fdirctrl register setting

2020-12-15 Thread dapengx . yu
From: YU DAPENG The function ixgbe_fdir_set_flexbytes_offset is used when create FDir rule for flexbytes. It set a register: FDIRCTRL.FLEX_OFFSET, which cause that even if the FDir flexbytes rule is destroyed, the rule still direct the packet and transfer it to the wrong place. It is because sett

Re: [dpdk-dev] [EXT] Re: [PATCH v1 1/2] meson: update meson build for armada drivers

2020-12-15 Thread Ferruh Yigit
On 12/15/2020 10:04 AM, Liron Himi wrote: -Original Message- From: Ferruh Yigit Sent: Monday, 14 December 2020 11:57 To: Liron Himi ; bruce.richard...@intel.com Cc: dev@dpdk.org; Akhil Goyal Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix flow descriptor allocation in Direct Verbs mode.

2020-12-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Tuesday, December 8, 2020 10:17 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; Slava > Ovsiienko ; Shahaf Shuler ; > Bing Zhao ; Xueming(Steven) Li > > Subject: [PATCH v2] net/mlx5: fix flow descri

Re: [dpdk-dev] [PATCH v1] net/iavf: fix not release memory issue in large VF

2020-12-15 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Monday, December 14, 2020 2:04 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Wang, Haiyue ; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH v1] net/iavf: fix not release memory issue in large VF > > This patch fixed the i

Re: [dpdk-dev] [PATCH] net/mlx5: fix mbufs double free in vectorized MPRQ

2020-12-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, December 10, 2020 5:14 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix mbufs double free in vectorized MPRQ > > Wrong index is used to fi

Re: [dpdk-dev] [PATCH v8] net/ice: fix outer checksum unknown

2020-12-15 Thread Zhang, Qi Z
> -Original Message- > From: Murphy Yang > Sent: Tuesday, December 15, 2020 4:11 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Rong, Leyi > ; Lu, Wenzhuo ; Yigit, Ferruh > ; Yang, MurphyX > Subject: [PATCH v8] net/ice: fix outer checksum unknown > > When re

Re: [dpdk-dev] [RFC] net/ionic: update MTU calculations

2020-12-15 Thread Ferruh Yigit
On 12/10/2020 2:46 AM, Andrew Boyer wrote: This RFC is in response to the threads about testpmd mtu settings and the deprecation of max-rx-pkt-len. It took us a while to figure out what we were supposed to be doing in this part of the API. It is not clear if max_rx_pkt_len should be an input to

Re: [dpdk-dev] [PATCH v2] net/i40e: issue with ADD VLAN from Guest

2020-12-15 Thread Dey, Souvik
Hi Guo, Ok sure will remove the extra log and submit the version 3. I have not received any other comments , so will also add your ACK in the next version then. -- Regards, Souvik From: Guo, Jia Sent: Monday, December 14, 2020 9:24 PM To: Dey, Souvik ; Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk

[dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest

2020-12-15 Thread Souvik Dey
Reset the configuration of vlan strip that would be change by the pf kernel driver when adding vlan from vf. Application cannot use rte_eth_dev_set_vlan_offload() to set the VLAN_STRIP, as this will only work for the first time when original and current config mismatch, but for all subsequent call

Re: [dpdk-dev] [PATCH v2] net/i40e: issue with ADD VLAN from Guest

2020-12-15 Thread Dey, Souvik
Hi Guo, Raised the v3 of the patch , but was not sure how to put the ACK. If you don’t mind can you please ACK the same. Thanks. https://patchwork.dpdk.org/patch/85210/ -- Regards, Souvik From: Dey, Souvik Sent: Tuesday, December 15, 2020 8:16 AM To: Guo, Jia ; Xing, Beilei ; Zhang, Qi Z Cc: d

Re: [dpdk-dev] [PATCH 3/6] net/ionic: fully implement remove-on-close

2020-12-15 Thread Ferruh Yigit
On 12/10/2020 2:22 PM, Andrew Boyer wrote: This is now required behavior for a PMD. Remove the UNMAINTAINED flag. Signed-off-by: Andrew Boyer --- MAINTAINERS | 2 +- drivers/net/ionic/ionic_ethdev.c | 41 drivers/net/ionic/ionic_lif.c

Re: [dpdk-dev] [PATCH 0/6] net/ionic: fixes for stop and start

2020-12-15 Thread Ferruh Yigit
On 12/10/2020 2:22 PM, Andrew Boyer wrote: These patches address issues found when testing port stop and start, link up and down, and queue stop and start. The UNMAINTAINED flag is removed in patch 3. Signed-off-by: Andrew Boyer Andrew Boyer (6): net/ionic: preserve RSS state unless RETA s

[dpdk-dev] FOSDEM 2021 CFP (Final Reminder)

2020-12-15 Thread Kinsella, Ray
Hi folks, This is the final reminder for the FOSDEM 2021 SDN devroom. The CFP closes at the end of this week. Details on how to submit a proposal are described in the CFP below. A small clarification on the original CFP is that the devroom will take place online on Sunday 7th February. We ho

Re: [dpdk-dev] [PATCH 1/2] common/sfc_efx/base: update MCDI headers for MAE privilege

2020-12-15 Thread Ferruh Yigit
On 12/11/2020 3:37 PM, Andrew Rybchenko wrote: On 12/11/20 6:34 PM, Ivan Malov wrote: VFs and unprivileged PFs should not be able to control MAE. Add MAE privilege to MCDI headers in order to reflect that. Fixes: 84d3fb7d7e1e ("common/sfc_efx/base: add MAE definitions to MCDI") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v2] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command

2020-12-15 Thread Ferruh Yigit
On 12/11/2020 8:48 PM, Long Li wrote: From: Long Li On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet while executing a VSP command synchronously. Instead of returning an error, ignore this packet as we don't use it for DPDK. Cc: sta...@dpdk.org Signed-off-by: Long

[dpdk-dev] [PATCH] crypto/qat: fix possible access to an uninitialized variable

2020-12-15 Thread Vladimir Medvedkin
QAT_LOG() has access to the uninitialized variable "name" Fixes: 21792c443205 ("crypto/qat: add multi-process handling of driver ID") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- drivers/crypto/qat/qat_asym_pmd.c | 8 drivers/crypto/qat/qat_sym_pmd.c | 8 2 files

[dpdk-dev] [PATCH] fib6: improve lookup performance

2020-12-15 Thread Vladimir Medvedkin
Improved performance for AVX512 FIB6 lookup by doubling the number of flows being processed Signed-off-by: Vladimir Medvedkin --- lib/librte_fib/trie_avx512.c | 230 --- 1 file changed, 153 insertions(+), 77 deletions(-) diff --git a/lib/librte_fib/trie_a

Re: [dpdk-dev] Windows support

2020-12-15 Thread Nick Connolly
There's also a blog post with some background at https://www.linkedin.com/posts/nick-connolly-36276339_storage-is-evolving-activity-6743223532664184832-8Qzq On 27/11/2020 20:13, Nick Connolly wrote: [Apologies if this is off-topic - just thought it might be of interest] Thanks to the excellent

Re: [dpdk-dev] question regarding rx checksum offload flags

2020-12-15 Thread Lance Richardson
On Mon, Dec 14, 2020 at 12:41 PM Lance Richardson wrote: > > On Thu, Sep 17, 2020 at 10:05 AM Olivier Matz wrote: > > > > Hi Lance, > > > > On Mon, Aug 24, 2020 at 04:11:45PM -0400, Lance Richardson wrote: > > > I was looking for some clarification regarding how rx checksum > > > flags should be

[dpdk-dev] [PATCH v2] meson: update meson build for armada drivers

2020-12-15 Thread lironh
From: Liron Himi With pkg-config support available within musdk library (from musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the musdk library. docs are updated with new musdk version a

[dpdk-dev] [PATCH v2] meson: update meson build for armada drivers

2020-12-15 Thread lironh
From: Liron Himi With pkg-config support available within musdk library (from musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the musdk library. docs are updated with new musdk version a

Re: [dpdk-dev] [EXT] [PATCH] net/mvneta: check allocation in rx queue flush

2020-12-15 Thread Liron Himi
-Original Message- From: wangyunjian Sent: Monday, 7 December 2020 15:08 To: Liron Himi ; dev@dpdk.org Cc: z...@semihalf.com; Lilijun (Jerry) ; xudingke ; sta...@dpdk.org Subject: RE: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush > -Original Message- >

[dpdk-dev] [Bug 601] Virtio-user PMD Cannot Send/Receive Packets when 2M Hugepages arre Enabled

2020-12-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=601 Bug ID: 601 Summary: Virtio-user PMD Cannot Send/Receive Packets when 2M Hugepages arre Enabled Product: DPDK Version: 20.11 Hardware: All OS: Linux Stat

Re: [dpdk-dev] [PATCH v2] eal/windows: add pthread TLS function support

2020-12-15 Thread Dmitry Kozlyuk
On Sun, 13 Dec 2020 22:24:37 +0200, Tal Shnaiderman wrote: > Add the following functions to the pthread shim implementation > for Windows as they are needed for thread safe rte_flow functions. > > pthread_key_create. > pthread_key_delete. > pthread_getspecific. > pthread_setspecific. > > Signed-o

Re: [dpdk-dev] [PATCH v2] eal/windows: add interrupt functions stub

2020-12-15 Thread Dmitry Kozlyuk
On Mon, 14 Dec 2020 16:26:22 -0800, Pallavi Kadam wrote: > Add some missing interrupt implementations on Windows. > Also add respective functions to export file. > > Signed-off-by: Tal Shnaiderman > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > Acked-by: Narcisa Vasile Acked-by:

[dpdk-dev] [Bug 602] rte_jhash: reading past end of stack

2020-12-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=602 Bug ID: 602 Summary: rte_jhash: reading past end of stack Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priorit

[dpdk-dev] [PATCH v2] doc: fix some statements for ice vector PMD

2020-12-15 Thread Qi Zhang
1. Add descriptions for how to select avx512 datapath. 2. Add explanation for "P" in ice.ini. Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") Fixes: 271cc8c5028a ("doc: update ice features list") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: fix statement for force-max-simd-bitwid

[dpdk-dev] [PATCH v2] doc: fix some statements for ice vector PMD

2020-12-15 Thread Qi Zhang
1. Add descriptions for how to select avx512 datapath. 2. Add explanation for "P" in ice.ini. Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") Fixes: 271cc8c5028a ("doc: update ice features list") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: fix statement for force-max-simd-bitwid

Re: [dpdk-dev] [PATCH] net/ixgbe: fix fdirctrl register setting

2020-12-15 Thread Yu, DapengX
Hi Jia, Thanks for your comments! Patch v2 has been sent, all your comments have specified answer in patch v2. -Original Message- From: Guo, Jia Sent: Tuesday, December 15, 2020 12:37 PM To: Yu, DapengX Cc: dev@dpdk.org; Yu, DapengX ; Zhang, Qi Z Subject: RE: [PATCH] net/ixgbe: fix fdi

Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest

2020-12-15 Thread Guo, Jia
Acked-by: Jeff Guo mailto:jia@intel.com>> From: Souvik Dey Sent: Tuesday, December 15, 2020 9:28 PM To: Xing, Beilei ; Guo, Jia ; Zhang, Qi Z Cc: dev@dpdk.org; Souvik Dey Subject: [PATCH v3] net/i40e: issue with ADD VLAN from Guest Reset the configuration of vlan strip that would be chang

Re: [dpdk-dev] [PATCH] crypto/qat: fix possible access to an uninitialized variable

2020-12-15 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Medvedkin, Vladimir > Sent: wtorek, 15 grudnia 2020 19:24 > To: dev@dpdk.org > Cc: Kusztal, ArkadiuszX ; Griffin, John > ; Trahe, Fiona ; Jain, Deepak K > ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix possible access to an uninitialized variable > >

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-12-15 Thread Maxime Coquelin
Hi Huawei, On 12/14/20 3:24 PM, 谢华伟(此时此刻) wrote: > Hi Maxime and David: > > Could we start to review this patch? Yes, I plan to work on it after the holidays, let's target -rc1. Thanks, Maxime > /Thanks, huawei > > > On 2020/11/10 20:42, David Marchand wrote: >> On Tue, Nov 10, 2020 at 1:35