On 12/15/2020 10:04 AM, Liron Himi wrote:
-----Original Message-----
From: Ferruh Yigit <ferruh.yi...@intel.com>
Sent: Monday, 14 December 2020 11:57
To: Liron Himi <lir...@marvell.com>; bruce.richard...@intel.com
Cc: dev@dpdk.org; Akhil Goyal <akhil.go...@nxp.com>
Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 1/2] meson: update meson build for
armada drivers
On 12/13/2020 8:06 PM, Liron Himi wrote:
-----Original Message-----
From: Ferruh Yigit <ferruh.yi...@intel.com>
Sent: Wednesday, 9 December 2020 12:50
To: Liron Himi <lir...@marvell.com>; bruce.richard...@intel.com
Cc: dev@dpdk.org; Akhil Goyal <akhil.go...@nxp.com>
Subject: [EXT] Re: [dpdk-dev] [PATCH v1 1/2] meson: update meson build
for armada drivers
External Email
----------------------------------------------------------------------
On 12/2/2020 1:05 PM, lir...@marvell.com wrote:
From: Liron Himi <lir...@marvell.com>
With pkg-config support available within musdk library, meson option
'lib_musdk_dir' can be removed.
PKG_CONFIG_PATH environment variable should be set appropriately to
use the musdk library.
Signed-off-by: Liron Himi <lir...@marvell.com>
Reviewed-by: Liron Himi <lir...@marvell.com>
---
drivers/common/mvep/meson.build | 14 +++++---------
drivers/crypto/mvsam/meson.build | 15 +++++----------
drivers/net/mvneta/meson.build | 19 +++++--------------
drivers/net/mvneta/mvneta_ethdev.h | 1 +
drivers/net/mvpp2/meson.build | 15 +++++----------
meson_options.txt | 2 --
6 files changed, 21 insertions(+), 45 deletions(-)
Hi Liron,
+1 to this change, but can you please make a new version to include
+build
related document changes into this same patch?
Second patch updates document, both for this build related issues and other
issues like new musdk version and supported features etc.. Instead you can move
build related changes to this patch, and separate second patch for crypto and
net, so that it can have proper commit logs for each and can be reviewed easier.
[L.H.] the support for the pkg-config, which meson build relay on, requires
newer musdk version. Can I create a platform doc for all Marvell ARMADA
platforms?
Not sure if a platform doc is required just to document external library
dependency.
But if there is more to add to platform document, can you sent it as separate
patch so it can be reviewed without blocking this set?
[L.H.] i can split the doc patch and add the meson part to this patch, but I
will also need to include the musdk version as only in the new version the
pkg-config support is included.
Is that fine?
Got it, that is fine but can you please highlight this in the commit log? (That
only new specific version of the musdk supports pkg-config)
