Hi
I don't think this is right.
One question: What if users want to disable rss? What you're doing right now
will just make testpmd ignore "--disable-rss".
BRs
Xiaoyun
> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Steve Yang
> Sent: Tuesday, December 15, 2020 14:13
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Xing, Beilei <beilei.x...@intel.com>;
> Iremonger, Bernard <bernard.iremon...@intel.com>; Yigit, Ferruh
> <ferruh.yi...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; Yang, SteveX
> <stevex.y...@intel.com>
> Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate
>
> When testpmd launched, the default RSS hash function will only activate
> 'ETH_RSS_IP', it isn't consistent with the command result of 'port config all
> rss
> default'.
>
> Removed the default 'rss_hf' limited in 'init_port_config', that will use the
> default supported RSS hash function for NIC.
>
> Fixes: 9089296206ce ("app/testpmd: fix config due to RSS offload check")
>
> Signed-off-by: Steve Yang <stevex.y...@intel.com>
> ---
> app/test-pmd/testpmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 33fc0fddf5..ed6b438950 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3505,7 +3505,7 @@ init_port_config(void)
> if (nb_rxq > 1) {
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
> - rss_hf & port-
> >dev_info.flow_type_rss_offloads;
> + port->dev_info.flow_type_rss_offloads;
> } else {
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
> --
> 2.17.1
