10/11/2020 17:04, Viacheslav Ovsiienko:
> This patch introduces the routine to allocate the UAR (User
> Access Region) with various memory mapping types. The origin
> patch being fixed provided the UAR allocation workaround
> for the mlx5 net PMD only. As it was found the other mlx5
> based drivers
> > For VxLAN packets, GRO will mistakenly reassemble them
> > if inner L3 is IPv6, inner L4 is TCP or UDP, and outer L3
> > is IPv4 because the value of IS_IPV4_VXLAN_TCP4/UDP4_PKT
> > is true for them.
> >
> > This fix makes sure IS_IPV4_TCP_PKT, IS_IPV4_UDP_PKT,
> > IS_IPV4_VXLAN_TCP4_PKT and
13/11/2020 16:05, Bruce Richardson:
> On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> > With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> > by default. It got lost when transitioning to Meson build
> > system.
> >
> > In order to avoid performance changes, this patch
14/11/2020 09:51, Thomas Monjalon:
> 13/11/2020 16:05, Bruce Richardson:
> > On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> > > With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> > > by default. It got lost when transitioning to Meson build
> > > system.
> > >
> > >
I tested external compilation for all possible examples (in my env).
The result is this series.
--
David Marchand
Changelog since v2:
- reworked patch 4 check on crypto driver availability,
- added patch 5 to fix misalignment with other examples makefiles,
- dropped last patch on checking all ex
flow.c: In function ‘parse_flow_tokens’:
flow.c:153:23: error: taking address of packed member of ‘struct
rte_ipv4_hdr’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr,
| ^~~~
When this example started using rte_cryptodev_sym_session_pool_create,
the part for pkg-config builds was not updated.
Fixes: 261bbff75e34 ("examples: use separate crypto session mempools")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
examples/fips_validatio
rm -f build/kni build/kni-static build/kni-shared
test -d build && rmdir -p build || true
[...]
/usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol
'pthread_join@@GLIBC_2.2.5'
This example explicitly call pthread API and should be linked against
the pthread library.
Fixes: 724beb913b44 ("
This example missed the rework from commit 8549295db07b
("build/pkg-config: improve static linking flags").
Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
examples/l3fwd-graph/Makefile | 2 +-
1 file cha
Two issues fixed here.
First add the experimental flag.
Then fix a link issue with the crypto scheduler driver:
/usr/bin/ld: /tmp/cchr7aHA.o: in function `main':
main.c:(.text.startup+0x1673): undefined reference to
`rte_cryptodev_scheduler_workers_get'
collect2: error: ld returned 1 exit status
This example missed the fixes from commit 69b1bb49ed82
("examples: hide error for missing pkg-config path flag") and
commit 12a652a02b08 ("examples: fix build with old pkg-config").
Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Signed-off-by: David Marchand
---
ex
main.c: In function ‘lthread_tx’:
main.c:2091:25: error: implicit declaration of function ‘sched_getcpu’;
did you mean ‘sched_getparam’? [-Werror=implicit-function-declaration]
2091 | tx_conf->conf.cpu_id = sched_getcpu();
| ^~~~
|
When introducing this example, the cleanup from commit 7e9562a107f1
("examples: fix make clean when using pkg-config") was missed.
Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
Acked-by: Xiaoyun Li
---
ex
vhost_blk.c: In function ‘ctrlr_worker’:
vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’
[-Wimplicit-function-declaration]
543 | CPU_ZERO(&cpuset);
| ^~~~
vhost_blk.c:544:2: warning: implicit declaration of function ‘CPU_SET’
[-Wimplicit-function-declaration]
Before make removal, those examples were built with experimental flag
for tracepoints to be compiled in but the pkg-config part of those
makefiles were missed.
Fixes: 78d44153de8f ("ethdev: add tracepoints")
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
Changelog since v2:
- adde
This example is missing the experimental flag since it uses an
experimental API.
Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Bruce Richardson
---
examples/rxtx_callbacks/Makefile | 2 ++
1 file changed, 2 ins
10/11/2020 17:04, Viacheslav Ovsiienko:
> +void *
> +mlx5_devx_alloc_uar(void *ctx, int mapping)
> +{
> + void *uar;
> + uint32_t retry, uar_mapping;
> + void *base_addr;
> +
> + for (retry = 0; retry < MLX5_ALLOC_UAR_RETRY; ++retry) {
> +#ifdef MLX5DV_UAR_ALLOC_TYPE_NC
> +
On Fri, Nov 13, 2020 at 5:17 PM Bruce Richardson
wrote:
>
> DPDK has been using meson 0.47 for some time now, so we can safely
> remove the note calling out this fact.
>
> Signed-off-by: Bruce Richardson
> ---
> doc/guides/rel_notes/deprecation.rst | 6 --
> 1 file changed, 6 deletions(-)
>
On Sat, Nov 14, 2020 at 10:00 AM Thomas Monjalon wrote:
>
> 14/11/2020 09:51, Thomas Monjalon:
> > 13/11/2020 16:05, Bruce Richardson:
> > > On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> > > > With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> > > > by default. It g
On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq wrote:
>
> Instead of using getopt_long return value, strcmp was used to
> compare the input parameters with the struct option array. This
> patch get rid of all those strcmp by directly binding each longopt
> with an int enum. This is to improve reada
When testpmd enabled the verbosity for the received packets, if two packets
was received at the same time, for example, sampling packet and normal
packet, the dump output of these packets may be overlapping due to multiple
core handled the multiple queues simultaneously.
The patch uses one string
13/11/2020 15:52, Gregory Etelson:
> + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group,
> + &flow_table, grp_info, error);
The parameter grp_info is a struct passed as value.
I believe it should be passed as a pointer.
I see some other funct
13/11/2020 15:31, Juraj Linkeš:
> Add an option to automatically discover the host's numa and cpu counts
> and use those values for a non cross-build.
> Give users the option to override the per-arch default values or values
> from cross files by specifying them on the command line with -Dmax_lcore
> 13/11/2020 15:52, Gregory Etelson:
> > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group,
> > + &flow_table, grp_info, error);
>
> The parameter grp_info is a struct passed as value.
> I believe it should be passed as a pointer.
struct flo
> 13/11/2020 15:52, Gregory Etelson:
> > The original patch allocated tunnel offload objects with invalid
> > indexes. As the result, PMD tunnel object allocation failed.
> >
> > In this patch indexed pool provides both an index and memory for a new
> > tunnel offload object.
> > Also tunnel offloa
Reviewed-by: Liron Himi
-Original Message-
From: Juraj Linkeš
Sent: Friday, 13 November 2020 16:31
To: bruce.richard...@intel.com; ruifeng.w...@arm.com;
honnappa.nagaraha...@arm.com; phil.y...@arm.com; vcchu...@amazon.com;
dharmik.thak...@arm.com; jerinjac...@gmail.com; hemant.agra...@
14/11/2020 18:41, Gregory Etelson:
> > 13/11/2020 15:52, Gregory Etelson:
> > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group,
> > > + &flow_table, grp_info, error);
> >
> > The parameter grp_info is a struct passed as value.
> > I believ
14/11/2020 18:47, Gregory Etelson:
> > 13/11/2020 15:52, Gregory Etelson:
> > > The original patch allocated tunnel offload objects with invalid
> > > indexes. As the result, PMD tunnel object allocation failed.
> > >
> > > In this patch indexed pool provides both an index and memory for a new
> >
> 14/11/2020 18:41, Gregory Etelson:
> > > 13/11/2020 15:52, Gregory Etelson:
> > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data-
> >group,
> > > > + &flow_table, grp_info,
> > > > + error);
> > >
> > > The parameter grp_info is a struct passe
14/11/2020 19:31, Gregory Etelson:
> > 14/11/2020 18:41, Gregory Etelson:
> > > > 13/11/2020 15:52, Gregory Etelson:
> > > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data-
> > >group,
> > > > > + &flow_table, grp_info,
> > > > > + error);
> > >
The ETOOMANYREFS errno is missing from the Windows clang build
is it used in initialization of flow error structures.
The commit will define it as it is done in the minGW Windows build.
Signed-off-by: Tal Shnaiderman
---
lib/librte_eal/windows/include/rte_os.h | 1 +
1 file changed, 1 insertion
> Subject: Re: [dpdk-dev] [PATCH v1 59/72] net/mlx5/windows: support VF PCI
> address
>
> On Tue, Oct 27, 2020 at 11:23:22PM +, Ophir Munk wrote:
> > From: Tal Shnaiderman
> >
> > Support VF BDF scanning by checking both the BDF and raw BDF provided
> > by DevX. In Linux a PCI address is form
> Subject: Re: [dpdk-dev] [PATCH v1 48/72] net/mlx5/windows: support link
> update
>
> On Tue, Oct 27, 2020 at 11:23:11PM +, Ophir Munk wrote:
> > From: Tal Shnaiderman
> >
> > Add support for mlx5_link_update() to get link speed and link state.
> > Other parameters are currently hard-coded.
> Subject: Re: [dpdk-dev] [PATCH v1 42/72] common/mlx5/windows: add
> DevX UAR getters
>
> On Tue, Oct 27, 2020 at 11:23:05PM +, Ophir Munk wrote:
> > The following getters are added: mlx5_os_get_devx_uar_mmap_offset,
> > mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr,
> > mlx5_
> Subject: Re: [dpdk-dev] [PATCH v1 34/72] net/mlx5/windows: implement
> mlx5 mac addr add
>
> On Tue, Oct 27, 2020 at 11:22:57PM +, Ophir Munk wrote:
> > From: Tal Shnaiderman
> >
> > Get the list of MAC addresses and verify if the input mac parameter
> > already exists. If not - return -ENO
> Subject: Re: [dpdk-dev] [PATCH v1 27/72] common/mlx5/windows: add OS
> alloc/dealloc pd
>
> On Tue, Oct 27, 2020 at 11:22:50PM +, Ophir Munk wrote:
> > From: Tal Shnaiderman
> >
> > Implement Windows API mlx5_os_alloc_pd() and mlx5_os_dealloc_pd().
> > They are equivalent to the Linux imple
On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote:
> The ETOOMANYREFS errno is missing from the Windows clang build
> is it used in initialization of flow error structures.
"is it" -> "it is"
> The commit will define it as it is done in the minGW Windows build.
"The commit will" is unne
> Subject: Re: [PATCH] eal/windows: definition for ETOOMANYREFS errno
>
> External email: Use caution opening links or attachments
>
>
> On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote:
> > The ETOOMANYREFS errno is missing from the Windows clang build is it
> > used in initialization
The ETOOMANYREFS errno is missing from the Windows build.
it is used in initialization of flow error structures.
The commit will define it with the same error code used by
WSAETOOMANYREFS.
Signed-off-by: Tal Shnaiderman
---
v2: log message fix, apply errno to both Windows builds
and remove depe
On Sun, 15 Nov 2020 00:21:29 +0200, Tal Shnaiderman wrote:
> The ETOOMANYREFS errno is missing from the Windows build.
> it is used in initialization of flow error structures.
>
> The commit will define it with the same error code used by
> WSAETOOMANYREFS.
>
> Signed-off-by: Tal Shnaiderman
>
> 14/11/2020 19:31, Gregory Etelson:
> > > 14/11/2020 18:41, Gregory Etelson:
> > > > > 13/11/2020 15:52, Gregory Etelson:
> > > > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data-
> > > >group,
> > > > > > + &flow_table, grp_info,
> > > > > > +
41 matches
Mail list logo
