13/11/2020 15:52, Gregory Etelson:
> +       ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group,
> +                                      &flow_table, grp_info, error);

The parameter grp_info is a struct passed as value.
I believe it should be passed as a pointer.

I see some other functions are passing arrays with [] syntax,
which does not make sense in parameters. I should be a simple pointer.

Matan, Slava, as maintainers, what are your policies in mlx5 code?


Reply via email to