On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote: > The ETOOMANYREFS errno is missing from the Windows clang build > is it used in initialization of flow error structures.
"is it" -> "it is" > The commit will define it as it is done in the minGW Windows build. "The commit will" is unnecessary. "minGW" -> "MinGW" > Signed-off-by: Tal Shnaiderman <tal...@nvidia.com> > --- > lib/librte_eal/windows/include/rte_os.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/windows/include/rte_os.h > b/lib/librte_eal/windows/include/rte_os.h > index 569ed92d51..2a91ebf6a1 100644 > --- a/lib/librte_eal/windows/include/rte_os.h > +++ b/lib/librte_eal/windows/include/rte_os.h > @@ -90,6 +90,7 @@ eal_strerror(int code) > } > > #define strerror eal_strerror > +#define ETOOMANYREFS WSAETOOMANYREFS > > #endif /* RTE_TOOLCHAIN_GCC */ Should be #define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */ for all toolchains: 1. Users of librte_ethdev, who check for ETOOMANYREFS, may not wish to include <winsock2.h> because of its defines that break librte_net headers. 2. Now that I looked closely, MinGW-w64's #define ETOOMANYREFS WSAETOOMANYREFS is under #if 0 clause (for documentation?). Apologies for earlier misinformation.
