Re: [dpdk-dev] [PATCH v5 0/7] BBDEV test updates

2020-10-24 Thread David Marchand
On Sat, Oct 24, 2020 at 1:43 AM Nicolas Chautru wrote: > > v5: correcting typos again. Quite worrisome spelling disorder. > v4: rebased on main latest Don't forget to update superseded series in patchwork too. Thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v6 0/4] hash: integrate RCU QSBR

2020-10-24 Thread David Marchand
On Thu, Oct 22, 2020 at 12:51 AM Dharmik Thakkar wrote: > > Integrate RCU QSBR to make it easier for the applications to use lock > free algorithm. > > Resource reclamation implementation was split from the original > series, and has already been part of RCU library. Rework the series > to base ha

Re: [dpdk-dev] [PATCH v3 01/23] event/dlb2: add documentation and meson build infrastructure

2020-10-24 Thread Jerin Jacob
On Fri, Oct 23, 2020 at 11:59 PM Timothy McDaniel wrote: > > Adds the meson build infrastructure, which includes > compile-time constants in rte_config.h. DLB2 is > only supported on Linux X86 platforms at this time. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads There is the foll

Re: [dpdk-dev] [PATCH v6 01/23] event/dlb: add documentation and meson infrastructure

2020-10-24 Thread Jerin Jacob
On Sat, Oct 24, 2020 at 12:08 AM Timothy McDaniel wrote: > > Increased RTE_EVENT_MAX_QUEUES_PER_DEV config option > from 64 to 255. Please send a separate patch for changing this value with reason. > > Note that config/rte_config.h contains several configuration > switches, providing for fine co

Re: [dpdk-dev] [PATCH v2 00/22] Add DLB2 PMD

2020-10-24 Thread Thomas Monjalon
17/10/2020 20:20, Timothy McDaniel: > Note that the DLB2 hardware is a successor of the DLB hardware, and > as such is structured similarly, both in terms of code layout and > implementation. That's quite funny that you are unable to have a single driver for both similar hardware. I guess that's t

Re: [dpdk-dev] [PATCH v6 01/23] event/dlb: add documentation and meson infrastructure

2020-10-24 Thread Thomas Monjalon
23/10/2020 20:32, Timothy McDaniel: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1188,6 +1188,11 @@ M: Peter Mccarthy > F: drivers/event/opdl/ > F: doc/guides/eventdevs/opdl.rst > > +Intel DLB Eventdev PMD "Intel DLB" is enough. > +M: Timothy McDaniel > +F: drivers/event/dlb/ > +F: doc/gui

Re: [dpdk-dev] [PATCH v3 2/5] lib/ring: add zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Hi Konstantin, Thank you for the quick comments. Please see the responses inline. > > > > > > Add zero-copy APIs. These APIs provide the capability to copy the data > > to/from the ring memory directly, without having a temporary copy (for > > ex: an array of mbufs on the stack). Use c

[dpdk-dev] [PATCH v4 1/8] lib/ring: add zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Add zero-copy APIs. These APIs provide the capability to copy the data to/from the ring memory directly, without having a temporary copy (for ex: an array of mbufs on the stack). Use cases that involve copying large amount of data to/from the ring can benefit from these APIs. Signed-off-by: Honnap

[dpdk-dev] [PATCH v4 2/8] test/ring: move common function to header file

2020-10-24 Thread Honnappa Nagarahalli
Move test_ring_inc_ptr to header file so that it can be used by functions in other files. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_ring.c | 11 --- app/test/test_ring.h | 13 + 2 files changed, 13 insertions(+), 11 deletions(-) diff

[dpdk-dev] [PATCH v4 0/8] lib/ring: add zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
It is pretty common for the DPDK applications to be deployed in semi-pipeline model. In these models, a small number of cores (typically 1) are designated as I/O cores. The I/O cores work on receiving and transmitting packets from the NIC and several packet processing cores. The IO core and the pac

[dpdk-dev] [PATCH v4 4/8] test/ring: add stress tests for zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Add stress tests for zero copy API. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 + app/test/test_ring_mt_peek_stress_zc.c | 56 ++ app/test/test_ring_st_peek_stress_zc.c | 65 +

[dpdk-dev] [PATCH v4 3/8] test/ring: add functional tests for zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Add functional tests for zero copy APIs. Test enqueue/dequeue functions are created using the zero copy APIs to fit into the existing testing method. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Acked-by: Konstantin Ananyev --- app/test/test_ring.c | 196 +++

[dpdk-dev] [PATCH v4 6/8] test/ring: fix the memory dump size

2020-10-24 Thread Honnappa Nagarahalli
Pass the correct number of bytes to dump the memory. Fixes: bf28df24e915 ("test/ring: add contention stress test" Cc: konstantin.anan...@intel.com Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Acked-by: Konstantin Ananyev --- app/test/test_ring_stress_im

[dpdk-dev] [PATCH v4 5/8] doc/ring: add zero copy peek APIs

2020-10-24 Thread Honnappa Nagarahalli
Add zero copy peek API documentation. Signed-off-by: Honnappa Nagarahalli --- doc/guides/prog_guide/ring_lib.rst | 41 ++ doc/guides/rel_notes/release_20_11.rst | 9 ++ 2 files changed, 50 insertions(+) diff --git a/doc/guides/prog_guide/ring_lib.rst b/doc/guid

[dpdk-dev] [PATCH v4 7/8] test/ring: remove unnecessary braces

2020-10-24 Thread Honnappa Nagarahalli
Remove unnecessary braces to improve readability. Signed-off-by: Honnappa Nagarahalli --- app/test/test_ring.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test/test_ring.h b/app/test/test_ring.h index b525abb79..c8bfec839 100644 --- a/app/test/test_ring.h

[dpdk-dev] [PATCH v4 8/8] test/ring: user uintptr_t instead of unsigned long

2020-10-24 Thread Honnappa Nagarahalli
Use uintptr_t instead of unsigned long while initializing the array of pointers. Signed-off-by: Honnappa Nagarahalli --- app/test/test_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_ring.c b/app/test/test_ring.c index 99fe4b46f..51c05cabb 100644 --- a/ap

Re: [dpdk-dev] [PATCH v4 0/8] lib/ring: add zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Hi David, Checkpatch CI is showing "WARNING" on a lot of the patches in this series, but it does not list any real warnings. Any idea what is happening? Thanks, Honnappa > -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, October 24, 2020 11:11 AM > To: dev@dpdk

[dpdk-dev] [PATCH v2] maintainers: improve coverage of arch-specific files

2020-10-24 Thread Thomas Monjalon
The sub-directories of config/ are maintained by different architecture maintainers. Some wildcards are used to describe the lib, drivers and app files which are specific to some architectures. The EAL Arm files have split responsibilities depending on 32/64 suffix, and the common files are share

Re: [dpdk-dev] [PATCH v5 3/5] eal: replace pci-whitelist/pci-blacklist options

2020-10-24 Thread Stephen Hemminger
On Fri, 23 Oct 2020 18:01:44 -0700 Stephen Hemminger wrote: > + case 'i': > + /* include device list */ > + if (x_used) > + goto include_exclude; This part is wrong, and didn't get fixed with some of the renaming

Re: [dpdk-dev] [PATCH v2] maintainers: improve coverage of arch-specific files

2020-10-24 Thread David Marchand
On Sat, Oct 24, 2020 at 6:36 PM Thomas Monjalon wrote: > > The sub-directories of config/ are maintained by > different architecture maintainers. > > Some wildcards are used to describe the lib, drivers and app files > which are specific to some architectures. > > The EAL Arm files have split resp

Re: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API

2020-10-24 Thread Thomas Monjalon
24/10/2020 01:06, Liang Ma: > Add a simple API to allow getting address of next RX descriptor from the > PMD, as well as release notes information. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: Konstantin Ananyev You keep forgetting Cc ethdev maintainers (it is autom

Re: [dpdk-dev] [PATCH v9 10/10] doc: update programmer's guide for power library

2020-10-24 Thread Thomas Monjalon
24/10/2020 01:06, Liang Ma: > Update programmer's guide to document PMD power management usage. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > Acked-by: David Hunt > --- > doc/guides/prog_guide/power_man.rst | 42 + > 1 file changed, 42 insertions(+)

[dpdk-dev] [PATCH v2 00/21] ice: update base code

2020-10-24 Thread Qi Zhang
main change: 1. Refactor the RSS configure API. 2. Add global LUT support . 3. copule fix and code clean v2: - fix a bug in patch 19/21. Qi Zhang (21): net/ice/base: add tunnel support for FDIR net/ice/base: add NVM Write Response flags net/ice/base: modify ptype bitmap for outer MAC net

[dpdk-dev] [PATCH v2 01/21] net/ice/base: add tunnel support for FDIR

2020-10-24 Thread Qi Zhang
Add struct to store outer part for tunnel rule. Add vxlan ptype in ipv4 mac bitmap. So when create a vxlan rule, the ptype group will be valid. Signed-off-by: Zhirun Yan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 8 drivers/net/ice/base/ice_fdir.h | 9 + driv

[dpdk-dev] [PATCH v2 02/21] net/ice/base: add NVM Write Response flags

2020-10-24 Thread Qi Zhang
Added NVM Write Admin Command (0x703) ARQ response flags - as returned in "Response flags" field. Three flags are supported: POR, PERST and EMPR. All indicate the type of reset required to get the NVM bank update effective. Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/ba

[dpdk-dev] [PATCH v2 04/21] net/ice/base: rename ptype bitmap

2020-10-24 Thread Qi Zhang
Align all ptype bitmap to follow ice_ptypes_xxx prefix. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 45990aeca0..4512b12368

[dpdk-dev] [PATCH v2 03/21] net/ice/base: modify ptype bitmap for outer MAC

2020-10-24 Thread Qi Zhang
Add below ptypes into ice_ptypes_mac_ofos: MAC_IPV4[6]_ESP MAC_IPV4[6]_AH MAC_IPV4[6]_NAT_T_ESP MAC_IPV4[6]_NAT_T_IKE MAC_IPV4[6]_NAT_T_KEEP MAC_IPV4[6]_PFCP_NODE MAC_IPV4[6]_PFCP_SESSION MAC_IPV4[6]_L2TPV3 So above ptype can also be selected by a filter when outer mac header is required. Signed

[dpdk-dev] [PATCH v2 05/21] net/ice/base: move sched function prototypes

2020-10-24 Thread Qi Zhang
These functions reside in ice_sched.c but the function protypes are declared in ice_common.h. Move the function prototypes to ice_sched.h. Signed-off-by: Tony Nguyen Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.h | 7 --- drivers/net/ice/base/ice_sched.h | 8 2 file

[dpdk-dev] [PATCH v2 06/21] net/ice/base: read security revision

2020-10-24 Thread Qi Zhang
The main NVM module and the Option ROM module contain a security revision in their CSS header. This security revision is used to determine whether or not the signed module should be loaded at bootup. If the module security revision is lower than the associated minimum security revision, it will not

[dpdk-dev] [PATCH v2 07/21] net/ice/base: add functions to allocate and free a RSS global LUT

2020-10-24 Thread Qi Zhang
Currently there is no API to allocate and free a RSS global LUT. Incoming changes to support VFs having >16 queues will require using RSS global LUT resources. The functions included will allow a PF to configure a RSS global LUT for VFs that request >16 queues. Signed-off-by: Brett Creeley Signed

[dpdk-dev] [PATCH v2 08/21] net/ice/base: add more capability to admin queue

2020-10-24 Thread Qi Zhang
Add below 3 new capability to "Get Capabilities" AQ commands 0x000A and 0x000B. ICE_AQC_CAPS_IWARP ICE_AQC_CAPS_PCIE_RESET_AVOIDANCE ICE_AQC_CAPS_NVM_MGMT Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 3 +++ 1 file changed, 3 insertions(+) diff -

[dpdk-dev] [PATCH v2 09/21] net/ice/base: update to use package info from ice segment

2020-10-24 Thread Qi Zhang
There are two package versions in the package binary. Today, these two version numbers are the same. However, in the future that may change. Update code to use the package info from the ice segment metadata section, which is the package information that is actually downloaded to the firmware durin

[dpdk-dev] [PATCH v2 10/21] net/ice/base: use malloc instead of calloc

2020-10-24 Thread Qi Zhang
Use *malloc() instead of *calloc() when allocating only a single object as opposed to an array of objects. Signed-off-by: Bruce Allan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_swit

[dpdk-dev] [PATCH v2 12/21] net/ice/base: return error directly

2020-10-24 Thread Qi Zhang
As there is nothing to unroll, return the error directly. Remove the label as this is the only reference to that label. Signed-off-by: Tony Nguyen Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 11/21] net/ice/base: add support for class 5+ modules

2020-10-24 Thread Qi Zhang
Currently QSFP/SFP modules up to power class 4 are supported. 100G modules require higher power in many cases. Also, low power mode requires support of power classes 7 and even 8. This change extends "Get Link Status" AQ command (0x0607) to support class 5+ modules. The patch also add couple othe

[dpdk-dev] [PATCH v2 15/21] net/ice/base: fix parameter name in comment

2020-10-24 Thread Qi Zhang
Fix parameter name for cookie_high and cookie_low. Fixes: a90fae1d0755 ("net/ice/base: add admin queue structures and commands") Cc: sta...@dpdk.org Signed-off-by: Jesse Brandeburg Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[dpdk-dev] [PATCH v2 14/21] net/ice/base: recognize 860 as iSCSI port in CEE mode

2020-10-24 Thread Qi Zhang
iSCSI can use both TCP ports 860 and 3260. However, in our current implementation, the ice_aqc_opc_get_cee_dcb_cfg (0x0A07) AQ command doesn't provide a way to communicate the protocol port number to the AQ's caller. Thus, we assume that 3260 is the iSCSI port number at the AQ's caller layer. In t

[dpdk-dev] [PATCH v2 13/21] net/ice/base: implement shared rate limiter

2020-10-24 Thread Qi Zhang
Implemented shared bandwidth rate limit functionality to account for dedicated bandwidth and minimum bandwidth. It requires non default profile be programmed for CIR, EIR/PIR, and SRL. Signed-off-by: Tarun Singh Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_sched.c | 484

[dpdk-dev] [PATCH v2 16/21] net/ice/base: support extended GPIO access

2020-10-24 Thread Qi Zhang
Added two new admin commands called: SW Set GPIO and SW Get GPIO (0x6EF and 0x6F0 respectively) which extends GPIO handling capabilities by SW driver Signed-off-by: Amir Shay Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 18 ++ 1 file changed, 18 insertions

[dpdk-dev] [PATCH v2 17/21] net/ice/base: remove duplicated AQ command flag setting

2020-10-24 Thread Qi Zhang
When sending the indirect Read/Write SFF EEPROM AQ command. The flag is already added later in the code flow for all indirect AQ commands, i.e. commands that provide an additional data buffer. Signed-off-by: Bruce Allan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 2 +- 1 fil

[dpdk-dev] [PATCH v2 18/21] net/ice/base: introduce and use FLEX_ARRAY_SIZE where possible

2020-10-24 Thread Qi Zhang
Use the FLEX_ARRAY_SIZE() helper with the recently added flexible array members in structures. Signed-off-by: Bruce Allan Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_flex_pipe.c | 2 +- drivers/net/ice/base/ice_type.h | 4 3 files

[dpdk-dev] [PATCH v2 19/21] net/ice/base: refactor RSS configure API

2020-10-24 Thread Qi Zhang
Use struct ice_rss_hash_cfg as parameter for ice_add_rss_cfg, ice_add_rss_cfg_sync and ice_rem_rss_cfg, ice_rem_rss_cfg_sync. Introduce enmu ice_rss_cfg_hdr_type to allow user specify the more flexible RSS configure. ICE_RSS_OUTER_HEADERS - take outer layer as RSS inputset ICE_RSS_INNER_HEADERS -

[dpdk-dev] [PATCH v2 20/21] net/ice/base: add support for get/set RSS LUT to specify global LUT

2020-10-24 Thread Qi Zhang
There is no way to specify a global RSS LUT ID with the current API and 0 is the only global LUT ID that can be supported since it's hard coded. Upcoming support to specify a global LUT ID will require this flexibility. To fix this, update the API for ice_aq_get_rss_lut() and ice_aq_set_rss_lut() t

[dpdk-dev] [PATCH v2 21/21] net/ice/base: update version

2020-10-24 Thread Qi Zhang
Update base code version in readme. Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 1e9c854ae8..5229e5fe7d 100644 --- a/drivers/net/ice/base/README +++ b/dr

Re: [dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues function

2020-10-24 Thread Xu, Ting
> -Original Message- > From: Ferruh Yigit > Sent: Friday, October 23, 2020 6:07 PM > To: Xu, Ting ; dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues > function > > On 10/22/2020 7:48 AM, Ting Xu wrot

[dpdk-dev] [PATCH v5 1/8] lib/ring: add zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Add zero-copy APIs. These APIs provide the capability to copy the data to/from the ring memory directly, without having a temporary copy (for ex: an array of mbufs on the stack). Use cases that involve copying large amount of data to/from the ring can benefit from these APIs. Signed-off-by: Honnap

[dpdk-dev] [PATCH v5 0/8] lib/ring: add zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
It is pretty common for the DPDK applications to be deployed in semi-pipeline model. In these models, a small number of cores (typically 1) are designated as I/O cores. The I/O cores work on receiving and transmitting packets from the NIC and several packet processing cores. The IO core and the pac

[dpdk-dev] [PATCH v5 4/8] test/ring: add stress tests for zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Add stress tests for zero copy API. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 + app/test/test_ring_mt_peek_stress_zc.c | 56 +++ app/test/test_ring_st_peek_stress_zc.c | 63

[dpdk-dev] [PATCH v5 2/8] test/ring: move common function to header file

2020-10-24 Thread Honnappa Nagarahalli
Move test_ring_inc_ptr to header file so that it can be used by functions in other files. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_ring.c | 11 --- app/test/test_ring.h | 13 + 2 files changed, 13 insertions(+), 11 deletions(-) diff

[dpdk-dev] [PATCH v5 3/8] test/ring: add functional tests for zero copy APIs

2020-10-24 Thread Honnappa Nagarahalli
Add functional tests for zero copy APIs. Test enqueue/dequeue functions are created using the zero copy APIs to fit into the existing testing method. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Acked-by: Konstantin Ananyev --- app/test/test_ring.c | 196 +++

[dpdk-dev] [PATCH v5 7/8] test/ring: remove unnecessary braces

2020-10-24 Thread Honnappa Nagarahalli
Remove unnecessary braces to improve readability. Signed-off-by: Honnappa Nagarahalli --- app/test/test_ring.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test/test_ring.h b/app/test/test_ring.h index b525abb79..c8bfec839 100644 --- a/app/test/test_ring.h

[dpdk-dev] [PATCH v5 5/8] doc/ring: add zero copy peek APIs

2020-10-24 Thread Honnappa Nagarahalli
Add zero copy peek API documentation. Signed-off-by: Honnappa Nagarahalli --- doc/guides/prog_guide/ring_lib.rst | 41 ++ doc/guides/rel_notes/release_20_11.rst | 9 ++ 2 files changed, 50 insertions(+) diff --git a/doc/guides/prog_guide/ring_lib.rst b/doc/guid

[dpdk-dev] [PATCH v5 6/8] test/ring: fix the memory dump size

2020-10-24 Thread Honnappa Nagarahalli
Pass the correct number of bytes to dump the memory. Fixes: bf28df24e915 ("test/ring: add contention stress test" Cc: konstantin.anan...@intel.com Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar Acked-by: Konstantin Ananyev --- app/test/test_ring_stress_im

[dpdk-dev] [PATCH v5 8/8] test/ring: user uintptr_t instead of unsigned long

2020-10-24 Thread Honnappa Nagarahalli
Use uintptr_t instead of unsigned long while initializing the array of pointers. Signed-off-by: Honnappa Nagarahalli --- app/test/test_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_ring.c b/app/test/test_ring.c index 3914cb98a..5b7fdfa45 100644 --- a/ap