[dpdk-dev] [PATCH v9 1/4] example/vhost: add async vhost args parsing function

2020-10-22 Thread Cheng Jiang
This patch is to add async vhost driver arguments parsing function for CBDMA channel, DMA initiation function and args description. The meson build file is changed to fix dependency problem. With these arguments vhost device can be set to use CBDMA or CPU for enqueue operation and bind vhost device

[dpdk-dev] [PATCH v9 3/4] doc: update vhost sample doc for vhost async data path

2020-10-22 Thread Cheng Jiang
Add vhost async driver arguments information for vhost async data path in vhost sample application. Signed-off-by: Cheng Jiang --- doc/guides/sample_app_ug/vhost.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vh

[dpdk-dev] [PATCH v9 2/4] example/vhost: add support for vhost async data path

2020-10-22 Thread Cheng Jiang
This patch is to implement vhost DMA operation callbacks for CBDMA PMD and add vhost async data-path in vhost sample. With providing callback implementation for CBDMA, vswitch can leverage IOAT to accelerate vhost async data-path. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 99 +++

[dpdk-dev] [PATCH v9 4/4] doc: update release notes for vhost sample

2020-10-22 Thread Cheng Jiang
Add release notes for vhost async data path support in vhost sample. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index 0d45b5003..f

Re: [dpdk-dev] eal: DPDK: 18.11.6 version rte_eal_init() function cleans the runtime directory in 5.4.35 kernel

2020-10-22 Thread Mohakud, Amiya Ranjan
Hi Anatoly - I raised a bug https://bugs.dpdk.org/show_bug.cgi?id=561 in DPDK for tracking purpose. Regards Amiya From: Mohakud, Amiya Ranjan Sent: 16 October 2020 11:04 To: Burakov, Anatoly ; dpdk-dev Subject: RE: [dpdk-dev] eal: DPDK: 18.11.6 version rte_eal_init() function cleans the runti

[dpdk-dev] [PATCH v1] app/regex: add job context

2020-10-22 Thread guyk
From: Guy Kaneti Store mbuf pointer associated with that job. Signed-off-by: Guy Kaneti --- app/test-regex/main.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/app/test-regex/main.c b/app/test-regex/main.c index e6080b44b..f869d754b 100644 --- a/app/

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-22 Thread Maxime Coquelin
Hi Yinan, On 10/22/20 6:01 AM, Wang, Yinan wrote: > Hi Maxime/ Adrian, > > Thanks for the patch. we can launch vhost-user with client mode with this > fix patch. > But still fail to get throughput with basic vhost/virtio-user server mode > loopback test. This is another problem which introduce

Re: [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver

2020-10-22 Thread Andrew Rybchenko
On 10/22/20 5:58 AM, Guo, Jia wrote: > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Thursday, October 22, 2020 12:09 AM >> To: Guo, Jia ; Xing, Beilei ; >> Thomas Monjalon ; Yigit, Ferruh >> ; Andrew Rybchenko >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH 02/14] ethdev: move

[dpdk-dev] 【DPDK latency test】

2020-10-22 Thread oulijun
Hi, Guys I am a new developer of DPDK. I want to consult about the DPDK latency test app or tool. Thanks Lijun Ou

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-22 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, October 22, 2020 3:14 PM > To: Wang, Yinan ; Adrian Moreno > ; dev@dpdk.org; Xia, Chenbo > Cc: Fu, Patrick ; sta...@dpdk.org; Wang, Zhihong > ; Xu, Qian Q > Subject: Re: [PATCH v2 3/3] virtio-user: set status on v

[dpdk-dev] [PATCH] build: fix version map file references in documentation

2020-10-22 Thread David Marchand
Fixes: 63b3907833d8 ("build: remove library name from version map file name") Signed-off-by: David Marchand --- Note: we might want to update the ABI version in the examples shown in the documentation. I can send a followup patch. --- doc/guides/contributing/abi_versioning.rst | 14 +++

[dpdk-dev] [PATCH] bpf: use helper to install headers

2020-10-22 Thread David Marchand
Libraries can use the headers variable to install headers. Signed-off-by: David Marchand --- lib/librte_bpf/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build index 6070898cb6..48460e9505 100644 --- a/lib/

[dpdk-dev] [PATCH 20.11] crypto/octeontx2: fix for multi process

2020-10-22 Thread Ankur Dwivedi
During crypto device probe few functions should be called only for the primary process. This patch fixes this issue. Fixes: 818d138bcce9 ("crypto/octeontx2: add init sequence in probe") Signed-off-by: Ankur Dwivedi Reviewed-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev.c | 5

Re: [dpdk-dev] [PATCH] build: fix version map file references in documentation

2020-10-22 Thread Kinsella, Ray
On 22/10/2020 08:47, David Marchand wrote: > Fixes: 63b3907833d8 ("build: remove library name from version map file name") > > Signed-off-by: David Marchand > --- > Note: we might want to update the ABI version in the examples shown in > the documentation. I can send a followup patch. I was t

[dpdk-dev] [PATCH v2 1/2] crypto/scheduler: fix header install with meson

2020-10-22 Thread David Marchand
The headers variable is only used in lib/meson.build context. For drivers, an explicit install_headers() is necessary. Reproduced while compiling the l2fwd-crypto example out of meson (which can be done by adding it in devtools/test-meson-builds.sh examples build test). Fixes: cd2b6458a1cb ("cryp

Re: [dpdk-dev] [PATCH v13 1/7] fib: make lookup function type configurable

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Add type argument to dir24_8_get_lookup_fn() > Now it supports 3 different lookup implementations: > RTE_FIB_DIR24_8_SCALAR_MACRO > RTE_FIB_DIR24_8_SCALAR_INLINE > RTE_FIB_DIR24_8_SCALAR_UNI > > Add new rte_fib_set_lookup_fn() - user can chang

Re: [dpdk-dev] [PATCH v13 3/7] fib: introduce AVX512 lookup

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Add new lookup implementation for DIR24_8 algorithm using > AVX512 instruction set > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev > --- > doc/guides/rel_notes/release_20_11.rst | 3 + > lib/librte_fib/dir24_8.c

Re: [dpdk-dev] [PATCH v13 2/7] fib: move lookup definition into the header file

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Move dir24_8 table layout and lookup definition into the > private header file. This is necessary for implementing a > vectorized lookup function in a separate .с file. > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev > ---

Re: [dpdk-dev] [PATCH v13 4/7] fib6: make lookup function type configurable

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Add type argument to trie_get_lookup_fn() > Now it only supports RTE_FIB6_TRIE_SCALAR > > Add new rte_fib6_set_lookup_fn() - user can change lookup > function type runtime. > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev >

[dpdk-dev] [PATCH v2 2/2] drivers: add headers install helper

2020-10-22 Thread David Marchand
A lot of drivers export headers, reproduce the same facility than for libraries. Suggested-by: Bruce Richardson Signed-off-by: David Marchand --- doc/guides/contributing/coding_style.rst | 3 +++ drivers/baseband/acc100/meson.build| 2 +- drivers/baseband/fpga_5gnr_fec/meson.build | 2

Re: [dpdk-dev] [PATCH v13 5/7] fib6: move lookup definition into the header file

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Move trie table layout and lookup definition into the > private header file. This is necessary for implementing a > vectorized lookup function in a separate .с file. > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev Acked-by:

Re: [dpdk-dev] [PATCH v13 7/7] app/testfib: add support for different lookup functions

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Added -v option to switch between different lookup implementations > to measure their performance and correctness. > > Signed-off-by: Vladimir Medvedkin Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH v13 6/7] fib6: introduce AVX512 lookup

2020-10-22 Thread Kinsella, Ray
On 19/10/2020 16:05, Vladimir Medvedkin wrote: > Add new lookup implementation for FIB6 trie algorithm using > AVX512 instruction set > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev Acked-by: Ray Kinsella

[dpdk-dev] [PATCH] hash: use x86 common flag for jhash

2020-10-22 Thread David Marchand
jhash has been forgotten when factorising the x86 arch check. Fixes: dbf17d44f375 ("hash: use common x86 flag") Signed-off-by: David Marchand --- lib/librte_hash/rte_jhash.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jha

[dpdk-dev] [PATCH] doc/guides: fix reference to x32 architecture

2020-10-22 Thread David Marchand
There is no CONFIG_RTE_ARCH_X86_64_32. The original intention was probably to refer to x32. Fixes: 36032e46be40 ("doc: add coding style") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- doc/guides/contributing/design.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH] service: separate dump and reset code

2020-10-22 Thread David Marchand
No functional change intended. service_dump_calls_per_lcore() was always called with a 0 reset flag. service_dump_one() was called with either a 0 reset flag or a NULL FILE pointer. We can split the code for readability sake. Note: there is no path to resetting calls_per_service[], this is left

[dpdk-dev] [Patch v2] net/vdev_netvsc: prevent alarm loss on failed device probe

2020-10-22 Thread Long Li
From: Long Li If a device probe fails, the alarm is canceled and will no longer work for previously probed devices. Fix this by checking if alarm is necessary at the end of each device probe. Reset the alarm if there are vdev_netvsc_ctx created. Change log: v2: removed lock and flags, use count

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-22 Thread Adrian Moreno
On 10/22/20 9:37 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, October 22, 2020 3:14 PM >> To: Wang, Yinan ; Adrian Moreno >> ; dev@dpdk.org; Xia, Chenbo >> Cc: Fu, Patrick ; sta...@dpdk.org; Wang, Zhihong >> ; Xu, Qian Q >> S

Re: [dpdk-dev] [PATCH v2 2/2] drivers: add headers install helper

2020-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2020 at 09:55:45AM +0200, David Marchand wrote: > A lot of drivers export headers, reproduce the same facility than for > libraries. > > Suggested-by: Bruce Richardson > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson With this patch 2, you don't need patch 1, th

Re: [dpdk-dev] [PATCH] build: fix version map file references in documentation

2020-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2020 at 09:47:04AM +0200, David Marchand wrote: > Fixes: 63b3907833d8 ("build: remove library name from version map file name") > > Signed-off-by: David Marchand > --- Thanks. I never thought that there might be references to the version maps including their filenames in the docs

[dpdk-dev] [PATCH] net/i40e: fix FDIR issue for ETH + VLAN pattern

2020-10-22 Thread beilei . xing
From: Beilei Xing Currently, can't create more than one following flow for ETH + VLAN pattern: > flow create 0 ingress pattern eth / vlan vid is 350 / end actions queue index 2 / end The root cause is the keys of all such flows are the same. Fixes: 42044b69c67d ("net/i40e: support input set se

Re: [dpdk-dev] [PATCH] bpf: use helper to install headers

2020-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2020 at 09:50:38AM +0200, David Marchand wrote: > Libraries can use the headers variable to install headers. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 2/2] drivers: add headers install helper

2020-10-22 Thread David Marchand
On Thu, Oct 22, 2020 at 10:16 AM Bruce Richardson wrote: > > On Thu, Oct 22, 2020 at 09:55:45AM +0200, David Marchand wrote: > > A lot of drivers export headers, reproduce the same facility than for > > libraries. > > > > Suggested-by: Bruce Richardson > > Signed-off-by: David Marchand > > --- >

Re: [dpdk-dev] [PATCH] hash: use x86 common flag for jhash

2020-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2020 at 09:59:59AM +0200, David Marchand wrote: > jhash has been forgotten when factorising the x86 arch check. > > Fixes: dbf17d44f375 ("hash: use common x86 flag") > > Signed-off-by: David Marchand > --- > lib/librte_hash/rte_jhash.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [dpdk-dev] [PATCH] doc/guides: fix reference to x32 architecture

2020-10-22 Thread Bruce Richardson
On Thu, Oct 22, 2020 at 10:01:43AM +0200, David Marchand wrote: > There is no CONFIG_RTE_ARCH_X86_64_32. > The original intention was probably to refer to x32. > > Fixes: 36032e46be40 ("doc: add coding style") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > doc/guides/contributi

[dpdk-dev] [PATCH V3 1/1] net/mlx5: fix IPv6 next proto validation

2020-10-22 Thread Eli Britstein
Previous patch added validation of the IPv6 next proto field, in order to overcome a known limitation. One of the values checked is IPPROTO_HOPOPTS, which is defined as 0. If proto field is not specified for matching, or mask=0, as in the following, a wrong validation takes place. flow create 0 ing

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-22 Thread Maxime Coquelin
On 10/22/20 10:12 AM, Adrian Moreno wrote: > > > On 10/22/20 9:37 AM, Xia, Chenbo wrote: >> Hi Maxime, >> >>> -Original Message- >>> From: Maxime Coquelin >>> Sent: Thursday, October 22, 2020 3:14 PM >>> To: Wang, Yinan ; Adrian Moreno >>> ; dev@dpdk.org; Xia, Chenbo >>> Cc: Fu, Patr

Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make from NICs guides

2020-10-22 Thread Thomas Monjalon
Hi, I would like to apply this series. I see some small things that I could fix. Please see the comments below to confirm. 21/10/2020 10:17, Ciara Power: > -.. _bnx2x_driver-compilation: > + .. _bnx2x_driver-compilation: was it changed by mistake? [...] > #. Load ``igb_uio`` or ``vfio-pci`` dr

Re: [dpdk-dev] [PATCH] doc/guides: fix reference to x32 architecture

2020-10-22 Thread David Marchand
On Thu, Oct 22, 2020 at 10:26 AM Bruce Richardson wrote: > > diff --git a/doc/guides/contributing/design.rst > > b/doc/guides/contributing/design.rst > > index 5fe7f63942..54dad08846 100644 > > --- a/doc/guides/contributing/design.rst > > +++ b/doc/guides/contributing/design.rst > > @@ -47,7 +47,

[dpdk-dev] [PATCH v6 0/2] fix default max mtu size when device configured

2020-10-22 Thread SteveX Yang
For testpmd, increase the max rx packet length when size of mtu and overhead exceeds max_rx_pkt_len. For generic ethdev, readuce the mtu size to ensure the rx frame size is larger than size of mtu and overhead. v6: * change the max_rx_pkt_len in the init_config of testpmd; * change the mtu valu

Re: [dpdk-dev] [PATCH v8 0/6] enable large VF configuration

2020-10-22 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, October 22, 2020 2:55 PM > To: Xu, Ting ; dev@dpdk.org > Cc: Zhang, Qi Z ; Wu, Jingjing > Subject: RE: [PATCH v8 0/6] enable large VF configuration > > > > > -Original Message- > > From: Xu, Ting > > Sent: Thursday

[dpdk-dev] [PATCH v6 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-10-22 Thread SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang --- app/test-pmd/testpmd.c | 52 +

[dpdk-dev] [PATCH v6 2/2] librte_ethdev: fix MTU size exceeds max rx packet length

2020-10-22 Thread SteveX Yang
If max rx packet length is smaller then MTU + Ether overhead, that will drop all MTU size packets. Update the MTU size according to the max rx packet and Ether overhead. Fixes: 59d0ecdbf0e1 ("ethdev: MTU accessors") Signed-off-by: SteveX Yang --- lib/librte_ethdev/rte_ethdev.c | 14 +++

Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue

2020-10-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Monday, October 19, 2020 10:20 AM > To: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Cc: Zhang, Yuying ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix virtual channel confiliction issue > > i40evf_execute_vf_cmd() uses _atomic_s

Re: [dpdk-dev] [PATCH 13/14] app/testpmd: remove flow_director_flex_mask command

2020-10-22 Thread Andrew Rybchenko
On 10/20/20 1:53 PM, David Marchand wrote: > On Sun, Oct 18, 2020 at 4:14 PM Andrew Rybchenko > wrote: >> >> The command uses FDIR filter information get API which >> is not supported any more. >> >> Signed-off-by: Andrew Rybchenko > > Build error on parse_flexbytes(): > > FAILED: app/a172ced@@

Re: [dpdk-dev] [PATCH v6 1/4] rcu: build on Windows

2020-10-22 Thread David Marchand
On Thu, Oct 22, 2020 at 12:51 AM Dharmik Thakkar wrote: > > Build the lib for Windows. > > Signed-off-by: Dharmik Thakkar > Tested-by: Dmitry Kozlyuk > --- > lib/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/meson.build b/lib/meson.build > index dd55b5cb53e4..1bb01972

Re: [dpdk-dev] [PATCH v9 0/4] add async data path in vhost sample

2020-10-22 Thread Maxime Coquelin
Hi, On 10/22/20 8:46 AM, Cheng Jiang wrote: > This patch set makes vhost-vswitch be able to use vhost async APIs > for enqueue operations. Demonstrated how the application > leverage IOAT DMA channel with vhost async APIs. > > We introduce two parameters to enable DMA acceleration for Tx > operat

Re: [dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-22 Thread Ferruh Yigit
On 10/21/2020 7:11 PM, Ajit Khaparde wrote: On Wed, Oct 21, 2020 at 11:07 AM Ferruh Yigit wrote: On 10/20/2020 10:55 PM, Ajit Khaparde wrote: From: Peter Spreadborough - Moved P4 specific code under the P4 directory - Added P45 skeleton code for SR to build on - Add SR support in truflow co

[dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-10-22 Thread Cheng Jiang
This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to enable DMA acceleration for Tx operations of queues: -dma_type This parameter is used to speci

[dpdk-dev] [PATCH v10 1/4] example/vhost: add async vhost args parsing function

2020-10-22 Thread Cheng Jiang
This patch is to add async vhost driver arguments parsing function for CBDMA channel, DMA initiation function and args description. The meson build file is changed to fix dependency problem. With these arguments vhost device can be set to use CBDMA or CPU for enqueue operation and bind vhost device

[dpdk-dev] [PATCH v10 4/4] doc: update release notes for vhost sample

2020-10-22 Thread Cheng Jiang
Add release notes for vhost async data path support in vhost sample. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index 0d45b5003..f

[dpdk-dev] [PATCH v10 2/4] example/vhost: add support for vhost async data path

2020-10-22 Thread Cheng Jiang
This patch is to implement vhost DMA operation callbacks for CBDMA PMD and add vhost async data-path in vhost sample. With providing callback implementation for CBDMA, vswitch can leverage IOAT to accelerate vhost async data-path. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 100 ++

[dpdk-dev] [PATCH v10 3/4] doc: update vhost sample doc for vhost async data path

2020-10-22 Thread Cheng Jiang
Add vhost async driver arguments information for vhost async data path in vhost sample application. Signed-off-by: Cheng Jiang --- doc/guides/sample_app_ug/vhost.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vh

Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions

2020-10-22 Thread Andrew Rybchenko
On 10/20/20 5:52 PM, Ferruh Yigit wrote: > On 10/18/2020 3:09 PM, Andrew Rybchenko wrote: >> The legacy filter API, including rte_eth_dev_filter_supported() and >> rte_eth_dev_filter_ctrl() is removed. Flow API should be used. >> >> examples/tep_termination build is broken. >> >> Signed-off-by: And

Re: [dpdk-dev] [PATCH v9 0/4] add async data path in vhost sample

2020-10-22 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, October 22, 2020 5:11 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Fu, Patrick ; Yang, YvonneX > > Subject: Re: [PATCH v9 0/4] add async data path in vhost sample > > Hi, > > On 10/22/20 8:46 AM, Cheng Ji

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-22 Thread 谢华伟(此时此刻)
On 2020/10/22 1:24, Ferruh Yigit wrote: On 10/21/2020 1:32 PM, 谢华伟(此时此刻) wrote: On 2020/10/21 19:49, Ferruh Yigit wrote: On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resour

Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions

2020-10-22 Thread Ferruh Yigit
On 10/22/2020 10:12 AM, Andrew Rybchenko wrote: On 10/20/20 5:52 PM, Ferruh Yigit wrote: On 10/18/2020 3:09 PM, Andrew Rybchenko wrote: The legacy filter API, including rte_eth_dev_filter_supported() and rte_eth_dev_filter_ctrl() is removed. Flow API should be used. examples/tep_termination bu

[dpdk-dev] [PATCH v2 00/14] ethdev: remove legacy filter API

2020-10-22 Thread Andrew Rybchenko
Removal is aggressive and tries to cleanup all dead code from drivers. tep_termination example still uses TUNNEL filters. Functionality is broken when TUNNEL filter is removed and finally even build of the example is broken when API is removed. It is assumed that the example will be removed before

[dpdk-dev] [PATCH v2 02/14] ethdev: move MAC filter type to i40e driver

2020-10-22 Thread Andrew Rybchenko
net/i40e driver is the only user of the enum rte_mac_filter_type. Move the define to the driver and use i40e_ prefix instead of rte_. Signed-off-by: Andrew Rybchenko --- drivers/net/i40e/i40e_ethdev.c | 58 drivers/net/i40e/i40e_ethdev.h | 15 +++-- drive

[dpdk-dev] [PATCH v2 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of MACVLAN filter RTE flow API should be used. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 110 --- doc/guides/rel_notes/deprecation.rst| 2 +- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 -- drivers/net/i40e/i40e_ethd

[dpdk-dev] [PATCH v2 04/14] ethdev: remove legacy flexible filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of FLEXIBLE filter RTE flow API should be used. Temporarily preserve helper defines in public interface. Signed-off-by: Andrew Rybchenko Acked-by: Haiyue Wang --- app/test-pmd/cmdline.c | 195 doc/guides/rel_notes/deprecation.rst| 2 +

[dpdk-dev] [PATCH v2 03/14] ethdev: remove legacy EtherType filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of EtherType filter RTE flow API should be used. Move corresponding definitions to ethdev internal driver API since it is used by drivers internally. Preserve RTE_ETH_FILTER_ETHERTYPE because of it as well. Signed-off-by: Andrew Rybchenko Acked-by: Ajit Khaparde Acked-by: Haiyue Wang -

[dpdk-dev] [PATCH v2 06/14] ethdev: remove legacy SYN filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of SYN filter RTE flow API should be used. Move corresponding definitions to ethdev internal driver API since it is used by drivers internally. Preserve RTE_ETH_FILTER_SYN because of it as well. Signed-off-by: Andrew Rybchenko Acked-by: Haiyue Wang --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v2 07/14] ethdev: remove legacy N-tuple filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of N-tuple filter RTE flow API should be used. Preserve struct rte_eth_ntuple_filter in ethdev API since the structure and related defines are used in flow classify library and a number of drivers. Preserve RTE_ETH_FILTER_NTUPLE because of usage in drivers. Signed-off-by: Andrew Rybchenk

[dpdk-dev] [PATCH v2 05/14] ethdev: move flexible filter type to e1000 driver

2020-10-22 Thread Andrew Rybchenko
net/e1000 driver is the only user of the struct rte_eth_flex_filter and helper defines. Move it to the driver and use igb_ prefix instead of rte_eth_. Signed-off-by: Andrew Rybchenko Acked-by: Haiyue Wang --- drivers/net/e1000/e1000_ethdev.h | 22 +-- drivers/net/e1000/igb_ethd

[dpdk-dev] [PATCH v2 08/14] ethdev: remove legacy TUNNEL filter type support

2020-10-22 Thread Andrew Rybchenko
Intead of TUNNEL filter RTE flow API should be used. Move corresponding defines and helper structure to ethdev driver interface since it is still used by drivers internally. Preserve RTE_ETH_FILTER_TUNNEL because of usage in drivers. Signed-off-by: Andrew Rybchenko Acked-by: Ajit Khaparde ---

[dpdk-dev] [PATCH v2 09/14] ethdev: remove legacy HASH filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of HASH filter RTE flow API should be used. Preserve RTE_ETH_FILTER_HASH since it is used in drivers internally in RTE flow API support. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 434 doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH v2 11/14] ethdev: remove legacy global filter configuration support

2020-10-22 Thread Andrew Rybchenko
Global filter configuration request was supported by net/i40e driver only to configure GRE key length. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 57 - doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v2 13/14] app/testpmd: remove command to set FDIR flexible filter mask

2020-10-22 Thread Andrew Rybchenko
The command uses FDIR filter information get API which is not supported any more. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 162 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 -- 2 files changed, 178 deletions(-) diff --git a/app/

[dpdk-dev] [PATCH v2 14/14] ethdev: remove legacy filter API functions

2020-10-22 Thread Andrew Rybchenko
The legacy filter API, including rte_eth_dev_filter_supported() and rte_eth_dev_filter_ctrl() is removed. Flow API should be used. Signed-off-by: Andrew Rybchenko --- v2: - remove RTE_ETH_FILTER_MAX - move remaining rte_filter_op and rte_filter_type to ethdev driver interface doc/guides/r

[dpdk-dev] [PATCH v2 10/14] ethdev: remove legacy L2_TUNNEL filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of L2 tunnel filter RTE flow API should be used. Preserve RTE_ETH_FILTER_L2_TUNNEL since it is used in drivers internally in RTE flow API support. rte_eth_l2_tunnel_conf structure is used in other ethdev API functions. Signed-off-by: Andrew Rybchenko Acked-by: Haiyue Wang --- app/test

[dpdk-dev] [PATCH v2 12/14] ethdev: remove legacy FDIR filter type support

2020-10-22 Thread Andrew Rybchenko
Instead of FDIR filters RTE flow API should be used. Signed-off-by: Andrew Rybchenko Acked-by: Ajit Khaparde Acked-by: Haiyue Wang --- - cleanup testpmd user guide - partially cleanup net/i40e documentation, please, review and suggest how to fix remaining flow_director_filter command app

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-22 Thread Ferruh Yigit
On 10/22/2020 10:15 AM, 谢华伟(此时此刻) wrote: On 2020/10/22 1:24, Ferruh Yigit wrote: On 10/21/2020 1:32 PM, 谢华伟(此时此刻) wrote: On 2020/10/21 19:49, Ferruh Yigit wrote: On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to crea

Re: [dpdk-dev] [PATCH v2 2/2] drivers: add headers install helper

2020-10-22 Thread Luca Boccassi
On Thu, 2020-10-22 at 10:22 +0200, David Marchand wrote: > On Thu, Oct 22, 2020 at 10:16 AM Bruce Richardson > wrote: > > On Thu, Oct 22, 2020 at 09:55:45AM +0200, David Marchand wrote: > > > A lot of drivers export headers, reproduce the same facility than for > > > libraries. > > > > > > Sugges

Re: [dpdk-dev] [PATCH v2 2/2] drivers: add headers install helper

2020-10-22 Thread Kevin Traynor
On 22/10/2020 10:47, Luca Boccassi wrote: > On Thu, 2020-10-22 at 10:22 +0200, David Marchand wrote: >> On Thu, Oct 22, 2020 at 10:16 AM Bruce Richardson >> wrote: >>> On Thu, Oct 22, 2020 at 09:55:45AM +0200, David Marchand wrote: A lot of drivers export headers, reproduce the same facility

[dpdk-dev] [PATCH 1/2] fips_validation: fix missed version line

2020-10-22 Thread Fan Zhang
This patch fixes the missing version line in the response file. Fixes: 793650184099 ("examples/fips_validation: fix version compatibility") Cc: march...@marvell.com Signed-off-by: Fan Zhang --- examples/fips_validation/fips_validation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH 0/2] fips_validation: fix issues

2020-10-22 Thread Fan Zhang
This patch fixes two issues in FIPS validation sample application. Fan Zhang (2): fips_validation: fix missed version line fips_validation: fix gcm test examples/fips_validation/fips_validation.c | 2 +- examples/fips_validation/fips_validation_gcm.c | 1 - examples/fips_validation/mai

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-22 Thread 谢华伟(此时此刻)
On 2020/10/22 17:44, Ferruh Yigit wrote: On 10/22/2020 10:15 AM, 谢华伟(此时此刻) wrote: On 2020/10/22 1:24, Ferruh Yigit wrote: On 10/21/2020 1:32 PM, 谢华伟(此时此刻) wrote: On 2020/10/21 19:49, Ferruh Yigit wrote: On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only s

[dpdk-dev] [PATCH 2/2] fips_validation: fix gcm test

2020-10-22 Thread Fan Zhang
This patch fixes FIPS GCM test of the redundant plaintext string write and insufficient test case support check for some corner cases. Fixes: d09abf2d1007 ("examples/fips_validation: update GCM test") Cc: roy.fan.zh...@intel.com Signed-off-by: Fan Zhang --- examples/fips_validation/fips_validat

[dpdk-dev] [dpdk-dev 0/2] fips_validation: fix issues

2020-10-22 Thread Fan Zhang
This patch fixes two issues in FIPS validation sample application. Fan Zhang (2): fips_validation: fix missed version line fips_validation: fix gcm test examples/fips_validation/fips_validation.c | 2 +- examples/fips_validation/fips_validation_gcm.c | 1 - examples/fips_validation/mai

[dpdk-dev] [dpdk-dev 2/2] fips_validation: fix gcm test

2020-10-22 Thread Fan Zhang
This patch fixes FIPS GCM test of the redundant plaintext string write and insufficient test case support check for some corner cases. Fixes: d09abf2d1007 ("examples/fips_validation: update GCM test") Cc: roy.fan.zh...@intel.com Signed-off-by: Fan Zhang --- examples/fips_validation/fips_validat

[dpdk-dev] [dpdk-dev 1/2] fips_validation: fix missed version line

2020-10-22 Thread Fan Zhang
This patch fixes the missing version line in the response file. Fixes: 793650184099 ("examples/fips_validation: fix version compatibility") Cc: march...@marvell.com Signed-off-by: Fan Zhang --- examples/fips_validation/fips_validation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [dpdk-dev] [PATCH V3 1/1] net/mlx5: fix IPv6 next proto validation

2020-10-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Eli Britstein > Sent: Thursday, October 22, 2020 11:26 AM > To: dev@dpdk.org > Cc: Dekel Peled ; Ori Kam ; Matan > Azrad ; Raslan Darawsheh ; Slava > Ovsiienko ; Shahaf Shuler ; > Asaf Penso ; Eli Britstein > Subject: [PATCH V3 1/1] net/mlx5: fix IPv6 nex

Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make from NICs guides

2020-10-22 Thread Power, Ciara
Hi Thomas, Thanks for reviewing, these changes seem fine overall, comments inline. Thanks, Ciara >-Original Message- >From: Thomas Monjalon >Sent: Thursday 22 October 2020 09:32 >Subject: Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make >from NICs guides > >Hi, > >I would

[dpdk-dev] [PATCH 1/3] ethdev: remove API to config L2 tunnel EtherType

2020-10-22 Thread Andrew Rybchenko
Remove rte_eth_dev_l2_tunnel_eth_type_conf() and corresponding ethdev driver operation. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 122 doc/guides/nics/features.rst| 1 - doc/guides/rel_notes/deprecation.rst|

[dpdk-dev] [PATCH 0/3] ethdev: remove L2 tunnel config API

2020-10-22 Thread Andrew Rybchenko
Dispite of the deprecation notice I'm not 100% sure that corresponding functionality is supported via flow API. Since the functionality is supported by the net/ixgbe driver only, it is a question to maintainers. The patch series should be applied on top of [1]. [1] https://patches.dpdk.org/projec

[dpdk-dev] [PATCH 2/3] ethdev: remove L2 tunnel offload control API

2020-10-22 Thread Andrew Rybchenko
Remove rte_eth_dev_l2_tunnel_offload_set() and corresponding ethdev driver operation. Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 455 doc/guides/nics/features.rst| 2 - doc/guides/rel_notes/deprecation.rst| 6

[dpdk-dev] [PATCH 3/3] ethdev: move L2 tunnel config structure to ixgbe driver

2020-10-22 Thread Andrew Rybchenko
net/ixgbe driver is the only user of the struct rte_eth_l2_tunnel_conf. Move it to the driver and use ixgbe_ prefix instead of rte_eth_. Signed-off-by: Andrew Rybchenko --- drivers/net/ixgbe/ixgbe_ethdev.c | 12 - drivers/net/ixgbe/ixgbe_ethdev.h | 16 ++-- drivers/net/ixgbe/ixgb

Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make from NICs guides

2020-10-22 Thread Thomas Monjalon
22/10/2020 12:03, Power, Ciara: > From: Thomas Monjalon > >> -- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``) > >> - > >> - Toggles display of bus configurations and enables a debugging queue > >> - to fetch error (Rx/Tx) packets to driver. By default, packets with > >> errors > >> -

[dpdk-dev] [PATCH] examples/pipeline: fix help command

2020-10-22 Thread Yogesh Jangra
This patch has the changes to list all supported commands and fix supported commands help details. Fixes: 5074e1d55107 ("examples/pipeline: add configuration commands") Cc: cristian.dumitre...@intel.com Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 31

Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities

2020-10-22 Thread Ophir Munk
Hi Guy, I could not find RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F defined in latest dpdk/main. As a result my compilation is broken. Can you please assist? Regards, Ophir > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Tuesday, October 20, 2020 12:14 PM > To: g...@marvell.com >

Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities

2020-10-22 Thread Ophir Munk
Please ignore. Now I notice it in a follow up commit. http://patches.dpdk.org/patch/81673/ > -Original Message- > From: Ophir Munk > Sent: Thursday, October 22, 2020 1:53 PM > To: Ori Kam ; g...@marvell.com > Cc: NBU-Contact-Thomas Monjalon ; > smad...@marvell.com; dov...@marvell.com; dev

Re: [dpdk-dev] [PATCH 1/7] vhost: fix virtqueues metadata allocation

2020-10-22 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, October 21, 2020 8:07 PM > To: Xia, Chenbo ; dev@dpdk.org; amore...@redhat.com > Cc: sta...@dpdk.org > Subject: Re: [PATCH 1/7] vhost: fix virtqueues metadata allocation > > Hi Chenbon > > On 10/21/20 1:10 PM, Xia, Chenbo wr

[dpdk-dev] [PATCH v1] examples/pipeline: fix help command

2020-10-22 Thread Yogesh Jangra
This patch has the changes to list all supported commands and fix supported commands help details. Fixes: 5074e1d55107 ("examples/pipeline: add configuration commands") Cc: cristian.dumitre...@intel.com Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 31

Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities

2020-10-22 Thread Guy Kaneti
Hi, The patch was not merged yet: https://patches.dpdk.org/patch/81673/ I will rebase this patch once it is merged. Regards, Guy > -Original Message- > From: Ophir Munk > Sent: Thursday, October 22, 2020 1:53 PM > To: Ori Kam ; Guy Kaneti > Cc: NBU-Contact-Thomas Monjalon ; Smadar Fu

Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD

2020-10-22 Thread Jiawen Wu
On October 19, 2020 4:53 PM, Jiawen Wu wrote: > v4: Add log type introduction, > add txgbe support in release note. > v3: Merge some recent changes in the main repo, > fix the checkpatch warnings. > v2: Re-order patches and fix some known problems. > v1: Introduce txgbe PMD. > Hi Ferruh,

[dpdk-dev] setting parameters in meson build system

2020-10-22 Thread Sarosh Arif
Hello, I was using make build system previously, but since it is removed from dpdk now, I am trying to figure out how to enable/disable certain things using meson, Previously we were able to set some parameters using .config file. Some examples of these parameters are: CONFIG_RTE_LIBRTE_I40E_PMD

Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD

2020-10-22 Thread Ferruh Yigit
On 10/22/2020 12:23 PM, Jiawen Wu wrote: On October 19, 2020 4:53 PM, Jiawen Wu wrote: v4: Add log type introduction, add txgbe support in release note. v3: Merge some recent changes in the main repo, fix the checkpatch warnings. v2: Re-order patches and fix some known problems. v1: In

Re: [dpdk-dev] [PATCH] net/bnxt: fix a potential resource leak

2020-10-22 Thread Ferruh Yigit
On 10/21/2020 7:00 AM, Ajit Khaparde wrote: Fix a potential resource leak in case of errors during dev args parsing during device probe. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.

Re: [dpdk-dev] [PATCH v13 1/7] fib: make lookup function type configurable

2020-10-22 Thread David Marchand
On Mon, Oct 19, 2020 at 5:05 PM Vladimir Medvedkin wrote: > > Add type argument to dir24_8_get_lookup_fn() > Now it supports 3 different lookup implementations: > RTE_FIB_DIR24_8_SCALAR_MACRO > RTE_FIB_DIR24_8_SCALAR_INLINE > RTE_FIB_DIR24_8_SCALAR_UNI > > Add new rte_fib_set_lookup_fn() - user

  1   2   3   >