Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 8:45 AM, Guo, Jia wrote: -Original Message- From: Andrew Rybchenko Sent: Sunday, October 18, 2020 10:09 PM To: Lu, Wenzhuo ; Xing, Beilei ; Iremonger, Bernard ; Ray Kinsella ; Neil Horman ; Ajit Khaparde ; Somnath Kotur ; John Daley ; Hyong Youb Kim ; Guo, Jia ; Wang, Haiyu

Re: [dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 4:10 PM, Andrew Rybchenko wrote: On 10/21/20 1:18 PM, Ananyev, Konstantin wrote: Signed-off-by: Ferruh Yigit --- Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc: Matan Azrad Cc: Olivier Matz Cc: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 25

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-21 Thread McDaniel, Timothy
> -Original Message- > From: Bruce Richardson > Sent: Monday, October 19, 2020 3:34 AM > To: Jerin Jacob > Cc: McDaniel, Timothy ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob ; > T

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-21 Thread Andrew Rybchenko
On 10/20/20 2:07 PM, David Marchand wrote: On Sun, Oct 18, 2020 at 4:10 PM Andrew Rybchenko wrote: RTE flow API should be used for filtering. - We still have some trace in testpmd documentation. $ git grep set.port.*vf.*mac doc/guides/testpmd_app_ug/testpmd_funcs.rst: testpmd> set port (port

[dpdk-dev] [PATCH v2] mailmap: add a mailmap file to DPDK

2020-10-21 Thread Bruce Richardson
Since a number of contributors to DPDK have submitted patches to DPDK under more than one email address, we should maintain a mailmap file to properly track their commits using "shortlog". It also helps fix up any mangled names, for example, with surname/firstname reversed, or with incorrect capita

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 1:32 PM, 谢华伟(此时此刻) wrote: On 2020/10/21 19:49, Ferruh Yigit wrote: On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BA

Re: [dpdk-dev] [PATCH] net/bnxt: fix a potential resource leak

2020-10-21 Thread Ajit Khaparde
On Tue, Oct 20, 2020 at 11:00 PM Ajit Khaparde wrote: > > Fix a potential resource leak in case of errors during dev args > parsing during device probe. > > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > > Signed-off-by: Ajit Khaparde > Reviewed-by: Kalesh AP Patch applie

Re: [dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-21 Thread Ferruh Yigit
On 10/20/2020 10:55 PM, Ajit Khaparde wrote: From: Peter Spreadborough - Moved P4 specific code under the P4 directory - Added P45 skeleton code for SR to build on - Add SR support in truflow core layer Related to the patch title, as far as I know Stingray device support already added, what

Re: [dpdk-dev] [v3 1/2] cryptodev: support enqueue callback functions

2020-10-21 Thread Ananyev, Konstantin
Hi Abhinandan, Thanks for the effort, good progress. Though few more comments, see below. > This patch adds APIs to add/remove callback functions. The callback > function will be called for each burst of crypto ops received on a > given crypto device queue pair. > > Signed-off-by: Abhinandan G

[dpdk-dev] [PATCH v2 1/2] net/mlx5: refactor vectorized Rx routine

2020-10-21 Thread Alexander Kozyrev
Move the main processing cycle into a separate function: rxq_cq_process_v. Put the regular rxq_burst_v function to a non-arch specific file. Having all SIMD instructions in a single reusable block is a first preparatory step to implement vectorized Rx burst for MPRQ feature. Pass a pointer to the

[dpdk-dev] [PATCH v2 2/2] net/mlx5: implement vectorized MPRQ burst

2020-10-21 Thread Alexander Kozyrev
MPRQ (Multi-Packet Rx Queue) processes one packet at a time using simple scalar instructions. MPRQ works by posting a single large buffer (consisted of multiple fixed-size strides) in order to receive multiple packets at once on this buffer. A Rx packet is then copied to a user-provided mbuf or PMD

[dpdk-dev] [PATCH v2 0/2] net/mlx5: add vectorized mprq

2020-10-21 Thread Alexander Kozyrev
The vectorized Rx burst function helps to accelerate the Rx processing by using SIMD (single instruction, multiple data) extensions for the multi-buffer packet processing. Pre-allocating multiple mbufs and filling them in batches of four greatly improves the throughput of the Rx burst routine. MPR

[dpdk-dev] [PATCH] eal: create a runtime directory on windows

2020-10-21 Thread Pallavi Kadam
Added eal_create_runtime_dir() function in order to run any application as a user that does not have administrator access. Currently, since there is no runtime directory set, the code tries to create a file in C:\ which is only writable with administrator privileges. As a result, if the user is not

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix port shared data reference count

2020-10-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xueming Li > Sent: Wednesday, October 21, 2020 2:15 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Jack Min ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix port shared dat

Re: [dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-21 Thread Ajit Khaparde
On Wed, Oct 21, 2020 at 11:07 AM Ferruh Yigit wrote: > > On 10/20/2020 10:55 PM, Ajit Khaparde wrote: > > From: Peter Spreadborough > > > > - Moved P4 specific code under the P4 directory > > - Added P45 skeleton code for SR to build on > > - Add SR support in truflow core layer > > > > Related t

Re: [dpdk-dev] [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-21 Thread Honnappa Nagarahalli
> > > > Add functional and performance tests for the integrated RCU QSBR. > > > > Suggested-by: Honnappa Nagarahalli > > Signed-off-by: Dharmik Thakkar > > Reviewed-by: Ruifeng Wang > > --- > > app/test/test_hash.c | 390 - > > app/test/test_hash_read

[dpdk-dev] [PATCH v6 1/4] rcu: build on Windows

2020-10-21 Thread Dharmik Thakkar
Build the lib for Windows. Signed-off-by: Dharmik Thakkar Tested-by: Dmitry Kozlyuk --- lib/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/meson.build b/lib/meson.build index dd55b5cb53e4..1bb019720c6a 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -41,6 +41,7 @@ if

[dpdk-dev] [PATCH v6 3/4] test/hash: replace rte atomic with C11 atomic APIs

2020-10-21 Thread Dharmik Thakkar
Replace rte_atomic APIs with C11 atomic APIs in test_hash_readwrite_lf_perf.c Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Acked-by: Yipeng Wang --- app/test/test_hash_readwrite_lf_perf.c | 89 +++--- 1 file changed, 36 insertions(+), 53 deletions(-) diff --git

[dpdk-dev] [PATCH v6 0/4] hash: integrate RCU QSBR

2020-10-21 Thread Dharmik Thakkar
Integrate RCU QSBR to make it easier for the applications to use lock free algorithm. Resource reclamation implementation was split from the original series, and has already been part of RCU library. Rework the series to base hash integration on RCU reclamation APIs. Refer 'Resource reclamation f

[dpdk-dev] [PATCH v6 2/4] lib/hash: integrate RCU QSBR

2020-10-21 Thread Dharmik Thakkar
Currently, users have to use external RCU mechanisms to free resources when using lock free hash algorithm. Integrate RCU QSBR process to make it easier for the applications to use lock free algorithm. Refer to RCU documentation to understand various aspects of integrating RCU library into other l

[dpdk-dev] [PATCH v6 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-21 Thread Dharmik Thakkar
Add functional and performance tests for the integrated RCU QSBR. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_hash.c | 390 - app/test/test_hash_readwrite_lf_perf.c | 170 ++- 2

[dpdk-dev] [PATCH] net/netvsc: use memzone to allocate contiguous physical mem for rndis

2020-10-21 Thread Long Li
From: Long Li When sending data, netvsc assumes the tx_rndis buffer is contiguous and calculates physical addresses based on this assumption. Use memzone to allocate tx_rndis so it's guaranteed that this buffer is physically contiguous. Cc:sta...@dpdk.org Signed-off-by: Long Li --- drivers/ne

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-21 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 12:05 AM > To: Guo, Jia ; Lu, Wenzhuo ; > Xing, Beilei ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Rasesh Mody ; > Shahed Shaikh ; Andrew Rybchenko > ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev

Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-21 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 12:18 AM > To: Guo, Jia ; Lu, Wenzhuo ; > Xing, Beilei ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; > Hyong Youb Kim ; Wang, Haiyue > ; Matan Azrad

Re: [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver

2020-10-21 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 12:09 AM > To: Guo, Jia ; Xing, Beilei ; > Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: Re: [PATCH 02/14] ethdev: move MAC filter type to i40e driver > > On 10/21/20

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-21 Thread Wang, Yinan
Hi Maxime/ Adrian, Thanks for the patch. we can launch vhost-user with client mode with this fix patch. But still fail to get throughput with basic vhost/virtio-user server mode loopback test. This is another problem which introduced by 57912824615fd7787a48a7b18e40661466. Bugzilla: https://bug

[dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path

2020-10-21 Thread wangyunjian
From: Yunjian Wang In mrvl_create() allocated memory for 'mtr', we don't free it when profile get fails and it will lead to memory leak. We can get profile at the beginning of the function to fix it, before calling mtr = rte_zmalloc_socket(). Fixes: cdb53f8da628 ("net/mvpp2: support metering")

Re: [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix memory leak in error path

2020-10-21 Thread Liron Himi
Acked-by: Liron Himi -Original Message- From: wangyunjian Sent: Thursday, 22 October 2020 07:25 To: dev@dpdk.org Cc: Liron Himi ; jerry.lili...@huawei.com; xudin...@huawei.com; Yunjian Wang ; sta...@dpdk.org Subject: [EXT] [dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path Ex

[dpdk-dev] [PATCH v8 1/6] net/iavf: handle virtchnl event message without interrupt

2020-10-21 Thread Ting Xu
Currently, VF can only handle virtchnl event message by calling interrupt. It is not available in two cases: 1. If the event message comes during VF initialization before interrupt is enabled, this message will not be handled correctly. 2. Some virtchnl commands need to receive the event message an

[dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues function

2020-10-21 Thread Ting Xu
Add a new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs per VF, enable this request queues function. When requesting queues succeeds, PF will return an event message. If it is handled b

[dpdk-dev] [PATCH v8 0/6] enable large VF configuration

2020-10-21 Thread Ting Xu
This patchset supports to configure up to 256 queue pairs per VF. If large VF is supported after capability negotiation, VF will request queues from PF as needed. New virtual channel opcodes and structures are used to indicate 256 queues, so VF is designed to handle the new function of configure VS

[dpdk-dev] [PATCH v8 3/6] net/iavf: negotiate large VF and request more queues

2020-10-21 Thread Ting Xu
Negotiate large VF capability with PF during VF initialization. If large VF is supported and the number of queues larger than 16 is required, VF requests additional queues from PF. Mark the state that large VF is supported. If the allocated queues number is larger than 16, the max RSS queue region

[dpdk-dev] [PATCH v8 5/6] net/iavf: enable IRQ mapping configuration for large VF

2020-10-21 Thread Ting Xu
The current IRQ mapping configuration only supports max 16 queues and 16 MSIX vectors. Change the queue vector mapping structure to indicate up to 256 queues. A new opcode is used to handle the case with large number of queues. To avoid adminq buffer size limitation, we support to send the virtchnl

[dpdk-dev] [PATCH v8 4/6] net/iavf: enable multiple queues configurations for large VF

2020-10-21 Thread Ting Xu
Since the adminq buffer size has a 4K limitation, the current virtchnl command VIRTCHNL_OP_CONFIG_VSI_QUEUES cannot send the message only once to configure up to 256 queues. In this patch, we send the messages multiple times to make sure that the buffer size is less than 4K each time. Signed-off-b

[dpdk-dev] [PATCH v8 6/6] net/iavf: add enable/disable queues for large VF

2020-10-21 Thread Ting Xu
The current virtchnl structure for enable/disable queues only supports max 32 queue pairs. Use a new opcode and structure to indicate up to 256 queue pairs, in order to enable/disable queues in large VF case. Signed-off-by: Ting Xu --- drivers/net/iavf/iavf.h | 5 ++ drivers/net/iavf/iav

[dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-21 Thread yang_y_yi
From: Yi Yang rte_gso_segment decreased refcnt of pkt by one, but it is wrong if pkt is external mbuf, pkt won't be freed because of incorrect refcnt, the result is application can't allocate mbuf from mempool because mbufs in mempool are run out of. One correct way is application should call rt

Re: [dpdk-dev] [PATCH v8 0/6] enable large VF configuration

2020-10-21 Thread Xing, Beilei
> -Original Message- > From: Xu, Ting > Sent: Thursday, October 22, 2020 2:49 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing ; Xu, Ting > Subject: [PATCH v8 0/6] enable large VF configuration > > This patchset supports to configure up to 256 queue pairs per VF

[dpdk-dev] [PATCH v9 0/4] add async data path in vhost sample

2020-10-21 Thread Cheng Jiang
This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to enable DMA acceleration for Tx operations of queues: -dma_type This parameter is used to speci

<    1   2