Re: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type selection to ethdev

2020-10-20 Thread Maxime Coquelin
Hi Yinan, On 10/20/20 3:52 AM, Wang, Yinan wrote: > Hi Adrian/Maxime, > > Could you help to take a look at this issue? Most of automated regression > cases will be blocked due to this issue in 20.11 RC1 test. We are working on it. Adrian managed to reproduce it, and fixed one part of the issue.

[dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Adrian Moreno
If stat fails it means the backend must be vhost-user in server mode Bugzilla ID: 559 Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") Cc: sta...@dpdk.org Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_user_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+)

Re: [dpdk-dev] [PATCH v5 0/8] Rework build macros

2020-10-20 Thread David Marchand
On Mon, Oct 19, 2020 at 10:27 PM Thomas Monjalon wrote: > > 15/10/2020 17:05, Bruce Richardson: > > Following on from discussion in RFC v1 and v2 of this set, this version > > reworks the automated macros defined by meson to indicate if a > > particular library or driver is enabled in the build. H

Re: [dpdk-dev] [PATCH v6] net/mlx5: support query of AGE action

2020-10-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, October 19, 2020 4:53 PM > To: Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v6] net/mlx5: support query of AGE action > > Recent patch [1] adds to ethdev the

Re: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type selection to ethdev

2020-10-20 Thread Adrian Moreno
Hi Yinan, Still testing, but submitting for early review: https://patches.dpdk.org/patch/81431/ Thanks, On 10/20/20 9:11 AM, Maxime Coquelin wrote: > Hi Yinan, > > On 10/20/20 3:52 AM, Wang, Yinan wrote: >> Hi Adrian/Maxime, >> >> Could you help to take a look at this issue? Most of automated r

[dpdk-dev] [RFC 0/2] fix queue stats mapping

2020-10-20 Thread Min Hu (Connor)
From: Huisong Li This patch set is used to adjust the unreasonable configurations and runtime errors about rx/tx queue stats mapping. Huisong Li (2): app/testpmd: fix queue stats mapping configuration app/testpmd: fix starting failed with queue-stats-mapping app/test-pmd/config.c | 18

[dpdk-dev] [RFC 2/2] app/testpmd: fix starting failed with queue-stats-mapping

2020-10-20 Thread Min Hu (Connor)
From: Huisong Li testpmd fails to start with "--rx-queue-stats-mapping" and "--tx-queue-stats-mapping", which is caused by the failure and exit of 'map_port_queue_stats_mapping_registers' function. By default, the configuration of queue statistics mapping in the initialization process is implemen

[dpdk-dev] [RFC 1/2] app/testpmd: fix queue stats mapping configuration

2020-10-20 Thread Min Hu (Connor)
From: Huisong Li Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure message after executing the command "set stat_qmap rx 0 2 2". 2) Once queue mapping is set, unrelated and unmapped queues are also display

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-20 Thread Thomas Monjalon
20/10/2020 04:49, Ruifeng Wang: > From: Thomas Monjalon > > 15/10/2020 14:04, Anatoly Burakov: > > > +/** > > > + * This function is not supported on ARM. > > > + */ > > > +static inline void > > > +rte_power_monitor(const volatile void *p, const uint64_t > > expected_value, > > > +

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread David Marchand
On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar wrote: > > Build the lib for Windows. > > Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9 > Signed-off-by: Dharmik Thakkar > --- > lib/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/meson.build b/lib/meson.build > ind

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 3:57 AM, Yang, SteveX wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, October 20, 2020 2:05 AM To: Yang, SteveX ; Zhang, Qi Z ; Ananyev, Konstantin ; dev@dpdk.org Cc: Zhao1, Wei ; Guo, Jia ; Yang, Qiming ; Wu, Jingjing ; Xing, Beilei ; Stokes, Ian Subject: R

Re: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure

2020-10-20 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Qiming Yang > Sent: Wednesday, September 2, 2020 2:38 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor > infrastructure > > Defines data structures and code to ini

[dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

2020-10-20 Thread guyk
From: Guy Kaneti Add out of order scan capability to check PMD support for OOS. Signed-off-by: Guy Kaneti --- lib/librte_regexdev/rte_regexdev.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_regexdev/rte_regexdev.h b/lib/librte_regexdev/rte_regexdev.h index 4077e62c9.

[dpdk-dev] [PATCH] net/bnxt: cleanup and fixes in Rx/Tx queue release ops

2020-10-20 Thread Somnath Kotur
Some of the ring related memory was not being freed in both the release ops. Fix to free them now Add some more NULL ptr checks in the corresponding queue_release_mbufs() and queue_release_op() respectively. Also call queue_release_op() in the error path of the corresponding queue_setup_op() Fixes

[dpdk-dev] [RFC V2 1/2] app/testpmd: fix queue stats mapping configuration

2020-10-20 Thread Min Hu (Connor)
From: Huisong Li Currently, the queue stats mapping has the following problems: 1) Many PMD drivers don't support queue stats mapping. But there is no failure message after executing the command "set stat_qmap rx 0 2 2". 2) Once queue mapping is set, unrelated and unmapped queues are also display

[dpdk-dev] [RFC V2 0/2] fix queue stats mapping

2020-10-20 Thread Min Hu (Connor)
From: Huisong Li This patch set is used to adjust the unreasonable configurations and runtime errors about rx/tx queue stats mapping. --- V1 -> V2 * adjust commit log description. --- Huisong Li (2): app/testpmd: fix queue stats mapping configuration app/testpmd: fix starting failed with q

[dpdk-dev] [RFC V2 2/2] app/testpmd: fix starting failed with queue-stats-mapping

2020-10-20 Thread Min Hu (Connor)
From: Huisong Li testpmd fails to start with "--rx-queue-stats-mapping" and "--tx-queue-stats-mapping", which is caused by the failure and exit of 'map_port_queue_stats_mapping_registers' function. By default, the configuration of queue statistics mapping in the initialization process is implemen

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value

2020-10-20 Thread Wang, Haiyue
> -Original Message- > From: Walsh, Conor > Sent: Monday, October 19, 2020 20:26 > To: Guo, Jia ; Wang, Haiyue ; > Yigit, Ferruh > ; Awal, Mohammad Abdul > ; Doherty, Declan > > Cc: dev@dpdk.org; Walsh, Conor > Subject: [PATCH 1/2] net/ixgbe: fix unchecked return value > > The return

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Dmitry Kozlyuk
On Tue, 20 Oct 2020 10:13:11 +0200, David Marchand wrote: > On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar > wrote: > > > > Build the lib for Windows. > > > > Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9 > > Signed-off-by: Dharmik Thakkar > > --- > > lib/meson.build | 1 + > > 1 file c

Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants

2020-10-20 Thread Bruce Richardson
On Mon, Oct 19, 2020 at 11:04:54PM +0200, Thomas Monjalon wrote: > 19/10/2020 12:21, Bruce Richardson: > > On Fri, Oct 16, 2020 at 06:46:12PM +0200, David Marchand wrote: > > > On Fri, Oct 16, 2020 at 5:56 PM Bruce Richardson > > > wrote: > > > > > librte_eal.so is indeed built with the 64 value:

Re: [dpdk-dev] [PATCH v5 6/8] devtools/test-null: load all drivers from directory

2020-10-20 Thread Bruce Richardson
On Mon, Oct 19, 2020 at 06:58:32PM +0200, Thomas Monjalon wrote: > 15/10/2020 17:05, Bruce Richardson: > > Rather than specifying specific drivers in the driver directory to load, we > > can just pass in the whole driver directory to the "-d" EAL flag, causing > > all drivers to load. This makes th

Re: [dpdk-dev] [PATCH v5 0/8] Rework build macros

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 09:17:11AM +0200, David Marchand wrote: > On Mon, Oct 19, 2020 at 10:27 PM Thomas Monjalon wrote: > > > > 15/10/2020 17:05, Bruce Richardson: > > > Following on from discussion in RFC v1 and v2 of this set, this version > > > reworks the automated macros defined by meson to

[dpdk-dev] [RFC 0/2] net/i40e: add VXLAN-GPE and IP-in-GRE flow parsing

2020-10-20 Thread Chenxu Di
The patches add VXLAN-GPE and IP-in-GRE flow parsing function to support VXLAN-GPE and IP-in-GRE classifications. Chenxu Di (1): net/i40e: add IP-in-GRE flow parsing Junyu Jiang (1): net/i40e: add VXLAN-GPE flow parsing drivers/net/i40e/i40e_ethdev.c | 14 +- drivers/net/i40e/i40e_ethdev.h

[dpdk-dev] [RFC 1/2] net/i40e: add VXLAN-GPE flow parsing

2020-10-20 Thread Chenxu Di
From: Junyu Jiang This patch adds VXLAN-GPE flow parsing function to support VXLAN-GPE classification. Signed-off-by: Junyu Jiang --- drivers/net/i40e/i40e_ethdev.c | 14 +- drivers/net/i40e/i40e_ethdev.h | 5 + drivers/net/i40e/i40e_flow.c | 375 + 3 files

[dpdk-dev] [RFC 2/2] net/i40e: add IP-in-GRE flow parsing

2020-10-20 Thread Chenxu Di
This patch adds IP in GRE flow parsing function to support IP in GRE classification. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_flow.c | 237 +++ 1 file changed, 237 insertions(+) diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c in

Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Jiang, YuX
Tested-by: JiangYuX Best Regards Jiang yu > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrian Moreno > Sent: Tuesday, October 20, 2020 3:16 PM > To: dev@dpdk.org > Cc: Wang, Yinan ; Fu, Patrick > ; amore...@redhat.com; sta...@dpdk.org; Maxime > Coq

[dpdk-dev] [PATCH 04/62] common/sfc_efx/base: add MAE init/fini APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The patch adds APIs for client drivers to initialise / finalise MAE-specific context in NIC control structure. The context itself will be used by the follow-up patches to store supportive data for library-internal consumers. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybch

[dpdk-dev] [PATCH 03/62] net/sfc: add a stub for attaching to MAE

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add a stub for MAE attach / detach path and introduce MAE-specific context. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/meson.build | 1 + drivers/net/sfc/sfc.c | 8 ++ drivers/net/sfc/sfc.h | 2 +

[dpdk-dev] [PATCH 05/62] drivers: init/fini MAE on attach/detach

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov These actions affect MAE supplementary resources which are libefx-internal. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/efsys.h | 2 +- drivers/net/sfc/sfc_mae.c | 17 + 2 files changed,

[dpdk-dev] [PATCH 06/62] common/sfc_efx/base: add an MAE limit query API

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add an API for client drivers to query the engine limits. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 10 +++ drivers/common/sfc_efx/base/efx_impl.h| 1 + drivers/common/sfc_

[dpdk-dev] [PATCH 07/62] net/sfc: add the concept of MAE (transfer) rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Define the corresponding specification structure and make the code identify MAE rules by testing transfer attribute presence. Also, add a priority level check. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst

[dpdk-dev] [PATCH 02/62] common/sfc_efx/base: indicate support for MAE

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Riverhead boards maintain support for MAE, a low-level Match-Action Engine. The feature is documented in SF-122526-TC. The new field will help client drivers to test NIC support for MAE status. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreto

[dpdk-dev] [PATCH 00/62] net/sfc: support flow API transfer rules

2020-10-20 Thread Andrew Rybchenko
Transfer rules for Alveo SN1000 SmartNICs support matching on various inner and outer packet headers, traffic source items like PORT_ID, PHY_PORT, PF and VF and actions to route traffic to destination (PORT_ID, PHY_PORT, PF, VF or DROP), MARK, FLAG and apply VLAN push/pop transformations. Andrew

[dpdk-dev] [PATCH 10/62] common/sfc_efx/base: add a match spec validate API

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE has restrictions on what kind of mask a particular field can have in a match specification. Add an API for client drivers to check specifications. The patch defines a field description list, whilst the list itself is left empty. This is to provide a general idea of how field

[dpdk-dev] [PATCH 21/62] net/sfc: support flow action PHY PORT in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action DELIVER with MPORT of a given physical port. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 drivers/net/sfc/sfc_mae.c | 40 +++

[dpdk-dev] [PATCH 16/62] common/sfc_efx/base: support setting a PPORT in a match spec

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add an API for setting mask-value pairs in a match specification structure and add support for MAE field INGRESS_PORT of type PPORT. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 48 ++

[dpdk-dev] [PATCH 08/62] common/sfc_efx/base: add match spec init/fini APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov An MAE rule is a function of match criteria and a priority. The said match criteria have to be provided using "mask-value pairs" packing format which on its own should not be exposed to client drivers. The latter have to use a functional interface of sorts in order to generate a

[dpdk-dev] [PATCH 15/62] net/sfc: add actions parsing stub to MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov If parsing a flow results in an action set specification identical to an already existing one, duplication will be avoided by reusing the list entry of the latter. Using an attach helper and a reference counter is meant to serve the said purpose. Signed-off-by: Ivan Malov Signe

[dpdk-dev] [PATCH 09/62] net/sfc: add pattern parsing stub to MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add pattern parsing stub, define and implement flow cleanup method. The latter is needed to free any dynamic structures allocated during flow parsing. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_flow.c | 41

[dpdk-dev] [PATCH 23/62] common/sfc_efx/base: add MAE action rule provisioning APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add APIs for action rule insert / remove operations. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 29 drivers/common/sfc_efx/base/efx_mae.c | 150 ++ .../

[dpdk-dev] [PATCH 25/62] common/sfc_efx/base: support adding VLAN POP action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE supports stripping two tags, so this action can be requested once or twice. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 ++ drivers/common/sfc_efx/base/efx_impl.h| 7 +

[dpdk-dev] [PATCH 22/62] common/sfc_efx/base: add MAE action set provisioning APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The patch adds APIs for action set allocation / release. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 20 +++ drivers/common/sfc_efx/base/efx_mae.c | 128 ++ .

[dpdk-dev] [PATCH 20/62] common/sfc_efx/base: support adding DELIVER action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Introduce a mechanism for adding actions to an action set and add support for DELIVER action. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 11 +- drivers/common/sfc_efx/base/efx_impl.

[dpdk-dev] [PATCH 27/62] common/sfc_efx/base: support adding VLAN PUSH action

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE supports pushing two tags, so this action can be requested once or twice. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 7 ++ drivers/common/sfc_efx/base/efx_impl.h| 12 +++

[dpdk-dev] [PATCH 11/62] net/sfc: validate match spec in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Validate the match specification resulting from pattern parsing within MAE backend in RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 8 1 file changed, 8 insertions(+) dif

[dpdk-dev] [PATCH 12/62] common/sfc_efx/base: add a match specs class comparison API

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov >From MAE standpoint, a flow rule belongs to some class. Field capabilities advertised by the FW provide a hint on whether changing a particular match field value or its mask will affect the class of the rule. A client driver can make use of the concept of a class by comparing a

[dpdk-dev] [PATCH 26/62] net/sfc: support flow action OF POP VLAN in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This action is supported only for rules which have transfer attribute, and can be requested once or twice per a rule. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 3 +

[dpdk-dev] [PATCH 13/62] net/sfc: add verify method to flow validate path

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The new method is needed to make sure that a flow being validated will have a chance to be accepted by the FW. MAE-specific implementation of the method should compare the class of a rule being validated with the corresponding classes of active rules, and, if no matches found, ma

[dpdk-dev] [PATCH 24/62] net/sfc: implement flow insert/remove in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Exercise action set allocation / release and action rule insertion / removal in order to let flow API callers actually get created flows functioning. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_flow.c | 5 +-

[dpdk-dev] [PATCH 01/62] common/sfc_efx/base: add MAE definitions to MCDI

2020-10-20 Thread Andrew Rybchenko
MAE stands for Match-Action-Engine and will be used to support rte_flow API transfer rules. Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2232 +++ 1 file changed, 2232 insertions(+) diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/

[dpdk-dev] [PATCH 29/62] net/sfc: support VLAN PUSH actions in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov A group of actions (OF_PUSH_VLAN, OF_VLAN_SET_VID and OF_VLAN_SET_PCP) maps to MAE action VLAN_PUSH. This action group is supported only for rules which have transfer attribute, and can be requested once or twice per a rule. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybc

[dpdk-dev] [PATCH 48/62] common/sfc_efx/base: add MAE match fields for IPv4

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 +

[dpdk-dev] [PATCH 19/62] net/sfc: support flow item ETH in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sfc_mae.c | 106 2 file

[dpdk-dev] [PATCH 44/62] net/sfc: support flow action PORT ID in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action DELIVER with MPORT of the PCIe function associated with a given DPDK port ID. The DPDK port must not relate to a different physical device. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guid

[dpdk-dev] [PATCH 33/62] net/sfc: support flow action MARK in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action MARK. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 12 2 files changed, 14 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH 46/62] common/sfc_efx/base: add MAE match fields for VLAN

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 4 ++

[dpdk-dev] [PATCH 36/62] net/sfc: support flow items PF and VF in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for these flow items to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 ++ drivers/net/sfc/sfc_mae.c | 126 dri

[dpdk-dev] [PATCH 18/62] common/sfc_efx/base: add MAE match fields for Ethernet

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 3 ++

[dpdk-dev] [PATCH 38/62] common/sfc_efx/base: add an API for adding action DROP

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Client drivers may need to request that matching traffic be dropped. Add a dedicated API to support this. The API relies on action DELIVER with properly constructed NULL MPORT argument. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- d

[dpdk-dev] [PATCH 45/62] net/sfc: support flow item PORT ID in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. The DPDK port must not relate to a different physical device. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/

[dpdk-dev] [PATCH 39/62] net/sfc: support flow action DROP in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Effectively, the resulting action will be of type DELIVER, and destination MPORT will be a properly constructed NULL value. This will achieve the requested behaviour (no delivery). Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/gu

[dpdk-dev] [PATCH 55/62] common/sfc_efx/base: indicate MAE support for encapsulation

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE provides support for encapsulation. One needs to insert a so-called outer rule, which can match outer packet fields, to require that matching packets be parsed as tunnel frames of a given type (VXLAN, Geneve, NVGRE). Then it is possible to chain this rule with an action rule

[dpdk-dev] [PATCH 30/62] common/sfc_efx/base: support adding FLAG action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This action can be added at any point before DELIVER. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 ++ drivers/common/sfc_efx/base/efx_impl.h| 8 +++ drivers/common/sfc_efx

[dpdk-dev] [PATCH] eal/windows: fix missing header inclusion

2020-10-20 Thread Tal Shnaiderman
Following the addition of the in_addr/in6_addr structs to in.h the header file must have stdint.h included for the definitions of the uint8_t/uint32_t types used within the new structs. Not having it could results in the following errors in places where in.h is included: in.h:30:2: error: unknown

[dpdk-dev] [PATCH 31/62] net/sfc: support flow action FLAG in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action FLAG. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 5 + 2 files changed, 7 insertions(+) diff --git a/doc/guides/nics/sfc_

[dpdk-dev] [PATCH 14/62] common/sfc_efx/base: add action set spec init/fini APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The engine is only able to carry out chosen actions on matching packets in a strict order. No MCDI exists to identify supported actions and the order. Still, the definition of the latter is available from the FW documentation. The general idea is to define an action specificatio

[dpdk-dev] [PATCH 28/62] net/sfc: add facilities to handle bundles of actions

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov There are MAE actions which do not have uniform counterparts in terms of RTE flow. However, there are bundles of RTE flow actions which can be considered as such counterparts. Implement facilities to handle related RTE flow actions as parts of a whole. These facilities will be u

[dpdk-dev] [PATCH 35/62] common/sfc_efx/base: add an API to get MPORT of a PF/VF

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov PCIe functions have static MPORTs which can be utilised by MAE rules as delivery destinations for matching traffic. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 14 +++ drivers/com

[dpdk-dev] [PATCH 57/62] common/sfc_efx/base: add MAE match field VNET ID for tunnels

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for this field and provide necessary mappings for it to be inserted directly into mask-value pairs buffer. VNET_ID can be used to serve the following match fields: rte_flow_item_vxlan.vni, rte_flow_item_geneve.vni, rte_flow_item_nvgre.tni Signed-

[dpdk-dev] [PATCH 34/62] common/sfc_efx/base: add named constant for invalid VF

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This makes existing code clearer. Also, it will be used by a later patch. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/

[dpdk-dev] [PATCH 40/62] common/sfc_efx/base: refactor version / boot info get helper

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Refactor MCDI helper for version information and boot status retrieval; it should comprise two dedicated helper functions. A later patch will extend and reuse version retrieval helper. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/

[dpdk-dev] [PATCH 50/62] common/sfc_efx/base: add MAE match fields for IPv6

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 2 ++

[dpdk-dev] [PATCH 62/62] doc: advertise flow API transfer rules support in net/sfc

2020-10-20 Thread Andrew Rybchenko
Transfer rules support matching on various inner and outer packet headers, traffic source items like PORT_ID, PHY_PORT, PF and VF and actions to route traffic to destination (PORT_ID, PHY_PORT, PF, VF or DROP), MARK, FLAG and apply VLAN push/pop transformations. Signed-off-by: Andrew Rybchenko --

[dpdk-dev] [PATCH 56/62] common/sfc_efx/base: add MAE encap. match fields

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. These fields are meant to comprise a so-called outer match specification; provide necessary definitions. Signed-off-by: Ivan Malov Sig

[dpdk-dev] [PATCH 37/62] net/sfc: support flow actions PF and VF in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action DELIVER with MPORT of the PF/VF. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 drivers/net/sfc/sfc_mae.c | 34 ++ 2 files

[dpdk-dev] [PATCH 52/62] common/sfc_efx/base: add MAE match fields for TCP and UDP

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 3 ++

[dpdk-dev] [PATCH 54/62] net/sfc: support flow item UDP in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 53 + driver

[dpdk-dev] [PATCH 53/62] net/sfc: support flow item TCP in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sfc_mae.c | 77 + drivers

[dpdk-dev] [PATCH 51/62] net/sfc: support flow item IPV6 in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 3 + drivers/net/sfc/sfc_mae.c | 106 driver

[dpdk-dev] [PATCH 60/62] common/sfc_efx/base: support outer rule provisioning

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Let the client insert / remove outer rules. Let the client refer to an inserted outer rule in a match specification of type ACTION. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 21 ++

[dpdk-dev] [PATCH 32/62] common/sfc_efx/base: support adding MARK action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This action can be added at any point before DELIVER. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 6 ++ drivers/common/sfc_efx/base/efx_impl.h| 2 + drivers/common/sfc_efx/b

[dpdk-dev] [PATCH 17/62] net/sfc: support flow item PHY PORT in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 +++ drivers/net/sfc/sfc_mae.c | 69 + drive

[dpdk-dev] [PATCH 47/62] net/sfc: support flow item VLAN in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. In a pattern, a L2 item preceding an item VLAN must have correct "type" ("inner_type") set depending on the total number of VLAN tags (double-tagging is supported): "pattern eth type is X / vlan / end", X =

[dpdk-dev] [PATCH 43/62] net/sfc: support the concept of RTE switch domains/ports

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov A later patch will add support for RTE flow action PORT_ID to MAE backend. The driver has to ensure that such actions refer to RTE ethdev instances deployed on top of the same physical device. Also, the driver needs a means to find sibling RTE ethdev instances when parsing such a

[dpdk-dev] [PATCH 42/62] net/sfc: add HW switch ID helpers

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The driver will need a means to figure out relationship between RTE ethdev instances and underlying HW switch entities. For now, use board serial number string as a unique HW switch identifier. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton

[dpdk-dev] [PATCH 41/62] common/sfc_efx/base: add an API for querying board info

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Riverhead boards can provide extended version information. Implement facilities necessary to obtain it. Add an API for querying board information. A client driver may use this to discover which of its instances relate to which physical boards, based on board serial number persis

[dpdk-dev] [PATCH 61/62] net/sfc: support encap. flow items in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for flow items VXLAN, Geneve and NVGRE to MAE-specific RTE flow implementation. Having support for these items implies the ability to insert so-called outer MAE rules and refer to them in MAE action rules. The patch takes care of all necessary facilities to do that.

[dpdk-dev] [PATCH 49/62] net/sfc: support flow item IPV4 in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 3 + drivers/net/sfc/sfc_mae.c | 121 driver

[dpdk-dev] [PATCH 58/62] common/sfc_efx/base: add an API to compare match specs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Match specification format and its size are not exposed to clients. Provide an API to compare two match specifications. A client would typically use this API to compare a match specification of an outer rule being validated with match specifications of already active outer rules

[dpdk-dev] [PATCH 59/62] common/sfc_efx/base: validate and compare outer match specs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Let the client validate an outer match specification. Let the client comprare classes of two outer match specifications. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_impl.h | 3 + drivers/common/sfc

[dpdk-dev] [PATCH] net/ice/base: fix a refactor error

2020-10-20 Thread Simei Su
This patch corrects an upper limit value in for loop. Fixes: dd4a3cef556a ("net/ice/base: introduce and use bitmap set API") Signed-off-by: Simei Su --- drivers/net/ice/base/ice_bitops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_bitops.h b/dri

Re: [dpdk-dev] [PATCH 00/62] net/sfc: support flow API transfer rules

2020-10-20 Thread Andrew Rybchenko
On 10/20/20 11:47 AM, Andrew Rybchenko wrote: > Transfer rules for Alveo SN1000 SmartNICs support matching on various > inner and outer packet headers, traffic source items like PORT_ID, > PHY_PORT, PF and VF and actions to route traffic to destination > (PORT_ID, PHY_PORT, PF, VF or DROP), MARK, F

[dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration

2020-10-20 Thread Junyu Jiang
This patch configured RSS for sctp with IP address and port as input set. Fixes: 4717a12cfaf1 ("net/ice: initialize and update RSS based on user config") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [dpdk-dev] [PATCH v4] net/iavf: fix adding multicast MAC address

2020-10-20 Thread Zhang, Qi Z
> -Original Message- > From: Guinan Sun > Sent: Thursday, October 15, 2020 4:43 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Wu, Jingjing ; Sun, GuinanX > Subject: [PATCH v4] net/iavf: fix adding multicast MAC address > > When the multicast address list is added, it will

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread oulijun
在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration.

Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Kevin Traynor
On 20/10/2020 08:16, Adrian Moreno wrote: > If stat fails it means the backend must be vhost-user in server mode > > Bugzilla ID: 559 > Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") > Cc: sta...@dpdk.org > > Signed-off-by: Adrian Moreno > --- > drivers/net/virtio/vir

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value

2020-10-20 Thread Walsh, Conor
Thanks Haiyue, I will implement a v2, following your suggestions. /Conor. > -Original Message- > From: Wang, Haiyue > Sent: Tuesday 20 October 2020 09:34 > To: Walsh, Conor ; Guo, Jia ; > Yigit, Ferruh ; Awal, Mohammad Abdul > ; Doherty, Declan > > Cc: dev@dpdk.org > Subject: RE: [PATC

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-20 Thread Ananyev, Konstantin
> > testpmd will initialize default max packet length to 1518 which > doesn't include vlan tag size in ether overheader. Once, send the > max mtu length packet with vlan tag, the max packet length will > exceed 1518 that will cause p

Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Maxime Coquelin
On 10/20/20 11:01 AM, Kevin Traynor wrote: > On 20/10/2020 08:16, Adrian Moreno wrote: >> If stat fails it means the backend must be vhost-user in server mode >> >> Bugzilla ID: 559 >> Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") >> Cc: sta...@dpdk.org >> >> Signed-o

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: remove unused scan by address

2020-10-20 Thread David Marchand
On Wed, Oct 14, 2020 at 10:20 PM Thomas Monjalon wrote: > > The function pci_update_device was used to scan a device > for probing by PCI address. > This private function (and implementations) are unused > since such probing is removed. > > Fixes: f3bac43b60da ("bus/pci: remove unused function to

  1   2   3   4   >