Re: [dpdk-dev] [PATCH v4 0/2] Few enhancements for l3fwd-acl

2020-10-19 Thread David Marchand
On Fri, Oct 16, 2020 at 3:13 PM Konstantin Ananyev wrote: > > v3 -> v4: > Address David comments: > - squash patches #2 and #3 into one > - set default values for dest MACs > > Improve l3fwd-acl usability. > Allow to specify destination MAC and explicitly select classify algorithm. > > Konst

Re: [dpdk-dev] [PATCH 1/2] pipeline: fix jump instruction population

2020-10-19 Thread David Marchand
On Fri, Oct 16, 2020 at 3:58 PM Cristian Dumitrescu wrote: > > From: Venkata Suresh Kumar P > > This patch fixes jump next instruction pointer > population > > Fixes: b3947e25bed4 ("pipeline: introduce SWX jump and return instructions") > Cc: cristian.dumitre...@intel.com > > Signed-off-by: Venka

Re: [dpdk-dev] [PATCH] examples/pipeline: fix resource release in table update

2020-10-19 Thread David Marchand
On Tue, Oct 13, 2020 at 8:41 PM Cristian Dumitrescu wrote: > > Fix the resource release sequence in table update. > > Fixes: 5074e1d551 ("examples/pipeline: add configuration commands") > Coverity issues: 362882, 363041, 363044, 363047 $ ./devtools/check-git-log.sh Missing 'Coverity issue:' tag:

Re: [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx offload to drop error packets

2020-10-19 Thread Ajit Khaparde
On Thu, Oct 15, 2020 at 6:24 AM wrote: > > From: Nipun Gupta > > This change adds a Rx offload capability and configuration to > enable hardware to drop the packets in case of any error in the > packets such as L3 checksum error or L4 checksum. > > Signed-off-by: Nipun Gupta > Signed-off-by: Roh

Re: [dpdk-dev] [PATCH v1] app/regex: fix segfault in getopt_long call

2020-10-19 Thread Ori Kam
Hi Ophir, > -Original Message- > From: Ophir Munk > Sent: Sunday, October 18, 2020 5:22 PM > Subject: [PATCH v1] app/regex: fix segfault in getopt_long call > > getopt_long() parses command-line arguments. One of its arguments > 'longopts' is a pointer to the first element of an array of

Re: [dpdk-dev] [PATCH v5] security: update session create API

2020-10-19 Thread Thomas Monjalon
18/10/2020 13:03, Lukasz Wojciechowski: > W dniu 18.10.2020 o 11:40, Akhil Goyal pisze: > > The API ``rte_security_session_create`` takes only single > > mempool for session and session private data. So the > > application need to create mempool for twice the number of > > sessions needed and will

Re: [dpdk-dev] [PATCH 08/14] ethdev: remove legacy TUNNEL filter type support

2020-10-19 Thread Li, Xiaoyun
Hi Thanks for the work and notice. Actually, the tep_termination example has not been used for a long time. And the cases it want to test can already be covered by rte_flow_create tunnel test cases. So it makes sense to just deprecate this example. I'll do that soon and cc to you. So don't worr

Re: [dpdk-dev] [PATCH v1] app/regex: fix segfault in getopt_long call

2020-10-19 Thread Lukasz Wojciechowski
Hi, W dniu 19.10.2020 o 09:46, Ori Kam pisze: > Hi Ophir, > >> -Original Message- >> From: Ophir Munk >> Sent: Sunday, October 18, 2020 5:22 PM >> Subject: [PATCH v1] app/regex: fix segfault in getopt_long call >> >> getopt_long() parses command-line arguments. One of its arguments >> 'lo

Re: [dpdk-dev] [PATCH] raw/ioat: fix dereference before null check

2020-10-19 Thread Thomas Monjalon
14/10/2020 13:34, Bruce Richardson: > On Wed, Oct 14, 2020 at 11:11:10AM +0100, Kevin Laatz wrote: > > The 'idxd' pointer in 'idxd_rawdev_destroy()' is being dereferenced before > > it is checked. To fix this, the null pointer check was moved to occur > > earlier in the code. > > > > Coverity issu

[dpdk-dev] [PATCH] examples/tep_term: deprecate this example

2020-10-19 Thread Xiaoyun Li
The tunnel cases this example wants to test can be covered by testpmd with rte_flow_create. And this example hasn't been used for a long time. So deprecate this example. Signed-off-by: Xiaoyun Li --- MAINTAINERS |4 - .../img/tep_termination_arch.svg

Re: [dpdk-dev] [PATCH] ethdev: rename tunnel offload callbacks

2020-10-19 Thread Ferruh Yigit
On 10/18/2020 1:15 PM, Gregory Etelson wrote: rename new rte_flow ops callbacks to emphasize relation to tunnel offload API. Signed-off-by: Gregory Etelson Acked-by: Ori Kam --- lib/librte_ethdev/rte_flow.c| 13 +++-- lib/librte_ethdev/rte_flow_driver.h | 4 ++-- 2 files c

Re: [dpdk-dev] [PATCH v8 00/17] fix distributor synchronization issues

2020-10-19 Thread David Marchand
On Sat, Oct 17, 2020 at 5:07 AM Lukasz Wojciechowski wrote: > > During review and verification of the patch created by Sarosh Arif: > "test_distributor: prevent memory leakages from the pool" I found out > that running distributor unit tests multiple times in a row causes fails. > So I investigate

Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages from the pool

2020-10-19 Thread David Marchand
On Fri, Sep 25, 2020 at 5:27 PM David Hunt wrote: > On 8/9/2020 11:22 AM, Sarosh Arif wrote: > > rte_mempool_get_bulk is used to get bufs/many_bufs from the pool, > > but at some locations when test fails the bufs/many_bufs are > > not returned back to the pool. > > Due to this, multiple execution

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-19 Thread Bruce Richardson
On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > wrote: > > > > Adds the meson build infrastructure, which includes > > compile-time constants in rte_config.h. DLB2 is > > only supported on Linux X86 platforms at this time. > > > >

Re: [dpdk-dev] [PATCH v1] app/regex: fix segfault in getopt_long call

2020-10-19 Thread Ophir Munk
Adding Thomas Monjalon Thomas - when merging can you please remove the line: Cc: sta...@dpdk.org ? > -Original Message- > From: Lukasz Wojciechowski > Sent: Monday, October 19, 2020 11:13 AM > To: Ori Kam ; Ophir Munk ; > dev@dpdk.org; Raslan Darawsheh > Cc: sta...@dpdk.org; "'Lukasz Woj

Re: [dpdk-dev] [PATCH] raw/ioat: fix kvlist free

2020-10-19 Thread Thomas Monjalon
14/10/2020 12:09, Kevin Laatz: > There is a null pointer check in 'idxd_vdev_parse_params()' which is > causing a coverity issue. This check is redundant as the same check is > being done in 'rte_kvargs_free()', so it is simply removed in this patch. > > In addition, kvlist was only being free'd o

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 19, 2020 9:44 AM > To: Ananyev, Konstantin > Subject: FW: Re:RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments > attach to > > > > From: yang_y_yi mailto:yang_y...@163.com>> > Sent: Monday, Octobe

Re: [dpdk-dev] [PATCH] examples/tep_term: deprecate this example

2020-10-19 Thread Thomas Monjalon
19/10/2020 10:27, Xiaoyun Li: > The tunnel cases this example wants to test can be covered by testpmd > with rte_flow_create. And this example hasn't been used for a long time. > So deprecate this example. > > Signed-off-by: Xiaoyun Li Acked-by: Thomas Monjalon Thanks for the cleanup.

[dpdk-dev] [PATCH v4 00/58] net: txgbe PMD

2020-10-19 Thread Jiawen Wu
v4: Add log type introduction, add txgbe support in release note. v3: Merge some recent changes in the main repo, fix the checkpatch warnings. v2: Re-order patches and fix some known problems. v1: Introduce txgbe PMD. Jiawen Wu (58): net/txgbe: add build and doc infrastructure net/txg

[dpdk-dev] [PATCH v4 02/58] net/txgbe: add ethdev probe and remove

2020-10-19 Thread Jiawen Wu
From: jiawenwu Add basic PCIe ethdev probe and remove. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build| 18 + drivers/net/txgbe/base/txgbe.h| 10 +++ drivers/net/txgbe/base/txgbe_devids.h | 40 ++ drivers/net/txgbe/base/txgbe_type.h | 14 driv

[dpdk-dev] [PATCH v4 04/58] net/txgbe: add error types and registers

2020-10-19 Thread Jiawen Wu
Add error types and registers. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 1887 + drivers/net/txgbe/base/txgbe_status.h | 122 ++ 2 files changed, 2009 insertions(+) create mode 100644 drivers/net/txgbe/base/txgbe_regs.h create mode 100644 dri

[dpdk-dev] [PATCH v4 03/58] net/txgbe: add device init and uninit

2020-10-19 Thread Jiawen Wu
From: jiawenwu Add basic init and uninit function, and some macro definitions prepare for hardware infrastructure. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_osdep.h | 181 +++ drivers/net/txgbe/base/txgbe_type.h | 20 +++ drivers/net/txgbe/txgbe_ethdev

[dpdk-dev] [PATCH v4 01/58] net/txgbe: add build and doc infrastructure

2020-10-19 Thread Jiawen Wu
From: jiawenwu Adding bare minimum PMD library and doc build infrastructure and claim the maintainership for txgbe PMD. Signed-off-by: Jiawen Wu --- MAINTAINERS | 7 ++ doc/guides/nics/features/txgbe.ini | 11 + doc/guides/nics/txgbe.rst

[dpdk-dev] [PATCH v4 05/58] net/txgbe: add MAC type and bus lan id

2020-10-19 Thread Jiawen Wu
Add base driver shared code. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build | 4 +- drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 134 + drivers/net/txgbe/base/txgbe_hw.h | 16 +++ drivers/net/txgbe/base/txgbe_ty

[dpdk-dev] [PATCH v4 08/58] net/txgbe: add HW init and reset operation

2020-10-19 Thread Jiawen Wu
Add hardware init function and reset operation in mac layer. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 255 drivers/net/txgbe/base/txgbe_hw.h | 6 +- drivers/net/txgbe/base/txgbe_type.h | 15 ++ drivers/net/txgbe/txgbe_ethdev.c| 35

[dpdk-dev] [PATCH v4 06/58] net/txgbe: add HW infrastructure and dummy function

2020-10-19 Thread Jiawen Wu
Add hardware infrastructure and dummy function. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 657 +++ drivers/net/txgbe/base/txgbe_hw.c| 13 + drivers/net/txgbe/base/txgbe_type.h | 187 +++- 3 files changed, 856 insertions(+), 1 deletion(-

[dpdk-dev] [PATCH v4 11/58] net/txgbe: add PHY reset

2020-10-19 Thread Jiawen Wu
Add phy reset function, support read and write phy registers. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 5 + drivers/net/txgbe/base/txgbe_phy.c | 226 + drivers/net/txgbe/base/txgbe_phy.h | 10 ++ 3 files changed, 241 insertions(+) diff --g

[dpdk-dev] [PATCH v4 12/58] net/txgbe: add info get operation

2020-10-19 Thread Jiawen Wu
Add device information get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 7 +- drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.c| 79 ++

[dpdk-dev] [PATCH v4 13/58] net/txgbe: add interrupt operation

2020-10-19 Thread Jiawen Wu
Add device interrupt handler and setup misx interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + doc/guides/nics/txgbe.rst | 5 + drivers/net/txgbe/base/txgbe_type.h | 8 + drivers/net/txgbe/txgbe_ethdev.c| 467 drive

[dpdk-dev] [PATCH v4 07/58] net/txgbe: add EEPROM functions

2020-10-19 Thread Jiawen Wu
Add EEPROM functions. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build| 2 + drivers/net/txgbe/base/txgbe.h| 2 + drivers/net/txgbe/base/txgbe_eeprom.c | 581 ++ drivers/net/txgbe/base/txgbe_eeprom.h | 49 +++ drivers/net/txgbe/base/txgbe_h

[dpdk-dev] [PATCH v4 14/58] net/txgbe: add device configure operation

2020-10-19 Thread Jiawen Wu
Add device configure operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst| 1 + drivers/net/txgbe/txgbe_ethdev.c | 195 +++ drivers/net/txgbe/txgbe_ethdev.h | 7 ++ 3 files changed, 203 insertions(+) diff --git a/doc/guides/nics/txgbe.rst b/d

[dpdk-dev] [PATCH v4 17/58] net/txgbe: add autoc read and write

2020-10-19 Thread Jiawen Wu
Add autoc read and write for kr/kx/kx4/sfi link. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 2 + drivers/net/txgbe/base/txgbe_phy.c | 859 drivers/net/txgbe/base/txgbe_phy.h | 2 + drivers/net/txgbe/base/txgbe_type.h | 21 + 4 files cha

[dpdk-dev] [PATCH v4 09/58] net/txgbe: add PHY init

2020-10-19 Thread Jiawen Wu
Add phy init functions, get phy type and identify. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 50 + drivers/net/txgbe/base/txgbe_hw.h | 2 + drivers/net/txgbe/base/txgbe_phy

[dpdk-dev] [PATCH v4 16/58] net/txgbe: add multi-speed link setup

2020-10-19 Thread Jiawen Wu
Add multispeed fiber setup link and laser control. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 398 +- drivers/net/txgbe/base/txgbe_hw.h | 11 + 2 files changed, 408 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/

[dpdk-dev] [PATCH v4 10/58] net/txgbe: add module identify

2020-10-19 Thread Jiawen Wu
Add sfp anf qsfp module identify, i2c start and stop. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_phy.c| 588 +- drivers/net/txgbe/base/txgbe_phy.h| 12 +

[dpdk-dev] [PATCH v4 19/58] net/txgbe: add unicast hash bitmap

2020-10-19 Thread Jiawen Wu
Add unicast hash bitmap. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 4 +- drivers/net/txgbe/txgbe_ethdev.c| 120 drivers/net/txgbe/txgbe_ethdev.h| 10 +++ 3 files changed, 133 insertions(+), 1 deletion(-) diff --git a/drivers/net/t

[dpdk-dev] [PATCH v4 21/58] net/txgbe: add Rx and Tx queues setup and release

2020-10-19 Thread Jiawen Wu
Add receive and transmit queues setup and release. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 4 + drivers/net/txgbe/txgbe_ethdev.h | 13 + drivers/net/txgbe/txgbe_rxtx.c | 510 +++ drivers/net/txgbe/txgbe_rxtx.h | 130 4 files cha

[dpdk-dev] [PATCH v4 15/58] net/txgbe: add link status change

2020-10-19 Thread Jiawen Wu
Add ethdev link interrupt handler, MAC setup link and check link status and get capabilities. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 3 + drivers/net/txgbe/base/txgbe_hw.c | 498 +- drivers/net/txgbe/base/txgbe_hw.h | 15 + drivers

[dpdk-dev] [PATCH v4 22/58] net/txgbe: add Rx and Tx start and stop

2020-10-19 Thread Jiawen Wu
Add receive and transmit units start and stop for specified queue. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 3 + drivers/net/txgbe/txgbe_ethdev.c| 6 + drivers/net/txgbe/txgbe_ethdev.h| 15 ++ drivers/net/txgbe/t

[dpdk-dev] [PATCH v4 18/58] net/txgbe: add MAC address operations

2020-10-19 Thread Jiawen Wu
Add MAC address related operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini| 2 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_eeprom.h | 2 + drivers/net/txgbe/base/txgbe_hw.c | 476 ++ drivers/net/txgbe/

[dpdk-dev] [PATCH v4 23/58] net/txgbe: add packet type

2020-10-19 Thread Jiawen Wu
Add packet type marco definition and convert ptype to ptid. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe_ptypes.

[dpdk-dev] [PATCH v4 24/58] net/txgbe: fill simple transmit function

2020-10-19 Thread Jiawen Wu
Fill simple transmit function and define transmit descriptor. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_rxtx.c | 237 - drivers/net/txgbe/txgbe_rxtx.h | 84 +++- 2 files changed, 318 insertions(+), 3 deletions(-) diff --git a/drivers/net/txgbe

[dpdk-dev] [PATCH v4 26/58] net/txgbe: fill Tx prepare function

2020-10-19 Thread Jiawen Wu
Fill transmit prepare function. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 3 ++ drivers/net/txgbe/txgbe_rxtx.c | 61 3 files changed, 65 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c

[dpdk-dev] [PATCH v4 25/58] net/txgbe: fill transmit function with hardware offload

2020-10-19 Thread Jiawen Wu
Fill transmit function with hardware offload. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 7 + doc/guides/nics/txgbe.rst | 3 + drivers/net/txgbe/txgbe_ethdev.c | 26 ++ drivers/net/txgbe/txgbe_ethdev.h | 6 + drivers/net/txgbe/txgbe_rxtx.c | 670 +++

[dpdk-dev] [PATCH v4 27/58] net/txgbe: fill receive functions

2020-10-19 Thread Jiawen Wu
Fill receive functions and define receive descriptor. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 3 +- drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/txgbe_ethdev.c| 14 + drivers/net/txgbe/txgbe_ethdev.h

[dpdk-dev] [PATCH v4 20/58] net/txgbe: add Rx and Tx init

2020-10-19 Thread Jiawen Wu
Add receive and transmit initialize unit. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 4 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_type.h | 2 + drivers/net/txgbe/txgbe_ethdev.h| 8 + drivers/net/txgbe/txgbe_rxtx.c | 338 +++

[dpdk-dev] [PATCH v4 28/58] net/txgbe: add device start operation

2020-10-19 Thread Jiawen Wu
Add device start operation with hardware start and reset. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_eeprom.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 346 ++ drivers/net/txgbe/base/txgbe_hw.h | 9 + drivers/net/txgbe/base/txgbe_type.h | 5

[dpdk-dev] [PATCH v4 30/58] net/txgbe: add device stop and close operations

2020-10-19 Thread Jiawen Wu
Add device stop, close and reset operations. And support hardware thermal sensor. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 69 ++ drivers/net/txgbe/base/txgbe_hw.h | 3 + drivers/net/txgbe/base/txgbe_type.h | 11 +++ drivers/net/txgbe/txgbe_ethdev.

[dpdk-dev] [PATCH v4 32/58] net/txgbe: add Rx and Tx queue info get

2020-10-19 Thread Jiawen Wu
Add Rx and Tx queue information get operation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 2 + drivers/net/txgbe/txgbe_ethdev.h | 6 +++ drivers/net/txgbe/txgbe_rxtx.c | 77 3 files changed, 85 insertions(+) diff --git a/drivers/net/txgb

[dpdk-dev] [PATCH v4 29/58] net/txgbe: add Rx and Tx data path start and stop

2020-10-19 Thread Jiawen Wu
Add receive and transmit data path start and stop. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 142 ++ drivers/net/txgbe/base/txgbe_hw.h | 5 ++ 2 files changed, 147 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/tx

[dpdk-dev] [PATCH v4 31/58] net/txgbe: support Rx interrupt

2020-10-19 Thread Jiawen Wu
Support rx queue interrupt. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 43 ++ 3 files changed, 45 insertions(+) diff --git a/doc/guides/nics/features/txgbe.in

[dpdk-dev] [PATCH v4 33/58] net/txgbe: add device stats get

2020-10-19 Thread Jiawen Wu
Add device stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_regs.h | 48 ++--- drivers/net/txgbe/base/txgbe_type.h | 155 drivers/net/tx

[dpdk-dev] [PATCH v4 34/58] net/txgbe: add device xstats get

2020-10-19 Thread Jiawen Wu
Add device extended stats get from reading hardware registers. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 378 + drivers/net/txgbe/txgbe_ethdev.h | 6 + 3 files changed, 385 insertions(+) diff --g

[dpdk-dev] [PATCH v4 38/58] net/txgbe: add PF module init and uninit for SRIOV

2020-10-19 Thread Jiawen Wu
Add PF module init and uninit operations with mailbox. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/meson.build | 1 + drivers/net/txgbe/base/txgbe.h | 1 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_mbx

[dpdk-dev] [PATCH v4 37/58] net/txgbe: add SWFW semaphore and lock

2020-10-19 Thread Jiawen Wu
Add semaphore between software and firmware. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 2 +- drivers/net/txgbe/base/txgbe_eeprom.h | 8 ++ drivers/net/txgbe/base/txgbe_hw.c | 129 ++ drivers/net/txgbe/base/txgbe_hw.h | 5 + drivers

[dpdk-dev] [PATCH v4 36/58] net/txgbe: add VLAN handle support

2020-10-19 Thread Jiawen Wu
Add VLAN filter, tpid, offload and strip set support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 3 +- drivers/net/txgbe/base/txgbe_hw.c | 31 +++ drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/base/txgbe_t

[dpdk-dev] [PATCH v4 35/58] net/txgbe: add queue stats mapping

2020-10-19 Thread Jiawen Wu
Add queue stats mapping set, and clear hardware counters. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 118 + drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 55

[dpdk-dev] [PATCH v4 39/58] net/txgbe: add process mailbox operation

2020-10-19 Thread Jiawen Wu
Add check operation for vf function level reset, mailbox messages and ack from vf. Waiting to process the messages. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 5 + drivers/net/txgbe/base/txgbe_mbx.c | 303 +++ drivers/net/txgbe/base/txgbe_mbx.h | 83 +++- dr

[dpdk-dev] [PATCH v4 41/58] net/txgbe: add VMDq configure

2020-10-19 Thread Jiawen Wu
Add multiple queue setting with VMDq. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 35 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_rxtx.c | 260 + 4 files changed, 298 i

[dpdk-dev] [PATCH v4 43/58] net/txgbe: add DCB support

2020-10-19 Thread Jiawen Wu
Add DCB transmit and receive mode configurations, and allocate DCB packet buffer. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini| 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/meson.build| 2 + drivers/net/txgbe/base/txgbe.h| 1

[dpdk-dev] [PATCH v4 46/58] net/txgbe: add priority flow control support

2020-10-19 Thread Jiawen Wu
Add priority flow control support. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dcb.c| 148 ++ drivers/net/txgbe/base/txgbe_dcb.h| 2 + drivers/net/txgbe/base/txgbe_dcb_hw.c | 73 + drivers/net/txgbe/txgbe_ethdev.c | 54 ++

[dpdk-dev] [PATCH v4 45/58] net/txgbe: add FC auto negotiation support

2020-10-19 Thread Jiawen Wu
Add flow control negotiation with link partner. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 200 ++ drivers/net/txgbe/base/txgbe_hw.h | 3 + 2 files changed, 203 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_hw.c b/drivers/net/txgbe/

[dpdk-dev] [PATCH v4 44/58] net/txgbe: add flow control support

2020-10-19 Thread Jiawen Wu
Add flow control support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/base/txgbe_hw.c | 425 drivers/net/txgbe/base/txgbe_hw.h | 6 + drivers/net/txgbe/base/txgbe_type.

[dpdk-dev] [PATCH v4 40/58] net/txgbe: add PF module configure for SRIOV

2020-10-19 Thread Jiawen Wu
Add PF module configure for SRIOV. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_hw.c | 345 drivers/net/txgbe/base/txgbe_hw.h | 12 + drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_e

[dpdk-dev] [PATCH v4 49/58] net/txgbe: add FW version get operation

2020-10-19 Thread Jiawen Wu
Add firmware version get operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 22 ++ 3 files changed, 24 insertions(+) diff --git a/doc/guides/nics/features/txgbe.in

[dpdk-dev] [PATCH v4 47/58] net/txgbe: add device promiscuous and allmulticast mode

2020-10-19 Thread Jiawen Wu
Add device promiscuous and allmulticast mode. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + doc/guides/nics/txgbe.rst | 2 + drivers/net/txgbe/txgbe_ethdev.c | 63 ++ 3 files changed, 67 insertions(+) diff --git a/doc/guides/nics

[dpdk-dev] [PATCH v4 48/58] net/txgbe: add MTU set operation

2020-10-19 Thread Jiawen Wu
Add MTU set operation. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 2 ++ drivers/net/txgbe/txgbe_ethdev.c| 41 + 3 files changed, 44 insertions(+) diff --git a/doc/guides/nics/features/txgbe.ini

[dpdk-dev] [PATCH v4 51/58] net/txgbe: add register dump support

2020-10-19 Thread Jiawen Wu
Add register dump support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 113 +++ drivers/net/txgbe/txgbe_regs_group.h | 54 + 4 files changed, 1

[dpdk-dev] [PATCH v4 50/58] net/txgbe: add EEPROM info get operation

2020-10-19 Thread Jiawen Wu
Add EEPROM information get related operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/base/txgbe_hw.c | 4 + drivers/net/txgbe/base/txgbe_phy.c | 16 drivers/net/txgbe/base/txgbe_phy.h | 3 + drivers/net/txgbe/txgbe_ethdev.c | 126

[dpdk-dev] [PATCH v4 52/58] net/txgbe: support device LED on and off

2020-10-19 Thread Jiawen Wu
Support device LED on and off. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 46 +++ drivers/net/txgbe/base/txgbe_hw.h | 3 ++ drivers/net/txgbe/txgbe_ethdev.c | 20 ++ 3 files changed, 69 insertions(+) diff --git a/drivers/net/txgbe/

[dpdk-dev] [PATCH v4 53/58] net/txgbe: add mirror rule operations

2020-10-19 Thread Jiawen Wu
Add mirror rule set and reset operations. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 186 + drivers/net/txgbe/txgbe_ethdev.h | 1 + 3 files changed, 188 insertions(+) diff --git a/doc/guides/nics/

[dpdk-dev] [PATCH v4 54/58] net/txgbe: add PTP support

2020-10-19 Thread Jiawen Wu
Add PTP support. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 234 + drivers/net/txgbe/txgbe_ethdev.h | 22 +++ drivers/net/txgbe/txgbe_rxtx.c | 32 +++

[dpdk-dev] [PATCH v4 56/58] net/txgbe: add Rx and Tx descriptor status

2020-10-19 Thread Jiawen Wu
Supports check the status of Rx and Tx descriptors. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 2 + drivers/net/txgbe/txgbe_ethdev.c | 4 + drivers/net/txgbe/txgbe_ethdev.h | 8 ++ drivers/net/txgbe/txgbe_rxtx.c | 180 + drivers/ne

[dpdk-dev] [PATCH v4 55/58] net/txgbe: add DCB info get operation

2020-10-19 Thread Jiawen Wu
Add DCB information get operation. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 91 1 file changed, 91 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index ddf92f1bd..77292f07f 100644 --- a/drive

[dpdk-dev] [PATCH v4 58/58] net/txgbe: introduce log type in the driver documentation

2020-10-19 Thread Jiawen Wu
Introduce available logging types, add txgbe PMD in release note. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst | 44 +- doc/guides/rel_notes/release_20_11.rst | 6 drivers/net/txgbe/txgbe_rxtx.c | 6 drivers/net/txgbe/txgbe_rxtx.

[dpdk-dev] [PATCH v4 57/58] net/txgbe: change stop operation callback to return int

2020-10-19 Thread Jiawen Wu
Change txgbe_dev_stop return value from void to int, refer to the changes in main repo. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_eth

[dpdk-dev] [PATCH v4 42/58] net/txgbe: add RSS support

2020-10-19 Thread Jiawen Wu
Add RSS configure, support to RSS hash and reta operations for PF. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 3 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/meson.build | 2 + drivers/net/txgbe/txgbe_ethdev.c | 102 ++ drivers/net

Re: [dpdk-dev] [PATCH] examples/tep_term: deprecate this example

2020-10-19 Thread Ferruh Yigit
On 10/19/2020 9:27 AM, Xiaoyun Li wrote: The tunnel cases this example wants to test can be covered by testpmd with rte_flow_create. And this example hasn't been used for a long time. So deprecate this example. Signed-off-by: Xiaoyun Li cc'ed techboard since it has a recurring task to remove

Re: [dpdk-dev] [PATCH] examples/tep_term: deprecate this example

2020-10-19 Thread Andrew Rybchenko
On 10/19/20 11:49 AM, Thomas Monjalon wrote: > 19/10/2020 10:27, Xiaoyun Li: >> The tunnel cases this example wants to test can be covered by testpmd >> with rte_flow_create. And this example hasn't been used for a long time. >> So deprecate this example. >> >> Signed-off-by: Xiaoyun Li > > Acked

[dpdk-dev] [PATCH] app/regex: change default qp configuration flags

2020-10-19 Thread guyk
From: Guy Kaneti added --cfg_oos argument to config queue pair out of order scan Signed-off-by: Guy Kaneti --- app/test-regex/main.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/app/test-regex/main.c b/app/test-regex/main.c index 0d35f4583..9b19

[dpdk-dev] [PATCH v1] app/regex: change default qp configuration flags

2020-10-19 Thread guyk
From: Guy Kaneti By default qp configuration flags was set with RTE_REGEX_QUEUE_PAIR_CFG_OOS_F. Changed flags default to 0. In order to set OOS flag use new argument --cfg_oos to config queue pair out of order scan. Signed-off-by: Guy Kaneti --- app/test-regex/main.c | 24 +

Re: [dpdk-dev] [PATCH] app/regex: change default qp configuration flags

2020-10-19 Thread Guy Kaneti
Please Ignore this patch, it was sent by mistake v1 is the correct one > -Original Message- > From: g...@marvell.com > Sent: Monday, October 19, 2020 12:26 PM > To: or...@mellanox.com > Cc: tho...@monjalon.net; Guy Kaneti ; Smadar Fuks > ; dev@dpdk.org > Subject: [PATCH] app/regex: change

Re: [dpdk-dev] [PATCH v2 01/11] ethdev: change eth dev stop function to return int

2020-10-19 Thread Kinsella, Ray
On 16/10/2020 18:13, Andrew Rybchenko wrote: > On 10/16/20 2:20 PM, Kinsella, Ray wrote: >> On 15/10/2020 14:30, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Change rte_eth_dev_stop() return value from void to int >>> and return negative errno values in case of error conditions. >>>

[dpdk-dev] [PATCH v2] drivers: remove mlx* glue libraries separate ABI version

2020-10-19 Thread David Marchand
The glue libraries are tightly bound to the mlx drivers of a dpdk version and are packaged with them. Keeping a separate ABI version prevents us from installing two versions of dpdk. Maintaining this separate version just adds confusion. Align the glue library ABI version to the global ABI version

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] vfio: fix partial DMA unmapping for VFIO type1

2020-10-19 Thread Nithin Dabilpuram
On Sat, Oct 17, 2020 at 05:14:55PM +0100, Burakov, Anatoly wrote: > On 16-Oct-20 8:10 AM, Nithin Dabilpuram wrote: > > On Thu, Oct 15, 2020 at 04:10:31PM +0100, Burakov, Anatoly wrote: > > > On 15-Oct-20 12:57 PM, Nithin Dabilpuram wrote: > > > > On Thu, Oct 15, 2020 at 3:31 PM Burakov, Anatoly > >

Re: [dpdk-dev] [PATCH v3 1/3] lib/hash: integrate RCU QSBR

2020-10-19 Thread Kinsella, Ray
On 16/10/2020 18:38, Dharmik Thakkar wrote: > Currently, users have to use external RCU mechanisms to free resources > when using lock free hash algorithm. > > Integrate RCU QSBR process to make it easier for the applications to use > lock free algorithm. > Refer to RCU documentation to unders

[dpdk-dev] [PATCH] crypto/caam_jr: fix caam sec era invalid issue

2020-10-19 Thread Gagandeep Singh
of_init() should be called before using any of_* APIs to retrieve information from the device tree and if reading integer value that must be converted to cpu endianness before using. Fixes: 1d678de329ab ("crypto/caam_jr: add basic job ring routines") Cc: sta...@dpdk.org Signed-off-by: Gagandeep S

Re: [dpdk-dev] [PATCH] ethdev: rename tunnel offload callbacks

2020-10-19 Thread Kinsella, Ray
On 19/10/2020 09:31, Ferruh Yigit wrote: > On 10/18/2020 1:15 PM, Gregory Etelson wrote: >> rename new rte_flow ops callbacks to emphasize relation to tunnel >> offload API. >> >> Signed-off-by: Gregory Etelson >> Acked-by: Ori Kam >> --- >>   lib/librte_ethdev/rte_flow.c    | 13 +++--

[dpdk-dev] [RFC] pthread on Windows

2020-10-19 Thread Nick Connolly
As part of the DPDK on Windows work, the following proposal has been put together and we would welcome community feedback. The heart of the issue is that, unlike Linux and FreeBSD, Windows does not claim to be POSIX conformant: some functionality is missing, some is present and some has differ

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-19 Thread Kinsella, Ray
On 17/10/2020 19:20, Timothy McDaniel wrote: > Adds the meson build infrastructure, which includes > compile-time constants in rte_config.h. DLB2 is > only supported on Linux X86 platforms at this time. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads > --- > config/rte_config.h

Re: [dpdk-dev] [PATCH v2 18/22] event/dlb2: add PMD's token pop public interface

2020-10-19 Thread Kinsella, Ray
On 17/10/2020 19:21, Timothy McDaniel wrote: > The PMD uses a public interface to allow applications to > control the token pop mode. Supported token pop modes are > as follows, and they impact core scheduling affinity for > ldb ports. > > AUTO_POP: Pop the CQ tokens immediately after dequeuein

Re: [dpdk-dev] [PATCH v11 1/8] eal/x86: introduce AVX 512-bit type

2020-10-19 Thread Medvedkin, Vladimir
Hi Ray, On 19/10/2020 07:35, Kinsella, Ray wrote: On 16/10/2020 16:42, Vladimir Medvedkin wrote: New data type to manipulate 512 bit AVX values. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev This patch has already been applied - need to drop it from the v12. You're ri

Re: [dpdk-dev] [PATCH v2] eal/interrupts: add function to allow interruptible epoll

2020-10-19 Thread Thomas Monjalon
04/09/2020 01:28, Stephen Hemminger: > The existing definition of rte_epoll_wait retries if interrupted > by a signal. This behavior makes it hard to use rte_epoll_wait > for applications that want to use signals do do things like > exit polling loop and shutdown. > > Since changing existing seman

[dpdk-dev] [PATCH v12 0/7] fib: implement AVX512 vector lookup

2020-10-19 Thread Vladimir Medvedkin
This patch series implements vectorized lookup using AVX512 for ipv4 dir24_8 and ipv6 trie algorithms. Also introduced rte_fib_set_lookup_fn() to change lookup function type. Added option to select lookup function type in testfib application. Depends-on: patch-81125 ("eal: add max SIMD bitwidth")

[dpdk-dev] [PATCH v12 1/7] fib: make lookup function type configurable

2020-10-19 Thread Vladimir Medvedkin
Add type argument to dir24_8_get_lookup_fn() Now it supports 3 different lookup implementations: RTE_FIB_DIR24_8_SCALAR_MACRO RTE_FIB_DIR24_8_SCALAR_INLINE RTE_FIB_DIR24_8_SCALAR_UNI Add new rte_fib_set_lookup_fn() - user can change lookup function type runtime. Signed-off-by: Vladimir Medvedk

[dpdk-dev] [PATCH v12 2/7] fib: move lookup definition into the header file

2020-10-19 Thread Vladimir Medvedkin
Move dir24_8 table layout and lookup definition into the private header file. This is necessary for implementing a vectorized lookup function in a separate .с file. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/dir24_8.c | 225 +---

[dpdk-dev] [PATCH v12 3/7] fib: introduce AVX512 lookup

2020-10-19 Thread Vladimir Medvedkin
Add new lookup implementation for DIR24_8 algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/guides/rel_notes/release_20_11.rst | 3 + lib/librte_fib/dir24_8.c | 38 lib/librte_fib/dir24_8_avx512.c| 165

[dpdk-dev] [PATCH v12 4/7] fib6: make lookup function type configurable

2020-10-19 Thread Vladimir Medvedkin
Add type argument to trie_get_lookup_fn() Now it only supports RTE_FIB6_TRIE_SCALAR Add new rte_fib6_set_lookup_fn() - user can change lookup function type runtime. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/rte_fib6.c | 20 +++- lib/

[dpdk-dev] [PATCH v12 5/7] fib6: move lookup definition into the header file

2020-10-19 Thread Vladimir Medvedkin
Move trie table layout and lookup definition into the private header file. This is necessary for implementing a vectorized lookup function in a separate .с file. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_fib/trie.c | 121 --

[dpdk-dev] [PATCH v12 6/7] fib6: introduce AVX512 lookup

2020-10-19 Thread Vladimir Medvedkin
Add new lookup implementation for FIB6 trie algorithm using AVX512 instruction set Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/guides/rel_notes/release_20_11.rst | 2 +- lib/librte_fib/meson.build | 17 +++ lib/librte_fib/rte_fib6.c | 2 +

  1   2   3   >