Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Andrew Rybchenko
On 10/12/20 3:22 PM, Andrew Rybchenko wrote: > On 10/12/20 2:30 PM, Nipun Gupta wrote: >>> -Original Message- >>> From: Andrew Rybchenko >>> Sent: Monday, October 12, 2020 1:32 PM >>> To: Nipun Gupta ; dev@dpdk.org >>> Cc: tho...@monjalon.net; ferruh.yi...@intel.com; arybche...@solarflare.

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Nipun Gupta
Hi Thomas and Jerin, There seems two views: 1. Use of existing rx_offload_capa, to have additional error packet drop offload capabilities. This is showcased in v2, and also suggested by Thomas. 2. Adding additional offload capability flag types and configuration structure for error packet drop c

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-13 Thread Hu, Jiayu
> -Original Message- > From: yang_y...@163.com > Sent: Saturday, October 10, 2020 11:10 AM > To: dev@dpdk.org > Cc: Hu, Jiayu ; mark.b.kavan...@intel.com; Ananyev, > Konstantin ; olivier.m...@6wind.com; > tho...@monjalon.net; yangy...@inspur.com; yang_y...@163.com > Subject: [PATCH] gso

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Nipun Gupta
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 13, 2020 12:52 PM > To: Nipun Gupta ; dev@dpdk.org > Cc: tho...@monjalon.net; ferruh.yi...@intel.com; Hemant Agrawal > ; Sachin Saxena ; Rohit > Raj ; jerinjac...@gmail.com; > step...@networkplumber.org; as...@nvidia.

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 10:36 AM, Nipun Gupta wrote: > > >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, October 13, 2020 12:52 PM >> To: Nipun Gupta ; dev@dpdk.org >> Cc: tho...@monjalon.net; ferruh.yi...@intel.com; Hemant Agrawal >> ; Sachin Saxena ; Rohit >> Raj ; jerinjac...@gm

Re: [dpdk-dev] [PATCH v2] net/ice: refactor RSS config for potential bugs

2020-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Tuesday, October 13, 2020 2:26 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [PATCH v2] net/ice: refactor RSS config for potential bugs Renamed to refactor RSS config wrap and fix pot

Re: [dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel

2020-10-13 Thread Nicolas Dichtel
Le 12/10/2020 à 21:28, Nick Connolly a écrit : > Running dpdk-helloworld on Linux with lib numa present, > but no kernel support for NUMA (CONFIG_NUMA=n) causes > ret_service_init() to fail with EAL: error allocating > rte services array. > > alloc_seg() calls get_mempolicy to verify that the allo

Re: [dpdk-dev] [PATCH v4] ethdev: check if queue setup in queue-related APIs

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 5:41 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > This patch adds checking whether the related Tx or Rx queue has been setup "This patch adds checking" -> "Add checking" > in the queue-related API functions to avoid illegal address access. And > validity check of the queue

Re: [dpdk-dev] [PATCH v5 02/11] ethdev: add IPv6 fragment extension header item

2020-10-13 Thread Dekel Peled
Yes, thanks. > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:50 PM > To: Dekel Peled > Cc: Ori Kam ; ferruh.yi...@intel.com; > arybche...@solarflare.com; konstantin.anan...@intel.com; > olivier.m...@6wind.com; wenzhuo...@intel.com; beilei.x...@intel.com;

Re: [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx offload to drop error packets

2020-10-13 Thread Nipun Gupta
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 13, 2020 1:21 PM > To: Nipun Gupta ; dev@dpdk.org > Cc: tho...@monjalon.net; ferruh.yi...@intel.com; Hemant Agrawal > ; Sachin Saxena ; Rohit > Raj ; jerinjac...@gmail.com; > step...@networkplumber.org; as...@nvidia.c

[dpdk-dev] [PATCH v2 03/10] net/mlx5: add the validate sample action

2020-10-13 Thread Jiawei Wang
Add sample action validate function. Sample Flow is supported in NIC-RX and FDB domains. For the NIC-RX the Sample Flow action list must include the destination queue action. Only NIC-RX domain supports the optional actions list. FDB doesn't support any optional actions, the sampled packets is al

[dpdk-dev] [PATCH v2 01/10] common/mlx5: glue for sample action

2020-10-13 Thread Jiawei Wang
The new DR sample action is supported since OFED version 5.1.2 or rdma-core version v32. MLX5 PMD adds the rdma-core command in glue to create this action. Sample action is used for creating the sample object to implement the sampling/mirroring function. Signed-off-by: Jiawei Wang Acked-by: Via

[dpdk-dev] [PATCH v2 07/10] net/mlx5: update validation for mirroring flow

2020-10-13 Thread Jiawei Wang
Mirroring flow using sample action with ratio is 1, and it doesn't support jump action with the same one flow. Sample action must have destination actions like port or queue for mirroring, and don't need split function as sampling flow. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko

[dpdk-dev] [PATCH v2 09/10] doc: add the sample flow limitation description

2020-10-13 Thread Jiawei Wang
Add description about the sample flow limitation. Sample Flow supports in NIC-Rx and E-Switch domains. Due to Metadata register c0 is deleted while doing the loopback, so that only support forward the sampling packet into E-Switch manager port, no additional action support in sample flow. Signed-o

[dpdk-dev] [PATCH v2 02/10] common/mlx5: query sampler object capability via DevX

2020-10-13 Thread Jiawei Wang
Update function mlx5_devx_cmd_query_hca_attr() to add the NIC Flow Table attributes query, then get the log_max_flow_sampler_num from flow table properties. Add the related structs definition in mlx5_prm.h. Signed-off-by: Jiawei Wang Acked-by: Ori Kam Acked-by: Viacheslav Ovsiienko --- driver

[dpdk-dev] [PATCH v2 08/10] net/mlx5: update translate function for mirror

2020-10-13 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list. PMD will check the destination action number in current flow, if found multiple destination actions, then create the new destination array rdma action that group actions for each destination. Currently only sup

[dpdk-dev] [PATCH v2 06/10] common/mlx5: add glue function for mirroring

2020-10-13 Thread Jiawei Wang
The new DR destination array action is supported since the rdma-core version v32. Destination array action is used group DR actions to a single action, And it can be used for mirroring packet and forward to every destination (port or queue) in the array. Signed-off-by: Jiawei Wang Acked-by: Viac

[dpdk-dev] [PATCH v2 00/10] Add sampling and mirroring support in MLX5 PMD

2020-10-13 Thread Jiawei Wang
This patch set implement the flow sampling and mirroring for mlx5 driver. MLX5 PMD driver will be responsible for validate and translate the sample action while creating a flow. Depends-on: series-12828 ("support the flow-based traffic sampling") v2: * Fix incorrect check for E-Switch sample spl

[dpdk-dev] [PATCH v2 10/10] doc: update offload dependencies document

2020-10-13 Thread Jiawei Wang
Add the offloads minimum versions for new sampling feature. Signed-off-by: Jiawei Wang Reviewed-by: Asaf Penso --- doc/guides/nics/mlx5.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 166310f..8d567e1 100644 --- a/doc/guides

[dpdk-dev] [PATCH v2 05/10] net/mlx5: update translate function for sample action

2020-10-13 Thread Jiawei Wang
Translate the attribute of sample action that include sample ratio and sub actions list, then create the sample DR action. The metadata register value will be lost in the default path after Sampler in FDB due to CX5 HW limitation. Since source vport also be shared with metadata register c0, MLX5

[dpdk-dev] [PATCH v2 04/10] net/mlx5: split sample flow into two sub flows

2020-10-13 Thread Jiawei Wang
The flow with sample action will be splited into two sub flows: the prefix sub flow with the all actions preceding the sample action and sample action itself, and the suffix sub flow with the actions following the sample action. The original items remain in the prefix sub flow, add the implicit ta

Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-13 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Thomas Monjalon > Sent: Monday, October 12, 2020 11:42 PM > To: Ori Kam ; Dekel Peled > Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; > konstantin.anan...@intel.com; olivier.m...@6wind.com; > wenzhuo...@intel.com; beilei.x...@intel.com;

[dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction

2020-10-13 Thread Jeff Guo
Enable metadata extraction for flexible descriptors in AVF, that would allow network function directly get metadata without additional parsing which would reduce the CPU cost for VFs. The enabling metadata extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, a

Re: [dpdk-dev] [PATCH v4] ethdev: check if queue setup in queue-related APIs

2020-10-13 Thread Kalesh Anakkur Purayil
Hi Xavier, Thanks for taking care of the comments. LGTM. Reviewed-by: Kalesh AP Regards, Kalesh On Tue, Oct 13, 2020 at 8:11 AM Wei Hu (Xavier) wrote: > From: Chengchang Tang > > This patch adds checking whether the related Tx or Rx queue has been setup > in the queue-related API functions

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 12:53 AM, Thomas Monjalon wrote: > 12/10/2020 18:46, Ferruh Yigit: >> Queue stats are stored in 'struct rte_eth_stats' as array and array size >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >> >> As a result of technical board discussion, decided to remove the queue >

Re: [dpdk-dev] [PATCH v3] pci/linux: copy new id for inserted device

2020-10-13 Thread Thomas Monjalon
13/10/2020 00:01, Jim Harris: > When a device is inserted into an existing BDF slot > that has not been probed, we must overwrite the old > PCI ID with the ID of the new function. Otherwise > we may not probe the function with the correct driver, > if at all. > > Signed-off-by: Jim Harris > --- >

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Andrew Rybchenko
On 10/6/20 1:57 PM, Thomas Monjalon wrote: > 06/10/2020 11:43, Ferruh Yigit: >> On 10/5/2020 6:08 PM, Thomas Monjalon wrote: >>> The API function rte_eth_dev_close() was returning void. >>> The return type is changed to int for notifying of errors. >>> >>> If an error happens during a close operati

[dpdk-dev] [PATCH v4] support both PIO and MMIO bar for virtio pci device

2020-10-13 Thread 谢华伟(此时此刻)
From: "huawei.xhw" v2 changes: - add more explanation in the commit message v3 changes: - fix patch format issues v4 changes: - fixes for RTE_KDRV_UIO_GENERIC -> RTE_PCI_KDRV_UIO_GENERIC huawei.xhw (1): pci: support both PIO and MMIO BAR for legacy virtio on x86

[dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-13 Thread 谢华伟(此时此刻)
From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device. We handles different type of BAR in the similar way.

Re: [dpdk-dev] [PATCH v3] net/hinic: fix secondary process's using coredump.

2020-10-13 Thread Ferruh Yigit
On 10/9/2020 8:47 AM, l00283554 wrote: fix coredump when secondary process using the hinic port. the reason is that during the stage of secondary process port initialization, it lack the initialization of "eth_dev->dev_ops". Signed-off-by: Qingqing Li --- v3: update the signed-off information.

Re: [dpdk-dev] [PATCH] net/af_xdp: Don't allow umem sharing for xsks with same netdev, qid

2020-10-13 Thread Ferruh Yigit
On 10/8/2020 10:17 AM, Ciara Loftus wrote: Supporting this would require locks, which would impact the performance of the more typical cases - xsks with different qids and netdevs. Signed-off-by: Ciara Loftus Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") Hi Ciara, 'check-git-log.sh

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: support query of AGE action

2020-10-13 Thread Andrew Rybchenko
On 10/7/20 4:28 PM, Dekel Peled wrote: > Existing API supports AGE action to monitor the aging of a flow. > This patch implements RFC [1], introducing the response format for query > of an AGE action. > Application will be able to query the AGE action state. > The response will be returned in the f

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Thomas Monjalon
13/10/2020 10:40, Andrew Rybchenko: > On 10/6/20 1:57 PM, Thomas Monjalon wrote: > > 06/10/2020 11:43, Ferruh Yigit: > >> On 10/5/2020 6:08 PM, Thomas Monjalon wrote: > >>> The API function rte_eth_dev_close() was returning void. > >>> The return type is changed to int for notifying of errors. > >>

Re: [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions

2020-10-13 Thread Ferruh Yigit
On 10/8/2020 8:28 AM, David Marchand wrote: On Wed, Sep 23, 2020 at 4:23 PM Radu Nicolau wrote: Implement 2 new functions that will enable write combining stores depending on architecture. The functions are provided as a generic stub and a x86 specific implementation. The reason to implement

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Thomas Monjalon
13/10/2020 10:31, Andrew Rybchenko: > On 10/13/20 12:53 AM, Thomas Monjalon wrote: > > 12/10/2020 18:46, Ferruh Yigit: > >> Queue stats are stored in 'struct rte_eth_stats' as array and array size > >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > >> > >> As a result of technical

Re: [dpdk-dev] [PATCH v5 1/2] net: add run-time architecture specific CRC selection

2020-10-13 Thread Bruce Richardson
On Fri, Oct 09, 2020 at 02:50:44PM +0100, Mairtin o Loingsigh wrote: > This patch adds support for run-time selection of the optimal > architecture-specific CRC path, based on the supported instruction set(s) > of the CPU. > > The compiler option checks have been moved from the C files to the meso

Re: [dpdk-dev] [PATCH] net/mlx5: add debug print of LRO minimal size

2020-10-13 Thread Matan Azrad
From: Dekel Peled > Add debug printout showing HCA capability lro_min_mss_size - the minimal > size of TCP segment required for coalescing. > MLX5 PMD documentation is updated to note this condition. > > Signed-off-by: Dekel Peled Acked-by: Matan Azrad

Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 12:05 PM, Thomas Monjalon wrote: > 13/10/2020 10:31, Andrew Rybchenko: >> On 10/13/20 12:53 AM, Thomas Monjalon wrote: >>> 12/10/2020 18:46, Ferruh Yigit: Queue stats are stored in 'struct rte_eth_stats' as array and array size is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compi

Re: [dpdk-dev] [PATCH v4 00/17] Replace terms master/slave

2020-10-13 Thread David Marchand
On Fri, Oct 9, 2020 at 11:56 PM Stephen Hemminger wrote: > There a some minor whitespace issues (from checkpatch) which will get fixed in > next version. Travis reported: https://travis-ci.com/github/ovsrobot/dpdk/builds/189130545 - pipeline example is broken, missed during rebase: ../examples/p

Re: [dpdk-dev] [PATCH v4 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 9:55 AM, Thomas Monjalon wrote: <...> dev = &rte_eth_devices[port_id]; - RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_close); - (*dev->dev_ops->dev_close)(dev); + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_close, -ENOTSUP); + *lasterr = (*dev->dev_ops->dev

Re: [dpdk-dev] [PATCH v2] mem: fix allocation failure on non-NUMA kernel

2020-10-13 Thread Burakov, Anatoly
On 12-Oct-20 8:22 PM, Nick Connolly wrote: Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocating rte services array. alloc_seg() calls get_mempolicy to verify that the allocation has hap

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-13 Thread Burakov, Anatoly
On 12-Oct-20 2:13 PM, Burakov, Anatoly wrote: On 12-Oct-20 1:50 PM, Ananyev, Konstantin wrote: Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not

[dpdk-dev] [PATCH v5 0/3] cleanup ethdev close operation

2020-10-13 Thread Thomas Monjalon
Most of the patches from the v3 have been merged already. The remaining 3 patches are reworked in this v4: - reset dev_started in some PMDs - selectively reset pointers in rte_eth_dev_release_port() - fix error handling v5: change error code to ENODEV if wrong port id Thomas Monjalon (3):

[dpdk-dev] [PATCH v5 1/3] ethdev: remove forcing stopped state upon close

2020-10-13 Thread Thomas Monjalon
When closing a port, it is supposed to be already stopped, and marked as such with "dev_started" state zeroed by the stop API. Resetting "dev_started" before calling the driver close operation was hiding the case of not properly stopped port being closed. The flag "dev_started" is not changed anym

[dpdk-dev] [PATCH v5 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Thomas Monjalon
The API function rte_eth_dev_close() was returning void. The return type is changed to int for notifying of errors. If an error happens during a close operation, the status of the port is undefined, a maximum of resources having been freed. Signed-off-by: Thomas Monjalon Reviewed-by: Liron Himi

[dpdk-dev] [PATCH v5 2/3] ethdev: reset all when releasing a port

2020-10-13 Thread Thomas Monjalon
The function rte_eth_dev_release_port() is partially resetting the struct rte_eth_dev. The drivers were completing this reset with more pointers set to NULL in the close or remove operations. More pointers are reset at ethdev level, and some redundant assignments are removed from PMDs. Signed-off

Re: [dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction

2020-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Tuesday, October 13, 2020 4:18 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei ; Yigit, Ferruh > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Jia > > Subject: [PATCH v8] net/iavf: support flex desc metadata extraction > > Enable metadata ex

[dpdk-dev] [PATCH v3 0/3] Add Marvell OCTEON TX2 regex driver

2020-10-13 Thread guyk
From: Guy Kaneti This patchset adds support for OCTEON TX2 regex driver as DPDK regexdev. The driver implements the API defined in the regexdev lib. v3: * Fix ML comments. v2: * Rebase. * Remove config/common_base from patch * change rte_cio_wmb to rte_io_wmb Guy Kaneti (3): common/octeontx

[dpdk-dev] [PATCH v3 2/3] regex/octeontx2: add build infra and device support

2020-10-13 Thread guyk
From: Guy Kaneti Add meson based build infrastructure along with the OTX2 regexdev (REE) device functions. Add Marvell OCTEON TX2 regex guide. Signed-off-by: Guy Kaneti --- MAINTAINERS |4 + doc/guides/platform/octeontx2.rst |5 + doc/guide

[dpdk-dev] [PATCH v3 3/3] usertools: add octeontx2 REE device binding

2020-10-13 Thread guyk
From: Guy Kaneti Update the devbind script with new section of regex devices, also added OCTEONTX2 REE device ID to regex device list Signed-off-by: Guy Kaneti --- doc/guides/regexdevs/octeontx2.rst | 11 +++ usertools/dpdk-devbind.py | 8 2 files changed, 19 inserti

[dpdk-dev] [PATCH v3 1/3] common/octeontx2: add REE definitions and logging support

2020-10-13 Thread guyk
From: Guy Kaneti Add REE mbox msg definitions, RVU and REE HW definitions Signed-off-by: Guy Kaneti --- drivers/common/octeontx2/hw/otx2_ree.h| 27 + drivers/common/octeontx2/hw/otx2_rvu.h| 5 + drivers/common/octeontx2/otx2_common.c| 1 + drivers/common/octeon

Re: [dpdk-dev] [PATCH v9 4/8] fib: introduce AVX512 lookup

2020-10-13 Thread Bruce Richardson
On Wed, Oct 07, 2020 at 05:10:38PM +0100, Vladimir Medvedkin wrote: > Add new lookup implementation for DIR24_8 algorithm using > AVX512 instruction set > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Ananyev > --- > doc/guides/rel_notes/release_20_11.rst | 3 + > lib/librte_fib/

Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: replace full barrier with relaxed barrier

2020-10-13 Thread Ferruh Yigit
On 10/2/2020 1:07 AM, Honnappa Nagarahalli wrote: From: Phil Yang While registering the call back functions full write barrier can be replaced with one-way write barrier. Signed-off-by: Phil Yang Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang +Konstantin & Jerin, Can you p

Re: [dpdk-dev] [PATCH 2/2] lib/ethdev: fix memory ordering for call back functions

2020-10-13 Thread Ferruh Yigit
On 10/2/2020 1:07 AM, Honnappa Nagarahalli wrote: Call back functions are registered on the control plane. They are accessed from the data plane. Hence, correct memory orderings should be used to avoid race conditions. Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") Fixes: c

[dpdk-dev] [PATCH v4 01/17] eal: add max SIMD bitwidth

2020-10-13 Thread Ciara Power
This patch adds a max SIMD bitwidth EAL configuration. The API allows for an app to set this value. It can also be set using EAL argument --force-max-simd-bitwidth, which will lock the value and override any modifications made by the app. Each arch has a define for the default SIMD bitwidth value,

[dpdk-dev] [PATCH v4 00/17] add max SIMD bitwidth to EAL

2020-10-13 Thread Ciara Power
A number of components in DPDK have optional AVX-512 or other vector code paths which can be selected at runtime. Rather than having each component provide its own mechanism to select a code path, this patchset adds support for a single setting to control what code paths are used. This can be used

[dpdk-dev] [PATCH v4 02/17] doc: add detail on using max SIMD bitwidth

2020-10-13 Thread Ciara Power
This patch adds documentation on the usage of the max SIMD bitwidth EAL setting, and how to use it to enable AVX-512 at runtime. Cc: Anatoly Burakov Cc: John McNamara Cc: Marko Kovacevic Signed-off-by: Ciara Power --- v4: Updated docs to reflect renamed enum. v3: - Added enum value for dis

[dpdk-dev] [PATCH v4 03/17] net/i40e: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Beilei Xing Cc: Jeff Guo Signed-off-by: Ciara Power Acked-by: Konstantin Ananyev --- v4: Updated enum names. --- drivers/net/i40e/i40e_rxtx.c | 18 +

[dpdk-dev] [PATCH v4 04/17] net/axgbe: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Somalapuram Amaranath Signed-off-by: Ciara Power Acked-by: Amaranath Somalapuram --- v4: Updated enum name. --- drivers/net/axgbe/axgbe_rxtx.c | 3 ++

[dpdk-dev] [PATCH v4 05/17] net/bnxt: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Ajit Khaparde Cc: Somnath Kotur Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/bnxt/bnxt_ethdev.c | 6 -- 1 file changed,

[dpdk-dev] [PATCH v4 06/17] net/enic: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: John Daley Cc: Hyong Youb Kim Acked-by: Hyong Youb Kim Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/enic/enic_rxtx_vec_avx2

[dpdk-dev] [PATCH v4 07/17] net/fm10k: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Qi Zhang Cc: Xiao Wang Signed-off-by: Ciara Power Acked-by: Qi Zhang --- v4: Updated enum name. --- drivers/net/fm10k/fm10k_ethdev.c | 11 --

[dpdk-dev] [PATCH v4 08/17] net/iavf: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Jingjing Wu Cc: Beilei Xing Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/iavf/iavf_rxtx.c | 16 ++-- 1 file chan

[dpdk-dev] [PATCH v4 09/17] net/ice: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Qiming Yang Cc: Qi Zhang Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/ice/ice_rxtx.c | 20 ++-- 1 file chang

[dpdk-dev] [PATCH v4 10/17] net/ixgbe: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Wei Zhao Cc: Jeff Guo Signed-off-by: Ciara Power Acked-by: Konstantin Ananyev --- v4: - Updated enum name. - Moved placement of condition check.

[dpdk-dev] [PATCH v4 11/17] net/mlx5: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Matan Azrad Cc: Shahaf Shuler Cc: Viacheslav Ovsiienko Signed-off-by: Ciara Power Acked-by: Viacheslav Ovsiienko --- v4: Updated enum name. v2: Move

[dpdk-dev] [PATCH v4 13/17] distributor: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: David Hunt Signed-off-by: Ciara Power Acked-by: David Hunt --- v4: Updated enum name. --- lib/librte_distributor/rte_distributor.c | 3 ++- 1 file ch

[dpdk-dev] [PATCH v4 12/17] net/virtio: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Maxime Coquelin Cc: Chenbo Xia Cc: Zhihong Wang Signed-off-by: Ciara Power --- v4: Updated enum name. v3: Moved max SIMD bitwidth check to configure

[dpdk-dev] [PATCH v4 16/17] net: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. The vector path was initially chosen in RTE_INIT, however this is no longer suitable as we cannot check the max SIMD bitwidth at that time. Default handlers ar

[dpdk-dev] [PATCH v4 14/17] member: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Yipeng Wang Cc: Sameh Gobriel Signed-off-by: Ciara Power Acked-by: Yipeng Wang --- v4: Updated enum name. --- lib/librte_member/rte_member_ht.c | 3

[dpdk-dev] [PATCH v4 15/17] efd: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Byron Marohn Cc: Yipeng Wang Signed-off-by: Ciara Power Acked-by: Yipeng Wang --- v4: Updated enum name. --- lib/librte_efd/rte_efd.c | 7 +-- 1

Re: [dpdk-dev] [PATCH v5 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Andrew Rybchenko
On 10/13/20 1:06 PM, Thomas Monjalon wrote: > The API function rte_eth_dev_close() was returning void. > The return type is changed to int for notifying of errors. > > If an error happens during a close operation, > the status of the port is undefined, > a maximum of resources having been freed. >

[dpdk-dev] [PATCH v4 17/17] node: choose vector path at runtime

2020-10-13 Thread Ciara Power
When choosing the vector path, max SIMD bitwidth is now checked to ensure the vector path is suitable. To do this, rather than the scalar/vector lookup functions being called directly from the apps, a generic function is called which will then call the scalar or vector lookup function. Cc: Nithin

Re: [dpdk-dev] [PATCH v5 3/3] ethdev: allow close function to return an error

2020-10-13 Thread Thomas Monjalon
13/10/2020 12:41, Andrew Rybchenko: > On 10/13/20 1:06 PM, Thomas Monjalon wrote: > > The API function rte_eth_dev_close() was returning void. > > The return type is changed to int for notifying of errors. > > > > If an error happens during a close operation, > > the status of the port is undefine

Re: [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pktsrequirements

2020-10-13 Thread Ferruh Yigit
On 9/14/2020 1:42 PM, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson Sent: Monday, September 14, 2020 1:27 PM On Mon, Sep 14, 2020 at 01:05:11PM +0200, Morten Brørup wrote: Updated description of rte_eth_rx_burst() to reflect what drivers, when using

[dpdk-dev] [PATCH v5 01/17] eal: add max SIMD bitwidth

2020-10-13 Thread Ciara Power
This patch adds a max SIMD bitwidth EAL configuration. The API allows for an app to set this value. It can also be set using EAL argument --force-max-simd-bitwidth, which will lock the value and override any modifications made by the app. Each arch has a define for the default SIMD bitwidth value,

[dpdk-dev] [PATCH v5 00/17] add max SIMD bitwidth to EAL

2020-10-13 Thread Ciara Power
A number of components in DPDK have optional AVX-512 or other vector code paths which can be selected at runtime. Rather than having each component provide its own mechanism to select a code path, this patchset adds support for a single setting to control what code paths are used. This can be used

[dpdk-dev] [PATCH v5 03/17] net/i40e: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Beilei Xing Cc: Jeff Guo Signed-off-by: Ciara Power Acked-by: Konstantin Ananyev --- v4: Updated enum names. --- drivers/net/i40e/i40e_rxtx.c | 18 +

[dpdk-dev] [PATCH v5 04/17] net/axgbe: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Somalapuram Amaranath Signed-off-by: Ciara Power Acked-by: Amaranath Somalapuram --- v4: Updated enum name. --- drivers/net/axgbe/axgbe_rxtx.c | 3 ++

[dpdk-dev] [PATCH v5 02/17] doc: add detail on using max SIMD bitwidth

2020-10-13 Thread Ciara Power
This patch adds documentation on the usage of the max SIMD bitwidth EAL setting, and how to use it to enable AVX-512 at runtime. Cc: Anatoly Burakov Cc: John McNamara Cc: Marko Kovacevic Signed-off-by: Ciara Power --- v4: Updated docs to reflect renamed enum. v3: - Added enum value for dis

[dpdk-dev] [PATCH v5 05/17] net/bnxt: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Ajit Khaparde Cc: Somnath Kotur Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/bnxt/bnxt_ethdev.c | 6 -- 1 file changed,

[dpdk-dev] [PATCH v5 06/17] net/enic: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: John Daley Cc: Hyong Youb Kim Acked-by: Hyong Youb Kim Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/enic/enic_rxtx_vec_avx2

[dpdk-dev] [PATCH v5 07/17] net/fm10k: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Qi Zhang Cc: Xiao Wang Signed-off-by: Ciara Power Acked-by: Qi Zhang --- v4: Updated enum name. --- drivers/net/fm10k/fm10k_ethdev.c | 11 --

[dpdk-dev] [PATCH v5 08/17] net/iavf: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Jingjing Wu Cc: Beilei Xing Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/iavf/iavf_rxtx.c | 16 ++-- 1 file chan

[dpdk-dev] [PATCH v5 09/17] net/ice: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Qiming Yang Cc: Qi Zhang Signed-off-by: Ciara Power --- v4: Updated enum name. --- drivers/net/ice/ice_rxtx.c | 20 ++-- 1 file chang

[dpdk-dev] [PATCH v5 11/17] net/mlx5: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Matan Azrad Cc: Shahaf Shuler Cc: Viacheslav Ovsiienko Signed-off-by: Ciara Power Acked-by: Viacheslav Ovsiienko --- v4: Updated enum name. v2: Move

[dpdk-dev] [PATCH v5 10/17] net/ixgbe: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Wei Zhao Cc: Jeff Guo Signed-off-by: Ciara Power Acked-by: Konstantin Ananyev --- v4: - Updated enum name. - Moved placement of condition check.

[dpdk-dev] [PATCH v5 13/17] distributor: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: David Hunt Signed-off-by: Ciara Power Acked-by: David Hunt --- v4: Updated enum name. --- lib/librte_distributor/rte_distributor.c | 3 ++- 1 file ch

[dpdk-dev] [PATCH v5 12/17] net/virtio: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Maxime Coquelin Cc: Chenbo Xia Cc: Zhihong Wang Signed-off-by: Ciara Power --- v4: Updated enum name. v3: Moved max SIMD bitwidth check to configure

[dpdk-dev] [PATCH v5 14/17] member: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Yipeng Wang Cc: Sameh Gobriel Signed-off-by: Ciara Power Acked-by: Yipeng Wang --- v4: Updated enum name. --- lib/librte_member/rte_member_ht.c | 3

[dpdk-dev] [PATCH v5 15/17] efd: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. Cc: Byron Marohn Cc: Yipeng Wang Signed-off-by: Ciara Power Acked-by: Yipeng Wang --- v4: Updated enum name. --- lib/librte_efd/rte_efd.c | 7 +-- 1

[dpdk-dev] [PATCH v5 16/17] net: add checks for max SIMD bitwidth

2020-10-13 Thread Ciara Power
When choosing a vector path to take, an extra condition must be satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. The vector path was initially chosen in RTE_INIT, however this is no longer suitable as we cannot check the max SIMD bitwidth at that time. Default handlers ar

[dpdk-dev] [PATCH v5 17/17] node: choose vector path at runtime

2020-10-13 Thread Ciara Power
When choosing the vector path, max SIMD bitwidth is now checked to ensure the vector path is suitable. To do this, rather than the scalar/vector lookup functions being called directly from the apps, a generic function is called which will then call the scalar or vector lookup function. Cc: Nithin

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: support query of AGE action

2020-10-13 Thread Ferruh Yigit
On 10/13/2020 9:53 AM, Andrew Rybchenko wrote: On 10/7/20 4:28 PM, Dekel Peled wrote: Existing API supports AGE action to monitor the aging of a flow. This patch implements RFC [1], introducing the response format for query of an AGE action. Application will be able to query the AGE action state

Re: [dpdk-dev] [PATCH v5 10/17] net/ixgbe: add checks for max SIMD bitwidth

2020-10-13 Thread Wang, Haiyue
> -Original Message- > From: Power, Ciara > Sent: Tuesday, October 13, 2020 19:05 > To: dev@dpdk.org > Cc: vikto...@rehivetech.com; ruifeng.w...@arm.com; jer...@marvell.com; > d...@linux.vnet.ibm.com; > Richardson, Bruce ; Ananyev, Konstantin > ; > Power, Ciara ; Zhao1, Wei ; Guo, > Jia

Re: [dpdk-dev] [PATCH v3 17/18] net: add checks for max SIMD bitwidth

2020-10-13 Thread Power, Ciara
Hi Konstantin, >-Original Message- >From: Ananyev, Konstantin >Sent: Thursday 8 October 2020 15:55 >To: Olivier Matz ; Power, Ciara > >Cc: Coyle, David ; Singh, Jasvinder >; dev@dpdk.org; O'loingsigh, Mairtin >; Ryan, Brendan ; >Richardson, Bruce >Subject: RE: [dpdk-dev] [PATCH v3 17/18

Re: [dpdk-dev] [PATCH v5 16/17] net: add checks for max SIMD bitwidth

2020-10-13 Thread Olivier Matz
Hi Ciara, On Tue, Oct 13, 2020 at 12:04:36PM +0100, Ciara Power wrote: > When choosing a vector path to take, an extra condition must be > satisfied to ensure the max SIMD bitwidth allows for the CPU enabled > path. > > The vector path was initially chosen in RTE_INIT, however this is no > longer

Re: [dpdk-dev] [RFC v2 1/1] lib/ring: add scatter gather APIs

2020-10-13 Thread Ananyev, Konstantin
Hi Honnappa, > Hi Konstantin, > Appreciate your feedback. > > > > > > > > > > Add scatter gather APIs to avoid intermediate memcpy. Use cases that > > > involve copying large amount of data to/from the ring can benefit from > > > these APIs. > > > > > > Signed-off-by: Honnappa Nagarahal

[dpdk-dev] [PATCH v2 1/1] crypto/bcmfs: optimize crypto request processing

2020-10-13 Thread Vikas Gupta
Reduce number of source BDs to submit a request to crypto engine. This improves the performance as crypto engine fetches all the BDs in single cycle. Adjust optional metadata (OMD) in continuation of fixed meta data (FMD). Signed-off-by: Vikas Gupta Signed-off-by: Raveendra Padasalagi Reviewed-b

[dpdk-dev] [PATCH v2 0/1] optimization for crypto request processing

2020-10-13 Thread Vikas Gupta
Hi, This patch optimizes for crypto request processing in crypto engine by reducing the number of source BDs for Broadcom FlexSparc device. The patch has been tested on FlexSparc device. Regards, Vikas Changes from: v1->v2 Rebase the patch with latest dpdk-next-crypto Vikas Gupta (1)

  1   2   3   4   >