On 10/7/20 4:28 PM, Dekel Peled wrote:
> Existing API supports AGE action to monitor the aging of a flow.
> This patch implements RFC [1], introducing the response format for query
> of an AGE action.
> Application will be able to query the AGE action state.
> The response will be returned in the format implemented here.
>
> [1] https://mails.dpdk.org/archives/dev/2020-September/180061.html
>
> Signed-off-by: Dekel Peled <dek...@nvidia.com>
> Acked-by: Matan Azrad <ma...@nvidia.com>
with a nit below:
Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
> ---
> doc/guides/prog_guide/rte_flow.rst | 17 +++++++++++++++++
> doc/guides/rel_notes/release_20_11.rst | 3 +++
> lib/librte_ethdev/rte_flow.h | 15 +++++++++++++++
> 3 files changed, 35 insertions(+)
>
> diff --git a/doc/guides/prog_guide/rte_flow.rst
> b/doc/guides/prog_guide/rte_flow.rst
> index 119b128..a672fc5 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -2666,6 +2666,23 @@ timeout passed without any matching on the flow.
> | ``context`` | user input flow context |
> +--------------+---------------------------------+
>
> +Query structure to retrieve ageing status information of a
> +shared AGE action, or a flow rule using the AGE action:
> +
> +.. _table_rte_flow_query_age:
> +
> +.. table:: AGE query
> +
> +
> +------------------------------+-----+----------------------------------------+
> + | Field | I/O | Value
> |
> +
> +==============================+=====+========================================+
> + | ``aged`` | out | Aging timeout expired
> |
> +
> +------------------------------+-----+----------------------------------------+
> + | ``sec_since_last_hit_valid`` | out | ``sec_since_last_hit`` value is
> valid |
> +
> +------------------------------+-----+----------------------------------------+
> + | ``sec_since_last_hit`` | out | Seconds since last traffic hit
> |
> +
> +------------------------------+-----+----------------------------------------+
> +
> Negative types
> ~~~~~~~~~~~~~~
>
> diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> index 0b2a370..7e093f7 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -191,6 +191,9 @@ API Changes
>
> * ethdev: ``rte_eth_rx_descriptor_done()`` API has been deprecated.
>
> +* ethdev: Added struct ``rte_flow_query_age`` for use in response to query
> + of AGE action.
> +
IMO it too deep technical details for release notes advertising
new feature. What about:
Added possibility to query AGE action state.
> * Renamed internal ethdev APIs:
>
> * ``_rte_eth_dev_callback_process()`` -> ``rte_eth_dev_callback_process()``
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index da8bfa5..42a315a 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -2130,6 +2130,7 @@ enum rte_flow_action_type {
> * See struct rte_flow_action_age.
> * See function rte_flow_get_aged_flows
> * see enum RTE_ETH_EVENT_FLOW_AGED
> + * See struct rte_flow_query_age
> */
> RTE_FLOW_ACTION_TYPE_AGE,
> };
> @@ -2194,6 +2195,20 @@ struct rte_flow_action_age {
> };
>
> /**
> + * RTE_FLOW_ACTION_TYPE_AGE (query)
> + *
> + * Query structure to retrieve the aging status information of a
> + * shared AGE action, or a flow rule using the AGE action.
> + */
> +struct rte_flow_query_age {
> + uint32_t reserved:6; /**< Reserved, must be zero. */
> + uint32_t aged:1; /**< 1 if aging timeout expired, 0 otherwise. */
> + uint32_t sec_since_last_hit_valid:1;
> + /**< sec_since_last_hit value is valid. */
> + uint32_t sec_since_last_hit:24; /**< Seconds since last traffic hit. */
> +};
> +
> +/**
> * @warning
> * @b EXPERIMENTAL: this structure may change without prior notice
> *
>
