On 10/13/20 12:05 PM, Thomas Monjalon wrote: > 13/10/2020 10:31, Andrew Rybchenko: >> On 10/13/20 12:53 AM, Thomas Monjalon wrote: >>> 12/10/2020 18:46, Ferruh Yigit: >>>> Queue stats are stored in 'struct rte_eth_stats' as array and array size >>>> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >>>> >>>> As a result of technical board discussion, decided to remove the queue >>>> statistics from 'struct rte_eth_stats' in the long term. >>>> >>>> Instead PMDs should represent the queue statistics via xstats, this >>>> gives more flexibility on the number of the queues supported. >>> >>> Yes >> >> I like Stephen's idea to have dedicated API to get stats per >> queue. Of course it is doable via getting xstats by IDs, >> but IMHO it is over-complicated. From the other hand >> it sounds like a duplication to have it in xstats and >> dedicated API (basically the same as we have for basic >> stats and xstats). > > Please read my proposal to have fixed ids for common stats > and fixed id ranges for stats per queue: > https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf > (slide 11) >
Ah, yes, I forgot that point. Makes sense and LGTM.
