Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-14 Thread yang_y_yi
Thanks Jiayu, will change them per your comments. For doument part, is such change ok? diff --git a/doc/guides/prog_guide/generic_receive_offload_lib.rst b/doc/guides/prog index 5b3fb91..98a5d29 100644 --- a/doc/guides/prog_guide/generic_receive_offload_lib.rst +++ b/doc/guides/prog_guide

Re: [dpdk-dev] [PATCH v3 0/4] abi breakage checks for meson

2020-09-14 Thread Thomas Monjalon
Hi, > This patchset allows developers to check ABI breakages during build > time. > Currently checking that the DPDK ABI has not changed before up-streaming > code is not intuitive. The current method, requires the contributor to > use either the test-build.sh and test-meson-build.sh tools, along

Re: [dpdk-dev] [PATCH v2 1/2] rte_log: take experimental tag off of rte_log_get_stream

2020-09-14 Thread David Marchand
On Fri, Sep 4, 2020 at 1:05 AM Stephen Hemminger wrote: > > Applications will need to use this API now to get internal > state of rte_log. > > Suggested-by: David Marchand > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/include/rte_log.h | 1 - > lib/librte_eal/rte_eal_version.map |

Re: [dpdk-dev] [PATCH] eal: add new prefetch0_write variant

2020-09-14 Thread Van Haaren, Harry
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Sunday, September 13, 2020 9:11 PM > To: Van Haaren, Harry ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] eal: add new prefetch0_write variant > > >This commit adds a new rte_prefetch0_write() variant, suggests to the > >c

Re: [dpdk-dev] [PATCH v2 2/2] rte_log: make rte_logs private

2020-09-14 Thread David Marchand
On Fri, Sep 4, 2020 at 1:05 AM Stephen Hemminger wrote: > > As announced in earlier releases, rte_logs can now be made > internal to eal_common_log. > > Acked-by: Andrew Rybchenko > Signed-off-by: Stephen Hemminger Same comment as before, the rte_log_dynamic_type struct fwd declaration can be r

[dpdk-dev] [PATCH 1/5] bus/pci: switch to private kernel driver enum

2020-09-14 Thread David Marchand
The rte_kernel_driver enum actually only pointed at PCI drivers and is only used in the PCI subsystem. Remove it from the generic device API and use a private enum in the PCI code. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst| 4 -- doc/guides/rel_notes/release_20_

[dpdk-dev] [PATCH 0/5] 20.11 announced cleanups

2020-09-14 Thread David Marchand
I put those EAL and PCI cleanups as a single series since I intend to apply them at once with the rte_logs series. Nothing really hard in this series, but the devil is in the details, reviews welcome. -- David Marchand David Marchand (5): bus/pci: switch to private kernel driver enum pci:

[dpdk-dev] [PATCH 2/5] pci: move resource mapping to the PCI bus

2020-09-14 Thread David Marchand
As reported during 20.08 work for Windows, the pci_map_resource API was built with the assumption that its flags would be passed to mmap(). This introduced a regression when adding the rte_mem_map API as reported in the workaround commit 9d2b24593724 ("pci: keep API compatibility with mmap values"

[dpdk-dev] [PATCH 4/5] eal: hide internal device event structure

2020-09-14 Thread David Marchand
This structure is not used in the public API. Fixes: a753e53d517b ("eal: add device event monitor framework") Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_20_11.rst | 3 +++ lib/librte_eal/include/rte_dev.h | 6 -- lib/

[dpdk-dev] [PATCH 5/5] bus/pci: remove duplicate declaration

2020-09-14 Thread David Marchand
This declaration is the same as the one a few lines before. Fixes: 6844d146ff39 ("eal: add bus pointer in device structure") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/bus/pci/private.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/bus/pci/private.h b/drivers/b

[dpdk-dev] [PATCH 3/5] mem: drop mapping API workaround

2020-09-14 Thread David Marchand
Now that the pci_map_resource API is private to the PCI bus, we can drop the compatibility workaround we had implemented in 20.08. Signed-off-by: David Marchand --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c | 2 +- drivers/bus/pci/linux/pci_vfio.c

[dpdk-dev] [PATCH v2 0/6] 20.11 announced cleanups

2020-09-14 Thread David Marchand
I put those EAL and PCI cleanups as a single series since I intend to apply them at once with the rte_logs series. Nothing really hard in this series, but the devil is in the details, reviews welcome. -- David Marchand Changelog since v1: - added missing first patch, I suspect this will be a l

[dpdk-dev] [PATCH v2 1/6] ethdev: remove unused kernel driver field

2020-09-14 Thread David Marchand
This field was not generic as it was filled with PCI kernel drivers only. It has no known in-tree user (and I could not find opensource projects using it). Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_20_11.rst | 3 +++ drivers/ne

[dpdk-dev] [PATCH v2 5/6] eal: hide internal device event structure

2020-09-14 Thread David Marchand
This structure is not used in the public API. Fixes: a753e53d517b ("eal: add device event monitor framework") Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_20_11.rst | 3 +++ lib/librte_eal/include/rte_dev.h | 6 -- lib/

[dpdk-dev] [PATCH v2 3/6] pci: move resource mapping to the PCI bus

2020-09-14 Thread David Marchand
As reported during 20.08 work for Windows, the pci_map_resource API was built with the assumption that its flags would be passed to mmap(). This introduced a regression when adding the rte_mem_map API as reported in the workaround commit 9d2b24593724 ("pci: keep API compatibility with mmap values"

[dpdk-dev] [PATCH v2 4/6] mem: drop mapping API workaround

2020-09-14 Thread David Marchand
Now that the pci_map_resource API is private to the PCI bus, we can drop the compatibility workaround we had implemented in 20.08. Signed-off-by: David Marchand --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c | 2 +- drivers/bus/pci/linux/pci_vfio.c

[dpdk-dev] [PATCH v2 2/6] bus/pci: switch to private kernel driver enum

2020-09-14 Thread David Marchand
The rte_kernel_driver enum actually only pointed at PCI drivers and is only used in the PCI subsystem. Remove it from the generic device API and use a private enum in the PCI code. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst| 4 -- doc/guides/rel_notes/release_20_

[dpdk-dev] [PATCH v2 6/6] bus/pci: remove duplicate declaration

2020-09-14 Thread David Marchand
This declaration is the same as the one a few lines before. Fixes: 6844d146ff39 ("eal: add bus pointer in device structure") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/bus/pci/private.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/bus/pci/private.h b/drivers/b

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-14 Thread yang_y_yi
For outer_ip_id, there is same ip_id disorder issue existing as UDP GRO, so we can't use ip_id +/-1 to check if they are same flow, here is my incrmental change for it with more comments. @@ -189,7 +188,12 @@ is_same_vxlan_udp4_flow(struct vxlan_udp4_flow_key k1, struct vxla

Re: [dpdk-dev] [PATCH v3 0/4] abi breakage checks for meson

2020-09-14 Thread Kinsella, Ray
Predictably perhaps, I disagree. On 14/09/2020 09:08, Thomas Monjalon wrote: > Hi, > >> This patchset allows developers to check ABI breakages during build >> time. >> Currently checking that the DPDK ABI has not changed before up-streaming >> code is not intuitive. The current method, requires t

Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded

2020-09-14 Thread Bruce Richardson
On Mon, Sep 14, 2020 at 08:18:14AM +0100, Yang, SteveX wrote: > Hi Bruce, > > Do you mean I can provide a patch set which includes following two commit > fixes: > 1. For 20.11, add 'pmd_bond' to deps, and change the old macro to > RTE_LIBRTE_BOND_PMD; > 2. For backporting version, add 'pmd_bond'

Re: [dpdk-dev] [PATCH v1] app/test-pmd: fix meson build failed when used latency stats lib

2020-09-14 Thread Bruce Richardson
On Mon, Sep 14, 2020 at 09:00:19AM +0100, Yang, SteveX wrote: > Hi Bruce, > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, September 10, 2020 5:24 PM > > To: Yang, SteveX > > Cc: dev@dpdk.org; Lu, Wenzhuo ; Xing, Beilei > > ; Yang, Qiming > > Subject: Re: [dpdk-de

Re: [dpdk-dev] [PATCH v5 2/2] test/service: fix race condition on stopping lcore

2020-09-14 Thread David Marchand
On Fri, Jul 24, 2020 at 3:44 PM Harry van Haaren wrote: > > This commit fixes a potential race condition in the tests > where the lcore running a service would increment a counter > that was already reset by the test-suite thread. The resulting > race-condition incremented value could cause CI fai

Re: [dpdk-dev] [PATCH 1/2] service: add component useful work attribute

2020-09-14 Thread David Marchand
On Mon, Sep 7, 2020 at 6:20 PM Harry van Haaren wrote: > diff --git a/lib/librte_eal/include/rte_service_component.h > b/lib/librte_eal/include/rte_service_component.h > index 9e66ee7e29..2caa7981b5 100644 > --- a/lib/librte_eal/include/rte_service_component.h > +++ b/lib/librte_eal/include/rte_s

Re: [dpdk-dev] [PATCH 01/15] eal: add macro to mark macros as deprecated

2020-09-14 Thread Bruce Richardson
On Fri, Sep 11, 2020 at 12:06:47PM -0700, Stephen Hemminger wrote: > Add a macro that causes GCC and CLANG to emit a warning when > a deprecated macro is used. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/include/rte_common.h | 11 +++ > 1 file changed, 11 insertions(+) >

Re: [dpdk-dev] [PATCH 0/2] remove mbuf deprecated filed

2020-09-14 Thread Thomas Monjalon
11/09/2020 12:57, Phil Yang: > Andrew Rybchenko writes: > > > > On 9/11/20 10:35 AM, Phil Yang wrote: > > > Remove the deprecated[1] refcnt_atomic member in structures rte_mbuf > > and > > > rte_mbuf_ext_shared_info. > > > > > > [1] > > http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_note

Re: [dpdk-dev] [PATCH v2] app/test-pmd: fix meson build failed when enabled pmd_bonded

2020-09-14 Thread David Marchand
On Fri, Sep 11, 2020 at 4:45 PM Bruce Richardson wrote: > I don't particularly like keeping the old defines around, since they are > inconsistent in naming, but since we didn't announce a deprecation of the > old values perhaps we should add them in. I don't like keeping those either, but we did

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-14 Thread Hu, Jiayu
Out IP ID is not used to check if they belong to the same flow, but check if they are neighbors. If two vxlan/udp fragments are neighbors, their outer IP ID and outer frag_oft should be incremental. I still cannot understand why ignore outer IP ID when DF is 0. Can you give more explanation? From:

Re: [dpdk-dev] [PATCH 13/20] net/ring: release port upon close

2020-09-14 Thread Bruce Richardson
On Mon, Sep 14, 2020 at 12:07:04AM +0200, Thomas Monjalon wrote: > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > can be freed by rte_eth_dev_close(). > > Freeing of private port resources is moved > from the ".remove(device)" to the ".dev_close(port)" operation. > > Signed-off-

Re: [dpdk-dev] [PATCH v2] eal/interrupts: add function to allow interruptible epoll

2020-09-14 Thread David Marchand
On Fri, Sep 4, 2020 at 1:28 AM Stephen Hemminger wrote: > > The existing definition of rte_epoll_wait retries if interrupted > by a signal. This behavior makes it hard to use rte_epoll_wait > for applications that want to use signals do do things like > exit polling loop and shutdown. > > Since ch

[dpdk-dev] [PATCH v5] net/iavf: support outer IP hash for no inner GTPU

2020-09-14 Thread alvinx . zhang
From: Alvin Zhang Outer IP hash can be configured as input sets for no inner GTPU packets. Signed-off-by: Alvin Zhang --- V2: Modify codes according to comments. V3: Refact all codes. V4: Fix compatibility issues. V5: Modify codes according to comments. drivers/net/iavf/iavf_hash.c | 48

Re: [dpdk-dev] [PATCH v5 2/2] gro: add VXLAN UDP GRO support

2020-09-14 Thread yang_y_yi
Jiayu, VM to VM case for big UDP packet (say udp parload size is 8192K, but mtu 1500). VM will segment it as UDP framgments, but when ovs dpdk uses VxLan to encapsulate them, it doesn't know they are same flow, OVS DPDK has no knowldge about them, just encapsulate them as if they are not rela

[dpdk-dev] [PATCH v5] net/iavf: support outer IP hash for GTPC

2020-09-14 Thread alvinx . zhang
From: Alvin Zhang Add patterns and headers for GTPC, now outer IP hash can be configured as input sets for GTPC packets. Signed-off-by: Alvin Zhang --- V2: Modify codes according to comments. V3: Refact all codes. V4, V5: Fix compatibility issues. drivers/net/iavf/iavf_generic_flow.c | 18 ++

Re: [dpdk-dev] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp

2020-09-14 Thread David Marchand
On Mon, Sep 14, 2020 at 6:38 AM Honnappa Nagarahalli wrote: > > > > > > > When using memcmp function to check data, the third param should be the > > size of all elements, rather than the number of the elements. > > > > Furthermore, do code clean up by moving repeated code inside > > 'test_ring_m

Re: [dpdk-dev] [PATCH v3 0/4] abi breakage checks for meson

2020-09-14 Thread Kinsella, Ray
(apologies for re-sending, I missed the CC list the 1st time). Predictably perhaps, I disagree. On 14/09/2020 09:08, Thomas Monjalon wrote: > Hi, > >> This patchset allows developers to check ABI breakages during build >> time. >> Currently checking that the DPDK ABI has not changed before up-s

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2020-09-14 Thread Rahul Lakkireddy
On Monday, September 09/14/20, 2020 at 00:16:17 +0200, Thomas Monjalon wrote: > The patches for removing RTE_ETH_DEV_CLOSE_REMOVE are sent: > https://patches.dpdk.org/project/dpdk/list/?series=12173 > > 11 drivers are not supporting the new behaviour correctly: > bnx2x, cxgbe, dpaa, dp

Re: [dpdk-dev] [PATCH v2] kernel: remove igb_uio

2020-09-14 Thread Ferruh Yigit
On 9/12/2020 9:55 AM, Thomas Monjalon wrote: > 11/09/2020 18:22, Ferruh Yigit: >> On 9/11/2020 4:54 PM, Thomas Monjalon wrote: >>> As decided in the Technical Board in November 2019, >>> the kernel module igb_uio is moved to the dpdk-kmods repository >>> in the /linux/igb_uio/ directory. >>> >>> Mi

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: remove unused kernel driver field

2020-09-14 Thread Andrew Rybchenko
On 9/14/20 11:23 AM, David Marchand wrote: > This field was not generic as it was filled with PCI kernel drivers only. > It has no known in-tree user (and I could not find opensource projects > using it). > > Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 2/6] bus/pci: switch to private kernel driver enum

2020-09-14 Thread Andrew Rybchenko
On 9/14/20 11:23 AM, David Marchand wrote: > The rte_kernel_driver enum actually only pointed at PCI drivers and is > only used in the PCI subsystem. > Remove it from the generic device API and use a private enum in the PCI > code. > > Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 3/6] pci: move resource mapping to the PCI bus

2020-09-14 Thread Andrew Rybchenko
On 9/14/20 11:23 AM, David Marchand wrote: > As reported during 20.08 work for Windows, the pci_map_resource API was > built with the assumption that its flags would be passed to mmap(). > > This introduced a regression when adding the rte_mem_map API as reported > in the workaround commit 9d2b245

Re: [dpdk-dev] [PATCH v2 4/6] mem: drop mapping API workaround

2020-09-14 Thread Andrew Rybchenko
On 9/14/20 11:23 AM, David Marchand wrote: > Now that the pci_map_resource API is private to the PCI bus, we can drop > the compatibility workaround we had implemented in 20.08. > > Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 6/6] bus/pci: remove duplicate declaration

2020-09-14 Thread Andrew Rybchenko
On 9/14/20 11:23 AM, David Marchand wrote: > This declaration is the same as the one a few lines before. > > Fixes: 6844d146ff39 ("eal: add bus pointer in device structure") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v5] net/iavf: support outer IP hash for no inner GTPU

2020-09-14 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Monday, September 14, 2020 5:03 PM > To: Guo, Jia ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v5] net/iavf: support outer IP hash for no inner GTPU > > From: Alvin Zhang > > Outer IP hash can be configured as

Re: [dpdk-dev] [PATCH] eal: add new prefetch0_write variant

2020-09-14 Thread Pavan Nikhilesh Bhagavatula
>> >This commit adds a new rte_prefetch0_write() variant, suggests to >the >> >compiler to use a prefetch instruction with intention to write. As a >> >compiler builtin, the compiler can choose based on compilation >target >> >what the best implementation for this instruction is. >> >> Why not have

Re: [dpdk-dev] [PATCH v5] net/iavf: support outer IP hash for GTPC

2020-09-14 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Monday, September 14, 2020 5:12 PM > To: Guo, Jia ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v5] net/iavf: support outer IP hash for GTPC > > From: Alvin Zhang > > Add patterns and headers for GTPC, now outer

Re: [dpdk-dev] [PATCH v2 2/8] bus/fslmc: run secondary debug app without blocklist devices

2020-09-14 Thread Hemant Agrawal
Hi, > -Original Message- > From: Sachin Saxena (OSS) > Sent: Friday, September 11, 2020 2:05 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Cc: Sachin Saxena (OSS) > Subject: [PATCH v2 2/8] bus/fslmc: run secondary debug app without > blocklist devices > > From: Rohit Raj > > dpaa2 hw

Re: [dpdk-dev] [PATCH v2 3/8] net/dpaa2: fix check for key size

2020-09-14 Thread Hemant Agrawal
> -Original Message- > From: Sachin Saxena (OSS) > Sent: Friday, September 11, 2020 2:05 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Subject: [PATCH v2 3/8] net/dpaa2: fix check for key size > > From: Apeksha Gupta > > DPAA2 has support for raw flow classification, which can be used

Re: [dpdk-dev] [PATCH v2 1/2] net/ice: refactor FDIR set conf function

2020-09-14 Thread Ferruh Yigit
On 9/14/2020 4:05 AM, Zhirun Yan wrote: > The original set conf function in FDIR was very long. Refactor to > increase readability to make it clearer and allow for more convenient > further changes. > > No functional change here. > > Signed-off-by: Zhirun Yan > --- > drivers/net/ice/ice_fdir_fi

Re: [dpdk-dev] [PATCH v2 4/8] bus/dpaa: RX/TX error queues

2020-09-14 Thread Hemant Agrawal
HI, > -Original Message- > From: Sachin Saxena (OSS) > Sent: Friday, September 11, 2020 2:05 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Subject: [PATCH v2 4/8] bus/dpaa: RX/TX error queues > > From: Sachin Saxena > > CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y > > 1) Enable TX/RX error

Re: [dpdk-dev] [PATCH v2 5/8] bus/fslmc: fix usage of dpio blocklist flag

2020-09-14 Thread Hemant Agrawal
Please squash it with patch 2/8 > -Original Message- > From: Sachin Saxena (OSS) > Sent: Friday, September 11, 2020 2:05 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Subject: [PATCH v2 5/8] bus/fslmc: fix usage of dpio blocklist flag > > From: Sachin Saxena > > DPIO object shouldn't

Re: [dpdk-dev] [PATCH v2 6/8] bus/dpaa: enhance link status support

2020-09-14 Thread Hemant Agrawal
Hi , > -Original Message- > From: Sachin Saxena (OSS) > Sent: Friday, September 11, 2020 2:05 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Subject: [PATCH v2 6/8] bus/dpaa: enhance link status support > > From: Rohit Raj > > This patch adds support to get/set link speed, duplex and

Re: [dpdk-dev] [PATCH v2 7/8] bus/dpaa: send error packets to application

2020-09-14 Thread Hemant Agrawal
This should be squashed with patch 4/8 > -Original Message- > From: Sachin Saxena (OSS) > Sent: Friday, September 11, 2020 2:05 PM > To: dev@dpdk.org; ferruh.yi...@intel.com > Subject: [PATCH v2 7/8] bus/dpaa: send error packets to application > > From: Nipun Gupta > > Api fman_if_set_

[dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pkts requirements

2020-09-14 Thread Morten Brørup
Updated description of rte_eth_rx_burst() to reflect what drivers, when using vector instructions, expect from nb_pkts. Also discussed on the mailing list here: http://inbox.dpdk.org/dev/98cbd80474fa8b44bf855df32c47dc35c61...@smartserver.smartshare.dk/ Signed-off-by: Morten Brørup --- lib/librt

[dpdk-dev] [PATCH] eal: detach memsegs on cleanup

2020-09-14 Thread Anatoly Burakov
Currently, we don't detach the shared memory on EAL cleanup, which leaves the page table descriptors still holding on to the file descriptors as well as memory space occupied by them. Fix it by adding another detach stage that closes the internal memory allocator resource references, detaches share

[dpdk-dev] [PATCH v2] eal: detach memsegs on cleanup

2020-09-14 Thread Anatoly Burakov
Currently, we don't detach the shared memory on EAL cleanup, which leaves the page table descriptors still holding on to the file descriptors as well as memory space occupied by them. Fix it by adding another detach stage that closes the internal memory allocator resource references, detaches share

Re: [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pkts requirements

2020-09-14 Thread Bruce Richardson
On Mon, Sep 14, 2020 at 01:05:11PM +0200, Morten Brørup wrote: > Updated description of rte_eth_rx_burst() to reflect what drivers, > when using vector instructions, expect from nb_pkts. > > Also discussed on the mailing list here: > http://inbox.dpdk.org/dev/98cbd80474fa8b44bf855df32c47dc35c61...

[dpdk-dev] [PATCH v3] eal: detach memsegs on cleanup

2020-09-14 Thread Anatoly Burakov
Currently, we don't detach the shared memory on EAL cleanup, which leaves the page table descriptors still holding on to the file descriptors as well as memory space occupied by them. Fix it by adding another detach stage that closes the internal memory allocator resource references, detaches share

[dpdk-dev] [PATCH v2] mbuf: remove atomic reference counters

2020-09-14 Thread Thomas Monjalon
From: Phil Yang Remove the deprecated refcnt_atomic union fields in rte_mbuf and rte_mbuf_ext_shared_info structures. Signed-off-by: Phil Yang Reviewed-by: Ruifeng wang Signed-off-by: Thomas Monjalon --- v2: - squashed - removed deprecation notice - updated release notes (in API s

Re: [dpdk-dev] [PATCH v2] mbuf: remove atomic reference counters

2020-09-14 Thread Andrew Rybchenko
On 9/14/20 3:19 PM, Thomas Monjalon wrote: > From: Phil Yang > > Remove the deprecated refcnt_atomic union fields in > rte_mbuf and rte_mbuf_ext_shared_info structures. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng wang > Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2] mbuf: remove atomic reference counters

2020-09-14 Thread Thomas Monjalon
14/09/2020 14:22, Andrew Rybchenko: > On 9/14/20 3:19 PM, Thomas Monjalon wrote: > > From: Phil Yang > > > > Remove the deprecated refcnt_atomic union fields in > > rte_mbuf and rte_mbuf_ext_shared_info structures. > > > > Signed-off-by: Phil Yang > > Reviewed-by: Ruifeng wang > > Signed-off-b

[dpdk-dev] [PATCH v3] mbuf: remove atomic reference counters

2020-09-14 Thread Thomas Monjalon
From: Phil Yang Remove the deprecated refcnt_atomic union fields in rte_mbuf and rte_mbuf_ext_shared_info structures. Signed-off-by: Phil Yang Reviewed-by: Ruifeng wang Signed-off-by: Thomas Monjalon --- v2: - squashed - removed deprecation notice - updated release notes (in API s

Re: [dpdk-dev] [PATCH v2 2/3] app/test: change rawdev autotest to run selftest on all devs

2020-09-14 Thread Laatz, Kevin
On 10/09/2020 17:47, Bruce Richardson wrote: Rather than having each rawdev provide its own autotest command, we can instead just use the generic rawdev_autotest to test any and all available rawdevs. Signed-off-by: Bruce Richardson --- app/test/test_rawdev.c | 34

Re: [dpdk-dev] [PATCH v2 3/3] app/test: remove ioat-specific autotest

2020-09-14 Thread Laatz, Kevin
On 10/09/2020 17:47, Bruce Richardson wrote: Since the rawdev autotest can now be used to test all rawdevs on the system, there is no need for a dedicated ioat autotest command. Signed-off-by: Bruce Richardson --- app/test/test_rawdev.c | 20 doc/guides/r

Re: [dpdk-dev] [PATCH v2 1/3] raw/ioat: support multiple devices being tested

2020-09-14 Thread Laatz, Kevin
On 10/09/2020 17:47, Bruce Richardson wrote: The current selftest function uses a single global variable to track state which implies that only a single instance can have the selftest function called on it. Change this to an array to allow multiple instances to be tested. Signed-off-by: Bruce Ri

Re: [dpdk-dev] [PATCH v3] mbuf: remove atomic reference counters

2020-09-14 Thread Thomas Monjalon
I wrote: > From: Phil Yang > > Remove the deprecated refcnt_atomic union fields in > rte_mbuf and rte_mbuf_ext_shared_info structures. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng wang > Signed-off-by: Thomas Monjalon > --- > > v2: > - squashed > - removed deprecation notice >

Re: [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pktsrequirements

2020-09-14 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Monday, September 14, 2020 1:27 PM > > On Mon, Sep 14, 2020 at 01:05:11PM +0200, Morten Brørup wrote: > > Updated description of rte_eth_rx_burst() to reflect what drivers, > > when using vector instructions, expect fr

[dpdk-dev] [PATCH] pci: support both PIO and MMIO bar for legacy virtio on x86

2020-09-14 Thread 谢华伟(此时此刻)
In previous implementation, with igb_uio we get PIO address from igb_uio sysfs entry; with uio_pci_generic, we get PIO address from /proc/ioports. For PIO/MMIO RW, there is different path for different drivers and arch. For VFIO, PIO port RW is through syscall, which has big performance issue. On

Re: [dpdk-dev] [PATCH v3 2/4] devtools: add generation of compressed abi dump archives

2020-09-14 Thread Burakov, Anatoly
On 11-Sep-20 5:03 PM, Conor Walsh wrote: This patch adds a script that generates a compressed archive containing .dump files which can be used to perform ABI breakage checking for the build specified in the parameters. Invoke using "./gen-abi-tarball.py -t -a [-cf ]" - : dpdk tag e.g. "v20.11

[dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag

2020-09-14 Thread Conor Walsh
Since librte_ipsec was first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it. The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to avoid possible ABI problems in the futur

[dpdk-dev] [PATCH v2] lib/bpf: remove experimental tag

2020-09-14 Thread Conor Walsh
The BPF lib was introduced in 18.05. There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag. RTE_BPF_XTYPE_NUM is also being dropped from rte_bpf_xtype to avoid possible ABI problems in the future. --- v2: RTE_BPF_XTYPE_NUM dropped from r

Re: [dpdk-dev] [EXT] Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt mode

2020-09-14 Thread Ferruh Yigit
On 9/7/2020 12:12 PM, Nithin Dabilpuram wrote: > On Tue, Aug 25, 2020 at 05:59:10PM +0100, Ferruh Yigit wrote: >> On 5/1/2020 2:16 PM, Nithin Dabilpuram wrote: >>> On Fri, May 01, 2020 at 11:27:02AM +0100, Ferruh Yigit wrote: External Email ---

[dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup

2020-09-14 Thread Anatoly Burakov
Currently, we don't detach the shared memory on EAL cleanup, which leaves the page table descriptors still holding on to the file descriptors as well as memory space occupied by them. Fix it by adding another detach stage that closes the internal memory allocator resource references, detaches share

Re: [dpdk-dev] [PATCH] net/af_xdp: custom XDP program loading

2020-09-14 Thread Loftus, Ciara
> > > > The new 'xdp_prog=' vdev arg allows the user to specify the path > to > > a custom XDP program to be set on the device, instead of the default libbpf > > one. The program must have an XSK_MAP of name 'xsks_map' which will > > allow for the redirection of some packets to userspace and thus t

Re: [dpdk-dev] [PATCH] ether: check the first segment length on SW VLAN insertion

2020-09-14 Thread Ferruh Yigit
On 6/25/2020 1:27 PM, Andrew Rybchenko wrote: > On 5/29/20 8:43 AM, Stephen Hemminger wrote: >> On Wed, 27 May 2020 15:31:41 +0100 >> Andrew Rybchenko wrote: >> >>> SW VLAN insertion relies on Ethernet addresses location in contigous >>> memory (do not split across mbuf segments). There is no any

[dpdk-dev] [PATCH] pci: support both PIO and MMIO bar for legacy virtio on x86

2020-09-14 Thread 谢华伟(此时此刻)
In previous implementation, with igb_uio we get PIO address from igb_uio sysfs entry; with uio_pci_generic, we get PIO address from /proc/ioports. For PIO/MMIO RW, there is different path for different drivers and arch. For VFIO, PIO port RW is through syscall, which has big performance issue. On

Re: [dpdk-dev] [PATCH v1] maintainers: update for igb igc ixgbe

2020-09-14 Thread Ferruh Yigit
On 9/7/2020 6:59 AM, Guo, Jia wrote: <...> > -Original Message- > From: Zhao1, Wei > Sent: Monday, September 7, 2020 11:32 AM > To: Wang, Haiyue ; dev@dpdk.org > Cc: Guo, Jia ; Zhang, Qi Z ; Thomas > Monjalon > Subject: RE: [PATCH v1] maintainers: update for igb igc ixgbe <...> >> -

Re: [dpdk-dev] [PATCH v2] net/axgbe: enable IEEE 1588 PTP support

2020-09-14 Thread Ferruh Yigit
On 6/9/2020 4:13 PM, selwin.sebast...@amd.com wrote: > From: Selwin Sebastian > > Add ethdev APIs to support PTP timestamping > > Signed-off-by: Selwin Sebastian There was no ack/review from axgbe maintainer. Somalapuram, Selwin, Is this patch still valid or can we drop it?

Re: [dpdk-dev] [PATCH v2] net/hinic: fix secondary process's using coredump.

2020-09-14 Thread Ferruh Yigit
On 9/1/2020 12:44 PM, Ferruh Yigit wrote: > On 8/8/2020 8:45 AM, liqingqing wrote: >> fix coredump when secondary process using the hinic port. >> the reason is that during the stage of >> secondary process port initialization, >> it lack the initialization of "eth_dev->dev_ops". >> >> Signed-off-b

Re: [dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag

2020-09-14 Thread David Marchand
Hello Conor, On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh wrote: > > Since librte_ipsec was first introduced in 19.02 and there were no changes > in it's public API since 19.11, it should be considered mature enough to > remove the 'experimental' tag from it. > The RTE_SATP_LOG2_NUM enum is also b

Re: [dpdk-dev] [PATCH v3] mbuf: remove atomic reference counters

2020-09-14 Thread Phil Yang
Thomas Monjalon writes: > > > > Remove the deprecated refcnt_atomic union fields in > > rte_mbuf and rte_mbuf_ext_shared_info structures. > > > > Signed-off-by: Phil Yang > > Reviewed-by: Ruifeng wang > > Signed-off-by: Thomas Monjalon > > --- > > > > v2: > > - squashed > > - removed d

Re: [dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag

2020-09-14 Thread Walsh, Conor
Hi David, > Hello Conor, > > On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh > wrote: > > > > Since librte_ipsec was first introduced in 19.02 and there were no > > changes in it's public API since 19.11, it should be considered mature > > enough to remove the 'experimental' tag from it. > > The RTE

Re: [dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: increase supported anti replay win sz

2020-09-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 03/10] sched: add subport profile add and config api

2020-09-14 Thread Singh, Jasvinder
> -Original Message- > From: Dharmappa, Savinay > Sent: Thursday, September 10, 2020 7:49 PM > To: Singh, Jasvinder ; Dumitrescu, Cristian > ; dev@dpdk.org > Cc: Dharmappa, Savinay > Subject: [PATCH v2 03/10] sched: add subport profile add and config api > > Add apis to add new subpor

Re: [dpdk-dev] [PATCH 2/2] crypto/dpaa2_sec: change descriptor sharing for ERA10

2020-09-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Updated email of maintainer. Signed-off-by: Sachin Saxena --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b16d7a4b..b257427e3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -506,7 +506,7 @@ F: drive

[dpdk-dev] [PATCH v3] ipsec: remove experimental tag

2020-09-14 Thread Conor Walsh
Since librte_ipsec was first introduced in 19.02 and there were no changes in it's public API since 19.11, it should be considered mature enough to remove the 'experimental' tag from it. The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to avoid possible ABI problems in the futur

[dpdk-dev] [PATCH v3] bpf: remove experimental tag

2020-09-14 Thread Conor Walsh
The BPF lib was introduced in 18.05. There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag. RTE_BPF_XTYPE_NUM is also being dropped from rte_bpf_xtype to avoid possible ABI problems in the future. --- v2: RTE_BPF_XTYPE_NUM dropped from r

[dpdk-dev] [PATCH v2] net/dpaa2: fix misuse of if_index

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH v2] net/pfe: fix misuse of if_index

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Pfe pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/pfe/pfe_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe

Re: [dpdk-dev] [PATCH v2] net/axgbe: enable IEEE 1588 PTP support

2020-09-14 Thread Somalapuram, Amaranath
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Sebastian, Selwin Sent: Tuesday, June 9, 2020 8:44 PM To: dev@dpdk.org Cc: Somalapuram, Amaranath Subject: [PATCH v2] net/axgbe: enable IEEE 1588 PTP support From: Selwin Sebastian Add ethdev APIs to support

Re: [dpdk-dev] [PATCH v2 05/10] sched: update the pipe config api implementation

2020-09-14 Thread Singh, Jasvinder
> -Original Message- > From: Dharmappa, Savinay > Sent: Thursday, September 10, 2020 7:49 PM > To: Singh, Jasvinder ; Dumitrescu, Cristian > ; dev@dpdk.org > Cc: Dharmappa, Savinay > Subject: [PATCH v2 05/10] sched: update the pipe config api implementation > > Subport profile paramet

Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort

2020-09-14 Thread Ferruh Yigit
On 8/3/2020 4:55 PM, Andrew Rybchenko wrote: > On 8/3/20 6:49 PM, Ori Kam wrote: >> Hi David, >> >>> -Original Message- >>> From: David Marchand >>> >>> On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: >> + >> +- Hashing on types that are not supported by the PMD. > Shouldn't it

[dpdk-dev] [PATCH v6 1/2] service: add API to retrieve service core active

2020-09-14 Thread Harry van Haaren
This commit adds a new experimental API which allows the user to retrieve the active state of an lcore. Knowing when the service lcore is completed its polling loop can be useful to applications to avoid race conditions when e.g. finalizing statistics. The service thread itself now has a variable

[dpdk-dev] [PATCH v6 2/2] test/service: fix race condition on stopping lcore

2020-09-14 Thread Harry van Haaren
This commit fixes a potential race condition in the tests where the lcore running a service would increment a counter that was already reset by the test-suite thread. The resulting race-condition incremented value could cause CI failures, as indicated by DPDK's CI. This patch fixes the race-condit

[dpdk-dev] [PATCH v1 0/5] some bugs fix

2020-09-14 Thread Xiaoyun wang
These patches fix return value of null not checked, fix TCAM filter set failed process, reset rx_mbuf_alloc_failed to 0 when get stats to avoid adding everytime when this ops is called, get default cos from chip, and Sync the repair of patch("fix compile error for old glibc caused by CLOCK_MONO

[dpdk-dev] [PATCH v1 1/5] net/hinic: fix return value of null not checked

2020-09-14 Thread Xiaoyun wang
If rte_zmalloc failed, pmd driver should also delete the ntuple filter or ethertype filter or normal and tcam filter that already added before. Fixes: d7964ce192e7 ("net/hinic: check memory allocations in flow creation") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic

[dpdk-dev] [PATCH v1 3/5] net/hinic: fix Rx nombuf stats

2020-09-14 Thread Xiaoyun wang
rx_mbuf_alloc_failed value is not set to 0 when get stats from driver, which may cause this counter added every time when call this ops. Fixes: cb7b6606ebff ("net/hinic: add RSS stats and promiscuous ops") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c |

[dpdk-dev] [PATCH v1 5/5] net/hinic/base: fix clock definition with glibc version

2020-09-14 Thread Xiaoyun wang
Sync the repair of patch("fix compile error for old glibc caused by CLOCK_MONOTONIC_RAW") in the community. Fixes: efeed0894e9c ("net/hinic/base: avoid system time jump") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_compat.h | 8 +++- 1 file changed, 7 ins

[dpdk-dev] [PATCH v1 2/5] net/hinic: fix TCAM filter set failed

2020-09-14 Thread Xiaoyun wang
hinic supports two methods: linear table and tcam table, if tcam filter enables failed but linear table is ok, which also needs to enable filter, so for this scene, driver should not close fdir switch. Fixes: f4ca3fd54c4d ("net/hinic: create and destroy flow director filter") Cc: sta...@dpdk.org S

  1   2   3   >