https://bugs.dpdk.org/show_bug.cgi?id=522
Bug ID: 522
Summary: Performance degradation on AWS ena driver
Product: DPDK
Version: 19.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Pr
Virtio Standard TX broken : Reverting a small change added few months back
which has caused breakage in Virtio Standard TX path.
During basic ping Tx/Rx testing of net_virtio pmd driver using standard Tx
path, We saw TX is broken since anomaly code added by below patch once submitted
http://git.
Hi Andrew,
> -Original Message-
> From: Andrew Rybchenko
>
> On 8/7/20 8:02 AM, Ori Kam wrote:
> > Using the rte_flow action RSS types field,
> > may result in undefined outcome.
> >
> > For example selecting both UDP and TCP,
> > selecting TCP RSS type but the pattern is targeting UDP
On 03-Aug-20 3:31 PM, Owen Hilyard wrote:
On Fri, Jul 31, 2020 at 5:12 AM Burakov, Anatoly
mailto:anatoly.bura...@intel.com>> wrote:
On 30-Jul-20 5:54 PM, Owen Hilyard wrote:
> Thanks for the advice.
>
> I was wondering about the state of the "Setup VFIO permissions"
o
Clarify the ABI reference version (DPDK_ABI_REF_VERSION) tag, to use
when testing builds with devtools/test_build[_meson].sh before
submitting patches.
Signed-off-by: Ray Kinsella
---
doc/guides/contributing/patches.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/gu
I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas
and Akhil.
This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
also shows it has 3 ACKs.
Can I ask why it didn't go into 20.08 then?
Adam
> -Original Message-
> From: Thomas Monjalon
> Sent:
Hi Stephen,
To give an overview of the rationale behind the patchset:
- It allows other apps such as OVS and VPP which already make use of
AVX-512 to indicate that they are happy for DPDK to use AVX-512 too.
- It allows the end-user to override those settings if so desired.
- It allows an ea
On 8/10/20 10:40 AM, Ori Kam wrote:
> Hi Andrew,
>
>
>> -Original Message-
>> From: Andrew Rybchenko
>>
>> On 8/7/20 8:02 AM, Ori Kam wrote:
>>> Using the rte_flow action RSS types field,
>>> may result in undefined outcome.
>>>
>>> For example selecting both UDP and TCP,
>>> selecting TCP
10/08/2020 11:47, Dybkowski, AdamX:
> I see there are 3 ACKs: original (see the commit message) from Fan, then
> Thomas and Akhil.
> This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> also shows it has 3 ACKs.
Sorry I missed initial ack.
> Can I ask why it didn't go into 20.08
Scatter gather mode should get enabled:
- If mbuf size is less than max received packet length.
- MTU is reconfigured greater than mbuf size.
Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation")
Cc: sta...@dpdk.org
Signed-off-by: Harman Kalra
---
drivers/net/octeontx2/otx2_ethdev.c
Sorry about that Thomas, Akhil, we should have chased up acks sooner.
Given the proposed content of the patch, and the similar changes that are
recommended and agreed
throughout DPDK do you think an exception can be made and that this change can
get into 20.11 even
without the deprecation notic
10/08/2020 13:49, Trahe, Fiona:
> Sorry about that Thomas, Akhil, we should have chased up acks sooner.
>
> Given the proposed content of the patch, and the similar changes that are
> recommended and agreed
> throughout DPDK do you think an exception can be made and that this change
> can get i
Introduce function in to retrieve a lcore worker
thread's pthread id.
This change allows applications to do things like changing the name of
a lcore thread, or detect if it's getting interrupted (e.g. getting
preempted by another thread).
Signed-off-by: Mattias Rönnblom
---
lib/librte_eal/comm
https://bugs.dpdk.org/show_bug.cgi?id=523
Bug ID: 523
Summary: vhost iotlb cache incorrectly assumes to be single
consumer
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFI
Bugzilla bug: 523
Using testpmd as a vhost-user with iommu:
/home/dpdk/build/app/dpdk-testpmd -l 1,3 \
--vdev net_vhost0,iface=/tmp/vhost-user1,queues=1,iommu-support=1 \
-- --auto-start --stats-period 5 --forward-mode=txonly
And qemu with packed virtqueue:
Bugzilla bug: 523
Using testpmd as a vhost-user with iommu:
/home/dpdk/build/app/dpdk-testpmd -l 1,3 \
--vdev net_vhost0,iface=/tmp/vhost-user1,queues=1,iommu-support=1 \
-- --auto-start --stats-period 5 --forward-mode=txonly
And qemu with packed virtqueue:
Using the rte_flow action RSS types field,
may result in undefined outcome.
For example selecting both UDP and TCP,
selecting TCP RSS type but the pattern is targeting UDP traffic.
another option is that the PMD doesn't support all requested types.
Until now, it wasn't clear what will happen in s
Start a new release cycle with empty release notes.
ABI check is disabled in 20.11 cycle.
Signed-off-by: Thomas Monjalon
---
.travis.yml| 26 -
ABI_VERSION| 2 +-
VERSION| 2 +-
doc/guides/rel_notes/
> -Original Message-
> From: dev On Behalf Of Ciara Power
> Sent: Friday, August 7, 2020 11:59
> To: dev@dpdk.org
> Cc: bruce.richard...@intel.com; Ciara Power ; Matan
> Azrad ; Shahaf Shuler ;
> Viacheslav Ovsiienko
> Subject: [dpdk-dev] [PATCH 20.11 11/12] net/mlx5: add checks for max S
Flows like IP4 / UDP / RAW are not working because after parsing
RTE_FLOW_ITEM_TYPE_RAW item pointer is not advanced. This make whole
parsing fail.
Fixes: f35fec63dde1 ("net/ixgbe: enable flex bytes for generic flow API")
Cc: qi.z.zh...@intel.com
Signed-off-by: Pawel Wodkowski
---
drivers/net/ix
trace_mem is declared as 'void *' which triggers following error:
'...invalid conversion from ‘void*’ to ‘__rte_trace_header*’
[-fpermissive]...'
Fix this by adding proper typecast to 'struct __rte_trace_header *'.
Signed-off-by: Pawel Wodkowski
Fixes: ebaee6409702 ("trace: simplify trace point
The SPAPR IOMMU requires that a DMA window size be defined before memory
can be mapped for DMA. Current code dynamically modifies the DMA window
size in response to every new memory allocation which is potentially
dangerous because all existing mappings need to be unmapped/remapped in
order to resi
The SPAPR v2 IOMMU used on bare-metal PowerNV systems requires that a DMA
window be defined before mapping/unmapping memory. The current VFIO code
dynamically resizes this DMA window every time a new memory request is
made, which requires that all existing memory be unmapped/remapped.
While this s
Hi Vipul,
> -Original Message-
> From: Vipul Ashri
> Sent: Tuesday, August 11, 2020 4:00 AM
> To: dev@dpdk.org
> Cc: Xia, Chenbo ; vipul.as...@oracle.com
> Subject: [PATCH v2] net/virtio: fix 57f90f8("net/virtio: reuse packed ring
> functions")
The title is not right. As I told you,
plea
From: Long Li
netvsc uses rxbuf_info buffer to track received packets attached via
rte_pktmbuf_attach_extbuf() and ack the host based on usage count. It uses
the transaction_id in the VMBus packet to locate where to use memory in the
rxbuf_info.
This is not correct in multiple channel setup, as
From: Stephen Hemminger
The data from the host is trusted but checked by the driver.
One check that is missing is that the packet offset and length
might cause wraparound.
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Signed-off-by: Long Li
---
drivers/net/netvsc/hn_rxtx.c | 6 --
From: Long Li
netvsc is a high speed VMBus device that uses monitor bit to signal the
host. It's not necessary to send interrupts via INT bit.
Signed-off-by: Long Li
---
drivers/bus/vmbus/vmbus_channel.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/bus/vmbus/vmbus_
From: Long Li
chim_index could potentially be used in other hn_txdesc when re-allocated.
Mark it as invalid to prevent stale value being used.
Signed-off-by: Long Li
---
drivers/net/netvsc/hn_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_rx
> >
> > > > > > > > @@ -1790,9 +1792,9 @@ mlx5_rx_burst_mprq(void *dpdk_rxq,
> > > > struct
> > > > > > > > rte_mbuf **pkts, uint16_t pkts_n) void *buf_addr;
> > > > > > > >
> > > > > > > > /* Increment the refcnt of the whole chunk. */
> > > > > > > > -rte_atomic16_add_return(&buf->refcnt, 1);
Hi Ciara,
I have not reviewed other patches in this series yet. Few questions
inline.
> -Original Message-
> From: dev On Behalf Of Ciara Power
> Sent: Friday, August 7, 2020 10:59 AM
> To: dev@dpdk.org
> Cc: bruce.richard...@intel.com; Ciara Power
> Subject: [dpdk-dev] [PATCH 2
According to current RTE API, port flow rules must not be kept
after port stop.
Testpmd did not flush port flow rules after `port stop' command was
called. As the result, after the port was restarted, it showed bogus
flow rules.
Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Added needed changes in order to get ethdev compiling under windows.
Depends-on: series-10382 ("compile librte_net for windows")
v5: fixed style issues.
v4: added comments to #else and fixed code issue.
v3: rebased on current master, added more exports to export list
v2: fixed logging issue in
Compiling needed libraries for ethdev under Windows.
Signed-off-by: Fady Bader
---
lib/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/meson.build b/lib/meson.build
index 6bbaf242a9..c145240eb9 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -38,9 +38,
Telemetry didn't compile under Windows.
Empty stubs implementation was added for Windows.
Signed-off-by: Fady Bader
---
lib/librte_telemetry/rte_telemetry.h| 4 +++
lib/librte_telemetry/telemetry.c| 50 +
lib/librte_telemetry/telemetry_legacy.c | 25 +
Added eal functions used by ethdev lib to the export list under Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/rte_eal_exports.def | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/librte_eal/rte_eal_exports.def
b/lib/librte_eal/rte_eal_exports.def
index 69204a92c6..78
The ethdev lib uses interrupts. Interrupts are not implemented for Windows.
To solve this, empty interrupt stubs were added under Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/eal_interrupts.c | 18 ++
lib/librte_eal/windows/meson.build | 1 +
2 files change
Some ethdev structs were present in ethdev export list.
There structs were removed from the export list.
Signed-off-by: Fady Bader
---
lib/librte_ethdev/rte_ethdev_version.map | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev_version.map
b/lib/librte_ethdev/rte_e
These patches are bugs porting from i40evf to iavf.
[PATCH 1/7] net/iavf: fix scattered Rx enabling
[PATCH 2/7] net/iavf: set speed to undefined for default case
[PATCH 3/7] net/iavf: fix port start during configuration restore
[PATCH 4/7] net/iavf: fix setting of MAC address on iavf
[PA
No need to add additional vlan tag size for max packet size, since
for i40e, the queue's Rx Max Frame Size (rxq->max_pkt_len) already
includes the vlan header size.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Signed-off-by: SteveX Yang
---
drivers/net/iavf/iavf_ethdev.c | 2 +-
1 f
During PF/VF link update, a default speed value of 100M will be set
if get_link_info has failed or speed is unknown.
Consequently if PF is put in no-carrier state, VFs will switch to
"in carrier" state due to a link up + a link speed set to 100M
(default value if no speed detected).
To be consist
If configuring VF promiscuous mode is not supported,
return -ENOTSUP error code in .promiscuous_enable/disable dev_ops.
This is to fix the port start during configuration restore,
where if .promiscuous_enable/disable dev_ops exists
and return any value other than -ENOTSUP, start will fail.
Same is
Interrupt mapping should be 1:n queue(s).This patch fixes the
logic of interrupt bind by code reconstruction.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Signed-off-by: SteveX Yang
---
drivers/net/iavf/iavf_vchnl.c | 56 ---
1 file changed, 45 insert
When setting the MAC address, the ethdev layer copies the new mac
address in dev->data->mac_addrs[0] before calling the dev_ops.
Therefore, is_same_ether_addr(mac_addr, dev->data->mac_addrs) was
always true, and the MAC was never set. Remove this test to fix the
issue.
Fixes: 538da7a1cad2 ("net:
From: "Zhang, RobinX"
Port reset will call iavf_dev_uninit() to release resources. It wants
to call iavf_dev_close() to release resources. So there will be a
call conflict if calling iavf_dev_reset() and iavf_dev_close() at the
same time.
This patch added adapter->closed flag in iavf_dev_close()
When receiving the unsupported AQ messages, it's taken as an
error. It's not appropriate and triggers too much unnecessary print.
Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Signed-off-by: SteveX Yang
---
drivers/net/iavf/iavf_vchnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
45 matches
Mail list logo
