Hi Vipul, > -----Original Message----- > From: Vipul Ashri <vipul.as...@oracle.com> > Sent: Tuesday, August 11, 2020 4:00 AM > To: dev@dpdk.org > Cc: Xia, Chenbo <chenbo....@intel.com>; vipul.as...@oracle.com > Subject: [PATCH v2] net/virtio: fix 57f90f8("net/virtio: reuse packed ring > functions")
The title is not right. As I told you, please put 'Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions")' between the commit message and your 'Signed-off-by'. Note that the prefix should be 'Fixes' and the commit id length is 12. Could you refer to other commit with 'Fixes' to make it right? > > tx packets are not going out and standard tx path is not working due to > cleanup malfunctioning. Could you tell me what problem you solved? You just describe the result but not the root cause. Thanks! Chenbo > > Signed-off-by: Vipul Ashri <vipul.as...@oracle.com> > --- > drivers/net/virtio/virtqueue.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/virtio/virtqueue.h > b/drivers/net/virtio/virtqueue.h > index 105a9c00c..20c95471e 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) > > /* avoid write operation when necessary, to lessen cache issues */ > #define ASSIGN_UNLESS_EQUAL(var, val) do { \ > - typeof(var) var_ = (var); \ > - typeof(val) val_ = (val); \ > - if ((var_) != (val_)) \ > - (var_) = (val_); \ > + if ((var) != (val)) \ > + (var) = (val); \ > } while (0) > > #define virtqueue_clear_net_hdr(hdr) do { \ > -- > 2.28.0.windows.1