Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-29 Thread Jerin Jacob
On Tue, Jun 30, 2020 at 1:01 AM McDaniel, Timothy wrote: > > -Original Message- > From: Jerin Jacob > Sent: Saturday, June 27, 2020 2:45 AM > To: McDaniel, Timothy ; Ray Kinsella > ; Neil Horman > Cc: Jerin Jacob ; Mattias Rönnblom > ; dpdk-dev ; Eads, Gage > ; Van Haaren, Harry > Su

Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: add private APIs

2020-06-29 Thread Jeff Guo
hi, chenxu On 6/15/2020 10:18 AM, Chenxu Di wrote: The legacy filter API will be superseded by rte_flow. There are also several small features which can not be implemented in rte_flow. This patch re-implemented these features as private API. Three APIs are added: rte_pmd_i40e_get_fdir_info. rte_

[dpdk-dev] [PATCH v2] net/i40e: enable port filter by switch filter

2020-06-29 Thread Guinan Sun
This patch enables the filter that supports to create following two rules for the same packet type: One is to select source port only as input set and the other is for destination port only. Signed-off-by: Guinan Sun --- v2: * Fixed code style and variable naming --- doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH v2] eal: adjust barriers for IO on Armv8-a

2020-06-29 Thread Jerin Jacob
On Sun, Jun 28, 2020 at 12:55 AM Honnappa Nagarahalli wrote: > > Hi Jerin, > You had a comment earlier about deprecating rte_cio_[rw]mb. Let me > know if you are ok with this patch and I can add those changes (replace > references to rte_cio_[rw]mb with rte_io_[rw]mb and a deprecation no

Re: [dpdk-dev] [PATCH v2 2/5] net/ixgbe: add private APIs

2020-06-29 Thread Jeff Guo
hi, chenxu On 6/15/2020 10:18 AM, Chenxu Di wrote: The legacy filter API will be superseded by rte_flow. There are also several small features which can not be implemented in rte_flow. This patch re-implemented these features as private API. Two APIs are added: rte_pmd_ixgbe_get_fdir_info. rte_p

Re: [dpdk-dev] [PATCH 1/3] event/octeontx2: fix device reconfigure

2020-06-29 Thread Jerin Jacob
On Mon, Jun 29, 2020 at 7:03 AM wrote: > > From: Pavan Nikhilesh > > When event device is re-configured maintain the event queue to event port > links and event port status instead of resetting them. > > Fixes: cd24e70258bd ("event/octeontx2: add device configure function") > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v2] net/i40e: enable port filter by switch filter

2020-06-29 Thread Xing, Beilei
> -Original Message- > From: Sun, GuinanX > Sent: Tuesday, June 30, 2020 12:42 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Sun, > GuinanX > Subject: [PATCH v2] net/i40e: enable port filter by switch filter How about 'support cloud filter with l4 port'? Please also fix all t

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: re-implement commands by using private API

2020-06-29 Thread Jeff Guo
hi, chenxu On 6/17/2020 6:12 PM, Di, ChenxuX wrote: -Original Message- From: Kevin Traynor [mailto:ktray...@redhat.com] Sent: Wednesday, June 17, 2020 4:12 AM To: Di, ChenxuX ; dev@dpdk.org Cc: Xing, Beilei ; Yang, Qiming Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: re-implement c

Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: support query RSS config in flow query

2020-06-29 Thread Jeff Guo
hi, chenxu On 6/15/2020 10:18 AM, Chenxu Di wrote: This patch support RSS action in flow query. It can display the RSS configuration of the specified rule. Could you add some example command here for better know the usage and the details. Signed-off-by: Chenxu Di --- app/test-pmd/conf

Re: [dpdk-dev] [PATCH v2 4/5] net/i40e: enable flow query RSS

2020-06-29 Thread Jeff Guo
hi, chenxu On 6/15/2020 10:18 AM, Chenxu Di wrote: This patch enables flow query function to get the configuration ofthe specified rule. "ofthe" should be "of the". Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_flow.c | 51 1 file changed, 51

Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-29 Thread Dmitry Kozlyuk
On Sun, 28 Jun 2020 23:23:11 -0700, Ranjit Menon wrote: > On 6/28/2020 7:20 AM, Fady Bader wrote: > > Hi Dmitry, > > I'm trying to run test-pmd on Windows and I ran into this error with > > cmdline. > > > > The error log message is : > > In file included from ../app/test-pmd/cmdline_flow.c:23: > >

Re: [dpdk-dev] [PATCH v2 4/5] telemetry: implement empty stubs for Windows

2020-06-29 Thread Thomas Monjalon
28/06/2020 20:04, Stephen Hemminger: > On Sun, 28 Jun 2020 13:58:50 +0300 > Fady Bader wrote: > > > Telemetry didn't compile under Windows. > > Empty stubs implementation was added for Windows. > > > > Signed-off-by: Fady Bader > > Maybe ethdev could be modified to not depend on telemetry libr

[dpdk-dev] [PATCH v5 1/3] lib/lpm: integrate RCU QSBR

2020-06-29 Thread Ruifeng Wang
Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR process is integrated for safe tbl8 group reclaim. Refer to RCU documentation to understand various

[dpdk-dev] [PATCH v5 0/3] RCU integration with LPM library

2020-06-29 Thread Ruifeng Wang
This patchset integrates RCU QSBR support with LPM library. Resource reclaimation implementation was splitted from the original series, and has already been part of RCU library. Rework the series to base LPM integration on RCU reclaimation APIs. New API rte_lpm_rcu_qsbr_add is introduced for appl

[dpdk-dev] [PATCH v5 3/3] test/lpm: add RCU integration performance tests

2020-06-29 Thread Ruifeng Wang
From: Honnappa Nagarahalli Add performance tests for RCU integration. The performance difference with and without RCU integration is very small (~1% to ~2%) on both Arm and x86 platforms. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang --- app/test/test_lp

[dpdk-dev] [PATCH v5 2/3] test/lpm: add LPM RCU integration functional tests

2020-06-29 Thread Ruifeng Wang
Add positive and negative tests for API rte_lpm_rcu_qsbr_add. Also test LPM library behavior when RCU QSBR is enabled. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- app/test/test_lpm.c | 291 +++- 1 file changed,

Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows

2020-06-29 Thread Tal Shnaiderman
> From: Dmitry Kozlyuk > Subject: Re: [dpdk-dev] [PATCH 6/7] cmdline: support Windows > > On Sun, 28 Jun 2020 23:23:11 -0700, Ranjit Menon wrote: > > On 6/28/2020 7:20 AM, Fady Bader wrote: > > > Hi Dmitry, > > > I'm trying to run test-pmd on Windows and I ran into this error with > cmdline. > >

Re: [dpdk-dev] [PATCH] net/ixgbe: enable 10Mb/s speed for x553

2020-06-29 Thread Jeff Guo
hi, wei On 6/28/2020 2:12 PM, Wei Zhao wrote: For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed, so enable it for the kind of ixgbe nic. This is not an enabling patch i think, it just add the support link speed info for specific nic, so suggest you refine the commit log an

Re: [dpdk-dev] [PATCH 6/7] common/mlx5: remove useless assignment

2020-06-29 Thread Raslan Darawsheh
Hi > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 2:33 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH 6/7] common/mlx5: remove useless assignment > > The mlx5_dev_to_pci_addr function defines a variab

Re: [dpdk-dev] [PATCH] net/mlx4: remove useless assignment

2020-06-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:31 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx4: remove useless assignment > > The mlx4_ibv_device_to_pci_addr function defines a varia

Re: [dpdk-dev] [PATCH] net/mlx5: fix iterator type in Rx queue management

2020-06-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 5:07 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix iterator type in Rx queue > management > > The mlx5_check_vec_rx_

Re: [dpdk-dev] [PATCH] net/mlx5: use anonymous DV allocator argument

2020-06-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Wednesday, June 24, 2020 4:47 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [dpdk-dev] [PATCH] net/mlx5: use anonymous DV allocator > argument > > The mlx5_dev_spawn function defines an stru

Re: [dpdk-dev] [EXT] [PATCH v4 4/9] eal: introduce thread uninit helper

2020-06-29 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Friday, June 26, 2020 8:18 PM >To: dev@dpdk.org >Cc: jerinjac...@gmail.com; bruce.richard...@intel.com; m...@ashroe.eu; >tho...@monjalon.net; arybche...@solarflare.com; ktray...@redhat.com; >ian.sto...@intel.com; i.maxim...@ovn.org; Jerin Ja

Re: [dpdk-dev] [PATCH v3 00/14] vDPA API and framework rework

2020-06-29 Thread Maxime Coquelin
On 6/26/20 4:47 PM, Adrian Moreno wrote: > > > On 6/26/20 4:04 PM, Maxime Coquelin wrote: >> This series aims to rework the vDPA framework and >> its API to better fit into the DPDK device model >> and also be more easily consumable by applications. >> >> Main changes are creating a device cla

Re: [dpdk-dev] 18.11.9 (LTS) patches review and test

2020-06-29 Thread Kevin Traynor
On 28/06/2020 04:51, Chen, BoX C wrote: > Hi, Kevin > Update LTS 18.11.9 test result for Intel part. All passed and no new issue > is found. > > * Intel(R) Testing > > # Basic Intel(R) NIC testing > * PF(i40e):Passed > * PF(ixgbe):Passed > * VF(i40e):Passed > * Build or compile: Passed >

Re: [dpdk-dev] 18.11.9 (LTS) patches review and test

2020-06-29 Thread Kevin Traynor
On 28/06/2020 06:42, Pei Zhang wrote: > Hi Kevin, > > Testing with dpdk 18.11.9-rc2 from Red Hat looks good. > > We cover below 13 scenarios and and all get PASS on RHEL8 testing: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > (2)Guest with device assignment

Re: [dpdk-dev] [PATCH v2 1/3] vdpa/mlx5: optimize notification events

2020-06-29 Thread Maxime Coquelin
On 6/25/20 3:30 PM, Matan Azrad wrote: > When the virtio guest driver doesn't work with poll mode, the driver > creates event mechanism in order to schedule completion notifications > for each virtq burst traffic. > > When traffic comes to a virtq, a CQE will be added to the virtq CQ by > the F

Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper

2020-06-29 Thread David Marchand
On Fri, Jun 26, 2020 at 5:00 PM Jerin Jacob wrote: > > On Fri, Jun 26, 2020 at 8:18 PM David Marchand > wrote: > > > > This is a preparation step for dynamically unregistering threads. > > > > Since we explicitly allocate a per thread trace buffer in > > rte_thread_init, add an internal helper to

Re: [dpdk-dev] [PATCH v2 2/3] vdpa/mlx5: optimize completion queue poll

2020-06-29 Thread Maxime Coquelin
On 6/25/20 3:30 PM, Matan Azrad wrote: > The vDPA driver uses a CQ in order to know when traffic works were > completed by the HW. > > Each traffic burst completion adds a CQE to the CQ. > > When the vDPA driver detects CQEs in the CQ, it triggers the guest > notification for the corresponding

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-29 Thread Bruce Richardson
On Fri, Jun 26, 2020 at 10:05:42AM -0700, Stephen Hemminger wrote: > On Fri, 26 Jun 2020 15:59:57 +0100 > Bruce Richardson wrote: > > > When using statically linked DPDK binaries, the EAL checks the default PMD > > path and tries to load any drivers there, despite the fact that all drivers > > ar

Re: [dpdk-dev] [PATCH v2 3/3] vdpa/mlx5: control completion queue event mode

2020-06-29 Thread Maxime Coquelin
On 6/25/20 3:30 PM, Matan Azrad wrote: > The CQ polling is necessary in order to manage guest notifications when > the guest doesn't work with poll mode (callfd != -1). > > The CQ polling scheduling method can affect the host CPU utilization and > the traffic bandwidth. > > Define 3 modes to c

Re: [dpdk-dev] [PATCH] common/mlx5: remove unneeded experimental build flag

2020-06-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Thursday, June 25, 2020 10:58 AM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko ; Ophir Munk > > Subject: [dpdk-dev] [PATCH] common/mlx5: remove unneeded > experimental

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-29 Thread Bruce Richardson
On Mon, Jun 29, 2020 at 10:11:58AM +0100, Bruce Richardson wrote: > On Fri, Jun 26, 2020 at 10:05:42AM -0700, Stephen Hemminger wrote: > > On Fri, 26 Jun 2020 15:59:57 +0100 > > Bruce Richardson wrote: > > > > > When using statically linked DPDK binaries, the EAL checks the default PMD > > > path

Re: [dpdk-dev] [EXT] [PATCH v4 4/9] eal: introduce thread uninit helper

2020-06-29 Thread David Marchand
On Mon, Jun 29, 2020 at 10:59 AM Sunil Kumar Kori wrote: > >diff --git a/lib/librte_eal/common/eal_common_thread.c > >b/lib/librte_eal/common/eal_common_thread.c > >index afb30236c5..3b30cc99d9 100644 > >--- a/lib/librte_eal/common/eal_common_thread.c > >+++ b/lib/librte_eal/common/eal_common_thre

Re: [dpdk-dev] [PATCH 02/21] net/ixgbe/base: change in the condition for response HI

2020-06-29 Thread Yang, Qiming
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Monday, June 22, 2020 19:59 > To: Sun, GuinanX ; dev@dpdk.org > Cc: Mateusz Kowalski > Subject: Re: [dpdk-dev] [PATCH 02/21] net/ixgbe/base: change in the > condition for response HI Don't use HI, please follow Ferruh's

Re: [dpdk-dev] [dpdk-stable] [PATCH] vfio: remove unused variable

2020-06-29 Thread David Marchand
On Sat, May 16, 2020 at 9:59 AM wangyunjian wrote: > > From: Yunjian Wang > > The 'group_status' has never been used and can be removed. > > Fixes: 94c0776b1bad ("vfio: support hotplug") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang > --- > lib/librte_eal/linux/eal_vfio.c | 3 --- > 1 f

Re: [dpdk-dev] [PATCH] vfio: fix mem leak when unmapping resource

2020-06-29 Thread David Marchand
On Sun, Jun 14, 2020 at 4:01 PM Yunjian Wang wrote: > > The 'vfio_res' is not freed when unmapping resource by primary process. > This leads to memory leak. > > Fixes: ab53203e194b ("vfio: enable unmapping resource for secondary") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang > --- > dri

Re: [dpdk-dev] [PATCH v2 (v20.11) 2/2] eal: improve device probing API

2020-06-29 Thread Gaëtan Rivet
On 25/06/20 10:04 +0200, Maxime Coquelin wrote: > This patch makes rte_dev_probe() to return the > rte_device pointer on success and NULL on error > instead of returning 0 on success and negative > value on error. > > The goal is to avoid that the calling application > iterates the devices list af

Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd

2020-06-29 Thread David Marchand
On Wed, May 27, 2020 at 4:58 PM Bruce Richardson wrote: > > If the bonding pmd is disabled, all autotest associated with it should be > disabled. However, some of those tests also depended upon the ring PMD so > were placed in a block depending on that driver - and unfortunately that > driver alon

Re: [dpdk-dev] [PATCH v5 4/4] eal/atomic: add wrapper for c11 atomic thread fence

2020-06-29 Thread Ananyev, Konstantin
> > > > > Subject: [PATCH v5 4/4] eal/atomic: add wrapper for c11 atomic thread fence > > > > Provide a wrapper for __atomic_thread_fence built-in to support optimized > > code for __ATOMIC_SEQ_CST memory order for x86 platforms. > > > > Suggested-by: Honnappa Nagarahalli > > Signed-off-by: P

Re: [dpdk-dev] [PATCH v5 4/4] eal/atomic: add wrapper for c11 atomic thread fence

2020-06-29 Thread Ananyev, Konstantin
> > Provide a wrapper for __atomic_thread_fence built-in to support > optimized code for __ATOMIC_SEQ_CST memory order for x86 platforms. > > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Phil Yang > Reviewed-by: Ola Liljedahl > --- > lib/librte_eal/arm/include/rte_atomic_32.h | 6 +

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-06-29 Thread Andrey Vesnovaty
On Sun, Jun 28, 2020 at 4:42 PM Jerin Jacob wrote: > On Sun, Jun 28, 2020 at 2:14 PM Andrey Vesnovaty > wrote: > > > > Hi > > > > On Fri, Jun 26, 2020 at 2:44 PM Jerin Jacob > wrote: > >> > >> On Sat, Jun 20, 2020 at 7:02 PM Andrey Vesnovaty > >> wrote: > >> > > >> > Hi, and thanks a lot for y

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-29 Thread Ori Kam
Hi all, > -Original Message- > From: Andrew Rybchenko > Sent: Sunday, June 28, 2020 7:19 PM > To: Jiawei(Jonny) Wang ; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad > Cc: dev@dpdk.org; Thomas Monjalon ; Raslan > Darawsheh ; ian.sto...@intel.com; f...@redhat.com > Subject: Re: [dpdk-dev] [P

Re: [dpdk-dev] [PATCH v5 1/3] lib/lpm: integrate RCU QSBR

2020-06-29 Thread David Marchand
On Mon, Jun 29, 2020 at 10:03 AM Ruifeng Wang wrote: > > Currently, the tbl8 group is freed even though the readers might be > using the tbl8 group entries. The freed tbl8 group can be reallocated > quickly. This results in incorrect lookup results. > > RCU QSBR process is integrated for safe tbl8

[dpdk-dev] [PATCH v10 03/10] pci: use OS generic memory mapping functions

2020-06-29 Thread talshn
From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Change all of PCI mapping function usage in bus/pci to support the new API. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c

[dpdk-dev] [PATCH v10 00/10] Windows bus/pci support

2020-06-29 Thread talshn
From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. --- v10: * replace strncpy with strlcpy (ThomasM) * Fix indent and style issues with new variables (ThomasM) * Remove the remap function and u

[dpdk-dev] [PATCH v10 01/10] eal: move OS common config objects

2020-06-29 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those functions are getter functions for IOVA, configuration, Multi-process. Move rte_config, internal_config, early_mem_config and runtime_dir to be defined in the common file with getter functions. R

[dpdk-dev] [PATCH v10 04/10] pci: build on Windows

2020-06-29 Thread talshn
From: Tal Shnaiderman Added in rte_pci header file to include off_t type since it is missing for Windows. Define the implementation of the Linux function rte_pci_get_sysfs_path in pci_common.c for Linux OS only as it is unneeded for other OSs and to avoid the warning on deprecated call to geten

[dpdk-dev] [PATCH v10 02/10] eal: move OS common options functions

2020-06-29 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_options.c. Those functions are getter functions for rte_application_usage_hook. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/eal_common_options.c | 23 +++ lib/librte_eal/common/

[dpdk-dev] [PATCH v10 05/10] pci: fix format warning on Windows

2020-06-29 Thread talshn
From: Tal Shnaiderman the struct rte_pci_addr defines domain as uint32_t variable however the PCI_PRI_FMT macro used for logging the struct sets the format of domain to uint16_t. The mismatch causes the following warning messages in Windows clang build: format specifies type 'unsigned short' bu

[dpdk-dev] [PATCH v10 07/10] drivers: fix incorrect meson import folder for Windows

2020-06-29 Thread talshn
From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs") C

[dpdk-dev] [PATCH v10 06/10] drivers: ignore pmdinfogen generation for Windows

2020-06-29 Thread talshn
From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/meson.

[dpdk-dev] [PATCH v10 08/10] bus/pci: introduce Windows support with stubs

2020-06-29 Thread talshn
From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v10 10/10] build: generate version.map file for MinGW on Windows

2020-06-29 Thread talshn
From: Tal Shnaiderman The MinGW build for Windows has special cases where exported function contain additional prefix: __emutls_v.per_lcore__* To avoid adding those prefixed functions to the version.map file the map_to_def.py script was modified to create a map file for MinGW with the needed ch

[dpdk-dev] [PATCH v10 09/10] bus/pci: support Windows with bifurcated drivers

2020-06-29 Thread talshn
From: Tal Shnaiderman Uses SetupAPI.h functions to scan PCI tree. Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. scanning currently supports types RTE_KDRV_NONE. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c

Re: [dpdk-dev] [PATCH v4 7/9] eal: add lcore init callbacks

2020-06-29 Thread Ananyev, Konstantin
> diff --git a/lib/librte_eal/common/eal_common_lcore.c > b/lib/librte_eal/common/eal_common_lcore.c > index a61824a779..52c46a4cea 100644 > --- a/lib/librte_eal/common/eal_common_lcore.c > +++ b/lib/librte_eal/common/eal_common_lcore.c > @@ -224,11 +224,114 @@ rte_socket_id_by_idx(unsigned in

Re: [dpdk-dev] [PATCH v5 1/3] lib/lpm: integrate RCU QSBR

2020-06-29 Thread Bruce Richardson
On Mon, Jun 29, 2020 at 01:56:07PM +0200, David Marchand wrote: > On Mon, Jun 29, 2020 at 10:03 AM Ruifeng Wang wrote: > > > > Currently, the tbl8 group is freed even though the readers might be > > using the tbl8 group entries. The freed tbl8 group can be reallocated > > quickly. This results in

Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd

2020-06-29 Thread Bruce Richardson
On Mon, Jun 29, 2020 at 12:09:20PM +0200, David Marchand wrote: > On Wed, May 27, 2020 at 4:58 PM Bruce Richardson > wrote: > > > > If the bonding pmd is disabled, all autotest associated with it should be > > disabled. However, some of those tests also depended upon the ring PMD so > > were place

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-29 Thread Andrew Rybchenko
Hi all, CC Adrien (I apologize for pulling you to the rte_flow API discussions once again, but may be you can find spare time and share your thoughts. Your opinion as an author and architect of the rte_flow API would be very useful and highly appreciated.) On 6/29/20 2:40 PM, Ori Kam wrote: > Hi

[dpdk-dev] [PATCH v2] common/octeontx2: fix seg fault on running procinfo

2020-06-29 Thread Harman Kalra
Segmentation fault has been observed while running procinfo with reset options i.e. --stats-reset and --xstats-reset. Reason is procinfo runs as a secondary process and tries to hold a lock which is part of struct mdev, which was not allocated as part of shared memory. Fixes: 5ca59711f771 ("common

Re: [dpdk-dev] [PATCH v4 2/2] eal: emulate glibc getentropy for initial random seed

2020-06-29 Thread Mattias Rönnblom
On 2020-04-23 01:42, Dan Gora wrote: > The getentropy() function was introduced into glibc v2.25 and so is > not available on all supported platforms. Previously, if DPDK was > compiled (using meson) on a system which has getentropy(), it would > introduce a dependency on glibc v2.25 which would p

Re: [dpdk-dev] [PATCH v4 0/2] eal: choose initial PRNG seed source at runtime

2020-06-29 Thread Mattias Rönnblom
On 2020-04-23 01:42, Dan Gora wrote: > Hi All, > > The following patches updates the rte_random subsystem to dynamically find > the best source of the initial seed to the PRNG at run time. > > The first patch enables dynamic checking for the rdseed instruction and > removes the requirement for it o

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-29 Thread Jerin Jacob
On Fri, Jun 26, 2020 at 6:07 PM Jerin Jacob wrote: > > On Fri, Jun 26, 2020 at 5:46 PM David Marchand > wrote: > > > > On Fri, Jun 26, 2020 at 2:06 PM Jerin Jacob wrote: > > > > > > On Fri, Jun 26, 2020 at 5:13 PM David Marchand > > > wrote: > > > > > > > > On Fri, Jun 26, 2020 at 1:16 PM Jerin

[dpdk-dev] [PATCH v3 0/3] vdpa/mlx5: optimize cpu utilization

2020-06-29 Thread Matan Azrad
Defines new event modes in order to schedule CQ polling. Timer thread is created in mode 0 and 1 in order to save CPU utilization. v2: Add devargs to control the events mode. v3: rebase. Improve mode 0 latency. Matan Azrad (3): vdpa/mlx5: optimize notification events vdpa/mlx5: optimize com

Re: [dpdk-dev] [PATCH v2 3/6] bus/mlx5_pci: add mlx5 PCI bus

2020-06-29 Thread Gaëtan Rivet
Hi Parav, On 21/06/20 19:11 +, Parav Pandit wrote: > Add mlx5 PCI bus which enables multiple mlx5 drivers to bind to single > pci device. > > Signed-off-by: Parav Pandit > --- > Changelog: > v1->v2: > - Address comments from Thomas and Gaetan > - Inheriting ret_pci_driver instead of rte_dr

[dpdk-dev] [PATCH v3 1/3] vdpa/mlx5: optimize notification events

2020-06-29 Thread Matan Azrad
When the virtio guest driver doesn't work with poll mode, the driver creates event mechanism in order to schedule completion notifications for each virtq burst traffic. When traffic comes to a virtq, a CQE will be added to the virtq CQ by the FW. The driver requests interrupt for the next CQE inde

[dpdk-dev] [PATCH v3 2/3] vdpa/mlx5: optimize completion queue poll

2020-06-29 Thread Matan Azrad
The vDPA driver uses a CQ in order to know when traffic works were completed by the HW. Each traffic burst completion adds a CQE to the CQ. When the vDPA driver detects CQEs in the CQ, it triggers the guest notification for the corresponding queue and consumes all of them. There is collapse feat

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-29 Thread Owen Hilyard
It seems that GENEVE is not supported in the version of scapy that is currently used. It is supported in the next version. I didn't want to make the decision to either force an update, spend time attempting to backport the protocol and then adding a way to automatically add that patch onto an exist

[dpdk-dev] [PATCH v3 3/3] vdpa/mlx5: control completion queue event mode

2020-06-29 Thread Matan Azrad
The CQ polling is necessary in order to manage guest notifications when the guest doesn't work with poll mode (callfd != -1). The CQ polling scheduling method can affect the host CPU utilization and the traffic bandwidth. Define 3 modes to control the CQ polling scheduling: 1. A timer thread whi

[dpdk-dev] [PATCH v3 1/6] vhost: support host notifier queue configuration

2020-06-29 Thread Matan Azrad
As an arrangement to per queue operations in the vDPA device it is needed to change the next experimental API: The API ``rte_vhost_host_notifier_ctrl`` was changed to be per queue instead of per device. A `qid` parameter was added to the API arguments list. Setting the parameter to the value RTE

[dpdk-dev] [PATCH v3 0/6] vhost: improve ready state

2020-06-29 Thread Matan Azrad
Due to the issue described in "vhost: improve device ready definition" patch here, we need to change the ready state definition in vhost device. To support the suggestion improvement there is update for the host notifier control API. Also need to skip access lock when vDPA device is configured.

[dpdk-dev] [PATCH v3 2/6] vhost: skip access lock when vDPA is configured

2020-06-29 Thread Matan Azrad
No need to take access lock in the vhost-user message handler when vDPA driver controls all the data-path of the vhost device. It allows the vDPA set_vring_state operation callback to configure guest notifications. Signed-off-by: Matan Azrad Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia

[dpdk-dev] [PATCH v3 4/6] vhost: handle memory hotplug with vDPA devices

2020-06-29 Thread Matan Azrad
Some vDPA drivers' basic configurations should be updated when the guest memory is hotplugged. Close vDPA device before hotplug operation and recreate it after the hotplug operation is done. Signed-off-by: Matan Azrad Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/v

[dpdk-dev] [PATCH v3 3/6] vhost: improve device readiness notifications

2020-06-29 Thread Matan Azrad
Some guest drivers may not configure disabled virtio queues. In this case, the vhost management never notifies the application and the vDPA device readiness because it waits to the device to be ready. The current ready state means that all the virtio queues should be configured regardless the ena

[dpdk-dev] [PATCH v3 5/6] vhost: notify virtq file descriptor update

2020-06-29 Thread Matan Azrad
When virtq call or kick file descriptors are changed in the device configuration when the queue is ready, the application and the vDPA driver should be notified to be aligned to the new file descriptors. Notify the state to be disabled before the file descriptor update and return it back to be ena

[dpdk-dev] [PATCH v3 6/6] vdpa/mlx5: support queue update

2020-06-29 Thread Matan Azrad
Last changes in vDPA device management by vhost library may cause queue ready state update after the device configuration. So, there is chance that some queue configuration information will be known only after the device was configured. Add support to reconfigure a queue after the device configur

Re: [dpdk-dev] [PATCH v2 0/4] one more step in makefiles deprecation

2020-06-29 Thread David Marchand
On Thu, Jun 25, 2020 at 11:43 PM Thomas Monjalon wrote: > > Some "make" usages are cleaned up in the documentation, > and an inevitable deprecation warning is printed when using "make". > > > * > NOTE: Lots of docs must be converted to meson > build, con

Re: [dpdk-dev] [PATCH v7 0/5] Introduce flow perf application

2020-06-29 Thread Thomas Monjalon
04/06/2020 15:34, Wisam Jaddo: > Add new application to test rte flow performance from: > - Insertion rate. > - Deletion rate. > - Memory consumption. > - PPS forward measurement. > > Unchanged comments: > - Prevent actions such as Queue from adding twice: > * Current design don't support add acti

Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide

2020-06-29 Thread Dharmik Thakkar
> On Jun 22, 2020, at 10:26 AM, Thomas Monjalon wrote: > > 19/06/2020 18:13, Dharmik Thakkar: >>> On Jun 19, 2020, at 10:43 AM, Thomas Monjalon wrote: >>> 19/06/2020 17:38, Dharmik Thakkar: > On Jun 17, 2020, at 2:48 PM, Thomas Monjalon wrote: > 17/06/2020 20:21, Ferruh Yigit: >>

Re: [dpdk-dev] [PATCH v4 6/9] eal: register non-EAL threads as lcores

2020-06-29 Thread Ananyev, Konstantin
> diff --git a/lib/librte_eal/common/eal_common_lcore.c > b/lib/librte_eal/common/eal_common_lcore.c > index 86d32a3dd7..a61824a779 100644 > --- a/lib/librte_eal/common/eal_common_lcore.c > +++ b/lib/librte_eal/common/eal_common_lcore.c > @@ -6,13 +6,15 @@ > #include > #include > > -#include

Re: [dpdk-dev] [PATCH v2 0/4] one more step in makefiles deprecation

2020-06-29 Thread Thomas Monjalon
29/06/2020 16:15, David Marchand: > On Thu, Jun 25, 2020 at 11:43 PM Thomas Monjalon wrote: > > > > Some "make" usages are cleaned up in the documentation, > > and an inevitable deprecation warning is printed when using "make". > > > > > > * > > NOTE: Lo

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-06-29 Thread Ori Kam
Hi All, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, June 29, 2020 4:12 PM > To: Ori Kam ; Jiawei(Jonny) Wang > ; Slava Ovsiienko ; > Matan Azrad > Cc: dev@dpdk.org; Thomas Monjalon ; Raslan > Darawsheh ; ian.sto...@intel.com; f...@redhat.com; > Adrien Mazarguil > Subje

Re: [dpdk-dev] [PATCH v5 4/4] eal/atomic: add wrapper for c11 atomic thread fence

2020-06-29 Thread Honnappa Nagarahalli
> > > diff --git a/lib/librte_eal/x86/include/rte_atomic.h > > > b/lib/librte_eal/x86/include/rte_atomic.h > > > index b9dcd30..bd256e7 100644 > > > --- a/lib/librte_eal/x86/include/rte_atomic.h > > > +++ b/lib/librte_eal/x86/include/rte_atomic.h > > > @@ -83,6 +83,23 @@ rte_smp_mb(void) > > > >

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-29 Thread Thomas Monjalon
29/06/2020 16:01, Owen Hilyard: > It seems that GENEVE is not supported in the version of scapy that is > currently used. It is supported in the next version. I didn't want to make > the decision to either force an update, spend time attempting to backport > the protocol and then adding a way to au

Re: [dpdk-dev] [EXT] Re: [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-29 Thread Harman Kalra
Acked-by: Harman Kalra On Mon, Jun 29, 2020 at 09:34:00AM +0800, Wei Hu (Xavier) wrote: > External Email > > -- > Hi, Heinrich Kuhn & Harman Kalra & Jerin Jacob & Nithin Dabilpuram & Kiran > Kumar K & > > Rasesh Mody & Shahed S

Re: [dpdk-dev] [PATCH v3 03/14] vhost: introduce vDPA devices class

2020-06-29 Thread Ferruh Yigit
On 6/26/2020 3:04 PM, Maxime Coquelin wrote: > This patch introduces vDPA device class. It will enable > application to iterate over the vDPA devices. > > Acked-by: Adrián Moreno > Signed-off-by: Maxime Coquelin <...> > +static int > +vdpa_dev_match(struct rte_vdpa_device *dev, > + c

Re: [dpdk-dev] [PATCH v3 08/14] vhost: remove useless vDPA API

2020-06-29 Thread Ferruh Yigit
On 6/26/2020 3:04 PM, Maxime Coquelin wrote: > vDPA is no more used outside of the vDPA internals, > so remove rte_vdpa_get_device() API that is now useless. > > Acked-by: Adrián Moreno > Signed-off-by: Maxime Coquelin <...> > diff --git a/lib/librte_vhost/rte_vhost_version.map > b/lib/librte

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-29 Thread Burakov, Anatoly
On 26-Jun-20 3:59 PM, Bruce Richardson wrote: When using statically linked DPDK binaries, the EAL checks the default PMD path and tries to load any drivers there, despite the fact that all drivers are normally linked into the binary. This behaviour can cause issues if the PMD path and lib dir is

[dpdk-dev] [PATCH v2 0/2] introduce asynchronous data path for vhost

2020-06-29 Thread patrick . fu
From: Patrick Fu Performing large memory copies usually takes up a major part of CPU cycles and becomes the hot spot in vhost-user enqueue operation. To offload expensive memory operations from the CPU, this patch set proposes to leverage DMA engines, e.g., I/OAT, a DMA engine in the Intel's proc

[dpdk-dev] [PATCH v2 1/2] vhost: introduce async enqueue registration API

2020-06-29 Thread patrick . fu
From: Patrick Fu This patch introduces registration/un-registration APIs for vhost async data enqueue operation. Together with the registration APIs implementations, data structures and async callback functions required for async enqueue data path are also defined. Signed-off-by: Patrick Fu ---

[dpdk-dev] [PATCH v2 2/2] vhost: introduce async enqueue for split ring

2020-06-29 Thread patrick . fu
From: Patrick Fu This patch implements async enqueue data path for split ring. 2 new async data path APIs are defined, by which applications can submit and poll packets to/from async engines. The async enqueue data leverages callback functions registered by applications to work with the async eng

Re: [dpdk-dev] [PATCH v10 01/10] eal: move OS common config objects

2020-06-29 Thread Tal Shnaiderman
> Subject: [PATCH v10 01/10] eal: move OS common config objects > > From: Tal Shnaiderman > > rte_eal_config_create(void) > { > + struct rte_config *config = rte_eal_get_configuration(); > + const struct internal_config *internal_conf = > + eal_get_internal_configuration

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-29 Thread Stephen Hemminger
On Mon, 29 Jun 2020 10:19:10 +0100 Bruce Richardson wrote: > On Mon, Jun 29, 2020 at 10:11:58AM +0100, Bruce Richardson wrote: > > On Fri, Jun 26, 2020 at 10:05:42AM -0700, Stephen Hemminger wrote: > > > On Fri, 26 Jun 2020 15:59:57 +0100 > > > Bruce Richardson wrote: > > > > > > > When usi

Re: [dpdk-dev] [PATCH v2 4/6] bus/mlx5_pci: register a PCI driver

2020-06-29 Thread Gaëtan Rivet
On 21/06/20 19:11 +, Parav Pandit wrote: > Create a mlx5 bus driver framework for invoking drivers of > multiple classes who have registered with the mlx5_pci bus > driver. > > Validate user class arguments for supported class combinations. > > Signed-off-by: Parav Pandit > --- > Changelog:

[dpdk-dev] [PATCH] net/mlx5: fix LACP action type casting

2020-06-29 Thread Shiri Kuzin
The mlx5_flow_lacp_miss flow rule for matching LACP traffic was added to steer LACP traffic to kernel. When setting the action type of rte_flow_action to MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS we get an error since the action is an enum of type mlx5_rte_flow_action_type. To solve this a casting o

[dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes

2020-06-29 Thread Konstantin Ananyev
v2: - update Release Notes (as per comments) Two new sync modes were introduced into rte_ring: relaxed tail sync (RTS) and head/tail sync (HTS). This change provides user with ability to select these modes for ring based mempool via mempool ops API. Signed-off-by: Konstantin Ananyev Acked-by: G

Re: [dpdk-dev] [PATCH] eal: don't use default library path for static binaries

2020-06-29 Thread Bruce Richardson
On Mon, Jun 29, 2020 at 08:41:46AM -0700, Stephen Hemminger wrote: > On Mon, 29 Jun 2020 10:19:10 +0100 > Bruce Richardson wrote: > > > On Mon, Jun 29, 2020 at 10:11:58AM +0100, Bruce Richardson wrote: > > > On Fri, Jun 26, 2020 at 10:05:42AM -0700, Stephen Hemminger wrote: > > > > On Fri, 26 J

Re: [dpdk-dev] [PATCH v3 03/14] vhost: introduce vDPA devices class

2020-06-29 Thread Maxime Coquelin
On 6/29/20 4:48 PM, Ferruh Yigit wrote: > On 6/26/2020 3:04 PM, Maxime Coquelin wrote: >> This patch introduces vDPA device class. It will enable >> application to iterate over the vDPA devices. >> >> Acked-by: Adrián Moreno >> Signed-off-by: Maxime Coquelin > > <...> > >> +static int >> +vd

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: fix 32-bit coremask logic

2020-06-29 Thread Jerin Jacob
On Tue, Jun 16, 2020 at 10:24 PM Harry van Haaren wrote: > > This commit fixes a bug in 32-bit environments when a core mask greater > than 32-bits is requested. The fix is to convert the bitmask logic to > 64 bits, aligning 64 and 32 bit implementations. > > Fixes: adb5d548 ("examples/eventdev_pi

Re: [dpdk-dev] [RFC v2 01/26] eal: rename terms used for DPDK lcores

2020-06-29 Thread Bruce Richardson
On Fri, Jun 05, 2020 at 03:57:46PM -0700, Stephen Hemminger wrote: > Replace the old use of master/slave lcore with more inclusive > name of initial/secondary lcore. The old visible API will > stay for now. > > Change master2slave to new init2worker and vice-versa. > > This patch breaks the expe

  1   2   >