On Fri, Jun 26, 2020 at 5:00 PM Jerin Jacob <jerinjac...@gmail.com> wrote: > > On Fri, Jun 26, 2020 at 8:18 PM David Marchand > <david.march...@redhat.com> wrote: > > > > This is a preparation step for dynamically unregistering threads. > > > > Since we explicitly allocate a per thread trace buffer in > > rte_thread_init, add an internal helper to free this buffer. > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > --- > > Note: I preferred renaming the current internal function to free all > > threads trace buffers (new name trace_mem_free()) and reuse the previous > > name (trace_mem_per_thread_free()) when freeing this buffer for a given > > thread. > > > > Changes since v2: > > - added missing stub for windows tracing support, > > - moved free symbol to exported (experimental) ABI as a counterpart of > > the alloc symbol we already had, > > > > Changes since v1: > > - rebased on master, removed Windows workaround wrt traces support, > > > +/** > > + * Uninitialize per-lcore info for current thread. > > + */ > > +void rte_thread_uninit(void); > > + > > Is it a public API? I guess not as it not adding in .map file. > If it is private API, Is n't it better to change as eal_thread_ like > another private API in eal_thread.h?
Before this series, we have: - rte_thread_ public APIs for both EAL and non-EAL threads (declared in rte_eal_interrupts.h and rte_lcore.h), - eal_thread_ internal APIs that apply to EAL threads (declared in eal_thread.h), I guess __rte_thread_ could do the trick and I will move this to eal_private.h. -- David Marchand
