[dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32

2020-06-23 Thread Ruifeng Wang
Expand vector PMD support to aarch32. Enable ixgbe PMD by default for armv7 make build. Signed-off-by: Ruifeng Wang --- config/defconfig_arm-armv7a-linuxapp-gcc | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 3 files changed, 4 insertio

[dpdk-dev] [PATCH v2 1/4] arch/arm: add vcopyq intrinsic for aarch32

2020-06-23 Thread Ruifeng Wang
vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic. This fixes build of examples/l3fwd for armv7. Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Ferruh Yigit --- lib/librte_eal/arm

[dpdk-dev] [PATCH v2 3/4] net/ixgbe: fix include of vector header file

2020-06-23 Thread Ruifeng Wang
The include of 'arm_neon.h' causes issues to old gcc and aarch32. Including 'rte_vect.h' instead fixes these issues. Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang --- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- 1 file cha

[dpdk-dev] [PATCH v2 4/4] net/i40e: add support for aarch32

2020-06-23 Thread Ruifeng Wang
Expand vector PMD support to aarch32. Enable i40e PMD by default for armv7 make build. Signed-off-by: Ruifeng Wang --- config/defconfig_arm-armv7a-linuxapp-gcc | 2 +- drivers/net/i40e/Makefile| 2 +- drivers/net/i40e/i40e_rxtx_vec_neon.c| 2 +- 3 files changed, 3 insertions(

Re: [dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file

2020-06-23 Thread Thomas Monjalon
23/06/2020 08:45, Tal Shnaiderman: > > 22/06/2020 09:55, tal...@mellanox.com: > > > +struct internal_config * > > > +rte_eal_get_internal_configuration(void) > > > +{ > > > + return &internal_config; > > > +} > > > > This function should be private to EAL, no rte_ prefix. > > When creating the ne

Re: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode

2020-06-23 Thread Phil Yang
> -Original Message- > From: dev On Behalf Of Jasvinder Singh > Sent: Monday, June 22, 2020 11:51 PM > To: dev@dpdk.org > Cc: cristian.dumitre...@intel.com > Subject: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode > > Softnic can be used like other virtual devices without > ne

[dpdk-dev] [PATCH] net/mlx5: fix host physical function representor naming

2020-06-23 Thread Viacheslav Ovsiienko
The new kernel adds the names like "pf0" for Host PCI physical function representor on Bluefield SmartNIC hosts. This patch provides correct HPF representor recognition over the kernel versions 5.7 and laters. The following port naming formats are supported: - missing physical port name (no sys

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread David Marchand
Hello Konstantin, On Mon, Jun 22, 2020 at 5:49 PM Ananyev, Konstantin wrote: > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > b/lib/librte_eal/common/eal_common_lcore.c > > index 86d32a3dd7..7db05428e7 100644 > > --- a/lib/librte_eal/common/eal_common_lcore.c > > +++ b/lib/librte_ea

Re: [dpdk-dev] [PATCH] net/mlx5: fix host physical function representor naming

2020-06-23 Thread Matan Azrad
From: Viacheslav Ovsiienko > Sent: Tuesday, June 23, 2020 10:49 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix host physical function representor naming > > The new kernel adds the names like "pf0" for Host PCI physical function >

[dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-06-23 Thread Phil Yang
Use c11 atomics with explicit ordering instead of the rte_atomic ops which enforce unnecessary barriers on aarch64. Signed-off-by: Phil Yang --- v3: Split from the patchset: http://patchwork.dpdk.org/cover/68159/ drivers/net/mlx5/mlx5_rxq.c | 2 +- drivers/net/mlx5/mlx5_rxtx.c | 16 +-

Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32

2020-06-23 Thread David Marchand
Hello Ruifeng, On Tue, Jun 23, 2020 at 9:00 AM Ruifeng Wang wrote: > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc > b/config/defconfig_arm-armv7a-linuxapp-gcc > index 9ecc2a526..9c6d387cf 100644 > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > +++ b/config/defconfig_arm-armv7a-linuxap

Re: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode

2020-06-23 Thread Singh, Jasvinder
> -Original Message- > From: Phil Yang > Sent: Tuesday, June 23, 2020 8:38 AM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode > > > -Original Message- > > From: dev On Behalf Of Jasvin

[dpdk-dev] [PATCH 2/3] net/mlx5: add default miss action to flow engine

2020-06-23 Thread Shiri Kuzin
The new action is an internal mlx5 action that will call the rdma-core function MLX5DV_FLOW_ACTION_DEFAULT_MISS. The default miss action will be used when a bond is configured to allow traffic related to the bond to be managed in the kernel. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad ---

[dpdk-dev] [PATCH 1/3] common/mlx5: add default miss action

2020-06-23 Thread Shiri Kuzin
Add dv_create_action_default_miss wrapper function for the action added to the rdma-core MLX5DV_FLOW_ACTION_DEFAULT_MISS. When a packet matches MLX5DV_FLOW_ACTION_DEFAULT_MISS action it is steered to the default miss of the verbs steering domain. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad

[dpdk-dev] [PATCH 3/3] net/mlx5: add new devarg for LACP packets control

2020-06-23 Thread Shiri Kuzin
The new devarg will control the steering of the lacp traffic. When setting dv_lacp_by_user = 0 the lacp traffic will be steered to kernel and managed there. When setting dv_lacp_by_user = 1 the lacp traffic will not be steered and the user will need to manage it. Signed-off-by: Shiri Kuzin Acked

[dpdk-dev] [PATCH 0/3] mlx5: LACP handling for bonded devices

2020-06-23 Thread Shiri Kuzin
When the driver has a bond configured, LACP traffic should be steered to kernel to manage the bond using a new rdma-core API. This is done by creating a new internal action and adding a new devarg that will allow the user to manage the bond and get lacp traffic if they wish. Shiri Kuzin (3):

Re: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 10:38 AM Singh, Jasvinder wrote: > > > > > -Original Message- > > From: Phil Yang > > Sent: Tuesday, June 23, 2020 8:38 AM > > To: Singh, Jasvinder ; dev@dpdk.org > > Cc: Dumitrescu, Cristian > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: restrict pointer aliasing for NEON vpmd

2020-06-23 Thread Maxime Coquelin
On 6/11/20 5:32 AM, Joyce Kong wrote: > Restrict pointer aliasing to allow the compiler to vectorize loops > more aggressively. > > With this patch, a 9.6% improvement is observed in throughput for > the virtio-net PVP case, and a 2.4% perf improvement in throughput > for the virtio-user PVP ca

Re: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode

2020-06-23 Thread Singh, Jasvinder
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 9:42 AM > To: Singh, Jasvinder > Cc: Phil Yang ; dev@dpdk.org; Dumitrescu, Cristian > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove softnic forward mode > > On Tue, Jun 23, 2020 at 10:38 AM Singh, Jasvi

[dpdk-dev] [PATCH v3] net/ice: initialize and update RSS based on user request

2020-06-23 Thread Junyu Jiang
Initialize and update RSS configure based on user request (rte_eth_rss_conf) from dev_configure and .rss_hash_update ops. All previous default configure has been removed. Signed-off-by: Junyu Jiang --- v2->v3: change the commit log Separate ipv4 and ipv6 Remove the call of ice_rem_vsi_rss_cfg()

Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support for aarch32

2020-06-23 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 4:37 PM > To: Ruifeng Wang > Cc: tho...@monjalon.net; Wei Zhao ; Jeff Guo > ; dev ; Yigit, Ferruh > ; Honnappa Nagarahalli > ; Juraj Linkeš > ; nd > Subject: Re: [dpdk-dev] [PATCH v2 2/4] net/ixgbe: add support fo

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
From: Maxime Coquelin: > On 6/22/20 5:51 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> On 6/22/20 3:43 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin: > Sent: Monday, June 22, 2020 3:33 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > >

Re: [dpdk-dev] [PATCH v1 1/2] net/virtio: restrict pointer aliasing for NEON vpmd

2020-06-23 Thread Phil Yang
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 23, 2020 4:48 PM > To: Joyce Kong ; jer...@marvell.com; > zhihong.w...@intel.com; xiaolong...@intel.com; Honnappa Nagarahalli > ; Phil Yang ; > Ruifeng Wang > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 1/2] net/virtio: rest

Re: [dpdk-dev] [PATCH v4 1/4] librte_ethdev: Introduce a function to release HW rings

2020-06-23 Thread Renata Saiakhova
Hi Ferruh, I added an INTERNAL block in .map file, that gives me an error: Build targets in project: 806 Found ninja-1.8.2 at /usr/bin/ninja [7/627] Linking target lib/librte_ethdev.so.20.0.3. FAILED: lib/librte_ethdev.so.20.0.3 ccache cc -o lib/librte_ethdev.so.20.0.3 'lib/lib@@rte_ethdev@sta/

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread Bruce Richardson
On Tue, Jun 23, 2020 at 09:49:18AM +0200, David Marchand wrote: > Hello Konstantin, > > On Mon, Jun 22, 2020 at 5:49 PM Ananyev, Konstantin > wrote: > > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > > b/lib/librte_eal/common/eal_common_lcore.c > > > index 86d32a3dd7..7db05428e7 100

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-06-23 Thread Sarosh Arif
Hello, This patch has been sitting around for more than 3 weeks. Is there something that needs to be done further for acceptance? Regards, Sarosh On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif wrote: > rte_exit should be called when the application exits due to > invalid EAL or application argumen

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 11:02 AM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 5:51 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: On 6/22/20 3:43 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> Sent: Monday, June 22, 2020 3:33 PM >> To: Matan Azr

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-06-23 Thread Pattan, Reshma
From: Sarosh Arif Sent: Tuesday, June 23, 2020 10:19 AM To: dev@dpdk.org; Pattan, Reshma Subject: Re: [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments Hello, This patch has been sitting around for more than 3 weeks. Is there something that needs

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 9:48 AM, Chengchang Tang wrote: > In common practice, PMD configure the rx_buf_size according to the data > room size of the object in mempool. But in fact the final value is related > to the specifications of hw, and its values will affect the number of > fragments in recieving pkts. >

[dpdk-dev] [PATCH v4 0/2] standardize devtools check scripts

2020-06-23 Thread Ciara Power
v4: - Merge doc patch into patch with code changes. - Simplified and reduced documentation and comments. v3: - Fix comments on v2. - Add patch to update contributor's guide. v2: Fix comments on v1. This patchset standardizes the checkpatches and check-git-log scripts to accept the same s

[dpdk-dev] [PATCH v4 2/2] devtools: added stats print

2020-06-23 Thread Ciara Power
When all checks are completed on the specified commit logs, the script indicates if all are valid, or if there were some failures. Signed-off-by: Ciara Power Acked-by: Ferruh Yigit --- v2: Added appropriate exit codes based on failure status. --- devtools/check-git-log.sh | 45

[dpdk-dev] [PATCH v4 1/2] devtools: standardize script arguments

2020-06-23 Thread Ciara Power
This patch modifies the arguments expected by the check-git-log script, to match the format of arguments for the checkpatches script. Both scripts now take certain argument options in the same format, making them easier to use. e.g. Both now take a commit ID range by "-r " The checkpatches help pr

[dpdk-dev] [PATCH v2] app/testpmd: remove softnic forward mode

2020-06-23 Thread Jasvinder Singh
Softnic can be used like other virtual devices without needing any special mode. Therefore, remove softnic mode from testpmd app. Documentation is updated as well. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v2 - merge softnic document update patch app/test-pmd/Makefile

Re: [dpdk-dev] [PATCH] doc: update softnic documentation

2020-06-23 Thread Singh, Jasvinder
> -Original Message- > From: dev On Behalf Of Jasvinder Singh > Sent: Monday, June 22, 2020 4:47 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] doc: update softnic documentation > > Update traffic management function parameters description and command >

Re: [dpdk-dev] [PATCH v3] net/ice: initialize and update RSS based on user request

2020-06-23 Thread Zhang, Qi Z
> -Original Message- > From: Jiang, JunyuX > Sent: Tuesday, June 23, 2020 4:33 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Su, Simei ; Jiang, JunyuX > > Subject: [PATCH v3] net/ice: initialize and update RSS based on user request > > Initialize and update RSS configure

Re: [dpdk-dev] [PATCH 00/10] net/ice: base code update for 20.08 batch 2

2020-06-23 Thread Yang, Qiming
Reviewed-by: Qiming Yang > -Original Message- > From: Zhang, Qi Z > Sent: Friday, June 19, 2020 12:25 > To: Yang, Qiming > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: RE: [PATCH 00/10] net/ice: base code update for 20.08 batch 2 > > > > > -Original Message- > > From: Yang, Qim

[dpdk-dev] [PATCH v2 2/6] security: add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Add support for DOCSIS protocol to rte_security library. This support currently comprises the combination of Crypto and CRC operations. A security operation definition is also added. This allow security protocol related parameters be specified at the operation level. For DOCSIS, these parameters i

[dpdk-dev] [PATCH v2 1/6] cryptodev: add security operation to crypto operation

2020-06-23 Thread David Coyle
Add a new security operation field to the crypto operation to allow protocol specific parameters be defined for a crypto operation. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- lib/librte_cryptodev/rte_crypto.h| 19 +-- lib/librte_cryptodev/rte_cryptodev

[dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Introduction This patchset adds support for the DOCSIS protocol to the DPDK Security API (rte_security), to be used by the AESNI-MB and QAT crypto devices to combine and accelerate Crypto and CRC functions of the DOCSIS protocol into a single operation. Performing these functions in

[dpdk-dev] [PATCH v2 4/6] crypto/qat: add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Add support to the QAT SYM PMD for the DOCSIS protocol, through the rte_security API. This, therefore, includes adding support for the rte_security API to this PMD. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- drivers/common/qat/Makefile | 3 + drivers/crypt

[dpdk-dev] [PATCH v2 3/6] crypto/aesni_mb: add support for DOCSIS protocol

2020-06-23 Thread David Coyle
Add support to the AESNI-MB PMD for the DOCSIS protocol, through the rte_security API. This, therefore, includes adding support for the rte_security API to this PMD. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- .../crypto/aesni_mb/aesni_mb_pmd_private.h| 19 +- drivers

[dpdk-dev] [PATCH v2 6/6] test/security: add DOCSIS capability check tests

2020-06-23 Thread David Coyle
Add unit tests for DOCSIS capabilitity checks. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- app/test/test_security.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 3076

[dpdk-dev] [PATCH v2 5/6] test/crypto: add DOCSIS security test cases

2020-06-23 Thread David Coyle
Add uplink and downlink DOCSIS unit test cases and vectors, to test the combined DOCSIS Crypto-CRC support that has been added to the rte_security and rte_cryptodev libraries. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- app/test/test_cryptodev.c | 552

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-23 Thread Wang, Xiao W
Hi, The original issue is with legacy QEMU (e.g.QEMUv2.6, with centos7.2 as guest kernel, without set_vring_status as an indicator). For a normal boot, the last 2 messages are set_vring_kick and set_vring_call, inside the set_vring_kick handling, virtio_is_ready() will reture true (because of th

Re: [dpdk-dev] [PATCH v2 1/3] examples/packet_ordering: free resources on exit

2020-06-23 Thread Pattan, Reshma
> -Original Message- > From: Sarosh Arif > Sent: Wednesday, June 17, 2020 5:01 AM > To: dev@dpdk.org; Richardson, Bruce ; > Mcnamara, John ; Pattan, Reshma > ; Varghese, Vipin > Cc: Sarosh Arif > Subject: [PATCH v2 1/3] examples/packet_ordering: free resources on exit > > Resources s

[dpdk-dev] [PATCH 0/8] add OCTEON TX2 lookaside IPsec support

2020-06-23 Thread Tejasree Kondoj
This series adds lookaside IPsec support in OCTEON TX2 PMD. Features supported: * IPv4 * ESP * Tunnel mode * AES-128/192/256-GCM This series is on top of http://patches.dpdk.org/patch/71638/ Tejasree Kondoj (4): net/octeontx2: move otx2_sec_session struct to otx2_security.h crypto/octeontx2:

[dpdk-dev] [PATCH 1/8] net/octeontx2: move otx2_sec_session struct to otx2_security.h

2020-06-23 Thread Tejasree Kondoj
This patch moves otx2_sec_session structure to otx2_security.h to make it common for inline and lookaside protocol Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_security.h | 21 + drivers/net/octeontx2/otx2_ethdev_sec.c| 1 + drivers/net/octeontx2/ot

[dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 52 drivers/crypto/octeontx2/otx2_ipsec_po.h | 119 ++ drivers/crypto/octeontx2/otx2_security.h | 2 + drivers/net/octeontx2/otx2_ethdev_sec.h

[dpdk-dev] [PATCH 5/8] crypto/octeontx2: add cryptodev sec misc callbacks

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 34 +-- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c b/drivers/crypto/octeontx2

[dpdk-dev] [PATCH 6/8] crypto/octeontx2: add cryptodev sec session create

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 466 +- drivers/crypto/octeontx2/otx2_ipsec_po.h | 295 +++ drivers/crypto/octeontx2/otx2_security.h | 9 + drivers/net/octe

[dpdk-dev] [PATCH 7/8] crypto/octeontx2: add cryptodev sec enqueue routine

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.h | 8 + drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 36 +++- drivers/crypto/octeontx2/otx2_ipsec_po.h | 6 + drivers/crypto/octeontx2/otx2_ipsec_po_o

[dpdk-dev] [PATCH 8/8] crypto/octeontx2: add cryptodev sec dequeue routine

2020-06-23 Thread Tejasree Kondoj
From: Vamsi Attunuru Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 37 +++ drivers/crypto/octeontx2/otx2_ipsec_po.h | 30 +++ 2 files changed, 67 insertions(+) diff --git a/drivers/crypto/octeo

[dpdk-dev] [PATCH 3/8] crypto/octeontx2: add cryptodev sec registration

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/Makefile | 1 + drivers/crypto/octeontx2/meson.build | 3 +- drivers/crypto/octeontx2/otx2_cryptodev.c | 12 - drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 46 +

[dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- .../octeontx2/otx2_cryptodev_capabilities.c | 108 ++ .../octeontx2/otx2_cryptodev_capabilities.h | 3 + drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 4 +- 3 files changed, 114 insertions(+), 1 deletion(-

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-23 Thread Neil Horman
On Mon, Jun 22, 2020 at 10:39:46PM +0300, Dmitry Kozlyuk wrote: > On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote: > > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: > [snip] > > > 1. No standard ELF or COFF module for Python > > > (amount of Python code without libelf on

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
From: Maxime Coquelin: > On 6/23/20 11:02 AM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> On 6/22/20 5:51 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin: > On 6/22/20 3:43 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> Sent: Mond

Re: [dpdk-dev] [RFC PATCH 0/2] pmdinfogen: rewrite in Python

2020-06-23 Thread Bruce Richardson
On Tue, Jun 23, 2020 at 07:28:06AM -0400, Neil Horman wrote: > On Mon, Jun 22, 2020 at 10:39:46PM +0300, Dmitry Kozlyuk wrote: > > On Mon, 22 Jun 2020 08:41:17 -0400, Neil Horman wrote: > > > On Mon, Jun 22, 2020 at 03:45:01AM +0300, Dmitry Kozlyuk wrote: > > [snip] > > > > > > 2. How much error-

Re: [dpdk-dev] [PATCH v4 1/4] librte_ethdev: Introduce a function to release HW rings

2020-06-23 Thread Ferruh Yigit
On 6/23/2020 10:11 AM, Renata Saiakhova wrote: > Hi Ferruh, > > I added an INTERNAL block in .map file, that gives me an error: > > Build targets in project: 806 > Found ninja-1.8.2 at /usr/bin/ninja > [7/627] Linking target lib/librte_ethdev.so.20.0.3. > FAILED: lib/librte_ethdev.so.20.0.3 > cca

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 11:14 AM Bruce Richardson wrote: > > On Tue, Jun 23, 2020 at 09:49:18AM +0200, David Marchand wrote: > > Hello Konstantin, > > > > On Mon, Jun 22, 2020 at 5:49 PM Ananyev, Konstantin > > wrote: > > > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > > > b/lib/li

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread Ananyev, Konstantin
Hi David, > > > diff --git a/lib/librte_eal/common/eal_common_lcore.c > > > b/lib/librte_eal/common/eal_common_lcore.c > > > index 86d32a3dd7..7db05428e7 100644 > > > --- a/lib/librte_eal/common/eal_common_lcore.c > > > +++ b/lib/librte_eal/common/eal_common_lcore.c > > > @@ -220,3 +221,38 @@ rte

[dpdk-dev] [PATCH] drivers/bus/vdev: corrected a typing error in header file

2020-06-23 Thread Muhammad Bilal
Here I have corrected a potential typing mistake in header file. while Uninitalizing the driver the comment was mentioning initializing instead of Uninitalizing in despription of parameter Fixes: d4a586d29e65 ("bus/vdev: move code from EAL into a new driver") Cc: jianfeng@intel.com Signed-of

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation

2020-06-23 Thread Ali Alnubani
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 5:43 PM > To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Ali Alnubani > ; orgerl...@mellanox.com; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com; jer

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-23 Thread Ali Alnubani
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 5:43 PM > To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Ali Alnubani > ; orgerl...@mellanox.com; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com; jer

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: enable empty polls in burst stats

2020-06-23 Thread Ali Alnubani
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 5:43 PM > To: dev@dpdk.org; honnappa.nagaraha...@arm.com; Ali Alnubani > ; orgerl...@mellanox.com; wenzhuo...@intel.com; > beilei.x...@intel.com; bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com; jer

[dpdk-dev] [PATCH v5 2/4] drivers/net: fix in igb and ixgbe HW rings memory

2020-06-23 Thread Renata Saiakhova
Delete memzones for HW rings in igb and ixgbe while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/igb_rxtx.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 68

[dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings

2020-06-23 Thread Renata Saiakhova
Free previously allocated memzone for HW rings Signed-off-by: Renata Saiakhova --- lib/librte_ethdev/rte_ethdev.c | 30 ++-- lib/librte_ethdev/rte_ethdev_driver.h| 17 ++ lib/librte_ethdev/rte_ethdev_version.map | 7 ++ 3 files changed, 52 inser

[dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation

2020-06-23 Thread Renata Saiakhova
igb and ixgbe and some other drivers allocate HW rings using rte_eth_dma_zone_reserve(), which checks first if the memzone exists for a given name, consisting of port id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id. If the memzone with a given name exists it is returne

[dpdk-dev] [PATCH v5 3/4] drivers/net: fix in i40e HW rings memory overlap

2020-06-23 Thread Renata Saiakhova
Delete memzones for HW rings in i40e while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/i40e/i40e_fdir.c | 3 +++ drivers/net/i40e/i40e_rxtx.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index d59399afe..3a8

[dpdk-dev] [PATCH v5 4/4] drivers/net: fix in em and ice HW rings memory overlap

2020-06-23 Thread Renata Saiakhova
Delete memzones for HW rings in em and ice while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/em_rxtx.c | 2 ++ drivers/net/ice/ice_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index 49c53712a..67

[dpdk-dev] [PATCH] net/iavf: fix uninitialized variable

2020-06-23 Thread Ferruh Yigit
This is observed with experimental gcc 11, although the older gcc versions don't complain about it, issue seems a valid one. gcc version 11.0.0 20200621 (experimental) (GCC) Build error .../drivers/net/iavf/iavf_ethdev.c: In function ‘iavf_dev_link_update’: .../drivers/net/iavf/iavf_ethdev.c:641:6

[dpdk-dev] [PATCH] doc: mark internal symbols in ethdev

2020-06-23 Thread Ferruh Yigit
The APIs are marked in the doxygen comment but better to mark the symbols too. This is planned for v20.11 release. Signed-off-by: Ferruh Yigit --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel

Re: [dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation

2020-06-23 Thread Ferruh Yigit
On 6/23/2020 2:42 PM, Renata Saiakhova wrote: > igb and ixgbe and some other drivers allocate HW rings using > rte_eth_dma_zone_reserve(), > which checks first if the memzone exists for a given name, consisting of port > id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id.

Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings

2020-06-23 Thread Ferruh Yigit
On 6/23/2020 2:42 PM, Renata Saiakhova wrote: > Free previously allocated memzone for HW rings > > Signed-off-by: Renata Saiakhova Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
Hi Matan, On 6/23/20 1:53 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/23/20 11:02 AM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: On 6/22/20 5:51 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 3:43 PM, Matan Azrad wrote: >>> >

Re: [dpdk-dev] [PATCH] net/mlx5: fix host physical function representor naming

2020-06-23 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, June 23, 2020 10:49 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix host physical function representor naming > > The new kernel adds the names like "pf0

Re: [dpdk-dev] [PATCH] doc: mark internal symbols in ethdev

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 4:49 PM, Ferruh Yigit wrote: > The APIs are marked in the doxygen comment but better to mark the > symbols too. This is planned for v20.11 release. > > Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 3:55 PM, Maxime Coquelin wrote: > Hi Matan, > > On 6/23/20 1:53 PM, Matan Azrad wrote: >> >> >> From: Maxime Coquelin: >>> On 6/23/20 11:02 AM, Matan Azrad wrote: From: Maxime Coquelin: > On 6/22/20 5:51 PM, Matan Azrad wrote: >> >> >> From: Maxime Coqu

Re: [dpdk-dev] [PATCH 0/3] improve MinGW-w64 support

2020-06-23 Thread Thomas Monjalon
22/06/2020 22:51, Kadam, Pallavi: > On 6/20/2020 3:35 PM, Dmitry Kozlyuk wrote: > > Following the discussion on the mailing list [1], clarify MinGW-w64 > > installation process and stop linking with pthread on Windows. > > Make Meson cross-file more general along the way. > > > > [1]: https://mail

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Stephen Hemminger
On Tue, 23 Jun 2020 14:48:54 +0800 Chengchang Tang wrote: > In common practice, PMD configure the rx_buf_size according to the data > room size of the object in mempool. But in fact the final value is related > to the specifications of hw, and its values will affect the number of > fragments in r

[dpdk-dev] [PATCH v2] net/af_xdp: optimisations to improve packet loss

2020-06-23 Thread Ciara Loftus
This commit makes some changes to the AF_XDP PMD in an effort to improve its packet loss characteristics. 1. In the case of failed transmission due to inability to reserve a tx descriptor, the PMD now pulls from the completion ring, issues a syscall in which the kernel attempts to complete outstan

Re: [dpdk-dev] [PATCH] net/af_xdp: optimisations to improve packet loss

2020-06-23 Thread Loftus, Ciara
> > On Fri, 12 Jun 2020 14:17:46 + > Ciara Loftus wrote: > > > This commit makes some changes to the AF_XDP PMD in an effort to > improve > > its packet loss characteristics. > > > > 1. In the case of failed transmission due to inability to reserve a tx > > descriptor, the PMD now pulls from

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 12:36 PM David Coyle wrote: > A number of approaches to combine DOCSIS Crypto and CRC functions have > been discussed in the DPDK community to date, namely: > 1) adding a new rte_accelerator API, to provide a generic interface for >combining operations of different type

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 23, 2020 4:56 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > Hi Matan, > > On 6/23/20 1:53 PM, Matan Azrad wrote: > > > > > > From: Maxime

Re: [dpdk-dev] [RFC][PATCH v2 2/3] ethdev: add API to convert raw timestamps to nsec

2020-06-23 Thread Slava Ovsiienko
Hi, Patrick > /**< @internal Function used to get the current value of the device clock. */ > @@ -730,6 +734,7 @@ struct eth_dev_ops { > eth_timesync_read_time timesync_read_time; /** Get the device > clock time. */ > eth_timesync_write_timetimesync_write_time; /** Set the dev

Re: [dpdk-dev] [RFC] [PATCH v1 0/3] pdump HW timestamps for mlx5

2020-06-23 Thread Slava Ovsiienko
Hi, Patrick. Not all rdma-core versions provide the - mlx5dv_get_clock_info(context, clock_info); - mlx5dv_ts_to_ns(clock_info, device_timestamp); With these versions we would get compilation/linkage error. There should be conditional compilation like it is done with other mlx5dv routines. Wit

Re: [dpdk-dev] [PATCH v3] bus/pci: fix VF bus error for memory access

2020-06-23 Thread Harman Kalra
On Mon, Jun 22, 2020 at 07:13:51PM +0800, Haiyue Wang wrote: > To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps > and block MMIO access on disabled memory, it will send a SIGBUS to the > application: > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread Coyle, David
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 3:52 PM > > > A number of approaches to combine DOCSIS Crypto and CRC functions > have > > been discussed in the DPDK community to date, namely: > > 1) adding a new rte_accelerator API, to provide a generic inter

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 4:52 PM, Matan Azrad wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, June 23, 2020 4:56 PM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> Hi Matan, >> >> On 6/23/

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 5:48 PM, Stephen Hemminger wrote: > On Tue, 23 Jun 2020 14:48:54 +0800 > Chengchang Tang wrote: > >> In common practice, PMD configure the rx_buf_size according to the data >> room size of the object in mempool. But in fact the final value is related >> to the specifications of hw, and

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 5:18 PM Coyle, David wrote: > > I guess https://patchwork.dpdk.org/project/dpdk/list/?series=9304 can be > > marked Superseded then. > > Thanks. > > [DC] Yes it can - I have tried to set it to Superseded but don't have > permissions to > do that - guess one of the Maintain

Re: [dpdk-dev] [PATCH v4 1/4] hash: add kv hash library

2020-06-23 Thread Ananyev, Konstantin
Hi Vladimir, > --- /dev/null > +++ b/lib/librte_hash/k32v64_hash.c > @@ -0,0 +1,277 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Intel Corporation > + */ > + > +#include > + > +#include > +#include > +#include > + > +#include "k32v64_hash.h" > + > +static inline int >

Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings

2020-06-23 Thread Andrew Rybchenko
Hi Renata, Looks good to me except to minor notes below. It is better to use: --to-cmd ./devtools/get-maintainer.sh --cc dev@dpdk.org to have required list of maintainers directly specified. On 6/23/20 4:42 PM, Renata Saiakhova wrote: > Free previously allocated memzone for HW rings > > Signed

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread Coyle, David
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 4:39 PM > > > I guess https://patchwork.dpdk.org/project/dpdk/list/?series=9304 > > > can be marked Superseded then. > > > Thanks. > > > > [DC] Yes it can - I have tried to set it to Superseded but don't have > > pe

Re: [dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows

2020-06-23 Thread Thomas Monjalon
18/06/2020 21:32, Ranjit Menon: > On 6/17/2020 11:55 PM, Fady Bader wrote: > > This patchset splits OS dependent EAL timer functions and implements them > > for windows. > > > > v2: > > * fixing styles and correctness errors. > > v3: > > * fixing correctness, get_tsc_freq was reimplement

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread David Marchand
On Tue, Jun 23, 2020 at 5:56 PM Coyle, David wrote: > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, June 23, 2020 4:39 PM > > > > I guess https://patchwork.dpdk.org/project/dpdk/list/?series=9304 > > > > can be marked Superseded then. > > > > Thanks. > > > > > > [DC]

Re: [dpdk-dev] [PATCH v2 0/6] add support for DOCSIS protocol

2020-06-23 Thread Coyle, David
> -Original Message- > From: David Marchand > Sent: Tuesday, June 23, 2020 5:22 PM > To: Coyle, David > > > > > I guess > > > > > https://patchwork.dpdk.org/project/dpdk/list/?series=9304 > > > > > can be marked Superseded then. > > > > > Thanks. > > > > > > > > [DC] Yes it can - I have t

[dpdk-dev] [PATCH] ethdev: verify reserved HW ring

2020-06-23 Thread Ferruh Yigit
Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based on name match, but other requested attributes are discarded. This may cause driver using a memzone with wrong size or alignment. Verify size, alignment and socket_id for matched memzone, and do not use memzone if any one of th

Re: [dpdk-dev] [PATCH] ethdev: verify reserved HW ring

2020-06-23 Thread Andrew Rybchenko
On 6/23/20 7:41 PM, Ferruh Yigit wrote: > Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based > on name match, but other requested attributes are discarded. > This may cause driver using a memzone with wrong size or alignment. > > Verify size, alignment and socket_id for matche

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-23 Thread Andrew Rybchenko
On 6/22/20 4:25 PM, David Marchand wrote: > DPDK allows calling some part of its API from a non-EAL thread but this > has some limitations. > OVS (and other applications) has its own thread management but still > want to avoid such limitations by hacking RTE_PER_LCORE(_lcore_id) and > faking EAL th

Re: [dpdk-dev] [PATCH v3 9/9] mempool/bucket: handle non-EAL lcores

2020-06-23 Thread Andrew Rybchenko
On 6/22/20 4:25 PM, David Marchand wrote: > Convert to new lcore API to support non-EAL lcores. > > Signed-off-by: David Marchand > --- > drivers/mempool/bucket/rte_mempool_bucket.c | 131 > 1 file changed, 82 insertions(+), 49 deletions(-) > > diff --git a/drivers/mempool/

  1   2   >