Hello,
This patch has been sitting around for more than 3 weeks. Is there
something that needs to be done further for acceptance?
Regards,
Sarosh
On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif <sarosh.a...@emumba.com> wrote:
> rte_exit should be called when the application exits due to
> invalid EAL or application arguments.
>
> Fixes: 850f3733f840 ("examples/packet_ordering: new sample app")
> Cc: sergio.gonzalez.mon...@intel.com
>
> Signed-off-by: Sarosh Arif <sarosh.a...@emumba.com>
> ---
> examples/packet_ordering/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/packet_ordering/main.c
> b/examples/packet_ordering/main.c
> index b397b318e..edaf810d9 100644
> --- a/examples/packet_ordering/main.c
> +++ b/examples/packet_ordering/main.c
> @@ -675,7 +675,7 @@ main(int argc, char **argv)
> /* Initialize EAL */
> ret = rte_eal_init(argc, argv);
> if (ret < 0)
> - return -1;
> + rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n");
>
> argc -= ret;
> argv += ret;
> @@ -683,7 +683,7 @@ main(int argc, char **argv)
> /* Parse the application specific arguments */
> ret = parse_args(argc, argv);
> if (ret < 0)
> - return -1;
> + rte_exit(EXIT_FAILURE, "Invalid packet_ordering
> arguments\n");
>
> /* Check if we have enought cores */
> if (rte_lcore_count() < 3)
> --
> 2.17.1
>
>
