> -----Original Message-----
> From: Jiang, JunyuX <junyux.ji...@intel.com>
> Sent: Tuesday, June 23, 2020 4:33 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Su, Simei <simei...@intel.com>; Jiang, JunyuX
> <junyux.ji...@intel.com>
> Subject: [PATCH v3] net/ice: initialize and update RSS based on user request
>
> Initialize and update RSS configure based on user request
> (rte_eth_rss_conf) from dev_configure and .rss_hash_update ops.
> All previous default configure has been removed.
>
> Signed-off-by: Junyu Jiang <junyux.ji...@intel.com>
>
> ---
> v2->v3:
> change the commit log
> Separate ipv4 and ipv6
> Remove the call of ice_rem_vsi_rss_cfg()
>
> v1->v2:
> remove gtpu and pppoe/pppod configuration from rss init
> ---
> drivers/net/ice/ice_ethdev.c | 169 +++++++++++++++++++++--------------
> drivers/net/ice/ice_ethdev.h | 2 +
> 2 files changed, 104 insertions(+), 67 deletions(-)
>
...
> + if (rss_conf->rss_hf == 0)
> + return -EINVAL;
This looks not correct, user may only want to update hash key but without any
RSS configure, just return success here.
> +
> + /* RSS hash configuration */
> + ice_rss_hash_set(pf, rss_conf->rss_hf);
> +
> return 0;
> }
>
