Re: [dpdk-dev] [RFC] doc: change to diverse and inclusive language

2020-06-05 Thread Luca Boccassi
On Thu, 2020-06-04 at 14:02 -0700, Stephen Hemminger wrote: > For diversity reasons, the DPDK should take every effort > to eliminate master and slave terminology. The actual code change > is just syntax, but it has bigger impacts. > > Lets announce this now and do it in the next API changing > re

[dpdk-dev] [PATCH 2/4] net/ice: add redirect support for VSI list rule

2020-06-05 Thread Wei Zhao
This patch enable redirect switch rule of vsi list type. Fixes: 397b4b3c5095 ("net/ice: enable flow redirect on switch") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH 0/4] enable more PPPoE packet type for switch

2020-06-05 Thread Wei Zhao
1. add more support for switch parser of pppoe packet. 2. add redirect support for VSI list rule 3. add check for NVGRE protocol 4. support flow for specific L4 type This patchset is based on: [1] https://patches.dpdk.org/cover/70762/ : net/ice: base code update Depends-on: series-10300 Wei Zhao

[dpdk-dev] [PATCH 3/4] net/ice: add check for NVGRE protocol

2020-06-05 Thread Wei Zhao
This patch add check for protocol type of IPv4 packet, it need to update tunnel type when NVGRE is in payload. Fixes: 6bc7628c5e0b ("net/ice: change default tunnel type") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- drivers/net/ice/ice_switch_filter.c | 7 ++- 1 file changed, 6 insertion

[dpdk-dev] [PATCH 1/4] net/ice: add support more PPPoE packet type for switch

2020-06-05 Thread Wei Zhao
This patch add more support for switch parser of pppoe packet, it enable parse tcp/udp L4 layer and ipv4/ipv6 L3 layer parser for pppoe payload, so we can use L4 dst/src port and L3 ip address as input set for switch filter pppoe related rule. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_swit

[dpdk-dev] [PATCH 4/4] net/ice: support switch flow for specific L4 type

2020-06-05 Thread Wei Zhao
This patch add more specific tunnel type for ipv4/ipv6 packet, it enable tcp/udp layer of ipv4/ipv6 as L4 payload but without L4 dst/src port number as input set for the switch filter rule. Fixes: 47d460d63233 ("net/ice: rework switch filter") Cc: sta...@dpdk.org Signed-off-by: Wei Zhao --- dri

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-05 Thread Bruce Richardson
On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote: > 04/06/2020 13:12, Andrey Vesnovaty: > > Thomas Monjalon wrote: > > > 20/05/2020 11:18, Andrey Vesnovaty: > > > We had "create", "destroy", "query", but no "modify" capability. > > > The new API is adding 2 things in my opinion: > >

[dpdk-dev] [PATCH] test/crypto: change cipher offset for esn vector

2020-06-05 Thread Ankur Dwivedi
In the IPSEC ESN test vector the cipher offset for encryption should be 8 bytes which is the size of esp header. This patch also changes the ciphertext and the digest reference data against which the operaton result is validated. Fixes: 699741912d71 ("test/crypto: add case for auth only trailer")

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-05 Thread Thomas Monjalon
05/06/2020 10:30, Bruce Richardson: > On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote: > > 04/06/2020 13:12, Andrey Vesnovaty: > > > Thomas Monjalon wrote: > > > > 20/05/2020 11:18, Andrey Vesnovaty: > > > > We had "create", "destroy", "query", but no "modify" capability. > > > > T

Re: [dpdk-dev] [RFC] doc: change to diverse and inclusive language

2020-06-05 Thread Bruce Richardson
On Fri, Jun 05, 2020 at 08:54:47AM +0100, Luca Boccassi wrote: > On Thu, 2020-06-04 at 14:02 -0700, Stephen Hemminger wrote: > > For diversity reasons, the DPDK should take every effort > > to eliminate master and slave terminology. The actual code change > > is just syntax, but it has bigger impac

Re: [dpdk-dev] [PATCH] net/i40e: enable i40e NEON vector PMD in meson

2020-06-05 Thread Bruce Richardson
On Fri, Jun 05, 2020 at 01:20:55PM +0800, Ruifeng Wang wrote: > The i40e neon vector implementation is not compiled with meson. > Add the file to meson for Arm platform. > > Cc: sta...@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli >

Re: [dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-05 Thread Wei Hu (Xavier)
On 2020/6/5 0:56, Ferruh Yigit wrote: On 6/3/2020 10:32 AM, Wei Hu (Xavier) wrote: From: Hongbo Zheng Base on hns3 network engine, when the rte_eth_tx_burst API is called by Upper Level Process, if PKT_TX_TCP_SEG flag is set and tso_segsz is 0 in the input parameter structure rte_mbuf, hns3

Re: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror

2020-06-05 Thread Ferruh Yigit
On 6/5/2020 3:57 AM, Wei Hu (Xavier) wrote: > > > On 2020/6/5 0:30, Ferruh Yigit wrote: >> On 6/4/2020 7:22 AM, Wei Hu (Xavier) wrote: >>> Currently, there are coverity defect warnings as blow: >>> Coverity issue: >>>In nic_stats_clear function: >>> CID 290021 (#1 of 1): Argument cannot

Re: [dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-05 Thread Ferruh Yigit
On 6/5/2020 9:50 AM, Wei Hu (Xavier) wrote: > > > On 2020/6/5 0:56, Ferruh Yigit wrote: >> On 6/3/2020 10:32 AM, Wei Hu (Xavier) wrote: >>> From: Hongbo Zheng >>> >>> Base on hns3 network engine, when the rte_eth_tx_burst API is called >>> by Upper Level Process, if PKT_TX_TCP_SEG flag is set an

Re: [dpdk-dev] [PATCH v 0/4] bugfixes for hns3 PMD driver

2020-06-05 Thread Ferruh Yigit
On 6/3/2020 10:31 AM, Wei Hu (Xavier) wrote: > This series are bugfixes for hns3 PMD driver. > > Chengchang Tang (2): > net/hns3: remove unsupported VLAN capabilities > net/hns3: fix VLAN strip configuration when setting a PVID > > Hongbo Zheng (1): > net/hns3: add checking tso segsz when s

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Gaëtan Rivet
On 04/06/20 18:04 -0700, Stephen Hemminger wrote: > I have a full patch that replaces the master/slave lcore > naming (widely used in DPDK) with a better primary/secondary naming. > > For now this is just a trial balloon to see what the impact would > look like. The change mostly automated so like

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: enable i40e NEON vector PMD in meson

2020-06-05 Thread Ferruh Yigit
On 6/5/2020 9:36 AM, Bruce Richardson wrote: > On Fri, Jun 05, 2020 at 01:20:55PM +0800, Ruifeng Wang wrote: >> The i40e neon vector implementation is not compiled with meson. >> Add the file to meson for Arm platform. >> >> Cc: sta...@dpdk.org >> >> Reported-by: David Marchand >> Signed-off-by: R

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Ananyev, Konstantin
> > On 04/06/20 18:04 -0700, Stephen Hemminger wrote: > > I have a full patch that replaces the master/slave lcore > > naming (widely used in DPDK) with a better primary/secondary naming. > > > > For now this is just a trial balloon to see what the impact would > > look like. The change mostly aut

Re: [dpdk-dev] [PATCH v6 02/11] eal: introduce internal wrappers for file operations

2020-06-05 Thread Neil Horman
On Fri, Jun 05, 2020 at 03:16:03AM +0300, Dmitry Kozlyuk wrote: > On Thu, 4 Jun 2020 17:07:07 -0400 > Neil Horman wrote: > > > On Wed, Jun 03, 2020 at 03:34:03PM +0300, Dmitry Kozlyuk wrote: > > > On Wed, 3 Jun 2020 08:07:59 -0400 > > > Neil Horman wrote: > > > > > > [snip] > > > > > +int > >

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Bruce Richardson
On Fri, Jun 05, 2020 at 12:43:00PM +0200, Gaëtan Rivet wrote: > On 04/06/20 18:04 -0700, Stephen Hemminger wrote: > > I have a full patch that replaces the master/slave lcore > > naming (widely used in DPDK) with a better primary/secondary naming. > > > > For now this is just a trial balloon to se

Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status textrepresentation

2020-06-05 Thread Ferruh Yigit
On 5/27/2020 8:45 AM, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Dyukov >> Sent: Tuesday, May 26, 2020 9:10 PM >> >> This commit add function which treat link status structure >> and format it to text representation. >> >> Signed-off-by: Ivan Dyukov >> --- >>

[dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-06-05 Thread Sarosh Arif
rte_exit should be called when the application exits due to invalid EAL or application arguments. Fixes: 850f3733f840 ("examples/packet_ordering: new sample app") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 4 ++-- 1 file changed, 2 inse

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-05 Thread Juraj Linkeš
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 4, 2020 3:30 PM > To: Juraj Linkeš ; Thomas Monjalon > > Cc: arybche...@solarflare.com; dev@dpdk.org; Honnappa Nagarahalli > > Subject: Re: [PATCH] ethdev: fix dpdk gcc build on Arm > > On 6/4/2020 1:55 PM, Juraj Linkeš

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-05 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Thursday, June 4, 2020 3:42 PM > To: Juraj Linkeš > Cc: Ferruh Yigit ; Thomas Monjalon > ; arybche...@solarflare.com; dev@dpdk.org; > Honnappa Nagarahalli > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm > > On T

Re: [dpdk-dev] [PATCH v2] examples/l2fwd: free resources in case of error

2020-06-05 Thread Muhammad Bilal
Is there anything else to be done for acceptance? So that this problem can be removed from other examples. On Tue, May 12, 2020 at 6:57 PM Muhammad Bilal wrote: > > Bugzilla ID: 437 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: bruce.richard...@intel.com > Cc: vipin.vargh...@intel.com > Cc: jgra

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Gaëtan Rivet
On 05/06/20 12:28 +0100, Bruce Richardson wrote: > On Fri, Jun 05, 2020 at 12:43:00PM +0200, Gaëtan Rivet wrote: > > On 04/06/20 18:04 -0700, Stephen Hemminger wrote: > > > I have a full patch that replaces the master/slave lcore > > > naming (widely used in DPDK) with a better primary/secondary na

[dpdk-dev] [PATCH v1 00/12] enable DCF datapath configuration

2020-06-05 Thread Ting Xu
This patchset adds support to configure DCF datapath, including Rx/Tx queues setup, start and stop, device configuration, RSS and flexible descriptor RXDID initialization and MAC filter setup. Qi Zhang (11): net/ice: init RSS and supported RXDID in DCF net/ice: complete device info get in DCF

[dpdk-dev] [PATCH v1 02/12] net/ice: complete device info get in DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add support to get complete device information for DCF, including Rx/Tx offload capabilities and default configuration. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf_ethdev.c | 72 ++-- 1 file changed, 69 insertions(+), 3 deletions(-) diff --gi

[dpdk-dev] [PATCH v1 03/12] net/ice: complete dev configure in DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Enable device configuration function in DCF. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index 7f24ef81a..e8bed1362 100644 --- a/driv

[dpdk-dev] [PATCH v1 05/12] net/ice: add stop flag for device start / stop

2020-06-05 Thread Ting Xu
From: Qi Zhang Add stop flag for DCF device start and stop. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf_ethdev.c | 12 drivers/net/ice/ice_dcf_parent.c | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev

[dpdk-dev] [PATCH v1 04/12] net/ice: complete queue setup in DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Delete original DCF queue setup functions and use ice queue setup and release functions instead. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf_ethdev.c | 42 +++- drivers/net/ice/ice_dcf_ethdev.h | 3 --- drivers/net/ice/ice_dcf_parent.c | 7 +

[dpdk-dev] [PATCH v1 01/12] net/ice: init RSS and supported RXDID in DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Enable RSS parameters initialization and get the supported flexible descriptor RXDIDs bitmap from PF during DCF init. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c | 54 ++- drivers/net/ice/ice_dcf.h | 3 +++ 2 files changed, 56 inser

[dpdk-dev] [PATCH v1 07/12] net/ice: init RSS during DCF start

2020-06-05 Thread Ting Xu
From: Qi Zhang Enable RSS initialization during DCF start. Add RSS LUT and RSS key configuration functions. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c| 123 +++ drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 14 +++-

[dpdk-dev] [PATCH v1 09/12] net/ice: add queue start and stop for DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add queue start and stop in DCF. Support queue enable and disable through virtual channel. Add support for Rx queue mbufs allocation and queue reset. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c| 57 ++ drivers/net/ice/ice_dcf.h| 3 +- drivers/net

[dpdk-dev] [PATCH v1 08/12] net/ice: add queue config in DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add queues and Rx queue irqs configuration during device start in DCF. The setup is sent to PF via virtchnl. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c| 109 +++ drivers/net/ice/ice_dcf.h| 6 ++ drivers/net/ice/ice_dcf_ethdev.

[dpdk-dev] [PATCH v1 06/12] net/ice: add Rx queue init in DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Enable Rx queues initialization during device start in DCF. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 83 2 files changed, 84 insertions(+) diff --git a/drivers/net/ice/ice_dcf.h b/dr

[dpdk-dev] [PATCH v1 11/12] net/ice: set MAC filter during dev start for DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add support to add and delete MAC address filter in DCF. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c| 42 drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_ethdev.c | 7 ++ 3 files changed, 50 insertions(+)

[dpdk-dev] [PATCH v1 10/12] net/ice: enable stats for DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add support to get and reset Rx/Tx stats in DCF. Query stats from PF. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_dcf.c| 27 drivers/net/ice/ice_dcf.h| 4 ++ drivers/net/ice/ice_dcf_ethdev.c | 102 +++ 3 files changed,

[dpdk-dev] [PATCH v1 12/12] doc: enable DCF datapath configuration

2020-06-05 Thread Ting Xu
Add doc for DCF datapath configuration in DPDK 20.08 release note. Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_20_08.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index 39064afbe..3cda6111

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-05 Thread Bruce Richardson
On Fri, Jun 05, 2020 at 12:00:56PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, June 4, 2020 3:42 PM > > To: Juraj Linkeš > > Cc: Ferruh Yigit ; Thomas Monjalon > > ; arybche...@solarflare.com; dev@dpdk.org; > > Honnappa Nagarahall

[dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask

2020-06-05 Thread Sarosh Arif
Giving invalid or zero portmask as command line option to packet_ordering application will have an unexpected response. The reason behind this is that parse_portmask's return value is stored in a variable called portmask.The data type of portmask is unsigned int, hence returning -1 in case of zer

Re: [dpdk-dev] [PATCH v1 12/12] doc: enable DCF datapath configuration

2020-06-05 Thread Ye Xiaolong
Hi, Ting On 06/05, Ting Xu wrote: >Add doc for DCF datapath configuration in DPDK 20.08 release note. > It'd be better to also add some document update in ice.rst. Thanks, Xiaolong >Signed-off-by: Ting Xu >--- > doc/guides/rel_notes/release_20_08.rst | 5 + > 1 file changed, 5 insertions(+)

Re: [dpdk-dev] [PATCH v2] net/axgbe: add RSS reta/hash query and update

2020-06-05 Thread Ferruh Yigit
On 6/4/2020 6:27 AM, Somalapuram, Amaranath wrote: <...> > -Original Message- > From: Namburu, Chandu-babu > Sent: Friday, May 29, 2020 5:19 PM > To: dev@dpdk.org > Cc: Somalapuram, Amaranath > Subject: [PATCH v2] net/axgbe: add RSS reta/hash query and update > > From: Chandu Babu N >

Re: [dpdk-dev] [PATCH v1] net/axgbe: enable IEEE 1588 PTP support for axgbe

2020-06-05 Thread Ferruh Yigit
On 6/1/2020 1:57 PM, selwin.sebast...@amd.com wrote: > From: Selwin Sebastian > > Add ethdev APIs to support PTP timestamping For the patch title, "net/axgbe: " already says the change is in the 'axgbe' driver, no need to duplicate " .. support for axgbe". <...> > +static inline uint64_t > +d

Re: [dpdk-dev] [PATCH v1 03/12] net/ice: complete dev configure in DCF

2020-06-05 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Enable device configuration function in DCF. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_dcf_ethdev.c | 9 + > 1 file changed, 9 insertions(+) > >diff --git a/drivers/net/ice/ice_dcf_ethdev.c >b/drivers/net/ice/ice_dcf_ethdev.c >index

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Stephen Hemminger
On Fri, 5 Jun 2020 12:43:00 +0200 Gaëtan Rivet wrote: > On 04/06/20 18:04 -0700, Stephen Hemminger wrote: > > I have a full patch that replaces the master/slave lcore > > naming (widely used in DPDK) with a better primary/secondary naming. > > > > For now this is just a trial balloon to see what

Re: [dpdk-dev] [PATCH v1 07/12] net/ice: init RSS during DCF start

2020-06-05 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Enable RSS initialization during DCF start. Add RSS LUT and >RSS key configuration functions. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_dcf.c| 123 +++ > drivers/net/ice/ice_dcf.h| 1 + > drivers/n

Re: [dpdk-dev] mlx5 & pdump: convert HW timestamps to nanoseconds

2020-06-05 Thread Slava Ovsiienko
> -Original Message- > From: PATRICK KEROULAS > Sent: Friday, June 5, 2020 3:10 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Vivien Didelot ; Shahaf > Shuler ; Raslan Darawsheh > ; Matan Azrad > Subject: Re: [dpdk-dev] mlx5 & pdump: convert HW timestamps to > nanoseconds > > On Wed, Jun 3,

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Stephen Hemminger
On Fri, 5 Jun 2020 11:14:50 + "Ananyev, Konstantin" wrote: > > organization is a little specific, with an lcore that does most init work > > and spawns the others, but then runs the application like all others. > > > > I'd propose instead leader lcore - there is this idea that the leader > >

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Wiles, Keith
> On Jun 5, 2020, at 11:33 AM, Stephen Hemminger > wrote: > > On Fri, 5 Jun 2020 11:14:50 + > "Ananyev, Konstantin" wrote: > >>> organization is a little specific, with an lcore that does most init work >>> and spawns the others, but then runs the application like all others. >>> >>> I

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Stephen Hemminger
On Fri, 5 Jun 2020 17:10:05 + "Wiles, Keith" wrote: > >>> > >>> I'd propose instead leader lcore - there is this idea that the leader > >>> is still a member of the team and will participate in the work. > >>> > >>> Leader / worker? > >>> > >> > >> I personally doubt such changes are ne

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-06-05 Thread Stephen Hemminger
On Thu, 4 Jun 2020 10:17:31 -0700 Stephen Hemminger wrote: > The code in rte_cuckoo_hash multi-writer support is broken if write > operations are called from a non-EAL thread. > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL > thread and that leads to using wrong local cache.

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Wiles, Keith
> On Jun 5, 2020, at 12:45 PM, Stephen Hemminger > wrote: > > On Fri, 5 Jun 2020 17:10:05 + > "Wiles, Keith" wrote: > > > I'd propose instead leader lcore - there is this idea that the leader > is still a member of the team and will participate in the work. > > Lea

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Stephen Hemminger
On Fri, 5 Jun 2020 19:23:52 + "Wiles, Keith" wrote: > > On Jun 5, 2020, at 12:45 PM, Stephen Hemminger > > wrote: > > > > On Fri, 5 Jun 2020 17:10:05 + > > "Wiles, Keith" wrote: > > > > > > I'd propose instead leader lcore - there is this idea that the leader > > is st

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Wiles, Keith
> On Jun 5, 2020, at 2:53 PM, Stephen Hemminger > wrote: > > On Fri, 5 Jun 2020 19:23:52 + > "Wiles, Keith" wrote: > >>> On Jun 5, 2020, at 12:45 PM, Stephen Hemminger >>> wrote: >>> >>> On Fri, 5 Jun 2020 17:10:05 + >>> "Wiles, Keith" wrote: >>> >>> >>> I'd propose in

Re: [dpdk-dev] [RFC] doc: change to diverse and inclusive language

2020-06-05 Thread Aaron Conole
Stephen Hemminger writes: > For diversity reasons, the DPDK should take every effort > to eliminate master and slave terminology. The actual code change > is just syntax, but it has bigger impacts. > > Lets announce this now and do it in the next API changing > release. > --- Okay. Usually, I a

[dpdk-dev] [RFC v2 02/26] kni: fix reference to master/slave process

2020-06-05 Thread Stephen Hemminger
In DPDK, the correct terms for process are primary/secondary. This is bugfix, not a change in terms for new release. Fixes: f2e7592c474c ("kni: fix multi-process support") Signed-off-by: Stephen Hemminger --- lib/librte_kni/rte_kni.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[dpdk-dev] [RFC v2 00/26] Change references to master/slave to

2020-06-05 Thread Stephen Hemminger
This set of patches changes the API and conventions around referring to DPDK lcores. The first patch changes rte_get_master_lcore_id and related calls. The rest fix the DPDK to use the new naming. The last patch marks the old names as deprecated. My preferred option would be to do the rest of the

[dpdk-dev] [RFC v2 01/26] eal: rename terms used for DPDK lcores

2020-06-05 Thread Stephen Hemminger
Replace the old use of master/slave lcore with more inclusive name of initial/secondary lcore. The old visible API will stay for now. Change master2slave to new init2worker and vice-versa. This patch breaks the expected practice for new API's. The new rte_get_initial_lcore() will not go through

[dpdk-dev] [RFC v2 03/26] bbdev: rename master to initial lcore

2020-06-05 Thread Stephen Hemminger
Conform to new API. Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index fb38dc3a72cb..06288e7f8add 100644 --- a/examples/bbdev_app/main.c +++

[dpdk-dev] [RFC v2 05/26] drivers: replace master/slave terminolgy

2020-06-05 Thread Stephen Hemminger
Replace rte_get_master_lcore() with rte_get_initial_lcore(). Replace RTE_LCORE_FOREACH_SLAVE with RTE_LCORE_FOREACH_WORKER Signed-off-by: Stephen Hemminger --- drivers/bus/dpaa/dpaa_bus.c | 2 +- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 6 +++--- drivers/net/bnxt/bnxt_ring

[dpdk-dev] [RFC v2 04/26] librte_power: change reference to rte_master_lcore

2020-06-05 Thread Stephen Hemminger
New API name is rte_get_initial_lcore() Signed-off-by: Stephen Hemminger --- lib/librte_power/rte_power_empty_poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c index 70c07b1533f3..d54a09b9

[dpdk-dev] [RFC v2 07/26] examples/bond: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Change the references to master lcore. For now, leave refernces to slave for bonding since that is part of the API not addressed yet. Signed-off-by: Stephen Hemminger --- examples/bond/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/bond/main.c b/examp

[dpdk-dev] [RFC v2 06/26] examples/distrutor: rename master to initial

2020-06-05 Thread Stephen Hemminger
Conform to new API Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 567c5e98919d..d3906bede6fc 100644 --- a/examples/distributor/main.c ++

[dpdk-dev] [RFC v2 10/26] examples/qos_{meter/sched}: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/qos_meter/main.c| 4 ++-- examples/qos_sched/args.c| 22 +++--- examples/qos_sched/cmdline.c | 2 +- examples/qos_sched/main.c| 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff -

[dpdk-dev] [RFC v2 09/26] examples/ip_pipeline: replace references to master_lcore

2020-06-05 Thread Stephen Hemminger
Use initial lcore instead of primary lcore Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/main.c | 2 +- examples/ip_pipeline/thread.c | 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/ip_pipeline/main.c b/examples/ip_pipeline/main.c ind

[dpdk-dev] [RFC v2 12/26] examples/l2fwd: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Use term initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/l2fwd-cat/l2fwd-cat.c | 2 +- examples/l2fwd-crypto/main.c | 8 examples/l2fwd-event/l2fwd_event_generic.c | 2 +- examples/l2fwd-event/l2fwd_event_internal_port.c |

[dpdk-dev] [RFC v2 08/26] examples/ethtool-app: replace references to slave with worker

2020-06-05 Thread Stephen Hemminger
Conforms to new API naming conventions. Signed-off-by: Stephen Hemminger --- examples/ethtool/ethtool-app/main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c index 7383413215d6..a55d31d891

[dpdk-dev] [RFC v2 11/26] examples/l3fwd: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/l3fwd-acl/main.c | 4 ++-- examples/l3fwd-graph/main.c | 14 +++--- examples/l3fwd-power/main.c | 20 ++-- examples/l3fwd/main.c | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) d

[dpdk-dev] [RFC v2 18/26] app/test-pmd: change references to master/slave

2020-06-05 Thread Stephen Hemminger
Use new API and naming convention Signed-off-by: Stephen Hemminger --- app/test-pmd/config.c | 4 ++-- app/test-pmd/parameters.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- app/test-pmd/testpmd.c| 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/config.c

[dpdk-dev] [RFC v2 14/26] examples/performance-thread: replace reference to master lcore

2020-06-05 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/performance-thread/l3fwd-thread/main.c | 12 ++-- examples/performance-thread/pthread_shim/main.c | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/mai

[dpdk-dev] [RFC v2 13/26] examples/multi_process: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- .../multi_process/client_server_mp/mp_server/main.c| 10 +- examples/multi_process/simple_mp/main.c| 6 +++--- examples/multi_process/symmetric_mp/main.c | 2 +- 3 files changed, 9 insertions

[dpdk-dev] [RFC v2 17/26] examples: replace reference to master lcore

2020-06-05 Thread Stephen Hemminger
Small changes in several examples to replace master_lcore with initial_lcore across multiple small examples. Signed-off-by: Stephen Hemminger --- examples/eventdev_pipeline/main.c | 2 +- examples/flow_classify/flow_classify.c | 2 +- examples/helloworld/main.c | 6 +++--- ex

[dpdk-dev] [RFC v2 15/26] examples/ptpclient: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Replace master lcore with initial lcore. This API still has issue with use of term master clock. Signed-off-by: Stephen Hemminger --- examples/ptpclient/ptpclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c

[dpdk-dev] [RFC v2 19/26] test-eventdev: replace references to slave with worker lcores

2020-06-05 Thread Stephen Hemminger
Use new API terminolgy Signed-off-by: Stephen Hemminger --- app/test-eventdev/evt_options.c | 2 +- app/test-eventdev/test_order_common.c| 12 ++-- app/test-eventdev/test_perf_common.c | 16 app/test-eventdev/test_pipeline_common.c | 8 4 files

[dpdk-dev] [RFC v2 16/26] examples/ipcsec-secgw: replace references to master lcore

2020-06-05 Thread Stephen Hemminger
Use initial lcore instead. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 6 +++--- examples/ipsec-secgw/ipsec-secgw.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[dpdk-dev] [RFC v2 24/26] app/pdump: replace references to master/slave lcore

2020-06-05 Thread Stephen Hemminger
Use initial and worker lcore instead. Signed-off-by: Stephen Hemminger --- app/pdump/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index c38c53719e7d..1590a716a31d 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -947,7 +947,

[dpdk-dev] [RFC v2 21/26] doc: fix incorrect reference to master process

2020-06-05 Thread Stephen Hemminger
Correct terminolgy here is primary process. This is a bug in original doc. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: bernard.iremon...@intel.com Signed-off-by: Stephen Hemminger --- doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[dpdk-dev] [RFC v2 23/26] doc: replace master lcore terminology

2020-06-05 Thread Stephen Hemminger
A few places in documentation refer to master lcore Signed-off-by: Stephen Hemminger --- doc/guides/howto/debug_troubleshoot.rst | 2 +- doc/guides/linux_gsg/eal_args.include.rst | 4 ++-- doc/guides/nics/bnxt.rst | 2 +- doc/guides/sample_app_ug/hello_world.rst | 2 +- doc/g

[dpdk-dev] [RFC v2 25/26] app/test-XXX: replace reference to master/slave

2020-06-05 Thread Stephen Hemminger
Use new terminology for lcore's Signed-off-by: Stephen Hemminger --- app/test-acl/main.c | 2 +- app/test-bbdev/test_bbdev_perf.c | 16 app/test-compress-perf/main.c| 8 app/test-crypto-perf/main.c | 14 +++--- app/test-pipeline/main.c

[dpdk-dev] [RFC v2 20/26] app/test: repalce refernces to master/slave

2020-06-05 Thread Stephen Hemminger
Use initial and worker when referring to lcores Signed-off-by: Stephen Hemminger --- app/test/autotest_test_funcs.py | 2 +- app/test/test.c | 2 +- app/test/test_atomic.c | 26 app/test/test_barrier.c | 2 +- app/test/test_cryptodev.c

[dpdk-dev] [RFC v2 22/26] doc: update references to master/slave lcore in samples

2020-06-05 Thread Stephen Hemminger
New terms are initial and worker lcores. Signed-off-by: Stephen Hemminger --- doc/guides/sample_app_ug/hello_world.rst| 2 +- doc/guides/sample_app_ug/ioat.rst | 2 +- doc/guides/sample_app_ug/l3_forward_graph.rst | 6 +++--- doc/guides/sample_app_ug/multi_process.rst

[dpdk-dev] [RFC v2 26/26] eal: mark old naming as deprecated

2020-06-05 Thread Stephen Hemminger
Use of old RTE_LCORE_FOREACH_SLAVE and rte_get_master_lcore_id() are marked as deprecated. All uses of these in DPDK itself is gone. This will cause warnings for applications still using them. Signed-off-by: Stephen Hemminger --- lib/librte_eal/include/rte_launch.h | 4 ++-- lib/librte_eal/incl

[dpdk-dev] Intel 82599 ixgbe VF flow director support ?

2020-06-05 Thread Vincent Li
Hi, I am testing https://github.com/iqiyi/dpvs in KVM VM running Ubuntu with Intel 82599 SR-IOV VF. got error like: # ./dpvs current thread affinity is set to F EAL: Detected 4 lcore(s) EAL: Probing VFIO support... EAL: WARNING: cpu flags constant_tsc=no nonstop_tsc=no -> using unreliable cl

Re: [dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-05 Thread Wei Hu (Xavier)
On 2020/6/5 17:44, Ferruh Yigit wrote: On 6/5/2020 9:50 AM, Wei Hu (Xavier) wrote: On 2020/6/5 0:56, Ferruh Yigit wrote: On 6/3/2020 10:32 AM, Wei Hu (Xavier) wrote: From: Hongbo Zheng Base on hns3 network engine, when the rte_eth_tx_burst API is called by Upper Level Process, if PKT_TX_

[dpdk-dev] [PATCH v3] app/testpmd: fix passing negative parameter to strerror

2020-06-05 Thread Wei Hu (Xavier)
Currently, there are coverity defect warnings those were found from the public coverity. https://scan.coverity.com/projects/dpdk-data-plane-development-kit Coverity issue: In nic_stats_clear function: CID 358450 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) 5. negative_return

Re: [dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror

2020-06-05 Thread Wei Hu (Xavier)
On 2020/6/5 17:25, Ferruh Yigit wrote: On 6/5/2020 3:57 AM, Wei Hu (Xavier) wrote: On 2020/6/5 0:30, Ferruh Yigit wrote: On 6/4/2020 7:22 AM, Wei Hu (Xavier) wrote: Currently, there are coverity defect warnings as blow: Coverity issue: In nic_stats_clear function: CID 290021 (#1

[dpdk-dev] [PATCH v1] net/ice: support orignal VF action for DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add support to allow the original VF actions in DCF. Signed-off-by: Qi Zhang --- This patch depends on the previous patchset: "enable DCF datapath configuration", which starts with patch: "net/ice: init RSS and supported RXDID in DCF" --- drivers/net/ice/ice_switch_filter.c | 1

[dpdk-dev] [RFC PATCH 0/3] enable multiple DCF and buildin recipe

2020-06-05 Thread Ting Xu
This RFC patchset adds the support to enable multiple DCF instance, add buildin recipe to accelerate specific flow creating with custom DDP package and support flow flush in DCF. --- This patchset depends on the patch: net/ice: support orignal VF action for DCF --- Qi Zhang (3): drivers: add fl

[dpdk-dev] [RFC PATCH 1/3] drivers: add flow flush for DCF

2020-06-05 Thread Ting Xu
From: Qi Zhang Add support to enable DCF to flush flow rule created by the previous DCF when multiple DCF feature is enabled. Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 4 +++- drivers/net/ice/ice_dcf.c | 16 drivers/net/ice/ice_dcf.h |

[dpdk-dev] [RFC PATCH 3/3] net/ice: enable buildin recipe 10 for custom DDP package

2020-06-05 Thread Ting Xu
From: Qi Zhang Enable buildin recipe to accelerate DCF start and specific flow rules creating speed with custom DDP package. Use dev_args "br=1" to turn on buildin recipe. Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 3 ++ drivers/net/ice/base/ice_common.c | 25

[dpdk-dev] [RFC PATCH 2/3] drivers/net: support multiple DCF instance

2020-06-05 Thread Ting Xu
From: Qi Zhang DCF will not explicitly call VIRTCHNL_OP_DCF_DISABLE during uninit if DCF PMD is required to support multiple instances co-exist. This is hinted by devargs "cap=mdcf". NOTE: in kernel PF, it still only take one VF as DCF, so there is only one active DPDK DCF instance has the DCF c