Re: [dpdk-dev] [PATCH v4 0/5] Introduce flow perf application

2020-05-04 Thread Thomas Monjalon
Would be nice to have a last round of review before merging in -rc2. Volunteers? 30/04/2020 12:33, Wisam Jaddo: > Add new application to test rte flow performance from: > - Insertion rate. > - Deletion rate. > - Memory consumption. > - PPS forward measurement.

[dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison

2020-05-04 Thread Matan Azrad
A regular memcmp function was used to compare between two objects of type `struct rte_pci_addr`. Due to the alignment rules of compiler structure builders, some memory is not initiated in the structure even though all the fields were initiated. Therefore, the comparison may fail even though the P

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong assert in modify converting

2020-05-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, April 29, 2020 4:06 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: Ori Kam ; Matan Azrad ; > dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix wrong assert in modify converting > > The assertion was added inc

Re: [dpdk-dev] [PATCH] net/mlx5: fix gcc 10 enum-conversion warning

2020-05-04 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Kevin Traynor > Sent: Friday, March 20, 2020 18:48 > To: dev@dpdk.org; Raslan Darawsheh > Cc: Kevin Traynor > Subject: [dpdk-dev] [PATCH] net/mlx5: fix gcc 10 enum-conversion warning > > gcc 10.0.1 reports warnings when using mlx5_rte_flow e

Re: [dpdk-dev] [EXT] [PATCH 1/8] cryptodev: fix trace points registration

2020-05-04 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 2:01 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Declan Doherty ; >Sunil Kumar Kori >Subject: [EXT] [PATCH 1/8] cryptodev: fix trace points registration > >External Email > >---

Re: [dpdk-dev] [PATCH dpdk-dev v3 2/2] mempool: use shared memzone for rte_mempool_ops

2020-05-04 Thread Olivier Matz
Hi, On Tue, Apr 28, 2020 at 09:22:37PM +0800, Tonghao Zhang wrote: > On Mon, Apr 27, 2020 at 8:51 PM Tonghao Zhang > wrote: > > > > On Mon, Apr 27, 2020 at 7:40 PM Thomas Monjalon wrote: > > > > > > 27/04/2020 10:03, Tonghao Zhang: > > > > On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix set VLAN vid size check

2020-05-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Wisam Monther > Sent: Thursday, April 30, 2020 11:31 AM > To: dev@dpdk.org; Dekel Peled ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: Moti Haimovsky ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix set VLAN vid size check > > All comparison should be do

Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

2020-05-04 Thread Sunil Kumar Kori
Overall, it looks okay but I think "args" will be more relevant as each API says XXX_args_save(). What do you say ? Regards Sunil Kumar Kori >-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 2:02 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran

Re: [dpdk-dev] [PATCH] net/octeontx2: offload bad L4 checksum detection

2020-05-04 Thread Jerin Jacob
On Fri, May 1, 2020 at 3:23 PM wrote: > > From: Amit Gupta > > On detecting outer L4 checksum as bad, both outer and > inner checksums are marked as bad. No need to explicitly > check inner L4 checksum in this case. > > Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD > and PKT_RX_L4_CKSU

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-05-04 Thread Mattias Rönnblom
On 2020-05-01 23:05, Dan Gora wrote: > On Fri, May 1, 2020 at 1:29 PM Luca Boccassi wrote: >>> Well, no, because rdseed is used first if available and /dev/urandom >>> is used next.. >>> >>> And this is not a corner case at all.. There are lots of linux >>> distributions which DPDK claims to suppo

Re: [dpdk-dev] [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Olivier Matz
Hi, On Fri, May 01, 2020 at 04:48:21PM +0530, Jerin Jacob wrote: > On Fri, Apr 17, 2020 at 12:53 PM Nithin Dabilpuram > wrote: > > > > From: Nithin Dabilpuram > > > > Introduce PKT_TX_MARK_IP_DSCP, PKT_TX_MARK_IP_ECN > > and PKT_TX_MARK_VLAN_DEI Tx offload flags to support > > packet marking. >

Re: [dpdk-dev] [EXT] [PATCH 5/8] trace: remove unneeded checks in internal API

2020-05-04 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 2:02 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Sunil Kumar Kori >Subject: [EXT] [PATCH 5/8] trace: remove unneeded checks in internal API > >External Email > >---

Re: [dpdk-dev] [PATCH] net/mlx5: fix gcc 10 enum-conversion warning

2020-05-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Kevin Traynor > Sent: Friday, March 20, 2020 6:48 PM > To: dev@dpdk.org; Raslan Darawsheh > Cc: Kevin Traynor > Subject: [PATCH] net/mlx5: fix gcc 10 enum-conversion warning > > gcc 10.0.1 reports warnings when using mlx5_rte_flow enums > with rte_flow

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Nithin Dabilpuram
Hi Olivier, On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > External Email > > -- > Hi, > > On Fri, May 01, 2020 at 04:48:21PM +0530, Jerin Jacob wrote: > > On Fri, Apr 17, 2020 at 12:53 PM Nithin Dabilpuram > >

Re: [dpdk-dev] [EXT] [PATCH 6/8] trace: remove limitation on patterns number

2020-05-04 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 2:02 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Sunil Kumar Kori >Subject: [EXT] [PATCH 6/8] trace: remove limitation on patterns number > >External Email > >-

Re: [dpdk-dev] [PATCH v2] net/octeontx2: update red algo for shaper dynamic update

2020-05-04 Thread Jerin Jacob
On Fri, May 1, 2020 at 7:54 PM Nithin Dabilpuram wrote: > > From: Nithin Dabilpuram > > Due to an errata red algo needs to be set to discard instead of stall > for 96XX C0 silicon for two rate shaping. This workaround is being > already handled for newly created hierarchy but not for dynamic > sh

[dpdk-dev] [PATCH v3 0/4] Introduce IF proxy library

2020-05-04 Thread Andrzej Ostruszka
All Please find in this patch set updated version of IF Proxy library. This version addresses comments received so far with some additional minor improvements/changes. This version does not change the notification scheme yet since discussion about general DPDK messaging/notification scheme has h

[dpdk-dev] [PATCH v3 2/4] if_proxy: add library documentation

2020-05-04 Thread Andrzej Ostruszka
This commit adds documentation of IF Proxy library. Signed-off-by: Andrzej Ostruszka --- MAINTAINERS| 1 + doc/guides/prog_guide/if_proxy_lib.rst | 142 + doc/guides/prog_guide/index.rst| 1 + 3 files changed, 144 insertions(+) cre

[dpdk-dev] [PATCH v3 1/4] lib: introduce IF Proxy library

2020-05-04 Thread Andrzej Ostruszka
This library allows to designate ports visible to the system (such as Tun/Tap or KNI) as port representors serving as proxies for other DPDK ports. When such a proxy is configured this library initially queries network configuration from the system and later monitors its changes. The information

[dpdk-dev] [PATCH v3 4/4] if_proxy: add example application

2020-05-04 Thread Andrzej Ostruszka
Add an example application showing possible library usage. This is a simplified version of l3fwd where: - many performance improvements has been removed in order to simplify logic and put focus on the proxy library usage, - the configuration of forwarding has to be done by the user (using typic

[dpdk-dev] [PATCH v3 3/4] if_proxy: add simple functionality test

2020-05-04 Thread Andrzej Ostruszka
This commit adds simple test of the library notifications. Signed-off-by: Andrzej Ostruszka --- MAINTAINERS | 1 + app/test/Makefile| 5 + app/test/meson.build | 4 + app/test/test_if_proxy.c | 707 +++ 4 files changed, 717 inser

Re: [dpdk-dev] [EXT] [PATCH 7/8] trace: remove string duplication

2020-05-04 Thread Sunil Kumar Kori
>-Original Message- >From: David Marchand >Sent: Monday, May 4, 2020 2:02 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Sunil Kumar Kori >Subject: [EXT] [PATCH 7/8] trace: remove string duplication > >External Email > >

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

2020-05-04 Thread Thomas Monjalon
30/04/2020 16:43, Ananyev, Konstantin: > > Hi Honnappa, > > > Hi Konstantin, > > I like the way the tests are organized and it looks good. > > > > I am just wondering about the way it is being tested here. The intent to > > write the test cases the way they are currently is to mimic how th

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison

2020-05-04 Thread Maxime Coquelin
On 5/4/20 9:12 AM, Matan Azrad wrote: > A regular memcmp function was used to compare between two objects of > type `struct rte_pci_addr`. > > Due to the alignment rules of compiler structure builders, some memory > is not initiated in the structure even though all the fields were > initiated.

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Olivier Matz
On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > Hi Olivier, > > On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > > External Email > > > > -- > > Hi, > > > > On Fri, May 01, 2020 at 04:48:21PM

Re: [dpdk-dev] [PATCH] common/octeontx: fix GCC 9.1 ABI break

2020-05-04 Thread Harman Kalra
On Sat, May 02, 2020 at 09:40:31PM +0530, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > GCC 9.1 fixes a bug with passing bitfields as pass by value in function > parameters and generates a warning for the same as below: > > drivers/common/octeontx/octeontx_mbox.c:282:1: note: param

[dpdk-dev] [PATCH v2] event/dsw: avoid reusing previously recorded events

2020-05-04 Thread Mattias Rönnblom
From: Mattias Rönnblom Avoid reusing recorded events when performing a migration, since this may make the migration selection logic pick an already-moved flow. Fixes: f6257b22e767 ("event/dsw: add load balancing") Cc: sta...@dpdk.org Reported-by: Venky Venkatesh Signed-off-by: Mattias Rönnblom

[dpdk-dev] Intel CI failure due to Virtio PMD AVX series

2020-05-04 Thread Maxime Coquelin
Hi Marvin, Could you please check what is wrong with your AVX series for Virtio packed ring in Intel CI (UB1804-32 + Meson)? http://mails.dpdk.org/archives/test-report/2020-May/130108.html Thanks, Maxime

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison

2020-05-04 Thread Maxime Coquelin
On 5/4/20 9:12 AM, Matan Azrad wrote: > A regular memcmp function was used to compare between two objects of > type `struct rte_pci_addr`. > > Due to the alignment rules of compiler structure builders, some memory > is not initiated in the structure even though all the fields were > initiated.

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Nithin Dabilpuram
On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > > Hi Olivier, > > > > On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > > > External Email > > > > > > ---

Re: [dpdk-dev] [PATCH v5 1/2] virtio: one way barrier for split vring used idx

2020-05-04 Thread Maxime Coquelin
On 5/1/20 12:58 AM, Ferruh Yigit wrote: > On 4/30/2020 10:14 AM, Joyce Kong wrote: >> In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend >> and backend are assumed to be implemented in software, that is they can >> run on identical CPUs in an SMP configuration. >> Thus a we

[dpdk-dev] [PATCH] examples/ipsec-secgw: tests clean-up

2020-05-04 Thread Mariusz Drost
As more test cases are defined for execution, test scripts structure needs to be reorganized, so fewer files are needed to describe the test. To achieve that, new environment variables are incorporated into the scripts. Additionally, tests for mixed tunnel protocols are added. Signed-off-by: Mariu

Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton

2020-05-04 Thread Andrew Rybchenko
On 4/30/20 1:33 PM, Wisam Jaddo wrote: > Add flow performance application skeleton. > > Signed-off-by: Wisam Jaddo > --- > MAINTAINERS | 5 + > app/Makefile | 1 + > app/meson.build | 1 + > app/test-flow-perf/Makefile

Re: [dpdk-dev] [PATCH V2 0/2] net/mlx5: optimize performance for IPv4/IPv6

2020-05-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Eli Britstein > Sent: Sunday, May 3, 2020 1:48 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Slava Ovsiienko > ; Eli Britstein > Subject: [PATCH V2 0/2] net/mlx5: optimize performance for IPv4/IPv6 > > The HW is optimized for I

Re: [dpdk-dev] [PATCH v2] event/dsw: avoid reusing previously recorded events

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 3:01 PM Mattias Rönnblom wrote: > > From: Mattias Rönnblom > > Avoid reusing recorded events when performing a migration, since this > may make the migration selection logic pick an already-moved flow. > > Fixes: f6257b22e767 ("event/dsw: add load balancing") > Cc: sta...@d

[dpdk-dev] [pull-request] next-eventdev 20.05 RC2

2020-05-04 Thread Jerin Jacob Kollanukkaran
The following changes since commit 67d376e7fe7d4e4149d3591ed94cba33206e8cd2: maintainers: update for testpmd (2020-04-29 23:51:50 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 53878b746f26a6f845fd077fbae046eb98b211d

Re: [dpdk-dev] [PATCH v4 2/5] app/test-flow-perf: add insertion rate calculation

2020-05-04 Thread Andrew Rybchenko
On 4/30/20 1:33 PM, Wisam Jaddo wrote: > Add insertion rate calculation feature into flow > performance application. > > The application now provide the ability to test > insertion rate of specific rte_flow rule, by > stressing it to the NIC, and calculate the > insertion rate. > > The applicatio

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Olivier Matz
On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > > On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > > > Hi Olivier, > > > > > > On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > >

[dpdk-dev] [PATCH] app/test: handle -ENOTSUP from session init

2020-05-04 Thread Ankur Dwivedi
The session init routine rte_cryptodev_sym_session_init(), could return -ENOTSUP when the requested algo combination is not supported by the PMD. This should be treated as unsupported features. For other return values like -EINVAL or -ENOMEM the test can be treated as failure. Signed-off-by: Ankur

[dpdk-dev] [PATCH v3 3/8] net/dpaa2: do not prefetch annotaion for physical mode

2020-05-04 Thread Hemant Agrawal
From: Nipun Gupta When IOVA is physical address do not prefetch the annotation of the next frame, as there is a cost involved there to convert the physical address to virtual address. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 6 ++-- drivers/net/dpaa2/dpaa2_rxtx

[dpdk-dev] [PATCH v3 0/8] NXP DPAAx fixes and enhancements

2020-05-04 Thread Hemant Agrawal
v3: Limiting the patches to avoid ABI breakage. Apeksha Gupta (1): bus/fslmc: fix dereferencing null pointer Hemant Agrawal (2): net/dpaa2: add default Rx params in devinfo net/dpaa2: reduce prints in queue count functions Jun Yang (1): net/dpaa2: use cong group id for multiple tcs Nip

[dpdk-dev] [PATCH v3 4/8] net/dpaa2: add default Rx params in devinfo

2020-05-04 Thread Hemant Agrawal
This patch adds default/preferred rx/tx params in dev info, specially the advertised burst size. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 4 drivers/net/dpaa/dpaa_ethdev.h | 1 + drivers/net/dpaa2/dpaa2_ethdev.c | 16 drivers/net/dpaa2/dpaa2_

[dpdk-dev] [PATCH v3 1/8] bus/fslmc: fix dereferencing null pointer

2020-05-04 Thread Hemant Agrawal
From: Apeksha Gupta This patch fixees the nxp internal coverity reported null pointer dereferncing issue. Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta --- drivers/bus/fslmc/qbman/qbman_debug.c | 9 + 1 file changed,

[dpdk-dev] [PATCH v3 5/8] drivers: dpaa2 enhance portal alloc failure log

2020-05-04 Thread Hemant Agrawal
From: Nipun Gupta The change adds printing the thread id when portal allocation failure occurs Signed-off-by: Nipun Gupta --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 ++-- drivers/event/dpaa2/dpaa2_eventdev.c| 8 ++-- drivers/mempool/dpaa2/dpaa2_hw_mempool.c| 12 +

[dpdk-dev] [PATCH v3 2/8] net/dpaa2: fix 10g port negotiation issue

2020-05-04 Thread Hemant Agrawal
From: Rohit Raj Fixed 10g port negotiation issue with another 10G/non 10G port. Initialize the port link speed. Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v3 6/8] net/dpaa2: support UDP dst port based muxing

2020-05-04 Thread Hemant Agrawal
From: Nipun Gupta This change adds DPDMUX support to bifurcate traffic on the basis of UDP destination port. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_mux.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b

[dpdk-dev] [PATCH v3 7/8] net/dpaa2: reduce prints in queue count functions

2020-05-04 Thread Hemant Agrawal
changing them to DP as it is impacting l3fwd-power apps Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 817e9e0316..fd766a2184 10064

[dpdk-dev] [PATCH v3 8/8] net/dpaa2: use cong group id for multiple tcs

2020-05-04 Thread Hemant Agrawal
From: Jun Yang Flow id may not work when used with multipel tcs. The CGID will be provided in the INDEX field. Signed-off-by: Jun Yang --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpa

[dpdk-dev] [PATCH v5] mempool: return 0 if area is too small on populate

2020-05-04 Thread Olivier Matz
Change rte_mempool_populate_iova() and rte_mempool_populate_virt() to return 0 instead of -EINVAL when there is not enough room to store one object, as it can be helpful for applications to distinguish this specific case. As this is an ABI change, use symbol versioning to preserve old behavior for

Re: [dpdk-dev] [PATCH v5] mempool: return 0 if area is too small on populate

2020-05-04 Thread Andrew Rybchenko
On 5/4/20 3:49 PM, Olivier Matz wrote: > Change rte_mempool_populate_iova() and rte_mempool_populate_virt() to > return 0 instead of -EINVAL when there is not enough room to store one > object, as it can be helpful for applications to distinguish this > specific case. > > As this is an ABI change,

Re: [dpdk-dev] [PATCH] app/test: handle -ENOTSUP from session init

2020-05-04 Thread Anoob Joseph
> The session init routine rte_cryptodev_sym_session_init(), could return - > ENOTSUP when the requested algo combination is not supported by the PMD. > This should be treated as unsupported features. For other return values like - > EINVAL or -ENOMEM the test can be treated as failure. > > Signed

[dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum

2020-05-04 Thread jerinj
From: Jerin Jacob Some machines may have a lot of PCI devices and all of them are not bound to DPDK. In such case the logs from EAL creates a lot of clutter on boot-up, typically one needs to scroll the screen to find other issues in boot-up. This patch changes the following to reduce the clutte

[dpdk-dev] [PATCH v3] doc: use glob terminology

2020-05-04 Thread jerinj
From: Jerin Jacob Glob is the terminology used in fnmatch man page. Use glob terminology across DPDK for shell pattern. Signed-off-by: Jerin Jacob --- v3: - Address Thomas's comments http://patches.dpdk.org/patch/68225/ v2: - Fix typo devtools/check-includes.sh | 2 +- lib/librt

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Thomas Monjalon
04/05/2020 04:46, Jerin Jacob: > On Mon, May 4, 2020 at 2:02 AM David Marchand > wrote: > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. > > > Initially, I thought of doing the same. But,

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > On Mon, May 4, 2020 at 2:02 AM David Marchand > wrote: > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. > > > Initially, I thought of

Re: [dpdk-dev] [EXT] [PATCH 4/8] trace: avoid confusion on optarg

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 9:55 AM Sunil Kumar Kori wrote: > > Overall, it looks okay but I think "args" will be more relevant as each API > says XXX_args_save(). > What do you say ? No opinion, the function name itself indicates we are dealing with arguments. I can go with args if you like. -- D

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-05-04 Thread Dan Gora
On Mon, May 4, 2020 at 5:04 AM Mattias Rönnblom wrote: > >> so what you are effectively asking is to > >> double the size of the support matrix, and for the project to ensure > >> that every single dependency can always be built against a new version > >> and used against an older one. > > No, th

Re: [dpdk-dev] [EXT] [PATCH 6/8] trace: remove limitation on patterns number

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 10:48 AM Sunil Kumar Kori wrote: > >diff --git a/lib/librte_eal/common/eal_common_trace_utils.c > >b/lib/librte_eal/common/eal_common_trace_utils.c > >index 4077acf428..15384ce4f1 100644 > >--- a/lib/librte_eal/common/eal_common_trace_utils.c > >+++ b/lib/librte_eal/common/e

Re: [dpdk-dev] [PATCH v5 1/1] bus/pci: optimise scanning with whitelist/blacklist

2020-05-04 Thread David Marchand
On Sat, May 2, 2020 at 9:42 AM Sunil Kumar Kori wrote: > diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h > index a205d4d9f..3a9da7322 100644 > --- a/drivers/bus/pci/private.h > +++ b/drivers/bus/pci/private.h > @@ -42,6 +42,17 @@ int rte_pci_scan(void); > void > pci_name_set(s

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2020-05-04 Thread Dan Gora
On Mon, May 4, 2020 at 11:13 AM Dan Gora wrote: > > On Mon, May 4, 2020 at 5:04 AM Mattias Rönnblom > wrote: > > > >> so what you are effectively asking is to > > >> double the size of the support matrix, and for the project to ensure > > >> that every single dependency can always be built agains

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 7:34 PM David Marchand wrote: > > On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 2:02 AM David Marchand > > wrote: > > > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > > > Merge them and let RTE_TRACE_POIN

Re: [dpdk-dev] [PATCH v1 5/6] doc: update sample app with unknown speed

2020-05-04 Thread Ivan Dyukov
03.05.2020 16:57, Andrew Rybchenko пишет: > On 5/2/20 10:35 PM, Ivan Dyukov wrote: >> 01.05.2020 16:28, Andrew Rybchenko пишет: >>> On 4/27/20 12:57 PM, Ivan Dyukov wrote: Signed-off-by: Ivan Dyukov ---   doc/guides/sample_app_ug/link_status_intr.rst | 3 ++-   1 file changed,

Re: [dpdk-dev] [PATCH v5] mempool: return 0 if area is too small on populate

2020-05-04 Thread Lukasz Wojciechowski
W dniu 04.05.2020 o 14:54, Andrew Rybchenko pisze: > On 5/4/20 3:49 PM, Olivier Matz wrote: >> Change rte_mempool_populate_iova() and rte_mempool_populate_virt() to >> return 0 instead of -EINVAL when there is not enough room to store one >> object, as it can be helpful for applications to distin

Re: [dpdk-dev] [PATCH v1 5/6] doc: update sample app with unknown speed

2020-05-04 Thread Andrew Rybchenko
On 5/4/20 6:46 PM, Ivan Dyukov wrote: > 03.05.2020 16:57, Andrew Rybchenko пишет: >> On 5/2/20 10:35 PM, Ivan Dyukov wrote: >>> 01.05.2020 16:28, Andrew Rybchenko пишет: On 4/27/20 12:57 PM, Ivan Dyukov wrote: > Signed-off-by: Ivan Dyukov > --- >   doc/guides/sample_app_ug/link_s

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix fd leak

2020-05-04 Thread Gaëtan Rivet
On 03/05/20 11:33 +, Ali Alnubani wrote: > Hi, > > > -Original Message- > > From: dev On Behalf Of Ferruh Yigit > > Sent: Monday, April 27, 2020 7:56 PM > > To: Gaëtan Rivet ; wangyunjian > > > > Cc: dev@dpdk.org; jerry.lili...@huawei.com; xudin...@huawei.com; > > sta...@dpdk.org > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix fd leak

2020-05-04 Thread Stephen Hemminger
On Mon, 4 May 2020 18:22:26 +0200 Gaëtan Rivet wrote: > On 03/05/20 11:33 +, Ali Alnubani wrote: > > Hi, > > > > > -Original Message- > > > From: dev On Behalf Of Ferruh Yigit > > > Sent: Monday, April 27, 2020 7:56 PM > > > To: Gaëtan Rivet ; wangyunjian > > > > > > Cc: dev@dpdk

Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows

2020-05-04 Thread Thomas Monjalon
01/05/2020 03:08, Ranjit Menon: > On 4/30/2020 12:30 AM, Dmitry Kozlyuk wrote: > > On 2020-04-30 08:52 GMT+0200 Thomas Monjalon wrote: > >> 30/04/2020 01:24, Pallavi Kadam: > >>> Added fnmatch implementation on Windows to support > >>> log level arguments. > >>> The source file is with BSD-3-Clause

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > On Mon, May 4, 2020 at 7:34 PM David Marchand > wrote: > > > > On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > > > > > On Mon, May 4, 2020 at 2:02 AM David Marchand > > > wrote: > > > > > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_PO

[dpdk-dev] [PATCH v2] vhost: fix mbuf alloc failure

2020-05-04 Thread Sivaprasad Tummala
vhost buffer allocation is successful for packets that fit into a linear buffer. If it fails, vhost library is expected to drop the current packet and skip to the next. The patch fixes the error scenario by skipping to next packet. Note: Drop counters are not currently supported. Fixes: c3ff0ac70

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 10:38 PM David Marchand wrote: > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 7:34 PM David Marchand > > wrote: > > > > > > On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > > > > > > > On Mon, May 4, 2020 at 2:02 AM David Marcha

Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function

2020-05-04 Thread Thomas Monjalon
02/05/2020 01:15, Chautru, Nicolas: > Hi Akhil, Thomas, > > Following up on that previous discussion below so that to confirm whether > there is an available option to handle this usecase within DPDK repo. > > Basically traditional deployment for VRAN relies on BBDEV/DPDK running within > con

[dpdk-dev] [PATCH] ipv4_fragmentation: fix fragmentation of ipv4 packet with optional header

2020-05-04 Thread Pu Xu
Signed-off-by: Pu Xu <583493...@qq.com> --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index e9de335ae..156087ca3 10

Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags

2020-05-04 Thread Kinsella, Ray
> -Original Message- > From: Thomas Monjalon > Sent: Saturday 25 April 2020 17:04 > To: Kinsella, Ray ; nhor...@tuxdriver.com; > Laatz, Kevin > Cc: dev@dpdk.org; Richardson, Bruce ; Van > Haaren, Harry ; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x

[dpdk-dev] Multiple cores for DPDK behind SmartNIC

2020-05-04 Thread Jonatan Langlet
Hi group, We are building a setup with DPDK bound to VF ports of a Netronome Agilio CX 2x40 (NFP4000) SmartNIC. Netronome does some P4 processing of packets, and forwards through SR-IOV to host where dpdk will continue processing. My problem: in DPDK I can not allocate more than a single RX-queue

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header options

2020-05-04 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-04 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: a7c528e5d71f ("net: add rte prefix to IP structure") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Pu Xu <583493...@qq.com>

[dpdk-dev] [PATCH 2/2] drivers/net: Fix in e1000 and ixgbe HW rings memory overlap

2020-05-04 Thread Renata Saiakhova
Delete memzones for HW rings in igb and ixgbe while freeing queues Signed-off-by: Renata Saiakhova --- drivers/net/e1000/igb_rxtx.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 68

[dpdk-dev] [PATCH 0/2] Memory corruption due to HW rings allocation

2020-05-04 Thread Renata Saiakhova
igb and ixgbe drivers allocate HW rings using rte_eth_dma_zone_reserve(), which checks first if the memzone exists for a given name, consisting of port id, queue_id, rx/tx direction, but not for the size, alignment, and socket_id. If the memzone with a given name exists it is returned, otherwise it

[dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2020-05-04 Thread Pu Xu
When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). Fixes: a7c528e5d71f ("net: add rte prefix to IP structure") Cc: olivier.m...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Pu Xu <583493...@qq.com>

[dpdk-dev] [PATCH 1/2] librte_ethdev: Introduce a function to release HW rings

2020-05-04 Thread Renata Saiakhova
Free previously allocated memzone for HW rings Signed-off-by: Renata Saiakhova --- lib/librte_ethdev/rte_ethdev.c | 23 +++ lib/librte_ethdev/rte_ethdev_driver.h| 14 ++ lib/librte_ethdev/rte_ethdev_version.map | 1 + 3 files changed, 38 insertions(

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > On Mon, May 4, 2020 at 10:38 PM David Marchand > wrote: > > > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > > > > > On Mon, May 4, 2020 at 7:34 PM David Marchand > > > wrote: > > > > > > > > On Mon, May 4, 2020 at 4:47 AM Jerin Ja

[dpdk-dev] [PATCH] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-04 Thread David Christensen
Building DPDK on Ubuntu 20.04 with GCC 9.3.0 results in a "subscript is outside array bounds" message in rte_memcpy function. The build error is caused by an interaction between __builtin_constant_p and "-Werror=array-bounds" as described in this bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cg

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 11:10 PM David Marchand wrote: > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 10:38 PM David Marchand > > wrote: > > > > > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > > > > > > > On Mon, May 4, 2020 at 7:34 PM David Marcha

Re: [dpdk-dev] [PATCH v1 5/6] doc: update sample app with unknown speed

2020-05-04 Thread Ivan Dyukov
04.05.2020 18:54, Andrew Rybchenko пишет: > On 5/4/20 6:46 PM, Ivan Dyukov wrote: >> 03.05.2020 16:57, Andrew Rybchenko пишет: >>> On 5/2/20 10:35 PM, Ivan Dyukov wrote: 01.05.2020 16:28, Andrew Rybchenko пишет: > On 4/27/20 12:57 PM, Ivan Dyukov wrote: >> Signed-off-by: Ivan Dyukov >

Re: [dpdk-dev] [PATCH] app/test: allow building with bonding net driver disabled

2020-05-04 Thread Lukasz Wojciechowski
W dniu 01.05.2020 o 17:05, Bruce Richardson pisze: > The autotest application build was partially enabled for building with > the net/bond driver disabled, but a number of items were missed, leading > to build errors when the driver was disabled, e.g. by simply doing > "-Ddisable_drivers=net/*" whe

Re: [dpdk-dev] [PATCH v2] vhost: fix mbuf alloc failure

2020-05-04 Thread Flavio Leitner
On Mon, May 04, 2020 at 10:41:17PM +0530, Sivaprasad Tummala wrote: > vhost buffer allocation is successful for packets that fit > into a linear buffer. If it fails, vhost library is expected > to drop the current packet and skip to the next. > > The patch fixes the error scenario by skipping to n

Re: [dpdk-dev] [PATCH v2 2/3] eal: add internal directory management API

2020-05-04 Thread Narcisa Ana Maria Vasile
On Sun, Apr 26, 2020 at 06:28:17PM +0300, Dmitry Kozlyuk wrote: > Add functions for handling directories in a platform-independent way: > > * eal_persistent_data_path() > * eal_dir_create() > > Currently, only tracing requires this API for its common code. > > Signed-off-by: Dmitry Kozlyuk > --

Re: [dpdk-dev] [PATCH] test/service: add perf test for service on app lcore

2020-05-04 Thread Lukasz Wojciechowski
W dniu 01.05.2020 o 17:56, Harry van Haaren pisze: > Add a performance test to the service run on app lcore auto- > test. This test runs the service in a tight loop, and measures > cycles passed, printing the results. It provides a quick cycle > cost value, enabling measuring performance of the f

[dpdk-dev] [PATCH 2/2] crypto/dpaa_sec: improve error handling

2020-05-04 Thread Akhil Goyal
The return values in cases of errors were not specified properly. With this patch appropriate error numbers are returned. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 33 -- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 1/2] crypto/dpaa2_sec: improve error handling

2020-05-04 Thread Akhil Goyal
The return values in cases of errors were not specified properly. With this patch appropriate error numbers are returned. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 59 + 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2] eal: fix rte_memcpy build on ppc with gcc 9.3

2020-05-04 Thread David Christensen
Building DPDK on Ubuntu 20.04 with GCC 9.3.0 results in a "subscript is outside array bounds" message in rte_memcpy function. The build error is caused by an interaction between __builtin_constant_p and "-Werror=array-bounds" as described in this bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cg

[dpdk-dev] [PATCH] net/bnxt: modify mark manager validity checks

2020-05-04 Thread Mike Baucom
From: Kishore Padmanabha The ulp mark manager originally assumed that zero was an invalid mark and used it for invalidation and deletion. The mark manager now supports adding zero as a mark, flags for validity and type, and adds explicit bounds checking instead of relying on mask. Signed-off-by

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Thomas Monjalon
04/05/2020 19:54, Jerin Jacob: > On Mon, May 4, 2020 at 11:10 PM David Marchand > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > > On Mon, May 4, 2020 at 10:38 PM David Marchand > > > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob > > > > wrote: > > > > > On Mon, May 4, 2020 at 7:34 PM Da

Re: [dpdk-dev] [PATCH v1] abi: document reasons behind the three part versioning

2020-05-04 Thread Thomas Monjalon
23/04/2020 12:12, Ray Kinsella: > Clarify the reasons behind the three part version numbering scheme. > Documents the fixes made in f26c2b3. Please add these lines: Fixes: f26c2b39b271 ("build: fix soname info for 19.11 compatibility") Cc: sta...@dpdk.org > Signed-off-by: Ray Kinsella > Signed-

[dpdk-dev] [PATCH v2 2/2] crypto/dpaa_sec: improve error handling

2020-05-04 Thread Akhil Goyal
The return values in cases of errors were not specified properly. With this patch appropriate error numbers are returned. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 40 -- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v2 1/2] crypto/dpaa2_sec: improve error handling

2020-05-04 Thread Akhil Goyal
The return values in cases of errors were not specified properly. With this patch appropriate error numbers are returned. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 59 + 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/drivers

Re: [dpdk-dev] [PATCH v6 1/1] abi: change references to abi 20.0.1 to abi v21

2020-05-04 Thread Thomas Monjalon
30/04/2020 12:27, Ray Kinsella: > Sending again, as I missed the cover letter last time. You don't need a cover letter for a single patch. The changelog can be added below --- in a patch.

[dpdk-dev] [PATCH 2/9] test/crypto: skip unsupported non-byte aligned cases

2020-05-04 Thread Akhil Goyal
Skipped the test cases for the PMDs which do not support RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA and subsequently removed the PMD specific checks for running that case. Signed-off-by: Apeksha Gupta Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 68 +---

[dpdk-dev] [PATCH 0/9] test/crypto: code cleanup

2020-05-04 Thread Akhil Goyal
Certain cases were put in PMD specific checks which should be avoided. Appropriate capability/supported feature flag should be checked before executing the test case. Added 1 missing feature flag for non-byte aligned data Enabled it for SNOW/ZUC/KASUMI PMDs. All the PMD owners are requested to veri

[dpdk-dev] [PATCH 1/9] cryptodev: add feature flag for non-byte aligned data

2020-05-04 Thread Akhil Goyal
Some wireless algos like SNOW, ZUC may support input data in bits which are not byte aligned. However, not all PMDs can support this requirement. Hence added a new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA to identify which all PMDs can support non-byte aligned data. Signed-off-by: Akhil

  1   2   >