Hi, > -----Original Message----- > From: Bing Zhao <[email protected]> > Sent: Wednesday, April 29, 2020 4:06 PM > To: Slava Ovsiienko <[email protected]>; Raslan Darawsheh > <[email protected]> > Cc: Ori Kam <[email protected]>; Matan Azrad <[email protected]>; > [email protected]; [email protected] > Subject: [PATCH] net/mlx5: fix wrong assert in modify converting > > The assertion was added incorrectly in converting the modify actions > into the format of low layer driver. > There is no mask specified in the rte_flow actions, and PMD dirver > will give a mask of all 1s to the field to be modified. For each > field, the mask could not be zero. But for the whole header which > contains this field, the masks of other fields could be zero. The > assertion needs to be removed for debug mode. > > Fixes: 72a944dba163 ("net/mlx5: fix header modify action validation") > Cc: [email protected] > > Signed-off-by: Bing Zhao <[email protected]> > Acked-by: Viacheslav Ovsiienko <[email protected]> > --- > drivers/net/mlx5/mlx5_flow_dv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 6263ecc..8cd9c83 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -434,7 +434,6 @@ struct field_modify_info modify_tcp[] = { > /* Fetch variable byte size mask from the array. */ > mask = flow_dv_fetch_field((const uint8_t *)item->mask + > field->offset, field->size); > - MLX5_ASSERT(mask); > if (!mask) { > ++field; > continue; > -- > 1.8.3.1
Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
