> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Friday, April 24, 2020 8:02 PM
> To: Honnappa Nagarahalli
> Cc: dev@dpdk.org; nd
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ring: future proof flag settings
>
> On Fri, 24 Apr 2020 18:07:15 +
> Honnappa Nagarah
Move the internal function into INTERNAL session to avoid the ABI
checking, and it is only used for DPDK drivers or related library.
__rte_internal funA
INTERNAL {
global:
funA
};
v7: Fix the meson build error
v6: split into small patches, and add the missed handling.
Introduce the __rte_internal tag to mark internal ABI function which is
used only by the drivers or other libraries.
Signed-off-by: Haiyue Wang
---
lib/librte_eal/include/rte_compat.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/librte_eal/include/rte_compat.h
b/lib/li
Allow the drivers and libraries to use the internal tag for marking
internal ABI symbols.
Signed-off-by: Haiyue Wang
---
drivers/meson.build | 5 -
lib/meson.build | 5 -
mk/target/generic/rte.vars.mk | 1 +
3 files changed, 9 insertions(+), 2 deletions(-)
diff -
Move the internal tag on a separate line and make it the first thing of
function prototypes.
Signed-off-by: Haiyue Wang
---
devtools/checkpatches.sh | 39 +++
1 file changed, 39 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
in
Ignore the internal version ABI check, this kind of ABI is used only
by drivers and libraries.
Signed-off-by: Haiyue Wang
---
devtools/libabigail.abignore | 5 +
1 file changed, 5 insertions(+)
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 1911890a7..986a527
Add checks during build to ensure that all symbols in the INTERNAL
version map section have __internal tags on their definitions, and
enable the warnings needed to announce their use.
Signed-off-by: Haiyue Wang
---
MAINTAINERS | 2 +-
...-experimental-syms.sh =
No need to restrict the ABI on symbols that are only used by core
libraries.
Signed-off-by: Haiyue Wang
---
devtools/check-symbol-change.sh | 8
1 file changed, 8 insertions(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index ed2178e36..7b6d5f40f 100
20/04/2020 19:34, Aaron Conole:
> "Burakov, Anatoly" writes:
> > Nitpicking, but i believe the coding style guide discourages using
> > boolean syntax for anything other than boolean checks, and it is
> > better to use a more explicit `if (x == NULL)`.
>
> I see, it does. Looking at the code-bas
I'll review v2 promptly, some minor comments from me below
(taking into account that Olivier's review notes are applied).
On 1/6/20 11:34 AM, Somnath Kotur wrote:
> Certain hardware may be able to strip and/or save only the outermost
> VLAN instead of both the VLANs in the mbuf in a QinQ scenario.
> On Apr 24, 2020, at 6:36 PM, Stephen Hemminger
> wrote:
>
> These are a couple of small fixes to the TAP driver. The first makes it
> more robust to random signals, and the second one adds better error
> reporting.
>
> Stephen Hemminger (2):
> net/tap: simplify netlink send/receive functi
> Aaron Conole (3):
> ip_frag: ensure minimum v4 fragmentation length
> ip_frag: ensure minimum v6 fragmentation length
> ipfrag: add unit test case
Applied, thanks
17/04/2020 01:46, Wang, Yipeng1:
> From: Medvedkin, Vladimir
> >
> > Implement rte_hash_lookup_with_hash_bulk_data() and
> > rte_hash_lookup_with_hash_bulk() - bulk lookup functions with precomputed
> > hash signatures.
> > Add these two functions into performance tests.
> >
> > Signed-off-by: V
25/04/2020 15:30, Thomas Monjalon:
> 17/04/2020 01:46, Wang, Yipeng1:
> > From: Medvedkin, Vladimir
> > >
> > > Implement rte_hash_lookup_with_hash_bulk_data() and
> > > rte_hash_lookup_with_hash_bulk() - bulk lookup functions with precomputed
> > > hash signatures.
> > > Add these two functions
20/04/2020 20:27, Vladimir Medvedkin:
> Change hash function from jhash to crc.
> Precalculate hash signatures for a bulk of keys and then
> use rte_hash_lookup_with_hash_bulk_data() to speed up sad lookup
> Also use rte_hash_add_key_with_hash and _del_key_with_hash with
> precalculated hash signat
On 4/23/20 9:30 PM, Dekel Peled wrote:
> Specified pattern may be translated in different manner.
> For example the pattern "eth / ipv4" can be translated to match
> untagged packets only, since the pattern doesn't specify a vlan item.
vlan -> VLAN
> It can also be translated to match both tagged
This patchset introduces changes to the action record allocation, flow
database entry deletion, and hw flow cache updates. Action record
allocation now allows the actions to scale with the flows.
Additionally, resources attached to a flow database entry are now
correctly released when the critical
From: Mike Baucom
The resource function did not have a method of invalidating or
indicating that a resource is uninitialized. Added an invalid enum so
that processing works correctly for partially added flows.
Signed-off-by: Mike Baucom
Reviewed-by: Kishore Padmanabha
Reviewed-by: Ajit Khapar
From: Mike Baucom
The ulp required changes to properly call the index table management
routines and use the index for external memory indices. The ulp no
longer has to account for stride as the tf_core returns the actual
offset, not a 0 based index.
Signed-off-by: Mike Baucom
Reviewed-by: Kish
From: Shahaji Bhosle
Updated the params list to include flush timer, this will
allow users to set the HW flush timer value in 10th of second.
Setting 0 will disable the pending cache flush feature.
Signed-off-by: Shahaji Bhosle
Signed-off-by: Randy Schacher
Signed-off-by: Venkat Duvvuru
Revie
From: Farah Smith
- Added support variable sized action records
- Additional error checking on table scope params
- Single external pool supported per direction
- Changed to return action record pointer
- Allows action pool to fully utilize the number of flows
Signed-off-by: Farah Smith
Signed-
On Sat, Apr 25, 2020 at 8:10 AM Wang, Haiyue wrote:
>
> Hi David,
>
> Try to fix the issues you mentioned, except below, plan to
> another patch set, I need more time to test these adding.
Thanks for working on this topic.
>
>
>
> We are missing updates on devtools/check-abi-version.sh and
25/04/2020 16:21, David Marchand:
> On Sat, Apr 25, 2020 at 8:10 AM Wang, Haiyue wrote:
> > - For fully experimental libraries, we have a special so version:
> > https://git.dpdk.org/dpdk/tree/drivers/meson.build#n131
> >
> > This will apply to common drivers that will be 100% internal.
> >
On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang wrote:
>
> Add checks during build to ensure that all symbols in the INTERNAL
> version map section have __internal tags on their definitions, and
> enable the warnings needed to announce their use.
>
> Signed-off-by: Haiyue Wang
> ---
> MAINTAINERS
On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang wrote:
>
> No need to restrict the ABI on symbols that are only used by core
> libraries.
>
> Signed-off-by: Haiyue Wang
Rather than add a special case for INTERNAL, we can invert the logic
in this script: identify "stable" sections symbol.
I went with
20/04/2020 18:05, Phil Yang:
> This patch depends on patch:
> http://patchwork.dpdk.org/patch/65997/
In order to ease patch tracking, you should have kept the first patch
in the next version of your series. We don't split series in general.
On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang wrote:
>
> Move the internal function into INTERNAL session to avoid the ABI
> checking, and it is only used for DPDK drivers or related library.
>
> __rte_internal funA
>
> INTERNAL {
> global:
>
> funA
> };
Thanks a lot for working on
On Mon, Mar 16, 2020 at 9:38 PM David Christensen
wrote:
>
> All recent POWER systems, Power 8 and 9 specifically, support an IOMMU
> (it can't be disabled). The functionality of the IOMMU is different
> depending on whether it's running on a bare metal PowerNV system or in
> a virtual environment
> -Original Message-
> From: Thomas Monjalon
> Sent: Saturday, April 25, 2020 10:36 PM
> To: Phil Yang
> Cc: erik.g.carri...@intel.com; rsanf...@akamai.com;
> david.march...@redhat.com; konstantin.anan...@intel.com;
> jer...@marvell.com; hemant.agra...@nxp.com; Honnappa Nagarahalli
> ; Ga
On Sat, Jan 4, 2020 at 2:35 AM Stephen Hemminger
wrote:
>
> The netlink socket for flow creation was left open and never
> closed.
>
> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
> Cc: pascal.ma...@6wind.com
> Cc: sta...@dpdk.org
> Signed-off-by: Stephen Hemminger
Afaics, su
04/01/2020 02:33, Stephen Hemminger:
> The priority of the message about drivers not using new (correct)
> behaviour on close was debug. And debug messages are typically surpressed
> and never seen. Raise the priority so that broken drivers are visible
> and hopefully get developers to fix.
>
> S
16/04/2020 13:00, Kevin Laatz:
> This patch adds CPU flags which will enable the detection of ISA
> features available on more recent x86 based CPUs.
[...]
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> +; Ignore this enum update as it should not be allocated by the app
25/04/2020 17:51, Phil Yang:
> From: Thomas Monjalon
> > 20/04/2020 18:05, Phil Yang:
> > > This patch depends on patch:
> > > http://patchwork.dpdk.org/patch/65997/
> >
> > In order to ease patch tracking, you should have kept the first patch
> > in the next version of your series. We don't spli
On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger
wrote:
>
> When rte_eal_cleanup is called, free all the memory
> associated with dynamic log levels and types.
>
> Fixes: c1b5fa94a46f ("eal: support dynamic log types")
> Cc: olivier.m...@6wind.com
> Signed-off-by: Stephen Hemminger
> ---
> lib/l
On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger
wrote:
>
> Calling rte_eal_cleanup() should cause DPDK to cleanup all
> outstanding resources including file descriptors.
>
> Signed-off-by: Stephen Hemminger
> ---
> lib/librte_eal/common/eal_private.h | 7 +++
> lib/librte_eal/linux/eal/ea
> -Original Message-
> From: David Marchand
> Sent: Saturday, April 25, 2020 22:39
> To: Wang, Haiyue
> Cc: dev ; Thomas Monjalon ; Richardson,
> Bruce
> ; Yigit, Ferruh ; Neil
> Horman
> ; Ray Kinsella
> Subject: Re: [PATCH v7 0/6] dpdk: introduce __rte_internal tag
>
> On Sat, Apr 2
On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger
wrote:
>
> When rte_eal_cleanup is called the interrupt thread and
> associated resources should be cleaned up.
>
> Signed-off-by: Stephen Hemminger
> ---
> lib/librte_eal/common/eal_private.h | 10 ++
> lib/librte_eal/linux/eal/eal.
24/04/2020 09:24, Phil Yang:
> Volatile has no ordering semantics. The rte_timer structure defines
> timer status as a volatile variable and uses the rte_r/wmb barrier
> to guarantee inter-thread visibility.
>
> This patch optimized the volatile operation with c11 atomic operations
> and one-way b
> > rte_timer_subsystem_initialized is a global variable that can be accessed by
> > multiple processes simultaneously. Hence, any access to
> > rte_timer_subsystem_initialized should be protected by
> > rte_mcfg_timer_lock.
> >
> > Fixes: f9d6cd8bfe9e ("timer: fix resource leak in finalize")
> >
12/04/2020 17:04, jer...@marvell.com:
> --- a/devtools/check-includes.sh
> +++ b/devtools/check-includes.sh
> @@ -23,7 +23,7 @@
> # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
> # C/C++ compilation flags.
> #
> -# IGNORE contains a list of shell patterns matching file
04/03/2020 16:28, Luca Boccassi:
> On Wed, 2020-03-04 at 14:34 +, Kevin Traynor wrote:
> > On 29/02/2020 16:37, luca.bocca...@gmail.com wrote:
> > > Debian's linter is getting more and more annoy^^smart and now
> > > parses binaries
> > > for typos too - CC stable to get it off my back in the
On Sat, Apr 25, 2020 at 7:02 AM Ajit Khaparde
wrote:
> This patchset introduces changes to the action record allocation, flow
> database entry deletion, and hw flow cache updates. Action record
> allocation now allows the actions to scale with the flows.
> Additionally, resources attached to a f
Hi David,
> -Original Message-
> From: David Marchand
> Sent: Saturday, April 25, 2020 22:39
> To: Wang, Haiyue
> Cc: dev ; Thomas Monjalon ; Richardson,
> Bruce
> ; Yigit, Ferruh ; Neil
> Horman
> ; Ray Kinsella
> Subject: Re: [PATCH v7 0/6] dpdk: introduce __rte_internal tag
>
> On
While adding error handling to tap device, I noticed we already have two
places rolling their own netlink message handling (tap and mlx5) and now
with proposed IF proxy there is a third.
Netlink is non-trivial and easy to get wrong and doing error handling
also requires work. There should be a com
On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger
wrote:
>
> Recently started using valgrind with DPDK, and the results
> are not clean.
>
> The DPDK has a function that applications can use to tell it
> to cleanup resources on shutdown (rte_eal_cleanup). But the
> current coverage of that API is s
25/04/2020 21:24, Stephen Hemminger:
> While adding error handling to tap device, I noticed we already have two
> places rolling their own netlink message handling (tap and mlx5) and now
> with proposed IF proxy there is a third.
>
> Netlink is non-trivial and easy to get wrong and doing error han
24/04/2020 05:21, Joyce Kong:
> Bitwise operation APIs are defined and used in a lot of PMDs,
> which caused a huge code duplication. To reduce duplication,
> this patch consolidates them into a common API family.
[...]
> +rte_get_bit32_relaxed(unsigned int nr, volatile uint32_t *addr)
> +rte_set_b
On 4/24/2020 11:28 AM, Dumitrescu, Cristian wrote:
>
>
>> -Original Message-
>> From: Nithin Dabilpuram
>> Sent: Wednesday, April 22, 2020 6:21 PM
>> To: Singh, Jasvinder ; Dumitrescu, Cristian
>> ; Thomas Monjalon
>> ; Yigit, Ferruh ; Andrew
>> Rybchenko
>> Cc: dev@dpdk.org; jer...@mar
On Tue, Apr 21, 2020 at 1:26 AM Thomas Monjalon wrote:
>
> The EAL options and app-specific options are separated
> with double dashes.
>
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
>
> Fixes: af7507
On Thu, Mar 12, 2020 at 5:30 PM wrote:
>
> From: Luca Boccassi
>
> Debian and Ubuntu switched years ago from /usr/share/hwdata to
> /usr/share/misc,
> and the former is just a compat symlink now.
> We are starting to get bug reports to nudge us into changing.
> So check the new path first, and t
06/02/2020 15:36, Jerin Jacob:
> On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon wrote:
> > 21/01/2020 09:00, jer...@marvell.com:
> > > From: Jerin Jacob
> > >
> > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > creates a lot of clutter on boot-up, typically one needs
> >
24/04/2020 19:08, Vijaya Mohan Guvva:
> For pci devices presented through igb_uio, pcidev->mem_resource[] is
> not populated when the device is initialized for secondary process.
>
> Initialize pcidev->mem_resource[] with pci-bar mapped addresses.
>
> Fixes: c752998b (pci: introduce library and d
07/04/2020 09:56, Muhammad Bilal:
> Bugzilla ID: 353
> Cc: dev@dpdk.org
> Cc: sta...@dpdk.org
> Cc: hemant.agra...@nxp.com
> Signed-off-by: Muhammad Bilal
Acked-by: Hemant Agrawal
No need to Cc stable in my opinion, as there is no bug fixed.
Changing the name to:
mbuf: prevent setting m
From: Olivier Matz
Change rte_mempool_populate_iova() and rte_mempool_populate_iova() to
return 0 instead of -EINVAL when there is not enough room to store one
object, as it can be helpful for applications to distinguish this
specific case.
As this is an ABI change, use symbol versioning to pres
https://bugs.dpdk.org/show_bug.cgi?id=225
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|C
https://bugs.dpdk.org/show_bug.cgi?id=377
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Status|IN_PROGRESS |RESOLVED
Resolutio
https://bugs.dpdk.org/show_bug.cgi?id=400
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|U
https://bugs.dpdk.org/show_bug.cgi?id=237
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|C
https://bugs.dpdk.org/show_bug.cgi?id=253
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|C
From: "Wei Hu (Xavier)"
Currently, when running start/clear stats&xstats/stop command many times
based on testpmd application, there are incorrect forward Rx/Tx-packets
stats as below:
-- Forward statistics for port 0 --
RX-packets: 18446744073709544808 RX-dropped
Hi, Ferruh Yigit
On 2020/4/25 0:12, Ferruh Yigit wrote:
On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote:
From: Chengwen Feng
Currently, when running start/clear stats&xstats/stop command many times
based on testpmd application, there are incorrect RX/TX-packets stats as
below:
--
On 4/26/2020 2:36 AM, Wei Hu (Xavier) wrote:
> Hi, Ferruh Yigit
>
> On 2020/4/25 0:12, Ferruh Yigit wrote:
>> On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote:
>>> From: Chengwen Feng
>>>
>>> Currently, when running start/clear stats&xstats/stop command many times
>>> based on testpmd application, th
The kernel module vfio-pci introduces the VF token to enable SR-IOV
support since 5.7.
The VF token can be set by a vfio-pci based PF driver and must be known
by the vfio-pci based VF driver in order to gain access to the device.
Signed-off-by: Haiyue Wang
Acked-by: Vamsi Attunuru
Tested-by: Va
Add the dependent header files explicitly, so that the user just needs
to include the 'rte_uuid.h' header file directly to avoid compile error:
(1). rte_uuid.h:97:55: error: unknown type name ‘size_t’
(2). rte_uuid.h:58:2: error: implicit declaration of function ‘memcpy’
Fixes: 6bc67c497a51 ("ea
v10: Use the __rte_internal to mark the internal API changing.
v9: Rewrite the document.
v8: Update the document.
v7: Add the Fixes tag in uuid, the release note and help
document.
v6: Drop the Fixes tag in uuid, since the file has been
moved to another place, not suitable to apply on s
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, April 24, 2020 4:09 PM
> To: Joyce Kong
> Cc: step...@networkplumber.org; david.march...@redhat.com;
> m...@smartsharesystems.com; jer...@marvell.com;
> bruce.richard...@intel.com; ravi1.ku...@amd.com; rm...@marvell.com;
> shsha
Ring initialization is different when inorder feature negotiated. This
action should dependent on negotiated feature bits.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 94ba7a3ec..e450477e8 100644
--
Previously, virtio split ring vectorized path was enabled by default.
This is not suitable for everyone because that path dose not follow
virtio spec. Add new devarg for virtio vectorized path selection. By
default vectorized path is disabled.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coqueli
This patch set introduced vectorized path for packed ring.
The size of packed ring descriptor is 16Bytes. Four batched descriptors
are just placed into one cacheline. AVX512 instructions can well handle
this kind of data. Packed ring TX path can fully transformed into
vectorized path. Packed ring
Add new devarg for virtio user device vectorized path selection. By
default vectorized path is disabled.
Signed-off-by: Marvin Liu
diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index 902a1f0cf..d59add23e 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.
Introduce free threshold setting in Rx queue, its default value is 32.
Limit the threshold size to multiple of four as only vectorized packed
Rx function will utilize it. Virtio driver will rearm Rx queue when
more than rx_free_thresh descs were dequeued.
Signed-off-by: Marvin Liu
Reviewed-by: Ma
Move offload, xmit cleanup and packed xmit enqueue function to header
file. These functions will be reused by packed ring vectorized path.
Signed-off-by: Marvin Liu
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 84f4cf946..a549991aa 100644
--- a/drivers/ne
Rewrite vectorized path selection logic. Default setting comes from
vectorized devarg, then checks each criteria.
Packed ring vectorized path need:
AVX512F and required extensions are supported by compiler and host
VERSION_1 and IN_ORDER features are negotiated
mergeable feature is not
Document packed virtqueue vectorized path selection logic in virtio net
PMD.
Signed-off-by: Marvin Liu
Reviewed-by: Maxime Coquelin
diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index d59add23e..dbcf49ae1 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virti
Optimize packed ring Rx path with SIMD instructions. Solution of
optimization is pretty like vhost, is that split path into batch and
single functions. Batch function is further optimized by AVX512
instructions. Also pad desc extra structure to 16 bytes aligned, thus
four elements will be saved in
Optimize packed ring Tx path like Rx path. Split Tx path into batch and
single Tx functions. Batch function is further optimized by AVX512
instructions.
Signed-off-by: Marvin Liu
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index 5c112cac7..b7d52d497 1006
Currently, while creating the flow with meter, meter id is saved to the
rte flow. While destroying the flow, the meter object will be found by
the meter id, so the meter object will be released accordingly. But as
the meter id is configured by user, while the meter id is set to 0, it
doesn't make a
Thanks,
Feng Li
David Marchand 于2020年4月25日周六 上午1:10写道：
>
> On Fri, Apr 24, 2020 at 12:43 PM Li Feng wrote:
> >
> > Commit 8a4baf06c17a ("mem: mark pages as not accessed when reserving VA")
> > has mapped the initialized memory with PROT_NONE, and when it's unmapped,
> > eal_memalloc.c should re
This patch fixes errors caused by using Unix-only functions in tracing
EAL. It introduces new internal EAL wrappers for directory management
and provides simple, but correct implementation for some EAL functions
required for tracing.
This patch implements rte_get_tsc_hz() instead of basing upon a
Add EAL private functions to support trace storage:
* eal_persistent_data_path()
* eal_dir_create()
Replace clock_gettime(CLOCK_REALTIME) with C11 timespec_get().
Implementation is provided for MinGW-w64 that misses this function.
Provide minimum viable implementations of malloc and timer functi
Limited version imported previously lacks STAILQ macros used by tracing
and SLIST macros used by memory management. Import a complete file from
FreeBSD, since its license exception is already approved by Technical
Board.
Fixes: 321dd5f8fa62 ("trace: add internal init and fini interface")
Signed-o
Sorry, because the mail filtering is wrong, I have not seen this mail, and the
community canceled the patch. I resubmitted a pacth, only modified the format.
Judging this flag, it feels a bit more complicated.
New patch: http://patches.dpdk.org/patch/68713/
-Original Message-
From: Step
From: Yunjian Wang
Zero is a valid fd. When ccp_probe_device() is failed, the uio_fd won't be
closed thus leading fd leak.
Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/crypto/ccp/ccp_dev.c | 2 +-
1 file changed, 1 inserti
https://bugs.dpdk.org/show_bug.cgi?id=462
Bug ID: 462
Summary: command kvargs_autotest excute failed on freebsd with
gcc and clang
Product: DPDK
Version: 20.05
Hardware: x86
OS: FreeBSD
Status: U
84 matches
Mail list logo
