20/04/2020 19:34, Aaron Conole: > "Burakov, Anatoly" <anatoly.bura...@intel.com> writes: > > Nitpicking, but i believe the coding style guide discourages using > > boolean syntax for anything other than boolean checks, and it is > > better to use a more explicit `if (x == NULL)`. > > I see, it does. Looking at the code-base, I see it mixed all over, some > places using 'if (!ptr)' and others 'if (ptr == NULL)'. Actually, even > in the flow_filtering.rst doc, it implies that if (!ptr) is acceptable. > > Since I'm spinning a v6 with the constants, I'll fold this change in - > maybe it makes sense to clean it up everywhere to help mitigate the > confusion (for example, I most recently did work in the eal and the !ptr > is all over there). WDYT?
In general I agree cleanups are good, avoiding confusion. About changing the whole codebase, just for styling I am not sure. Please let's start with documentation fixes and discuss whether to move forward.
