Sorry, because the mail filtering is wrong, I have not seen this mail, and the community canceled the patch. I resubmitted a pacth, only modified the format. Judging this flag, it feels a bit more complicated.
New patch: http://patches.dpdk.org/patch/68713/ -----Original Message----- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Friday, March 27, 2020 6:02 AM To: Peng, ZhihongX <zhihongx.p...@intel.com> Cc: Ye, Xiaolong <xiaolong...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org; Wang, Liang-min <liang-min.w...@intel.com> Subject: Re: [dpdk-dev] [DPDK] net/ixgbe: fix status synchronization on BSD On Tue, 24 Mar 2020 23:31:11 -0400 zhihongx.p...@intel.com wrote: > +/*BSD has no interrupt mechanism, so force NIC status > +synchronization.*/ #ifdef RTE_EXEC_ENV_FREEBSD > + wait = 1; > +#endif > + Please format comments correctly. Is there a better way to detect interrupt mechanism with a function? #ifdef's make for hard to maintain code.