Re: [dpdk-dev] [EXT] [RFC v2] eal: add VFIO-PCI SR-IOV support

2020-04-10 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Haiyue Wang > Sent: Friday, April 10, 2020 1:03 PM > To: dev@dpdk.org; tho...@monjalon.net; Vamsi Krishna Attunuru > ; Jerin Jacob Kollanukkaran ; > alex.william...@redhat.com; david.march...@redhat.com > Cc: Haiyue Wang > Subject: [EXT] [RFC v2] eal: add V

Re: [dpdk-dev] [PATCH dpdk-dev v2 1/2] eal: introduce rte-init queue for libraries initialization

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 11:48 AM Jerin Jacob wrote: > Three more items are missing in this patch 1) Unit test case for new API 2) Make the new API __rte_experimal 3) Update the .map file > On Thu, Apr 9, 2020 at 8:33 PM wrote: > > > > From: Tonghao Zhang > > > > This patch introduces last-in

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread David Marchand
On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > The global level is just disabling some logs even if it is enabled > > in the logtype level. > > It only makes usage complicate. > > We should consider only logtype levels. > > OK. Do we care about the following use case? > # Trace only specif

Re: [dpdk-dev] [PATCH] build: gcc 10 disable stringop-overflow warnings

2020-04-10 Thread Bruce Richardson
On Fri, Apr 10, 2020 at 11:51:56AM +0100, Kevin Traynor wrote: > On 07/04/2020 17:27, Kevin Traynor wrote: > > stringop-overflow warns when it sees a possible overflow > > in a string operation. > > > > In the rte_memcpy functions different implementations are > > used depending on the size. strin

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Bruce Richardson
On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > 10/04/2020 12:42, Bruce Richardson: > > On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > > > --- a/app/test/meson.build > > > +++ b/app/test/meson.build > > > has_hugepage = true > > > if is_linux > > > > Since

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 6:45 PM David Marchand wrote: > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > The global level is just disabling some logs even if it is enabled > > > in the logtype level. > > > It only makes usage complicate. > > > We should consider only logtype levels. > >

Re: [dpdk-dev] [PATCH v4 0/3] Fix and add txq xstats

2020-04-10 Thread Ferruh Yigit
On 4/10/2020 10:21 AM, Xiaoyun wang wrote: > This patch fixes PF firmware hotactive problem, optimizes > log style and adds txq xstats members. > > -- > v3->v4: > - fix PF firmware hotactive problem > - optimize log style > - adds txq xstats members > > v2->v3: > - fix FW hotactive prob

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread David Marchand
On Fri, Apr 10, 2020 at 3:30 PM Jerin Jacob wrote: > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > wrote: > > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > The global level is just disabling some logs even if it is enabled > > > > in the logtype level. > > > > It only makes

Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats

2020-04-10 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin > Hi Matan, > > On 3/16/20 4:12 PM, Matan Azrad wrote: > > The vDPA device offloads all the datapath of the vhost device to the > > HW device. > > > > In order to expose to the user traffic information this patch > > introduce new API to get traffic statistics per

Re: [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array

2020-04-10 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin > On 3/31/20 1:12 PM, Matan Azrad wrote: > > As a preparation to listen the virtqs status before the device is > > configured, manage the virtqs structures in array instead of list. > > > > Signed-off-by: Matan Azrad > > Acked-by: Viacheslav Ovsiienko > > --- > >

Re: [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array

2020-04-10 Thread Maxime Coquelin
On 4/10/20 3:58 PM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin >> On 3/31/20 1:12 PM, Matan Azrad wrote: >>> As a preparation to listen the virtqs status before the device is >>> configured, manage the virtqs structures in array instead of list. >>> >>> Signed-off-by: Matan Azrad

Re: [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop

2020-04-10 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin > On 3/31/20 1:12 PM, Matan Azrad wrote: > > In live migration, before loging the virtq, the driver queries the > > virtq > s/loging/logging/ Ok, can this small change be done in integration? > > indexes after moving it to suspend mode. > > > > Separate this met

Re: [dpdk-dev] [PATCH v4 0/3] net/mlx5: add large packet size support to MPRQ

2020-04-10 Thread Matan Azrad
From: Alexander Kozyrev > In order to support the 9K MTU the MPRQ feature should be updated to > allow a packet to take more than one stride (single linear buffer). > Receiving a packet into multiple adjacent strides should be implemented. > The reason preventing the packet to be received into m

Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats

2020-04-10 Thread Maxime Coquelin
On 4/10/20 3:54 PM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin >> Hi Matan, >> >> On 3/16/20 4:12 PM, Matan Azrad wrote: >>> The vDPA device offloads all the datapath of the vhost device to the >>> HW device. >>> >>> In order to expose to the user traffic information this patch >>

Re: [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop

2020-04-10 Thread Maxime Coquelin
On 4/10/20 3:59 PM, Matan Azrad wrote: > > Hi Maxime > > From: Maxime Coquelin >> On 3/31/20 1:12 PM, Matan Azrad wrote: >>> In live migration, before loging the virtq, the driver queries the >>> virtq >> s/loging/logging/ > Ok, can this small change be done in integration? Of course! > >>

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Aaron Conole
Thomas Monjalon writes: > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > in app/test/meson.build and then adding it as a build dependency. > This causes build loop if the timestamp of this file keeps changing. > > It is fixed by hiding hugepage check in a shell script.

Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats

2020-04-10 Thread Matan Azrad
From: Maxime Coquelin > Sent: Friday, April 10, 2020 5:04 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Slava Ovsiienko ; Shahaf Shuler > ; Xiao Wang ; Tiwei Bie > > Subject: Re: [PATCH] [RFC] vhost: inroduce operation to get vDPA queue > stats > > > > On 4/10/20 3:54 PM, Matan Azrad wrote: > >

Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats

2020-04-10 Thread Maxime Coquelin
On 4/10/20 4:15 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> Sent: Friday, April 10, 2020 5:04 PM >> To: Matan Azrad ; dev@dpdk.org >> Cc: Slava Ovsiienko ; Shahaf Shuler >> ; Xiao Wang ; Tiwei Bie >> >> Subject: Re: [PATCH] [RFC] vhost: inroduce operation to get vDPA queue >> stats

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Wiles, Keith
> On Apr 10, 2020, at 5:49 AM, Morten Brørup wrote: > >> From: Ciara Power [mailto:ciara.po...@intel.com] >> Sent: Wednesday, April 8, 2020 6:50 PM >> >> This patchset extensively reworks the telemetry library adding new >> functionality and simplifying much of the existing code, while >> main

Re: [dpdk-dev] [PATCH v2 1/4] raw/common: add multi-function interface

2020-04-10 Thread Coyle, David
Hi Pablo Thank you for reviewing and the comments - see below for resolutions. The changes will be available in v3 shortly David > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, April 6, 2020 5:09 PM > > Hi David, > > > -Original Message- > > From: Coyle, Davi

Re: [dpdk-dev] [PATCH v2 2/4] raw/aesni_mb: add aesni_mb raw device

2020-04-10 Thread Coyle, David
Hi Pablo Thank you for reviewing and the comments - see below for resolutions. The changes will be available in v3 shortly David > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, April 7, 2020 7:51 PM > > Hi David, > > > -Original Message- > > From: Coyle, Dav

Re: [dpdk-dev] [PATCH v2 4/4] app/crypto-perf: add support for multi-function processing

2020-04-10 Thread Coyle, David
Hi Pablo, Thank you for reviewing and the comments - see below for resolutions. The changes will be available in v3 shortly David > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, April 7, 2020 7:55 PM > > > -Original Message- > > From: Coyle, David > > Sent:

Re: [dpdk-dev] [PATCH v2 1/4] raw/common: add multi-function interface

2020-04-10 Thread Coyle, David
Hi Pablo Thank you for reviewing and the comments - see below for resolutions. The changes will be available in v3 shortly David > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, April 7, 2020 7:56 PM > > Hi David, > > > -Original Message- > > From: Coyle, Dav

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 7:15 PM David Marchand wrote: > > On Fri, Apr 10, 2020 at 3:30 PM Jerin Jacob wrote: > > > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > > wrote: > > > > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > > The global level is just disabling some logs eve

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Wiles, Keith
> On Apr 9, 2020, at 4:37 AM, Thomas Monjalon wrote: > > 09/04/2020 11:19, Bruce Richardson: >> On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: >>> 08/04/2020 18:49, Ciara Power: This patchset extensively reworks the telemetry library adding new functionality and sim

[dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-10 Thread David Coyle
Introduction This patchset adds a new AESNI-MB Multi-Function raw device PMD for utilizing multi-function capabilities of the Intel IPSec Multi Buffer library. The aim of this rawdev PMD is to provide a way of combining one or more common packet-processing functions into a single ope

[dpdk-dev] [PATCH v3 1/4] raw/common: add multi-function interface

2020-04-10 Thread David Coyle
The multi-function interface provides a way of combining one or more different types of packet processing functions into a single operation. The interface can be used by applications to send the combined operations to a optimized software or hardware accelerator via a raw device. Signed-off-by: Da

[dpdk-dev] [PATCH v3 2/4] raw/aesni_mb_mfn: add aesni_mb_mfn raw device PMD

2020-04-10 Thread David Coyle
Add an AESNI-MB Multi-Function raw device PMD, for utilizing multi-function capabilities of the Intel IPSec Multi Buffer library. This PMD uses the multi-function interface to allow combined operations be sent to the Intel IPSec Multi Buffer library. Signed-off-by: David Coyle Signed-off-by: Mair

[dpdk-dev] [PATCH v3 3/4] test/rawdev: add aesni_mb_mfn raw device tests

2020-04-10 Thread David Coyle
Add unit tests for the AESNI-MB Multi-Function raw device PMD. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- app/test/test_rawdev.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c index 524a9d5f3..eae88c

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Thomas Monjalon
10/04/2020 15:25, Bruce Richardson: > On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > > 10/04/2020 12:42, Bruce Richardson: > > > On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > > > > --- a/app/test/meson.build > > > > +++ b/app/test/meson.build > > > > has_hu

[dpdk-dev] [PATCH v3 4/4] doc: update docs for aesni_mb_mfn raw device PMD

2020-04-10 Thread David Coyle
Update documentation for the AESNI-MB Multi-Function raw device PMD. Signed-off-by: David Coyle Signed-off-by: Mairtin o Loingsigh --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + doc/guides/rawdevs/aesni_mb_mfn.rst| 219 ++

Re: [dpdk-dev] [PATCH v4 19/29] node: add generic ipv4 lookup node

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 03:50:06PM +0530, Nithin Dabilpuram wrote: > On Fri, Apr 10, 2020 at 01:07:34AM +0200, Andrzej Ostruszka wrote: > > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > > From: Pavan Nikhilesh > > > > > > Add IPv4 lookup process function for ip4_lookup node. > > > This node p

Re: [dpdk-dev] [PATCH] vhost/crypto: fix missed user protocol flag

2020-04-10 Thread Maxime Coquelin
On 1/29/20 11:19 AM, Fan Zhang wrote: > Fixes: 939066d96563 ("vhost/crypto: add public function implementation") > Cc: sta...@dpdk.org > > This patch fixes the vhost crypto missed > "VHOST_USER_PROTOCOL_F_CONFIG" flag problem during initialization. > Newer Qemu version requires this feature ena

Re: [dpdk-dev] [PATCH] examples/vhost_blk: use common macros for min/max

2020-04-10 Thread Maxime Coquelin
On 2/19/20 11:39 AM, Thomas Monjalon wrote: > The macros RTE_MIN and RTE_MAX can be used in DPDK applications. > > This change implies fixing the sign of used_len as size_t > as defined in vhost_strcpy_pad(). > > Signed-off-by: Thomas Monjalon > --- > examples/vhost_blk/blk.c |

Re: [dpdk-dev] [PATCH] vhost: fix packed ring zero-copy

2020-04-10 Thread Maxime Coquelin
On 3/16/20 4:38 PM, Marvin Liu wrote: > Available buffer ID should be stored in the zmbuf in the packed-ring > dequeue path. There's no guarantee that local queue avail index is > equal to buffer ID. > > Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue") > Cc: sta...@

Re: [dpdk-dev] [PATCH v1] net/vhost: add config option for linear and extbuf

2020-04-10 Thread Maxime Coquelin
On 2/26/20 11:00 AM, Sivaprasad Tummala wrote: > Added vHost PMD arguments 'linear-buffer' and 'ext-buffer' > to configure 'RTE_VHOST_USER_LINEARBUF_SUPPORT' and > 'RTE_VHOST_USER_EXTBUF_SUPPORT' flags in the vhost library > > Signed-off-by: Sivaprasad Tummala > --- > doc/guides/nics/vhost.r

Re: [dpdk-dev] [PATCH] net/vhost: enable promiscuous and multicast by default

2020-04-10 Thread Maxime Coquelin
On 2/26/20 2:45 PM, Xiaolong Ye wrote: > With this patch, the promiscuous and multicast fields are initialized as > enabled for vhost PMD by default, this allows the devices to be used when > running applications that attempt to enable promiscuous or multicast mode. > Similar things have done fo

Re: [dpdk-dev] [PATCH v1 0/2] small fixes

2020-04-10 Thread Maxime Coquelin
On 3/7/20 2:22 PM, Xiaolong Ye wrote: > This series contains small fixes for virtio and vhost. > > Xiaolong Ye (2): > net/virtio: fix for out of date comment > vhost: remove unused variable > > drivers/net/virtio/virtio_ethdev.c | 6 +++--- > lib/librte_vhost/vhost.h | 1 - > 2

Re: [dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak

2020-04-10 Thread Maxime Coquelin
On 3/5/20 3:54 AM, Itsuro Oda wrote: > If a vhost device is closed before eth_dev_configure is done > to the device, internal resources allocated to the device > would not be freed. This patch fixes it. > > Fixes: 3d01b759d267 ("net/vhost: delay driver setup") > Cc: sta...@dpdk.org > > Signed-

Re: [dpdk-dev] [PATCH] vhost: prefix vDPA enum value for PCI address type

2020-04-10 Thread Maxime Coquelin
On 3/26/20 3:14 PM, Maxime Coquelin wrote: > In order to avoid potential conflicts, rename the PCI_ADDR > enum value to VDPA_ADDR_PCI in vdpa_addr_type_enum. > > All symbols referencing this enum are experimental, so it > does not break API policy. > > Signed-off-by: Maxime Coquelin > --- >

Re: [dpdk-dev] [PATCH v3] vhost: make iotlb cache name unique among multi processes

2020-04-10 Thread Maxime Coquelin
On 3/12/20 12:19 AM, Itsuro Oda wrote: > Currently, iotlb cache name is comprised of vid and virtqueue > index. For example, "iotlb_cache_0_0". Because vid is assigned > per process, iotlb cache name is not unique among multi processes. > For example a secondary process uses a vhost > (ex. eth_v

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Thomas Monjalon
10/04/2020 16:39, Wiles, Keith: > > On Apr 9, 2020, at 4:37 AM, Thomas Monjalon wrote: > > 09/04/2020 11:19, Bruce Richardson: > >> On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > >>> 08/04/2020 18:49, Ciara Power: > This patchset extensively reworks the telemetry library a

Re: [dpdk-dev] [EXT] Re: [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API

2020-04-10 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 02:52:33PM +0200, Andrzej Ostruszka wrote: > External Email > > -- > On 4/10/20 7:09 AM, Nithin Dabilpuram wrote: > > On Fri, Apr 10, 2020 at 01:07:17AM +0200, Andrzej Ostruszka wrote: > [...] > >>> +struct

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Wiles, Keith
> On Apr 10, 2020, at 9:51 AM, Thomas Monjalon wrote: > > 10/04/2020 16:39, Wiles, Keith: >>> On Apr 9, 2020, at 4:37 AM, Thomas Monjalon wrote: >>> 09/04/2020 11:19, Bruce Richardson: On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: > 08/04/2020 18:49, Ciara Power: >

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread David Marchand
On Fri, Apr 10, 2020 at 4:38 PM Jerin Jacob wrote: > > - I am still looking at the event record mode. > > I just wonder why we have this notion per tracepoint. > > The documentation talks about it being an attribute of the trace > > buffers, and the described behavior looks fine. > > But if we can

[dpdk-dev] [PATCH v4 1/2] crypto/aesni_mb: support DOCSIS AES-256

2020-04-10 Thread Mairtin o Loingsigh
This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh Acked-by: Pablo de Lara --- v2: Added IPSec MB version check v3: Added doc update v4: Added missing patch --- doc/guides/rel_notes/release_20_05.rst | 5 + drivers/crypto/aesni_mb/rte_a

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Thomas Monjalon
10/04/2020 17:00, David Marchand: > On Fri, Apr 10, 2020 at 4:38 PM Jerin Jacob wrote: > > > - Another comment, on the form, I can see that we talk about dataplane > > > tracepoints and fastpath API. > > > Is there a difference? or could everything be named in a consistent > > > > No. Both are the

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Thomas Monjalon
10/04/2020 15:29, Jerin Jacob: > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > wrote: > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > # In summary: > > > ~ > > > # In the existing code: > > > The trace will be emitted when > > > a) When the trace is enabled > > > AND

[dpdk-dev] [dpdk-dev v3 0/4] add RSS configuration for iavf

2020-04-10 Thread Jeff Guo
Because the VF must be capable of configuring RSS, so add RSS configuration for iavf. The supported protocol rss input set as below. eth-src-only/ eth-dst-only/ svlan/ cvlan/ ipv4/ ipv6/ l3_src_only/ l3_dst_only/ l2tpv3/ esp/ ah/ pfcp/ gtpu down/ gtpu up/ udp/ tcp/ sctp/ This patchset depends on

[dpdk-dev] [dpdk-dev v3 1/4] ethdev: add new RSS offload types

2020-04-10 Thread Jeff Guo
Defines some new RSS offload types for ETH/SVLAN/CVLAN/GTPU/L2TPV3/ ESP/AH/PFCP. Signed-off-by: Jeff Guo --- v3->v2: 1.refine rss offload types. --- lib/librte_ethdev/rte_ethdev.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/li

[dpdk-dev] [dpdk-dev v3 2/4] net/iavf: add RSS configuration for VFs

2020-04-10 Thread Jeff Guo
The VF must be capable of configuring RSS. Add a virtchnl handler to parse a specific RSS configuration, and process the configuration for VFs, such as add or delete a RSS rule. Signed-off-by: Jeff Guo --- v3->v2: 1.add doc in release note 2.refine some naming base on virtchnl definition. --- do

[dpdk-dev] [dpdk-dev v3 3/4] app/testpmd: support GTP PDU type

2020-04-10 Thread Jeff Guo
Add gtp pdu type configure in the cmdline. Signed-off-by: Jeff Guo --- v3->v2: 1.move gtp pdu index from normal to special. --- app/test-pmd/cmdline_flow.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c i

[dpdk-dev] [dpdk-dev v3 4/4] app/testpmd: add new types to RSS hash commands

2020-04-10 Thread Jeff Guo
Add some new types, such as eth-src-only/eth-dst-only/svlan/cvlan/ l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to configure these rss input set by cmdline. Signed-off-by: Jeff Guo --- v3->v2: 1:refine some rss offload types --- app/test-pmd/cmdline.c | 24 ++

Re: [dpdk-dev] [PATCH v4 19/29] node: add generic ipv4 lookup node

2020-04-10 Thread Andrzej Ostruszka
On 4/10/20 4:41 PM, Nithin Dabilpuram wrote: > On Fri, Apr 10, 2020 at 03:50:06PM +0530, Nithin Dabilpuram wrote: >> On Fri, Apr 10, 2020 at 01:07:34AM +0200, Andrzej Ostruszka wrote: [...] + next_hop = (rc == 0) ? next_hop : drop_nh; >>> >>> Maybe simple if here? I see the same in o

[dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-04-10 Thread Mairtin o Loingsigh
This patch adds test vectors for AES-256 and sets AESNI-MB as the target PMD Signed-off-by: Mairtin o Loingsigh Acked-by: Pablo de Lara --- v2: Remove duplicate code --- app/test/test_cryptodev_aes_test_vectors.h | 81 ++ 1 file changed, 81 insertions(+) diff --git

[dpdk-dev] [dpdk-dev v2 1/1] net/ice: Support for GTPU down/up rss configure

2020-04-10 Thread Jeff Guo
Add GTP PDU uplink/donwlink checking in RSS inpust set configuration, in order to support l3 src hash for GTPU uplink, while l3 dst hash for GTPU downlink. Signed-off-by: Jeff Guo --- v2->v1: refine rss offload types --- drivers/net/ice/ice_hash.c | 55 +++--- 1 f

[dpdk-dev] [dpdk-dev v2 0/1] add new rss configuration for ice

2020-04-10 Thread Jeff Guo
add some new protocol rss input set configuration for ice driver, the protocol input set such as below: l3-src for gtpu uplink l3-dst for gtpu downlink This patchset depends on below patch set. (1)http://patches.dpdk.org/project/dpdk/list/?series=8962 add RSS configuration for iavf v2->v

Re: [dpdk-dev] [PATCH v3 1/6] rte_ethdev: change rte_eth_dev_owner_get to return error if unowned

2020-04-10 Thread Ferruh Yigit
On 4/2/2020 6:19 PM, Stephen Hemminger wrote: > For applications that want to check if device is owned, > change the return value of rte_eth_dev_owner_get to return -ENOENT > if there is no owner for the device. > > Change the two drivers (failsafe and netvsc) that are using > this experimental AP

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/6] examples/l2fwd-cat: make applicaton aware of port ownership

2020-04-10 Thread Ferruh Yigit
On 4/2/2020 6:19 PM, Stephen Hemminger wrote: > If a ethdev port is in use for a sub device, then it should not > be allowed in the portmask of application. > > Fixes: 5b7ba31148a8 ("ethdev: add port ownership") > Cc: ma...@mellanox.com > Cc: sta...@dpdk.org > Signed-off-by: Stephen Hemminger <.

Re: [dpdk-dev] [PATCH v4] build: enable allow experimental API flag

2020-04-10 Thread David Marchand
On Fri, Apr 10, 2020 at 2:12 PM David Marchand wrote: > On Fri, Apr 10, 2020 at 11:04 AM wrote: > > > > From: Pavan Nikhilesh > > > > Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and > > meson.build instead enable ALLOW_EXPERIMENTAL_API flag across app, lib and > > driver

Re: [dpdk-dev] [PATCH v3 1/2] bitmap: add create bitmap with all bits set

2020-04-10 Thread Dumitrescu, Cristian
> -Original Message- > From: Suanming Mou > Sent: Friday, April 10, 2020 1:46 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Cc: a...@semihalf.com > Subject: [PATCH v3 1/2] bitmap: add create bitmap with all bits set > > Currently, in the case to use bitmap as resource allocator, after

Re: [dpdk-dev] [dpdk-techboard] rte_atomic deprecation discussion for the tech board meeting

2020-04-10 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > > > > Adding the dev mailing list. We could not complete the discussion today in > the tech board. > > > > It was agreed that the older compilers without C11 atomic API support > > (stdatomic.h) need to be supported and wrappers around C11 built- ins can > be provided. OVS [

Re: [dpdk-dev] [PATCH v2 04/16] telemetry: invert dependency on metrics

2020-04-10 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara > +DEPDIRS-librte_metrics += librte_telemetry endif > > index 0f9f2e0e6f..d116857e2d 100644 > --- a/lib/librte_metrics/meson.build > + deps += ['ethdev', 'telemetry'] The telemetry dependency should be added under CONFIG_RTE_LIBRTE_TELEME

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 6/6] examples/tep_termination: rework the port setup logic

2020-04-10 Thread Ferruh Yigit
On 4/2/2020 6:19 PM, Stephen Hemminger wrote: > The handling of ports in this application had many problems. > It was checking for things that can never happen with current > DPDK library (like rte_ethdev_avail_count() >= RTE_MAX_ETHPORTS) > and it was not checking if the port was owned and should

[dpdk-dev] [PATCH RFC v2 2/7] net/mlx5: dmb for immediate doorbell ring on aarch64

2020-04-10 Thread Gavin Hu
A 'DMB' is enough to evict the merge buffer on aarch64,when the doorbell register is mapped as 'Normal-NC', the counterpart of WC on x86. Otherwise, it is mapped as Device memory, no barriers required at all. Signed-off-by: Gavin Hu --- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 1 file changed, 1 ins

[dpdk-dev] [PATCH RFC v2 1/7] eal: introduce new class of barriers for DMA use cases

2020-04-10 Thread Gavin Hu
In DPDK we use rte_*mb barriers to ensure that memory accesses to DMA regions are observed before MMIO accesses to hardware registers. On AArch64, the rte_*mb barriers are implemented by "DSB" (Data Synchronisation Barrier) style instructions which are the strongest barriers possible. Recently, h

[dpdk-dev] [PATCH RFC v2 0/7] introduce new barrier class and use it for mlx5 PMD

2020-04-10 Thread Gavin Hu
To order writes to various memory types, 'sfence' is required for x86, and 'dmb oshst' is required for aarch64. But within DPDK, there is no abstracted barriers covers this combination: sfence(x86)/dmb(aarch64). So introduce a new barrier class - rte_dma_*mb for this combination, Doorbell ring

[dpdk-dev] [PATCH RFC v2 4/7] net/mlx5: relax barrier for aarch64

2020-04-10 Thread Gavin Hu
To ensure the WQE and doorbell record, which reside in the host memory, are visible to HW before the blue frame, an ordered mlx5_uar_write call is sufficient, a rte_wmb is overkill for aarch64. Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH RFC v2 5/7] net/mlx5: add descriptive comment for a barrier

2020-04-10 Thread Gavin Hu
The barrier is not required or can be moved down if HW waits for the doorbell ring to execute the WQE. This is not the case as HW can start executing the WQE until it gets the ownership(passed by SW writing the doorbell record). Add a decriptive comment for this HW specific behavior. Signed-off-

[dpdk-dev] [PATCH RFC v2 3/7] net/mlx5: relax barrier to order UAR writes on aarch64

2020-04-10 Thread Gavin Hu
To order the writes to host memory and the MMIO device memory, 'DMB' is sufficient on aarch64, as a 'other-multi-copy' architecture. 'DSB' is over-killing, especially in the fast path. Using the rte_dma_wmb can take the advantage on aarch64 while no impacting x86 and ppc. Fixes: 6bf10ab69be0 ("ne

[dpdk-dev] [PATCH RFC v2 6/7] net/mlx5: relax ordering for multi-packet RQ buffer refcnt

2020-04-10 Thread Gavin Hu
From: Phil Yang PMD Rx queue descriptor contains two mlx5_mprq_buf fields, which are the multi-packet RQ buffer header pointers. It uses the common rte_atomic_XXX functions to make sure the refcnt access is atomic. The common rte_atomic_XXX functions are full barriers on aarch64. Optimized it wi

[dpdk-dev] [PATCH RFC v2 7/7] doc: clarify one configuration in mlx5 guide

2020-04-10 Thread Gavin Hu
The 'tx_db_nc' is used to differntiate two mapping types, WC and non-WC, both are actually non-cacheable. The Write-Combining on x86, is not-cacheablei. The Normal-NC, the counterpart on aarch64, is non-cacheable too, as its name suggests, the cache hierarchy was bypassed for accesses to these two

[dpdk-dev] [PATCH v2 00/10] eal: Windows basic memory management

2020-04-10 Thread Dmitry Kozlyuk
This patchset implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * Only 2MB hugepages are supported. * IOVA is always PA, obtained through kernel-mode driver. * No 32-bit support (presumably not demanded). * Ni multi-process support (it is forceful

[dpdk-dev] [PATCH v2 02/10] eal/windows: do not expose private EAL facilities

2020-04-10 Thread Dmitry Kozlyuk
The goal of rte_os.h is to mitigate OS differences for EAL users. In Windows EAL, rte_os.h did excessive things: 1. It included platform SDK headers (windows.h, etc). Those files are huge, require specific inclusion order, and are generally unused by the code including rte_os.h. Declarations

[dpdk-dev] [PATCH v2 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-10 Thread Dmitry Kozlyuk
This driver supports Windows EAL memory management by translating current process virtual addresses to physical addresses (IOVA). Standalone virt2phys allows using DPDK without PMD and provides a reference implementation. Signed-off-by: Dmitry Kozlyuk --- Note: this patch is for dpdk-kmods t

[dpdk-dev] [PATCH v2 04/10] eal/windows: initialize hugepage info

2020-04-10 Thread Dmitry Kozlyuk
Add hugepages discovery ("large pages" in Windows terminology) and update documentation for required privilege setup. Signed-off-by: Dmitry Kozlyuk --- config/meson.build | 2 + doc/guides/windows_gsg/build_dpdk.rst | 20 - doc/guides/windows_gsg/index.rst | 1

[dpdk-dev] [PATCH v2 05/10] eal: introduce internal wrappers for file operations

2020-04-10 Thread Dmitry Kozlyuk
EAL common code uses file locking and truncation. Introduce OS-independent wrappers in order to support both Linux/FreeBSD and Windows: * eal_file_lock: lock or unlock an open file. * eal_file_truncate: enforce a given size for an open file. Wrappers follow POSIX semantics, but interface is not P

[dpdk-dev] [PATCH v2 03/10] eal/windows: improve CPU and NUMA node detection

2020-04-10 Thread Dmitry Kozlyuk
1. Map CPU cores to their respective NUMA nodes as reported by system. 2. Support systems with more than 64 cores (multiple processor groups). 3. Fix magic constants, styling issues, and compiler warnings. 4. Add EAL private function to map DPDK socket ID to NUMA node number. Fixes: 53ffd9f080fc (

[dpdk-dev] [PATCH v2 06/10] eal: introduce memory management wrappers

2020-04-10 Thread Dmitry Kozlyuk
System meory management is implemented differently for POSIX and Windows. Introduce wrapper functions for operations used across DPDK: * rte_mem_map() Create memory mapping for a regular file or a page file (swap). This supports mapping to a reserved memory region even on Windows. * rte_mem_u

[dpdk-dev] [PATCH v2 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-10 Thread Dmitry Kozlyuk
Clang on Windows follows MS ABI where enum values are limited to 2^31-1. Enum rte_page_size has members valued above this limit, which get wrapped to zero, resulting in compilation error (duplicate values in enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. Define these values o

[dpdk-dev] [PATCH v2 07/10] eal: extract common code for memseg list initialization

2020-04-10 Thread Dmitry Kozlyuk
All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_memory.c | 54 ++ lib/librte_eal/commo

[dpdk-dev] [PATCH v2 09/10] eal/windows: replace sys/queue.h with a complete one from FreeBSD

2020-04-10 Thread Dmitry Kozlyuk
Limited version imported previously lacks at least SLIST macros. Import a complete file from FreeBSD, since its license exception is already approved by Technical Board. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/include/sys/queue.h | 663 +++-- 1 file changed, 601

[dpdk-dev] [PATCH v2 10/10] eal/windows: implement basic memory management

2020-04-10 Thread Dmitry Kozlyuk
Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Signed-off-by: Dmitry Kozlyuk --- config/meson.build| 2 +- doc/guides/windows_gsg/

Re: [dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test

2020-04-10 Thread Honnappa Nagarahalli
> > > > > Subject: [PATCH v3 1/9] test/ring: add contention stress test > > Minor, would 'add stress test for overcommitted use case' sound better? > > I liked to point out that this test-case can be used as contention > stress-test > (many threads do enqueue/dequeue to/from the same ring) for

Re: [dpdk-dev] [PATCH v2 12/16] telemetry: introduce telemetry backward compatibility

2020-04-10 Thread Pattan, Reshma
> -Original Message- > From: Power, Ciara >> +static int >>+telemetry_v2_init(const char *runtime_dir, const char **err_str) >>+ if (strlcpy(v2_socket.path, get_socket_path(runtime_dir, 2), >>+ sizeof(v2_socket.path)) >= sizeof(v2_socket.path)) { >>+

Re: [dpdk-dev] [PATCH] common/mlx5: fix bogus assert

2020-04-10 Thread Stephen Hemminger
On Tue, 31 Mar 2020 15:09:43 + Slava Ovsiienko wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, March 31, 2020 17:55 > > To: Slava Ovsiienko > > Cc: Matan Azrad ; Shahaf Shuler > > ; dev@dpdk.org; Alexander Kozyrev > > > > Subject: Re: [PATCH] common/mlx

Re: [dpdk-dev] [PATCH RFC v2 0/7] introduce new barrier class and use it for mlx5 PMD

2020-04-10 Thread Andrew Rybchenko
On 4/10/20 7:41 PM, Gavin Hu wrote: To order writes to various memory types, 'sfence' is required for x86, and 'dmb oshst' is required for aarch64. But within DPDK, there is no abstracted barriers covers this combination: sfence(x86)/dmb(aarch64). So introduce a new barrier class - rte_dma_*mb

[dpdk-dev] [PATCH] drivers: fix gcc 10 errors due to logtype var in header

2020-04-10 Thread Bruce Richardson
The zlib compression driver, as well as the aesni-gcm, aesni-mb and openssl crypto drivers all defined the logtype variable in the header file directly. This gives errors with gcc 10, due to -fno-common being the default, so we need to apply the same fix in all cases: * move the variable definition

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 8:42 PM Thomas Monjalon wrote: > > 10/04/2020 15:29, Jerin Jacob: > > On Fri, Apr 10, 2020 at 6:45 PM David Marchand > > wrote: > > > On Thu, Apr 9, 2020 at 8:27 PM Jerin Jacob wrote: > > > > # In summary: > > > > ~ > > > > # In the existing code: > > > > The

Re: [dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test

2020-04-10 Thread Honnappa Nagarahalli
> > > > > +static int > > > > +test_worker_prcs(void *arg) > > > > +{ > > > > + int32_t rc; > > > > + uint32_t lc, n, num; > > > minor, lcore instead of lc would be better > > > > > > > + uint64_t cl, tm0, tm1; > > > > + struct lcore_arg *la; > > > > + struct ring_e

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetrylibrary.

2020-04-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > Sent: Friday, April 10, 2020 4:22 PM > > > On Apr 10, 2020, at 5:49 AM, Morten Brørup > wrote: > > > >> From: Ciara Power [mailto:ciara.po...@intel.com] > >> Sent: Wednesday, April 8, 2020 6:50 PM > >> > >> This patchset extens

[dpdk-dev] [PATCH] examples/ipsec-secgw: remove limitation for crypto sessions

2020-04-10 Thread Vladimir Medvedkin
Get rid of hardcoded limit of cryptodev sessions. Fixes: e1143d7dbbf4 ("examples/ipsec-secgw: get rid of maximum SA limitation") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec-secgw.c | 12 +++- examples/ipsec-secgw/ipsec.h | 3 +++ examples/

Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-10 Thread Ranjit Menon
On 4/9/2020 7:50 PM, Dmitry Kozlyuk wrote: + +_Use_decl_annotations_ +VOID +virt2phys_device_EvtIoInCallerContext( + IN WDFDEVICE device, IN WDFREQUEST request) +{ + WDF_REQUEST_PARAMETERS params; + ULONG code; + PVOID *virt; Should this be PVOID virt; (instead of PVOID

Re: [dpdk-dev] [PATCH v3 2/9] ring: prepare ring to allow new sync schemes

2020-04-10 Thread Honnappa Nagarahalli
> > > > Subject: [PATCH v3 2/9] ring: prepare ring to allow new sync schemes > > > > > > Change from *single* to *sync_type* to allow different > > > synchronisation schemes to be applied. > > > Mark *single* as deprecated in comments. > > > Add new functions to allow user to query ring sync typ

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Lukasz Wojciechowski
W dniu 10.04.2020 o 16:41, Thomas Monjalon pisze: > 10/04/2020 15:25, Bruce Richardson: >> On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: >>> 10/04/2020 12:42, Bruce Richardson: On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > --- a/app/test/meson.buil

Re: [dpdk-dev] [PATCH v2 10/10] eal/windows: implement basic memory management

2020-04-10 Thread Narcisa Ana Maria Vasile
On Fri, Apr 10, 2020 at 07:43:42PM +0300, Dmitry Kozlyuk wrote: > Basic memory management supports core libraries and PMDs operating in > IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain > IOVAs of hugepages allocated from user-mode. > > Signed-off-by: Dmitry Kozlyuk > --- > c

Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file

2020-04-10 Thread Stephen Hemminger
On Fri, 10 Apr 2020 22:47:44 +0200 Lukasz Wojciechowski wrote: > W dniu 10.04.2020 o 16:41, Thomas Monjalon pisze: > > 10/04/2020 15:25, Bruce Richardson: > >> On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > >>> 10/04/2020 12:42, Bruce Richardson: > On Fri, Apr 10, 2

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

2020-04-10 Thread Thomas Monjalon
Hi, Adding more people (crypto PMD maintainers) as Cc. 10/04/2020 16:27, David Coyle: > Introduction > > > This patchset adds a new AESNI-MB Multi-Function raw device PMD for > utilizing multi-function capabilities of the Intel IPSec Multi Buffer > library. > > The aim of this rawd

Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode

2020-04-10 Thread Honnappa Nagarahalli
> Subject: RE: [PATCH v3 3/9] ring: introduce RTS ring mode > > > > Introduce relaxed tail sync (RTS) mode for MT ring synchronization. > > > Aim to reduce stall times in case when ring is used on overcommited > > > cpus (multiple active threads on the same cpu). > > > The main difference from o

Re: [dpdk-dev] [PATCH v2 10/10] eal/windows: implement basic memory management

2020-04-10 Thread Dmitry Kozlyuk
[snip] > > +static int > > +alloc_seg(struct rte_memseg *ms, void *requested_addr, int socket_id, > > + struct hugepage_info *hi) > > +{ > > + HANDLE current_process; > > + unsigned int numa_node; > > + size_t alloc_sz; > > + void *addr; > > + rte_iova_t iova = RTE_BAD_IOVA; > > + PSA

<    1   2   3   >