On 4/10/20 4:41 PM, Nithin Dabilpuram wrote: > On Fri, Apr 10, 2020 at 03:50:06PM +0530, Nithin Dabilpuram wrote: >> On Fri, Apr 10, 2020 at 01:07:34AM +0200, Andrzej Ostruszka wrote: [...] >>>> + next_hop = (rc == 0) ? next_hop : drop_nh; >>> >>> Maybe simple if here? I see the same in other patches. >> >> Will fix it in V5. > > I now see it is better to leave this statement > instead of putting an "if(unlikely(rc))" that might force an > explicit branch instruction. On other hand, conditional might > be making use of an "csel" instruction in arm64 or "cmov" in x86. > Are you ok with leaving this line as it is ? or you have a strong opinion > to change it to if ?
It is fine - if you think the generated code will be better then leave it. With regards Andrzej Ostruszka
