10/04/2020 15:25, Bruce Richardson: > On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: > > 10/04/2020 12:42, Bruce Richardson: > > > On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: > > > > --- a/app/test/meson.build > > > > +++ b/app/test/meson.build > > > > has_hugepage = true > > > > if is_linux > > > > > > Since you check for linux in the script, you can drop these two lines, > > > > The issue is for Windows. > > I am not sure how we will skip shell scripts > > when adding Windows support for this application. > > So there are two options now: > > a) remove Linux check before calling the script and ignore Windows > > support for now > > b) keep Linux check without knowing whether it will be useful for > > Windows support > > > > We vote a? > > > c) Write all such scripts in python, to allow them to run everywhere. :-) > > Given that windows is the problem, having the is_linux check in the > meson.build file makes most sense - in which case I don't think we need the > check for linux in the script.
Yes, let's make it simple for now.
