Re: [dpdk-dev] [PATCH] doc: thunderx: explain which PCI is secondary VF

2020-02-03 Thread Jerin Jacob
On Tue, Jan 28, 2020 at 7:01 PM wrote: > > From: Krzysztof Kanas > > Thunderx-nic uses secondary VF's to provide more queues to DPDK. > Current instructions explain the concept but don't show easy way to find > which PCI id is primary and which is secondary VF's. > > Signed-off-by: Krzysztof Kana

Re: [dpdk-dev] [PATCH v3 00/13] Introduce mlx5 vDPA driver

2020-02-03 Thread Maxime Coquelin
Thanks Matan, it looks OK to me. On 2/2/20 5:03 PM, Matan Azrad wrote: > v2: > - Reorder patches for 2 serieses - this is the seccond part of the previous > series splitting. > - Fix spelling and per patch complition issues. > - moved to use claim_zero instead of pure asserts. > > v3: > - Addres

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-02-03 Thread Anoob Joseph
Hi Konstantin, Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Saturday, February 1, 2020 12:20 AM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu > Cc: Jerin Jacob Kollanukkaran ; Lukas Bartosik > ; Narayana Prasad Raju Athreya > ; d

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-03 Thread Gaetan Rivet
On 02/02/2020 12:21, Jerin Jacob wrote: On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger wrote: On Fri, 31 Jan 2020 22:31:57 +0530 wrote: + +#define set_err(err, where, fmt, ...) do { \ + graph_err(fmt, ##__VA_ARGS__);

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-02-03 Thread Akhil Goyal
> > > > > > > Currently only one qp will be used for one core. The number of > > > > > > > qps can be increased to match the number of lcore params. > > > > > > > > > > > > I don't really understand the purpose of that patch > > > > > > As I understand, all it does - unconditionally increases n

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-02-03 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Monday, February 3, 2020 2:46 PM > To: Anoob Joseph ; Ananyev, Konstantin > ; Nicolau, Radu > Cc: Jerin Jacob Kollanukkaran ; Lukas Bartosik > ; Narayana Prasad Raju Athreya > ; dev@dpdk.org > S

Re: [dpdk-dev] [PATCH v3 13/13] vdpa/mlx5: disable ROCE

2020-02-03 Thread Maxime Coquelin
Hi Matan, On 2/2/20 5:03 PM, Matan Azrad wrote: > In order to support virtio queue creation by the FW, ROCE mode > should be disabled in the device. > > Do it by netlink which is like the devlink tool commands: > 1. devlink dev param set pci/[pci] name enable_roce value false > cmo

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Ferruh Yigit
On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > >> 31/01/2020 15:16, Trahe, Fiona: >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote: 30/01/2020 17:09, Ferruh Yigit: > On 1/29/2020 8:13 PM, Akhil Goyal wrote: >> >> I believe these enums will be used only in case of ASYM case which

Re: [dpdk-dev] [PATCH v2] net/octeontx2: enable full flow control for HIGIG

2020-02-03 Thread Jerin Jacob
On Thu, Jan 30, 2020 at 9:54 PM wrote: > > From: Kiran Kumar K > > When HIGIG flow control enabled with CGX, We are disabling Tx flow control. > Added check to enable the full flow control in HIGIG mode. > > Signed-off-by: Kiran Kumar K > --- > V2 changes: > * Updated commit log Updated the com

Re: [dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-02-03 Thread Jerin Jacob
On Mon, Feb 3, 2020 at 2:44 PM Gaetan Rivet wrote: > > On 02/02/2020 12:21, Jerin Jacob wrote: > > On Sun, Feb 2, 2020 at 4:08 PM Stephen Hemminger > > wrote: > >> > >> On Fri, 31 Jan 2020 22:31:57 +0530 > >> wrote: > >> > >>> + > >>> +#define set_err(err, where, fmt, ...) do {

Re: [dpdk-dev] [PATCH] net/octeontx: fix memory leak of MAC address table

2020-02-03 Thread Jerin Jacob
On Wed, Jan 29, 2020 at 5:58 PM Harman Kalra wrote: > > On Wed, Jan 29, 2020 at 02:47:04PM +0530, Sunil Kumar Kori wrote: > > MAC address table is allocated during octeontx device create and > > same is used to maintain list of MAC address associated to port. > > This table is not getting freed ni

Re: [dpdk-dev] [PATCH v4] net/i40e: fix multi-queue Rx interrupt for VF

2020-02-03 Thread Ye Xiaolong
On 01/17, Lunyuan Cui wrote: >The interrupt vector which bind to queues should not larger than should not be larger than >the max avaiable vertor. It will cause port start failed. This patch s/avaiable/available s/vertor/vector >changed the judgement condition of the limited vector id. It can >

Re: [dpdk-dev] [PATCH] app/testpmd: fix uninitialized members of mpls

2020-02-03 Thread Ferruh Yigit
On 2/2/2020 8:23 AM, Ori Kam wrote: > Hi Ferruh, > > PSB, > Thanks, > Ori > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, January 31, 2020 1:08 PM >> To: Ori Kam ; Wenzhuo Lu ; >> Jingjing Wu ; Bernard Iremonger >> >> Cc: dev@dpdk.org; Slava Ovsiienko ; >> sta...@dpdk.org

Re: [dpdk-dev] Windows Support Plan

2020-02-03 Thread Burakov, Anatoly
On 02-Feb-20 8:37 PM, Dmitry Kozliuk wrote: Hi everyone! Hi, Primary topics to discuss: 1. Memory management (@Anatoly) 1.1. MM changed radically since v18.08 and dpdk-next-windows does not implement it properly anyway, it allocates segment lists in a PCI bus driver.

Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix user supplied index in MAC address add

2020-02-03 Thread Jerin Jacob
On Wed, Jan 29, 2020 at 5:56 PM Harman Kalra wrote: > > On Wed, Jan 29, 2020 at 12:12:42PM +0530, Sunil Kumar Kori wrote: > > Earlier after a successful mac_addr_add operation, index was returned > > by underlying layer which was unused but same as provided by DPDK API. > > > > So API is enhanced

Re: [dpdk-dev] [PATCH] maintainers: update stable maintainers

2020-02-03 Thread Kevin Traynor
On 09/09/2019 22:17, Thomas Monjalon wrote: > 05/09/2019 18:23, Thomas Monjalon: >> 05/09/2019 18:21, Luca Boccassi: >>> On Thu, 2019-09-05 at 16:49 +0100, Kevin Traynor wrote: Yuanhan is no longer maintaining DPDK stable. Add myself as a stable maintainer. Signed-off-by: K

Re: [dpdk-dev] [PATCH v3 13/13] vdpa/mlx5: disable ROCE

2020-02-03 Thread Maxime Coquelin
On 2/3/20 10:27 AM, Maxime Coquelin wrote: > Hi Matan, > > On 2/2/20 5:03 PM, Matan Azrad wrote: >> In order to support virtio queue creation by the FW, ROCE mode >> should be disabled in the device. >> >> Do it by netlink which is like the devlink tool commands: >> 1. devlink dev param se

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-02-03 Thread Eelco Chaudron
On 30 Jan 2020, at 21:20, Thomas Monjalon wrote: Yes, sorry, this is what I meant. Given 19.11.0 already has the symbol as experimental, and that applications like OVS had to accept it as experimental, why removing experimental tag in 19.11.1? I think it was mentioned that it was preferr

Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-03 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Sunday, February 2, 2020 17:59 > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] common/mlx5: redefine Netlink include > > The new RDMA-CORE versions may have the same sub-path to include the > linux Netlink header file. > > It

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Neil Horman
On Mon, Feb 03, 2020 at 09:30:06AM +, Ferruh Yigit wrote: > On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > > > >> 31/01/2020 15:16, Trahe, Fiona: > >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > 30/01/2020 17:09, Ferruh Yigit: > > On 1/29/2020 8:13 PM, Akhil Goyal wrote: >

Re: [dpdk-dev] [PATCH] net/mlx5: add Rx/Tx burst mode info callbacks

2020-02-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, January 30, 2020 6:28 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > ferruh.yi...@intel.com; Thomas Monjalon > Subject: [PATCH] net/mlx5: add Rx/Tx burst mode info callbacks > > Get

Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Sunday, February 2, 2020 5:59 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include > > The new RDMA-CORE versions may have the same sub-path to include the >

Re: [dpdk-dev] [PATCH v3 13/13] vdpa/mlx5: disable ROCE

2020-02-03 Thread Matan Azrad
From: Maxime Coquelin > Sent: Monday, February 3, 2020 1:00 PM > To: Matan Azrad ; dev@dpdk.org; Slava Ovsiienko > > Subject: Re: [PATCH v3 13/13] vdpa/mlx5: disable ROCE > > > > On 2/3/20 10:27 AM, Maxime Coquelin wrote: > > Hi Matan, > > > > On 2/2/20 5:03 PM, Matan Azrad wrote: > >> In or

Re: [dpdk-dev] [PATCH v3 13/13] vdpa/mlx5: disable ROCE

2020-02-03 Thread Maxime Coquelin
On 2/3/20 1:44 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> Sent: Monday, February 3, 2020 1:00 PM >> To: Matan Azrad ; dev@dpdk.org; Slava Ovsiienko >> >> Subject: Re: [PATCH v3 13/13] vdpa/mlx5: disable ROCE >> >> >> >> On 2/3/20 10:27 AM, Maxime Coquelin wrote: >>> Hi Matan, >>> >

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-03 Thread Ferruh Yigit
On 2/2/2020 6:53 PM, Neil Horman wrote: > On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: >> Duplicated the existing symbol and versioned one as experimental and >> other as stable. >> >> Created VERSION_SYMBOL_EXPERIMENTAL helper macro. >> >> Updated the 'check-experimental-syms.sh'

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Ferruh Yigit
On 2/3/2020 11:50 AM, Neil Horman wrote: > On Mon, Feb 03, 2020 at 09:30:06AM +, Ferruh Yigit wrote: >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: >>> 31/01/2020 15:16, Trahe, Fiona: > On 1/30/2020 8:18 PM, Thomas Monjalon wrote: >> 30/01/2020 17:09, Ferruh Yigit: >>> On 1

Re: [dpdk-dev] [PATCH v2 00/13] Introduce mlx5 vDPA driver

2020-02-03 Thread Maxime Coquelin
On 1/29/20 11:08 AM, Matan Azrad wrote: > v2: > - Reorder patches for 2 serieses - this is the seccond part of the previous > series splitting. > - Fix spelling and per patch complition issues. > - moved to use claim_zero instead of pure asserts. > > Matan Azrad (13): > drivers: introduce ml

Re: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes

2020-02-03 Thread Akhil Goyal
> > > > > > > > > > > From: Ankur Dwivedi > > > > > > > > Adding pre-processing required for inline IPsec outbound packets. > > > > > > > > Signed-off-by: Ankur Dwivedi > > > > Signed-off-by: Anoob Joseph > > > > Signed-off-by: Archana Muniganti > > > > Signed-off-by: Tejasree Kondoj > > > > S

[dpdk-dev] [Bug 389] Crash in librte_kni driver due to noncontiguous pages

2020-02-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=389 Bug ID: 389 Summary: Crash in librte_kni driver due to noncontiguous pages Product: DPDK Version: 18.11 Hardware: All OS: All Status: UNCONFIRMED Severity: critica

[dpdk-dev] [PATCH 2/6] net/mlx5: change operations of non-cached flows

2020-02-03 Thread Bing Zhao
When stopping a mlx5 device, the flows with non-cached mode will be flushed. So no operation will be done for these flows in the device closing stage. If the device restarts after stopped, no flow with non-cached mode will be reinserted. Operations of flows with cached mode remain the same. And whe

[dpdk-dev] [PATCH 1/6] net/mlx5: introduce non-cached flows tailq list

2020-02-03 Thread Bing Zhao
A new tailq head is introduced in the mlx5 private structure for each device. Then all the flows created by user are moved into this tailq list. This is the first stage to separate the flows with DV mode from the flows with Verbs mode. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH 4/6] net/mlx5: introduce handle structure for DV flows

2020-02-03 Thread Bing Zhao
Introduce a new structure "mlx5_flow_dv_handle" based on device flow structures "mlx5_flow" and "mlx5_flow_dv", and in the meanwhile, the "mlx5_flow" is kept for Verbs flow. Only the matchers and actions objects will be saved in order to free such resource when destroying a flow. The other informat

[dpdk-dev] [PATCH 0/6] net/mlx5: move to non-cached mode for flow rules

2020-02-03 Thread Bing Zhao
This patch set will remove the flow rules cache and move to the non-cached mode for DV mode. For Verbs mode flow rules, the behavior will remain the same. In the device closing stage, all the software resources for flows created will be freed and corresponding hardware resources will be released.

[dpdk-dev] [PATCH 3/6] net/mlx5: flow type check before creating

2020-02-03 Thread Bing Zhao
When creating a flow, the driver mode needs to be checked in order to call the corresponding functions. Now the driver mode checking part is moved out of the flow creating function, then the flow could be added into the correct tailq list. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.

[dpdk-dev] [PATCH 5/6] net/mlx5: remove the DV support macro checking

2020-02-03 Thread Bing Zhao
Some structures are defined in the mlx5_flow header file and only used for flows with DV driver type. When using inbox driver, the DV mode is not supported. But the code is unique and there is no need to use pre-processing macro since all code could be compiled. Signed-off-by: Bing Zhao --- driv

[dpdk-dev] [PATCH 6/6] net/mlx5: do not save device flow matcher value

2020-02-03 Thread Bing Zhao
The matcher value is a series of bits with specified format that defined by the hardware interface. PMD driver needs to translate the packet header into the matcher format and then used to create the flow with the lower layer driver. And this matcher value is only used when creating a flow, and whe

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-02-03 Thread Kevin Traynor
On 13/01/2020 05:59, Ye, Xiaolong wrote: > > >> -Original Message- >> From: Xing, Beilei >> Sent: Monday, January 13, 2020 11:26 AM >> To: Ye, Xiaolong >> Cc: dev@dpdk.org; Ye, Xiaolong >> Subject: RE: [dpdk-dev] [PATCH v4 00/36] update for i40e base code >> >> >> >>> -Original Mess

Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-03 Thread Ferruh Yigit
On 2/2/2020 3:59 PM, Matan Azrad wrote: > The new RDMA-CORE versions may have the same sub-path to include the > linux Netlink header file. > > It uses the pre-proccessor command #include_next what breaks the PMD gcc > compilation of common/mlx5_netlink.h file in debug mode. > > Use specific incl

Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs

2020-02-03 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Tuesday, November 19, 2019 3:15 > To: Thinh Tran > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter > mode for Mellanox PMDs > > On Mon, 18 Nov 2019 12:18:33 -0600 > Thinh Tra

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Ferruh Yigit
On 2/3/2020 2:00 PM, Dodji Seketeli wrote: > Hello, > > Ferruh Yigit a écrit: > > [...] > >> +1 the change/shuffle of the existing values are problematic, but we don't >> have >> it in this case. > > Right. > > [...] > >> The concern is when there are cases we can waive, we can't directly r

[dpdk-dev] Minutes of Technical Board Meeting, 2020-01-15

2020-02-03 Thread Maxime Coquelin
Minutes of Technical Board Meeting, 2020-01-15 Members Attending - - Ferruh - Kevin - Bruce - Konstantin - Thomas - Hemant - Maxime (Chair) - Olivier - Stephen - Jerin - Honnappa NOTE: The technical board meetings every second Wednesday on IRC channel #dpdk-board, at 3pm UTC. Mee

Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-03 Thread Matan Azrad
From: Ferruh Yigit > On 2/2/2020 3:59 PM, Matan Azrad wrote: > > The new RDMA-CORE versions may have the same sub-path to include the > > linux Netlink header file. > > > > It uses the pre-proccessor command #include_next what breaks the PMD > > gcc compilation of common/mlx5_netlink.h file in de

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Trahe, Fiona
> > > > These sorts of changes are the type that we could collectively waive in > > terms of > > ABI checking, as they should be ok, but the errors from libabigail should be > > taken as an indicator that this API could be rewritten (for example by > > removing > > the abi entirely, and adding

[dpdk-dev] [PATCH] devtools: add fixes column to git-log-fixes

2020-02-03 Thread Kevin Traynor
During backporting, if the fixes or stable tag are missing, it usually requires some investigation by stable maintainer as to why. The fixes tag of the originating release, if present, is contained at the end of the line. Otherwise there is an (N/A). When there are a large amount of commits, addi

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-02-03 Thread Ferruh Yigit
On 1/25/2020 6:56 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit >> On 1/23/2020 7:25 PM, Matan Azrad wrote: >>> Hi >>> >>> From: Ferruh Yigit On 1/23/2020 3:29 PM, Matan Azrad wrote: > > Hi > > From: Ferruh Yigit >> On 1/23/2020 2:05 PM, Matan Azrad wrote:

[dpdk-dev] [PATCH v2] devtools: add fixes column to git-log-fixes

2020-02-03 Thread Kevin Traynor
During backporting, if the fixes or stable tag are missing, it usually requires some investigation by stable maintainer as to why. The presence of a fixes tag may be known from whether the originating release of the issue is printed at the end of the line but with variable line lengths and nested

[dpdk-dev] [PATCH] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-02-03 Thread prateekag
From: prateekagarwal88 Signed-off-by: prateekagarwal88 --- .../prog_guide/img/ring-mp-enqueue3.svg | 194 +- doc/guides/prog_guide/rcu_lib.rst | 2 +- 2 files changed, 101 insertions(+), 95 deletions(-) diff --git a/doc/guides/prog_guide/img/ring-mp-enqueue3

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Dodji Seketeli
Hello, Ferruh Yigit a écrit: [...] > +1 the change/shuffle of the existing values are problematic, but we don't > have > it in this case. Right. [...] > The concern is when there are cases we can waive, we can't directly rely on > the > tool and automate it. These indicators good for impro

Re: [dpdk-dev] [EXTERNAL] Windows Support Plan

2020-02-03 Thread Stephen Hemminger
You should talk to the Windows DPDK developers. They have been presenting regularly at dpdk summits. Look up videos for more info. The initial port is focused on running DPDK on bare metal with Intel NIC. Your version looks more aligned with Windows as guest in KVM. Get Outlook for Android

Re: [dpdk-dev] [PATCH v2 00/13] Introduce mlx5 vDPA driver

2020-02-03 Thread Maxime Coquelin
On 2/3/20 2:24 PM, Maxime Coquelin wrote: > > > On 1/29/20 11:08 AM, Matan Azrad wrote: >> v2: >> - Reorder patches for 2 serieses - this is the seccond part of the previous >> series splitting. >> - Fix spelling and per patch complition issues. >> - moved to use claim_zero instead of pure as

Re: [dpdk-dev] [PATCH v3 00/13] Introduce mlx5 vDPA driver

2020-02-03 Thread Maxime Coquelin
On 2/2/20 5:03 PM, Matan Azrad wrote: > v2: > - Reorder patches for 2 serieses - this is the seccond part of the previous > series splitting. > - Fix spelling and per patch complition issues. > - moved to use claim_zero instead of pure asserts. > > v3: > - Address Maxime C comments. > - Adjust

Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-03 Thread Ferruh Yigit
On 2/3/2020 3:02 PM, Matan Azrad wrote: > > > From: Ferruh Yigit >> On 2/2/2020 3:59 PM, Matan Azrad wrote: >>> The new RDMA-CORE versions may have the same sub-path to include the >>> linux Netlink header file. >>> >>> It uses the pre-proccessor command #include_next what breaks the PMD >>> gcc

[dpdk-dev] [PATCH v4] app/testpmd: add portlist option to the testpmd

2020-02-03 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex for

Re: [dpdk-dev] [PATCH] common/mlx5: redefine Netlink include

2020-02-03 Thread Matan Azrad
Hi From: Ferruh Yigit > On 2/3/2020 3:02 PM, Matan Azrad wrote: > > > > > > From: Ferruh Yigit > >> On 2/2/2020 3:59 PM, Matan Azrad wrote: > >>> The new RDMA-CORE versions may have the same sub-path to include > the > >>> linux Netlink header file. > >>> > >>> It uses the pre-proccessor command

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Thomas Monjalon
03/02/2020 10:30, Ferruh Yigit: > On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > > 02/02/2020 14:05, Thomas Monjalon: > >> 31/01/2020 15:16, Trahe, Fiona: > >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > 30/01/2020 17:09, Ferruh Yigit: > > On 1/29/2020 8:13 PM, Akhil Goyal wrote: >

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-02-03 Thread Matan Azrad
Hi From: Ferruh Yigit > On 1/25/2020 6:56 PM, Matan Azrad wrote: > > Hi Ferruh > > > > From: Ferruh Yigit > >> On 1/23/2020 7:25 PM, Matan Azrad wrote: > >>> Hi > >>> > >>> From: Ferruh Yigit > On 1/23/2020 3:29 PM, Matan Azrad wrote: > > > > Hi > > > > From: Ferruh Yigit > >

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Thomas Monjalon
03/02/2020 18:09, Thomas Monjalon: > 03/02/2020 10:30, Ferruh Yigit: > > On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > > > 02/02/2020 14:05, Thomas Monjalon: > > >> 31/01/2020 15:16, Trahe, Fiona: > > >>> On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > > If library give higher value than ex

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Ferruh Yigit
On 2/3/2020 5:09 PM, Thomas Monjalon wrote: > 03/02/2020 10:30, Ferruh Yigit: >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: >>> 02/02/2020 14:05, Thomas Monjalon: 31/01/2020 15:16, Trahe, Fiona: > On 1/30/2020 8:18 PM, Thomas Monjalon wrote: >> 30/01/2020 17:09, Ferruh Yigit:

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix uninitialized members of mpls

2020-02-03 Thread Ferruh Yigit
On 2/3/2020 10:21 AM, Ferruh Yigit wrote: > On 2/2/2020 8:23 AM, Ori Kam wrote: >> Hi Ferruh, >> >> PSB, >> Thanks, >> Ori >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Friday, January 31, 2020 1:08 PM >>> To: Ori Kam ; Wenzhuo Lu ; >>> Jingjing Wu ; Bernard Iremonger >>> >>>

Re: [dpdk-dev] [EXTERNAL] Windows Support Plan

2020-02-03 Thread Menon, Ranjit
Dmitry... There is a DPDK Windows community meeting every second Wednesday at 8:00am (Pacific Time). If this time works for you, we can have Harini add you to this meeting series. thanks, ranjit m. From: Stephen Hemminger Sent: Monday, February 3, 2020 1:16 AM To: Dmitry Kozliuk ; dev@dpdk.org

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Thomas Monjalon
03/02/2020 18:40, Ferruh Yigit: > On 2/3/2020 5:09 PM, Thomas Monjalon wrote: > > 03/02/2020 10:30, Ferruh Yigit: > >> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > >>> 02/02/2020 14:05, Thomas Monjalon: > 31/01/2020 15:16, Trahe, Fiona: > > On 1/30/2020 8:18 PM, Thomas Monjalon wrote:

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Ray Kinsella
On 03/02/2020 17:34, Thomas Monjalon wrote: > 03/02/2020 18:09, Thomas Monjalon: >> 03/02/2020 10:30, Ferruh Yigit: >>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: 02/02/2020 14:05, Thomas Monjalon: > 31/01/2020 15:16, Trahe, Fiona: >> On 1/30/2020 8:18 PM, Thomas Monjalon wrote

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread William Tu
On Sat, Feb 1, 2020 at 3:43 AM Dmitry Kozliuk wrote: > > Hi William, > > > Sanity check compile stderr: > > clang.exe: error: linker command failed with exit code 1104 (use -v to > > see invocation) > > Please add '-v' flag to Meson invocation and post the output as plain text. > The exact command

[dpdk-dev] [PATCH v2 5/5] hash: correct lock free extendable table support

2020-02-03 Thread Honnappa Nagarahalli
Lock-free extendable table is supported. Correct the comments. Fixes: f401363d984a ("hash: support lock-free extendable bucket") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli --- lib/librte_hash/rte_hash.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_hash/rte_hash.h

[dpdk-dev] [PATCH v2 4/5] test/hash: move reader writer lock free tests to perf tests

2020-02-03 Thread Honnappa Nagarahalli
Move reader writer lock free tests to performance tests. Signed-off-by: Honnappa Nagarahalli --- app/test/Makefile | 2 +- app/test/autotest_data.py | 4 ++-- app/test/meson.build | 4

[dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-03 Thread Honnappa Nagarahalli
Add lock-free reader writer concurrency functional tests. These tests will provide the same coverage that non lock-free APIs have. Signed-off-by: Honnappa Nagarahalli --- app/test/test_hash_readwrite.c | 58 +- 1 file changed, 36 insertions(+), 22 deletions(-) di

[dpdk-dev] [PATCH v2 1/5] test/meson: hash test split into shorter subtests

2020-02-03 Thread Honnappa Nagarahalli
From: Amit Gupta hash_readwrite meson test was taking longer time to complete. The test always get TIMEOUT, hence test is split into functional and perf test. perf test is being moved under dpdk perf testsuites in meson build. Signed-off-by: Amit Gupta Acked-by: Yipeng Wang --- app/test/meso

[dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code

2020-02-03 Thread Honnappa Nagarahalli
The test case target 'hash_readwrite_autotest' is covered by 'hash_readwrite_func_autotest' and 'hash_readwrite_perf_autotest'. Hence, it is removed along with its test code. Signed-off-by: Honnappa Nagarahalli --- app/test/autotest_data.py | 10 +++- app/test/test_hash_readwrite.c | 101 -

[dpdk-dev] [PATCH v2 0/5] test/meson: fix hash readwrite timeout failure

2020-02-03 Thread Honnappa Nagarahalli
V2 changes: - Remove duplicated code in the existing patch - Add lock-free option to hash read-write functional test cases - Move existing loack-free test cases to performance tests - A typo fix in the comments for lock-free extendable table feature V1 changes: - hash_readwrite and hash_readwrite

[dpdk-dev] [PATCH] ixgbe: reset need link config flag on start

2020-02-03 Thread Dave Burton
Begin forwarded message: From: Dave Burton Subject: [PATCH] ixgbe: reset need link config flag on start Date: January 16, 2020 at 11:29:47 AM CST To: dev@dpdk.org Cc: sta...@dpdk.org, Dave Burton [Resending; original sent on Jan 16, 2020, never seen on public lists] [NB: I do not have DPDK 1

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-03 Thread Thomas Monjalon
03/02/2020 19:55, Ray Kinsella: > On 03/02/2020 17:34, Thomas Monjalon wrote: > > 03/02/2020 18:09, Thomas Monjalon: > >> 03/02/2020 10:30, Ferruh Yigit: > >>> On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: > 02/02/2020 14:05, Thomas Monjalon: > > 31/01/2020 15:16, Trahe, Fiona: > >>

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread Dmitry Kozlyuk
Hi, > Thanks for your help. "meson -v" only shows meson's version. > Am I doing it wrong? It'm my mistake, pardon me. Ninja has '-v' option, Meson doesn't. > A full log can be found at > [1mC:\dpdk-draft-windows\build\meson-logs\meson-log.txt [0m Please post C:\dpdk-draft-windows\build\meson-lo

Re: [dpdk-dev] [EXTERNAL] Windows Support Plan

2020-02-03 Thread Dmitry Kozlyuk
> If this time works for you, we can have Harini add you to this meeting series. Thanks Ranjit, Harini's sent me an invitation for this Wednesday. -- Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v7] eal: add manual probing option

2020-02-03 Thread Thomas Monjalon
03/02/2020 06:16, Pavan Nikhilesh Bhagavatula: > @David Marchand @tho...@monjalon.net > > Ping? > > Are there any more changes required for this patch? It's been in queue since > last October. Sorry we have not decided whether it is a good idea or not. All changes related to probing are very s

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread William Tu
On Mon, Feb 3, 2020 at 2:08 PM Dmitry Kozlyuk wrote: > > Hi, > > > Thanks for your help. "meson -v" only shows meson's version. > > Am I doing it wrong? > > It'm my mistake, pardon me. Ninja has '-v' option, Meson doesn't. > > > A full log can be found at > > [1mC:\dpdk-draft-windows\build\meson-l

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread Dmitry Kozlyuk
> From the step in > https://mesonbuild.com/Quick-guide.html#installation-from-source > I tried to compile meson by doing: > $ git clone https://github.com/mesonbuild/meson.git > $ cd meson > $ meson builddir > ERROR: Neither directory contains a build file meson.build. > > How do I generate a m

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread William Tu
On Mon, Feb 3, 2020 at 3:03 PM Dmitry Kozlyuk wrote: > > > From the step in > > https://mesonbuild.com/Quick-guide.html#installation-from-source > > I tried to compile meson by doing: > > $ git clone https://github.com/mesonbuild/meson.git > > $ cd meson > > $ meson builddir > > ERROR: Neither d

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread Dmitry Kozliuk
> > Do I mess up some linker's configurations? > I attached the meson log, thanks for your help! Those are not errors, just harmless warnings. You can now build and run an example program (rerun meson with -Dexamples=helloworld per Windows Getting Started Guide).

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread William Tu
On Mon, Feb 3, 2020 at 3:43 PM Dmitry Kozliuk wrote: >> >> Do I mess up some linker's configurations? >> I attached the meson log, thanks for your help! > > > Those are not errors, just harmless warnings. You can now build and run an > example program (rerun meson with -Dexamples=helloworld per W

Re: [dpdk-dev] [PATCH v4 00/36] update for i40e base code

2020-02-03 Thread Ye Xiaolong
Hi, Kevin On 02/03, Kevin Traynor wrote: >On 13/01/2020 05:59, Ye, Xiaolong wrote: [snip] >>> -Original Message- >Hi Xiaolong/Beilei/Qi Z, > >Some of these patches are tagged to go to 'S'table and are 'F'ixes, >while others are also fixes for older releases but not tagged to go to >stabl

[dpdk-dev] [PATCH V1] doc:Split recommended mapping table for X710/XL710/XXV710 and X722, since they have different firmware version.

2020-02-03 Thread Chen, Zhaoyan
--- doc/guides/nics/i40e.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index c7c34b62f..4292375d9 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -66,6 +66,8 @@ avoid the compatibility issue

[dpdk-dev] [PATCH V1] doc:Split recommended mapping table for X710/XL710/XXV710 and X722, since they have different firmware version.

2020-02-03 Thread Chen, Zhaoyan
--- doc/guides/nics/i40e.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index c7c34b62f..4292375d9 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -66,6 +66,8 @@ avoid the compatibility issue

[dpdk-dev] [PATCH V1] doc:Split recommended mapping table for X710/XL710/XXV710 and X722, since they have different firmware version.

2020-02-03 Thread Chen, Zhaoyan
Split recommended mapping table for X710/XL710/XXV710 and X722, since they have different firmware version. Signed-off-by: Chen, Zhaoyan --- doc/guides/nics/i40e.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst inde

Re: [dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw

2020-02-03 Thread Anoob Joseph
Hi Akhil, > > > > This series integrates SA database (SAD) capabilities from ipsec library. > > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > > Also patch series removes hardcoded limitation for maximum number of > > SA's and SP's. > > According to our measurements, after

Re: [dpdk-dev] DPDK Windows Build

2020-02-03 Thread Dmitry Kozlyuk
Hi William, > examples\meson.build:11:0: ERROR: Program or command 'sh' not found or > not executable > > A full log can be found at > C:\dpdk-draft-windows\build11\meson-logs\meson-log.txt > > Do I need to install "sh"? No, you shouldn't have to, if you're building "master" branch of "dpdk" re

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix uninitialized members of mpls

2020-02-03 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Monday, February 3, 2020 7:46 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; Slava Ovsiienko ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix uninitialized members of > mp