Re: [dpdk-dev] [PATCH] doc/guides: clean repeated words

Good work. Thanks. John

[dpdk-dev] Intel X710, DPDK with SFP - FTLX8574D3BCV-IT link down

Hello, Using a X710 based NIC with Intel SFP - FTLX8574D3BCV-IT on a bare-metal setup, I came across the following issue on the i40e PMD: When Intel SFP - FTLX8574D3BCV-IT is used, link does not come up on executing link down and up commands in quick succession. It shows "NO-CARRIER" in ip link s

Re: [dpdk-dev] [PATCH v2] net/mlx5: change default flow engine to DV

> -Original Message- > From: Dekel Peled > Sent: Thursday, October 24, 2019 15:53 > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH v2] net/mlx5: change default flow engine to DV > > The default flow engine is Verbs flow engine, for lega

Re: [dpdk-dev] [PATCH] doc: update release notes for AESNI PMDs

> > >Support is added for all sequence number sizes for control and user > plane. > > >Test application is updated for unit testing. > > > > > > +* **Updated the AESNI-MB PMD.** > > > + > > > + * Added support for intel-ipsec-mb version 0.53. > > > + > > > +* **Updated the AESNI-GCM PMD.

Re: [dpdk-dev] [PATCH v3] app/test-crypto-perf: support PDCP

> > test-crypto-perf app is updated to calculate PDCP > throughput numbers. > > 2 new params are added for PDCP > --pdcp-sn-sz <5/7/12/15/18> > --pdcp-domain > > ./dpdk-test-crypto-perf --master-lcore 0 -l 0,1 --log-level=8 -- > --devtype crypto_dpaa2_sec --optype pdcp --cipher-algo aes-ctr > -

[dpdk-dev] [RFC v20.20] mbuf: introduce pktmbuf pool with pinned external buffers

Today's pktmbuf pool contains only mbufs with no external buffers. This means data buffer for the mbuf should be placed right after the mbuf structure (+ the private data when enabled). On some cases, the application would want to have the buffers allocated from a different device in the platform.

Re: [dpdk-dev] [PATCH] doc: clarify virtio PMD path selection

Hi Yinan, > -Original Message- > From: dev On Behalf Of Yinan > Sent: Monday, November 18, 2019 6:29 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; tiwei@intel.com > Cc: zhihong.w...@intel.com; john.mcnam...@intel.com; > marko.kovace...@intel.com; Yinan Wang > Subject: [dpdk-dev]

[dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

With the API and ABI freeze ahead, it will be good to reserve some bits on the private structure for future use. Otherwise we will potentially need to maintain two different private structure during 2020 period. There is already one use case for those reserved bits[1] The reserved field should b

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

Hi This bit on in dst mac address = "01:00:00:00:00:00" means the packets is L2 multicast packet. When you run Testpmd application the multicast configuration is forwarded to the device by default. So, you have 2 rules: The default which try to match on the above dst mac bit and to do RSS acti

[dpdk-dev] [PATCH v3 3/6] net/axgbe: use common rte bit operation APIs instead

Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/axgbe/axgbe_common.h | 29 + drivers/net/axgbe/axgbe_ethdev.c | 14 +++--- drivers/net/axgb

[dpdk-dev] [PATCH v3 2/6] test/bitops: add bit operation test case

Add test cases for set bit, clear bit, test and set bit, test and clear bit operations. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu Reviewed-by: Phil Yang --- app/test/Makefile | 1 + app/test/autotest_data.py | 6 + app/test/meson.build | 2 + app/test/test_bitops.c

[dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bit operation APIs

There are a lot functions of bit operations scattered and duplicated in PMDs, consolidating them into a common API family is necessary. Furthermore, when the bit operation is applied to the IO devices, use __ATOMIC_ACQ_REL to ensure the ordering for io bit operation. Signed-off-by: Joyce Kong Rev

[dpdk-dev] [PATCH v3 0/6] implement common rte bit operation APIs in PMDs

There are a lot functions of bit operations scattered in PMDs, consolidate them into a common API family and applied in different PMDs to reduce code duplication. v3: 1. Change the API's head file back to rte_bitops.h, then implement both 32-bit and 64-bit operations with and without C11 a

[dpdk-dev] [PATCH v3 4/6] net/bnx2x: use common rte bit operation APIs instead

Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/bnx2x/bnx2x.c| 209 --- drivers/net/bnx2x/bnx2x.h| 4 - drivers/net/bnx2x/ecore_sp.h

[dpdk-dev] [PATCH v3 5/6] net/qede: use common rte bit operation APIs instead

Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/qede/base/bcm_osal.c | 20 drivers/net/qede/base/bcm_osal.h | 10 -- 2 files changed, 4 insertions

[dpdk-dev] [PATCH v3 6/6] net/hinic: use common rte bit operation APIs instead

Remove its own bit operation APIs and use the common one, this can reduce the code duplication largely. Signed-off-by: Joyce Kong Reviewed-by: Gavin Hu --- drivers/net/hinic/Makefile| 1 + drivers/net/hinic/base/hinic_compat.h | 33 +-- drivers/net/hinic/hin

Re: [dpdk-dev] [PATCH] eal: check for interrupt context

On 17-Nov-19 7:36 PM, Harman Kalra wrote: Added an API to check if current execution is in interrupt context. This will be helpful to handle nested interrupt cases. Signed-off-by: Harman Kalra --- This is a great idea. It would be nice to add checks for is_intr() inside rte_malloc routines,

Re: [dpdk-dev] [PATCH] app/testpmd: report invalid command line parameter

On 11/17/2019 5:10 PM, David Marchand wrote: > We currently do not check that a non option string has been passed to > testpmd. > > Example: > $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ > --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf 2048 > [...] > testpmd> show config f

Re: [dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bitoperation APIs

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > Sent: Monday, November 18, 2019 11:07 AM > [snip] > +++ b/lib/librte_eal/common/include/rte_bitops.h > @@ -0,0 +1,474 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2019 Arm Limite

[dpdk-dev] [PATCH] doc: update metadata feature description for mlx5

Legacy Verbs supports MARK and FLAG metadata actions only. Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 9351de6..6598e2f 100644 --- a/doc/guides/nics/mlx5.rst +++

Re: [dpdk-dev] [PATCH v2 0/2] support older pkg-config

On 11/15/2019 3:16 PM, Bruce Richardson wrote: > Not all pkg-config installs support --define-prefix and --path flags, so > ensure we can still build examples without those flags, and that we > don't get errors when using test-meson-builds.sh with/without those > flags. > > Bruce Richardson (2): >

Re: [dpdk-dev] [RFC 0/4] cpu-crypto API choices

Hi Jerin, Thanks for input, my answers inline. Other guys - please provide your input. Thanks Konstantin > > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > > process the crypto workload asynchronously. This way provides uniformity > > to both PMD types, but also introduce

Re: [dpdk-dev] [PATCH v2] net/mlx5: change default flow engine to DV

Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, October 24, 2019 3:53 PM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: change default flow engine to DV > > The default flow eng

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

> > > > > > > > > > > > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > > > > > > Hi All, > > > > > > > > > > > > > > > > > > This patchset would need ack from more vendors as it will > > > > > > > > > impact user > > > > > > > > experience > > > > > > > > > on a key example application which is

Re: [dpdk-dev] [PATCH] mem: clarify documentation for rte_mem_virt2iova

On Thu, Nov 14, 2019 at 02:13:06PM +, Anatoly Burakov wrote: > It may not be immediately clear that rte_mem_virt2iova does not actually > check the internal memseg table, and will instead either return VA (in > IOVA as VA mode), or will fall back to kernel page table walk (in IOVA > as PA mode)

[dpdk-dev] [PATCH] doc: add abi policy changes to release notes

Add some pointers to the releases notes on the changes to the abi policy, the introduction of project-level ABI management and the deprecation of library-level management. Signed-off-by: Ray Kinsella --- doc/guides/rel_notes/release_19_11.rst | 11 +++ 1 file changed, 11 insertions(+) d

[dpdk-dev] [PATCH v2] crypto/openssl: support SG for inplace buffers

As per current support, Scatter Gather is only supported for out of place input and output buffers. This patch add support for Scatter Gather for inplace buffers. Signed-off-by: Akhil Goyal --- changes in v2: - fixed typo - enabled corresponding test case - removed hardcodings app/test/test_cr

Re: [dpdk-dev] [PATCH v15 1/2] kni: support userspace VA

On Sun, Nov 17, 2019 at 8:43 PM David Marchand wrote: > > From: Vamsi Attunuru > > Patch adds support for kernel module to work in IOVA = VA mode by > providing address translation routines to convert userspace VA to > kernel VA. > > KNI performance using PA is not changed by this patch. > But co

Re: [dpdk-dev] [PATCH v15 2/2] eal/linux: remove KNI restriction on IOVA

On Sun, Nov 17, 2019 at 8:43 PM David Marchand wrote: > > From: Vamsi Attunuru > > Now that KNI supports VA (with kernel versions starting 4.6.0), we can > accept IOVA as VA, but KNI must be configured for this. > Pass iova_mode when creating KNI netdevs. > > So far, IOVA detection policy forced

Re: [dpdk-dev] [PATCH] drivers: copyrights update for nxp files

> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 4:36 PM > To: dev@dpdk.org > Cc: Sachin Saxena ; ferruh.yi...@intel.com; Hemant > Agrawal ; techbo...@dpdk.org > Subject: Re: [PATCH] drivers: copyrights update for nxp files > Importance: High > > 06/11/2

[dpdk-dev] What is the 'unit of timestamp' assigned to mbuf packet in DPDK?

Hi, The timestamp assigned to packet at the time of enqueue (value of timestamp field in mbuf), is it in milliseconds or microseconds or in cpu cycles? How this timestamp is calculated? Is it calculated using the *rte_cycles.h*? Thanks in advance! --Gokul

[dpdk-dev] [PATCH v2 0/2] fix testpmd quit error after FDIR rule created

This patch series fixes FDIR error when immediately quit without flushing FDIR rule in testpmd. - Patch 1 adds programming status check mechanism to monitor FDIR status. - Patch 2 moves FDIR queue irq config out of device start/stop. -- v2: * Seperate FDIR/LAN queue irq config Yahui Cao (2): n

[dpdk-dev] [PATCH v2 2/2] net/ice: fix FDIR rule failure after device stop

By moving irq enable/disable from device start/stop to FDIR setup/teardown, FDIR queue irq config is independent of LAN queue irq config. So device stop will not cause FDIR rule failure. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Cc: beilei.x...@intel.com Signed-off-by: Yahui Ca

[dpdk-dev] [PATCH v2 1/2] net/ice: fix FDIR programming status check issue

To make sure if FDIR programming succeed or fail, legacy programming status descriptor WB format is enabled and FDIR queue irq is opened. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Cc: beilei.x...@intel.com Signed-off-by: Yahui Cao Signed-off-by: Beilei Xing --- drivers/net/i

Re: [dpdk-dev] [PATCH v15 0/2] kni: support IOVA mode

On Sun, Nov 17, 2019 at 4:13 PM David Marchand wrote: > Sending this to track the changes I did on the v14 patchset from Vamsi. > > Changelog since v14: > - reworded commitlogs, > - added missing documentation update, > - fixed release notes, Reviewed-by: Jerin Jacob Applied. -- David Marcha

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: remove library search path from binary

12/11/2019 14:15, Ferruh Yigit: > This patch functionally reverts the patch in fixes line to not have any > hardcoded library path in the final binary for the security reasons, in > case this binary distributed to production environment. What about meson? There are these rpaths: $ORIGIN/..

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: remove library search path from binary

On Mon, Nov 18, 2019 at 04:14:54PM +0100, Thomas Monjalon wrote: > 12/11/2019 14:15, Ferruh Yigit: > > This patch functionally reverts the patch in fixes line to not have any > > hardcoded library path in the final binary for the security reasons, in > > case this binary distributed to production e

Re: [dpdk-dev] [dpdk-stable] [PATCH] mk: remove library search path from binary

On Mon, Nov 18, 2019 at 03:30:32PM +, Bruce Richardson wrote: > On Mon, Nov 18, 2019 at 04:14:54PM +0100, Thomas Monjalon wrote: > > 12/11/2019 14:15, Ferruh Yigit: > > > This patch functionally reverts the patch in fixes line to not have any > > > hardcoded library path in the final binary for

[dpdk-dev] [PATCH v2] app/testpmd: report invalid command line parameter

We currently do not check that a non option string has been passed to testpmd. Example: $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf 2048 [...] testpmd> show config fwd io packet forwarding - ports=2 - cores=1 - streams=2 - N

Re: [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo

On Thu, Nov 7, 2019 at 2:34 PM Hemant Agrawal wrote: > > The IV was not set, which was causing HW based SEC on DPAA1 > to fail. > > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") > > Signed-off-by: Hemant Agrawal > --- > Sending only the fixes. dropped the functional change

Re: [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo

Hi Jerin, Last week, I was on vacation. So, could not review it. I will try to finish this by tomorrow. Regards Abhinandan > -Original Message- > From: Jerin Jacob > Sent: Monday, November 18, 2019 9:30 PM > To: Hemant Agrawal > Cc: dpdk-dev ; Gujjar, Abhinandan S > > Subject: Re: [P

Re: [dpdk-dev] [RFC v20.20] mbuf: introduce pktmbuf pool with pinned external buffers

On Mon, 18 Nov 2019 09:50:07 + Shahaf Shuler wrote: > +struct rte_mempool * > +rte_pktmbuf_ext_buffer_pool_create(const char *name, unsigned n, > +unsigned cache_size, uint16_t priv_size, > +int socket_id, void **buffers, > +

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

On Mon, 18 Nov 2019 10:02:55 + Shahaf Shuler wrote: > With the API and ABI freeze ahead, it will be good to reserve > some bits on the private structure for future use. > > Otherwise we will potentially need to maintain two different > private structure during 2020 period. > > There is alre

Re: [dpdk-dev] [PATCH v2] app/testpmd: report invalid command line parameter

On 11/18/2019 3:37 PM, David Marchand wrote: > We currently do not check that a non option string has been passed to > testpmd. > > Example: > $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ > --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf 2048 > [...] > testpmd> show config f

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell write memory barrier

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, November 15, 2019 1:35 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix Tx doorbell write memory barrier > > As the result of testing it was found that some hosts

Re: [dpdk-dev] time taken for allocation of mempool.

Hi Anatoly, After using iova-mode=va, i see my ports are not getting detected ? I thought it's working but I see following problem what could be the problem? i) I see allocation is faster ii) But my ports are not getting detected I take my word back that it entirely working.. Thanks, Regards, Ve

Re: [dpdk-dev] [PATCH] fips_validation: fix auth verify

Acked-by: Marko Kovacevic

Re: [dpdk-dev] time taken for allocation of mempool.

PL note I am using dpdk 18-11... On Wed, 13 Nov, 2019, 10:37 am Venumadhav Josyula, wrote: > Hi , > We are using 'rte_mempool_create' for allocation of flow memory. This has > been there for a while. We just migrated to dpdk-18.11 from dpdk-17.05. Now > here is problem statement > > Problem stat

Re: [dpdk-dev] [PATCH] doc: add matching list for ice

On 11/18/2019 4:03 AM, Qi Zhang wrote: > Add kernel driver, firmware and DDP package matching list > for ice PMD. > > Signed-off-by: Qi Zhang > --- > doc/guides/nics/ice.rst | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ic

Re: [dpdk-dev] [PATCH] af_packet: advertise offload capabilities that code already supports

On 11/13/2019 12:08 PM, Paul Atkins wrote: > The af_packet pmd already supports MULTI_SEG tx packets, and tx > VLAN_INSERT so advertise these capabilities. > > Signed-off-by: Paul Atkins Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs

Simple change to enable scatter for Mellanox CX4/CX5 PMDs to run this example Signed-off-by: Thinh Tran --- examples/ip_reassembly/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index d59e6d02f..f881b89d1 100644 --- a/e

Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs

On Mon, 18 Nov, 2019, 11:49 pm Thinh Tran, wrote: > Simple change to enable scatter for Mellanox CX4/CX5 PMDs > to run this example > > Signed-off-by: Thinh Tran > --- > examples/ip_reassembly/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/ip_reassembly/main.c b/exa

[dpdk-dev] [PATCH] net/bnxt: fix Rx queue pool calculation

When the number of Rx queues requested by the application is less than the number of pools calculated, we end up calling HWRM_VNIC_ALLOC with incorrect parameters. This causes the firmware to return an error. Fix the Rx queue pool calculation. Fixes: 10bb6ddc2984 ("net/bnxt: fix flow creation with

Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue pool calculation

On Mon, Nov 18, 2019 at 12:32 PM Ajit Khaparde wrote: > When the number of Rx queues requested by the application is less than > the number of pools calculated, we end up calling HWRM_VNIC_ALLOC with > incorrect parameters. This causes the firmware to return an error. > Fix the Rx queue pool calc

Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs

Hi Jerin, would it be possible to add a command option such as '--enable-scatter' like testpmd does? Thanks, Thinh Tran On 11/18/2019 12:30 PM, Jerin Jacob wrote: On Mon, 18 Nov, 2019, 11:49 pm Thinh Tran, > wrote: Simple change to enable scatter for

[dpdk-dev] [PATCH] net/ice: fix flow type selection for FDIR

The FDIR parser will select ICE_FLTR_PTYPE_NONF_IPV4_OTHER as flow type for an IPv4 UDP flow with empty l4 matching field which is not correct. Same issues happens on all the combination between IPv4/IPv6 and UDP/TCP/SCTP cases The patch fix all the wrong flow ptype selections. Fixes: f5cafa961fa

Re: [dpdk-dev] [PATCH v2 0/2] fix testpmd quit error after FDIR rule created

> -Original Message- > From: Cao, Yahui > Sent: Tuesday, November 19, 2019 6:24 AM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui > ; Ye, Xiaolong ; Xing, Beilei > > Subject: [PATCH v2 0/2] fix testpmd quit error after FDIR rule created > > This patch

Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs

On Mon, 18 Nov 2019 12:18:33 -0600 Thinh Tran wrote: > Simple change to enable scatter for Mellanox CX4/CX5 PMDs > to run this example > > Signed-off-by: Thinh Tran > --- > examples/ip_reassembly/main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/ip_reassembly/main.c

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] mempool: remove check for bad IOVA when populating

Tested-by: Chen, BoX C > -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Thursday, November 14, 2019 9:58 PM > To: dev@dpdk.org > Cc: Olivier Matz ; Andrew Rybchenko > ; david.march...@redhat.com; sta...@dpdk.org > Subject: [dpdk-sta

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] mempool: use actual IOVA addresses when populating

Tested-by: Chen, BoX C > -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Thursday, November 14, 2019 9:58 PM > To: dev@dpdk.org > Cc: Olivier Matz ; Andrew Rybchenko > ; david.march...@redhat.com; sta...@dpdk.org > Subject: [dpdk-sta

Re: [dpdk-dev] [PATCH] net/ice: fix flow type selection for FDIR

> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, November 19, 2019 9:07 AM > To: Cao, Yahui ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice: fix flow type selection for FDIR > > The FDIR parser will select ICE_FLTR_PTYPE_NONF_IPV4_OTHER as flow type

Re: [dpdk-dev] [PATCH 7/7] doc: update OcteonTx limitations

On Sat, Nov 16, 2019 at 7:56 PM wrote: > > From: Pavan Nikhilesh > > Update OcteonTx limitaion with max mempool size used. Please squash this patch to the first patch and change all occurrence of OcteonTx with OCTEON TX. > > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/eventdevs/octeont

Re: [dpdk-dev] [PATCH v3] net/ice: fix FDIR flow type conflict

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, November 18, 2019 2:35 PM > To: Xing, Beilei ; Cao, Yahui > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v3] net/ice: fix FDIR flow type conflict > > Flow type "IPv4 + UDP" or "IPv4 + TCP" is conflict with "IPv4 + any" > flow

Re: [dpdk-dev] [PATCH] net/ice: fix flow type selection for FDIR

On 11/19, Qi Zhang wrote: >The FDIR parser will select ICE_FLTR_PTYPE_NONF_IPV4_OTHER as flow type >for an IPv4 UDP flow with empty l4 matching field which is not correct. >Same issues happens on all the combination between IPv4/IPv6 and >UDP/TCP/SCTP cases > >The patch fix all the wrong flow ptype

Re: [dpdk-dev] [PATCH v2 0/2] fix testpmd quit error after FDIR rule created

On 11/19, Yahui Cao wrote: >This patch series fixes FDIR error when immediately quit without >flushing FDIR rule in testpmd. > >- Patch 1 adds programming status check mechanism to monitor FDIR status. >- Patch 2 moves FDIR queue irq config out of device start/stop. > >-- >v2: >* Seperate FDIR/LAN

Re: [dpdk-dev] [PATCH v3] net/ice: fix FDIR flow type conflict

On 11/18, Qi Zhang wrote: >Flow type "IPv4 + UDP" or "IPv4 + TCP" is conflict with "IPv4 + any" >flow type. If a rule for IPv4 + any is created, we should reject any rule >for IPv4 + UDP otherwise the first rule may be impacted, same decision >should be made on a reverse order. >For IPv6 and IPv4 G

Re: [dpdk-dev] [PATCH v3] net/ice: add flow mark hint support

On 11/18, Qi Zhang wrote: >Since not all data paths support flow mark, the driver need s/need/needs >a hint from application to select the correct data path if >flow mark is required. The patch introduce a devarg s/introduce/introduces >"flow-mark-support" as a workaround solution, since a stan

Re: [dpdk-dev] [PATCH v3] net/ice: add flow mark hint support

> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, November 19, 2019 1:53 PM > To: Zhang, Qi Z > Cc: Yang, Qiming ; Cao, Yahui > ; Xing, Beilei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/ice: add flow mark hint support > > On 11/18, Qi Zhang wrote: > >Since not al

[dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

Since not all data paths support flow mark, the driver needs a hint from application to select the correct data path if flow mark is required. The patch introduces a devarg "flow-mark-support" as a workaround solution, since a standard way is still ongoing. Signed-off-by: Qi Zhang Acked-by: Qimin

Re: [dpdk-dev] [PATCH v3] net/ice: add flow mark hint support

On 11/19, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Tuesday, November 19, 2019 1:53 PM >> To: Zhang, Qi Z >> Cc: Yang, Qiming ; Cao, Yahui >> ; Xing, Beilei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3] net/ice: add flow mark hint support >> >> On

[dpdk-dev] [PATCH 20.02] net/virtio-user: do not close tap when disabling queue pairs

Do not close the tap fds when disabling queue pairs, instead, we just need to unbind the backend. Otherwise, tap port can be destroyed unexpectedly. Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") Cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Tiwei Bie --- dri

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix link status

On 11/18, Lunyuan Cui wrote: >The link status for 82599eb got from link status register was not >correct. Check the enable/disable flag of tx laser, set the link >status down if tx laser disabled. Then, we can get correct status. >But after port reset, tx laser register will be reset enable. >Link

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

Monday, November 18, 2019 6:12 PM, Stephen Hemminger: > Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private > structure > > On Mon, 18 Nov 2019 10:02:55 + > Shahaf Shuler wrote: > > > With the API and ABI freeze ahead, it will be good to reserve some > > bits on the private str

Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

On 11/19, Qi Zhang wrote: >Since not all data paths support flow mark, the driver needs >a hint from application to select the correct data path if >flow mark is required. The patch introduces a devarg >"flow-mark-support" as a workaround solution, since a standard >way is still ongoing. > >Signed-

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix link status

Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, November 19, 2019 2:28 PM > To: Cui, LunyuanX > Cc: dev@dpdk.org; Lu, Wenzhuo ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix link status > > On 11/18, Lunyuan Cui wrote: > >The link status fo

Re: [dpdk-dev] [PATCH v3] net/e1000: fix link status update

Hi Lunyuan, > -Original Message- > From: Cui, LunyuanX > Sent: Monday, November 18, 2019 10:58 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Cui, LunyuanX > ; sta...@dpdk.org > Subject: [PATCH v3] net/e1000: fix link status update > > Unassigned variable should not be used as judgment, and t

[dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

The "addr" param has been used since the event callbacks are enabled for external memory. So the "__rte_unused" should be dropped. Besides, slightly refine the coding style by consistently assuming tabs are 8 characters. Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") C

Re: [dpdk-dev] [PATCH] fips_validation: fix auth verify

> Acked-by: Marko Kovacevic Applied to dpdk-next-crypto Thanks.