Re: [dpdk-dev] [PATCH] examples/l2fwd-event: fix build on RHEL 7.6

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 3:21 PM Kevin Traynor wrote: > > On 08/11/2019 10:04, David Marchand wrote: > > CC l2fwd_event_generic.o > > .../l2fwd_event_generic.c: In function > > ‘l2fwd_rx_tx_adapter_setup_generic’: > > .../l2fwd_event_generic.c:203:3: error: missing initializer for field > > ‘i

Re: [dpdk-dev] DPDK and Link-time Optimizations

2019-11-08 Thread Thomas Monjalon
29/04/2019 18:39, Mattias Rönnblom: > If LTO builds would work "out of the box", DPDK could gradually migrate > from away from having static inline functions in the header files. > > Those interested squeezing out as much performance as possible would > build with LTO (and static linking), and t

Re: [dpdk-dev] [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig

2019-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, November 7, 2019 3:18 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig > > To support multi-segment packet sendin

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
Hi David, Too many things in these days. I have reviewed it. Thanks a lot. > -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, October 30, 2019 16:00 > To: Xu, Rosen > Cc: dev ; Kevin Traynor ; dpdk > stable ; Ye, Xiaolong > Subject: Re: [dp

Re: [dpdk-dev] [dpdk-stable] [PATCH 5/9] net/ipn3ke: remove useless if statement

2019-11-08 Thread Xu, Rosen
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, October 30, 2019 16:01 > To: Kevin Traynor > Cc: dev ; Xu, Rosen ; dpdk stable > > Subject: Re: [dpdk-stable] [PATCH 5/9] net/ipn3ke: remove useless if > statement > > On Tue, Oct 1, 2019

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
08/11/2019 15:01, Wang, Haiyue: > From: Thomas Monjalon > > 07/11/2019 11:44, Haiyue Wang: > > > --- a/drivers/net/ice/rte_pmd_ice_version.map > > > +++ b/drivers/net/ice/rte_pmd_ice_version.map > > > +EXPERIMENTAL { > > > + global: > > > + > > > + # added in 19.11 > > > + rte_net_ice_dynfield_pro

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
08/11/2019 15:08, Wang, Haiyue: > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon > > Sent: Friday, November 8, 2019 20:34 > > To: Wang, Haiyue > > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > > ; Yigit, Ferruh > > > > Subject: Re: [dpdk-dev] [PATCH v9] net/ic

Re: [dpdk-dev] [dpdk-stable] [PATCH 6/9] net/ipn3ke: remove commented out code

2019-11-08 Thread Xu, Rosen
Hi, Too busy these days, sorry for late reply. > -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, October 30, 2019 16:04 > To: Kevin Traynor > Cc: dev ; Xu, Rosen ; dpdk stable > > Subject: Re: [dpdk-stable] [PATCH 6/9] net/ipn3ke: remove c

[dpdk-dev] [PATCH v3] net/mlx5: control transmit doorbell register mapping

2019-11-08 Thread Viacheslav Ovsiienko
The rdma core library can map doorbell register in two ways, depending on the environment variable "MLX5_SHUT_UP_BF": - as regular cached memory, the variable is either missing or set to zero. This type of mapping may cause the significant doorbell register writing latency and requires e

Re: [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups

2019-11-08 Thread Xu, Rosen
Hi David, Too busy today, sorry for late reply. > -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, November 08, 2019 22:08 > To: Kevin Traynor > Cc: dev ; Xu, Rosen ; Ye, Xiaolong > > Subject: Re: [v2 PATCH 0/8] Coverity fixes and other cleanu

Re: [dpdk-dev] [PATCH] usertools/dpdk-telemetry-client: fix typo in SPDX tag

2019-11-08 Thread Kevin Traynor
On 08/11/2019 14:26, Bruce Richardson wrote: > There is a typo in the SPDX tag, which is down as an "SPDK" tag. > One-character change should be all that is needed. > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Cc: sta...@dpdk.org > > Reported-by: Stephen Hemminger > S

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
Hi Kevin, Too many things in these days, sorry for late reply. > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, November 05, 2019 23:42 > To: David Marchand ; Xu, Rosen > > Cc: dev ; dpdk stable ; Ye, Xiaolong > > Subject: Re: [dpdk-dev] [PATCH 4/

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Kevin Traynor
On 08/11/2019 14:45, Xu, Rosen wrote: > Hi Kevin, > > Too many things in these days, sorry for late reply. > Hi Rosen, no problem, thanks for the Ack. Kevin. >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Tuesday, November 05, 2019 23:42 >> To: David

Re: [dpdk-dev] [v2 PATCH 4/8] net/ipn3ke: remove useless if statement

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, November 07, 2019 3:02 > To: dev@dpdk.org > Cc: david.march...@redhat.com; Kevin Traynor ; > Xu, Rosen ; sta...@dpdk.org > Subject: [v2 PATCH 4/8] net/ipn3ke: remove useless if statement > > Cove

Re: [dpdk-dev] [v2 PATCH 5/8] net/ipn3ke: remove commented out code

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, November 07, 2019 3:02 > To: dev@dpdk.org > Cc: david.march...@redhat.com; Kevin Traynor ; > Xu, Rosen ; sta...@dpdk.org > Subject: [v2 PATCH 5/8] net/ipn3ke: remove commented out code > > These

Re: [dpdk-dev] [v2 PATCH 3/8] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Thursday, November 07, 2019 3:02 > To: dev@dpdk.org > Cc: david.march...@redhat.com; Kevin Traynor ; > Xu, Rosen ; sta...@dpdk.org > Subject: [v2 PATCH 3/8] net/ipn3ke: fix incorrect commit check logic > >

Re: [dpdk-dev] [PATCH 6/9] net/ipn3ke: remove commented out code

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, October 01, 2019 21:04 > To: dev@dpdk.org > Cc: Kevin Traynor ; Xu, Rosen > ; sta...@dpdk.org > Subject: [PATCH 6/9] net/ipn3ke: remove commented out code > > These struct members and variable wer

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, October 01, 2019 21:04 > To: dev@dpdk.org > Cc: Kevin Traynor ; Xu, Rosen > ; sta...@dpdk.org > Subject: [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic > > Coverity is complaining about

Re: [dpdk-dev] [PATCH 5/9] net/ipn3ke: remove useless if statement

2019-11-08 Thread Xu, Rosen
Hi, > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, October 01, 2019 21:04 > To: dev@dpdk.org > Cc: Kevin Traynor ; Xu, Rosen > ; sta...@dpdk.org > Subject: [PATCH 5/9] net/ipn3ke: remove useless if statement > > Coverity complains that this statem

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ananyev, Konstantin
> > > > On 11/7/2019 12:35 PM, Dekel Peled wrote: > > > > > @@ -1266,6 +1286,18 @@ struct rte_eth_dev * > > > > > > > > > RTE_ETHER_MAX_LEN; > > > > > } > > > > > > > > > > + /* > > > > > + * If LRO is enabled, check that the maximum aggregated > > > > packe

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

2019-11-08 Thread Jerin Jacob
On Fri, Nov 8, 2019 at 7:56 PM Ferruh Yigit wrote: > > > >> Hi Vasim, Jerin, > >> > >> Overall looks good and I not getting any functional error but I am > >> observing a > >> huge performance drop with this update, 3.8Mpps to 0.7Mpps [1]. > > > > Hi Ferruh, > > When it comes to actual kernel net

Re: [dpdk-dev] [PATCH 1/2] raw/dpaa2_qdma: add support for route by port in DMA

2019-11-08 Thread Thomas Monjalon
07/11/2019 10:57, Hemant Agrawal: > Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask

2019-11-08 Thread Jerin Jacob
On Fri, Nov 8, 2019 at 7:24 PM Ananyev, Konstantin wrote: > > > > > -Original Message- > > From: dev On Behalf Of Ferruh Yigit > > Sent: Thursday, November 7, 2019 7:41 PM > > To: Jerin Jacob > > Cc: Pavan Nikhilesh ; Andrew Rybchenko > > ; jer...@marvell.com; > > tho...@monjalon.net; L

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 22:40 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by > dynamic mbuf API > > 08/1

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Ye Xiaolong
On 11/08, Thomas Monjalon wrote: >Hi, > >I see this patch is already merged in next-net-intel, >but please I would prefer to have below improvements first. > Got it, I'll drop v9 in next-net-intel and wait for the improved new version. Thanks, Xiaolong

[dpdk-dev] [PATCH v4] net/mlx5: control transmit doorbell register mapping

2019-11-08 Thread Viacheslav Ovsiienko
The rdma core library can map doorbell register in two ways, depending on the environment variable "MLX5_SHUT_UP_BF": - as regular cached memory, the variable is either missing or set to zero. This type of mapping may cause the significant doorbell register writing latency and requires e

Re: [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 3:41 PM Xu, Rosen wrote: > > Hi David, > > Too busy today, sorry for late reply. Ok, no problem, I had not pushed yet. So I put the patch 3 back in my tree with your Review tokens added where applicable, and pushed the full series. > > > Kevin Traynor (8): > > > net/pca

Re: [dpdk-dev] [PATCH v2] doc: disable doxygen's HAVE_DOT tag

2019-11-08 Thread Thomas Monjalon
> > Ubuntu ships with a patched version of doxygen that enables HAVE_DOT > > (disabled by default). Enabling this option causes the warning: > > > We have also started seeing this on some recent build systems as well. > Thanks for the fix. I think this should be merged soon in case it break > doc

Re: [dpdk-dev] [PATCH] net/ice: clear the HW tables when close device

2019-11-08 Thread Ye Xiaolong
Drop this patch from next-net-intel since it is superseded by "nett/ice: free the HW tables when close device" Thanks, Xiaolong On 11/08, Ye Xiaolong wrote: >On 11/07, Qi Zhang wrote: >>Clear the HW tables during dev_close. Otherwise HW tables will not >>be initialized correctly after device res

Re: [dpdk-dev] [PATCH v4] net/mlx5: control transmit doorbell register mapping

2019-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Friday, November 8, 2019 5:08 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > sta...@dpdk.org > Subject: [PATCH v4] net/mlx5: control transmit doorbell register mapping > > The rdma core library can m

[dpdk-dev] [PATCH v2 3/3] net/mlx5: reorganize flow matcher resources

2019-11-08 Thread Bing Zhao
From: Bing Zhao Matchers are created on the specific table. If a single linked list is used to store these, then the finding process might be the bottleneck when there are a lot of different flow matchers on a huge amount of tables. The matchers could be move into the table data resource structur

[dpdk-dev] [PATCH v2 2/3] net/mlx5: reorganize jump table resources

2019-11-08 Thread Bing Zhao
From: Bing Zhao Jump object is associated with table object, so there is no need to use a single linked list to store it. All the jump objects could be put together with related flow tables. Signed-off-by: Bing Zhao Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.h | 1 - drivers/

[dpdk-dev] [PATCH v2 1/3] net/mlx5: reorganize flow tables with hash list

2019-11-08 Thread Bing Zhao
From: Bing Zhao In the current flow tables organization, arrays are used. This is fast for searching, creating related object that will be used in flow creation. But it introduces some limitation to the table index. Then we can reorganize the flow tables information with hash list. When using has

[dpdk-dev] [PATCH v2 0/3] Reorganize resources of flow tables

2019-11-08 Thread Bing Zhao
From: Bing Zhao Number of flow tables is limited by the memory resource, and the index could be to as large as 2^^32 - 1. In the past, the flow tables are organized by arrays, and this organization has some advantages and disadvantages. The lookup for the table resource from a linear array is qui

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] mk: disable OCTEON TX2 on old compilers

2019-11-08 Thread Thomas Monjalon
04/11/2019 14:30, Ali Alnubani: > This disables OCTEON TX2 for gcc 4.8.5 as the compiler is > emitting "internal compiler error" for aarch64. > > Fixes: 9a8864c8b5da ("net/octeontx2: add build and doc infrastructure") > Cc: sta...@dpdk.org > > Signed-off-by: Ali Alnubani > Acked-by: Jerin Jacob

Re: [dpdk-dev] [PATCH] net/ice: net/ice: free the HW tables when close device

2019-11-08 Thread Ye Xiaolong
On 11/08, Qi Zhang wrote: >Free the HW tables during dev_close. >Otherwise there will be two issues: >1. Memory not be freed if the device is detached. >2. Driver can't be initialized correctly after device reset. > >Fixes: a4c8c48fe3f4 ("net/ice: load OS default package") > >Signed-off-by: Qi Zhan

[dpdk-dev] [PATCH v10 0/2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Haiyue Wang
v10: - Rename the exported variables with 'rte_net_ice' and 'RTE_'. Update the commit message, and separate patch for doxygen. v9: - Rename the dynamic filed and flags variables to _offs, _mask, so it matches the design. v8: - Cleanup the doxgen, rename the dynamic filed and flags wi

[dpdk-dev] [PATCH v10 2/2] doc: add the ice PMD doxygen

2019-11-08 Thread Haiyue Wang
Add the doxygen for ice protocol extraction feature APIs. Signed-off-by: Haiyue Wang --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + drivers/net/ice/rte_pmd_ice.h | 55 +++ 3 files changed, 57 insertions(+) diff --git a/doc/api/dox

[dpdk-dev] [PATCH v10 1/2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Haiyue Wang
The original design is to use rte_mbuf::udata64 to save the metadata of protocol extraction which has network protocol data fields and type, a private API is used to decode this metadata. Use the dynamic mbuf field and flags to register the needed fields in mbuf, to avoid overwriting 'rte_mbuf::ud

Re: [dpdk-dev] [PATCH v2 0/3] Reorganize resources of flow tables

2019-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, November 8, 2019 5:23 PM > To: Slava Ovsiienko > Cc: Bing Zhao ; Ori Kam > ; Raslan Darawsheh ; > dev@dpdk.org > Subject: [PATCH v2 0/3] Reorganize resources of flow tables > > From: Bing Zhao > > Number of flow tables is limit

Re: [dpdk-dev] [PATCH v10 0/2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
08/11/2019 16:44, Haiyue Wang: > v10: - Rename the exported variables with 'rte_net_ice' and 'RTE_'. Update >the commit message, and separate patch for doxygen. Thank you I think this version can replace v9 in next-net

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, November 8, 2019 4:53 PM > To: Dekel Peled ; Matan Azrad > ; Yigit, Ferruh ; Mcnamara, > John ; Kovacevic, Marko > ; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov, > An

Re: [dpdk-dev] [PATCH] net/mlx5: optimize tag traversal with hash list

2019-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, November 8, 2019 7:27 AM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: optimize tag traversal with hash list > > Tag action for flow mark/flag could be reused by different f

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ferruh Yigit > Sent: Friday, November 8, 2019 2:52 PM > To: Matan Azrad ; Dekel Peled > ; john.mcnam...@intel.com; > marko.kovace...@intel.com; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > anatoly.bura...@inte

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread Stephen Hemminger
On Wed, 6 Nov 2019 13:09:43 +0100 Thomas Monjalon wrote: > The constants like AF_INET are in sys/socket.h in FreeBSD. > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > in order to be consistent across DPDK files, and allow to grep > for EXEC_ENV among other benefits. > > Si

Re: [dpdk-dev] [PATCH 19.11] vfio: fix DMA mapping of externally allocated heaps

2019-11-08 Thread Rajesh Ravi
Tested-by: Rajesh Ravi Tested the patch modified for DPDK 19.02 along with SPDK 19.07 Regards, Rajesh On Tue, Nov 5, 2019 at 8:45 PM Anatoly Burakov wrote: > Currently, externally created heaps are supposed to be automatically > mapped for VFIO DMA by EAL, however they only do so if, at the

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-11-08 Thread Rajesh Ravi
Thanks David. With Anatoly's patch applied my patch is not needed as the purpose is solved. Regards, Rajesh On Thu, Nov 7, 2019 at 9:21 PM David Marchand wrote: > On Wed, Nov 6, 2019 at 2:55 PM David Marchand > wrote: > > > > On Tue, Nov 5, 2019 at 6:14 PM Burakov, Anatoly > > wrote: > > >

[dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

2019-11-08 Thread Anatoly Burakov
From: Marcin Baran As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that. Signed-off-by: Marcin Baran Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script

2019-11-08 Thread Anatoly Burakov
In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script. Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v3: - Switch to sh rather than bash, and remove bash-i

[dpdk-dev] [PATCH v7 00/10] Implement the new ABI policy and add helper scripts

2019-11-08 Thread Anatoly Burakov
This patchset prepares the codebase for the new ABI policy and adds a few helper scripts. There are two new scripts for managing ABI versions added. The first one is a Python script that will read in a .map file, flatten it and update the ABI version to the ABI version specified on the command-lin

[dpdk-dev] [PATCH v7 04/10] timer: remove deprecated code

2019-11-08 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Acked-by: Erik Gabriel Carrillo --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib

[dpdk-dev] [PATCH v7 07/10] distributor: rename v2.0 ABI to _single suffix

2019-11-08 Thread Anatoly Burakov
From: Marcin Baran The original ABI versioning was slightly misleading in that the DPDK 2.0 ABI was really a single mode for the distributor, and is used as such throughout the distributor code. Fix this by renaming all _v20 API's to _single API's, and remove symbol versioning. Signed-off-by: M

[dpdk-dev] [PATCH v7 05/10] lpm: remove deprecated code

2019-11-08 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_lpm/rte_lpm.c | 1010 ++-

[dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

2019-11-08 Thread Anatoly Burakov
From: Pawel Modrak Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is. Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v7: - Do not re

[dpdk-dev] [PATCH v7 06/10] distributor: remove deprecated code

2019-11-08 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v5: - Fixed shared library linking error due to versioning still enabled v2: - Moved this to before A

[dpdk-dev] [PATCH v7 08/10] drivers/octeontx: add missing public symbol

2019-11-08 Thread Anatoly Burakov
The logtype symbol was missing from the .map file. Add it. Fixes: d8dd31652cf4 ("common/octeontx: move mbox to common folder") Cc: pbhagavat...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v2: - add this patch to avoid comp

[dpdk-dev] [PATCH v7 10/10] buildtools: add ABI versioning check script

2019-11-08 Thread Anatoly Burakov
From: Marcin Baran Add a shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, or EXPERIMENTAL). The following command was used to verify current source tree (assuming build directory is in ./build): find ./build/lib ./build/drivers -nam

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ananyev, Konstantin
> > > > > > > > > > On 11/7/2019 12:35 PM, Dekel Peled wrote: > > > > > > > @@ -1266,6 +1286,18 @@ struct rte_eth_dev * > > > > > > > > > > > > > RTE_ETHER_MAX_LEN; > > > > > > > } > > > > > > > > > > > > > > + /* > > > > > > > + * If LRO is

Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing

2019-11-08 Thread Thomas Monjalon
08/11/2019 17:15, Stephen Hemminger: > On Wed, 6 Nov 2019 13:09:43 +0100 > Thomas Monjalon wrote: > > > The constants like AF_INET are in sys/socket.h in FreeBSD. > > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > > in order to be consistent across DPDK files, and allow to

Re: [dpdk-dev] [PATCH v13 2/5] eal: add the APIs to wait until equal

2019-11-08 Thread Ananyev, Konstantin
Hi David, > From: Gavin Hu > > The rte_wait_until_equal_xx APIs abstract the functionality of > 'polling for a memory location to become equal to a given value'. > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled > by default. When it is enabled, the above APIs will call WFE

[dpdk-dev] [PATCH v5 0/3] support API to set max LRO packet size

2019-11-08 Thread Dekel Peled
This series implements support and use of API for configuration and validation of max size for LRO aggregated packet. v2: Updated ethdev patch per review comments. v3: Updated ethdev and testpmd patches per review comments. v4: Updated ethdev patch for QEDE PMD per review comments. v5: Updated eth

[dpdk-dev] [PATCH v5 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Dekel Peled
This patch implements [1], to support API for configuration and validation of max size for LRO aggregated packet. API change notice [2] is removed, and release notes for 19.11 are updated accordingly. Various PMDs using LRO offload are updated, the new data members are initialized to ensure they d

[dpdk-dev] [PATCH v5 3/3] app/testpmd: use API to set max LRO packet size

2019-11-08 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. It adds command-line and runtime commands to configure this value, and adds option to show the supported value. Documentation is updated accordingly. Signed-off-by: Dekel Peled Acked-by: Bernard Iremonger Acked-by: Matan Az

[dpdk-dev] [PATCH v5 2/3] net/mlx5: use API to set max LRO packet size

2019-11-08 Thread Dekel Peled
This patch implements use of the API for LRO aggregated packet max size. Rx queue create is updated to use the relevant configuration. Documentation is updated accordingly. Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst| 2 ++ d

[dpdk-dev] [PATCH v2 2/2] pdump: use dynamic logtype

2019-11-08 Thread Stephen Hemminger
The logtype USER1 should not be overloaded for library function. Instead use a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 70 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/lib/librte_pdump/rte_pdump

[dpdk-dev] [PATCH v2 0/2] pdump: cleanups

2019-11-08 Thread Stephen Hemminger
These are a couple of small cleanups for 19.10 which came out of work on pcapng support. Full pcapng support and BPF are planned for DPDK 20.02. Stephen Hemminger (2): pdump: use new pktmbuf copy function pdump: use dynamic logtype lib/librte_pdump/rte_pdump.c | 139 ++---

[dpdk-dev] [PATCH v2 1/2] pdump: use new pktmbuf copy function

2019-11-08 Thread Stephen Hemminger
The rte_pktmbuf_copy handles varying size mbuf pools correctly. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 69 +--- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c i

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 4:11 PM, Dekel Peled wrote: > Thanks, PSB. > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, November 8, 2019 2:52 PM >> To: Matan Azrad ; Dekel Peled >> ; john.mcnam...@intel.com; >> marko.kovace...@intel.com; nhor...@tuxdriver.com; >> ajit.khapa...@broadcom.com

[dpdk-dev] [PATCH] eventdev: reserve space in main structs for extension

2019-11-08 Thread jerinj
From: Jerin Jacob The struct rte_eventdev and rte_eventdev_data are supposed to be used internally only, but there is a chance that increasing their size would break ABI for some applications. In order to allow smooth addition of features without breaking ABI compatibility, some space is reserved

Re: [dpdk-dev] [PATCH v13 2/5] eal: add the APIs to wait until equal

2019-11-08 Thread Thomas Monjalon
08/11/2019 17:38, Ananyev, Konstantin: > > From: Gavin Hu > > +static __rte_always_inline void > > +rte_wait_until_equal_64(volatile uint64_t *addr, uint64_t expected, > > + int memorder) > > +{ > > + uint64_t value; > > + > > + assert(memorder == __ATOMIC_ACQUIRE || memorder == __AT

[dpdk-dev] [PATCH] examples/ipsec-segw: add SPDX license tag

2019-11-08 Thread Stephen Hemminger
Add missing BSD license tag to ipsec examples. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/test/bypass_defs.sh | 1 + examples/ipsec-secgw/test/common_defs.sh | 1 + examples/ipsec-secgw/test/common_defs_secgw.sh | 1 + ex

[dpdk-dev] [PATCH] examples/l2fwd-event: add missing SPDX license header

2019-11-08 Thread Stephen Hemminger
Add same tag as other files in this example. Signed-off-by: Stephen Hemminger --- examples/l2fwd-event/l2fwd_common.c | 4 examples/l2fwd-event/l2fwd_poll.c | 4 2 files changed, 8 insertions(+) diff --git a/examples/l2fwd-event/l2fwd_common.c b/examples/l2fwd-event/l2fwd_common.c

[dpdk-dev] [PATCH] examples/performance-thread: add missing SPDX license tag

2019-11-08 Thread Stephen Hemminger
All source and scripts should be marked as BSD-3. Signed-off-by: Stephen Hemminger --- examples/performance-thread/l3fwd-thread/test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examples/performance-thread/l3fwd-thread/test.sh index b

Re: [dpdk-dev] [PATCH v9 2/4] doc: changes to abi policy introducing major abi versions

2019-11-08 Thread Thomas Monjalon
08/11/2019 13:46, Ray Kinsella: > This policy change introduces major ABI versions, these are > declared every year, typically aligned with the LTS release > and are supported by subsequent releases in the following year. > This change is intended to improve ABI stabilty for those projects > consum

Re: [dpdk-dev] [PATCH v9 2/4] doc: changes to abi policy introducing major abi versions

2019-11-08 Thread Ray Kinsella
On 08/11/2019 17:11, Thomas Monjalon wrote: > 08/11/2019 13:46, Ray Kinsella: >> This policy change introduces major ABI versions, these are >> declared every year, typically aligned with the LTS release >> and are supported by subsequent releases in the following year. >> This change is intende

Re: [dpdk-dev] [PATCH v9 4/4] doc: add maintainer for abi policy

2019-11-08 Thread Thomas Monjalon
08/11/2019 13:46, Ray Kinsella: > Add an entry to the maintainer file for the abi policy. > > Signed-off-by: Ray Kinsella > Acked-by: John Mcnamara > --- > --- a/MAINTAINERS > +++ b/MAINTAINERS > +ABI Policy > +M: Ray Kinsella > +F: doc/guides/contributing/abi_*.rst If you are doing a new vers

[dpdk-dev] [PATCH] net/sfc/base: add missing SPDX license header

2019-11-08 Thread Stephen Hemminger
The meson.build file is missing the required license header. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/base/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/base/meson.build b/drivers/net/sfc/base/meson.build index 6c80305820ce..5fbe24014ec6 100644 ---

Re: [dpdk-dev] [PATCH] net/sfc/base: add missing SPDX license header

2019-11-08 Thread Ferruh Yigit
On 11/8/2019 5:19 PM, Stephen Hemminger wrote: > The meson.build file is missing the required license header. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/sfc/base/meson.build | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/sfc/base/meson.build > b/drivers/ne

[dpdk-dev] [PATCH] devtools: add SPDX license tag check script

2019-11-08 Thread Stephen Hemminger
Simple script to look for missing SPDX license tags with exceptions for certain directories and file types. Signed-off-by: Stephen Hemminger --- devtools/spdx-check.sh | 22 ++ 1 file changed, 22 insertions(+) create mode 100755 devtools/spdx-check.sh diff --git a/devtools/

Re: [dpdk-dev] [PATCH] net/sfc/base: add missing SPDX license header

2019-11-08 Thread Stephen Hemminger
On Fri, 8 Nov 2019 17:25:16 + Ferruh Yigit wrote: > On 11/8/2019 5:19 PM, Stephen Hemminger wrote: > > The meson.build file is missing the required license header. > > > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/sfc/base/meson.build | 2 ++ > > 1 file changed, 2 insertions

Re: [dpdk-dev] [PATCH v3 1/1] net/octeontx2: add Rx/Tx burst mode get callbacks

2019-11-08 Thread Jerin Jacob
On Wed, Nov 6, 2019 at 4:57 PM Sunil Kumar Kori wrote: > > Retrieve burst mode information according to the selected Rx/Tx mode and > offloads. > > Signed-off-by: Sunil Kumar Kori > --- > v3: > - Rebased the patch over patches.dpdk.org/patch/62368/ > v2: > - Rebased the patch on latest commit.

Re: [dpdk-dev] [PATCH v9 2/4] doc: changes to abi policy introducing major abi versions

2019-11-08 Thread Thomas Monjalon
08/11/2019 18:12, Ray Kinsella: > On 08/11/2019 17:11, Thomas Monjalon wrote: > > 08/11/2019 13:46, Ray Kinsella: > >> +#. The ABI version is managed at a project level in DPDK, with the ABI > >> version > >> + reflected in all library's soname. > > > > It is not specifying the experimental lib

Re: [dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype

2019-11-08 Thread Stephen Hemminger
On Fri, 8 Nov 2019 09:13:56 +0100 David Marchand wrote: > On Fri, Nov 8, 2019 at 5:39 AM Stephen Hemminger > wrote: > > > > The logtype USER1 should not be overloaded for library function. > > Instead use a dynamic log type. > > > > Signed-off-by: Stephen Hemminger > > This patch is incomple

[dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef

2019-11-08 Thread Stephen Hemminger
The #ifdef to conditionally include on BSD is unnecessary. It is harmless to include the header on other OS's. An extra include is better than an #ifdef. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 2 -- app/test/test_cmdline_ipaddr.c| 2 -- lib/

Re: [dpdk-dev] [PATCH 2/2] failsafe: implement xstats

2019-11-08 Thread Ferruh Yigit
On 11/1/2019 8:12 PM, Stephen Hemminger wrote: > Add support for extended statistics in failsafe driver. > Reports detailed statistics for each sub device. > > Example: > > testpmd> show port xstats 1 > rx_good_packets: 0 > tx_good_packets: 0 > rx_good_bytes: 0 > tx_good_bytes: 0 > rx_missed_erro

Re: [dpdk-dev] [PATCH 0/2] xstats related patches

2019-11-08 Thread Ferruh Yigit
On 11/1/2019 8:12 PM, Stephen Hemminger wrote: > This is an updated simplified version of previous failsafe xstats > patch and a bug fix for testpmd. > > The failsafe xstats patch is almostly a complete redo. > > Stephen Hemminger (2): > app/testpmd: block xstats for hidden ports > failsafe:

Re: [dpdk-dev] [PATCH] examples/ipsec-segw: add SPDX license tag

2019-11-08 Thread Ananyev, Konstantin
> Signed-off-by: Stephen Hemminger > --- > examples/ipsec-secgw/test/bypass_defs.sh | 1 + > examples/ipsec-secgw/test/common_defs.sh | 1 + > examples/ipsec-secgw/test/common_defs_secgw.sh | 1 + > examples/ipsec-secgw/test/data_rxtx.

Re: [dpdk-dev] [PATCH v13 2/5] eal: add the APIs to wait until equal

2019-11-08 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 5:00 PM > To: Ananyev, Konstantin > Cc: David Marchand ; dev@dpdk.org; n...@arm.com; > Gavin Hu ; Mcnamara, John > ; Kovacevic, Marko ; > Jerin Jacob ; Jan Viktorin > > Subject: Re: [PATCH v13 2/5] eal: ad

Re: [dpdk-dev] [PATCH v4 1/1] test/compress: unit tests refactoring

2019-11-08 Thread Thomas Monjalon
07/11/2019 18:26, Artur Trybula: > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -246,6 +246,11 @@ New Features > +* **Refactored compression unit tests.** > + > + Refactored core function to get clear code structure, better for > maintenance. >

Re: [dpdk-dev] [v3] net/i40e: fix vlan packets drop

2019-11-08 Thread Kevin Traynor
Hi Xiao, On 29/10/2019 05:12, Xiao Zhang wrote: > VLAN packets with ip length bigger than 1496 will not be received by > i40e/i40evf due to wrong packets size checking. This patch fixes the > issue by correcting the maximum frame size during checking. > > Fixes: 43e5488c0ac6 ("net/i40e: support M

[dpdk-dev] [PATCH] ci: remove LTO job

2019-11-08 Thread David Marchand
The LTO job using gcc-7 has two issues at the moment: - warnings about implicit fallthroughs trigger build errors: In file included from ...common/include/rte_memory.h:22:0, from ...linux/eal/eal_hugepage_info.c:24: ...common/include/rte_common.h: In function ‘rte_str_to_size’: ..

Re: [dpdk-dev] [v3] net/i40e: fix vlan packets drop

2019-11-08 Thread Thomas Monjalon
08/11/2019 20:28, Kevin Traynor: > Hi Xiao, > > On 29/10/2019 05:12, Xiao Zhang wrote: > > VLAN packets with ip length bigger than 1496 will not be received by > > i40e/i40evf due to wrong packets size checking. This patch fixes the > > issue by correcting the maximum frame size during checking. >

Re: [dpdk-dev] [PATCH] ci: remove LTO job

2019-11-08 Thread Thomas Monjalon
08/11/2019 20:32, David Marchand: > The LTO job using gcc-7 has two issues at the moment: > - warnings about implicit fallthroughs trigger build errors: > > In file included from ...common/include/rte_memory.h:22:0, > from ...linux/eal/eal_hugepage_info.c:24: > ...common/include/r

[dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

2019-11-08 Thread Anatoly Burakov
From: Pawel Modrak Merge all vesions in linker version script files to DPDK_20.0. This commit was generated by running the following command: :~/DPDK$ buildtools/update-abi.sh 20.0 Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- .../rte_pmd_bbdev_f

Re: [dpdk-dev] [PATCH] ci: remove LTO job

2019-11-08 Thread David Marchand
On Fri, Nov 8, 2019 at 8:56 PM Thomas Monjalon wrote: > > 08/11/2019 20:32, David Marchand: > > The LTO job using gcc-7 has two issues at the moment: > > - warnings about implicit fallthroughs trigger build errors: > > > > In file included from ...common/include/rte_memory.h:22:0, > >

[dpdk-dev] [PATCH v6] ethdev: add max LRO packet size

2019-11-08 Thread Thomas Monjalon
From: Dekel Peled The maximum supported aggregated packet size for LRO is advertised in rte_eth_dev_info. For some devices, max_lro_pktlen may be different of the basic max_rx_pktlen property. Various PMDs supporting LRO are updated. Signed-off-by: Dekel Peled Signed-off-by: Thomas Monjalon -

[dpdk-dev] vtap0 device creation (bug)?

2019-11-08 Thread Stephen Hemminger
When I create a virtio-user device with rte_hotplug it creates a kernel device (ie vtap0). This is normal an the device has ifindex N. But later when device is configured an started the original vtap0 device is deleted and a new one is created (with ifindex N+1). This seems like a bug, if nothi

Re: [dpdk-dev] [PATCH v10 0/2] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Ye Xiaolong
On 11/08, Thomas Monjalon wrote: >08/11/2019 16:44, Haiyue Wang: >> v10: - Rename the exported variables with 'rte_net_ice' and 'RTE_'. Update >>the commit message, and separate patch for doxygen. > >Thank you >I think this version can replace v9 in next-net > > Dropped v9 and applied this

Re: [dpdk-dev] [v3] net/i40e: fix vlan packets drop

2019-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, November 9, 2019 3:49 AM > To: Kevin Traynor > Cc: Zhang, Xiao ; dev@dpdk.org; Xing, Beilei > ; Zhang, Qi Z ; Stokes, Ian > ; sta...@dpdk.org; Andrew Rybchenko > ; Yigit, Ferruh ; Ye, > Xiaolong > Subject: Re: [v3] net/i40

<    1   2