Hi,
> -----Original Message-----
> From: Kevin Traynor [mailto:ktray...@redhat.com]
> Sent: Thursday, November 07, 2019 3:02
> To: dev@dpdk.org
> Cc: david.march...@redhat.com; Kevin Traynor <ktray...@redhat.com>;
> Xu, Rosen <rosen...@intel.com>; sta...@dpdk.org
> Subject: [v2 PATCH 5/8] net/ipn3ke: remove commented out code
>
> These struct members and variable were commented out. Remove them.
>
> Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> Fixes: c820468ac99c ("net/ipn3ke: support TM")
> Cc: rosen...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktray...@redhat.com>
> Reviewed-by: David Marchand <david.march...@redhat.com>
> ---
> drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 -------
> drivers/net/ipn3ke/ipn3ke_tm.c | 1 -
> 2 files changed, 8 deletions(-)
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> index 985f20352..9b0cf309c 100644
> --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> @@ -97,18 +97,11 @@ struct ipn3ke_tm_node { struct ipn3ke_tm_hierarchy
> {
> struct ipn3ke_tm_node *port_node;
> - /*struct ipn3ke_tm_node_list vt_node_list;*/
> - /*struct ipn3ke_tm_node_list cos_node_list;*/
> -
> uint32_t n_shaper_profiles;
> - /*uint32_t n_shared_shapers;*/
> uint32_t n_tdrop_profiles;
> uint32_t n_vt_nodes;
> uint32_t n_cos_nodes;
> -
> struct ipn3ke_tm_node *port_commit_node;
> struct ipn3ke_tm_node_list vt_commit_node_list;
> struct ipn3ke_tm_node_list cos_commit_node_list;
> -
> - /*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/
> };
No problem.
> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c
> b/drivers/net/ipn3ke/ipn3ke_tm.c index a93145d59..5a16c5f96 100644
> --- a/drivers/net/ipn3ke/ipn3ke_tm.c
> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c
> @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t
> tm_id,
> struct rte_tm_error *error)
> {
> - /*struct ipn3ke_tm_internals *tm =
> IPN3KE_DEV_PRIVATE_TO_TM(dev);*/
> uint32_t node_index;
> uint32_t parent_index;
> --
> 2.21.0
Reviewed-by: Rosen Xu <rosen...@intel.com>
