[dpdk-dev] [PATCH 9/9 v4] bus/fslmc: sanitize device name parsing for clarity

2019-11-05 Thread Nipun Gupta
remove unnecessary dup and free Signed-off-by: Shreyansh Jain Reviewed-by: Nipun Gupta --- drivers/bus/fslmc/fslmc_bus.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index 9caf5b6b9..b3e964

[dpdk-dev] [PATCH 6/9 v4] raw/dpaa2_cmdif: add retry and timeout in packet enqueue API

2019-11-05 Thread Nipun Gupta
This patch adds retry in the DPAA2 CMDIF packet enqueue API Fixes: 53c71586c789 ("raw/dpaa2_cmdif: support enqueue/dequeue operations") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 9 +++-- 1 file changed, 7 insertions(

[dpdk-dev] [PATCH 7/9 v4] mempool/dpaa2: report error on endless loop in mbuf release

2019-11-05 Thread Nipun Gupta
From: Radu Bulie When BMAN is not able to accept more buffers, it could be that there are no FBPR's (internal mem provided to bman) left. Report error in such condition. Fixes: 5dc43d22b5ad ("mempool/dpaa2: add hardware offloaded mempool") Cc: sta...@dpdk.org Signed-off-by: Radu Bulie Signed-o

Re: [dpdk-dev] [PATCH 1/3] ethdev: support API to set max LRO packet size

2019-11-05 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 5, 2019 4:27 PM > To: Dekel Peled ; john.mcnam...@intel.com; > marko.kovace...@intel.com; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > anatoly.bura...@intel.com; xuan

Re: [dpdk-dev] [PATCH v7 2/4] doc: changes to abi policy introducing major abi versions

2019-11-05 Thread Ray Kinsella
On 31/10/2019 15:06, Mcnamara, John wrote: > > >> -Original Message- >> From: Ray Kinsella >> Sent: Friday, October 25, 2019 5:29 PM >> To: dev@dpdk.org >> Cc: m...@ashroe.eu; tho...@monjalon.net; step...@networkplumber.org; >> Richardson, Bruce ; Yigit, Ferruh >> ; Ananyev, Konstanti

Re: [dpdk-dev] [PATCH v7 1/4] doc: separate versioning.rst into version and policy

2019-11-05 Thread Ray Kinsella
On 31/10/2019 15:02, Mcnamara, John wrote: > > >> -Original Message- >> From: Ray Kinsella >> Sent: Friday, October 25, 2019 5:29 PM >> To: dev@dpdk.org >> Cc: m...@ashroe.eu; tho...@monjalon.net; step...@networkplumber.org; >> Richardson, Bruce ; Yigit, Ferruh >> ; Ananyev, Konstanti

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Ferruh Yigit
On 11/3/2019 7:50 AM, Slava Ovsiienko wrote: > > >> -Original Message- >> From: Damjan Marion (damarion) >> Sent: Saturday, November 2, 2019 21:21 >> To: Slava Ovsiienko >> Cc: Liu, Yu Y ; Wang, Haiyue ; >> Thomas Monjalon ; dev@dpdk.org; >> arybche...@solarflare.com; Yigit, Ferruh ; >>

[dpdk-dev] [PATCH 19.11] vfio: fix DMA mapping of externally allocated heaps

2019-11-05 Thread Anatoly Burakov
Currently, externally created heaps are supposed to be automatically mapped for VFIO DMA by EAL, however they only do so if, at the time of heap creation, VFIO is initialized and has at least one device available. If no devices are available at the time of heap creation (or if devices were availabl

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-11-05 Thread Burakov, Anatoly
On 05-Nov-19 2:10 PM, Rajesh Ravi wrote: Thanks a lot Anatoly. Will the same solution work with  DPDK 19.02 as well? We 're actually using DPDK 19.02 for memory allocations for SPDK 19.07. DPDK 19.11 may not be supported by SPDK 19.07 we 're currently using. I 'll definitely test if the patch

[dpdk-dev] [PATCH v8 1/4] doc: separate versioning.rst into version and policy

2019-11-05 Thread Ray Kinsella
Separate versioning.rst into abi versioning and abi policy guidance, in preparation for adding more detail to the abi policy. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 167 doc/guides/contributing/abi_versioning.rst | 427 + doc/gui

[dpdk-dev] [PATCH v8 0/4] doc: changes to abi policy introducing major abi versions

2019-11-05 Thread Ray Kinsella
TL;DR abbreviation: A major ABI version that all DPDK releases during an agreed period support. ABI versioning is managed at a project-level, in place of library-level management. ABI changes to add new features are permitted, as long as ABI compatibility with the major ABI version is maintained.

[dpdk-dev] [PATCH v8 4/4] doc: add maintainer for abi policy

2019-11-05 Thread Ray Kinsella
Add an entry to the maintainer file for the abi policy. Signed-off-by: Ray Kinsella --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 717c318..d5bb806 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -84,6 +84,10 @@ M: Marko Kovacevic F: READM

[dpdk-dev] [PATCH v8 3/4] doc: updates to versioning guide for abi versions

2019-11-05 Thread Ray Kinsella
Updates to the ABI versioning guide, to account for the changes to the DPDK ABI/API policy. Fixes for references to abi versioning and policy guides. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 15 +- doc/guides/contributing/abi_versioning.rst | 250

[dpdk-dev] [PATCH v8 2/4] doc: changes to abi policy introducing major abi versions

2019-11-05 Thread Ray Kinsella
This policy change introduces major ABI versions, these are declared every year, typically aligned with the LTS release and are supported by subsequent releases in the following year. This change is intended to improve ABI stabilty for those projects consuming DPDK. Signed-off-by: Ray Kinsella --

[dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Bing Zhao
Introduce simple hash list to the mlx5 utilities. User can define its own data structure containing the mlx5_hlist_entry and create the hash list table via the creation interface. Then the entry will be inserted into the table and linked to the corresponding list head. User should guarantee there i

Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Tuesday, November 5, 2019 17:28 > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > ; dev@dpdk.org > Subject: [PATCH] net/mlx5: introduce mlx5 hash list > > Introduce simple hash list to the mlx5 utilities. User can define its own data > s

[dpdk-dev] [PATCH] ethdev: fix compilation related to hairpin

2019-11-05 Thread Ori Kam
This patch solves a compilation issue that is caused due to using internal function (is_rx_hairpin_queue) inside inline function. The solution is to remove the usage of the functions from the burst functions. Fixes: 60b476d5da3c ("ethdev: add support for hairpin queue") Cc: or...@mellanox.com Si

[dpdk-dev] [PATCH v4 5/7] mempool: introduce helpers for populate and calc mem size

2019-11-05 Thread Olivier Matz
Introduce new functions that can used by mempool drivers to calculate required memory size and to populate mempool. For now, these helpers just replace the *_default() functions without change. They will be enhanced in next commit. Signed-off-by: Olivier Matz Acked-by: Nipun Gupta Reviewed-by:

[dpdk-dev] [PATCH v4 2/7] mempool: reduce wasted space on mempool populate

2019-11-05 Thread Olivier Matz
The size returned by rte_mempool_op_calc_mem_size_default() is aligned to the specified page size. Therefore, with big pages, the returned size can be much more that what we really need to populate the mempool. For instance, populating a mempool that requires 1.1GB of memory with 1GB hugepages can

[dpdk-dev] [PATCH v4 7/7] mempool: use the specific macro for object alignment

2019-11-05 Thread Olivier Matz
For consistency, RTE_MEMPOOL_ALIGN should be used in place of RTE_CACHE_LINE_SIZE. They have the same value, because the only arch that was defining a specific value for it has been removed from dpdk. Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko Acked-by: Nipun Gupta --- lib/librt

[dpdk-dev] [PATCH v4 0/7] mempool: avoid objects allocations across pages

2019-11-05 Thread Olivier Matz
KNI supposes that mbufs are contiguous in kernel virtual memory. This may not be true when using the IOVA=VA mode. To fix this, a possibility is to ensure that objects do not cross page boundaries in mempool. This patchset implements this in the last patch (5/5). The previous patches prepare the j

[dpdk-dev] [PATCH v4 4/7] mempool: introduce function to get mempool page size

2019-11-05 Thread Olivier Matz
In rte_mempool_populate_default(), we determine the page size, which is needed for calc_size and allocation of memory. Move this in a function and export it, it will be used in a next commit. Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko Acked-by: Nipun Gupta --- lib/librte_mempoo

[dpdk-dev] [PATCH v4 1/7] mempool: allow unaligned addr/len in populate virt

2019-11-05 Thread Olivier Matz
rte_mempool_populate_virt() currently requires that both addr and length are page-aligned. Remove this uneeded constraint which can be annoying with big hugepages (ex: 1GB). Signed-off-by: Olivier Matz Reviewed-by: Andrew Rybchenko Acked-by: Nipun Gupta --- lib/librte_mempool/rte_mempool.c |

[dpdk-dev] [PATCH v4 3/7] mempool: remove optimistic IOVA-contiguous allocation

2019-11-05 Thread Olivier Matz
The previous commit reduced the amount of required memory when populating the mempool with non iova-contiguous memory. Since there is no big advantage to have a fully iova-contiguous mempool if it is not explicitly asked, remove this code, it simplifies the populate function. Signed-off-by: Olivi

[dpdk-dev] [PATCH v4 6/7] mempool: prevent objects from being across pages

2019-11-05 Thread Olivier Matz
When populating a mempool, ensure that objects are not located across several pages, except if user did not request iova contiguous objects. Signed-off-by: Vamsi Krishna Attunuru Signed-off-by: Olivier Matz Acked-by: Nipun Gupta Acked-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempoo

[dpdk-dev] [PATCH v2] app/testpmd: add hairpin support

2019-11-05 Thread Ori Kam
This commit introduce the hairpin queues to the testpmd. the hairpin queue is configured using --hairpinq= the hairpin queue adds n queue objects for both the total number of TX queues and RX queues. The connection between the queues are 1 to 1, first Rx hairpin queue will be connected to the first

Re: [dpdk-dev] [PATCH 3/9] net/bnxt: remove logically dead code

2019-11-05 Thread Kevin Traynor
On 30/10/2019 16:27, Ajit Khaparde wrote: > On Wed, Oct 30, 2019 at 12:43 AM David Marchand > wrote: > >> Hello Ajit, Kevin, >> >> On Wed, Oct 2, 2019 at 3:29 AM Ajit Khaparde >> wrote: >>> >>> On Tue, Oct 1, 2019 at 6:04 AM Kevin Traynor >> wrote: >>> If rc contains a non-zero return code

Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic

2019-11-05 Thread Kevin Traynor
On 30/10/2019 07:59, David Marchand wrote: > Hello Rosen, > > Review please. > Ping Rosen. > On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor wrote: >> >> Coverity is complaining about identical code regardless of which branch >> of the if else is taken. Functionally it means an error will always

Re: [dpdk-dev] Query on the old patch: examples/l3fwd: use reserved IPv4/IPv6 addresses

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 13:54:43 + Hemant Agrawal wrote: > Hi Stephen, > In one of your old patch, you have changed the default IP > addresses to the range of 192.18.0.0 citing RFC 5735. > commit 37afe381bde4277f0078116b8d4d7a315c8e39b3 > Author: Stephen Hemminger > Date: Wed Apr

Re: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Ray Kinsella
On 04/11/2019 10:39, Haiyue Wang wrote: > Change the type of burst mode information from bit field to free string > data, so that each PMD can describe the Rx/Tx busrt functions flexibly. > > Signed-off-by: Haiyue Wang > --- > > v2: - Drop the bit field for burst mode information handling. >

Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 15:12:07 + Ferruh Yigit wrote: > On 11/3/2019 7:50 AM, Slava Ovsiienko wrote: > > > > > >> -Original Message- > >> From: Damjan Marion (damarion) > >> Sent: Saturday, November 2, 2019 21:21 > >> To: Slava Ovsiienko > >> Cc: Liu, Yu Y ; Wang, Haiyue ; > >> Thom

Re: [dpdk-dev] [PATCH v1 02/13] net/ppfe: introduce ppfe net poll mode driver

2019-11-05 Thread Ferruh Yigit
On 11/4/2019 11:06 AM, Bruce Richardson wrote: > On Tue, Oct 29, 2019 at 09:27:22AM +, Ferruh Yigit wrote: >> On 10/28/2019 5:18 PM, Stephen Hemminger wrote: >>> On Mon, 26 Aug 2019 18:32:35 +0530 >>> Gagandeep Singh wrote: >>> --- a/config/common_base +++ b/config/common_base @

Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Tuesday, November 5, 2019 5:28 PM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh ; > dev@dpdk.org > Subject: [PATCH] net/mlx5: introduce mlx5 hash list > > Introduce simple hash list to the mlx5 utilities. User can define its own d

Re: [dpdk-dev] [PATCH v4 0/7] mempool: avoid objects allocations across pages

2019-11-05 Thread Olivier Matz
On Tue, Nov 05, 2019 at 04:36:59PM +0100, Olivier Matz wrote: > KNI supposes that mbufs are contiguous in kernel virtual memory. This > may not be true when using the IOVA=VA mode. To fix this, a possibility > is to ensure that objects do not cross page boundaries in mempool. This > patchset implem

[dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

2019-11-05 Thread Stephen Hemminger
The original patch used incorrect subnet range for testing. Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") Reported-by: Ferruh Yigit Signed-off-by: Stephen Hemminger --- doc/guides/testpmd_app_ug/run_app.rst | 6 +++--- examples/l3fwd/l3fwd_lpm.c| 18 +---

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

2019-11-05 Thread Ferruh Yigit
On 11/4/2019 11:24 AM, Shah, Rahul R wrote: > Hi Ferruh, > > I was checking the lib/Makefile for cryptodev example which is similar to > eventdev patch I have added (i.e. there is a dependency on librte_cryptodev > library) > > DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port > DEPDIRS-librte_port

Re: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

2019-11-05 Thread Ferruh Yigit
On 11/5/2019 4:09 PM, Stephen Hemminger wrote: > The original patch used incorrect subnet range for testing. > > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") > Reported-by: Ferruh Yigit I guess this is: Reported-by: Hemant Agrawal > Signed-off-by: Stephen Hemminger > ---

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

2019-11-05 Thread Shah, Rahul R
No, As Bruce explained I confirmed it is being already built before librte_port library as highlighted below. # process all libraries equally, as far as possible # "core" libs first, then others alphebetically as far as possible # NOTE: for speed of meson runs, the dependencies in the subdire

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

2019-11-05 Thread Ferruh Yigit
On 11/5/2019 4:13 PM, Shah, Rahul R wrote: > No, As Bruce explained I confirmed it is being already built before > librte_port > library as highlighted below. Got it, so meson doesn't need fixing. Can you please fix the make part?

Re: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 16:12:31 + Ferruh Yigit wrote: > On 11/5/2019 4:09 PM, Stephen Hemminger wrote: > > The original patch used incorrect subnet range for testing. > > > > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") > > Reported-by: Ferruh Yigit > > I guess this is:

Re: [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests

2019-11-05 Thread Ferruh Yigit
On 11/1/2019 5:04 PM, Wang, Yipeng1 wrote: > Hi, Amit, > > I think I acked this patch. But from patchwork seems you superseded this > patch set accidentally. So Thomas might have missed it. > To make his life easier, you may submit a newer version with my acked. I > believe Thomas will see it.

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-11-05 Thread Ori Kam
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, November 5, 2019 1:31 PM > To: Ori Kam ; Thomas Monjalon > > Cc: dev@dpdk.org; pbhagavat...@marvell.com; ferruh.yi...@intel.com; > jer...@marvell.com; John McNamara ; Marko > Kovacevic ; Adrien Mazarguil > ; david.march...@r

Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks

2019-11-05 Thread Kevin Traynor
On 30/10/2019 07:52, David Marchand wrote: > On Tue, Oct 1, 2019 at 2:54 PM Kevin Traynor wrote: >> >> Previously rx/tx_queues were passed into eth_from_pcaps_common() >> as ptrs and were checked for being NULL. >> >> In commit da6ba28f0540 ("net/pcap: use a struct to pass user options") >> that c

Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks

2019-11-05 Thread Ferriter, Cian
> -Original Message- > From: Kevin Traynor > Sent: Tuesday 5 November 2019 16:41 > To: David Marchand > Cc: dev ; Ferriter, Cian ; dpdk > stable ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks > > On 30/10/2019 07:52, David Marchand wrote: > > On Tu

[dpdk-dev] [PATCH 18.11] vfio: fix DMA mapping of externally allocated heaps

2019-11-05 Thread Anatoly Burakov
Currently, externally created heaps are supposed to be automatically mapped for VFIO DMA by EAL, however they only do so if, at the time of heap creation, VFIO is initialized and has at least one device available. If no devices are available at the time of heap creation (or if devices were availabl

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-11-05 Thread Burakov, Anatoly
On 05-Nov-19 3:18 PM, Burakov, Anatoly wrote: On 05-Nov-19 2:10 PM, Rajesh Ravi wrote: Thanks a lot Anatoly. Will the same solution work with  DPDK 19.02 as well? We 're actually using DPDK 19.02 for memory allocations for SPDK 19.07. DPDK 19.11 may not be supported by SPDK 19.07 we 're curren

Re: [dpdk-dev] [PATCH 19.11] vfio: fix DMA mapping of externally allocated heaps

2019-11-05 Thread Burakov, Anatoly
On 05-Nov-19 3:15 PM, Anatoly Burakov wrote: Currently, externally created heaps are supposed to be automatically mapped for VFIO DMA by EAL, however they only do so if, at the time of heap creation, VFIO is initialized and has at least one device available. If no devices are available at the tim

Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 17:28:00 +0200 Bing Zhao wrote: > Introduce simple hash list to the mlx5 utilities. User can define > its own data structure containing the mlx5_hlist_entry and create > the hash list table via the creation interface. Then the entry will > be inserted into the table and linked

Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 17:28:00 +0200 Bing Zhao wrote: > +struct mlx5_hlist * > +mlx5_hlist_create(char *name, uint64_t size, mlx5_hlist_destroy_callback_fn > cb) Name is unused in rte_malloc, so why bother with it here? > +{ > + struct mlx5_hlist *h; > + uint64_t act_size; > + uint64_

Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 16:02:18 + Raslan Darawsheh wrote: > Hi, > > > -Original Message- > > From: Bing Zhao > > Sent: Tuesday, November 5, 2019 5:28 PM > > To: Ori Kam ; Slava Ovsiienko > > ; Raslan Darawsheh ; > > dev@dpdk.org > > Subject: [PATCH] net/mlx5: introduce mlx5 hash list >

Re: [dpdk-dev] [PATCH] ethdev: fix compilation related to hairpin

2019-11-05 Thread Ferruh Yigit
On 11/5/2019 3:32 PM, Ori Kam wrote: > This patch solves a compilation issue that is caused due to using > internal function (is_rx_hairpin_queue) inside inline function. > > The solution is to remove the usage of the functions > from the burst functions. > > Fixes: 60b476d5da3c ("ethdev: add sup

Re: [dpdk-dev] [PATCH v8 2/4] doc: changes to abi policy introducing major abi versions

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 15:24:16 + Ray Kinsella wrote: > This policy change introduces major ABI versions, these are > declared every year, typically aligned with the LTS release > and are supported by subsequent releases in the following year. > This change is intended to improve ABI stabilty fo

Re: [dpdk-dev] [PATCH v8 3/4] doc: updates to versioning guide for abi versions

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 15:24:17 + Ray Kinsella wrote: > Updates to the ABI versioning guide, to account for the changes to the DPDK > ABI/API policy. Fixes for references to abi versioning and policy guides. > > Signed-off-by: Ray Kinsella > --- Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH v8 1/4] doc: separate versioning.rst into version and policy

2019-11-05 Thread Stephen Hemminger
On Tue, 5 Nov 2019 15:24:15 + Ray Kinsella wrote: > Separate versioning.rst into abi versioning and abi policy guidance, in > preparation for adding more detail to the abi policy. > > Signed-off-by: Ray Kinsella > --- > doc/guides/contributing/abi_policy.rst | 167 > doc/guid

Re: [dpdk-dev] [PATCH] net/bnx2x: fix meson build failure

2019-11-05 Thread Thomas Monjalon
01/11/2019 07:02, Rasesh Mody: > Use kernel headers for __le* types to avoid potential conflicts > resulting in redefinition errors during Linux builds. Add check > for BSD builds. I don't see the error with my test builds. Please could you describe a case where it happens? And please provide an e

[dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags

2019-11-05 Thread devyn . johnson
From: Devyn Collier Johnson Signed-off-by: Devyn Collier Johnson --- lib/librte_cryptodev/rte_cryptodev.c| 4 ++-- lib/librte_eal/common/eal_common_cpuflags.c | 4 ++-- lib/librte_eal/common/eal_common_errno.c| 2 +- lib/librte_eal/common/eal_common_hexdump.c | 4 ++-- lib/libr

[dpdk-dev] [PATCH] Applied tweaks requested by the mailing-list patch-checker

2019-11-05 Thread devyn . johnson
From: Devyn Collier Johnson Signed-off-by: Devyn Collier Johnson --- app/test/test_cmdline_portlist.c| 2 +- examples/vmdq_dcb/main.c| 2 +- lib/librte_cryptodev/rte_cryptodev.c| 2 +- lib/librte_eal/common/eal_common_tailqs.c | 2 +- lib/librte_eal/com

[dpdk-dev] [RFC 0/4] cpu-crypto API choices

2019-11-05 Thread Konstantin Ananyev
Originally both SW and HW crypto PMDs use rte_crypot_op based API to process the crypto workload asynchronously. This way provides uniformity to both PMD types, but also introduce unnecessary performance penalty to SW PMDs that have to "simulate" HW async behavior (crypto-ops enqueue/dequeue, HW ad

[dpdk-dev] [RFC 4/4] cryptodev: introduce rte_crypto_cpu_sym_session API

2019-11-05 Thread Konstantin Ananyev
This patch extends rte_cryptodev API with CPU-CRYPTO mode. This is done by reusing of existing rte_crypto_sym_xform data structures and introducing new opaque rte_crypto_cpu_sym_session data structure and related control and data path API. Crypto PMD that wants to support that functionality would

[dpdk-dev] [RFC 3/4] cryptodev: introduce cpu-crypto API

2019-11-05 Thread Konstantin Ananyev
This patch extends rte_cryptodev API with CPU-CRYPTO mode. This is done by reusing existing rte_crypto_sym_session structure itself and related control-path cryptodev API (init/clear/get_size/etc.) For data-path new sym_cpu_ process() function is added into rte_cryptodev dev_ops. Crypto PMD t

[dpdk-dev] [RFC 1/4] cpu-crypto: Introduce basic data structures

2019-11-05 Thread Konstantin Ananyev
Introduce basic data strucure to be used with cpu-crypto data-path. Signed-off-by: Konstantin Ananyev --- lib/librte_cryptodev/rte_crypto_sym.h | 52 +-- lib/librte_security/rte_security.h| 6 +++- 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/lib/l

[dpdk-dev] [RFC 2/4] security: introduce cpu-crypto API

2019-11-05 Thread Konstantin Ananyev
This patch extends rte_security API with CPU-CRYPTO mode. Crypto PMD that wants to support that functionality would need to: 1. claim RTE_CRYPTODEV_FF_SECURITY capability supported. 2. at device .probe() allocate and initialize security context (dev-> security_ctx). 3. implement at least the follo

[dpdk-dev] [PATCH] Fixed one missed request for the mailing-list patch-checker

2019-11-05 Thread devyn . johnson
From: Devyn Collier Johnson Signed-off-by: Devyn Collier Johnson --- lib/librte_mbuf/rte_mbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index f3fe16eb0..305084531 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/li

Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list

2019-11-05 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, November 5, 2019 19:21 > To: Bing Zhao > Cc: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: introduce mlx5 hash list > > On Tue, 5 Nov 2019 17:28:00 +0200 > Bing

[dpdk-dev] [PATCH v3] app/testpmd: add hairpin support

2019-11-05 Thread Ori Kam
This commit introduce the hairpin queues to the testpmd. the hairpin queue is configured using --hairpinq= the hairpin queue adds n queue objects for both the total number of TX queues and RX queues. The connection between the queues are 1 to 1, first Rx hairpin queue will be connected to the first

Re: [dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags

2019-11-05 Thread David Marchand
Hello, On Tue, Nov 5, 2019 at 7:17 PM wrote: > > From: Devyn Collier Johnson > > Signed-off-by: Devyn Collier Johnson > --- > lib/librte_cryptodev/rte_cryptodev.c| 4 ++-- > lib/librte_eal/common/eal_common_cpuflags.c | 4 ++-- > lib/librte_eal/common/eal_common_errno.c| 2 +- >

Re: [dpdk-dev] [PATCH] net/bnx2x: fix meson build failure

2019-11-05 Thread Rasesh Mody
>From: Thomas Monjalon >Sent: Tuesday, November 05, 2019 10:15 AM > >01/11/2019 07:02, Rasesh Mody: >> Use kernel headers for __le* types to avoid potential conflicts >> resulting in redefinition errors during Linux builds. Add check for >> BSD builds. > >I don't see the error with my test builds.

Re: [dpdk-dev] [PATCH] Working Towards Making DPDK Compile with Additional Warning Flags

2019-11-05 Thread Devyn Johnson
On Tue, Nov 5, 2019 at 1:36 PM David Marchand wrote: > Hello, > > On Tue, Nov 5, 2019 at 7:17 PM wrote: > > > > From: Devyn Collier Johnson > > > > Signed-off-by: Devyn Collier Johnson > > --- > > lib/librte_cryptodev/rte_cryptodev.c| 4 ++-- > > lib/librte_eal/common/eal_common_cpuf

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix length retreived from hardware

2019-11-05 Thread Akhil Goyal
FD retreived from SEC after crypto processing provides an updated length of the buffer which need to be updated in mbuf. The difference in length can be negative hence changing diff to int32_t from uint32_t. Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec") Cc: sta...@dpdk.o

Re: [dpdk-dev] [RFC 3/4] cryptodev: introduce cpu-crypto API

2019-11-05 Thread Akhil Goyal
Hi Konstantin, > > This patch extends rte_cryptodev API with CPU-CRYPTO mode. > This is done by reusing existing rte_crypto_sym_session structure itself > and related control-path cryptodev API (init/clear/get_size/etc.) > For data-path new sym_cpu_ process() function is added into > rte_cryptod

Re: [dpdk-dev] [PATCH v5 2/3] ipsec: remove redundant replay_win_sz

2019-11-05 Thread Akhil Goyal
Hi Hemant, > > The rte_security lib has introduced replay_win_sz, > so it can be removed from the rte_ipsec lib. > > Also, the relaved tests,app are also update to reflect > the usages. > > Signed-off-by: Hemant Agrawal > Acked-by: Konstantin Ananyev > --- > app/test/test_ipsec.c

Re: [dpdk-dev] [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window config

2019-11-05 Thread Akhil Goyal
Hi Hemant, > > This patch usages the anti replay window size to config > the anti replay checking in decap path for lookaside > IPSEC offload > > Signed-off-by: Hemant Agrawal > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 24 +++ > drivers/crypto/dpaa2_sec/dpaa2_sec_pri

Re: [dpdk-dev] [PATCH] app: add few sanity checks in test-sad app

2019-11-05 Thread Akhil Goyal
> > Coverity reported about two division by zero: > *** CID 350344: Incorrect expression (DIVIDE_BY_ZERO) > Although in fact these dividers will never be equal to 0, > adding explicit checks in lookup() to make coverity happy > will not affect the execution speed. > > Signed-off-by: Vladimir

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix length retreived from hardware

2019-11-05 Thread Akhil Goyal
> FD retreived from SEC after crypto processing provides > an updated length of the buffer which need to be updated > in mbuf. The difference in length can be negative hence > changing diff to int32_t from uint32_t. > > Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec") >

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix gcm iv length

2019-11-05 Thread Akhil Goyal
> > The example IPsec application does not work properly when using > AES-GCM with crypto_openssl. > > ESP with AES-GCM uses standard 96bit long algorithm IV ([1]) which > later concatenated with be32(1) forms a J0 block. GCM specification > ([2], chapter 7.1) states that when length of IV is

Re: [dpdk-dev] [PATCH] doc: support IPsec Multi-buffer lib v0.53

2019-11-05 Thread Akhil Goyal
> Updated AESNI MB and AESNI GCM PMD documentation guides > with information about the latest Intel IPSec Multi-buffer > library supported. > > Signed-off-by: Pablo de Lara Applied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH v2] crypto/aesni_gcm: support in-place chained mbufs

2019-11-05 Thread Akhil Goyal
> IPSec Multi buffer library supports encryption on multiple segments. > When dealing with chained buffers (multiple segments), as long as > the operation is in-place, the destination buffer does not have to > be contiguous (unlike in the case of out-of-place operation). > Therefore, the limitati

Re: [dpdk-dev] [PATCH v6 00/12] lib: add RIB and FIB liraries

2019-11-05 Thread Thomas Monjalon
01/11/2019 16:21, Vladimir Medvedkin: > This is heavily reworked version of previous RIB library series: > https://mails.dpdk.org/archives/dev/2018-April/099492.html > > app/test/Makefile | 7 + > app/test/autotest_data.py | 48 +++ > app/test/meson.build

Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove

2019-11-05 Thread Ye Xiaolong
Hi, Ferruh On 11/05, Ferruh Yigit wrote: >On 10/28/2019 5:51 AM, Yang, Qiming wrote: >> Hi, >> >>> -Original Message- >>> From: Di, ChenxuX >>> Sent: Thursday, October 24, 2019 9:03 AM >>> To: dev@dpdk.org >>> Cc: Lu, Wenzhuo ; Yang, Qiming >>> ; Di, ChenxuX >>> Subject: [PATCH] app/test

Re: [dpdk-dev] [PATCH v8 2/4] doc: changes to abi policy introducing major abi versions

2019-11-05 Thread Thomas Monjalon
I'm sorry I still have some comments. But on the positive side, you can see that I carefuly read this doc. 05/11/2019 16:24, Ray Kinsella: > +#. Major ABI versions are declared every **year** and are then supported for > one > + year, typically aligned with the :ref:`LTS release `. As discusse

Re: [dpdk-dev] [PATCH 0/9 v4] DPAA and FSLMC driver fixes and cleanup

2019-11-05 Thread Thomas Monjalon
05/11/2019 15:23, Nipun Gupta: > Hemant Agrawal (1): > bus/dpaa: moving qbman global init to bus > > Nipun Gupta (7): > net/dpaa: fix supported RSS types > net/dpaa: fix LS1043 alignment check > common/dpaax: fallback to check separate memory node for VM > net/dpaa2: add retry and timeou

Re: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Thomas Monjalon
04/11/2019 11:39, Haiyue Wang: > Change the type of burst mode information from bit field to free string > data, so that each PMD can describe the Rx/Tx busrt functions flexibly. > > Signed-off-by: Haiyue Wang > --- > > v2: - Drop the bit field for burst mode information handling. Please use --

Re: [dpdk-dev] [PATCH] net/octeontx2: fix compilation with x86_x32

2019-11-05 Thread Gavin Hu (Arm Technology China)
Reviewed-by: Gavin Hu

Re: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Wang, Haiyue
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 6, 2019 08:34 > To: Wang, Haiyue > Cc: dev@dpdk.org; jerinjac...@gmail.com; Yigit, Ferruh > ; > arybche...@solarflare.com; viachesl...@mellanox.com; damar...@cisco.com; Ye, > Xiaolong > ; Sun, Chenmin ;

[dpdk-dev] [PATCH v6] net/virtio-user: fix failures when setting filters

2019-11-05 Thread Marvin Liu
As doc mentioned, Rx/Mac/vlan filters are all supported by best effort. These control commands should return success. Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device emulation") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu --- drivers/net/virtio/virtio_user/virtio_user_dev

[dpdk-dev] [PATCH v3] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Haiyue Wang
Change the type of burst mode information from bit field to free string data, so that each PMD can describe the Rx/Tx busrt functions flexibly. Signed-off-by: Haiyue Wang Acked-by: Ray Kinsella --- v3: - Fix one doxygen issue. v2: - http://patchwork.dpdk.org/patch/62368/ - Drop the bit fiel

[dpdk-dev] [PATCH] net/ice: change RSS rule destroy API

2019-11-05 Thread Simei Su
This patch changes RSS rule destroy API from ice_rem_vsi_rss_cfg() to ice_rem_rss_cfg(). ice_rem_vsi_rss_cfg() removes RSS configurations associated with VSI. ice_rem_rss_cfg() remove an existing RSS configuration with matching hashed fields. To support input set change, we should adopt ice_rem_rss

Re: [dpdk-dev] [PATCH v2] ethdev: enhance the API for getting burst mode information

2019-11-05 Thread Wang, Haiyue
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, November 6, 2019 09:22 > To: Thomas Monjalon > Cc: dev@dpdk.org; jerinjac...@gmail.com; Yigit, Ferruh > ; > arybche...@solarflare.com; viachesl...@mellanox.com; damar...@cisco.com; Ye, > Xiaolong > ; Sun, Chenmin ; Kinsella, Ra

Re: [dpdk-dev] [dpdk-techboard] [RFC 0/4] cpu-crypto API choices

2019-11-05 Thread Honnappa Nagarahalli
> > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > process the crypto workload asynchronously. This way provides uniformity to > both PMD types, but also introduce unnecessary performance penalty to SW > PMDs that have to "simulate" HW async behavior (crypto-ops > enqueue

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

2019-11-05 Thread Zhang, Xiao
Hi Eelco > -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Friday, November 1, 2019 4:13 PM > To: Xing, Beilei ; Zhang, Xiao > Cc: Zhang, Qi Z ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF > reset > > > > On 1

Re: [dpdk-dev] [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window config

2019-11-05 Thread Hemant Agrawal
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Wednesday, November 6, 2019 3:38 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: konstantin.anan...@intel.com; ano...@marvell.com; Hemant Agrawal > > Subject: RE: [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window > config >

Re: [dpdk-dev] [PATCH v5 2/3] ipsec: remove redundant replay_win_sz

2019-11-05 Thread Hemant Agrawal
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, November 6, 2019 3:32 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: konstantin.anan...@intel.com; ano...@marvell.com; Hemant Agrawal > > Subject: RE: [PATCH v5 2/3] ipsec: remove redundant replay_win_sz > Importance: High > >

[dpdk-dev] [PATCH v3 07/13] crypto/dpaa_sec: add AES-GCM support for lookaside case

2019-11-05 Thread Hemant Agrawal
This patch add support for AES-128-GCM, when used in proto lookaside mode. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 309 - 1 file changed, 211 insertions(+), 98 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/cryp

[dpdk-dev] [PATCH v3 01/13] crypto/dpaa_sec: fix to set PDCP capability flags

2019-11-05 Thread Hemant Agrawal
set the pdcp capa_flags to 0 by default. Fixes: a1173d55598c ("crypto/dpaa_sec: support PDCP offload") Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_se

[dpdk-dev] [PATCH v3 06/13] crypto/dpaa2_sec: add AES-GCM support for lookaside case

2019-11-05 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 60 +++-- 1 file changed, 56 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index dd80e6dc5..173ec8095 100644 ---

[dpdk-dev] [PATCH v3 04/13] crypto/dpaa2_sec: adding NULL cipher or NULL auth

2019-11-05 Thread Hemant Agrawal
These are supported when using protocol offload mode or in chain mode. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 22 +++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 41 + 2 files changed, 56 insertions(+), 7 deletions(-) diff -

[dpdk-dev] [PATCH v3 02/13] crypto/dpaa2_sec: add check for the session validity

2019-11-05 Thread Hemant Agrawal
Check if the session is not null during processing. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index b04890a48..7d5

[dpdk-dev] [PATCH v3 05/13] crypto/dpaa_sec: adding NULL cipher or NULL auth

2019-11-05 Thread Hemant Agrawal
These are supported when using protocol offload mode or when in chain mode. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 33 ++-- drivers/crypto/dpaa_sec/dpaa_sec.h | 41 ++ 2 files changed, 66 insertions(+), 8 deletions(-

[dpdk-dev] [PATCH v3 03/13] crypto/dpaa_sec: add check for the session validity

2019-11-05 Thread Hemant Agrawal
Check if the session is not null during processing. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 6c186338f..343a565a2 100644 --- a/dr

[dpdk-dev] [PATCH v3 13/13] crypto/dpaa_sec: enable ipsec aes-ctr to use nonce

2019-11-05 Thread Hemant Agrawal
From: Vakul Garg The protocol aware ipsec descriptor has been modified to use ctr_initial value of 1 and salt configured for ipsec SA. Signed-off-by: Hemant Agrawal Signed-off-by: Vakul Garg --- drivers/common/dpaax/caamflib/desc/ipsec.h | 18 -- drivers/crypto/dpaa2_sec/dpaa

<    1   2   3   >