On 11/4/2019 11:24 AM, Shah, Rahul R wrote: > Hi Ferruh, > > I was checking the lib/Makefile for cryptodev example which is similar to > eventdev patch I have added (i.e. there is a dependency on librte_cryptodev > library) > > DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port > DEPDIRS-librte_port := librte_eal librte_mempool librte_mbuf librte_ethdev > DEPDIRS-librte_port += librte_ip_frag librte_sched > ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) > DEPDIRS-librte_port += librte_kni > Endif > > This is how it is added in lib/Makefile. I don’t see cryptodev added here.
Hi Rahul, I didn't get your point, is cryptodev dependency also missing? If so can you please fix that too? > > > Thanks, > Rahul > > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, October 31, 2019 10:33 PM > To: Shah, Rahul R <rahul.r.s...@intel.com>; Dumitrescu, Cristian > <cristian.dumitre...@intel.com> > Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>; Thomas > Monjalon <tho...@monjalon.net>; Richardson, Bruce <bruce.richard...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the > rte_port library > > On 10/1/2019 7:05 PM, Rahul Shah wrote: >> Adding a new port type called eventdev to the rte_port library. >> >> Signed-off-by: Rahul Shah <rahul.r.s...@intel.com> >> --- >> lib/librte_port/Makefile | 4 +- >> lib/librte_port/meson.build | 8 +- >> lib/librte_port/rte_port_eventdev.c | 585 >> +++++++++++++++++++++++++++ lib/librte_port/rte_port_eventdev.h | 100 +++++ >> lib/librte_port/rte_port_version.map | 9 + >> 5 files changed, 702 insertions(+), 4 deletions(-) create mode >> 100644 lib/librte_port/rte_port_eventdev.c >> create mode 100644 lib/librte_port/rte_port_eventdev.h >> >> diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile index >> 1b83f6f2b..de6f0428a 100644 >> --- a/lib/librte_port/Makefile >> +++ b/lib/librte_port/Makefile >> @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y) LDLIBS += -lpcap >> endif LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev >> -LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev >> +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev -lrte_eventdev > > This creates a dependency form 'librte_port' to 'librte_eventdev', this > dependency should be reflected to the build system, so that 'librte_eventdev' > have built before 'librte_port' > This is done via 'lib/Makefile' in make build but not sure how to do in meson. > > Can you please send a fix for this? >
