On 10/21/19 3:22 PM, Ciara Power wrote:
The promiscuous enable and disable functions now check the
promiscuous state of the device before checking if the dev_ops
function exists for the device.
This change is necessary to allow sample applications run on
virtual PMDs, as previously -ENOTSUP retu
Hi Ferruh
From: Yigit, Ferruh
> On 7/31/2019 7:11 AM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > From: Ferruh Yigit
> >> On 7/30/2019 7:34 PM, Matan Azrad wrote:
> >>>
> >>>
> >>> From: Ferruh Yigit
> On 7/30/2019 4:56 PM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > From: Ferruh Yigi
When calculate queue index for queue action in
switch filter, vsi base queue should be included.
Cc: sta...@dpdk.org
Fixes: 24dc00c30907 ("net/ice: enable switch filter")
Signed-off-by: Wei Zhao
---
drivers/net/ice/ice_switch_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 10/21/19 3:22 PM, Ciara Power wrote:
The promiscuous and multicast fields are now initialised as enabled for
some virtual PMDs. This allows the devices to be used when running
applications that attempt to enable promiscuous or multicast mode.
Signed-off-by: Ciara Power
Acked-by: Andrew Ryb
The DevX counter management triggers an asynchronous event to get back
the new counters values from the HW.
The counter management doesn't trigger 2 parallel events for the same
pool, hence, the pool cannot be updated again in the event waiting time.
When the port is stopped, the DevX event mecha
On 10/22, Wei Zhao wrote:
>When calculate queue index for queue action in
>switch filter, vsi base queue should be included.
>
>Cc: sta...@dpdk.org
>Fixes: 24dc00c30907 ("net/ice: enable switch filter")
Should be:
Fixes: 57c4f2693588 ("net/ice: enable switch filter")
>
>Signed-off-by: Wei Zhao
>
On 10/22, Wei Zhao wrote:
>When calculate queue index for queue action in
>switch filter, vsi base queue should be included.
>
>Cc: sta...@dpdk.org
>Fixes: 24dc00c30907 ("net/ice: enable switch filter")
>
>Signed-off-by: Wei Zhao
>---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 file changed,
When calculate queue index for queue action in
switch filter, vsi base queue should be included.
Cc: sta...@dpdk.org
Fixes: 57c4f2693588 ("net/ice: enable switch filter")
Signed-off-by: Wei Zhao
---
drivers/net/ice/ice_switch_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
>
> According to RFC 4301 IPSec implementation needs an inbound SA database
> (SAD).
> For each incoming inbound IPSec-protected packet (ESP or AH) it has to
> perform a lookup within it’s SAD.
> Lookup should be performed by:
> Security Parameters Index (SPI) + destination IP (DIP) + source IP (S
>
> Failures found when running validation with FPGA HW and the related FPGA PMD
> driver on latest code base pre 19.11.
> Two bug fixes below :
> - The first error is a fatal failure during probing which was missed and would
> fundamentally prevent using the driver. This was missed as HW valida
> -Original Message-
> From: dev On Behalf Of Vladimir Medvedkin
> Sent: Thursday, October 10, 2019 10:22 PM
> To: dev@dpdk.org
> Cc: konstantin.anan...@intel.com; john.mcnam...@intel.com;
> marko.kovace...@intel.com
> Subject: [dpdk-dev] [PATCH] doc: add doxygen documentation for ipsec
On 21/10/2019 15:38, Thomas Monjalon wrote:
> 21/10/2019 12:10, Ray Kinsella:
>>
>> On 21/10/2019 10:50, Thomas Monjalon wrote:
>>> 27/09/2019 18:54, Ray Kinsella:
TL;DR abbreviation:
A major ABI version that all DPDK releases during a one year period
support. ABI versioning is ma
On 10/22/2019 1:29 PM, Ting Xu wrote:
> This patch enables testpmd to forward GTP packet in csum fwd mode.
> A GTP header structure (without optional fields and extension header)
> is defined in new rte_gtp.h. A parser function in testpmd is added.
> GTPU and GTPC packets are both supported, with r
On 10/22/2019 8:03 AM, Andrew Rybchenko wrote:
> On 10/21/19 3:22 PM, Ciara Power wrote:
>> The promiscuous enable and disable functions now check the
>> promiscuous state of the device before checking if the dev_ops
>> function exists for the device.
>>
>> This change is necessary to allow sample
Here are two little changes to be able to run testpmd as non-root with
virtio ports in a guest.
This requires a functional vIOMMU (the main pain parts being writing a
Q35 machine configuration in qemu for x86 guests).
No major change since the RFC, I just did not find the time to describe
the full
On x86, calling inb/outb special instructions (used in UIO ioport
read/write parts) is only possible if the right IO permissions has been
granted.
The only user of this API (the net/virtio pmd) checks this
unconditionnaly but this should be hidden by the rte_pci_ioport API
itself and only checked
On x86, iopl permissions are only available to root user (or users that
have the CAP_SYS_RAWIO capability).
But those permissions are only needed when the virtio devices accesses
are done with inb/outb instructions, which is when the device is bound
to a UIO kernel module.
So far, the virtio drive
Sure, I will investigate and send v4.
Thanks,
Arek
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, October 22, 2019 8:54 AM
> To: Kusztal, ArkadiuszX ; dev@dpdk.org
> Cc: Trahe, Fiona
> Subject: RE: [PATCH v3 0/5] Add session-less, RSA, RSA-CRT to QA
On 10/21/2019 7:52 PM, Rasesh Mody wrote:
> Hi Kevin,
>
>> From: Kevin Traynor
>> Sent: Monday, October 21, 2019 3:58 AM
>>
>> --
>> On 20/10/2019 06:20, Rasesh Mody wrote:
>>> In our testing we have identified a critical FW bug.
On Mon, Oct 21, 2019 at 5:05 PM Rao, Nikhil wrote:
>
> > -Original Message-
> > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > Sent: Thursday, October 3, 2019 3:57 PM
> > To: Hemant Agrawal
> > Cc: Rao, Nikhil ; Nipun Gupta ;
> > Jerin Jacob ; dpdk-dev ; Pavan Nikhilesh
> > ; Sunil
Thank you Bruce for the comment. The original patch set did not manage
to get to the dev list (I've sent it from my Marvell account and it
stuck at moderation). So I'll take your "indent" comment and will send
another version which will hopefully get through.
On 10/21/19 2:59 PM, Bruce Richardso
On 10/22/2019 6:31 AM, Gagandeep Singh wrote:
>
> <...>
>>>
>>> include $(RTE_SDK)/mk/rte.lib.mk
>>> diff --git a/drivers/net/enetc/enetc_ethdev.c
>> b/drivers/net/enetc/enetc_ethdev.c
>>> index 4e978348c..475ec77c3 100644
>>> --- a/drivers/net/enetc/enetc_ethdev.c
>>> +++ b/drivers/net/enetc/ene
On 10/22/2019 6:31 AM, Gagandeep Singh wrote:
>
>
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Monday, October 21, 2019 9:26 PM
>> To: Gagandeep Singh ; dev@dpdk.org
>> Subject: Re: [PATCH v4 3/3] net/enetc: enable dpaax library
>>
>> On 10/21/2019 11:50 AM, Gagandeep Singh wrote
On Wed, Oct 2, 2019 at 9:40 PM Stephen Hemminger
wrote:
> +struct lcore_config {
> + pthread_t thread_id; /**< pthread identifier */
> + int pipe_master2slave[2]; /**< communication pipe with master */
> + int pipe_slave2master[2]; /**< communication pipe with master */
>
On 22/10/2019 09:45, Ferruh Yigit wrote:
> On 10/21/2019 7:52 PM, Rasesh Mody wrote:
>> Hi Kevin,
>>
>>> From: Kevin Traynor
>>> Sent: Monday, October 21, 2019 3:58 AM
>>>
>>> --
>>> On 20/10/2019 06:20, Rasesh Mody wrote:
In
On 10/22/2019 5:16 AM, kirankum...@marvell.com wrote:
> From: Kiran Kumar K
>
> Add new rte_flow_item_higig2_hdr in order to match higig2 header.
> It is a layer 2.5 protocol and used in Broadcom switches.
> Header format is based on the following document.
> http://read.pudn.com/downloads558/doc
This patch enables testpmd to forward GTP packet in csum fwd mode.
A GTP header structure (without optional fields and extension header)
is defined in new rte_gtp.h. A parser function in testpmd is added.
GTPU and GTPC packets are both supported, with respective UDP
destination port and GTP message
Hi Olivier, Andrew,
Please share your thoughts/comments on below email.
> -Original Message-
> From: Vamsi Krishna Attunuru
> Sent: Monday, October 21, 2019 8:08 PM
> To: olivier.m...@6wind.com; Andrew Rybchenko
>
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> Kiran Kumar Kokki
Let's prepare for the ABI freeze.
The first patches are about changes that had been announced before (with
a patch from Stephen that I took as it is ready as is from my pov).
The malloc_heap structure from the memory subsystem can be hidden.
The PCI library had some forgotten deprecated APIs that
From: Stephen Hemminger
The internal structure of lcore_config does not need to be part of
visible API/ABI. Make it private to EAL.
Rearrange the structure so it takes less memory (and cache footprint).
Signed-off-by: Stephen Hemminger
Signed-off-by: David Marchand
---
Based on Stephen v8: ht
Remove rte_cpu_check_supported as announced previously.
Signed-off-by: David Marchand
---
doc/guides/rel_notes/deprecation.rst | 3 ---
doc/guides/rel_notes/release_19_11.rst | 3 +++
lib/librte_eal/common/eal_common_cpuflags.c | 11 ---
lib/librt
No need to expose rte_logs, hide it and remove it from the current ABI.
Signed-off-by: David Marchand
---
lib/librte_eal/common/eal_common_log.c | 23 ---
lib/librte_eal/common/include/rte_log.h | 20 +++-
lib/librte_eal/rte_eal_version.map | 1 -
3 fil
Those functions have been deprecated since 17.11 and have 1:1
replacement.
Signed-off-by: David Marchand
---
doc/guides/rel_notes/deprecation.rst | 7 -
doc/guides/rel_notes/release_19_11.rst | 6 +
lib/librte_pci/rte_pci.c | 19 --
lib/librte_pci/rte_pci.h
Let's avoid exporting structures without an identified usecase.
Signed-off-by: David Marchand
---
app/test-pmd/testpmd.c | 1 -
lib/librte_eal/common/Makefile | 2 +-
lib/librte_eal/common/eal_memcfg.h | 3 ++-
lib/librte_eal/common/inclu
Remove rte_malloc_virt2phy as announced previously.
Signed-off-by: David Marchand
---
doc/guides/rel_notes/deprecation.rst | 3 ---
doc/guides/rel_notes/release_19_11.rst | 3 +++
lib/librte_eal/common/include/rte_malloc.h | 7 ---
3 files changed, 3 insertions(+), 10 deletions(-)
Define an accessor so that users can write their debug message to the
same stream than the rte_log infrastructure.
Use it in the qat infrastructure.
Signed-off-by: David Marchand
---
drivers/common/qat/qat_logs.c | 3 +--
drivers/common/qat/qat_logs.h | 3 +--
lib/librte_ea
rte_eal_compare_pci_addr has been deprecated since v17.11.
Convert to rte_pci_addr_cmp.
Fixes: c848b518bbc7 ("net/bonding: support bifurcated driver in eal")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/bonding/rte_eth_bond_args.c | 5 ++---
1 file changed, 2 insertions(+),
> > The rte_wait_until_equal_xx APIs abstract the functionality of
> > 'polling for a memory location to become equal to a given value'.
> >
> > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled
> > by default. When it is enabled, the above APIs will call WFE instruction
> > to save
> -Original Message-
> From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> Sent: Tuesday, October 22, 2019 2:15 PM
> To: Rao, Nikhil
> Cc: Nipun Gupta ; Jerin Jacob ;
> dpdk-dev ; Pavan Nikhilesh ;
> Sunil Kumar Kori ; Richardson, Bruce
> ; Kovacevic, Marko
> ; Ori Kam ; Nicolau, Radu
> ;
On Tue, Oct 22, 2019 at 11:37 AM Ananyev, Konstantin
wrote:
>
> > > The rte_wait_until_equal_xx APIs abstract the functionality of
> > > 'polling for a memory location to become equal to a given value'.
> > >
> > > Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled
> > > by default.
Hi,
@Pavan, see question below.
On 10/21/19 6:34 PM, Ferruh Yigit wrote:
On 10/21/2019 4:19 PM, Pavan Nikhilesh Bhagavatula wrote:
Hi Ferruh,
-Original Message-
From: Ferruh Yigit
Sent: Monday, October 21, 2019 8:37 PM
To: Andrew Rybchenko ; Pavan Nikhilesh
Bhagavatula ; Jerin Jacob
On 15/10/2019 18:19, Kevin Traynor wrote:
> On 15/10/2019 18:12, Abhishek Marathe wrote:
>> Hi Kevin,
>>
>> We tried reverting all netvsc and failsafe patches, still we got the same
>> results. We are still looking into it.
>> "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is
On 10/17/19 6:32 PM, Ori Kam wrote:
The queue state defines are internal to the DPDK.
This commit moves them to a private header file.
Signed-off-by: Ori Kam
Reviewed-by: Andrew Rybchenko
Yes, there is a lot of space for improvements in queue state
management etc, but this one is a step in
On Mon, Oct 21, 2019 at 03:23:09PM +0800, Ye Xiaolong wrote:
> +Bruce for the meson change.
>
> Thanks,
> Xiaolong
>
> On 10/21, Andy Pei wrote:
> >From: Rosen Xu
> >
> >The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev,
> >so it doesn't need to provide configuration for i40e por
Hi Honnappa,
As per the comments received in
http://patches.dpdk.org/patch/60499/
http://patches.dpdk.org/patch/61013/
Marvell will no longer host the external library for the PMD.
We can have 2 possible solutions to this situation
1. Arm host it somewhere and let people contribute to that.
Thanks David, please see my comments below.
> -Original Message-
> From: David Marchand
> Sent: Tuesday, October 8, 2019 1:05 PM
> To: Dekel Peled
> Cc: Wenzhuo Lu ; Jingjing Wu
> ; Iremonger, Bernard
> ; Mcnamara, John
> ; Kovacevic, Marko
> ; Burakov, Anatoly
> ; dev ; dpdk stable
>
>
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, October 22, 2019 2:31 PM
> To: Gagandeep Singh ; dev@dpdk.org
> Subject: Re: [PATCH v4 3/3] net/enetc: enable dpaax library
>
> On 10/22/2019 6:31 AM, Gagandeep Singh wrote:
> >
> >
> >> -Original Message-
> >> From: Fer
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, October 22, 2019 2:30 PM
> To: Gagandeep Singh ; dev@dpdk.org
> Subject: Re: [PATCH v4 2/3] net/enetc: set random MAC in case no MAC for SI
>
> On 10/22/2019 6:31 AM, Gagandeep Singh wrote:
> >
> > <...>
> >>>
> >>> include $(R
Clarify constraints on fields specified in bits for wireless
algorithms in digest-encrypted case.
Signed-off-by: Fiona Trahe
---
lib/librte_cryptodev/rte_crypto_sym.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
b/lib/librt
Hi Ori,
see my notes below.
A generic note is that we have strict policy about Rx/Tx (not RX/TX) in
commit messages, but I'd like to follow it in comments and log messages
at least in a new code. It is already a mixture in the existing code.
On 10/17/19 6:32 PM, Ori Kam wrote:
This commit intr
Hi Fiona,
>
> Clarify constraints on fields specified in bits for wireless
> algorithms in digest-encrypted case.
>
> Signed-off-by: Fiona Trahe
> ---
> lib/librte_cryptodev/rte_crypto_sym.h |7 +++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/lib/librte_cryptod
This patch adds an option to enable link time optimization. In addition
to LTO option itself (-flto) fat-lto-objects are being used. This is
because during the build pmdinfogen scans the generated ELF objects to
find this_pmd_name* symbol in symbol table. Without fat-lto-objects gcc
produces ELF
This patch series adds an option to make use of link time optimization
(if compiler has support for it). It is split as follows:
- 1st patch (build) is the enablement
- remaining patches are fixes for the warnings produced by the compiler
and they are split by directory/subsystem so their mainta
Fix the logic for the case of event queue allowing all schedule types.
Compiler warning pointing to this error (with LTO enabled):
error: ‘sched_type’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
if ((ret < 0 && ret != -EOVERFLOW) ||
Fixes: 6750b21bd6af ("eventdev: a
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘service_id’ may be used uninitialized in this function
[-Werror=maybe-uninitia
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘chunk’ may be used uninitialized in this function
[-Werror=maybe-uninitialized
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘stats.greatest_free_size’ may be used uninitialized in this
function [-Werror=
This patch fixes 'maybe-uninitialized' warnings reported by compiler
when using LTO.
Compiler warning pointing to this error (with LTO enabled):
error: ‘kg_cfg.extracts[0].masks[0].mask’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
extr->masks[j].mask = cfg->extract
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘link’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘filter_idx’ may be used uninitialized in this function
[-Werror=maybe-uninitia
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘transceiver_type’ may be used uninitialized in this function
[-Werror=maybe-un
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘features’ may be used uninitialized in this function
[-Werror=maybe-uninitiali
Hi Akhil,
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, October 22, 2019 12:49 PM
> To: Trahe, Fiona ; dev@dpdk.org
> Cc: Kusztal, ArkadiuszX ; Dybkowski, AdamX
>
> Subject: RE: [PATCH] cryptodev: clarify wireless inputs in digest-encrypted
> case
>
> Hi Akhil,
>
> >
> > Hi Fiona,
> >
> > >
> > > Clarify constraints on fields specified in bits for wireless
> > > algorithms in digest-encrypted case.
> > >
> > > Signed-off-by: Fiona Trahe
> > > ---
> > > lib/librte_cryptodev/rte_crypto_sym.h |7 +++
> > > 1 files changed, 7 inse
Ubuntu ships with a patched version of doxygen that enables
HAVE_DOT. Enabling this option causes the warning:
"""
warning: Included by graph for 'rte_common.h' not generated,
too many nodes. Consider increasing DOT_GRAPH_MAX_NODES
"""
This reproduces with doxygen version 1.8.13 and
dot - graphviz
Hi Vasmi,
On 10/21/19 5:38 PM, Vamsi Krishna Attunuru wrote:
Hi Olivier, Andrew,
+#define OPT_LEGACY_KNI "legacy-kni"
+ OPT_LEGACY_KNI_NUM,
OPT_LONG_MAX_NUM
};
Two concerns,
1- "legacy-kni" doesn't have enough context
2- I prefer to keep existing behavior default, at le
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, October 22, 2019 1:08 PM
> To: Trahe, Fiona ; dev@dpdk.org
> Cc: Kusztal, ArkadiuszX ; Dybkowski, AdamX
>
> Subject: RE: [PATCH] cryptodev: clarify wireless inputs in digest-encrypted
> cases
>
>
>
On Tue, Oct 22, 2019 at 01:54:02PM +0200, Andrzej Ostruszka wrote:
> This patch series adds an option to make use of link time optimization
> (if compiler has support for it). It is split as follows:
> - 1st patch (build) is the enablement
> - remaining patches are fixes for the warnings produced
On Tue, Oct 22, 2019 at 01:54:03PM +0200, Andrzej Ostruszka wrote:
> This patch adds an option to enable link time optimization. In addition
> to LTO option itself (-flto) fat-lto-objects are being used. This is
> because during the build pmdinfogen scans the generated ELF objects to
> find this_
On 10/18/19 7:35 PM, Ferruh Yigit wrote:
On 10/2/2019 2:58 PM, Thomas Monjalon wrote:
24/09/2019 14:03, Matan Azrad:
From: Ferruh Yigit
On 9/15/2019 8:48 AM, Matan Azrad wrote:
Hi Ferruh
From: Ferruh Yigit
On 8/29/2019 8:47 AM, Matan Azrad wrote:
It may be needed by the user to limit the
On 10/22/19 2:48 PM, Bruce Richardson wrote:
> On Tue, Oct 22, 2019 at 01:54:02PM +0200, Andrzej Ostruszka wrote:
>> This patch series adds an option to make use of link time optimization
[...]
> Does this have a dependency on set 6726 [1] ?
[...]
> [1] http://patches.dpdk.org/project/dpdk/list/?se
On Mon, Oct 14, 2019 at 11:03:50AM +0100, Ferruh Yigit wrote:
> Fixes: 70febdcfd60f ("examples: check status of getting MAC address")
>
> Signed-off-by: Ferruh Yigit
> ---
> Cc: Igor Romanov
> Cc: Andrew Rybchenko
> ---
> examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 8 +---
>
Clarify constraints on fields specified in bits for wireless
algorithms in digest-encrypted case.
v2 changes:
- added note on each of the affected parameter fields
Signed-off-by: Fiona Trahe
---
lib/librte_cryptodev/rte_crypto_sym.h | 23 +++
1 files changed, 19 insertion
>
> Clarify constraints on fields specified in bits for wireless
> algorithms in digest-encrypted case.
>
> v2 changes:
> - added note on each of the affected parameter fields
>
> Signed-off-by: Fiona Trahe
> ---
> lib/librte_cryptodev/rte_crypto_sym.h | 23 +++
> 1 f
Hi,
> -Original Message-
> From: dev On Behalf Of Matan Azrad
> Sent: Tuesday, October 22, 2019 10:34 AM
> To: dev@dpdk.org
> Cc: Slava Ovsiienko ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix DevX event registration timing
>
> The DevX counter management triggers an async
Hi Konstantin,
>
>
> Hi Akhil,
>
>
> > Added my comments inline with your draft.
> > [snip]..
> >
> > >
> > > Ok, then my suggestion:
> > > Let's at least write down all points about crypto-dev approach where we
> > > disagree and then probably try to resolve them one by one
> > > If we f
Hi Ferruh,
Can you please explain the problems in using kni dedicated mbuf alloc routines
while enabling kni iova=va mode. Please see the below discussion with Andrew.
He wanted to know the problems in having newer APIs.
I wanted to clarify ourselves about the need of mem pool patch(V11 1/4) an
This patch adds option to use asymmetric crypto pmd with
session-less support.
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/features/qat.ini | 1 +
doc/guides/rel_notes/release_19_11.rst | 4 +
drivers/crypto/qat/qat_asym.c | 328 -
drivers/c
This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
to Intel QuickAssist Technology PMD. It also adds session-less test cases
for those algorithms.
Test case for RSA signature with no padding will be sent in a later patch.
[1]crypto/qat: add sessionless implementation to asym
This commit adds rsa algorithm to asymmetric pmd
using pair (n, d) private key
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/features/qat.ini | 2 +
doc/guides/cryptodevs/qat.rst | 1 +
doc/guides/rel_notes/release_19_11.rst | 2 +
.../q
This commit adds asymmetric sessionless tests to mod exp.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 73 --
1 file changed, 49 insertions(+), 24 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.
This commit extends RSA implementation by CRT option
Signed-off-by: Arek Kusztal
---
doc/guides/cryptodevs/features/qat.ini | 1 +
doc/guides/rel_notes/release_19_11.rst | 2 +
.../qat/qat_adf/qat_pke_functionality_arrays.h | 9
drivers/crypto/qat/qat_asym.c
This commit adds RSA tests to Intel QuickAssist Technology pmd
and OpenSSL pmd test suite for session and session-less cases
when PADDING_NONE selected
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 140 --
app/test/test_cryptodev_rsa_test_vectors.h
On 10/22/2019 11:16 AM, Andrew Rybchenko wrote:
> Hi,
>
> @Pavan, see question below.
>
> On 10/21/19 6:34 PM, Ferruh Yigit wrote:
>> On 10/21/2019 4:19 PM, Pavan Nikhilesh Bhagavatula wrote:
>>> Hi Ferruh,
>>>
-Original Message-
From: Ferruh Yigit
Sent: Monday, October 21
AES-CMAC is used in 3gpp specifications hence it is needed
to support 4 byte digest.
Fixes: 91c1daa4e1f0 ("crypto/qat: support AES-CMAC")
Cc: sta...@dpdk.org
Signed-off-by: Arek Kusztal
---
drivers/crypto/qat/qat_sym_capabilities.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
On 10/19/2019 12:48 AM, Ye Xiaolong wrote:
> On 09/30, Ciara Loftus wrote:
>> This patch enables the unaligned chunks feature for AF_XDP which allows
>> chunks to be placed at arbitrary places in the umem, as opposed to them
>> being required to be aligned to 2k. This allows for DPDK application
>>
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, October 22, 2019 3:22 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal,
> ArkadiuszX
> ; sta...@dpdk.org
> Subject: [PATCH] crypto/qat: fix aes cmac mininum digest size
>
> AES-CMAC is used in 3gpp
> -Original Message-
> From: Akhil Goyal
> Sent: Tuesday, October 22, 2019 2:24 PM
> To: Trahe, Fiona ; dev@dpdk.org
> Cc: Kusztal, ArkadiuszX ; Dybkowski, AdamX
>
> Subject: RE: [PATCH v2] cryptodev: clarify wireless inputs in
> digest-encrypted cases
>
>
>
> >
> > Clarify constra
On Tue, Oct 22, 2019 at 11:56 AM Shahaf Shuler wrote:
>
> Thursday, October 17, 2019 8:19 PM, Jerin Jacob:
> > Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline
> > packet
> >
> > On Thu, Oct 17, 2019 at 4:30 PM Shahaf Shuler
> > wrote:
> > >
> > > Thursday, October 17, 2019
>-Original Message-
>From: Ferruh Yigit
>Sent: Tuesday, October 22, 2019 7:51 PM
>To: Andrew Rybchenko ; Pavan Nikhilesh
>Bhagavatula ; Jerin Jacob Kollanukkaran
>
>Cc: dev@dpdk.org; Adrien Mazarguil ;
>Thomas Monjalon ; Xiaolong Ye
>; Bruce Richardson
>
>Subject: Re: [dpdk-dev] [PATCH v12
Armv8's peripheral coherence order is a total order on all reads and
writes to that peripheral, that makes a compiler barrier is enough for
abstracted rte io barrier.
For virtual PCI devices, the virtual device memory is actually normal
memory and the Hypervisor view of things takes precedence and
Other than real PCI reads and writes to the device memory requiring
the io barriers, virtual pci memories are normal memory in the smp
configuration, which requires the smp barriers.
Since the smp barriers and io barriers are identical on x86 and PPC,
this change has only effect on aarch64.
As fa
Armv8's peripheral coherence order is a total order on all reads and writes
to that peripheral.[1]
The Peripheral coherence order for a Memory-mapped peripheral signifies the
order in which accesses arrive at the endpoint. For a read or a write RW1
and a read or a write RW2 to the same peripheral
Other than real PCI reads and writes to the device memory requiring
the io barriers, virtual pci memories are normal memory in the smp
configuration, and requires the smp barriers.
Since the smp barriers and io barriers are identical on x86 and PPC,
this change has only effect on aarch64.
As far
When build with meson, some examples were skipped when "-Dexamples=all"
parameter was passed. Ignoring examples slated for removal by other
patches[1], this set adds support for building the rest of the examples.
The only exception is "bpf" which is a set of code snippets rather than
code to be nat
The examples/bpf directory does not contain an example app, but rather
example code for use with testpmd's BPF support. Therefore, we should not
attempt to build it when the user requests "examples=all". This also
synchronises the meson behaviour with make which similarly doesn't compile
up the cod
Since the code for the ethtool example was contained in subdirectories the
compilation of this example is different from most of the other apps, and
it had not been abled when the user requests a build with "-Dexamples=all".
To simplify the build with meson, the separate ethtool library is not bui
The warnings about functions not returning values can be removed from the
code by just adding an attribute to the function to specifies it doesn't
return. The GCC bug referenced in the makefile which prevents this from
working has been fixed for >10 years according to bugzilla.
Signed-off-by: Bruc
When adding to the build, add in two missing includes that prevented build
on freebsd, rather than just duplicating the makefile restriction.
Signed-off-by: Bruce Richardson
Acked-by: Luca Boccassi
---
V3: add in missing headers for build compilation
---
examples/meson.build
Limited to x86_64 systems, as it fails to compile on any others and is
disabled in the examples makefile for non-x86_64 systems.
Signed-off-by: Bruce Richardson
Acked-by: Luca Boccassi
---
examples/meson.build | 3 ++-
.../l3fwd-thread/meson.build | 27
1 - 100 of 176 matches
Mail list logo
