[dpdk-dev] [PATCH] net/iavf: enable AVX2 for iavf

2019-09-04 Thread Leyi Rong
This patch enables AVX data path for iavf PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/Makefile | 21 + drivers/net/iavf/iavf_rxtx.c| 62 +- drivers/net/iavf/iavf_rxtx.h| 10 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 867

Re: [dpdk-dev] [EXT] [PATCH] security: update doxygen fields

2019-09-04 Thread Thomas Monjalon
04/09/2019 05:41, Anoob Joseph: > Hi Radu, > > Most parts of the file(rte_security.h) follows 'description after item' > methodology. Do you think we should stick to that? > > @Akhil, @Thomas, what is the recommended way of documenting individual > members of structure? Is it 'description after

Re: [dpdk-dev] [PATCH 0/2] i40e neon vPMD optiomization for aarch64

2019-09-04 Thread Ferruh Yigit
On 8/13/2019 11:43 AM, Gavin Hu wrote: > Aarch64 neon vPMD survives across discontinuous DD bits, which makes > the ordering for descriptors loading unnecessary. > Similarly, the compiler barrier to order the extraction of packet > length is not needed any more when the extraction was simplified >

[dpdk-dev] [PATCH 2/2] net/octeontx2: add ptype translation for ICMP6

2019-09-04 Thread Nithin Dabilpuram
Update ptype translation logic with ICMP6 in both outer and inner layers. Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_lookup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c index 13c26a9..fd0bc

[dpdk-dev] [PATCH 1/2] net/octeontx2: fix ptype translation logic

2019-09-04 Thread Nithin Dabilpuram
Extract and use layer type LB..LE for non-tunnel ptype and LF..LH as tunnel ptype translation. Fixes: 6e892eabce11 ("net/octeontx2: support packet type") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_lookup.c | 22 -- drivers/net/octeont

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: remove IP checksum from Tx/Rx offload capa

2019-09-04 Thread Ferruh Yigit
On 8/19/2019 10:56 PM, Louis Luo wrote: > Hi Maxime, > > Thanks for the fix. Actually Yong and I had some discussion about removing TX > IP CSUM offload flag last August and I did prepare a fix but later forgot to > submit. Anyway your fix is fine. > > Thanks, > Louis > > On 8/13/19, 6:30 AM,

Re: [dpdk-dev] [RFC] ethdev: configure SR-IOV VF from host

2019-09-04 Thread Thomas Monjalon
29/08/2019 17:02, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > In a virtual environment, the network controller may have to configure some > > SR-IOV VF parameters for security reasons. > > > > When the PF (host port) is drived by DPDK (OVS-DPDK

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 01/54] ethdev: remove redundunt device info cleanup before get

2019-09-04 Thread Ferruh Yigit
On 9/3/2019 2:56 PM, Andrew Rybchenko wrote: > rte_eth_dev_info_get() always fills in device information memory > with zeros on entry. > > Fixes: b6719879855d ("ethdev: avoid getting uninitialized info for bad port") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh

Re: [dpdk-dev] [PATCH v2 47/54] examples/ipsec-secgw: check status of getting ethdev info

2019-09-04 Thread Akhil Goyal
> > rte_eth_dev_info_get() return value was changed from void to > int, so this patch modify rte_eth_dev_info_get() usage across > examples/ipsec-secgw according to its new return type. > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > --- Acked-by: Akhil Goyal

[dpdk-dev] [PATCH] net/ixgbe: fix Vf Rss offloads configuration

2019-09-04 Thread Wei Zhao
x550 NIC Vf port has the capacity to set Rss hash, so device info get function should report that. Cc: sta...@dpdk.org Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) di

Re: [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking

2019-09-04 Thread Christian Ehrhardt
On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt wrote: > > On Thu, Aug 29, 2019 at 6:02 PM Luca Boccassi wrote: > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote: > > > On Thu, Aug 29, 2019 at 05:30:03PM +0200, Christian Ehrhardt wrote: > > > > A while ago telemetry was added in

[dpdk-dev] [PATCH] net/mlx5: retry when link update fails

2019-09-04 Thread Moti Haimovsky
mlx5_link_update immediately returns when called with no-wait parameter and its call for retrieving the link status returns with EAGAIN error. This is too harsh on busy systems where a first call fails with EAGAIN from time to time. This patch adds a (very limited) retry on such cases in order to a

Re: [dpdk-dev] [PATCH v2] build: avoid --as-needed as it causes overlinking

2019-09-04 Thread Bruce Richardson
On Wed, Sep 04, 2019 at 11:13:34AM +0200, Christian Ehrhardt wrote: > On Mon, Sep 2, 2019 at 9:09 AM Christian Ehrhardt > wrote: > > > > On Thu, Aug 29, 2019 at 6:02 PM Luca Boccassi wrote: > > > > > > On Thu, 2019-08-29 at 16:34 +0100, Bruce Richardson wrote: > > > > On Thu, Aug 29, 2019 at 05:3

Re: [dpdk-dev] [PATCH] security: update doxygen fields

2019-09-04 Thread Akhil Goyal
> > Replace /**< with /** for multiline doxygen comments. > > Signed-off-by: Radu Nicolau This is a bug in the doxygen build, better to have a fixes line here and cc to stable. Acked-by: Akhil Goyal

[dpdk-dev] [dpdk-announce] Elixir Cross-Referencer now available for dpdk

2019-09-04 Thread Ali Alnubani
Hi, DPDK.org now hosts an instance of Elixir (a source code cross-referencer), available at http://code.dpdk.org. Available repositories: http://code.dpdk.org/dpdk/latest/source http://code.dpdk.org/dpdk-stable/latest/source http://code.dpdk.org/dpdk-burst-replay/latest/source http://code.dpdk.o

Re: [dpdk-dev] [PATCH v3] security: add statistics definitions and update API

2019-09-04 Thread Akhil Goyal
> > Update IPsec statistics struct definition, add per SA > statistics collection enable flag. > > Signed-off-by: Radu Nicolau > --- > v2: added second reserved field > v3: update doc > Acked-by: Akhil Goyal

Re: [dpdk-dev] [EXT] [PATCH] security: update doxygen fields

2019-09-04 Thread Akhil Goyal
> > Hi Radu, > > Most parts of the file(rte_security.h) follows 'description after item' > methodology. Do you think we should stick to that? > > @Akhil, @Thomas, what is the recommended way of documenting individual > members of structure? Is it 'description after the item' or 'description > b

Re: [dpdk-dev] [EXT] [PATCH] security: update doxygen fields

2019-09-04 Thread Anoob Joseph
> -Original Message- > From: Radu Nicolau > Sent: Tuesday, September 3, 2019 6:28 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; konstantin.anan...@intel.com; > bernard.iremon...@intel.com; declan.dohe...@intel.com; > step...@networkplumber.org; Anoob Joseph ; > Radu Nicolau > Subject:

Re: [dpdk-dev] [EXT] [PATCH v3] security: add statistics definitions and update API

2019-09-04 Thread Anoob Joseph
> -Original Message- > From: Radu Nicolau > Sent: Tuesday, September 3, 2019 6:36 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; konstantin.anan...@intel.com; > bernard.iremon...@intel.com; declan.dohe...@intel.com; > step...@networkplumber.org; Anoob Joseph ; > Radu Nicolau > Subject:

Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest failing

2019-09-04 Thread Van Haaren, Harry
> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Tuesday, September 3, 2019 3:46 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: [BUG] service_lcore_en_dis_able from service_autotest failing > > Hi Harry, Hey Aaron, > I noticed as part of series_621

Re: [dpdk-dev] [PATCH 04/12] examples/fips: fix bad return code in fips_test_parse_header()

2019-09-04 Thread Akhil Goyal
Hi Michael, Title should be " examples/fips_validation: fix bad return value " > > Returning correct error value by fips_test_parse_header() > allows graceful exit of fips application. Please add a fixes line here and cc stable. It would be good if you can separate out the fixes from this patc

[dpdk-dev] [PATCH v4] net/ixgbe: fix Rx/Tx queue interrupt for X552/557 device

2019-09-04 Thread Jiang JunyuX
Interrupt mode is not working on X552/557 device because this device doesn't enable the queue interrupt mapping, this patch fixed the issue. Fixes: d2e72774e58c ("ixgbe/base: support X550") Cc: sta...@dpdk.org Signed-off-by: Jiang JunyuX --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++- 1 file cha

Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest failing

2019-09-04 Thread David Marchand
On Tue, Sep 3, 2019 at 4:46 PM Aaron Conole wrote: > > Hi Harry, > > I noticed as part of series_6218 > (http://patches.dpdk.org/project/dpdk/list/?series=6218) that the travis > build had a single failure, in service_autotest but it doesn't seem > related to the series at all. > > https://travi

Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest failing

2019-09-04 Thread David Marchand
On Wed, Sep 4, 2019 at 11:42 AM Van Haaren, Harry wrote: > > > -Original Message- > > From: Aaron Conole [mailto:acon...@redhat.com] > > Sent: Tuesday, September 3, 2019 3:46 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: [BUG] service_lcore_en_dis_able from service_autote

[dpdk-dev] [PATCH] net/iavf: enable AVX2 for iavf

2019-09-04 Thread Leyi Rong
This patch enables AVX data path for iavf PMD. Signed-off-by: Leyi Rong --- drivers/net/iavf/Makefile | 21 + drivers/net/iavf/iavf_rxtx.c| 62 +- drivers/net/iavf/iavf_rxtx.h| 10 + drivers/net/iavf/iavf_rxtx_vec_avx2.c | 867

Re: [dpdk-dev] [PATCH 00/12] FIPS improvements

2019-09-04 Thread Akhil Goyal
Hi Michael, Please try to improve descriptions and patch titles as per the suggestions given below. There are many patches which are fixes. Are the eligible for backport to stable branches? The support which is getting added, is it eligible for documentation update for the application. -Akhil

Re: [dpdk-dev] [PATCH] net/af_xdp: enable support for unaligned umem chunks

2019-09-04 Thread Loftus, Ciara
> > Hi, Ciara > > Thanks for the patch, the performance number is quite impressive. > > On 08/29, Ciara Loftus wrote: > >This patch enables the unaligned chunks feature for AF_XDP which allows > >chunks to be placed at arbitrary places in the umem, as opposed to them > >being required to be alig

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-04 Thread Akhil Goyal
Hi Fan, > > This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action > type to > security library. The type represents performing crypto operation with CPU > cycles. The patch also includes a new API to process crypto operations in > bulk and the function pointers for PMDs. > I am not

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix access to freed packet

2019-09-04 Thread Akhil Goyal
> > For unknown/unsupported packets, the packet would get checked for inline > offloads after the packet is freed. > > Fixes: 0ccfd14bc10d ("examples/ipsec-secgw: support inline protocol") > > Signed-off-by: Anoob Joseph > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest failing

2019-09-04 Thread David Marchand
On Wed, Sep 4, 2019 at 12:04 PM David Marchand wrote: > > On Wed, Sep 4, 2019 at 11:42 AM Van Haaren, Harry > wrote: > > > > > -Original Message- > > > From: Aaron Conole [mailto:acon...@redhat.com] > > > Sent: Tuesday, September 3, 2019 3:46 PM > > > To: Van Haaren, Harry > > > Cc: dev@

Re: [dpdk-dev] [PATCH 11/11] doc: add documentation for OCTEON TX2 crypto PMD

2019-09-04 Thread Jerin Jacob Kollanukkaran
> > -Original Message- > > From: Jerin Jacob Kollanukkaran > > Sent: Tuesday, September 3, 2019 10:52 AM > > To: Anoob Joseph ; Akhil Goyal > > ; Pablo de Lara ; > > Thomas Monjalon > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > > ; Ankur Dwivedi ; Tejasree > > Kondoj ; dev@dpdk.or

[dpdk-dev] [PATCH v2] security: update doxygen fields

2019-09-04 Thread Radu Nicolau
Replace /**< with /** for multiline doxygen comments. Fixes: c261d1431bd8 ("security: introduce security API and framework") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal Acked-by: Anoob Joseph --- v2: add fixes line and CC'ed stable lib/librte_security/rte_security.h

Re: [dpdk-dev] [PATCH 11/11] doc: add documentation for OCTEON TX2 crypto PMD

2019-09-04 Thread Anoob Joseph
Hi Thomas, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Tuesday, September 3, 2019 11:12 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > > Cc: Akhil Goyal ; Pablo de Lara > ; Narayana Prasad Raju Athreya > ; Ankur Dwivedi ;

[dpdk-dev] [PATCH 2/2] net/qede: implement rte_flow drop action

2019-09-04 Thread Shahed Shaikh
Add support to configure drop action in RTE_FLOW infrastructure. Also, add statistics counter for dropped packets due to this filter action "rx_gft_filter_drop" Signed-off-by: Shahed Shaikh --- drivers/net/qede/base/ecore_dev_api.h | 1 + drivers/net/qede/base/ecore_l2.c | 50 +

[dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-04 Thread Shahed Shaikh
As per HW design of 100Gb mode, device internally uses 2 engines (eng0 and eng1), and both engines need to be configured symmetrically. Based on this requirement, driver design chose an approach to allow user to allocate only even number of queues and split those queues on both engines equally. Th

[dpdk-dev] [PATCH v4 0/4] add unit tests for eal vfio library

2019-09-04 Thread Chaitanya Babu Talluri
1/4: fix vfio unmap that fails unexpectedly 2/4: fix vfio unmap that succeeds unexpectedly 3/4: add API to check iommu type is set 4/4: add unit tests for eal vfio Patch 4/4 depends on 1/4,2/4,3/4 Signed-off-by: Chaitanya Babu Talluri --- v4: Fixed compilation issues. v3: Added API to check iomm

[dpdk-dev] [PATCH v4 1/4] lib/eal: fix vfio unmap that fails unexpectedly

2019-09-04 Thread Chaitanya Babu Talluri
Unmap fails when there are duplicate entries in user_mem_maps. The fix is to validate if the input VA, IOVA exists or overlaps in user_mem_maps before creating map. Fixes: 73a63908 ("vfio: allow to map other memory regions") Cc: sta...@dpdk.org Signed-off-by: Chaitanya Babu Talluri --- lib/lib

[dpdk-dev] [PATCH v4 3/4] lib/eal: add API to check iommu type is set

2019-09-04 Thread Chaitanya Babu Talluri
Add rte_vfio_iommu_type_is_set() to check IOMMU type for default container. Signed-off-by: Chaitanya Babu Talluri --- lib/librte_eal/common/include/rte_vfio.h | 11 +++ lib/librte_eal/linux/eal/eal_vfio.c | 16 lib/librte_eal/rte_eal_version.map | 3 +++ 3 fi

[dpdk-dev] [PATCH v4 2/4] lib/eal: fix vfio unmap that succeeds unexpectedly

2019-09-04 Thread Chaitanya Babu Talluri
Unmapping page with a VA that is found in the list of current mappings will succeed even if the IOVA for the chunk that is being unmapped,is mismatched. Fix it by checking if IOVA address matches the expected IOVA address exactly. Fixes: 73a6390859 ("vfio: allow to map other memory regions") Cc:

[dpdk-dev] [PATCH v4 4/4] app/test: add unit tests for eal vfio

2019-09-04 Thread Chaitanya Babu Talluri
Unit test cases are added for eal vfio library. eal_vfio_autotest added to meson build file. Signed-off-by: Chaitanya Babu Talluri --- app/test/Makefile| 1 + app/test/meson.build | 2 + app/test/test_eal_vfio.c | 737 +++ 3 files changed, 740

Re: [dpdk-dev] [v8] net/e1000: fix i219 hang on reset/close

2019-09-04 Thread Kevin Traynor
On 22/07/2019 16:11, Xiao Zhang wrote: > Unit hang may occur if multiple descriptors are available in the rings > during reset or close. This state can be detected by configure status > by bit 8 in register. If the bit is set and there are pending > descriptors in one of the rings, we must flush th

[dpdk-dev] [Bug 343] Couldn't receive LACP PDU when enable dedicated queue

2019-09-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=343 Bug ID: 343 Summary: Couldn't receive LACP PDU when enable dedicated queue Product: DPDK Version: 17.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 1/4] net/ice: add devargs to control pipeline mode

2019-09-04 Thread Ye Xiaolong
On 09/04, Ying Wang wrote: >From: Qiming Yang > >Added a devarg to control the mode in generic flow API. >We use none-pipeline mode by default. > >Signed-off-by: Qiming Yang >--- > doc/guides/nics/ice.rst | 11 +++ > drivers/net/ice/ice_ethdev.c | 16 +++- > drivers/net/ice

[dpdk-dev] [Bug 344] Broken CPU feature discovery for armv8

2019-09-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=344 Bug ID: 344 Summary: Broken CPU feature discovery for armv8 Product: DPDK Version: unspecified Hardware: ARM OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-04 Thread Zhang, Roy Fan
Hi Akhil, This action type allows the burst of symmetric crypto workload using the same algorithm, key, and direction being processed by CPU cycles synchronously. This flexible action type does not require external hardware involvement, having the crypto workload processed synchronously, and is m

Re: [dpdk-dev] [PATCH v2 00/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-04 Thread Aaron Conole
Thomas Monjalon writes: > 03/09/2019 22:06, Aaron Conole: >> Andrew Rybchenko writes: >> > On September 3, 2019 21:14:58 Aaron Conole wrote: >> >> Some errors with the series: >> >> >> >> https://travis-ci.com/ovsrobot/dpdk/builds/125755853 >> > >> > I guess it was applied to dpdk main repo,

Re: [dpdk-dev] [PATCH 2/2] net/qede: implement rte_flow drop action

2019-09-04 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Shahed Shaikh > Sent: Wednesday, September 4, 2019 5:01 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yi...@intel.com; GR- > Everest-DPDK-Dev > Subject: [dpdk-dev] [PATCH 2/2] net/qede: implement rte_flow drop action > > Add support to con

Re: [dpdk-dev] [PATCH] net/iavf: enable AVX2 for iavf

2019-09-04 Thread Aaron Conole
Leyi Rong writes: > This patch enables AVX data path for iavf PMD. > > Signed-off-by: Leyi Rong > --- > drivers/net/iavf/Makefile | 21 + > drivers/net/iavf/iavf_rxtx.c| 62 +- > drivers/net/iavf/iavf_rxtx.h| 10 + > drivers/net/iavf/iavf_rxtx_vec_avx2.c

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-04 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Shahed Shaikh > Sent: Wednesday, September 4, 2019 5:01 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yi...@intel.com; GR- > Everest-DPDK-Dev ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using > odd

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing ptype for IP-in-IP

2019-09-04 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Thursday, August 8, 2019 14:39 > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix missing ptype for IP-in-IP > > The hw ptype information is missed for IP-in-IP tunnel. > It should be

[dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA affinity

2019-09-04 Thread Xiao Wang
It's better to allocate device private data on the same NUMA node with device, rather than with the main thread. This helps avoid cross-NUMA access for worker thread. Signed-off-by: Xiao Wang --- drivers/crypto/virtio/virtio_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH] net/mlx5: fix typo in error message

2019-09-04 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Tuesday, August 20, 2019 9:21 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix typo in error message > > This patch fixes a typing mistake in an error mes

[dpdk-dev] [PATCH] ethdev: fix typos for ENOTSUP

2019-09-04 Thread Xiaolong Ye
Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Xiaolong Ye --- lib/librte_ethdev/rte_ethdev.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index dc6596bc9..51e2caf79 10

Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of jump action

2019-09-04 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Thursday, August 15, 2019 12:27 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix validation of jump action > > This patch updates the validation function

Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of drop action

2019-09-04 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Thursday, August 15, 2019 12:27 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix validation of drop action > > Function mlx5_flow_validate_action_drop() c

Re: [dpdk-dev] [PATCH] net/mlx5: fix location of comment line

2019-09-04 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Tuesday, August 13, 2019 17:07 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix location of comment line > > In struct mlx5_ibv_shared, member esw_drop_ac

[dpdk-dev] [PATCH v2 1/3] examples/ipsec-secgw: ipsec_sa structure cleanup

2019-09-04 Thread Marcin Smoczynski
Cleanup ipsec_sa structure by removing every field that is already in the rte_ipsec_session structure: * cryptodev/security session union * action type * offload flags * security context References to abovementioned fields are changed to direct references to matching fields of rte_ipsec_session

[dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: add fallback session

2019-09-04 Thread Marcin Smoczynski
Inline processing is limited to a specified subset of traffic. It is often unable to handle more complicated situations, such as fragmented traffic. When using inline processing such traffic is dropped. Introduce multiple sessions per SA allowing to configure a fallback lookaside session for packe

[dpdk-dev] [PATCH v2 2/3] examples/ipsec-secgw: add fallback session feature

2019-09-04 Thread Marcin Smoczynski
Inline processing is limited to a specified subset of traffic. It is often unable to handle more complicated situations, such as fragmented traffic. When using inline processing such traffic is dropped. Introduce multiple sessions per SA allowing to configure a fallback lookaside session for packe

[dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: add offload fallback tests

2019-09-04 Thread Marcin Smoczynski
Add tests for offload fallback feature; add inbound config modificator SGW_CFG_XPRM_IN (offload fallback setting can be set only for inbound SAs). Tests are using cryptodev for outbound SA. To test fragmentation with QAT set: MULTI_SEG_TEST="--reassemble=4096 --cryptodev_mask=0x" Signed-off-b

Re: [dpdk-dev] [PATCH] net/mlx5: support adding a new UDP tunnel

2019-09-04 Thread Slava Ovsiienko
> -Original Message- > From: Raslan Darawsheh > Sent: Thursday, August 22, 2019 13:16 > To: Slava Ovsiienko ; mat...@mellanox.com > Cc: Asaf Penso ; dev@dpdk.org > Subject: [PATCH] net/mlx5: support adding a new UDP tunnel > > This adds support for adding a new udp tunnel port on a specif

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-04 Thread Ye Xiaolong
On 09/04, Ying Wang wrote: >The patch reworks the generic flow API (rte_flow) implementation. >It introduces an abstract layer which provides a unified interface >for low-level filter engine (switch, fdir, hash) to register supported >patterns and actions and implement flow validate/create/destroy/

Re: [dpdk-dev] [PATCH] ethdev: fix typos for ENOTSUP

2019-09-04 Thread Stephen Hemminger
On Wed, 4 Sep 2019 22:05:31 +0800 Xiaolong Ye wrote: > Fixes: af75078fece3 ("first public release") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaolong Ye > --- > lib/librte_ethdev/rte_ethdev.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_ethdev/r

[dpdk-dev] [PATCH] net/af_xdp: support pinning of IRQs

2019-09-04 Thread Ciara Loftus
Network devices using the AF_XDP PMD will trigger interrupts on reception of packets. The new PMD argument 'queue_irq' allows the user to specify a core on which to pin interrupts for a given queue. Multiple queue_irq arguments can be specified. For example: --vdev=net_af_xdp1,iface=eth0,queue_c

Re: [dpdk-dev] [PATCH v2 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-04 Thread Ferruh Yigit
On 9/3/2019 2:56 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Change rte_eth_dev_info_get() return value from void to int and return > negative errno values in case of error conditions. > Modify rte_eth_dev_info_get() usage across the ethdev according > to new return type. > > Signed-of

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight

2019-09-04 Thread Kevin Traynor
On 06/08/2019 14:26, Thomas Monjalon wrote: > 06/08/2019 13:49, Jasvinder Singh: >> The sched library checks the subport tc ov weight value regardless >> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not. >> >> This fix allows application to always set valid tc ov weight value. >> >> Fixes:

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-04 Thread Thomas Monjalon
03/09/2019 10:47, Ferruh Yigit: > On 9/3/2019 9:06 AM, David Marchand wrote: > > On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: > >> On 8/19/2019 12:41 PM, David Marchand wrote: > >>> The function rte_log_register_type_and_pick_level() fills a gap for > >>> dynamically loaded code (especially

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-04 Thread Shahed Shaikh
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, September 4, 2019 7:01 PM > To: Shahed Shaikh ; dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yi...@intel.com; GR-Everest- > DPDK-Dev ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure w

Re: [dpdk-dev] [PATCH 1/4] net/ice: add devargs to control pipeline mode

2019-09-04 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev On Behalf Of Ying Wang > Sent: Tuesday, September 3, 2019 3:15 PM > To: Zhang, Qi Z > Cc: Ye, Xiaolong ; Yang, Qiming > ; dev@dpdk.org; Wang, Ying A > ; Zhao1, Wei > Subject: [dpdk-dev] [PATCH 1/4] net/ice: add devargs to control pipeline > mode > > From

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-04 Thread Andrew Rybchenko
On 9/4/19 8:45 PM, Thomas Monjalon wrote: 03/09/2019 10:47, Ferruh Yigit: On 9/3/2019 9:06 AM, David Marchand wrote: On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: On 8/19/2019 12:41 PM, David Marchand wrote: The function rte_log_register_type_and_pick_level() fills a gap for dynamically

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-04 Thread Thomas Monjalon
04/09/2019 21:21, Andrew Rybchenko: > On 9/4/19 8:45 PM, Thomas Monjalon wrote: > > 03/09/2019 10:47, Ferruh Yigit: > >> On 9/3/2019 9:06 AM, David Marchand wrote: > >>> On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit > >>> wrote: > On 8/19/2019 12:41 PM, David Marchand wrote: > > The functi

Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest failing

2019-09-04 Thread Aaron Conole
David Marchand writes: > On Wed, Sep 4, 2019 at 12:04 PM David Marchand > wrote: >> >> On Wed, Sep 4, 2019 at 11:42 AM Van Haaren, Harry >> wrote: >> > >> > > -Original Message- >> > > From: Aaron Conole [mailto:acon...@redhat.com] >> > > Sent: Tuesday, September 3, 2019 3:46 PM >> > >

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-04 Thread Andrew Rybchenko
On September 4, 2019 22:42:12 Thomas Monjalon wrote: 04/09/2019 21:21, Andrew Rybchenko: On 9/4/19 8:45 PM, Thomas Monjalon wrote: 03/09/2019 10:47, Ferruh Yigit: On 9/3/2019 9:06 AM, David Marchand wrote: On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: On 8/19/2019 12:41 PM, David Mar

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-04 Thread Thomas Monjalon
04/09/2019 21:58, Andrew Rybchenko: > On September 4, 2019 22:42:12 Thomas Monjalon wrote: > > > 04/09/2019 21:21, Andrew Rybchenko: > >> On 9/4/19 8:45 PM, Thomas Monjalon wrote: > >>> 03/09/2019 10:47, Ferruh Yigit: > On 9/3/2019 9:06 AM, David Marchand wrote: > > On Mon, Sep 2, 2019 a

Re: [dpdk-dev] [v8] net/e1000: fix i219 hang on reset/close

2019-09-04 Thread Zhang, Xiao
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, September 4, 2019 8:23 PM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei ; > Ye, Xiaolong ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [v8] net/e1000: fix i219 hang on reset/close >

Re: [dpdk-dev] [PATCH 10/15] net/virtio: add vDPA op to configure and start the device

2019-09-04 Thread Tiwei Bie
On Wed, Sep 04, 2019 at 08:56:32AM +0200, Maxime Coquelin wrote: > On 9/4/19 6:06 AM, Jason Wang wrote: > > On 2019/9/3 下午4:49, Tiwei Bie wrote: > >> On Tue, Sep 03, 2019 at 09:40:25AM +0200, Maxime Coquelin wrote: > >>> On 9/3/19 7:30 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:55AM

[dpdk-dev] [PATCH v4 00/12] Add PCIe AER disable and IRQ support for ipn3ke

2019-09-04 Thread Andy Pei
This patch set adds PCIe AER disable and IRQ support for ipn3ke. Disable PCIe AER is very useful when FPGA reload. IRQ is used very widely in interrupt process. For ipn3ke is connect to CPU with PCIe switch, driver needs to scan all PCIe devices of ipn3ke, it also can get all i40e of card, so ipn3

[dpdk-dev] [PATCH v4 02/12] raw/ifpga/base: add irq support

2019-09-04 Thread Andy Pei
Add irq support for ifpga FME globle error, port error and uint unit. We implmented this feature by vfio interrupt mechanism. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_feature_dev.c | 61 ++ drivers/raw/ifpga/base/ifpga_fme

[dpdk-dev] [PATCH v4 06/12] raw/ifpga/base: align the send buffer for SPI

2019-09-04 Thread Andy Pei
The length of send buffer of SPI bus should be 4bytes align. Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_spi_transaction.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/raw/ifpga/base/opae_spi_tr

[dpdk-dev] [PATCH v4 01/12] net/i40e: i40e support ipn3ke FPGA port bonding

2019-09-04 Thread Andy Pei
In ipn3ke, each FPGA network side port bonding to an i40e pf, each i40e pf link status should get data from FPGA network, side port. This patch provide bonding relationship. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/i40e/base/i40e_type.h | 3 +++ drivers/net/i40e/i40e_eth

[dpdk-dev] [PATCH v4 05/12] raw/ifpga/base: add device tree support

2019-09-04 Thread Andy Pei
In PAC N3000 card, this is a BMC chip which using MAX10 FPGA to manage the board configuration, like sensors, flash controller, QSFP, powers. And this is a SPI bus connected between A10 FPGA and MAX10, we can access the MAX10 registers over this SPI bus. In BMC, there are about 19 sensors in MAX10

[dpdk-dev] [PATCH v4 07/12] raw/ifpga/base: add sensor support

2019-09-04 Thread Andy Pei
The sensor devices are connected in MAX10 FPGA. we used the device tree to describe those sensor devices. Parse the device tree to get the sensor devices and add them into a list. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/opae_intel_max10.c | 279 ++

[dpdk-dev] [PATCH v4 04/12] raw/ifpga/base: add SEU error support

2019-09-04 Thread Andy Pei
This patch exposes SEU error information to application then application could compare this information (128bit) with its own SMH file to know if this SEU is a fatal error or not. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 5 +++- driv

[dpdk-dev] [PATCH v4 03/12] raw/ifpga/base: clear pending bit

2019-09-04 Thread Andy Pei
Every defined bit in FME_ERROR0 is RW1C. Other reserved bits are always 0 when readout and it will plan to be RW1C if needed in future. So it is safe just write the read back value to clear all the errors. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_def

[dpdk-dev] [PATCH v4 10/12] raw/ifpga: add SEU error handler

2019-09-04 Thread Andy Pei
Add SEU interrupt support for FPGA. Signed-off-by: Tianfei zhang Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 245 +++ 1 file changed, 245 insertions(+) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/if

[dpdk-dev] [PATCH v4 09/12] raw/ifpga/base: update SEU register definition

2019-09-04 Thread Andy Pei
Update the SEU registser definition. Signed-off-by: Tianfei zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga/base/ifpga_defines.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/base/ifpga_defines.h b/drivers/raw/ifpga/base/ifpga_defines.h index b450

[dpdk-dev] [PATCH v4 12/12] net/ipn3ke: remove configuration for i40e port bonding

2019-09-04 Thread Andy Pei
The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, so it doesn't need to provide configuration for i40e port bonding. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/net/ipn3ke/Makefile | 2 + drivers/net/ipn3ke/ipn3ke_ethdev.c | 289 --

[dpdk-dev] [PATCH v4 08/12] raw/ifpga/base: introducing sensor APIs

2019-09-04 Thread Andy Pei
Introducing sensor APIs to PMD driver for PAC N3000 card. Those sensor APIs: 1. opae_mgr_for_each_sensor() 2. opae_mgr_get_sensor_by_name() 3. opae_mgr_get_sensor_by_id() 4. opae_mgr_get_sensor_value_by_name() 5. opae_mgr_get_sensor_value_by_id() 6. opae_mgr_get_sensor_value() Signed-off-by: Tian

[dpdk-dev] [PATCH v4 11/12] raw/ifpga: add PCIe BDF devices tree scan

2019-09-04 Thread Andy Pei
Add PCIe BDF devices tree scan for ipn3ke. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/raw/ifpga/ifpga_rawdev.c | 546 ++- drivers/raw/ifpga/ifpga_rawdev.h | 16 ++ 2 files changed, 557 insertions(+), 5 deletions(-) diff --git a/drivers/raw/

[dpdk-dev] [PATCH v2 01/16] net/ice/base: remove redundant empty lines

2019-09-04 Thread Qi Zhang
Remove redundant empty lines Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h| 111 --- drivers/net/ice/base/ice_bitops.h| 2 - drivers/net/ice/base/ice_common.c| 25 --- drivers/net/ice/b

[dpdk-dev] [PATCH v2 00/16] net/ice/base: share code update secend batch.

2019-09-04 Thread Qi Zhang
The patchset depends on the first batch http://patchwork.dpdk.org/project/dpdk/list/?series=6158&state=* Key Features: 1) Add tunnel support for fdir 2) Add non-word aligned field support for fdir 3) Add dest mac field support for fdir 4) Add flow count support for fdir 5) Add queue region suppor

[dpdk-dev] [PATCH v2 02/16] net/ice/base: add support for tunnel packets

2019-09-04 Thread Qi Zhang
Add VXLAN tunnel training packets to flow director and change the interface to support tunnel packets. Signed-off-by: Henry Tieman Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 266 drivers/net/ice/base

[dpdk-dev] [PATCH v2 04/16] net/ice/base: add non-word aligned ipv6 field support

2019-09-04 Thread Qi Zhang
Add non-word aligned field support for IPv6 with hlim, tc and proto. All these fields are one byte within one word. In order to match bytes within the IPv6 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v2 05/16] net/ice/base: correct the mask for checking protocol header

2019-09-04 Thread Qi Zhang
Before this patch, the logic of protocol header checking only support non-tunneled packet. This patch remove the inner protocol in L3/L4 RSS seg hdr mask and change the protocol header validation to reflect this. So, for ice_add_rss_cfg(), the last parameter addl_hdrs could specify the protocol hea

[dpdk-dev] [PATCH v2 03/16] net/ice/base: add non-word aligned ip field support

2019-09-04 Thread Qi Zhang
Add non-word aligned field support for ipv4 with ttl, tos and proto. All these fields are one byte within one word. In order to match bytes within the IPv4 header for flow director we need to use a mask. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang ---

[dpdk-dev] [PATCH v2 08/16] net/ice/base: remove RSS code as iavf host

2019-09-04 Thread Qi Zhang
The DPDK PF doesn't support SRIOV so remove the related iavf host code. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 128 1 file changed, 128 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b

[dpdk-dev] [PATCH v2 06/16] net/ice/base: propagate errors from functions

2019-09-04 Thread Qi Zhang
There could be an error returned from ice_fill_adv_dummy_packet() so we need to propagate that to the caller. Additionally, the call to ice_flow_xtract_pkt_flags() could also return an error so we need to propagate it as well. Also add in the correct offsets for GENEVE and VXLAN_GPE to the dummy p

[dpdk-dev] [PATCH v2 07/16] net/ice/base: remove pointless NULL check of port info

2019-09-04 Thread Qi Zhang
The code in ice_sched_cleanup_all checks whether the port info is NULL prior to calling ice_sched_clear_port. More importantly, it also checks whether the port structure has been initialized by checking its port_state field as well. Signed-off-by: Jacob Keller Signed-off-by: Paul M Stillwell Jr

[dpdk-dev] [PATCH v2 09/16] net/ice/base: add support for switch rule about VLAN PPPoE

2019-09-04 Thread Qi Zhang
Add support for switch rule about single-VLAN-PPPoE. Note that double VLAN is not supported by the hardware at this point, therefore only single-VLAN support for PPPoE is added. Signed-off-by: Junfeng Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_p

[dpdk-dev] [PATCH v2 10/16] net/ice/base: minor structure refactor

2019-09-04 Thread Qi Zhang
When declaring the ice_prot_ext, and ice_prot_id_tbl structure, we can use a fixed length array instead of a variable length one which helps us catch future code changes that might desynchronize the enum ice_protocol_type and the structs. This change also necessitates removing the last member of t

  1   2   >