On 06/08/2019 14:26, Thomas Monjalon wrote: > 06/08/2019 13:49, Jasvinder Singh: >> The sched library checks the subport tc ov weight value regardless >> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not. >> >> This fix allows application to always set valid tc ov weight value. >> >> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object") >>
FYI, tc_ov_weight is not visible without the RTE_SCHED_SUBPORT_TC_OV until Fixes: ca4d5915b877 ("sched: add config flexibility to TC queue sizes") so this will not build on 18.11 stable. >> error log >> SCHED: pipe_profile_check: Incorrect value for tc ov weight >> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22) >> Command "tmgr" failed. >> >> Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com> >> Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com> >> --- >> v2: >> - add fix line >> - change title > > "tc ov" is not that obvious. > I changed the title to "examples/ip_pipeline: fix TC oversubscription weight" > > +Add Cc stable > > Applied, thanks > >