Re: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit

2019-07-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, July 18, 2019 10:42 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Jack Min ; Ori Kam ; > dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix define of added tunnel layer bit > > The ne

Re: [dpdk-dev] [PATCH] net/mlx5: fix setting of item flags bitmap

2019-07-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, July 18, 2019 10:42 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Jack Min ; Ori Kam ; > dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix setting of item flags bitmap > > In functio

Re: [dpdk-dev] [PATCH] net/mlx5: correct spelling mistakes in comments

2019-07-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, July 18, 2019 10:41 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: correct spelling mistakes in > comments >

Re: [dpdk-dev] [PATCH] net/mlx4: correct spelling mistake in comment

2019-07-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, July 18, 2019 10:37 PM > To: Matan Azrad ; Shahaf Shuler > > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx4: correct spelling mistake in comment > > A spelling mistake was found in comment

[dpdk-dev] [PATCH] net/mlx5: fix interrupt install

2019-07-21 Thread Matan Azrad
The error path of interrupt install was done in any way. Fix it to skip error path in case of success. Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query") Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install

2019-07-21 Thread Slava Ovsiienko
> -Original Message- > From: Matan Azrad > Sent: Sunday, July 21, 2019 11:17 > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix interrupt install > > The error path of interrupt install was done in any way. > Fix it to skip error pa

Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install

2019-07-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Sunday, July 21, 2019 11:17 AM > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install > > The error path of interrupt install was done i

Re: [dpdk-dev] [PATCH v9 07/11] app/testpmd: use new ethernet address parser

2019-07-21 Thread Raslan Darawsheh
Hi Guys, We have a failure in testpmd commands when parsing rte_flow commands as following which were interduce by this patch: This rule is a valid rule to be added to testpmd: flow validate 0 priority 2 ingress group 0 pattern eth dst is 98:03:9B:5C:D9:00 / end actions queue index 0 / end

[dpdk-dev] [PATCH v4 2/8] net/mlx5: add Tx datapath related devargs

2019-07-21 Thread Viacheslav Ovsiienko
This patch introduces new mlx5 PMD devarg options: - txq_inline_min - specifies minimal amount of data to be inlined into WQE during Tx operations. NICs may require this minimal data amount to operate correctly. The exact value may depend on NIC operation mode, requested offloads, etc. - tx

[dpdk-dev] [PATCH v4 1/8] net/mlx5: remove Tx datapath implementation

2019-07-21 Thread Viacheslav Ovsiienko
This patch removes the existing Tx datapath code as preparation step before introducing the new implementation. The following entities are being removed: - deprecated devargs support - tx_burst() routines - related PRM definitions - SQ configuration code - Tx routine selection code - incompatible

[dpdk-dev] [PATCH v4 0/8] net/mlx5: consolidate Tx datapath

2019-07-21 Thread Viacheslav Ovsiienko
This patchset introduces the new implementation of tx_burst routine of mlx5 PMD. The existing implementation is based on the several branches of tx_burst routines optimizied for most common sets of Tx hardware offload, supported by Mellanox NICs. It was not very easy to update, support and develop

[dpdk-dev] [PATCH v4 4/8] net/mlx5: extend NIC attributes query via DevX

2019-07-21 Thread Viacheslav Ovsiienko
This patch extends the NIC attributes query via DevX. The appropriate interface structures are borrowed from kernel driver headers and DevX calls are added to mlx5_devx_cmd_query_hca_attr() routine. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.h | 5 ++ drivers/net/m

[dpdk-dev] [PATCH v4 5/8] net/mlx5: add Tx datapath configuration and setup

2019-07-21 Thread Viacheslav Ovsiienko
This patch updates the Tx datapath control and configuration structures and code for mananging Tx datapath settings. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 123 + drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_rxtx.c | 4 +-

[dpdk-dev] [PATCH v4 3/8] net/mlx5: update Tx datapath definitions

2019-07-21 Thread Viacheslav Ovsiienko
This patch updates Tx datapath definitions, mostly hardware related. The Tx descriptor structures are redefined with required fields, size definitions are renamed to reflect the meanings in more appropriate way. This is a preparation step before introducing the new Tx datapath implementation. Sign

[dpdk-dev] [PATCH v4 7/8] net/mlx5: implement Tx burst template

2019-07-21 Thread Viacheslav Ovsiienko
This patch adds the implementation of tx_burst routine template. The template supports all Tx offloads and multiple optimized tx_burst routines can be generated by compiler from this one. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 2958

[dpdk-dev] [PATCH v4 8/8] net/mlx5: report supported max number of mbuf segments

2019-07-21 Thread Viacheslav Ovsiienko
This patch fills the tx_desc_lim.nb_seg_max and tx_desc_lim.nb_mtu_seg_max fields of rte_eth_dev_info structure to report thee maximal number of packet segments, requested inline data configuration is taken into account in conservative way. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx

[dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-21 Thread Viacheslav Ovsiienko
Mellanox NICs support the wide set of Tx offloads. The supported offloads are reported by the mlx5 PMD in rte_eth_dev_info tx_offload_capa field. An application may choose any combination of supported offloads and configure the device appropriately. Some of Tx offloads may be not requested by appli

[dpdk-dev] [PATCH v2 0/2] net/mlx5: cache the associated network device ifindex

2019-07-21 Thread Viacheslav Ovsiienko
In mlx5 PMD the associated device index is retrieved via Netlink request to underlying Infiniband device driver. This network device index is permanent throughout the lifetime of device. We do not spawn the rte_eth_dev ports without associated network device, and if network device is being unbound

[dpdk-dev] [PATCH v2 2/2] Revert "net/mlx5: fix master device Netlink socket sharing"

2019-07-21 Thread Viacheslav Ovsiienko
This reverts commit e28111ac9864af09e826241a915dfff87a9c00ad. The netlink requests are replaced by ifindex caching and not needed anymore. Signed-off-by: Viacheslav Ovsiienko Fixes: e28111ac9864 ("net/mlx5: fix master device Netlink socket sharing") --- drivers/net/mlx5/mlx5.h| 6 ---

[dpdk-dev] [PATCH v2 1/2] net/mlx5: cache the associated network device ifindex

2019-07-21 Thread Viacheslav Ovsiienko
The associated device index is retrieved via Netlink request to underlying Infiniband device driver. This network device index is permanent throughout the lifetime of device. We do not spawn the rte_eth_dev ports without associated network device, and if network device is being unbound we get the r

Re: [dpdk-dev] [PATCH] rte_ether: force format string for unformat_addr

2019-07-21 Thread Aaron Conole
Ferruh Yigit writes: > On 7/17/2019 7:42 PM, Stephen Hemminger wrote: >> On Wed, 10 Jul 2019 16:31:59 -0400 >> Aaron Conole wrote: >> >>> Stephen Hemminger writes: >>> On Wed, 10 Jul 2019 15:13:02 -0400 Aaron Conole wrote: > Stephen Hemminger writes: > >> On W

Re: [dpdk-dev] [v2] net/e1000: fix buffer overrun while i219 processing DMA transactions

2019-07-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Xiao > Sent: Sunday, July 21, 2019 1:02 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei > ; Zhang, Qi Z ; Zhang, Xiao > ; sta...@dpdk.org > Subject: [v2] net/e1000: fix buffer overrun while i219 processing DMA > transactions > > Intel® 100/200 Ser

Re: [dpdk-dev] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary

2019-07-21 Thread Ogawa Yasufumi
2019年7月12日(金) 11:22 Yasufumi Ogawa : > On 2019/07/11 22:14, Burakov, Anatoly wrote: > > On 11-Jul-19 12:57 PM, Yasufumi Ogawa wrote: > >> On 2019/07/11 19:53, Burakov, Anatoly wrote: > >>> On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote: > From: Yasufumi Ogawa > > >>> <...> > >>> > >>>

[dpdk-dev] [Bug 334] ConnectX-4/mlx5 crashes under high load in rxq_cq_decompress_v()

2019-07-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=334 Bug ID: 334 Summary: ConnectX-4/mlx5 crashes under high load in rxq_cq_decompress_v() Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: UNCONF

Re: [dpdk-dev] [PATCH] net/ice: fix unsafe tailq element removal

2019-07-21 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Friday, July 19, 2019 1:28 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/ice: fix unsafe tailq element removal > > TAILQ_FOREACH macro is not safe to remove elements during iterating tailq > lists. Replace it with TAILQ

[dpdk-dev] [v6] net/e1000: fix i219 hang on reset/close

2019-07-21 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. This state can be detected by configure status by bit 8 in register. If the bit is set and there are pending descriptors in one of the rings, we must flush them before reset or close. Cc: sta...@dpdk.org

Re: [dpdk-dev] [v6] net/e1000: fix i219 hang on reset/close

2019-07-21 Thread Ye Xiaolong
On 07/22, Xiao Zhang wrote: >Unit hang may occur if multiple descriptors are available in the rings >during reset or close. This state can be detected by configure status >by bit 8 in register. If the bit is set and there are pending >descriptors in one of the rings, we must flush them before reset

Re: [dpdk-dev] [v6] net/e1000: fix i219 hang on reset/close

2019-07-21 Thread Zhang, Xiao
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, July 22, 2019 5:27 PM > To: Zhang, Xiao > Cc: dev@dpdk.org; Lu, Wenzhuo ; Zhao1, Wei > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [v6] net/e1000: fix i219 hang on reset/close > > On 07/22, Xiao Zhang wrote: > >Unit hang may occ

[dpdk-dev] [v7] net/e1000: fix i219 hang on reset/close

2019-07-21 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. This state can be detected by configure status by bit 8 in register. If the bit is set and there are pending descriptors in one of the rings, we must flush them before reset or close. Fixes: 80580344("e10

Re: [dpdk-dev] [PATCH v4 3/8] net/mlx5: update Tx datapath definitions

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch updates Tx datapath definitions, mostly hardware related. > The Tx descriptor structures are redefined with required fields, > size definitions are renamed to reflect the meanings in more > appropriate way. This is a pre

Re: [dpdk-dev] [PATCH v4 1/8] net/mlx5: remove Tx datapath implementation

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch removes the existing Tx datapath code > as preparation step before introducing the new > implementation. The following entities are being > removed: > > - deprecated devargs support > - tx_burst() routines > - related

Re: [dpdk-dev] [PATCH v4 2/8] net/mlx5: add Tx datapath related devargs

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch introduces new mlx5 PMD devarg options: > > - txq_inline_min - specifies minimal amount of data to be inlined into > WQE during Tx operations. NICs may require this minimal data amount > to operate correctly. The exac

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > Mellanox NICs support the wide set of Tx offloads. The supported > offloads are reported by the mlx5 PMD in rte_eth_dev_info tx_offload_capa > field. An application may choose any combination of supported offloads > and configure t

Re: [dpdk-dev] [PATCH v4 5/8] net/mlx5: add Tx datapath configuration and setup

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch updates the Tx datapath control and configuration > structures and code for mananging Tx datapath settings. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5.c | 123

Re: [dpdk-dev] [PATCH v4 4/8] net/mlx5: extend NIC attributes query via DevX

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch extends the NIC attributes query via DevX. > The appropriate interface structures are borrowed from > kernel driver headers and DevX calls are added to > mlx5_devx_cmd_query_hca_attr() routine. > > Signed-off-by: Viac

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: report supported max number of mbuf segments

2019-07-21 Thread Yongseok Koh
> \On Jul 21, 2019, at 7:25 AM, Viacheslav Ovsiienko > wrote: > > This patch fills the tx_desc_lim.nb_seg_max and > tx_desc_lim.nb_mtu_seg_max fields of rte_eth_dev_info > structure to report thee maximal number of packet > segments, requested inline data configuration is > taken into account in

Re: [dpdk-dev] [PATCH v4 7/8] net/mlx5: implement Tx burst template

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch adds the implementation of tx_burst routine template. > The template supports all Tx offloads and multiple optimized > tx_burst routines can be generated by compiler from this one. > > Signed-off-by: Viacheslav Ovsiienk

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: cache the associated network device ifindex

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:56 AM, Viacheslav Ovsiienko > wrote: > > The associated device index is retrieved via Netlink request to > underlying Infiniband device driver. This network device index > is permanent throughout the lifetime of device. We do not > spawn the rte_eth_dev ports without asso

Re: [dpdk-dev] [PATCH v2 2/2] Revert "net/mlx5: fix master device Netlink socket sharing"

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:56 AM, Viacheslav Ovsiienko > wrote: > > This reverts commit e28111ac9864af09e826241a915dfff87a9c00ad. > The netlink requests are replaced by ifindex caching and > not needed anymore. > > Signed-off-by: Viacheslav Ovsiienko > Fixes: e28111ac9864 ("net/mlx5: fix master

Re: [dpdk-dev] [v7] net/e1000: fix i219 hang on reset/close

2019-07-21 Thread Ye Xiaolong
On 07/22, Xiao Zhang wrote: >Unit hang may occur if multiple descriptors are available in the rings >during reset or close. This state can be detected by configure status >by bit 8 in register. If the bit is set and there are pending >descriptors in one of the rings, we must flush them before reset

Re: [dpdk-dev] [EXT] Re: [PATCH v3] app/testpmd: add device related cmds

2019-07-21 Thread Hemant Agrawal
HI, > On 7/18/2019 6:27 AM, Nithin Kumar Dabilpuram wrote: > > Hi Ferruh, > > > > On 7/17/2019 10:21 PM, Ferruh Yigit wrote: > >> External Email > >> > >> - > >> - On 7/17/2019 1:30 PM, Nithin Dabilpuram wrote: > >>> With the lates

Re: [dpdk-dev] [EXT] Re: [PATCH v3] app/testpmd: add device related cmds

2019-07-21 Thread Nithin Kumar Dabilpuram
On 7/22/2019 11:31 AM, Hemant Agrawal wrote: > HI, >> On 7/18/2019 6:27 AM, Nithin Kumar Dabilpuram wrote: >>> Hi Ferruh, >>> >>> On 7/17/2019 10:21 PM, Ferruh Yigit wrote: External Email - - On 7/17/2019 1:30

[dpdk-dev] [v8] net/e1000: fix i219 hang on reset/close

2019-07-21 Thread Xiao Zhang
Unit hang may occur if multiple descriptors are available in the rings during reset or close. This state can be detected by configure status by bit 8 in register. If the bit is set and there are pending descriptors in one of the rings, we must flush them before reset or close. Fixes: 80580344("e10

[dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error

2019-07-21 Thread Wei Zhao
There is a bug in function ixgbevf_dev_info_get(), it do not contain the reta table size get function for vf port, and this will cause error when update reta for x550 vf port. Cc: sta...@dpdk.org Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info") Signed-off-by: wei zhao ---

[dpdk-dev] [PATCH 2/3] bus/fslmc: fix to remove err print for non-fslmc devices

2019-07-21 Thread Hemant Agrawal
This patch removes the unneccessary err prints when using non-dpaa2 devices. Fixes: e67a61614d0b ("bus/fslmc: support device iteration") Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/fslmc_bus

[dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler

2019-07-21 Thread Hemant Agrawal
fslmc_vfio.c:387:36: note: format string is defined here DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n", format ‘%llx’ expects argument of type ‘long long unsigned int’ argument 6 has type ‘__u64 {aka long unsigned int}’ Fixes: 2b5fa25708cf ("mempool/dpaa2: map external memory with VF

[dpdk-dev] [PATCH 1/3] bus/dpaa: fix to remove err print for non-dpaa devices

2019-07-21 Thread Hemant Agrawal
This patch removes the unneccessary err prints when using non-dpaa devices. Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops") Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/driver

Re: [dpdk-dev] [PATCH v3 0/5] FSLMC bus enchancements

2019-07-21 Thread Hemant Agrawal
Hi Ferruh, > > On 7/16/2019 2:36 PM, Thomas Monjalon wrote: > > 16/07/2019 13:40, Ferruh Yigit: > >> On 7/15/2019 10:53 PM, Thomas Monjalon wrote: > >>> 15/07/2019 10:44, Hemant Agrawal: > Nipun Gupta (1): > bus/fslmc: use cinh read for eqcr ci on ls1088 platform > > Sachin