Hi,
On Wed, Jul 10, 2019 at 05:14:33PM +, Wang, Haiyue wrote:
> Hi,
>
> Sounds cool, just have some questions inline.
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz
> > Sent: Wednesday, July 10, 2019 17:29
> > To: dev@dpdk.org
> > Subje
On Wed, Jul 10, 2019 at 10:49:17AM -0700, Stephen Hemminger wrote:
> On Wed, 10 Jul 2019 11:29:07 +0200
> Olivier Matz wrote:
>
> > /**
> > * Indicate that the metadata field in the mbuf is in use.
> > @@ -738,6 +741,8 @@ struct rte_mbuf {
> > */
> > struct rte_mbuf_ext_shared_info *s
On Wed, Jul 10, 2019 at 04:37:46PM +, Yongseok Koh wrote:
>
> > On Jul 10, 2019, at 5:26 AM, Thomas Monjalon wrote:
> >
> > 10/07/2019 14:01, Bruce Richardson:
> >> On Wed, Jul 10, 2019 at 12:07:43PM +0200, Olivier Matz wrote:
> >>> On Wed, Jul 10, 2019 at 10:55:34AM +0100, Bruce Richardson
On 7/10/2019 9:09 PM, Ferruh Yigit wrote:
> On 6/25/2019 4:04 PM, Yangchao Zhou wrote:
>> va2pa depends on the physical address and virtual address offset of
>> current mbuf. It may get the wrong physical address of next mbuf which
>> allocated in another hugepage segment.
>>
>> In rte_mempool_popu
Hi Keith,
On Wed, Jul 10, 2019 at 06:12:16PM +, Wiles, Keith wrote:
>
>
> > On Jul 10, 2019, at 12:49 PM, Stephen Hemminger
> > wrote:
> >
> > On Wed, 10 Jul 2019 11:29:07 +0200
> > Olivier Matz wrote:
> >
> >> /**
> >> * Indicate that the metadata field in the mbuf is in use.
> >> @@
> -Original Message-
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Thursday, July 11, 2019 15:26
> To: Wang, Haiyue
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags
>
> Hi,
>
> On Wed, Jul 10, 2019 at 05:14:33PM +, Wang, Haiyue
On Thu, Jul 11, 2019 at 12:08:09AM +0200, Thomas Monjalon wrote:
> 10/07/2019 12:52, Harman Kalra:
> > Once the library usage is over, it must be deinitialized which
> > will free the shared memory reserved during initialization.
> >
> > Observed an issue while running 'metrics_autotest' continuou
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, July 11, 2019 8:42 AM
> To: Jerin Jacob Kollanukkaran ; Nithin Kumar
> Dabilpuram ; Vamsi Krishna Attunuru
>
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [EXT] [PATCH] octeontx2: do not put escape sequences in log
> ---
queue= parameter does not exist.
It might have been the previous name of the queue_count parameter, but
anyway, the default value 1 for the number of queues works fine.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
doc/guides/nics
On Thu, Jul 11, 2019 at 08:04:00AM +, Wang, Haiyue wrote:
> > -Original Message-
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, July 11, 2019 15:26
> > To: Wang, Haiyue
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and f
https://bugs.dpdk.org/show_bug.cgi?id=289
Thomas Monjalon (tho...@monjalon.net) changed:
What|Removed |Added
CC||tho...@monjalon.net
> -Original Message-
> From: Olivier Matz [mailto:olivier.m...@6wind.com]
> Sent: Thursday, July 11, 2019 16:21
> To: Wang, Haiyue
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags
>
> On Thu, Jul 11, 2019 at 08:04:00AM +, Wang, Haiyue wrote:
>
11/07/2019 10:12, Harman Kalra:
> On Thu, Jul 11, 2019 at 12:08:09AM +0200, Thomas Monjalon wrote:
> > "
> > I would vote for not backporting this new API.
> > "
> >
> > In case it is not clear, this comment means you should not Cc
> > sta...@dpdk.org
>
> I added CC because of the following comm
On 2019/7/9 上午1:13, Marvin Liu wrote:
In fast enqueue function, will first check whether descriptors are
cache aligned. Fast enqueue function will check prerequisites in the
beginning. Fast enqueue function do not support chained mbufs, normal
function will handle that.
Signed-off-by: Marvin L
> -Original Message-
> From: Pei, Andy
> Sent: Thursday, July 11, 2019 2:39 PM
> To: dev@dpdk.org
> Cc: Pei, Andy ; Zhang, Qi Z ; Wu,
> Jingjing ; Xing, Beilei ; Yigit,
> Ferruh ; Xu, Rosen ; Ye,
> Xiaolong ; Zhang, Roy Fan
> ; sta...@dpdk.org
> Subject: [PATCH v7] net/i40e: i40e get link
All the functionality of the legacy code path in now available in
the librte_ipsec library. It is planned to deprecate the legacy
code path in the 19.11 release and remove the legacy code path in
the 20.02 release.
Signed-off-by: Bernard Iremonger
---
doc/guides/rel_notes/deprecation.rst | 5 +++
Hi,
> -Original Message-
> From: dev On Behalf Of Xiaoyu Min
> Sent: Tuesday, July 9, 2019 1:59 PM
> To: Adrien Mazarguil ; Ori Kam
> ; Slava Ovsiienko ;
> Thomas Monjalon
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v9 0/2] match on GRE's key
>
> This series patchs are based on RFC [
On 11-Jul-19 3:22 AM, Takeshi Yoshimura wrote:
The commit db90b4969e2e ("vfio: retry creating sPAPR DMA window")
introduced a build breakage on old Linux. Linux <4.2 does not define ddw in
struct vfio_iommu_spapr_tce_info. Without ddw, we cannot change window size
and so should give up the creati
10/07/2019 11:29, Olivier Matz:
> Many features require to store data inside the mbuf. As the room in mbuf
> structure is limited, it is not possible to have a field for each
> feature. Also, changing fields in the mbuf structure can break the API
> or ABI.
>
> This commit addresses these issues,
Once the library usage is over, it must be deinitialized which
will free the shared memory reserved during initialization.
Observed an issue while running 'metrics_autotest' continuously
without quiting. For the first run 'metrics_autotest' passes
all test cases but second run onwards first test c
Issue is observed while running 'metrics_autotest' continuously
without quiting. During first execution all test cases pass but
second run onwards first test case fails as library is already
initialized.
To resolve, introduced a new API to deinitialise the library
after all test cases are executed
11/07/2019 11:17, Burakov, Anatoly:
> On 11-Jul-19 3:22 AM, Takeshi Yoshimura wrote:
> > The commit db90b4969e2e ("vfio: retry creating sPAPR DMA window")
> > introduced a build breakage on old Linux. Linux <4.2 does not define ddw in
> > struct vfio_iommu_spapr_tce_info. Without ddw, we cannot cha
On 2019/07/09 19:26, Burakov, Anatoly wrote:
On 09-Jul-19 11:24 AM, Burakov, Anatoly wrote:
On 09-Jul-19 11:22 AM, Yasufumi Ogawa wrote:
Hi Anatoly,
On 2019/07/05 17:53, Burakov, Anatoly wrote:
On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wrote:
From: Yasufumi Ogawa
In secondary_msl_
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Thursday, July 11, 2019 4:35 PM
> To: Liu, Yong ; Bie, Tiwei ;
> maxime.coque...@redhat.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue
> function
>
>
> On 2019/
On 11-Jul-19 10:37 AM, Yasufumi Ogawa wrote:
On 2019/07/09 19:26, Burakov, Anatoly wrote:
On 09-Jul-19 11:24 AM, Burakov, Anatoly wrote:
On 09-Jul-19 11:22 AM, Yasufumi Ogawa wrote:
Hi Anatoly,
On 2019/07/05 17:53, Burakov, Anatoly wrote:
On 16-Apr-19 4:43 AM, ogawa.yasuf...@lab.ntt.co.jp wr
On 2019/7/11 下午5:37, Liu, Yong wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Thursday, July 11, 2019 4:35 PM
To: Liu, Yong ; Bie, Tiwei ;
maxime.coque...@redhat.com; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enque
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Thursday, July 11, 2019 12:11 PM
> To: Liu, Yong ; Bie, Tiwei ;
> maxime.coque...@redhat.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqueue
> function
>
>
> On 2019
On 2019/7/11 下午5:49, Liu, Yong wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Thursday, July 11, 2019 12:11 PM
To: Liu, Yong ; Bie, Tiwei ;
maxime.coque...@redhat.com; dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 02/13] add vhost packed ring fast enqu
On 19-07-10 09:04, Stephen Hemminger wrote:
> External Email
>
> --
> On Wed, 10 Jul 2019 16:46:30 +0200
> wrote:
>
> >
> > +#define PMD_LOG_ERRNO(level, fmt, args...) \
> > + rte_log(RTE_LOG_ ## level, af_packet_logtype, \
This patchset refactors the dpdk qos sched library to allow flexibile
configuration of the pipe traffic classes and queue sizes.
Currently, each pipe has 16 queues hardwired into 4 TCs scheduled with
strict priority, and each TC has exactly with 4 queues that are
scheduled with Weighted Fair Queui
Add support for zero queue sizes of the traffic classes. The queues
which are not used can be set to zero size. This helps in reducing
memory footprint of the hierarchical scheduler.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
lib/librte_sche
Allow setting the maximum number of pipe profiles in run time.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
lib/librte_sched/rte_sched.c | 8 +---
lib/librte_sched/rte_sched.h | 2 ++
2 files changed, 7 insertions(+), 3 deletions(-)
diff
Change the traffic class 3 related params name to best-effort(be)
traffic class.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
lib/librte_sched/rte_sched.c | 48 ++--
1 file changed, 24 insertions(+), 24 deletion
All higher priority traffic classes contain only one queue, thus
remove wrr function for them. The lowest priority best-effort
traffic class conitnue to have multiple queues and packet are
scheduled from its queues using wrr function.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
S
Improve doxygen comments.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
lib/librte_sched/rte_sched.h | 145 ++-
1 file changed, 93 insertions(+), 52 deletions(-)
diff --git a/lib/librte_sched/rte_sched.h b/lib/l
Update softnic tm function for configuration flexiblity of pipe
traffic classes and queues size.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
drivers/net/softnic/rte_eth_softnic.c | 131 ++
drivers/net/softnic/rte_eth_softnic_cli.c
Replace hard-coded numbers for reporting errors with
error messages.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
lib/librte_sched/rte_sched.c | 295 ++-
1 file changed, 221 insertions(+), 74 deletions(-)
diff
Update ip pipeline sample app for configuration flexiblity of
pipe traffic classes and queues.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
examples/ip_pipeline/cli.c | 45 +++---
examples/ip_pipeline/tmgr.c
update unit tests for configuration flexibility of pipe traffic
classes and queues size.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
app/test/test_sched.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/app/test
Update qos sched sample app for configuration flexibility of
pipe traffic classes and queues.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
examples/qos_sched/app_thread.c | 9 +-
examples/qos_sched/cfg_file.c | 119 +---
examples/q
Remove unused macros from the library, and update release
notes.
Signed-off-by: Jasvinder Singh
Signed-off-by: Abraham Tovar
Signed-off-by: Lukasz Krakowiak
---
doc/guides/rel_notes/release_19_08.rst | 10 +-
lib/librte_sched/rte_sched.h | 10 --
2 files changed, 9 in
Minutes 11 July 2019
Agenda:
* Release Dates
* RC1 Status
* Subtrees
* OvS
* Opens
Participants:
* Arm
* Debian/Microsoft
* Intel
* Mellanox
* Red Hat
Release Dates
-
* v19.08 dates:
* RC1 is released on Monday 08 July
* https://mails.dpdk.org/archives/a
From: Yasufumi Ogawa
In secondary_msl_create_walk(), it creates a file for fbarrays with its
PID for reserving unique name among secondary processes. However, it
does not work if secondary is run as app container because each of
containerized secondary has PID 1. To reserve unique name, use hostn
From: Yasufumi Ogawa
In secondary_msl_create_walk(), it creates a file for fbarrays with its
PID for reserving unique name among secondary processes. However, it
does not work if secondary is run as app container because each of
containerized secondary has PID 1. To reserve unique name, use hostn
On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote:
From: Yasufumi Ogawa
In secondary_msl_create_walk(), it creates a file for fbarrays with its
PID for reserving unique name among secondary processes. However, it
does not work if secondary is run as app container because each of
containerized se
> -Original Message-
> From: Nithin Dabilpuram
> Sent: Wednesday, July 10, 2019 10:32 PM
> To: Jerin Jacob Kollanukkaran ; Nithin Kumar
> Dabilpuram ; Vamsi Krishna Attunuru
> ; John McNamara ;
> Marko Kovacevic ; Pavan Nikhilesh
> Bhagavatula ; Kiran Kumar Kokkilagadda
>
> Cc: dev@dpdk.o
On 2019/07/11 19:53, Burakov, Anatoly wrote:
On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote:
From: Yasufumi Ogawa
<...>
+ if (getpid() == 1) {
+ FILE *hn_fp;
+ hn_fp = fopen("/etc/hostname", "r");
+ if (hn_fp == NULL) {
+ RTE_LOG(ERR, EAL,
+
> -Original Message-
> From: Bie, Tiwei
> Sent: Thursday, July 11, 2019 12:08 PM
> To: Yu, Jin
> Cc: dev@dpdk.org; Liu, Changpeng ;
> maxime.coque...@redhat.com; Wang, Zhihong
> Subject: Re: [PATCH v2 2/2] vhost: Add vhost-user-blk example which
> support inflight
>
> On Thu, Jul 11, 2
'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
that case will be wrong and some values can cause buffer overflow
in destination mbuf data.
Signed-off-by: Ferruh Yigit
---
kernel/linux/kni/kni_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/
Hi all,
I have developed a multi-process app and am struggling to fix an error
while adding PMD from secondary process with hotplug feature. As we
reported in [1], I think it is because initializing hogplugged device is
changed to be done by primary first, then secondary. However,
initialization i
On Mon, Jul 08, 2019 at 06:35:25PM +0200, Thomas Monjalon wrote:
> 05/07/2019 15:58, Olivier Matz:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> > use "readlink -f", it should not have any impact in these cases.
> > - "sed -ri" is invalid on freebsd and should be replaced by
On 11-Jul-19 12:57 PM, Yasufumi Ogawa wrote:
On 2019/07/11 19:53, Burakov, Anatoly wrote:
On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote:
From: Yasufumi Ogawa
<...>
+ if (getpid() == 1) {
+ FILE *hn_fp;
+ hn_fp = fopen("/etc/hostname", "r");
+ if (hn_fp == NULL) {
This patch series add new RSA CRT key based test cases,
improve code organization and also rebase it to latest changes.
It covers following changes:
* Add crt key based rsa sign/verify, enc/decrypt test cases
* Move common code of enqueue/dequeue into separate function
* Configure device with ff_d
Move common code of enqueue/dequeue into separate functions.
Signed-off-by: Kanaka Durga Kotamarthy
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 413 -
1 file changed, 199 insertions(+), 214 deletions(-)
dif
Added RSA sign/verify and enc/dec tests for RSA
key type CRT(quintuple) and associated test vectors.
Signed-off-by: Kanaka Durga Kotamarthy
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
app/test/test_cryptodev_asym.c | 97 ++
app/test/test_cr
Hello Everyone,
I have figured out the DPDK version , i.e 18.11.2 , where LSC is working
fine for i40e (X722) under bond setup.
So command-line I am using is
./testpmd -c f -n 4 --vdev
'net_bonding0,mode=1,slave=:009:00.2,slave=:009:00.0,primary=:009:00.2'
-- -I
Can anybody please
https://bugs.dpdk.org/show_bug.cgi?id=319
Bug ID: 319
Summary: dpdk-i40e could not receive vlan packet whose ip_len
was bigger than 1496
Product: DPDK
Version: 19.05
Hardware: x86
OS: Linux
Statu
writes:
> From: Vamsi Attunuru
>
> eal flag autotest fails when multiple mem size flags are passed
> to --socket-mem option irrespective of RTE_MAX_NUMA_NODES.
>
> Patch fixes --socket-mem option by setting enough numbers
> of numa node mem flags based on RTE_MAX_NUMA_NODES config.
>
> Fixes: 45
On 6/27/2019 9:19 AM, Ziyang Xuan wrote:
> This patch add package sending and receiving function codes.
>
> Signed-off-by: Ziyang Xuan
Hi Ziyang,
The lgtm.com tool is reporting some errors on this patch, can you please check:
https://lgtm.com/projects/g/DPDK/dpdk/snapshot/b3d3e3a1c7ad57931c28c
In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed
without incrementing num_tx. To fix the issue, the mbuf freeing was
removed as it was not of any benefit.
Fixes: 6db141c91e1f ("pcap: support jumbo frames")
Cc: sta...@dpdk.org
Cc: tero@coriant.com
Signed-off-by: A.McLou
On Thu, Jul 11, 2019 at 06:54:31PM +0530, chetan bhasin wrote:
> Hello Everyone,
>
> I have figured out the DPDK version , i.e 18.11.2 , where LSC is working
> fine for i40e (X722) under bond setup.
>
> So command-line I am using is
> ./testpmd -c f -n 4 --vdev
> 'net_bonding0,mode=1,slave=
On 7/11/2019 2:59 PM, A.McLoughlin wrote:
> In the eth_pcap_tx() and eth_pcap_tx_dumper() functions mbufs were freed
> without incrementing num_tx. To fix the issue, the mbuf freeing was
> removed as it was not of any benefit.
>
> Fixes: 6db141c91e1f ("pcap: support jumbo frames")
> Cc: sta...@dpd
Hi,
On Tue, Jul 09, 2019 at 12:05:59PM +0100, Musatescu, Flavia wrote:
>
> On 05/07/2019 14:58, Olivier Matz wrote:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> >use "readlink -f", it should not have any impact in these cases.
> > - "sed -ri" is invalid on freebsd and s
- As "readlink -e" and "readlink -m" do not exist on freebsd,
use "readlink -f", it should not have any impact in these cases.
- "sed -ri" is invalid on freebsd and should be replaced by
"sed -ri=''"
- Use gmake instead of make.
This fixes the following command:
SYSDIR=/usr/src/sys ./devtool
> On Jul 11, 2019, at 2:53 AM, Olivier Matz wrote:
>
> Hi Keith,
>
> On Wed, Jul 10, 2019 at 06:12:16PM +, Wiles, Keith wrote:
>>
>>
>>> On Jul 10, 2019, at 12:49 PM, Stephen Hemminger
>>> wrote:
>>>
>>> On Wed, 10 Jul 2019 11:29:07 +0200
>>> Olivier Matz wrote:
>>>
/**
*
I was expecting some replies / reviews of this patch today.
10/07/2019 23:48, David Marchand:
> The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which
> was intended to mean "driver only supports VA" but had been understood
> as "driver supports both PA and VA" by most net drivers
On Thu, 11 Jul 2019 13:35:07 +0100
Ferruh Yigit wrote:
> 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
> that case will be wrong and some values can cause buffer overflow
> in destination mbuf data.
>
> Signed-off-by: Ferruh Yigit
> ---
> kernel/linux/kni/kni_net.c | 2
On 07/11, David Marchand wrote:
>queue= parameter does not exist.
>It might have been the previous name of the queue_count parameter, but
>anyway, the default value 1 for the number of queues works fine.
>
>Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>Cc: sta...@dpdk.org
>
>Signed-off-
On Thu, 11 Jul 2019 09:26:19 +0200
Olivier Matz wrote:
> For generic fields, I think they should be declared in this file. For
> instance, if we decide to replace the current m->timestamp field by a
> dynamic field, we should add like this:
>
> #define RTE_MBUF_DYN_TIMESTAMP_ID "rte_timestamp"
>
On Thu, 11 Jul 2019 09:56:32 +
Krzysztof Kanas wrote:
> On 19-07-10 09:04, Stephen Hemminger wrote:
> > External Email
> >
> > --
> > On Wed, 10 Jul 2019 16:46:30 +0200
> > wrote:
> >
> > >
> > > +#define PMD_LOG_ERRNO
On 7/4/2019 10:48 AM, Jerin Jacob Kollanukkaran wrote:
>> From: Vamsi Krishna Attunuru
>> Sent: Thursday, July 4, 2019 12:13 PM
>> To: dev@dpdk.org
>> Cc: ferruh.yi...@intel.com; olivier.m...@6wind.com;
>> arybche...@solarflare.com; Jerin Jacob Kollanukkaran ;
>> Burakov, Anatoly
>> Subject: Re
On 6/25/2019 4:56 AM, vattun...@marvell.com wrote:
> From: Vamsi Attunuru
>
> PCI related information is needed in KNI kernel module,
> since it requires iommu domain info for address
> translations(using iommu_iova_to_phys() call) when
> KNI runs in IOVA = VA mode.
>
> Signed-off-by: Vamsi Attu
On 6/25/2019 4:56 AM, vattun...@marvell.com wrote:
> From: Vamsi Attunuru
>
> Current KNI implementation operates in IOVA = PA mode,
> Patch adds support for IOVA = VA mode by addressing
> the issues with page address translations(IOVA <==> KVA).
>
> In this patch KNI application creates mempool
On 6/25/2019 4:57 AM, vattun...@marvell.com wrote:
> From: Kiran Kumar K
>
> Patch adds support for kernel module to work in IOVA = VA mode,
> the idea is to get physical address from iova address using
> iommu_iova_to_phys API and later use phys_to_virt API to
> convert the physical address to k
On Tue, 25 Jun 2019 09:27:00 +0530
wrote:
> diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
> index 1fc5eeb..b70c827 100644
> --- a/kernel/linux/kni/kni_misc.c
> +++ b/kernel/linux/kni/kni_misc.c
> @@ -294,6 +294,9 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,
>
The phys_addr concept is deprecated in rte_memzone, change it to access
iova member, and use the type 'rte_iova_t'.
Also rename the rx/tx_ring_phys_addr definitions to rx/tx_ring_dma that
matches the IOVA concept design.
Fixes: 50370662b727 ("net/ice: support device and queue ops")
Cc: sta...@dpd
The rte_vdev_drivers are declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/rte_eth_tap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 3841842f01f8..64bd049110e1 100644
-
On Thu, 11 Jul 2019 12:48:05 -0700
Stephen Hemminger wrote:
> The rte_vdev_drivers are declared twice.
> The first one is not necessary.
>
> Signed-off-by: Stephen Hemminger
Many drivers have same problem. Will send new series
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/af_packet/rte_eth_af_packet.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet/rte_eth_af_packet.c
index
The rte_vdev_drivers are declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/rte_eth_tap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 3841842f01f8..64bd049110e1 100644
-
Many drivers declare the local rte_vdev_driver structure
multiple times. This is unnecessary.
Surprised it is so common, I guess everyone copies the same code.
Stephen Hemminger (9):
net/tap: remove redundant declarations
net/af_packet: remove redundant rte_vdev_driver declaration
net/vhos
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/null/rte_eth_null.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index f1b521a7564a..31cbb84d031d 1006
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/vhost/rte_eth_vhost.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/vhost/rte_eth_vhost.c
b/drivers/net/vhost/rte_eth_vhost.c
index 0b61e37a1995..57f382c65f
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/pcap/rte_eth_pcap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 26e85183e524..7ff6dc38dc9a 1006
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
b/drivers/raw/skeleton_rawdev/skeleton_ra
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 65c2813ba1bc..eb347bce61b7 1006
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 05960cca95e
The rte_vdev_driver is declared twice.
The first one is not necessary.
Signed-off-by: Stephen Hemminger
---
drivers/net/virtio/virtio_user_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/virtio/virtio_user_ethdev.c
b/drivers/net/virtio/virtio_user_ethdev.c
index 0a57db
> On Jul 11, 2019, at 3:03 PM, Stephen Hemminger
> wrote:
>
> The rte_vdev_drivers are declared twice.
> The first one is not necessary.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/tap/rte_eth_tap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_e
The return value of function ice_flow_valid_attr should
be non-zero. This patch fixed this issue.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Yang
---
drivers/net/ice/ice_generic_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Hi, Haiyue
On 07/12, Haiyue Wang wrote:
>The phys_addr concept is deprecated in rte_memzone, change it to access
>iova member, and use the type 'rte_iova_t'.
>
It seems this issue also exists in other PMDs, like ixgbe, i40e, iavf..., do
you have plan to fix them all?
For the patch, Reviewed-by:
Hi, qiming
On 07/12, Qiming Yang wrote:
>The return value of function ice_flow_valid_attr should
>be non-zero. This patch fixed this issue.
>
Minor nit about the title, 'issue' is never needed after word 'fix', what about
net/ice: fix flow validation failure ?
And for the commit log, it's uncle
> -Original Message-
> From: Ye, Xiaolong
> Sent: Friday, July 12, 2019 16:30
> To: Wang, Haiyue
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of
> phys_addr which is
> deprecated
>
> Hi, Haiyue
>
> On 07/12, Haiyue Wang wro
On 2019/07/11 22:14, Burakov, Anatoly wrote:
On 11-Jul-19 12:57 PM, Yasufumi Ogawa wrote:
On 2019/07/11 19:53, Burakov, Anatoly wrote:
On 11-Jul-19 11:31 AM, yasufu...@gmail.com wrote:
From: Yasufumi Ogawa
<...>
+ if (getpid() == 1) {
+ FILE *hn_fp;
+ hn_fp = fopen("/etc/
Hi Xiaolong,
> -Original Message-
> From: Wang, Haiyue
> Sent: Friday, July 12, 2019 10:12
> To: Ye, Xiaolong
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1] net/ice: use rx/tx DMA iova instead of
> phys_addr which is
> deprecated
>
> > -Original Message
When a tbl8 group is getting attached to a tbl24 entry, lookup
might fail even though the entry is configured in the table.
For ex: consider a LPM table configured with 10.10.10.1/24.
When a new entry 10.10.10.32/28 is being added, a new tbl8
group is allocated and tbl24 entry is changed to point
LPM4 uses DIR24-8 method of routing info data organization.
Routing rule with prefix longer than 24 bits will be stored
in a tbl24 entry together with an associated tbl8 group.
When a tbl8 group is getting attached to a tbl24 entry, lookup
might fail even though the entry is configured in the tabl
Tests showed that the function inlining caused performance drop
on some x86 platforms with the memory ordering patches applied.
By force no-inline functions, the performance was better than
before on x86 and no impact to arm64 platforms.
Besides inlines of other functions are removed to let compil
When a tbl8 group is getting attached to a tbl24 entry, lookup
might fail even though the entry is configured in the table.
For ex: consider a LPM table configured with 10.10.10.1/24.
When a new entry 10.10.10.32/28 is being added, a new tbl8
group is allocated and tbl24 entry is changed to point
Compiler could generate non-atomic stores for whole table entry
updating. This may cause incorrect nexthop to be returned, if
the byte with valid flag is updated prior to the byte with nexthop
is updated.
Changed to use atomic store to update whole table entry.
Suggested-by: Medvedkin Vladimir
S
1 - 100 of 120 matches
Mail list logo
