On Thu, Jul 11, 2019 at 12:08:09AM +0200, Thomas Monjalon wrote: > 10/07/2019 12:52, Harman Kalra: > > Once the library usage is over, it must be deinitialized which > > will free the shared memory reserved during initialization. > > > > Observed an issue while running 'metrics_autotest' continuously > > without quiting. For the first run 'metrics_autotest' passes > > all test cases but second run onwards first test case fails > > because metrics library is already initialized during first run. > > > > Cc: sta...@dpdk.org > > > > Signed-off-by: Harman Kalra <hka...@marvell.com> > > --- > > v2: > > * Adding sta...@dpdk.org into cc as this patch falls between bug fix > > and new feature. > > v3: > > * Fixed check-git-log.sh and make doc-guides-html issues. > > Why don't you take our comments into account?
Sorry, I did not know that I have to copy ACKs and other tags. Will surely take care from next time onwards. > > Reminder 1: > " > I was waiting for an ack on this patch, > and realized that there was one already on v1. > When sending v2, you should have reported the Ack. > " > > Reminder 2: > " > Tested-by : Reshma Pattan <reshma.pat...@intel.com> > Reviewed-by: Reshma Pattan <reshma.pat...@intel.com> > Acked-by: Reshma Pattan <reshma.pat...@intel.com> > > Please keep these tags for next versions. > " Will include these in version 4. > > Reminder 3: > " > I would vote for not backporting this new API. > " > > In case it is not clear, this comment means you should not Cc sta...@dpdk.org I added CC because of the following comment from Remy: " On Mon, Feb 25, 2019 at 12:21:21PM +0000, Remy Horton wrote: > External Email > > ---------------------------------------------------------------------- > This patchset is in that grey area between new feature and bugfix so > it > might need to be CC'd to sta...@dpdk.org " Shall I remove it now? > > >
